PMD Results
The following document contains the results of PMD 5.5.1.
Files
fr/paris/lutece/plugins/identitystore/modules/cnicertifier/business/CNI.java
| Violation |
Line |
| Avoid short class names like CNI |
41–130 |
| Private field '_scan' could be made final; it is only initialized in the declaration or constructor. |
43 |
fr/paris/lutece/plugins/identitystore/modules/cnicertifier/business/MRZData.java
| Violation |
Line |
| Too many fields |
46–413 |
fr/paris/lutece/plugins/identitystore/modules/cnicertifier/business/ValidatedData.java
| Violation |
Line |
| Avoid unused private fields such as '_bBirthPlaceExists'. |
53 |
| Avoid unused private fields such as '_listBirthPlaceSimilar'. |
54 |
fr/paris/lutece/plugins/identitystore/modules/cnicertifier/service/CNICertifierService.java
| Violation |
Line |
| If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation |
79 |
fr/paris/lutece/plugins/identitystore/modules/cnicertifier/service/ScannerService.java
| Violation |
Line |
| The class 'ScannerService' has a Cyclomatic Complexity of 6 (Highest = 18). |
52–229 |
| All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. |
53–229 |
| Consider simply returning the value vs storing it in local variable 'cni' |
129 |
| New exception is thrown in catch block, original stack trace may be lost |
167 |
| The method 'handleError' has a Cyclomatic Complexity of 18. |
177–216 |
| The method handleError() has an NPath complexity of 512 |
177–216 |
fr/paris/lutece/plugins/identitystore/modules/cnicertifier/web/CNICertifierApp.java
| Violation |
Line |
| Avoid unused imports such as 'java.util.Locale' |
54 |
| Avoid unused imports such as 'java.util.Locale' |
54 |
| If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation |
113 |
| Assigning an Object to null is a code smell. Consider refactoring. |
115 |
