Fork me on GitHub

Résultats PMD

Le document suivant contient les résultats de PMD 6.13.0.

Violations By Priority

Priority 1

fr/paris/lutece/plugins/identitystore/modules/quality/rs/SuspiciousIdentityMapper.java

Rule Violation Ligne
ClassNamingConventions The utility class name 'SuspiciousIdentityMapper' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' 46–76

fr/paris/lutece/plugins/identitystore/modules/quality/rs/SuspiciousIdentityRest.java

Rule Violation Ligne
FormalParameterNamingConventions The final method parameter name 'customer_id' doesn't match '[a-z][a-zA-Z0-9]*' 214

fr/paris/lutece/plugins/identitystore/modules/quality/service/IdentityDuplicatesDaemon.java

Rule Violation Ligne
FieldNamingConventions The constant name 'clientCode' doesn't match '[A-Z][A-Z_0-9]*' 83
FieldNamingConventions The constant name 'batchSize' doesn't match '[A-Z][A-Z_0-9]*' 84
FieldNamingConventions The constant name 'purgeSize' doesn't match '[A-Z][A-Z_0-9]*' 85
FieldNamingConventions The constant name 'limitationMode' doesn't match '[A-Z][A-Z_0-9]*' 86
FieldNamingConventions The constant name 'author' doesn't match '[A-Z][A-Z_0-9]*' 89

fr/paris/lutece/plugins/identitystore/modules/quality/service/IdentityDuplicatesResolutionDaemon.java

Rule Violation Ligne
FieldNamingConventions The final field name 'MERGE_STRICT_CONNECTED' doesn't match '[a-z][a-zA-Z0-9]*' 83
FieldNamingConventions The final field name 'MERGE_STRICT_CONNECTED_AND_UNCONNECTED' doesn't match '[a-z][a-zA-Z0-9]*' 84
FieldNamingConventions The field name 'nbIdentitiesMerged' doesn't match '_[a-z][a-zA-Z0-9]*' 88

fr/paris/lutece/plugins/identitystore/modules/quality/service/SearchDuplicatesService.java

Rule Violation Ligne
FieldNamingConventions The static field name 'instance' doesn't match '_[a-z][a-zA-Z0-9]*' 52
FieldNamingConventions The final field name '_duplicateServiceElasticSearch' doesn't match '[a-z][a-zA-Z0-9]*' 53

fr/paris/lutece/plugins/identitystore/modules/quality/service/SuspiciousIdentityService.java

Rule Violation Ligne
FieldNamingConventions The final field name '_identityStoreNotifyListenerService' doesn't match '[a-z][a-zA-Z0-9]*' 81
FieldNamingConventions The final field name '_internalUserService' doesn't match '[a-z][a-zA-Z0-9]*' 82

fr/paris/lutece/plugins/identitystore/modules/quality/web/request/IdentityStoreDuplicateRuleGetRequest.java

Rule Violation Ligne
FieldNamingConventions The final field name '_nPriority' doesn't match '[a-z][a-zA-Z0-9]*' 55
FormalParameterNamingConventions The final method parameter name '_nPriority' doesn't match '[a-z][a-zA-Z0-9]*' 63

fr/paris/lutece/plugins/identitystore/modules/quality/web/request/IdentityStoreFindDuplicatesRequest.java

Rule Violation Ligne
FieldNamingConventions The final field name '_strRuleCode' doesn't match '[a-z][a-zA-Z0-9]*' 73
FieldNamingConventions The final field name '_strCustomerId' doesn't match '[a-z][a-zA-Z0-9]*' 74
FieldNamingConventions The field name 'qualifiedIdentity' doesn't match '_[a-z][a-zA-Z0-9]*' 76
FieldNamingConventions The field name 'rule' doesn't match '_[a-z][a-zA-Z0-9]*' 77

fr/paris/lutece/plugins/identitystore/modules/quality/web/request/IdentityStoreSearchDuplicatesRequest.java

Rule Violation Ligne
FieldNamingConventions The final field name '_request' doesn't match '[a-z][a-zA-Z0-9]*' 73
FieldNamingConventions The field name 'serviceContract' doesn't match '_[a-z][a-zA-Z0-9]*' 77

fr/paris/lutece/plugins/identitystore/modules/quality/web/request/IdentityStoreSuspiciousCancelExclusionRequest.java

Rule Violation Ligne
FieldNamingConventions The final field name '_request' doesn't match '[a-z][a-zA-Z0-9]*' 60
FieldNamingConventions The field name 'firstIdentity' doesn't match '_[a-z][a-zA-Z0-9]*' 62
FieldNamingConventions The field name 'secondIdentity' doesn't match '_[a-z][a-zA-Z0-9]*' 63

fr/paris/lutece/plugins/identitystore/modules/quality/web/request/IdentityStoreSuspiciousCreateRequest.java

Rule Violation Ligne
FieldNamingConventions The final field name '_request' doesn't match '[a-z][a-zA-Z0-9]*' 64
FieldNamingConventions The field name 'duplicateRule' doesn't match '_[a-z][a-zA-Z0-9]*' 66
FieldNamingConventions The field name 'identity' doesn't match '_[a-z][a-zA-Z0-9]*' 67

fr/paris/lutece/plugins/identitystore/modules/quality/web/request/IdentityStoreSuspiciousExcludeRequest.java

Rule Violation Ligne
FieldNamingConventions The final field name '_request' doesn't match '[a-z][a-zA-Z0-9]*' 60
FieldNamingConventions The field name 'firstIdentity' doesn't match '_[a-z][a-zA-Z0-9]*' 62
FieldNamingConventions The field name 'secondIdentity' doesn't match '_[a-z][a-zA-Z0-9]*' 63

fr/paris/lutece/plugins/identitystore/modules/quality/web/request/IdentityStoreSuspiciousLockRequest.java

Rule Violation Ligne
FieldNamingConventions The final field name '_request' doesn't match '[a-z][a-zA-Z0-9]*' 62
FieldNamingConventions The field name 'suspiciousIdentity' doesn't match '_[a-z][a-zA-Z0-9]*' 64

fr/paris/lutece/plugins/identitystore/modules/quality/web/request/IdentityStoreSuspiciousSearchRequest.java

Rule Violation Ligne
FieldNamingConventions The final field name '_request' doesn't match '[a-z][a-zA-Z0-9]*' 58

fr/paris/lutece/plugins/identitystore/modules/quality/web/validator/CreateSuspiciousIdentityValidator.java

Rule Violation Ligne
ClassWithOnlyPrivateConstructorsShouldBeFinal A class which only has private constructors should be final 41–65
FieldNamingConventions The static field name 'instance' doesn't match '_[a-z][a-zA-Z0-9]*' 43

fr/paris/lutece/plugins/identitystore/modules/quality/web/validator/ExcludeSuspiciousIdentityValidator.java

Rule Violation Ligne
ClassWithOnlyPrivateConstructorsShouldBeFinal A class which only has private constructors should be final 41–75
FieldNamingConventions The static field name 'instance' doesn't match '_[a-z][a-zA-Z0-9]*' 43

fr/paris/lutece/plugins/identitystore/modules/quality/web/validator/LockSuspiciousIdentityValidator.java

Rule Violation Ligne
ClassWithOnlyPrivateConstructorsShouldBeFinal A class which only has private constructors should be final 45–95
FieldNamingConventions The static field name 'instance' doesn't match '_[a-z][a-zA-Z0-9]*' 47

Priority 3

fr/paris/lutece/plugins/identitystore/modules/quality/business/DuplicatesDaemonLimitationMode.java

Rule Violation Ligne
CommentRequired Enum comments are required 5–25

fr/paris/lutece/plugins/identitystore/modules/quality/rbac/AccessSuspicionResourceIdService.java

Rule Violation Ligne
CommentRequired Header comments are required 44–90
ShortVariable Avoid variables with short names like rt 57
ShortVariable Avoid variables with short names like s 85

fr/paris/lutece/plugins/identitystore/modules/quality/rbac/AccessSuspicionsResource.java

Rule Violation Ligne
CommentRequired Header comments are required 5–25

fr/paris/lutece/plugins/identitystore/modules/quality/rs/SuspiciousIdentityMapper.java

Rule Violation Ligne
UseUtilityClass All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 47–76
CommentRequired Public method and constructor comments are required 48–74

fr/paris/lutece/plugins/identitystore/modules/quality/rs/SuspiciousIdentityRest.java

Rule Violation Ligne
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 34–269
AvoidDuplicateLiterals The String literal "Failure" appears 6 times in this file; the first occurrence is on line 101 101
AvoidDuplicateLiterals The String literal "Conflict" appears 4 times in this file; the first occurrence is on line 102 102
UseObjectForClearerAPI Rather than using a lot of String arguments, consider using a container object for those values. 104–109
AvoidDuplicateLiterals The String literal "Success" appears 4 times in this file; the first occurrence is on line 122 122
UseObjectForClearerAPI Rather than using a lot of String arguments, consider using a container object for those values. 125–131
CommentRequired Public method and constructor comments are required 125–137
AvoidDuplicateLiterals The String literal "Request body" appears 4 times in this file; the first occurrence is on line 126 126
CommentRequired Public method and constructor comments are required 146–157
UseObjectForClearerAPI Rather than using a lot of String arguments, consider using a container object for those values. 146–151
CommentRequired Public method and constructor comments are required 166–177
UseObjectForClearerAPI Rather than using a lot of String arguments, consider using a container object for those values. 166–171
UseObjectForClearerAPI Rather than using a lot of String arguments, consider using a container object for those values. 192–196
UseObjectForClearerAPI Rather than using a lot of String arguments, consider using a container object for those values. 214–219
UseObjectForClearerAPI Rather than using a lot of String arguments, consider using a container object for those values. 237–241
CommentRequired Public method and constructor comments are required 257–267
UseObjectForClearerAPI Rather than using a lot of String arguments, consider using a container object for those values. 257–261

fr/paris/lutece/plugins/identitystore/modules/quality/rs/swagger/SwaggerConfig.java

Rule Violation Ligne
CommentRequired Header comments are required 47–49

fr/paris/lutece/plugins/identitystore/modules/quality/service/IdentityDuplicatesDaemon.java

Rule Violation Ligne
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 34–298
AvoidDuplicateLiterals The String literal "dd/MM/yyyy HH:mm:ss.SSS" appears 4 times in this file; the first occurrence is on line 105 105
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 188
CyclomaticComplexity The method 'processRule(DuplicateRule, int, Set)' has a cyclomatic complexity of 16. 195–269
ConfusingTernary Avoid if (x != y) ..; else ..; 217
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 231–235
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 259

fr/paris/lutece/plugins/identitystore/modules/quality/service/IdentityDuplicatesResolutionDaemon.java

Rule Violation Ligne
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 34–357
RedundantFieldInitializer Avoid using redundant field initializer for 'nbIdentitiesMerged' 88
ConfusingTernary Avoid if (x != y) ..; else ..; 105–164
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 125
CyclomaticComplexity The method 'merge(IdentityDto, IdentityDto, String, RequestAuthor, int)' has a cyclomatic complexity of 11. 189–255
ConfusingTernary Avoid if (x != y) ..; else ..; 225–232
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 291

fr/paris/lutece/plugins/identitystore/modules/quality/service/SearchDuplicatesService.java

Rule Violation Ligne
CommentRequired Header comments are required 50–147
AvoidFieldNameMatchingMethodName Field instance has the same name as a method 52
NonThreadSafeSingleton Singleton is not thread safe 62–65

fr/paris/lutece/plugins/identitystore/modules/quality/service/SuspiciousIdentityService.java

Rule Violation Ligne
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 34–294
CommentRequired Header comments are required 69–294
UnusedPrivateField Avoid unused private fields such as 'ACCESS_SUSPICIOUS_IDENTITY_LOCK_STATUS'. 77
CommentRequired Public method and constructor comments are required 85–92
NonThreadSafeSingleton Singleton is not thread safe 87–90
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 129
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 139
PreserveStackTrace New exception is thrown in catch block, original stack trace may be lost 142
CommentRequired Public method and constructor comments are required 146–196
CyclomaticComplexity The method 'search(SuspiciousIdentitySearchRequest, String, RequestAuthor)' has a cyclomatic complexity of 13. 146–196
ConfusingTernary Avoid if (x != y) ..; else ..; 159–188
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 181
CommentRequired Public method and constructor comments are required 198–216
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 211
PreserveStackTrace New exception is thrown in catch block, original stack trace may be lost 214
CommentRequired Public method and constructor comments are required 218–249
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 230
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 236
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 244
PreserveStackTrace New exception is thrown in catch block, original stack trace may be lost 247
CommentRequired Public method and constructor comments are required 251–282
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 263
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 269
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 277
PreserveStackTrace New exception is thrown in catch block, original stack trace may be lost 280
CommentRequired Public method and constructor comments are required 284–287
CommentRequired Public method and constructor comments are required 289–293

fr/paris/lutece/plugins/identitystore/modules/quality/web/AbstractManageQualityJspBean.java

Rule Violation Ligne
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 50–106

fr/paris/lutece/plugins/identitystore/modules/quality/web/ManageSuspiciousIdentitys.java

Rule Violation Ligne
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 34–792
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 81–792
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 191
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 218
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 221
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 231
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 231
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 258
ConfusingTernary Avoid if (x != y) ..; else ..; 275
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 285
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 288
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 311
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 333
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 355
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 378
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 423
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 471
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 498
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 501
ConfusingTernary Avoid if (x != y) ..; else ..; 534
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 541
ConfusingTernary Avoid if (x != y) ..; else ..; 637
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 637
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 713
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 727
CommentRequired Public method and constructor comments are required 728–734
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 742
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 771

fr/paris/lutece/plugins/identitystore/modules/quality/web/request/IdentityStoreDuplicateRuleGetRequest.java

Rule Violation Ligne
CommentRequired Header comments are required 53–121
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 109

fr/paris/lutece/plugins/identitystore/modules/quality/web/request/IdentityStoreFindDuplicatesRequest.java

Rule Violation Ligne
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 34–185
CommentRequired Header comments are required 70–185
CommentRequired Public method and constructor comments are required 79–85

fr/paris/lutece/plugins/identitystore/modules/quality/web/request/IdentityStoreSearchDuplicatesRequest.java

Rule Violation Ligne
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 34–156
CommentRequired Header comments are required 70–156
CommentRequired Public method and constructor comments are required 79–88

fr/paris/lutece/plugins/identitystore/modules/quality/web/request/IdentityStoreSuspiciousSearchRequest.java

Rule Violation Ligne
CommentRequired Header comments are required 56–116
CommentRequired Public method and constructor comments are required 60–65

fr/paris/lutece/plugins/identitystore/modules/quality/web/validator/CreateSuspiciousIdentityValidator.java

Rule Violation Ligne
CommentRequired Header comments are required 41–65
AvoidFieldNameMatchingMethodName Field instance has the same name as a method 43
CommentRequired Public method and constructor comments are required 45–52
NonThreadSafeSingleton Singleton is not thread safe 47–50
CommentRequired Public method and constructor comments are required 58–64

fr/paris/lutece/plugins/identitystore/modules/quality/web/validator/ExcludeSuspiciousIdentityValidator.java

Rule Violation Ligne
CommentRequired Header comments are required 41–75
AvoidFieldNameMatchingMethodName Field instance has the same name as a method 43
CommentRequired Public method and constructor comments are required 45–52
NonThreadSafeSingleton Singleton is not thread safe 47–50
CommentRequired Public method and constructor comments are required 58–65
CommentRequired Public method and constructor comments are required 67–73

fr/paris/lutece/plugins/identitystore/modules/quality/web/validator/LockSuspiciousIdentityValidator.java

Rule Violation Ligne
CommentRequired Header comments are required 45–95
AvoidFieldNameMatchingMethodName Field instance has the same name as a method 47
CommentRequired Public method and constructor comments are required 49–56
NonThreadSafeSingleton Singleton is not thread safe 51–54
CommentRequired Public method and constructor comments are required 62–82
CommentRequired Public method and constructor comments are required 84–94

Priority 4

fr/paris/lutece/plugins/identitystore/modules/quality/web/request/IdentityStoreSearchDuplicatesRequest.java

Rule Violation Ligne
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.identitystore.v3.web.rs.dto.common.AttributeDto' 48

fr/paris/lutece/plugins/identitystore/modules/quality/web/request/IdentityStoreSuspiciousCancelExclusionRequest.java

Rule Violation Ligne
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.identitystore.v3.web.rs.AbstractIdentityStoreRequest' 41

fr/paris/lutece/plugins/identitystore/modules/quality/web/request/IdentityStoreSuspiciousExcludeRequest.java

Rule Violation Ligne
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.identitystore.v3.web.rs.AbstractIdentityStoreRequest' 41

fr/paris/lutece/plugins/identitystore/modules/quality/web/request/IdentityStoreSuspiciousLockRequest.java

Rule Violation Ligne
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.identitystore.v3.web.rs.AbstractIdentityStoreRequest' 43

Fichiers

fr/paris/lutece/plugins/identitystore/modules/quality/business/DuplicatesDaemonLimitationMode.java

Rule Violation Priority Ligne
CommentRequired Enum comments are required 3 5–25

fr/paris/lutece/plugins/identitystore/modules/quality/rbac/AccessSuspicionResourceIdService.java

Rule Violation Priority Ligne
CommentRequired Header comments are required 3 44–90
ShortVariable Avoid variables with short names like rt 3 57
ShortVariable Avoid variables with short names like s 3 85

fr/paris/lutece/plugins/identitystore/modules/quality/rbac/AccessSuspicionsResource.java

Rule Violation Priority Ligne
CommentRequired Header comments are required 3 5–25

fr/paris/lutece/plugins/identitystore/modules/quality/rs/SuspiciousIdentityMapper.java

Rule Violation Priority Ligne
ClassNamingConventions The utility class name 'SuspiciousIdentityMapper' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' 1 46–76
UseUtilityClass All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 3 47–76
CommentRequired Public method and constructor comments are required 3 48–74

fr/paris/lutece/plugins/identitystore/modules/quality/rs/SuspiciousIdentityRest.java

Rule Violation Priority Ligne
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 3 34–269
AvoidDuplicateLiterals The String literal "Failure" appears 6 times in this file; the first occurrence is on line 101 3 101
AvoidDuplicateLiterals The String literal "Conflict" appears 4 times in this file; the first occurrence is on line 102 3 102
UseObjectForClearerAPI Rather than using a lot of String arguments, consider using a container object for those values. 3 104–109
AvoidDuplicateLiterals The String literal "Success" appears 4 times in this file; the first occurrence is on line 122 3 122
UseObjectForClearerAPI Rather than using a lot of String arguments, consider using a container object for those values. 3 125–131
CommentRequired Public method and constructor comments are required 3 125–137
AvoidDuplicateLiterals The String literal "Request body" appears 4 times in this file; the first occurrence is on line 126 3 126
CommentRequired Public method and constructor comments are required 3 146–157
UseObjectForClearerAPI Rather than using a lot of String arguments, consider using a container object for those values. 3 146–151
CommentRequired Public method and constructor comments are required 3 166–177
UseObjectForClearerAPI Rather than using a lot of String arguments, consider using a container object for those values. 3 166–171
UseObjectForClearerAPI Rather than using a lot of String arguments, consider using a container object for those values. 3 192–196
FormalParameterNamingConventions The final method parameter name 'customer_id' doesn't match '[a-z][a-zA-Z0-9]*' 1 214
UseObjectForClearerAPI Rather than using a lot of String arguments, consider using a container object for those values. 3 214–219
UseObjectForClearerAPI Rather than using a lot of String arguments, consider using a container object for those values. 3 237–241
CommentRequired Public method and constructor comments are required 3 257–267
UseObjectForClearerAPI Rather than using a lot of String arguments, consider using a container object for those values. 3 257–261

fr/paris/lutece/plugins/identitystore/modules/quality/rs/swagger/SwaggerConfig.java

Rule Violation Priority Ligne
CommentRequired Header comments are required 3 47–49

fr/paris/lutece/plugins/identitystore/modules/quality/service/IdentityDuplicatesDaemon.java

Rule Violation Priority Ligne
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 3 34–298
FieldNamingConventions The constant name 'clientCode' doesn't match '[A-Z][A-Z_0-9]*' 1 83
FieldNamingConventions The constant name 'batchSize' doesn't match '[A-Z][A-Z_0-9]*' 1 84
FieldNamingConventions The constant name 'purgeSize' doesn't match '[A-Z][A-Z_0-9]*' 1 85
FieldNamingConventions The constant name 'limitationMode' doesn't match '[A-Z][A-Z_0-9]*' 1 86
FieldNamingConventions The constant name 'author' doesn't match '[A-Z][A-Z_0-9]*' 1 89
AvoidDuplicateLiterals The String literal "dd/MM/yyyy HH:mm:ss.SSS" appears 4 times in this file; the first occurrence is on line 105 3 105
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 188
CyclomaticComplexity The method 'processRule(DuplicateRule, int, Set)' has a cyclomatic complexity of 16. 3 195–269
ConfusingTernary Avoid if (x != y) ..; else ..; 3 217
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 3 231–235
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 259

fr/paris/lutece/plugins/identitystore/modules/quality/service/IdentityDuplicatesResolutionDaemon.java

Rule Violation Priority Ligne
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 3 34–357
FieldNamingConventions The final field name 'MERGE_STRICT_CONNECTED' doesn't match '[a-z][a-zA-Z0-9]*' 1 83
FieldNamingConventions The final field name 'MERGE_STRICT_CONNECTED_AND_UNCONNECTED' doesn't match '[a-z][a-zA-Z0-9]*' 1 84
RedundantFieldInitializer Avoid using redundant field initializer for 'nbIdentitiesMerged' 3 88
FieldNamingConventions The field name 'nbIdentitiesMerged' doesn't match '_[a-z][a-zA-Z0-9]*' 1 88
ConfusingTernary Avoid if (x != y) ..; else ..; 3 105–164
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 3 125
CyclomaticComplexity The method 'merge(IdentityDto, IdentityDto, String, RequestAuthor, int)' has a cyclomatic complexity of 11. 3 189–255
ConfusingTernary Avoid if (x != y) ..; else ..; 3 225–232
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 291

fr/paris/lutece/plugins/identitystore/modules/quality/service/SearchDuplicatesService.java

Rule Violation Priority Ligne
CommentRequired Header comments are required 3 50–147
FieldNamingConventions The static field name 'instance' doesn't match '_[a-z][a-zA-Z0-9]*' 1 52
AvoidFieldNameMatchingMethodName Field instance has the same name as a method 3 52
FieldNamingConventions The final field name '_duplicateServiceElasticSearch' doesn't match '[a-z][a-zA-Z0-9]*' 1 53
NonThreadSafeSingleton Singleton is not thread safe 3 62–65

fr/paris/lutece/plugins/identitystore/modules/quality/service/SuspiciousIdentityService.java

Rule Violation Priority Ligne
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 3 34–294
CommentRequired Header comments are required 3 69–294
UnusedPrivateField Avoid unused private fields such as 'ACCESS_SUSPICIOUS_IDENTITY_LOCK_STATUS'. 3 77
FieldNamingConventions The final field name '_identityStoreNotifyListenerService' doesn't match '[a-z][a-zA-Z0-9]*' 1 81
FieldNamingConventions The final field name '_internalUserService' doesn't match '[a-z][a-zA-Z0-9]*' 1 82
CommentRequired Public method and constructor comments are required 3 85–92
NonThreadSafeSingleton Singleton is not thread safe 3 87–90
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 129
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 139
PreserveStackTrace New exception is thrown in catch block, original stack trace may be lost 3 142
CommentRequired Public method and constructor comments are required 3 146–196
CyclomaticComplexity The method 'search(SuspiciousIdentitySearchRequest, String, RequestAuthor)' has a cyclomatic complexity of 13. 3 146–196
ConfusingTernary Avoid if (x != y) ..; else ..; 3 159–188
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 181
CommentRequired Public method and constructor comments are required 3 198–216
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 211
PreserveStackTrace New exception is thrown in catch block, original stack trace may be lost 3 214
CommentRequired Public method and constructor comments are required 3 218–249
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 230
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 236
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 244
PreserveStackTrace New exception is thrown in catch block, original stack trace may be lost 3 247
CommentRequired Public method and constructor comments are required 3 251–282
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 263
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 269
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 277
PreserveStackTrace New exception is thrown in catch block, original stack trace may be lost 3 280
CommentRequired Public method and constructor comments are required 3 284–287
CommentRequired Public method and constructor comments are required 3 289–293

fr/paris/lutece/plugins/identitystore/modules/quality/web/AbstractManageQualityJspBean.java

Rule Violation Priority Ligne
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 3 50–106

fr/paris/lutece/plugins/identitystore/modules/quality/web/ManageSuspiciousIdentitys.java

Rule Violation Priority Ligne
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 3 34–792
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 3 81–792
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 191
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 3 218
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 221
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 231
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 231
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 258
ConfusingTernary Avoid if (x != y) ..; else ..; 3 275
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 3 285
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 288
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 311
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 333
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 3 355
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 3 378
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 423
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 471
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 3 498
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 501
ConfusingTernary Avoid if (x != y) ..; else ..; 3 534
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 541
ConfusingTernary Avoid if (x != y) ..; else ..; 3 637
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 637
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 3 713
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 3 727
CommentRequired Public method and constructor comments are required 3 728–734
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 3 742
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 771

fr/paris/lutece/plugins/identitystore/modules/quality/web/request/IdentityStoreDuplicateRuleGetRequest.java

Rule Violation Priority Ligne
CommentRequired Header comments are required 3 53–121
FieldNamingConventions The final field name '_nPriority' doesn't match '[a-z][a-zA-Z0-9]*' 1 55
FormalParameterNamingConventions The final method parameter name '_nPriority' doesn't match '[a-z][a-zA-Z0-9]*' 1 63
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 109

fr/paris/lutece/plugins/identitystore/modules/quality/web/request/IdentityStoreFindDuplicatesRequest.java

Rule Violation Priority Ligne
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 3 34–185
CommentRequired Header comments are required 3 70–185
FieldNamingConventions The final field name '_strRuleCode' doesn't match '[a-z][a-zA-Z0-9]*' 1 73
FieldNamingConventions The final field name '_strCustomerId' doesn't match '[a-z][a-zA-Z0-9]*' 1 74
FieldNamingConventions The field name 'qualifiedIdentity' doesn't match '_[a-z][a-zA-Z0-9]*' 1 76
FieldNamingConventions The field name 'rule' doesn't match '_[a-z][a-zA-Z0-9]*' 1 77
CommentRequired Public method and constructor comments are required 3 79–85

fr/paris/lutece/plugins/identitystore/modules/quality/web/request/IdentityStoreSearchDuplicatesRequest.java

Rule Violation Priority Ligne
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 3 34–156
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.identitystore.v3.web.rs.dto.common.AttributeDto' 4 48
CommentRequired Header comments are required 3 70–156
FieldNamingConventions The final field name '_request' doesn't match '[a-z][a-zA-Z0-9]*' 1 73
FieldNamingConventions The field name 'serviceContract' doesn't match '_[a-z][a-zA-Z0-9]*' 1 77
CommentRequired Public method and constructor comments are required 3 79–88

fr/paris/lutece/plugins/identitystore/modules/quality/web/request/IdentityStoreSuspiciousCancelExclusionRequest.java

Rule Violation Priority Ligne
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.identitystore.v3.web.rs.AbstractIdentityStoreRequest' 4 41
FieldNamingConventions The final field name '_request' doesn't match '[a-z][a-zA-Z0-9]*' 1 60
FieldNamingConventions The field name 'firstIdentity' doesn't match '_[a-z][a-zA-Z0-9]*' 1 62
FieldNamingConventions The field name 'secondIdentity' doesn't match '_[a-z][a-zA-Z0-9]*' 1 63

fr/paris/lutece/plugins/identitystore/modules/quality/web/request/IdentityStoreSuspiciousCreateRequest.java

Rule Violation Priority Ligne
FieldNamingConventions The final field name '_request' doesn't match '[a-z][a-zA-Z0-9]*' 1 64
FieldNamingConventions The field name 'duplicateRule' doesn't match '_[a-z][a-zA-Z0-9]*' 1 66
FieldNamingConventions The field name 'identity' doesn't match '_[a-z][a-zA-Z0-9]*' 1 67

fr/paris/lutece/plugins/identitystore/modules/quality/web/request/IdentityStoreSuspiciousExcludeRequest.java

Rule Violation Priority Ligne
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.identitystore.v3.web.rs.AbstractIdentityStoreRequest' 4 41
FieldNamingConventions The final field name '_request' doesn't match '[a-z][a-zA-Z0-9]*' 1 60
FieldNamingConventions The field name 'firstIdentity' doesn't match '_[a-z][a-zA-Z0-9]*' 1 62
FieldNamingConventions The field name 'secondIdentity' doesn't match '_[a-z][a-zA-Z0-9]*' 1 63

fr/paris/lutece/plugins/identitystore/modules/quality/web/request/IdentityStoreSuspiciousLockRequest.java

Rule Violation Priority Ligne
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.identitystore.v3.web.rs.AbstractIdentityStoreRequest' 4 43
FieldNamingConventions The final field name '_request' doesn't match '[a-z][a-zA-Z0-9]*' 1 62
FieldNamingConventions The field name 'suspiciousIdentity' doesn't match '_[a-z][a-zA-Z0-9]*' 1 64

fr/paris/lutece/plugins/identitystore/modules/quality/web/request/IdentityStoreSuspiciousSearchRequest.java

Rule Violation Priority Ligne
CommentRequired Header comments are required 3 56–116
FieldNamingConventions The final field name '_request' doesn't match '[a-z][a-zA-Z0-9]*' 1 58
CommentRequired Public method and constructor comments are required 3 60–65

fr/paris/lutece/plugins/identitystore/modules/quality/web/validator/CreateSuspiciousIdentityValidator.java

Rule Violation Priority Ligne
ClassWithOnlyPrivateConstructorsShouldBeFinal A class which only has private constructors should be final 1 41–65
CommentRequired Header comments are required 3 41–65
AvoidFieldNameMatchingMethodName Field instance has the same name as a method 3 43
FieldNamingConventions The static field name 'instance' doesn't match '_[a-z][a-zA-Z0-9]*' 1 43
CommentRequired Public method and constructor comments are required 3 45–52
NonThreadSafeSingleton Singleton is not thread safe 3 47–50
CommentRequired Public method and constructor comments are required 3 58–64

fr/paris/lutece/plugins/identitystore/modules/quality/web/validator/ExcludeSuspiciousIdentityValidator.java

Rule Violation Priority Ligne
CommentRequired Header comments are required 3 41–75
ClassWithOnlyPrivateConstructorsShouldBeFinal A class which only has private constructors should be final 1 41–75
FieldNamingConventions The static field name 'instance' doesn't match '_[a-z][a-zA-Z0-9]*' 1 43
AvoidFieldNameMatchingMethodName Field instance has the same name as a method 3 43
CommentRequired Public method and constructor comments are required 3 45–52
NonThreadSafeSingleton Singleton is not thread safe 3 47–50
CommentRequired Public method and constructor comments are required 3 58–65
CommentRequired Public method and constructor comments are required 3 67–73

fr/paris/lutece/plugins/identitystore/modules/quality/web/validator/LockSuspiciousIdentityValidator.java

Rule Violation Priority Ligne
CommentRequired Header comments are required 3 45–95
ClassWithOnlyPrivateConstructorsShouldBeFinal A class which only has private constructors should be final 1 45–95
AvoidFieldNameMatchingMethodName Field instance has the same name as a method 3 47
FieldNamingConventions The static field name 'instance' doesn't match '_[a-z][a-zA-Z0-9]*' 1 47
CommentRequired Public method and constructor comments are required 3 49–56
NonThreadSafeSingleton Singleton is not thread safe 3 51–54
CommentRequired Public method and constructor comments are required 3 62–82
CommentRequired Public method and constructor comments are required 3 84–94