The following document contains the results of PMD 5.3.5.
| Violation | Line |
|---|---|
| Returning '_iconContent' may expose an internal array. | 196 |
| The user-supplied array 'iconContent' is stored directly. | 205 |
| Violation | Line |
|---|---|
| Use explicit scoping instead of the default package private level | 39 |
| Use explicit scoping instead of the default package private level | 40 |
| Violation | Line |
|---|---|
| Use explicit scoping instead of the default package private level | 68 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 289 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 341 |
| Violation | Line |
|---|---|
| Avoid unused imports such as 'fr.paris.lutece.portal.service.util.AppPropertiesService' | 42 |
| Avoid unused imports such as 'fr.paris.lutece.portal.service.util.AppPropertiesService' | 42 |
| Violation | Line |
|---|---|
| Avoid appending characters as strings in StringBuffer.append. | 61 |
| Document empty method | 73–74 |
| Document empty method | 82–83 |
| Violation | Line |
|---|---|
| A class which only has private constructors should be final | 45–92 |
| It is a good practice to call super() in a constructor | 51–53 |
| Singleton is not thread safe | 69–73 |
| Violation | Line |
|---|---|
| Document empty constructor | 55–57 |
| Avoid unnecessary constructors - the compiler will generate these for you | 55–57 |
| Use block level rather than method level synchronization | 64–72 |
| Violation | Line |
|---|---|
| The class 'MyAppsDatabaseProvider' has a Cyclomatic Complexity of 2 (Highest = 11). | 60–278 |
| Use block level rather than method level synchronization | 78–86 |
| Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() | 162 |
| The method 'getUrlOpenMyApps' has a Cyclomatic Complexity of 11. | 199–276 |
| Violation | Line |
|---|---|
| It is a good practice to call super() in a constructor | 68–71 |
| Avoid variables with short names like rt | 78 |
| Avoid variables with short names like p | 84 |
| Violation | Line |
|---|---|
| Document empty method | 70–71 |
| Use block level rather than method level synchronization | 78–86 |
| If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 139 |
| If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 143 |
| Violation | Line |
|---|---|
| The class 'MyAppsDatabaseApp' has a Cyclomatic Complexity of 5 (Highest = 16). | 73–446 |
| If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 170 |
| Avoid reassigning parameters such as 'page' | 196 |
| If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 228 |
| If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 278 |
| The method 'getMyAppsDatabaseUserInfo' has a Cyclomatic Complexity of 16. | 355–398 |
| The method getMyAppsDatabaseUserInfo() has an NPath complexity of 261 | 355–398 |
| Violation | Line |
|---|---|
| A high number of imports can indicate a high degree of coupling within an object. | 34–679 |
| Possible God class (WMC=67, ATFD=303, TCC=0.0) | 34–679 |
| The class 'MyAppsDatabaseJspBean' has a Cyclomatic Complexity of 5 (Highest = 28). | 77–679 |
| The class 'MyAppsDatabaseJspBean' has a Modified Cyclomatic Complexity of 3 (Highest = 12). | 77–679 |
| The class 'MyAppsDatabaseJspBean' has a Standard Cyclomatic Complexity of 3 (Highest = 12). | 77–679 |
| Private field '_nDefaultItemsPerPage' could be made final; it is only initialized in the declaration or constructor. | 83 |
| Document empty constructor | 90–92 |
| Avoid unnecessary constructors - the compiler will generate these for you | 90–92 |
| It is a good practice to call super() in a constructor | 90–92 |
| If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 114 |
| If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 140 |
| Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() | 186 |
| If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 289 |
| If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 316 |
| If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 383 |
| Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 491 |
| Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 572 |
| The method 'verifyFields' has a Cyclomatic Complexity of 28. | 602–678 |
| The method verifyFields() has an NPath complexity of 294915 | 602–678 |
| The method 'verifyFields' has a Standard Cyclomatic Complexity of 12. | 602–678 |
| The method 'verifyFields' has a Modified Cyclomatic Complexity of 12. | 602–678 |
