Fork me on GitHub
Built by Maven

PMD Results

The following document contains the results of PMD 6.13.0.

Violations By Priority

Priority 1

fr/paris/lutece/plugins/mydashboard/modules/favorites/business/ICategoryDAO.java

Rule Violation Line
FormalParameterNamingConventions The method parameter name '_plugin' doesn't match '[a-z][a-zA-Z0-9]*' 87

fr/paris/lutece/plugins/mydashboard/modules/favorites/business/IFavoriteDAO.java

Rule Violation Line
FormalParameterNamingConventions The method parameter name '_plugin' doesn't match '[a-z][a-zA-Z0-9]*' 138

fr/paris/lutece/plugins/mydashboard/modules/favorites/rest/rs/Constants.java

Rule Violation Line
ClassNamingConventions The utility class name 'Constants' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' 40–53

fr/paris/lutece/plugins/mydashboard/modules/favorites/service/FavoriteService.java

Rule Violation Line
ClassWithOnlyPrivateConstructorsShouldBeFinal A class which only has private constructors should be final 55–206

fr/paris/lutece/plugins/mydashboard/modules/favorites/service/provider/ProviderFavoriteService.java

Rule Violation Line
ClassWithOnlyPrivateConstructorsShouldBeFinal A class which only has private constructors should be final 44–110

Priority 3

fr/paris/lutece/plugins/mydashboard/modules/favorites/business/Category.java

Rule Violation Line
CommentRequired Header comments are required 38–118

fr/paris/lutece/plugins/mydashboard/modules/favorites/business/CategoryDAO.java

Rule Violation Line
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 164
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 215

fr/paris/lutece/plugins/mydashboard/modules/favorites/business/FavoriteDAO.java

Rule Violation Line
TooManyMethods This class has too many methods, consider refactoring it. 48–458
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 194
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 229
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 274
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 311
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 367
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 402
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 434

fr/paris/lutece/plugins/mydashboard/modules/favorites/business/FavoriteHome.java

Rule Violation Line
CommentRequired Public method and constructor comments are required 169–172

fr/paris/lutece/plugins/mydashboard/modules/favorites/business/ICategoryDAO.java

Rule Violation Line
CommentRequired Header comments are required 40–88

fr/paris/lutece/plugins/mydashboard/modules/favorites/business/IFavoriteDAO.java

Rule Violation Line
TooManyMethods This class has too many methods, consider refactoring it. 45–140
UnnecessaryModifier Unnecessary modifier 'public' on method 'selectActivatedFavoritesList': the method is declared in an interface type 104
UnnecessaryModifier Unnecessary modifier 'public' on method 'selectProviderNameFavoritesList': the method is declared in an interface type 112
UnnecessaryModifier Unnecessary modifier 'public' on method 'countProviderNameRemoteId': the method is declared in an interface type 121
UnnecessaryModifier Unnecessary modifier 'public' on method 'selectDefaultFavoritesList': the method is declared in an interface type 128
CommentRequired Public method and constructor comments are required 138

fr/paris/lutece/plugins/mydashboard/modules/favorites/service/CategoriesSubscriptionProviderService.java

Rule Violation Line
CommentRequired Header comments are required 41–95
RedundantFieldInitializer Avoid using redundant field initializer for '_instance' 45
NonThreadSafeSingleton Singleton is not thread safe 52–56
ControlStatementBraces This statement should have braces 56
UncommentedEmptyMethodBody Document empty method body 93–94

fr/paris/lutece/plugins/mydashboard/modules/favorites/service/FavoriteService.java

Rule Violation Line
RedundantFieldInitializer Avoid using redundant field initializer for '_instance' 63
NonThreadSafeSingleton Singleton is not thread safe 76–84

fr/paris/lutece/plugins/mydashboard/modules/favorites/service/FavoritesSubscriptionProviderService.java

Rule Violation Line
RedundantFieldInitializer Avoid using redundant field initializer for '_instance' 49
NonThreadSafeSingleton Singleton is not thread safe 56–60
ControlStatementBraces This statement should have braces 60
UncommentedEmptyMethodBody Document empty method body 92–93

fr/paris/lutece/plugins/mydashboard/modules/favorites/service/provider/IFavoriteProvider.java

Rule Violation Line
CommentRequired Header comments are required 39–43
UnnecessaryModifier Unnecessary modifier 'public' on method 'getProvideFavorites': the method is declared in an interface type 41
CommentRequired Public method and constructor comments are required 41
UnnecessaryModifier Unnecessary modifier 'public' on method 'getFavoriteProviderName': the method is declared in an interface type 42
CommentRequired Public method and constructor comments are required 42

fr/paris/lutece/plugins/mydashboard/modules/favorites/service/provider/MokeFavoriteProvider.java

Rule Violation Line
CommentRequired Header comments are required 41–81
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 49

fr/paris/lutece/plugins/mydashboard/modules/favorites/service/provider/ProviderFavoriteService.java

Rule Violation Line
CommentRequired Header comments are required 44–110
RedundantFieldInitializer Avoid using redundant field initializer for '_instance' 46
NonThreadSafeSingleton Singleton is not thread safe 59–67
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 76
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 76
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 91
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 91
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 95
UseCollectionIsEmpty Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 103

fr/paris/lutece/plugins/mydashboard/modules/favorites/util/UrlUtil.java

Rule Violation Line
CommentRequired Header comments are required 38–54
UseUtilityClass All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 39–54
CommentRequired Public method and constructor comments are required 47–53
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 50

fr/paris/lutece/plugins/mydashboard/modules/favorites/web/CategoriesXPage.java

Rule Violation Line
CommentRequired Header comments are required 54–129
CommentRequired Public method and constructor comments are required 72–102
CommentRequired Public method and constructor comments are required 105–128

fr/paris/lutece/plugins/mydashboard/modules/favorites/web/CategoryJspBean.java

Rule Violation Line
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 115
ConfusingTernary Avoid if (x != y) ..; else ..; 131
ConfusingTernary Avoid if (x != y) ..; else ..; 200–209

fr/paris/lutece/plugins/mydashboard/modules/favorites/web/FavoriteJspBean.java

Rule Violation Line
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 69–422
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 138
ConfusingTernary Avoid if (x != y) ..; else ..; 154
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 358
CommentRequired Public method and constructor comments are required 397–421
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 399
ControlStatementBraces This statement should have braces 405

fr/paris/lutece/plugins/mydashboard/modules/favorites/web/FavoritesXPage.java

Rule Violation Line
CommentRequired Header comments are required 58–240
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 58–240
CommentRequired Public method and constructor comments are required 81–108
CommentRequired Public method and constructor comments are required 111–135
CommentRequired Public method and constructor comments are required 138–165
LinguisticNaming Linguistics Antipattern - The setter 'setOrderFavorite' should not return any type except void linguistically 138–165
CommentRequired Public method and constructor comments are required 168–179
CyclomaticComplexity The method 'setOrder(List, String, Subscription)' has a cyclomatic complexity of 13. 187–221

fr/paris/lutece/plugins/mydashboard/modules/favorites/web/ManageFavoritesJspBean.java

Rule Violation Line
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 49–98
SingularField Perhaps '_nDefaultItemsPerPage' could be replaced by a local variable. 65
AddEmptyString Do not add empty strings 92

fr/paris/lutece/plugins/mydashboard/modules/favorites/web/MyDashboardCategoriesComponent.java

Rule Violation Line
CommentRequired Header comments are required 64–129
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 94
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 94
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 103

fr/paris/lutece/plugins/mydashboard/modules/favorites/web/MyDashboardFavoritesComponent.java

Rule Violation Line
CommentRequired Header comments are required 58–135
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 58–135
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 77
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 77
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 86
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 88

fr/paris/lutece/plugins/mydashboard/modules/favorites/web/MyDashboardListFavoritesComponent.java

Rule Violation Line
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 86

fr/paris/lutece/plugins/mydashboard/modules/favorites/web/includes/FavoritesInclude.java

Rule Violation Line
CommentRequired Header comments are required 22–62
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 40
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 47–50

Priority 4

fr/paris/lutece/plugins/mydashboard/modules/favorites/business/Favorite.java

Rule Violation Line
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 134–137
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 188–191

fr/paris/lutece/plugins/mydashboard/modules/favorites/web/MyDashboardCategoriesComponent.java

Rule Violation Line
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.mydashboard.modules.favorites.business.Favorite' 46
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.mydashboard.modules.favorites.service.FavoritesSubscriptionProviderService' 49

fr/paris/lutece/plugins/mydashboard/modules/favorites/web/includes/FavoritesInclude.java

Rule Violation Line
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.mydashboard.modules.favorites.service.FavoriteService' 12

Files

fr/paris/lutece/plugins/mydashboard/modules/favorites/business/Category.java

Rule Violation Priority Line
CommentRequired Header comments are required 3 38–118

fr/paris/lutece/plugins/mydashboard/modules/favorites/business/CategoryDAO.java

Rule Violation Priority Line
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 164
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 215

fr/paris/lutece/plugins/mydashboard/modules/favorites/business/Favorite.java

Rule Violation Priority Line
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 4 134–137
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 4 188–191

fr/paris/lutece/plugins/mydashboard/modules/favorites/business/FavoriteDAO.java

Rule Violation Priority Line
TooManyMethods This class has too many methods, consider refactoring it. 3 48–458
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 194
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 229
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 274
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 311
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 367
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 402
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 434

fr/paris/lutece/plugins/mydashboard/modules/favorites/business/FavoriteHome.java

Rule Violation Priority Line
CommentRequired Public method and constructor comments are required 3 169–172

fr/paris/lutece/plugins/mydashboard/modules/favorites/business/ICategoryDAO.java

Rule Violation Priority Line
CommentRequired Header comments are required 3 40–88
FormalParameterNamingConventions The method parameter name '_plugin' doesn't match '[a-z][a-zA-Z0-9]*' 1 87

fr/paris/lutece/plugins/mydashboard/modules/favorites/business/IFavoriteDAO.java

Rule Violation Priority Line
TooManyMethods This class has too many methods, consider refactoring it. 3 45–140
UnnecessaryModifier Unnecessary modifier 'public' on method 'selectActivatedFavoritesList': the method is declared in an interface type 3 104
UnnecessaryModifier Unnecessary modifier 'public' on method 'selectProviderNameFavoritesList': the method is declared in an interface type 3 112
UnnecessaryModifier Unnecessary modifier 'public' on method 'countProviderNameRemoteId': the method is declared in an interface type 3 121
UnnecessaryModifier Unnecessary modifier 'public' on method 'selectDefaultFavoritesList': the method is declared in an interface type 3 128
CommentRequired Public method and constructor comments are required 3 138
FormalParameterNamingConventions The method parameter name '_plugin' doesn't match '[a-z][a-zA-Z0-9]*' 1 138

fr/paris/lutece/plugins/mydashboard/modules/favorites/rest/rs/Constants.java

Rule Violation Priority Line
ClassNamingConventions The utility class name 'Constants' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' 1 40–53

fr/paris/lutece/plugins/mydashboard/modules/favorites/service/CategoriesSubscriptionProviderService.java

Rule Violation Priority Line
CommentRequired Header comments are required 3 41–95
RedundantFieldInitializer Avoid using redundant field initializer for '_instance' 3 45
NonThreadSafeSingleton Singleton is not thread safe 3 52–56
ControlStatementBraces This statement should have braces 3 56
UncommentedEmptyMethodBody Document empty method body 3 93–94

fr/paris/lutece/plugins/mydashboard/modules/favorites/service/FavoriteService.java

Rule Violation Priority Line
ClassWithOnlyPrivateConstructorsShouldBeFinal A class which only has private constructors should be final 1 55–206
RedundantFieldInitializer Avoid using redundant field initializer for '_instance' 3 63
NonThreadSafeSingleton Singleton is not thread safe 3 76–84

fr/paris/lutece/plugins/mydashboard/modules/favorites/service/FavoritesSubscriptionProviderService.java

Rule Violation Priority Line
RedundantFieldInitializer Avoid using redundant field initializer for '_instance' 3 49
NonThreadSafeSingleton Singleton is not thread safe 3 56–60
ControlStatementBraces This statement should have braces 3 60
UncommentedEmptyMethodBody Document empty method body 3 92–93

fr/paris/lutece/plugins/mydashboard/modules/favorites/service/provider/IFavoriteProvider.java

Rule Violation Priority Line
CommentRequired Header comments are required 3 39–43
UnnecessaryModifier Unnecessary modifier 'public' on method 'getProvideFavorites': the method is declared in an interface type 3 41
CommentRequired Public method and constructor comments are required 3 41
UnnecessaryModifier Unnecessary modifier 'public' on method 'getFavoriteProviderName': the method is declared in an interface type 3 42
CommentRequired Public method and constructor comments are required 3 42

fr/paris/lutece/plugins/mydashboard/modules/favorites/service/provider/MokeFavoriteProvider.java

Rule Violation Priority Line
CommentRequired Header comments are required 3 41–81
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 49

fr/paris/lutece/plugins/mydashboard/modules/favorites/service/provider/ProviderFavoriteService.java

Rule Violation Priority Line
CommentRequired Header comments are required 3 44–110
ClassWithOnlyPrivateConstructorsShouldBeFinal A class which only has private constructors should be final 1 44–110
RedundantFieldInitializer Avoid using redundant field initializer for '_instance' 3 46
NonThreadSafeSingleton Singleton is not thread safe 3 59–67
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 76
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 76
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 91
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 91
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 95
UseCollectionIsEmpty Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 3 103

fr/paris/lutece/plugins/mydashboard/modules/favorites/util/UrlUtil.java

Rule Violation Priority Line
CommentRequired Header comments are required 3 38–54
UseUtilityClass All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 3 39–54
CommentRequired Public method and constructor comments are required 3 47–53
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 50

fr/paris/lutece/plugins/mydashboard/modules/favorites/web/CategoriesXPage.java

Rule Violation Priority Line
CommentRequired Header comments are required 3 54–129
CommentRequired Public method and constructor comments are required 3 72–102
CommentRequired Public method and constructor comments are required 3 105–128

fr/paris/lutece/plugins/mydashboard/modules/favorites/web/CategoryJspBean.java

Rule Violation Priority Line
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 115
ConfusingTernary Avoid if (x != y) ..; else ..; 3 131
ConfusingTernary Avoid if (x != y) ..; else ..; 3 200–209

fr/paris/lutece/plugins/mydashboard/modules/favorites/web/FavoriteJspBean.java

Rule Violation Priority Line
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 3 69–422
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 138
ConfusingTernary Avoid if (x != y) ..; else ..; 3 154
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 358
CommentRequired Public method and constructor comments are required 3 397–421
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 399
ControlStatementBraces This statement should have braces 3 405

fr/paris/lutece/plugins/mydashboard/modules/favorites/web/FavoritesXPage.java

Rule Violation Priority Line
CommentRequired Header comments are required 3 58–240
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 3 58–240
CommentRequired Public method and constructor comments are required 3 81–108
CommentRequired Public method and constructor comments are required 3 111–135
CommentRequired Public method and constructor comments are required 3 138–165
LinguisticNaming Linguistics Antipattern - The setter 'setOrderFavorite' should not return any type except void linguistically 3 138–165
CommentRequired Public method and constructor comments are required 3 168–179
CyclomaticComplexity The method 'setOrder(List, String, Subscription)' has a cyclomatic complexity of 13. 3 187–221

fr/paris/lutece/plugins/mydashboard/modules/favorites/web/ManageFavoritesJspBean.java

Rule Violation Priority Line
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 3 49–98
SingularField Perhaps '_nDefaultItemsPerPage' could be replaced by a local variable. 3 65
AddEmptyString Do not add empty strings 3 92

fr/paris/lutece/plugins/mydashboard/modules/favorites/web/MyDashboardCategoriesComponent.java

Rule Violation Priority Line
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.mydashboard.modules.favorites.business.Favorite' 4 46
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.mydashboard.modules.favorites.service.FavoritesSubscriptionProviderService' 4 49
CommentRequired Header comments are required 3 64–129
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 94
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 94
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 103

fr/paris/lutece/plugins/mydashboard/modules/favorites/web/MyDashboardFavoritesComponent.java

Rule Violation Priority Line
CommentRequired Header comments are required 3 58–135
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 3 58–135
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 77
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 77
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 86
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 88

fr/paris/lutece/plugins/mydashboard/modules/favorites/web/MyDashboardListFavoritesComponent.java

Rule Violation Priority Line
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 86

fr/paris/lutece/plugins/mydashboard/modules/favorites/web/includes/FavoritesInclude.java

Rule Violation Priority Line
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.mydashboard.modules.favorites.service.FavoriteService' 4 12
CommentRequired Header comments are required 3 22–62
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 40
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 3 47–50