Fork me on GitHub

PMD Results

The following document contains the results of PMD 5.3.5.

Files

fr/paris/lutece/plugins/mydashboard/modules/identity/business/DashboardAttribute.java

Violation Line
Document empty constructor 51–54
Assigning an Object to null is a code smell. Consider refactoring. 70
Assigning an Object to null is a code smell. Consider refactoring. 71
Assigning an Object to null is a code smell. Consider refactoring. 72

fr/paris/lutece/plugins/mydashboard/modules/identity/business/DashboardIdentity.java

Violation Line
This class has a bunch of public methods and attributes 34–857
Possible God class (WMC=94, ATFD=137, TCC=0.0) 34–857
Private field '_mapAttributes' could be made final; it is only initialized in the declaration or constructor. 47

fr/paris/lutece/plugins/mydashboard/modules/identity/util/DashboardIdentityUtils.java

Violation Line
A class which only has private constructors should be final 54–258
Possible unsafe assignment to a non-final static field in a constructor. 59
Singleton is not thread safe 112–115
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 167

fr/paris/lutece/plugins/mydashboard/modules/identity/web/IdentityXPage.java

Violation Line
A high number of imports can indicate a high degree of coupling within an object. 34–884
Possible God class (WMC=73, ATFD=159, TCC=0.018461538461538463) 34–884
The class 'IdentityXPage' has a Standard Cyclomatic Complexity of 3 (Highest = 20). 77–884
The class 'IdentityXPage' has a Modified Cyclomatic Complexity of 3 (Highest = 20). 77–884
The class 'IdentityXPage' has a Cyclomatic Complexity of 3 (Highest = 21). 77–884
Private field '_lstContactModeList' could be made final; it is only initialized in the declaration or constructor. 116
Private field '_lstGenderList' could be made final; it is only initialized in the declaration or constructor. 117
Private field '_identityService' could be made final; it is only initialized in the declaration or constructor. 121
Avoid variables with short names like i 133
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 256
Assigning an Object to null is a code smell. Consider refactoring. 279
The method 'checkDashboardIdentityFields' has a Modified Cyclomatic Complexity of 20. 371–515
Avoid really long methods. 371–515
The method 'checkDashboardIdentityFields' has a Cyclomatic Complexity of 21. 371–515
The method 'checkDashboardIdentityFields' has a Standard Cyclomatic Complexity of 20. 371–515
The method checkDashboardIdentityFields() has an NPath complexity of 294912 371–515
These nested if statements could be combined 484–488
These nested if statements could be combined 494–498
The String literal "bAccept" appears 6 times in this file; the first occurrence is on line 826 826
Avoid unnecessary comparisons in boolean expressions 829
Avoid unnecessary comparisons in boolean expressions 851
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 875

fr/paris/lutece/plugins/mydashboard/modules/identity/web/MyDashboardIdentityComponent.java

Violation Line
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 88
Assigning an Object to null is a code smell. Consider refactoring. 90