SpotBugs Bug Detector Report
The following document contains the results of SpotBugs
SpotBugs Version is 4.5.3
Threshold is medium
Effort is default
Summary
| Classes |
Bugs |
Errors |
Missing Classes |
| 14 |
28 |
0 |
0 |
fr.paris.lutece.plugins.mydashboard.modules.identity.business.DashboardAttribute
| Bug |
Category |
Details |
Line |
Priority |
| fr.paris.lutece.plugins.mydashboard.modules.identity.business.DashboardAttribute.getCertificateDate() may expose internal representation by returning DashboardAttribute._dCertificateDate |
MALICIOUS_CODE |
EI_EXPOSE_REP |
207 |
Medium |
| fr.paris.lutece.plugins.mydashboard.modules.identity.business.DashboardAttribute.getExpirationDate() may expose internal representation by returning DashboardAttribute._tCertificateExpirationDate |
MALICIOUS_CODE |
EI_EXPOSE_REP |
174 |
Medium |
| new fr.paris.lutece.plugins.mydashboard.modules.identity.business.DashboardAttribute(String, String, String, String, int, Date, Date) may expose internal representation by storing an externally mutable object into DashboardAttribute._dCertificateDate |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
66 |
Medium |
| new fr.paris.lutece.plugins.mydashboard.modules.identity.business.DashboardAttribute(String, String, String, String, int, Date, Date) may expose internal representation by storing an externally mutable object into DashboardAttribute._tCertificateExpirationDate |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
65 |
Medium |
| fr.paris.lutece.plugins.mydashboard.modules.identity.business.DashboardAttribute.setCertificateDate(Date) may expose internal representation by storing an externally mutable object into DashboardAttribute._dCertificateDate |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
215 |
Medium |
| fr.paris.lutece.plugins.mydashboard.modules.identity.business.DashboardAttribute.setExpirationDate(Date) may expose internal representation by storing an externally mutable object into DashboardAttribute._tCertificateExpirationDate |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
183 |
Medium |
fr.paris.lutece.plugins.mydashboard.modules.identity.business.DashboardIdentity
| Bug |
Category |
Details |
Line |
Priority |
| fr.paris.lutece.plugins.mydashboard.modules.identity.business.DashboardIdentity.getLastUpdateDate() may expose internal representation by returning DashboardIdentity._lastUpdateDate |
MALICIOUS_CODE |
EI_EXPOSE_REP |
467 |
Medium |
| fr.paris.lutece.plugins.mydashboard.modules.identity.business.DashboardIdentity.setLastUpdateDate(Timestamp) may expose internal representation by storing an externally mutable object into DashboardIdentity._lastUpdateDate |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
475 |
Medium |
fr.paris.lutece.plugins.mydashboard.modules.identity.service.DashboardIdentityService
| Bug |
Category |
Details |
Line |
Priority |
| Incorrect lazy initialization and update of static field fr.paris.lutece.plugins.mydashboard.modules.identity.service.DashboardIdentityService._instance in fr.paris.lutece.plugins.mydashboard.modules.identity.service.DashboardIdentityService.getInstance() |
MT_CORRECTNESS |
LI_LAZY_INIT_UPDATE_STATIC |
113-115 |
Medium |
| Public static fr.paris.lutece.plugins.mydashboard.modules.identity.service.DashboardIdentityService.getInstance() may expose internal representation by returning DashboardIdentityService._instance |
MALICIOUS_CODE |
MS_EXPOSE_REP |
141 |
Medium |
fr.paris.lutece.plugins.mydashboard.modules.identity.util.DashboardIdentityUtils
| Bug |
Category |
Details |
Line |
Priority |
| Boxing/unboxing to parse a primitive fr.paris.lutece.plugins.mydashboard.modules.identity.util.DashboardIdentityUtils.needCertification(DashboardIdentity, ServiceContractSearchResponse, List, int, int) |
PERFORMANCE |
DM_BOXED_PRIMITIVE_FOR_PARSING |
260 |
High |
| fr.paris.lutece.plugins.mydashboard.modules.identity.util.DashboardIdentityUtils.getMapAttributeKey(AttributeCategory) may expose internal representation by returning DashboardIdentityUtils._mapAttributeKeyMatch |
MALICIOUS_CODE |
EI_EXPOSE_REP |
963 |
Medium |
| fr.paris.lutece.plugins.mydashboard.modules.identity.util.DashboardIdentityUtils.getMapAttributeKey(AttributeCategory) may expose internal representation by returning DashboardIdentityUtils._mapAttributeKeyMatchCoordinates |
MALICIOUS_CODE |
EI_EXPOSE_REP |
951 |
Medium |
| fr.paris.lutece.plugins.mydashboard.modules.identity.util.DashboardIdentityUtils.getMapAttributeKey(AttributeCategory) may expose internal representation by returning DashboardIdentityUtils._mapAttributeKeyMatchIdentityInformations |
MALICIOUS_CODE |
EI_EXPOSE_REP |
954 |
Medium |
| fr.paris.lutece.plugins.mydashboard.modules.identity.util.DashboardIdentityUtils.getMapAttributeKeyMatch() may expose internal representation by returning DashboardIdentityUtils._mapAttributeKeyMatch |
MALICIOUS_CODE |
EI_EXPOSE_REP |
650 |
Medium |
| Store of non serializable fr.paris.lutece.plugins.mydashboard.modules.identity.business.DashboardIdentity into HttpSession in fr.paris.lutece.plugins.mydashboard.modules.identity.util.DashboardIdentityUtils.setCurrentDashboardIdentityInSession(HttpServletRequest, DashboardIdentity) |
BAD_PRACTICE |
J2EE_STORE_OF_NON_SERIALIZABLE_OBJECT_INTO_SESSION |
672 |
High |
| Incorrect lazy initialization and update of static field fr.paris.lutece.plugins.mydashboard.modules.identity.util.DashboardIdentityUtils._instance in fr.paris.lutece.plugins.mydashboard.modules.identity.util.DashboardIdentityUtils.getInstance() |
MT_CORRECTNESS |
LI_LAZY_INIT_UPDATE_STATIC |
148-150 |
Medium |
| Public static fr.paris.lutece.plugins.mydashboard.modules.identity.util.DashboardIdentityUtils.getInstance() may expose internal representation by returning DashboardIdentityUtils._instance |
MALICIOUS_CODE |
MS_EXPOSE_REP |
175 |
Medium |
| Redundant nullcheck of dashboardIdentityFromRic, which is known to be non-null in fr.paris.lutece.plugins.mydashboard.modules.identity.util.DashboardIdentityUtils.convertToIdentityDto(DashboardIdentity, boolean, AttributeCategory) |
STYLE |
RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE |
315 |
Medium |
fr.paris.lutece.plugins.mydashboard.modules.identity.web.EditIdentityXPage
| Bug |
Category |
Details |
Line |
Priority |
| Class fr.paris.lutece.plugins.mydashboard.modules.identity.web.EditIdentityXPage defines non-transient non-serializable instance field _dashboardIdentity |
BAD_PRACTICE |
SE_BAD_FIELD |
Not available |
Medium |
| Class fr.paris.lutece.plugins.mydashboard.modules.identity.web.EditIdentityXPage defines non-transient non-serializable instance field _dashboardPropertiesGroup |
BAD_PRACTICE |
SE_BAD_FIELD |
Not available |
Medium |
| Class fr.paris.lutece.plugins.mydashboard.modules.identity.web.EditIdentityXPage defines non-transient non-serializable instance field _securityTokenService |
BAD_PRACTICE |
SE_BAD_FIELD |
Not available |
Medium |
fr.paris.lutece.plugins.mydashboard.modules.identity.web.IdentityXPage
| Bug |
Category |
Details |
Line |
Priority |
| Class fr.paris.lutece.plugins.mydashboard.modules.identity.web.IdentityXPage defines non-transient non-serializable instance field _checkdIdentity |
BAD_PRACTICE |
SE_BAD_FIELD |
Not available |
Medium |
| Class fr.paris.lutece.plugins.mydashboard.modules.identity.web.IdentityXPage defines non-transient non-serializable instance field _completionIdentity |
BAD_PRACTICE |
SE_BAD_FIELD |
Not available |
Medium |
| Class fr.paris.lutece.plugins.mydashboard.modules.identity.web.IdentityXPage defines non-transient non-serializable instance field _dashboardIdentity |
BAD_PRACTICE |
SE_BAD_FIELD |
Not available |
Medium |
| Class fr.paris.lutece.plugins.mydashboard.modules.identity.web.IdentityXPage defines non-transient non-serializable instance field _identityService |
BAD_PRACTICE |
SE_BAD_FIELD |
Not available |
Medium |
| Class fr.paris.lutece.plugins.mydashboard.modules.identity.web.IdentityXPage defines non-transient non-serializable instance field _securityTokenService |
BAD_PRACTICE |
SE_BAD_FIELD |
Not available |
Medium |
fr.paris.lutece.plugins.mydashboard.modules.identity.web.MyDashboardIdentityComponent
| Bug |
Category |
Details |
Line |
Priority |
| Class fr.paris.lutece.plugins.mydashboard.modules.identity.web.MyDashboardIdentityComponent defines non-transient non-serializable instance field _identityService |
BAD_PRACTICE |
SE_BAD_FIELD |
Not available |
Medium |
