Le document suivant contient les résultats de PMD 6.13.0.
Rule | Violation | Ligne |
---|---|---|
ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 34–690 |
UnusedPrivateField | Avoid unused private fields such as 'BEAN_USER_ATTRIBUTES_SERVICE'. | 129 |
UnnecessaryConstructor | Avoid unnecessary constructors - the compiler will generate these for you | 135–138 |
NPathComplexity | The method 'processLogin(String, String, HttpServletRequest)' has an NPath complexity of 9504 | 206–331 |
CyclomaticComplexity | The method 'processLogin(String, String, HttpServletRequest)' has a cyclomatic complexity of 28. | 206–331 |
ExcessiveMethodLength | Avoid really long methods. | 206–331 |
PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 208 |
AvoidDeeplyNestedIfStmts | Deeply nested if..then statements are hard to read | 242–250 |
UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 601 |
UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 630 |
AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 672 |
UseCollectionIsEmpty | Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() | 677 |
Rule | Violation | Ligne |
---|---|---|
TooManyMethods | This class has too many methods, consider refactoring it. | 56–448 |
Rule | Violation | Ligne |
---|---|---|
TooManyMethods | This class has too many methods, consider refactoring it. | 50–259 |
Rule | Violation | Ligne |
---|---|---|
TooManyMethods | This class has too many methods, consider refactoring it. | 55–729 |
DefaultPackage | Use explicit scoping instead of the default package private level | 91–92 |
CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the _passwordFactory field if you want a default access modifier | 92 |
Rule | Violation | Ligne |
---|---|---|
IdenticalCatchBranches | 'catch' branch identical to 'BeanDefinitionStoreException' branch | 123–129 |
IdenticalCatchBranches | 'catch' branch identical to 'BeanDefinitionStoreException' branch | 130–136 |
Rule | Violation | Ligne |
---|---|---|
LinguisticNaming | Linguistics Antipattern - The setter 'setDatabaseUserFilter' should not return any type except void linguistically | 171–190 |
ConfusingTernary | Avoid if (x != y) ..; else ..; | 176–187 |
Rule | Violation | Ligne |
---|---|---|
TooManyMethods | This class has too many methods, consider refactoring it. | 52–474 |
Rule | Violation | Ligne |
---|---|---|
MissingOverride | The method 'canBeRemoved(String)' is missing an @Override annotation. | 60–70 |
MissingOverride | The method 'getRemovalRefusedMessage(String, Locale)' is missing an @Override annotation. | 81–85 |
Rule | Violation | Ligne |
---|---|---|
ConfusingTernary | Avoid if (x != y) ..; else ..; | 65 |
MissingOverride | The method 'getResourceTypeCode()' is missing an @Override annotation. | 94–97 |
MissingOverride | The method 'getResourceId()' is missing an @Override annotation. | 104–107 |
Rule | Violation | Ligne |
---|---|---|
AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 71–82 |
Rule | Violation | Ligne |
---|---|---|
LinguisticNaming | Linguistics Antipattern - The setter 'setGroupFilter' should not return any type except void linguistically | 133–150 |
ConfusingTernary | Avoid if (x != y) ..; else ..; | 138–147 |
Rule | Violation | Ligne |
---|---|---|
MissingOverride | The method 'canBeRemoved(String)' is missing an @Override annotation. | 61–73 |
PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 63 |
MissingOverride | The method 'getRemovalRefusedMessage(String, Locale)' is missing an @Override annotation. | 84–88 |
Rule | Violation | Ligne |
---|---|---|
TooManyMethods | This class has too many methods, consider refactoring it. | 50–209 |
Rule | Violation | Ligne |
---|---|---|
TooManyMethods | This class has too many methods, consider refactoring it. | 49–359 |
Rule | Violation | Ligne |
---|---|---|
MissingOverride | The method 'insert(DatabaseUserKey, Plugin)' is missing an @Override annotation. | 57–67 |
MissingOverride | The method 'load(String, Plugin)' is missing an @Override annotation. | 72–90 |
MissingOverride | The method 'delete(String, Plugin)' is missing an @Override annotation. | 95–102 |
MissingOverride | The method 'deleteByIdUser(int, Plugin)' is missing an @Override annotation. | 107–114 |
MissingOverride | The method 'selectKeyByLogin(String, Plugin)' is missing an @Override annotation. | 119–137 |
Rule | Violation | Ligne |
---|---|---|
MissingOverride | The method 'load(String, Plugin)' is missing an @Override annotation. | 55–72 |
MissingOverride | The method 'store(ReferenceItem, Plugin)' is missing an @Override annotation. | 77–87 |
MissingOverride | The method 'selectAll(Plugin)' is missing an @Override annotation. | 92–110 |
Rule | Violation | Ligne |
---|---|---|
ImmutableField | Private field '_parameterService' could be made final; it is only initialized in the declaration or constructor. | 47 |
UnnecessaryConstructor | Avoid unnecessary constructors - the compiler will generate these for you | 52–55 |
Rule | Violation | Ligne |
---|---|---|
ImmutableField | Private field '_plugin' could be made final; it is only initialized in the declaration or constructor. | 77 |
ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 201 |
ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 202 |
ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 203 |
ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 204 |
ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 205 |
ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 206 |
ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 207 |
ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 208 |
ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 209 |
Rule | Violation | Ligne |
---|---|---|
ImmutableField | Private field '_plugin' could be made final; it is only initialized in the declaration or constructor. | 75 |
Rule | Violation | Ligne |
---|---|---|
MissingOverride | The method 'register()' is missing an @Override annotation. | 61–79 |
ShortVariable | Avoid variables with short names like rt | 63 |
ShortVariable | Avoid variables with short names like p | 68 |
MissingOverride | The method 'getResourceIdList(Locale)' is missing an @Override annotation. | 88–91 |
MissingOverride | The method 'getTitle(String, Locale)' is missing an @Override annotation. | 102–105 |
Rule | Violation | Ligne |
---|---|---|
ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 34–823 |
GodClass | Possible God Class (WMC=64, ATFD=83, TCC=8.300%) | 100–823 |
TooManyMethods | This class has too many methods, consider refactoring it. | 101–823 |
ConfusingTernary | Avoid if (x != y) ..; else ..; | 195–202 |
AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 210–218 |
UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 229 |
UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 379 |
ConfusingTernary | Avoid if (x != y) ..; else ..; | 429–445 |
UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 607 |
UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 681 |
CyclomaticComplexity | The method 'getXmlFromUser(DatabaseUser, boolean, boolean, boolean, List, Locale)' has a cyclomatic complexity of 10. | 719–803 |
Rule | Violation | Ligne |
---|---|---|
MissingOverride | The method 'register()' is missing an @Override annotation. | 59–72 |
ShortVariable | Avoid variables with short names like rt | 61 |
ShortVariable | Avoid variables with short names like p | 66 |
MissingOverride | The method 'getResourceIdList(Locale)' is missing an @Override annotation. | 81–84 |
MissingOverride | The method 'getTitle(String, Locale)' is missing an @Override annotation. | 95–98 |
Rule | Violation | Ligne |
---|---|---|
ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 34–461 |
ImmutableField | Private field '_userParamService' could be made final; it is only initialized in the declaration or constructor. | 98 |
CyclomaticComplexity | The method 'readLineOfCSVFile(String, int, Locale, String)' has a cyclomatic complexity of 25. | 104–314 |
NcssCount | The method 'readLineOfCSVFile(String, int, Locale, String)' has a NCSS line count of 107. | 104–314 |
NPathComplexity | The method 'readLineOfCSVFile(String, int, Locale, String)' has an NPath complexity of 19008 | 104–314 |
ExcessiveMethodLength | Avoid really long methods. | 104–314 |
UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 181 |
AvoidReassigningLoopVariables | Avoid reassigning the loop control variable 'strValue' | 268 |
AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 301 |
PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 323 |
UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 414 |
Rule | Violation | Ligne |
---|---|---|
MissingOverride | The method 'findByKey(String, Plugin)' is missing an @Override annotation. | 88–91 |
MissingOverride | The method 'update(ReferenceItem, Plugin)' is missing an @Override annotation. | 101–107 |
MissingOverride | The method 'findAll(Plugin)' is missing an @Override annotation. | 116–119 |
MissingOverride | The method 'isPasswordEncrypted(Plugin)' is missing an @Override annotation. | 128–131 |
MissingOverride | The method 'getEncryptionAlgorithm(Plugin)' is missing an @Override annotation. | 140–143 |
MissingOverride | The method 'isAccountCreationValidationEmail(Plugin)' is missing an @Override annotation. | 152–163 |
MissingOverride | The method 'isJcaptchaEnable(Plugin)' is missing an @Override annotation. | 189–200 |
Rule | Violation | Ligne |
---|---|---|
ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 34–1712 |
ExcessiveClassLength | Avoid really long classes. | 121–1712 |
CyclomaticComplexity | The class 'DatabaseJspBean' has a total cyclomatic complexity of 148 (highest 17). | 121–1712 |
GodClass | Possible God Class (WMC=148, ATFD=301, TCC=32.264%) | 121–1712 |
TooManyMethods | This class has too many methods, consider refactoring it. | 122–1712 |
UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 313 |
ImmutableField | Private field '_userParamService' could be made final; it is only initialized in the declaration or constructor. | 317 |
ImmutableField | Private field '_databaseService' could be made final; it is only initialized in the declaration or constructor. | 318 |
ImmutableField | Private field '_userFactory' could be made final; it is only initialized in the declaration or constructor. | 319 |
ImmutableField | Private field '_anonymizationService' could be made final; it is only initialized in the declaration or constructor. | 320 |
ImmutableField | Private field '_importDatabaseUserService' could be made final; it is only initialized in the declaration or constructor. | 321 |
UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 342 |
UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 424 |
CyclomaticComplexity | The method 'doCreateUser(HttpServletRequest)' has a cyclomatic complexity of 17. | 443–518 |
NPathComplexity | The method 'doCreateUser(HttpServletRequest)' has an NPath complexity of 5184 | 443–518 |
UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 546 |
UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 566 |
NPathComplexity | The method 'doModifyUser(HttpServletRequest)' has an NPath complexity of 200 | 589–657 |
CyclomaticComplexity | The method 'doModifyUser(HttpServletRequest)' has a cyclomatic complexity of 12. | 589–657 |
PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 600 |
ConfusingTernary | Avoid if (x != y) ..; else ..; | 633–640 |
PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 717 |
UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 752 |
ConfusingTernary | Avoid if (x != y) ..; else ..; | 780–808 |
ForLoopCanBeForeach | This for loop can be replaced by a foreach loop | 800–803 |
PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 822 |
UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 880 |
ConfusingTernary | Avoid if (x != y) ..; else ..; | 908–936 |
ForLoopCanBeForeach | This for loop can be replaced by a foreach loop | 928–931 |
UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 1191 |
PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 1266 |
CyclomaticComplexity | The method 'getModifyAccountLifeTimeEmails(HttpServletRequest)' has a cyclomatic complexity of 10. | 1308–1392 |
NcssCount | The method 'getModifyAccountLifeTimeEmails(HttpServletRequest)' has a NCSS line count of 61. | 1308–1392 |
UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 1312 |
UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 1482 |
PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 1521 |
UseLocaleWithCaseConversions | When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 1534 |
UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 1583 |
PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 1607 |
PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 1623 |
PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 1624 |
PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 1625 |
NonThreadSafeSingleton | Singleton is not thread safe | 1706–1710 |
Rule | Violation | Ligne |
---|---|---|
ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 34–868 |
GodClass | Possible God Class (WMC=73, ATFD=116, TCC=28.758%) | 81–868 |
UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 158 |
ImmutableField | Private field '_databaseService' could be made final; it is only initialized in the declaration or constructor. | 162 |
UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 244 |
AddEmptyString | Do not add empty strings | 245 |
PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 283 |
UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 329 |
ConfusingTernary | Avoid if (x != y) ..; else ..; | 352–378 |
PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 358 |
PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 359 |
UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 461 |
ConfusingTernary | Avoid if (x != y) ..; else ..; | 486–513 |
ForLoopCanBeForeach | This for loop can be replaced by a foreach loop | 506–509 |
PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 584 |
UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 584 |
PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 586 |
ConfusingTernary | Avoid if (x != y) ..; else ..; | 666–693 |
ForLoopCanBeForeach | This for loop can be replaced by a foreach loop | 684–689 |
CyclomaticComplexity | The method 'setItemNavigator(String, String, String)' has a cyclomatic complexity of 10. | 796–857 |
Rule | Violation | Ligne |
---|---|---|
ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 34–1729 |
ExcessiveClassLength | Avoid really long classes. | 96–1729 |
CyclomaticComplexity | The class 'MyLuteceDatabaseApp' has a total cyclomatic complexity of 200 (highest 25). | 96–1729 |
GodClass | Possible God Class (WMC=200, ATFD=326, TCC=25.128%) | 96–1729 |
TooManyMethods | This class has too many methods, consider refactoring it. | 97–1729 |
ImmutableField | Private field '_userParamService' could be made final; it is only initialized in the declaration or constructor. | 251 |
ImmutableField | Private field '_userKeyService' could be made final; it is only initialized in the declaration or constructor. | 252 |
ImmutableField | Private field '_captchaService' could be made final; it is only initialized in the declaration or constructor. | 253 |
ImmutableField | Private field '_userFactory' could be made final; it is only initialized in the declaration or constructor. | 254 |
ImmutableField | Private field '_databaseService' could be made final; it is only initialized in the declaration or constructor. | 255 |
CyclomaticComplexity | The method 'getPage(HttpServletRequest, int, Plugin)' has a cyclomatic complexity of 21. | 284–386 |
MissingOverride | The method 'getPage(HttpServletRequest, int, Plugin)' is missing an @Override annotation. | 284–386 |
ExcessiveMethodLength | Avoid really long methods. | 284–386 |
ConfusingTernary | Avoid if (x != y) ..; else ..; | 345–354 |
NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 353 |
ConfusingTernary | Avoid if (x != y) ..; else ..; | 360–375 |
NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 374 |
PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 533 |
PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 534 |
PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 535 |
PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 536 |
PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 537 |
PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 538 |
PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 539 |
PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 541 |
UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 541 |
ShortVariable | Avoid variables with short names like t | 593 |
UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 613 |
PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 613 |
ShortVariable | Avoid variables with short names like t | 633 |
UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 652 |
ShortVariable | Avoid variables with short names like t | 718 |
ExcessiveMethodLength | Avoid really long methods. | 733–857 |
CyclomaticComplexity | The method 'doCreateAccount(HttpServletRequest)' has a cyclomatic complexity of 25. | 733–857 |
NcssCount | The method 'doCreateAccount(HttpServletRequest)' has a NCSS line count of 65. | 733–857 |
NPathComplexity | The method 'doCreateAccount(HttpServletRequest)' has an NPath complexity of 163296 | 733–857 |
UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 838 |
CyclomaticComplexity | The method 'doModifyAccount(HttpServletRequest)' has a cyclomatic complexity of 13. | 866–928 |
ConfusingTernary | Avoid if (x != y) ..; else ..; | 1016–1044 |
UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 1021 |
ShortVariable | Avoid variables with short names like t | 1035 |
UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 1165 |
ShortVariable | Avoid variables with short names like t | 1175 |
UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 1194 |
ShortVariable | Avoid variables with short names like t | 1204 |
UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 1223 |
ShortVariable | Avoid variables with short names like t | 1239 |
CyclomaticComplexity | The method 'doChangePassword(HttpServletRequest)' has a cyclomatic complexity of 14. | 1254–1317 |
NPathComplexity | The method 'doChangePassword(HttpServletRequest)' has an NPath complexity of 1728 | 1254–1317 |
PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 1262 |
PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 1264 |
PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 1265 |
PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 1266 |
CyclomaticComplexity | The method 'doSendPassword(HttpServletRequest)' has a cyclomatic complexity of 15. | 1347–1444 |
NPathComplexity | The method 'doSendPassword(HttpServletRequest)' has an NPath complexity of 540 | 1347–1444 |
NPathComplexity | The method 'doSendLogin(HttpServletRequest)' has an NPath complexity of 288 | 1453–1527 |
CyclomaticComplexity | The method 'doSendLogin(HttpServletRequest)' has a cyclomatic complexity of 14. | 1453–1527 |
AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 1567 |
CyclomaticComplexity | The method 'reactivateAccount(HttpServletRequest)' has a cyclomatic complexity of 12. | 1637–1691 |
LinguisticNaming | Linguistics Antipattern - The getter 'getMessageResetPassword' should not return void linguistically | 1701–1705 |
Rule | Violation | Ligne |
---|---|---|
UnnecessaryFullyQualifiedName | Unnecessary use of fully qualified name 'java.sql.Timestamp' due to existing import 'java.sql.Timestamp' | 216 |
Rule | Violation | Ligne |
---|---|---|
UnnecessaryFullyQualifiedName | Unnecessary use of fully qualified name 'java.sql.Timestamp' due to existing import 'java.sql.Timestamp' | 472 |
Rule | Violation | Ligne |
---|---|---|
BooleanGetMethodName | A getX() method which returns a boolean should be named isX() | 446–449 |
Rule | Violation | Priority | Ligne |
---|---|---|---|
ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 3 | 34–690 |
UnusedPrivateField | Avoid unused private fields such as 'BEAN_USER_ATTRIBUTES_SERVICE'. | 3 | 129 |
UnnecessaryConstructor | Avoid unnecessary constructors - the compiler will generate these for you | 3 | 135–138 |
NPathComplexity | The method 'processLogin(String, String, HttpServletRequest)' has an NPath complexity of 9504 | 3 | 206–331 |
CyclomaticComplexity | The method 'processLogin(String, String, HttpServletRequest)' has a cyclomatic complexity of 28. | 3 | 206–331 |
ExcessiveMethodLength | Avoid really long methods. | 3 | 206–331 |
PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 208 |
UnnecessaryFullyQualifiedName | Unnecessary use of fully qualified name 'java.sql.Timestamp' due to existing import 'java.sql.Timestamp' | 4 | 216 |
AvoidDeeplyNestedIfStmts | Deeply nested if..then statements are hard to read | 3 | 242–250 |
UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 601 |
UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 630 |
AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 3 | 672 |
UseCollectionIsEmpty | Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() | 3 | 677 |
Rule | Violation | Priority | Ligne |
---|---|---|---|
TooManyMethods | This class has too many methods, consider refactoring it. | 3 | 56–448 |
Rule | Violation | Priority | Ligne |
---|---|---|---|
TooManyMethods | This class has too many methods, consider refactoring it. | 3 | 50–259 |
Rule | Violation | Priority | Ligne |
---|---|---|---|
TooManyMethods | This class has too many methods, consider refactoring it. | 3 | 55–729 |
DefaultPackage | Use explicit scoping instead of the default package private level | 3 | 91–92 |
CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the _passwordFactory field if you want a default access modifier | 3 | 92 |
Rule | Violation | Priority | Ligne |
---|---|---|---|
IdenticalCatchBranches | 'catch' branch identical to 'BeanDefinitionStoreException' branch | 3 | 123–129 |
IdenticalCatchBranches | 'catch' branch identical to 'BeanDefinitionStoreException' branch | 3 | 130–136 |
Rule | Violation | Priority | Ligne |
---|---|---|---|
LinguisticNaming | Linguistics Antipattern - The setter 'setDatabaseUserFilter' should not return any type except void linguistically | 3 | 171–190 |
ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 176–187 |
Rule | Violation | Priority | Ligne |
---|---|---|---|
TooManyMethods | This class has too many methods, consider refactoring it. | 3 | 52–474 |
UnnecessaryFullyQualifiedName | Unnecessary use of fully qualified name 'java.sql.Timestamp' due to existing import 'java.sql.Timestamp' | 4 | 472 |
Rule | Violation | Priority | Ligne |
---|---|---|---|
MissingOverride | The method 'canBeRemoved(String)' is missing an @Override annotation. | 3 | 60–70 |
MissingOverride | The method 'getRemovalRefusedMessage(String, Locale)' is missing an @Override annotation. | 3 | 81–85 |
Rule | Violation | Priority | Ligne |
---|---|---|---|
ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 65 |
MissingOverride | The method 'getResourceTypeCode()' is missing an @Override annotation. | 3 | 94–97 |
MissingOverride | The method 'getResourceId()' is missing an @Override annotation. | 3 | 104–107 |
Rule | Violation | Priority | Ligne |
---|---|---|---|
AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 3 | 71–82 |
Rule | Violation | Priority | Ligne |
---|---|---|---|
LinguisticNaming | Linguistics Antipattern - The setter 'setGroupFilter' should not return any type except void linguistically | 3 | 133–150 |
ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 138–147 |
Rule | Violation | Priority | Ligne |
---|---|---|---|
MissingOverride | The method 'canBeRemoved(String)' is missing an @Override annotation. | 3 | 61–73 |
PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 63 |
MissingOverride | The method 'getRemovalRefusedMessage(String, Locale)' is missing an @Override annotation. | 3 | 84–88 |
Rule | Violation | Priority | Ligne |
---|---|---|---|
TooManyMethods | This class has too many methods, consider refactoring it. | 3 | 50–209 |
Rule | Violation | Priority | Ligne |
---|---|---|---|
TooManyMethods | This class has too many methods, consider refactoring it. | 3 | 49–359 |
Rule | Violation | Priority | Ligne |
---|---|---|---|
MissingOverride | The method 'insert(DatabaseUserKey, Plugin)' is missing an @Override annotation. | 3 | 57–67 |
MissingOverride | The method 'load(String, Plugin)' is missing an @Override annotation. | 3 | 72–90 |
MissingOverride | The method 'delete(String, Plugin)' is missing an @Override annotation. | 3 | 95–102 |
MissingOverride | The method 'deleteByIdUser(int, Plugin)' is missing an @Override annotation. | 3 | 107–114 |
MissingOverride | The method 'selectKeyByLogin(String, Plugin)' is missing an @Override annotation. | 3 | 119–137 |
Rule | Violation | Priority | Ligne |
---|---|---|---|
MissingOverride | The method 'load(String, Plugin)' is missing an @Override annotation. | 3 | 55–72 |
MissingOverride | The method 'store(ReferenceItem, Plugin)' is missing an @Override annotation. | 3 | 77–87 |
MissingOverride | The method 'selectAll(Plugin)' is missing an @Override annotation. | 3 | 92–110 |
Rule | Violation | Priority | Ligne |
---|---|---|---|
ImmutableField | Private field '_parameterService' could be made final; it is only initialized in the declaration or constructor. | 3 | 47 |
UnnecessaryConstructor | Avoid unnecessary constructors - the compiler will generate these for you | 3 | 52–55 |
Rule | Violation | Priority | Ligne |
---|---|---|---|
ImmutableField | Private field '_plugin' could be made final; it is only initialized in the declaration or constructor. | 3 | 77 |
ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 3 | 201 |
ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 3 | 202 |
ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 3 | 203 |
ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 3 | 204 |
ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 3 | 205 |
ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 3 | 206 |
ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 3 | 207 |
ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 3 | 208 |
ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 3 | 209 |
Rule | Violation | Priority | Ligne |
---|---|---|---|
ImmutableField | Private field '_plugin' could be made final; it is only initialized in the declaration or constructor. | 3 | 75 |
Rule | Violation | Priority | Ligne |
---|---|---|---|
MissingOverride | The method 'register()' is missing an @Override annotation. | 3 | 61–79 |
ShortVariable | Avoid variables with short names like rt | 3 | 63 |
ShortVariable | Avoid variables with short names like p | 3 | 68 |
MissingOverride | The method 'getResourceIdList(Locale)' is missing an @Override annotation. | 3 | 88–91 |
MissingOverride | The method 'getTitle(String, Locale)' is missing an @Override annotation. | 3 | 102–105 |
Rule | Violation | Priority | Ligne |
---|---|---|---|
ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 3 | 34–823 |
GodClass | Possible God Class (WMC=64, ATFD=83, TCC=8.300%) | 3 | 100–823 |
TooManyMethods | This class has too many methods, consider refactoring it. | 3 | 101–823 |
ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 195–202 |
AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 3 | 210–218 |
UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 229 |
UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 3 | 379 |
ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 429–445 |
UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 607 |
UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 681 |
CyclomaticComplexity | The method 'getXmlFromUser(DatabaseUser, boolean, boolean, boolean, List, Locale)' has a cyclomatic complexity of 10. | 3 | 719–803 |
Rule | Violation | Priority | Ligne |
---|---|---|---|
MissingOverride | The method 'register()' is missing an @Override annotation. | 3 | 59–72 |
ShortVariable | Avoid variables with short names like rt | 3 | 61 |
ShortVariable | Avoid variables with short names like p | 3 | 66 |
MissingOverride | The method 'getResourceIdList(Locale)' is missing an @Override annotation. | 3 | 81–84 |
MissingOverride | The method 'getTitle(String, Locale)' is missing an @Override annotation. | 3 | 95–98 |
Rule | Violation | Priority | Ligne |
---|---|---|---|
ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 3 | 34–461 |
ImmutableField | Private field '_userParamService' could be made final; it is only initialized in the declaration or constructor. | 3 | 98 |
CyclomaticComplexity | The method 'readLineOfCSVFile(String, int, Locale, String)' has a cyclomatic complexity of 25. | 3 | 104–314 |
NcssCount | The method 'readLineOfCSVFile(String, int, Locale, String)' has a NCSS line count of 107. | 3 | 104–314 |
NPathComplexity | The method 'readLineOfCSVFile(String, int, Locale, String)' has an NPath complexity of 19008 | 3 | 104–314 |
ExcessiveMethodLength | Avoid really long methods. | 3 | 104–314 |
UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 181 |
AvoidReassigningLoopVariables | Avoid reassigning the loop control variable 'strValue' | 3 | 268 |
AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 301 |
PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 323 |
UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 414 |
BooleanGetMethodName | A getX() method which returns a boolean should be named isX() | 4 | 446–449 |
Rule | Violation | Priority | Ligne |
---|---|---|---|
MissingOverride | The method 'findByKey(String, Plugin)' is missing an @Override annotation. | 3 | 88–91 |
MissingOverride | The method 'update(ReferenceItem, Plugin)' is missing an @Override annotation. | 3 | 101–107 |
MissingOverride | The method 'findAll(Plugin)' is missing an @Override annotation. | 3 | 116–119 |
MissingOverride | The method 'isPasswordEncrypted(Plugin)' is missing an @Override annotation. | 3 | 128–131 |
MissingOverride | The method 'getEncryptionAlgorithm(Plugin)' is missing an @Override annotation. | 3 | 140–143 |
MissingOverride | The method 'isAccountCreationValidationEmail(Plugin)' is missing an @Override annotation. | 3 | 152–163 |
MissingOverride | The method 'isJcaptchaEnable(Plugin)' is missing an @Override annotation. | 3 | 189–200 |
Rule | Violation | Priority | Ligne |
---|---|---|---|
ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 3 | 34–1712 |
ExcessiveClassLength | Avoid really long classes. | 3 | 121–1712 |
CyclomaticComplexity | The class 'DatabaseJspBean' has a total cyclomatic complexity of 148 (highest 17). | 3 | 121–1712 |
GodClass | Possible God Class (WMC=148, ATFD=301, TCC=32.264%) | 3 | 121–1712 |
TooManyMethods | This class has too many methods, consider refactoring it. | 3 | 122–1712 |
UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 313 |
ImmutableField | Private field '_userParamService' could be made final; it is only initialized in the declaration or constructor. | 3 | 317 |
ImmutableField | Private field '_databaseService' could be made final; it is only initialized in the declaration or constructor. | 3 | 318 |
ImmutableField | Private field '_userFactory' could be made final; it is only initialized in the declaration or constructor. | 3 | 319 |
ImmutableField | Private field '_anonymizationService' could be made final; it is only initialized in the declaration or constructor. | 3 | 320 |
ImmutableField | Private field '_importDatabaseUserService' could be made final; it is only initialized in the declaration or constructor. | 3 | 321 |
UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 342 |
UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 424 |
CyclomaticComplexity | The method 'doCreateUser(HttpServletRequest)' has a cyclomatic complexity of 17. | 3 | 443–518 |
NPathComplexity | The method 'doCreateUser(HttpServletRequest)' has an NPath complexity of 5184 | 3 | 443–518 |
UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 546 |
UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 566 |
NPathComplexity | The method 'doModifyUser(HttpServletRequest)' has an NPath complexity of 200 | 3 | 589–657 |
CyclomaticComplexity | The method 'doModifyUser(HttpServletRequest)' has a cyclomatic complexity of 12. | 3 | 589–657 |
PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 600 |
ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 633–640 |
PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 717 |
UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 752 |
ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 780–808 |
ForLoopCanBeForeach | This for loop can be replaced by a foreach loop | 3 | 800–803 |
PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 822 |
UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 880 |
ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 908–936 |
ForLoopCanBeForeach | This for loop can be replaced by a foreach loop | 3 | 928–931 |
UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 1191 |
PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 1266 |
CyclomaticComplexity | The method 'getModifyAccountLifeTimeEmails(HttpServletRequest)' has a cyclomatic complexity of 10. | 3 | 1308–1392 |
NcssCount | The method 'getModifyAccountLifeTimeEmails(HttpServletRequest)' has a NCSS line count of 61. | 3 | 1308–1392 |
UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 1312 |
UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 1482 |
PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 1521 |
UseLocaleWithCaseConversions | When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 3 | 1534 |
UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 1583 |
PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 1607 |
PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 1623 |
PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 1624 |
PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 1625 |
NonThreadSafeSingleton | Singleton is not thread safe | 3 | 1706–1710 |
Rule | Violation | Priority | Ligne |
---|---|---|---|
ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 3 | 34–868 |
GodClass | Possible God Class (WMC=73, ATFD=116, TCC=28.758%) | 3 | 81–868 |
UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 158 |
ImmutableField | Private field '_databaseService' could be made final; it is only initialized in the declaration or constructor. | 3 | 162 |
UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 244 |
AddEmptyString | Do not add empty strings | 3 | 245 |
PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 283 |
UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 329 |
ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 352–378 |
PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 358 |
PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 359 |
UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 461 |
ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 486–513 |
ForLoopCanBeForeach | This for loop can be replaced by a foreach loop | 3 | 506–509 |
PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 584 |
UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 584 |
PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 586 |
ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 666–693 |
ForLoopCanBeForeach | This for loop can be replaced by a foreach loop | 3 | 684–689 |
CyclomaticComplexity | The method 'setItemNavigator(String, String, String)' has a cyclomatic complexity of 10. | 3 | 796–857 |
Rule | Violation | Priority | Ligne |
---|---|---|---|
ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 3 | 34–1729 |
ExcessiveClassLength | Avoid really long classes. | 3 | 96–1729 |
CyclomaticComplexity | The class 'MyLuteceDatabaseApp' has a total cyclomatic complexity of 200 (highest 25). | 3 | 96–1729 |
GodClass | Possible God Class (WMC=200, ATFD=326, TCC=25.128%) | 3 | 96–1729 |
TooManyMethods | This class has too many methods, consider refactoring it. | 3 | 97–1729 |
ImmutableField | Private field '_userParamService' could be made final; it is only initialized in the declaration or constructor. | 3 | 251 |
ImmutableField | Private field '_userKeyService' could be made final; it is only initialized in the declaration or constructor. | 3 | 252 |
ImmutableField | Private field '_captchaService' could be made final; it is only initialized in the declaration or constructor. | 3 | 253 |
ImmutableField | Private field '_userFactory' could be made final; it is only initialized in the declaration or constructor. | 3 | 254 |
ImmutableField | Private field '_databaseService' could be made final; it is only initialized in the declaration or constructor. | 3 | 255 |
CyclomaticComplexity | The method 'getPage(HttpServletRequest, int, Plugin)' has a cyclomatic complexity of 21. | 3 | 284–386 |
MissingOverride | The method 'getPage(HttpServletRequest, int, Plugin)' is missing an @Override annotation. | 3 | 284–386 |
ExcessiveMethodLength | Avoid really long methods. | 3 | 284–386 |
ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 345–354 |
NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 353 |
ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 360–375 |
NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 374 |
PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 533 |
PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 534 |
PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 535 |
PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 536 |
PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 537 |
PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 538 |
PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 539 |
PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 541 |
UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 541 |
ShortVariable | Avoid variables with short names like t | 3 | 593 |
UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 613 |
PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 613 |
ShortVariable | Avoid variables with short names like t | 3 | 633 |
UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 652 |
ShortVariable | Avoid variables with short names like t | 3 | 718 |
ExcessiveMethodLength | Avoid really long methods. | 3 | 733–857 |
CyclomaticComplexity | The method 'doCreateAccount(HttpServletRequest)' has a cyclomatic complexity of 25. | 3 | 733–857 |
NcssCount | The method 'doCreateAccount(HttpServletRequest)' has a NCSS line count of 65. | 3 | 733–857 |
NPathComplexity | The method 'doCreateAccount(HttpServletRequest)' has an NPath complexity of 163296 | 3 | 733–857 |
UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 838 |
CyclomaticComplexity | The method 'doModifyAccount(HttpServletRequest)' has a cyclomatic complexity of 13. | 3 | 866–928 |
ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 1016–1044 |
UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 1021 |
ShortVariable | Avoid variables with short names like t | 3 | 1035 |
UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 1165 |
ShortVariable | Avoid variables with short names like t | 3 | 1175 |
UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 1194 |
ShortVariable | Avoid variables with short names like t | 3 | 1204 |
UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 1223 |
ShortVariable | Avoid variables with short names like t | 3 | 1239 |
CyclomaticComplexity | The method 'doChangePassword(HttpServletRequest)' has a cyclomatic complexity of 14. | 3 | 1254–1317 |
NPathComplexity | The method 'doChangePassword(HttpServletRequest)' has an NPath complexity of 1728 | 3 | 1254–1317 |
PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 1262 |
PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 1264 |
PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 1265 |
PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 1266 |
CyclomaticComplexity | The method 'doSendPassword(HttpServletRequest)' has a cyclomatic complexity of 15. | 3 | 1347–1444 |
NPathComplexity | The method 'doSendPassword(HttpServletRequest)' has an NPath complexity of 540 | 3 | 1347–1444 |
NPathComplexity | The method 'doSendLogin(HttpServletRequest)' has an NPath complexity of 288 | 3 | 1453–1527 |
CyclomaticComplexity | The method 'doSendLogin(HttpServletRequest)' has a cyclomatic complexity of 14. | 3 | 1453–1527 |
AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 3 | 1567 |
CyclomaticComplexity | The method 'reactivateAccount(HttpServletRequest)' has a cyclomatic complexity of 12. | 3 | 1637–1691 |
LinguisticNaming | Linguistics Antipattern - The getter 'getMessageResetPassword' should not return void linguistically | 3 | 1701–1705 |