Résultats PMD
Le document suivant contient les résultats de PMD 5.3.5.
Fichiers
fr/paris/lutece/plugins/mylutece/modules/notification/business/NotificationDAO.java
| Violation |
Ligne |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. |
196 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. |
197 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. |
231 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. |
232 |
| Avoid using Literals in Conditional Statements |
340 |
fr/paris/lutece/plugins/mylutece/modules/notification/business/NotificationFilter.java
| Violation |
Ligne |
| A getX() method which returns a boolean should be named isX() |
96–99 |
fr/paris/lutece/plugins/mylutece/modules/notification/business/folder/AbstractFolder.java
| Violation |
Ligne |
| An empty method in an abstract class should be abstract instead |
133–135 |
| Document empty method |
134–135 |
fr/paris/lutece/plugins/mylutece/modules/notification/business/portlet/NotificationListPortlet.java
| Violation |
Ligne |
| The class 'NotificationListPortlet' has a Modified Cyclomatic Complexity of 3 (Highest = 10). |
65–322 |
| The class 'NotificationListPortlet' has a Standard Cyclomatic Complexity of 3 (Highest = 10). |
65–322 |
| The class 'NotificationListPortlet' has a Cyclomatic Complexity of 3 (Highest = 12). |
65–322 |
| A getX() method which returns a boolean should be named isX() |
126–129 |
| A getX() method which returns a boolean should be named isX() |
144–147 |
| The method 'getXml' has a Standard Cyclomatic Complexity of 10. |
152–239 |
| The method 'getXml' has a Cyclomatic Complexity of 12. |
152–239 |
| The method 'getXml' has a Modified Cyclomatic Complexity of 10. |
152–239 |
| The method getXml() has an NPath complexity of 904 |
152–239 |
| These nested if statements could be combined |
160–233 |
| Deeply nested if..then statements are hard to read |
180–183 |
| Deeply nested if..then statements are hard to read |
188–191 |
| Deeply nested if..then statements are hard to read |
196–201 |
fr/paris/lutece/plugins/mylutece/modules/notification/business/portlet/NotificationListPortletDAO.java
| Violation |
Ligne |
| Avoid variables with short names like p |
57 |
| Avoid variables with short names like p |
112 |
fr/paris/lutece/plugins/mylutece/modules/notification/business/portlet/NotificationListPortletHome.java
| Violation |
Ligne |
| Avoid excessively long variable names like BEAN_MYLUTECENOTIFICATION_NOTIFICATIONLISTPORTLETDAO |
50 |
| Document empty constructor |
62–64 |
| It is a good practice to call super() in a constructor |
62–64 |
| Avoid unnecessary constructors - the compiler will generate these for you |
62–64 |
| Singleton is not thread safe |
72–75 |
fr/paris/lutece/plugins/mylutece/modules/notification/rs/NotificationRest.java
| Violation |
Ligne |
| If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation |
114 |
| Avoid variables with short names like t |
117 |
| Rather than using a lot of String arguments, consider using a container object for those values. |
134–138 |
fr/paris/lutece/plugins/mylutece/modules/notification/service/NotificationPlugin.java
| Violation |
Ligne |
| Document empty method |
52–53 |
fr/paris/lutece/plugins/mylutece/modules/notification/service/NotificationResourceIdService.java
| Violation |
Ligne |
| It is a good practice to call super() in a constructor |
62–65 |
| Avoid variables with short names like rt |
72 |
| Avoid variables with short names like p |
78 |
fr/paris/lutece/plugins/mylutece/modules/notification/service/NotificationService.java
| Violation |
Ligne |
| Rather than using a lot of String arguments, consider using a container object for those values. |
243 |
fr/paris/lutece/plugins/mylutece/modules/notification/service/parameter/NotificationParameterService.java
| Violation |
Ligne |
| Avoid excessively long variable names like BEAN_MYLUTECENOTIFICATION_NOTIFICATIONPARAMETERSERVICE |
50 |
fr/paris/lutece/plugins/mylutece/modules/notification/service/portlet/NotificationListPortletService.java
| Violation |
Ligne |
| Avoid excessively long variable names like BEAN_MYLUTECENOTIFICATION_NOTIFICATIONLISTPORTLETSERVICE |
50 |
fr/paris/lutece/plugins/mylutece/modules/notification/web/NotificationAdminDashboardComponent.java
| Violation |
Ligne |
| If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation |
81 |
fr/paris/lutece/plugins/mylutece/modules/notification/web/NotificationApp.java
| Violation |
Ligne |
| A high number of imports can indicate a high degree of coupling within an object. |
34–573 |
| Possible God class (WMC=65, ATFD=117, TCC=0.32727272727272727) |
34–573 |
| The class 'NotificationApp' has a Modified Cyclomatic Complexity of 5 (Highest = 12). |
78–573 |
| The class 'NotificationApp' has a Standard Cyclomatic Complexity of 5 (Highest = 12). |
78–573 |
| The class 'NotificationApp' has a Cyclomatic Complexity of 6 (Highest = 12). |
78–573 |
| Private field '_notificationService' could be made final; it is only initialized in the declaration or constructor. |
133 |
| Private field '_folderService' could be made final; it is only initialized in the declaration or constructor. |
134 |
| Private field '_parameterService' could be made final; it is only initialized in the declaration or constructor. |
135 |
| The method 'getPage' has a Cyclomatic Complexity of 12. |
140–218 |
| The method 'getPage' has a Modified Cyclomatic Complexity of 12. |
140–218 |
| The method 'getPage' has a Standard Cyclomatic Complexity of 12. |
140–218 |
| Deeply nested if..then statements are hard to read |
192–195 |
| If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation |
204 |
| If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation |
229 |
| If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation |
261 |
| If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation |
310 |
| If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation |
340 |
| Prefer StringBuffer over += for concatenating strings |
524 |
fr/paris/lutece/plugins/mylutece/modules/notification/web/portlet/NotificationListPortletJspBean.java
| Violation |
Ligne |
| If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation |
88 |
| If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation |
112 |
