PMD Results
The following document contains the results of PMD 5.3.5.
Files
fr/paris/lutece/plugins/mylutece/modules/oauth/authentication/AbstractOAuthCredentialsRetriever.java
| Violation |
Line |
| If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation |
57 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. |
67 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. |
72 |
fr/paris/lutece/plugins/mylutece/modules/oauth/authentication/OAuthAuthentication.java
| Violation |
Line |
| Possible God class (WMC=57, ATFD=49, TCC=0.01680672268907563) |
34–608 |
| A high number of imports can indicate a high degree of coupling within an object. |
34–608 |
| The class 'OAuthAuthentication' has a Standard Cyclomatic Complexity of 2 (Highest = 11). |
89–608 |
| The class 'OAuthAuthentication' has a Cyclomatic Complexity of 2 (Highest = 12). |
89–608 |
| The class 'OAuthAuthentication' has a Modified Cyclomatic Complexity of 2 (Highest = 11). |
89–608 |
| The method 'getUser' has a Standard Cyclomatic Complexity of 11. |
318–398 |
| The method 'getUser' has a Modified Cyclomatic Complexity of 11. |
318–398 |
| The method 'getUser' has a Cyclomatic Complexity of 12. |
318–398 |
fr/paris/lutece/plugins/mylutece/modules/oauth/authentication/OAuthAuthenticationFactory.java
| Violation |
Line |
| If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation |
54 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. |
61 |
fr/paris/lutece/plugins/mylutece/modules/oauth/authentication/XMLCredentialRetriever.java
| Violation |
Line |
| The class 'XMLCredentialRetriever' has a Modified Cyclomatic Complexity of 11 (Highest = 10). |
64–122 |
| The class 'XMLCredentialRetriever' has a Standard Cyclomatic Complexity of 11 (Highest = 10). |
64–122 |
| The class 'XMLCredentialRetriever' has a Cyclomatic Complexity of 12 (Highest = 11). |
64–122 |
| The method 'doRetrieveUserInfo' has a Modified Cyclomatic Complexity of 10. |
70–121 |
| The method 'doRetrieveUserInfo' has a Cyclomatic Complexity of 11. |
70–121 |
| The method 'doRetrieveUserInfo' has a Standard Cyclomatic Complexity of 10. |
70–121 |
fr/paris/lutece/plugins/mylutece/modules/oauth/service/OAuthService.java
| Violation |
Line |
| Class cannot be instantiated and does not provide any static methods or fields |
61–216 |
| Private field '_mapAuthentications' could be made final; it is only initialized in the declaration or constructor. |
63 |
fr/paris/lutece/plugins/mylutece/modules/oauth/web/OAuthJspBean.java
| Violation |
Line |
| Perhaps '_nDefaultItemsPerPage' could be replaced by a local variable. |
110 |
| Private field '_factory' could be made final; it is only initialized in the declaration or constructor. |
112 |
| Private field '_service' could be made final; it is only initialized in the declaration or constructor. |
113 |
| It is a good practice to call super() in a constructor |
118–122 |
| If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation |
179 |
| Do not add empty strings |
183 |
| If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation |
217 |
| If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation |
289 |
