The following document contains the results of PMD 6.13.0.
| Rule | Violation | Line |
|---|---|---|
| FieldNamingConventions | The constant name 'authDataClientName' doesn't match '[A-Z][A-Z_0-9]*' | 76 |
| Rule | Violation | Line |
|---|---|---|
| FormalParameterNamingConventions | The method parameter name '_strIdSession' doesn't match '[a-z][a-zA-Z0-9]*' | 54 |
| FormalParameterNamingConventions | The method parameter name '_strLuteceUserName' doesn't match '[a-z][a-zA-Z0-9]*' | 64 |
| FormalParameterNamingConventions | The method parameter name '_bUpToDate' doesn't match '[a-z][a-zA-Z0-9]*' | 74 |
| Rule | Violation | Line |
|---|---|---|
| FieldNamingConventions | The static field name 'ATTRIBUTE_USER_MAPPING' doesn't match '_[a-z][a-zA-Z0-9]*' | 96 |
| FieldNamingConventions | The static field name 'ATTRIBUTE_USER_KEY_NAME' doesn't match '_[a-z][a-zA-Z0-9]*' | 99 |
| Rule | Violation | Line |
|---|---|---|
| ClassNamingConventions | The utility class name 'Constants' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' | 39–65 |
| Rule | Violation | Line |
|---|---|---|
| LoggerIsNotStaticFinal | The Logger variable declaration does not contain the static and final modifiers | 75 |
| Rule | Violation | Line |
|---|---|---|
| DefaultPackage | Use explicit scoping instead of the default package private level | 106–113 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the parse method if you want a default access modifier | 106–113 |
| CyclomaticComplexity | The method 'handleError(HttpServletRequest, HttpServletResponse, String)' has a cyclomatic complexity of 11. | 116–186 |
| UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 146 |
| UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 150 |
| UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 153 |
| Rule | Violation | Line |
|---|---|---|
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the parse method if you want a default access modifier | 101–108 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 101–108 |
| Rule | Violation | Line |
|---|---|---|
| UncommentedEmptyMethodBody | Document empty method body | 132–133 |
| SimplifyConditional | No need to check for null before an instanceof | 199 |
| Rule | Violation | Line |
|---|---|---|
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 86 |
| Rule | Violation | Line |
|---|---|---|
| UncommentedEmptyMethodBody | Document empty method body | 51–52 |
| Rule | Violation | Line |
|---|---|---|
| UncommentedEmptyMethodBody | Document empty method body | 60–61 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 36–45 |
| CommentRequired | Public method and constructor comments are required | 38 |
| CommentRequired | Public method and constructor comments are required | 40 |
| CommentRequired | Public method and constructor comments are required | 42 |
| CommentRequired | Public method and constructor comments are required | 44 |
| Rule | Violation | Line |
|---|---|---|
| UnusedPrivateField | Avoid unused private fields such as 'AUTHENTICATION_BEAN_NAME'. | 47 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 36–78 |
| CommentRequired | Public method and constructor comments are required | 42–47 |
| CommentRequired | Public method and constructor comments are required | 49–52 |
| CommentRequired | Public method and constructor comments are required | 54–57 |
| CommentRequired | Public method and constructor comments are required | 59–62 |
| CommentRequired | Public method and constructor comments are required | 64–67 |
| CommentRequired | Public method and constructor comments are required | 69–72 |
| CommentRequired | Public method and constructor comments are required | 74–77 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 43–119 |
| CommentRequired | Public method and constructor comments are required | 50–60 |
| NonThreadSafeSingleton | Singleton is not thread safe | 52–57 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 55 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 56 |
| CommentRequired | Public method and constructor comments are required | 62–72 |
| MissingOverride | The method 'isLuteceUserUpToDate(String)' is missing an @Override annotation. | 62–72 |
| CommentRequired | Public method and constructor comments are required | 74–83 |
| MissingOverride | The method 'addLuteceUserSession(String, String)' is missing an @Override annotation. | 74–83 |
| CommentRequired | Public method and constructor comments are required | 85–102 |
| MissingOverride | The method 'removeLuteceUserSession(String)' is missing an @Override annotation. | 85–102 |
| AvoidDeeplyNestedIfStmts | Deeply nested if..then statements are hard to read | 96–99 |
| MissingOverride | The method 'notifyLuteceUserUpdating(String)' is missing an @Override annotation. | 104–118 |
| CommentRequired | Public method and constructor comments are required | 104–118 |
| Rule | Violation | Line |
|---|---|---|
| CyclomaticComplexity | The method 'getInstance()' has a cyclomatic complexity of 10. | 119–176 |
| NonThreadSafeSingleton | Singleton is not thread safe | 121–173 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 131 |
| AvoidDeeplyNestedIfStmts | Deeply nested if..then statements are hard to read | 146–168 |
| NPathComplexity | The method 'processAuthentication(HttpServletRequest, Map, Token)' has an NPath complexity of 603 | 189–278 |
| CyclomaticComplexity | The method 'processAuthentication(HttpServletRequest, Map, Token)' has a cyclomatic complexity of 16. | 189–278 |
| ForLoopCanBeForeach | This for loop can be replaced by a foreach loop | 199–206 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 244–254 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 289–296 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 307 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 311 |
| ForLoopCanBeForeach | This for loop can be replaced by a foreach loop | 317–321 |
| Rule | Violation | Line |
|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 34–320 |
| CyclomaticComplexity | The method 'doFilter(ServletRequest, ServletResponse, FilterChain)' has a cyclomatic complexity of 16. | 115–183 |
| AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 119 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 149–165 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 203 |
| UseCollectionIsEmpty | Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() | 216 |
| UseCollectionIsEmpty | Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() | 223 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 297–304 |
| Rule | Violation | Line |
|---|---|---|
| UnusedImports | Avoid unused imports such as 'java.util.ArrayList' | 38 |
| UnusedImports | Avoid unused imports such as 'java.util.stream.Collectors' | 42 |
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.plugins.mylutece.business.LuteceUserRoleDescription' | 49 |
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.plugins.mylutece.business.attribute.AttributeHome' | 50 |
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.plugins.mylutece.service.MyLutecePlugin' | 52 |
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.portal.business.role.RoleHome' | 56 |
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.portal.service.plugin.Plugin' | 57 |
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.portal.service.plugin.PluginService' | 58 |
| Rule | Violation | Line |
|---|---|---|
| UnusedImports | Avoid unused imports such as 'java.util.HashSet' | 40 |
| UnusedImports | Avoid unused imports such as 'org.apache.commons.collections.map.HashedMap' | 54 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| DefaultPackage | Use explicit scoping instead of the default package private level | 3 | 106–113 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the parse method if you want a default access modifier | 3 | 106–113 |
| CyclomaticComplexity | The method 'handleError(HttpServletRequest, HttpServletResponse, String)' has a cyclomatic complexity of 11. | 3 | 116–186 |
| UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 3 | 146 |
| UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 3 | 150 |
| UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 3 | 153 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the parse method if you want a default access modifier | 3 | 101–108 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 3 | 101–108 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnusedImports | Avoid unused imports such as 'java.util.ArrayList' | 4 | 38 |
| UnusedImports | Avoid unused imports such as 'java.util.stream.Collectors' | 4 | 42 |
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.plugins.mylutece.business.LuteceUserRoleDescription' | 4 | 49 |
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.plugins.mylutece.business.attribute.AttributeHome' | 4 | 50 |
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.plugins.mylutece.service.MyLutecePlugin' | 4 | 52 |
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.portal.business.role.RoleHome' | 4 | 56 |
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.portal.service.plugin.Plugin' | 4 | 57 |
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.portal.service.plugin.PluginService' | 4 | 58 |
| FieldNamingConventions | The constant name 'authDataClientName' doesn't match '[A-Z][A-Z_0-9]*' | 1 | 76 |
| UncommentedEmptyMethodBody | Document empty method body | 3 | 132–133 |
| SimplifyConditional | No need to check for null before an instanceof | 3 | 199 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 86 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UncommentedEmptyMethodBody | Document empty method body | 3 | 51–52 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UncommentedEmptyMethodBody | Document empty method body | 3 | 60–61 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 36–45 |
| CommentRequired | Public method and constructor comments are required | 3 | 38 |
| CommentRequired | Public method and constructor comments are required | 3 | 40 |
| CommentRequired | Public method and constructor comments are required | 3 | 42 |
| CommentRequired | Public method and constructor comments are required | 3 | 44 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnusedPrivateField | Avoid unused private fields such as 'AUTHENTICATION_BEAN_NAME'. | 3 | 47 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 36–78 |
| CommentRequired | Public method and constructor comments are required | 3 | 42–47 |
| CommentRequired | Public method and constructor comments are required | 3 | 49–52 |
| CommentRequired | Public method and constructor comments are required | 3 | 54–57 |
| FormalParameterNamingConventions | The method parameter name '_strIdSession' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 54 |
| CommentRequired | Public method and constructor comments are required | 3 | 59–62 |
| CommentRequired | Public method and constructor comments are required | 3 | 64–67 |
| FormalParameterNamingConventions | The method parameter name '_strLuteceUserName' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 64 |
| CommentRequired | Public method and constructor comments are required | 3 | 69–72 |
| FormalParameterNamingConventions | The method parameter name '_bUpToDate' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 74 |
| CommentRequired | Public method and constructor comments are required | 3 | 74–77 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 43–119 |
| CommentRequired | Public method and constructor comments are required | 3 | 50–60 |
| NonThreadSafeSingleton | Singleton is not thread safe | 3 | 52–57 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 55 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 56 |
| CommentRequired | Public method and constructor comments are required | 3 | 62–72 |
| MissingOverride | The method 'isLuteceUserUpToDate(String)' is missing an @Override annotation. | 3 | 62–72 |
| CommentRequired | Public method and constructor comments are required | 3 | 74–83 |
| MissingOverride | The method 'addLuteceUserSession(String, String)' is missing an @Override annotation. | 3 | 74–83 |
| CommentRequired | Public method and constructor comments are required | 3 | 85–102 |
| MissingOverride | The method 'removeLuteceUserSession(String)' is missing an @Override annotation. | 3 | 85–102 |
| AvoidDeeplyNestedIfStmts | Deeply nested if..then statements are hard to read | 3 | 96–99 |
| MissingOverride | The method 'notifyLuteceUserUpdating(String)' is missing an @Override annotation. | 3 | 104–118 |
| CommentRequired | Public method and constructor comments are required | 3 | 104–118 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| LoggerIsNotStaticFinal | The Logger variable declaration does not contain the static and final modifiers | 2 | 75 |
| FieldNamingConventions | The static field name 'ATTRIBUTE_USER_MAPPING' doesn't match '_[a-z][a-zA-Z0-9]*' | 1 | 96 |
| FieldNamingConventions | The static field name 'ATTRIBUTE_USER_KEY_NAME' doesn't match '_[a-z][a-zA-Z0-9]*' | 1 | 99 |
| CyclomaticComplexity | The method 'getInstance()' has a cyclomatic complexity of 10. | 3 | 119–176 |
| NonThreadSafeSingleton | Singleton is not thread safe | 3 | 121–173 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 131 |
| AvoidDeeplyNestedIfStmts | Deeply nested if..then statements are hard to read | 3 | 146–168 |
| NPathComplexity | The method 'processAuthentication(HttpServletRequest, Map, Token)' has an NPath complexity of 603 | 3 | 189–278 |
| CyclomaticComplexity | The method 'processAuthentication(HttpServletRequest, Map, Token)' has a cyclomatic complexity of 16. | 3 | 189–278 |
| ForLoopCanBeForeach | This for loop can be replaced by a foreach loop | 3 | 199–206 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 244–254 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 289–296 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 307 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 311 |
| ForLoopCanBeForeach | This for loop can be replaced by a foreach loop | 3 | 317–321 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ClassNamingConventions | The utility class name 'Constants' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' | 1 | 39–65 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 3 | 34–320 |
| UnusedImports | Avoid unused imports such as 'java.util.HashSet' | 4 | 40 |
| UnusedImports | Avoid unused imports such as 'org.apache.commons.collections.map.HashedMap' | 4 | 54 |
| CyclomaticComplexity | The method 'doFilter(ServletRequest, ServletResponse, FilterChain)' has a cyclomatic complexity of 16. | 3 | 115–183 |
| AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 3 | 119 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 149–165 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 203 |
| UseCollectionIsEmpty | Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() | 3 | 216 |
| UseCollectionIsEmpty | Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() | 3 | 223 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 297–304 |
