Fork me on GitHub

Résultats PMD

Le document suivant contient les résultats de PMD 5.3.5.

Fichiers

fr/paris/lutece/plugins/mylutece/modules/openiddatabase/authentication/BaseAuthentication.java

Violation Ligne
A high number of imports can indicate a high degree of coupling within an object. 34661
Possible God class (WMC=51, ATFD=89, TCC=0.03162055335968379) 34661
The class 'BaseAuthentication' has a Cyclomatic Complexity of 2 (Highest = 11). 100661
The class 'BaseAuthentication' has a Standard Cyclomatic Complexity of 2 (Highest = 10). 100661
The class 'BaseAuthentication' has a Modified Cyclomatic Complexity of 2 (Highest = 10). 100661
Possible unsafe assignment to a non-final static field in a constructor. 112
The Logger variable declaration does not contain the static and final modifiers 113
Position literals first in String comparisons 185
Document empty method 254255
Avoid declaring a variable if it is unreferenced before a possible exit point. 339
debug logging that involves string concatenation should be guarded with isDebugEnabled() checks 469
The method 'verifyResponse' has a Modified Cyclomatic Complexity of 10. 496614
The method 'verifyResponse' has a Cyclomatic Complexity of 11. 496614
The method 'verifyResponse' has a Standard Cyclomatic Complexity of 10. 496614
Avoid really long methods. 496614
debug logging that involves string concatenation should be guarded with isDebugEnabled() checks 500
Avoid appending characters as strings in StringBuffer.append. 520
debug logging that involves string concatenation should be guarded with isDebugEnabled() checks 529
debug logging that involves string concatenation should be guarded with isDebugEnabled() checks 539
Avoid empty if statements 603604

fr/paris/lutece/plugins/mylutece/modules/openiddatabase/authentication/business/IManageUsers.java

Violation Ligne
Avoid using implementation types like 'ArrayList'; use the interface instead 74
Avoid using implementation types like 'ArrayList'; use the interface instead 74
Avoid using implementation types like 'ArrayList'; use the interface instead 98
Avoid using implementation types like 'ArrayList'; use the interface instead 98

fr/paris/lutece/plugins/mylutece/modules/openiddatabase/authentication/business/OpenIdDatabaseDAO.java

Violation Ligne
Use explicit scoping instead of the default package private level 7275
Avoid using implementation types like 'ArrayList'; use the interface instead 147
Avoid using implementation types like 'ArrayList'; use the interface instead 147
Avoid using implementation types like 'ArrayList'; use the interface instead 201
Avoid using implementation types like 'ArrayList'; use the interface instead 201

fr/paris/lutece/plugins/mylutece/modules/openiddatabase/authentication/business/OpenIdDatabaseHome.java

Violation Ligne
All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 49143
Avoid using implementation types like 'ArrayList'; use the interface instead 85
Avoid using implementation types like 'ArrayList'; use the interface instead 85
Avoid using implementation types like 'ArrayList'; use the interface instead 118
Avoid using implementation types like 'ArrayList'; use the interface instead 118

fr/paris/lutece/plugins/mylutece/modules/openiddatabase/authentication/business/OpenIdDatabaseUser.java

Violation Ligne
Avoid unused imports such as 'fr.paris.lutece.portal.service.mail.MailService' 36
Avoid unused imports such as 'fr.paris.lutece.portal.service.mail.MailService' 36

fr/paris/lutece/plugins/mylutece/modules/openiddatabase/authentication/business/OpenIdDatabaseUserDAO.java

Violation Ligne
Use explicit scoping instead of the default package private level 7174

fr/paris/lutece/plugins/mylutece/modules/openiddatabase/authentication/business/OpenIdDatabaseUserHome.java

Violation Ligne
Avoid unused imports such as 'java.util.HashMap' 40
Avoid unused imports such as 'java.util.HashMap' 40

fr/paris/lutece/plugins/mylutece/modules/openiddatabase/authentication/business/PasswordRecoveryByLinkDAO.java

Violation Ligne
Use explicit scoping instead of the default package private level 7376

fr/paris/lutece/plugins/mylutece/modules/openiddatabase/authentication/web/MyLuteceOpenIdDatabaseApp.java

Violation Ligne
A high number of imports can indicate a high degree of coupling within an object. 341019
Possible God class (WMC=99, ATFD=153, TCC=0.18803418803418803) 341019
The class 'MyLuteceOpenIdDatabaseApp' has a Cyclomatic Complexity of 5 (Highest = 22). 761019
Avoid unused private fields such as '_logger'. 181
The Logger variable declaration does not contain the static and final modifiers 181
Private field '_captchaService' could be made final; it is only initialized in the declaration or constructor. 185
The method 'getPage' has a Cyclomatic Complexity of 11. 224269
Avoid declaring a variable if it is unreferenced before a possible exit point. 354
Avoid variables with short names like t 373
Avoid variables with short names like t 426
The method 'doCreateAccount' has a Cyclomatic Complexity of 22. 439516
The method doCreateAccount() has an NPath complexity of 2106 439516
These nested if statements could be combined 491494
Avoid variables with short names like t 536
Avoid variables with short names like t 562
Avoid variables with short names like t 586
The method doChangePassword() has an NPath complexity of 1134 599659
The method 'doChangePassword' has a Cyclomatic Complexity of 16. 599659
Avoid declaring a variable if it is unreferenced before a possible exit point. 607
Avoid declaring a variable if it is unreferenced before a possible exit point. 609
Avoid declaring a variable if it is unreferenced before a possible exit point. 610
Avoid declaring a variable if it is unreferenced before a possible exit point. 611
The method 'doChangePasswordLink' has a Cyclomatic Complexity of 12. 666733
The method doChangePasswordLink() has an NPath complexity of 270 666733
Avoid declaring a variable if it is unreferenced before a possible exit point. 674
Avoid declaring a variable if it is unreferenced before a possible exit point. 677
Avoid declaring a variable if it is unreferenced before a possible exit point. 678
The method 'doSendPassword' has a Cyclomatic Complexity of 12. 761823
Position literals first in String comparisons 803
Position literals first in String comparisons 803
Position literals first in String comparisons 803
Avoid using Literals in Conditional Statements 861
Avoid unused private methods such as 'getMessageUrl(HttpServletRequest,String)'. 952
The method 'doModifyUserDetails' has a Cyclomatic Complexity of 12. 9661018

fr/paris/lutece/plugins/mylutece/modules/openiddatabase/authentication/web/OpenIdDatabaseJspBean.java

Violation Ligne
The class 'OpenIdDatabaseJspBean' has a Cyclomatic Complexity of 4 (Highest = 10). 65461
Avoid unused private fields such as 'PROPERTY_PAGE_TITLE_MANAGE_GROUPS_USER'. 82
Avoid unused private fields such as 'MESSAGE_ERROR_MANAGE_GROUPS'. 92
Avoid unused private fields such as 'PARAMETER_MYLUTECE_DATABASE_GROUP_KEY'. 98
Avoid unused private fields such as 'MARK_GROUPS_LIST'. 111
Avoid unused private fields such as 'MARK_GROUPS_LIST_FOR_USER'. 112
Avoid unused private fields such as 'TEMPLATE_MANAGE_GROUPS_USER'. 120
The method 'doModifyUser' has a Cyclomatic Complexity of 10. 223268
Avoid declaring a variable if it is unreferenced before a possible exit point. 358