Fork me on GitHub

PMD Results

The following document contains the results of PMD 5.3.5.

Files

fr/paris/lutece/plugins/mylutece/modules/parisconnect/authentication/ParisConnectAuthentication.java

Violation Line
Avoid unused imports such as 'fr.paris.lutece.portal.service.security.SecurityTokenService' 41
Avoid unused imports such as 'fr.paris.lutece.portal.service.security.SecurityTokenService' 41
Avoid unused imports such as 'fr.paris.lutece.portal.service.util.AppLogService' 42
Avoid unused imports such as 'fr.paris.lutece.portal.service.util.AppLogService' 42
Avoid unused private fields such as 'TOKEN_ACTION_LOGIN'. 56
Avoid unnecessary constructors - the compiler will generate these for you 6769
Document empty constructor 6769
It is a good practice to call super() in a constructor 6769

fr/paris/lutece/plugins/mylutece/modules/parisconnect/authentication/ParisConnectUser.java

Violation Line
The field name indicates a constant but its modifiers do not 47

fr/paris/lutece/plugins/mylutece/modules/parisconnect/service/ParisConnectAPI.java

Violation Line
The Logger variable declaration does not contain the static and final modifiers 62
debug logging that involves string concatenation should be guarded with isDebugEnabled() checks 212

fr/paris/lutece/plugins/mylutece/modules/parisconnect/service/ParisConnectAPIService.java

Violation Line
Unnecessary use of fully qualified name 'org.apache.log4j.Logger.getLogger' due to existing import 'org.apache.log4j.Logger' 112
The Logger variable declaration does not contain the static and final modifiers 112
Use explicit scoping instead of the default package private level 125134
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 128
Use explicit scoping instead of the default package private level 141148
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 144
Use explicit scoping instead of the default package private level 155161
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 157
Use explicit scoping instead of the default package private level 168185
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 170
Use explicit scoping instead of the default package private level 192198
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 194
Use explicit scoping instead of the default package private level 200228
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 203
The String literal " - " appears 14 times in this file; the first occurrence is on line 218 218
Use explicit scoping instead of the default package private level 236254
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 238
Use explicit scoping instead of the default package private level 263282
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 265
Use explicit scoping instead of the default package private level 293313
Rather than using a lot of String arguments, consider using a container object for those values. 293
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 295
Use explicit scoping instead of the default package private level 321339
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 323
Use explicit scoping instead of the default package private level 347365
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 349
Use explicit scoping instead of the default package private level 372397
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 374
Avoid variables with short names like jo 384
The String literal "Account Shadow API call : mail=" appears 4 times in this file; the first occurrence is on line 389 389
Use explicit scoping instead of the default package private level 405432
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 407
Avoid variables with short names like jo 419
Rather than using a lot of String arguments, consider using a container object for those values. 440
Use explicit scoping instead of the default package private level 440471
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 442
Avoid variables with short names like jo 452
Use explicit scoping instead of the default package private level 479518
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 481
Avoid variables with short names like jo 490
Use explicit scoping instead of the default package private level 527564
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 529
Avoid variables with short names like jo 539

fr/paris/lutece/plugins/mylutece/modules/parisconnect/service/ParisConnectIncludeService.java

Violation Line
All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 56189
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 89
Assigning an Object to null is a code smell. Consider refactoring. 90
Assigning an Object to null is a code smell. Consider refactoring. 116
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 117
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 142
Assigning an Object to null is a code smell. Consider refactoring. 143
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 173
Assigning an Object to null is a code smell. Consider refactoring. 174

fr/paris/lutece/plugins/mylutece/modules/parisconnect/service/ParisConnectService.java

Violation Line
Avoid unused private fields such as 'PCUSER_BIRTHDATE'. 83
The field name indicates a constant but its modifiers do not 85
The field name indicates a constant but its modifiers do not 86
The field name indicates a constant but its modifiers do not 87
The field name indicates a constant but its modifiers do not 88
The field name indicates a constant but its modifiers do not 89
The Logger variable declaration does not contain the static and final modifiers 90
Singleton is not thread safe 107117
debug logging that involves string concatenation should be guarded with isDebugEnabled() checks 172
debug logging that involves string concatenation should be guarded with isDebugEnabled() checks 177
debug logging that involves string concatenation should be guarded with isDebugEnabled() checks 263
Rather than using a lot of String arguments, consider using a container object for those values. 325

fr/paris/lutece/plugins/mylutece/modules/parisconnect/web/MyLuteceParisConnectXPage.java

Violation Line
Avoid unused private fields such as 'VIEW_IS_USER_AUTHENTICATED'. 78
Avoid unused private fields such as 'ACTION_DO_LOGIN_JSON'. 81
Private field '_parisConnectAuthentication' could be made final; it is only initialized in the declaration or constructor. 96
Avoid unused local variables such as 'strUserUid'. 211