Fork me on GitHub

Checkstyle Results

The following document contains the results of Checkstyle 8.19 with build-config/lutece_checks.xml ruleset. 

rss feed

Summary

Files
 Info
 Warnings
 Errors
28 0 0 191

Files

File
 I
 W
 E
fr/paris/lutece/plugins/mylutece/modules/saml/authentication/SAMLAuthentication.java 0 0 4
fr/paris/lutece/plugins/mylutece/modules/saml/authentication/SAMLUser.java 0 0 2
fr/paris/lutece/plugins/mylutece/modules/saml/authentication/checkers/CertificateChecker.java 0 0 3
fr/paris/lutece/plugins/mylutece/modules/saml/authentication/checkers/RequiredAttributesChecker.java 0 0 3
fr/paris/lutece/plugins/mylutece/modules/saml/authentication/checkers/SAMLAssertionChecker.java 0 0 9
fr/paris/lutece/plugins/mylutece/modules/saml/authentication/checkers/SAMLChecker.java 0 0 4
fr/paris/lutece/plugins/mylutece/modules/saml/authentication/checkers/SAMLResponseChecker.java 0 0 8
fr/paris/lutece/plugins/mylutece/modules/saml/authentication/checkers/SignatureChecker.java 0 0 3
fr/paris/lutece/plugins/mylutece/modules/saml/authentication/config/ConfigProperties.java 0 0 14
fr/paris/lutece/plugins/mylutece/modules/saml/authentication/config/Constants.java 0 0 10
fr/paris/lutece/plugins/mylutece/modules/saml/authentication/engine/BootStrap.java 0 0 18
fr/paris/lutece/plugins/mylutece/modules/saml/authentication/engine/SAMLResponseManager.java 0 0 22
fr/paris/lutece/plugins/mylutece/modules/saml/authentication/engine/SAMLTokenExtractor.java 0 0 9
fr/paris/lutece/plugins/mylutece/modules/saml/authentication/engine/SAMLTokenHandler.java 0 0 9
fr/paris/lutece/plugins/mylutece/modules/saml/authentication/exceptions/CertificateValidationException.java 0 0 6
fr/paris/lutece/plugins/mylutece/modules/saml/authentication/exceptions/InvalidAttributeException.java 0 0 6
fr/paris/lutece/plugins/mylutece/modules/saml/authentication/exceptions/SAMLCheckerException.java 0 0 6
fr/paris/lutece/plugins/mylutece/modules/saml/authentication/exceptions/SAMLParsingException.java 0 0 6
fr/paris/lutece/plugins/mylutece/modules/saml/authentication/exceptions/SAMLReponseCheckerException.java 0 0 6
fr/paris/lutece/plugins/mylutece/modules/saml/authentication/exceptions/SAMLTokenExtractorException.java 0 0 6
fr/paris/lutece/plugins/mylutece/modules/saml/authentication/exceptions/SignatureValidationException.java 0 0 6
fr/paris/lutece/plugins/mylutece/modules/saml/authentication/metadata/IDPMetadataManager.java 0 0 6
fr/paris/lutece/plugins/mylutece/modules/saml/authentication/metadata/MetadataManager.java 0 0 10
fr/paris/lutece/plugins/mylutece/modules/saml/authentication/metadata/SPMetadataManager.java 0 0 9
fr/paris/lutece/plugins/mylutece/modules/saml/authentication/util/X509CertificateHelper.java 0 0 4
fr/paris/lutece/plugins/mylutece/modules/saml/service/SAMLPlugin.java 0 0 1
fr/paris/lutece/plugins/mylutece/modules/saml/service/SAMLService.java 0 0 1

Rules

Category Rule Violations Severity
coding ExplicitInitialization 9
 Error
HiddenField 3
 Error
InnerAssignment 1
 Error
InnerAssignment 1
 Error
ParameterAssignment 2
 Error
design HideUtilityClassConstructor 2
 Error
InterfaceIsType 1
 Error
VisibilityModifier 1
 Error
header Header
  • fileExtensions: "java"
  • headerFile: "/var/jenkins_home/jobs/admin-github-build/workspace/target/checkstyle-header.txt"
27
 Error
javadoc JavadocMethod 100
 Error
JavadocType 25
 Error
modifier RedundantModifier 8
 Error
naming LocalVariableName
  • format: "^[a-z][a-zA-Z0-9]*$"
3
 Error
MemberName
  • format: "^_[a-z](_?[a-zA-Z0-9])*$"
7
 Error
StaticVariableName
  • format: "^_[a-z](_?[a-zA-Z0-9])*$"
2
 Error

Details

fr/paris/lutece/plugins/mylutece/modules/saml/authentication/SAMLAuthentication.java

Severity Category Rule Message Line
 Error
header Header Line does not match expected header line of ' * Copyright (c) 2002-2020, City of Paris'. 2
 Error
javadoc JavadocType Missing a Javadoc comment. 62
 Error
javadoc JavadocMethod Missing a Javadoc comment. 173
 Error
javadoc JavadocMethod Missing a Javadoc comment. 203

fr/paris/lutece/plugins/mylutece/modules/saml/authentication/SAMLUser.java

Severity Category Rule Message Line
 Error
header Header Line does not match expected header line of ' * Copyright (c) 2002-2020, City of Paris'. 2
 Error
javadoc JavadocType Missing a Javadoc comment. 40

fr/paris/lutece/plugins/mylutece/modules/saml/authentication/checkers/CertificateChecker.java

Severity Category Rule Message Line
 Error
header Header Line does not match expected header line of ' * Copyright (c) 2002-2020, City of Paris'. 2
 Error
javadoc JavadocType Missing a Javadoc comment. 49
 Error
javadoc JavadocMethod Missing a Javadoc comment. 51

fr/paris/lutece/plugins/mylutece/modules/saml/authentication/checkers/RequiredAttributesChecker.java

Severity Category Rule Message Line
 Error
header Header Line does not match expected header line of ' * Copyright (c) 2002-2020, City of Paris'. 2
 Error
javadoc JavadocType Missing a Javadoc comment. 49
 Error
javadoc JavadocMethod Missing a Javadoc comment. 51

fr/paris/lutece/plugins/mylutece/modules/saml/authentication/checkers/SAMLAssertionChecker.java

Severity Category Rule Message Line
 Error
header Header Line does not match expected header line of ' * Copyright (c) 2002-2020, City of Paris'. 2
 Error
javadoc JavadocType Missing a Javadoc comment. 48
 Error
javadoc JavadocMethod Missing a Javadoc comment. 50
 Error
javadoc JavadocMethod Expected @param tag for 'responseManager'. 74
 Error
javadoc JavadocMethod Expected @throws tag for 'SAMLReponseCheckerException'. 75
 Error
javadoc JavadocMethod Expected @param tag for 'responseManager'. 96
 Error
javadoc JavadocMethod Expected @throws tag for 'SAMLReponseCheckerException'. 97
 Error
javadoc JavadocMethod Expected @param tag for 'responseManager'. 120
 Error
javadoc JavadocMethod Expected @throws tag for 'SAMLReponseCheckerException'. 121

fr/paris/lutece/plugins/mylutece/modules/saml/authentication/checkers/SAMLChecker.java

Severity Category Rule Message Line
 Error
header Header Line does not match expected header line of ' * Copyright (c) 2002-2020, City of Paris'. 2
 Error
javadoc JavadocType Missing a Javadoc comment. 41
 Error
javadoc JavadocMethod Missing a Javadoc comment. 43
 Error
modifier RedundantModifier Redundant 'public' modifier. 43

fr/paris/lutece/plugins/mylutece/modules/saml/authentication/checkers/SAMLResponseChecker.java

Severity Category Rule Message Line
 Error
header Header Line does not match expected header line of ' * Copyright (c) 2002-2020, City of Paris'. 2
 Error
javadoc JavadocType Missing a Javadoc comment. 46
 Error
javadoc JavadocMethod Missing a Javadoc comment. 48
 Error
javadoc JavadocMethod Expected @param tag for 'responseManager'. 68
 Error
javadoc JavadocMethod Expected @throws tag for 'SAMLReponseCheckerException'. 69
 Error
javadoc JavadocMethod Expected @param tag for 'responseManager'. 91
 Error
javadoc JavadocMethod Expected @throws tag for 'SAMLParsingException'. 92
 Error
javadoc JavadocMethod Expected @throws tag for 'SAMLReponseCheckerException'. 92

fr/paris/lutece/plugins/mylutece/modules/saml/authentication/checkers/SignatureChecker.java

Severity Category Rule Message Line
 Error
header Header Line does not match expected header line of ' * Copyright (c) 2002-2020, City of Paris'. 2
 Error
javadoc JavadocType Missing a Javadoc comment. 55
 Error
javadoc JavadocMethod Missing a Javadoc comment. 57

fr/paris/lutece/plugins/mylutece/modules/saml/authentication/config/ConfigProperties.java

Severity Category Rule Message Line
 Error
header Header Line does not match expected header line of ' * Copyright (c) 2002-2020, City of Paris'. 2
 Error
javadoc JavadocType Missing a Javadoc comment. 47
 Error
naming StaticVariableName Name 'instance' must match pattern '^_[a-z](_?[a-zA-Z0-9])*$'. 50
 Error
coding ExplicitInitialization Variable 'instance' explicitly initialized to 'null' (default value for its type). 50
 Error
naming MemberName Name 'isTest' must match pattern '^_[a-z](_?[a-zA-Z0-9])*$'. 51
 Error
coding ExplicitInitialization Variable 'isTest' explicitly initialized to 'false' (default value for its type). 51
 Error
javadoc JavadocMethod Missing a Javadoc comment. 53
 Error
javadoc JavadocMethod Missing a Javadoc comment. 73
 Error
javadoc JavadocMethod Missing a Javadoc comment. 78
 Error
coding HiddenField 'isTest' hides a field. 78
 Error
javadoc JavadocMethod Missing a Javadoc comment. 83
 Error
javadoc JavadocMethod Missing a Javadoc comment. 91
 Error
javadoc JavadocMethod Missing a Javadoc comment. 101
 Error
coding InnerAssignment Inner assignments should be avoided. 154

fr/paris/lutece/plugins/mylutece/modules/saml/authentication/config/Constants.java

Severity Category Rule Message Line
 Error
header Header Line does not match expected header line of ' * Copyright (c) 2002-2020, City of Paris'. 2
 Error
javadoc JavadocType Missing a Javadoc comment. 36
 Error
design InterfaceIsType interfaces should describe a type and hence have methods. 36
 Error
modifier RedundantModifier Redundant 'public' modifier. 38
 Error
modifier RedundantModifier Redundant 'public' modifier. 39
 Error
modifier RedundantModifier Redundant 'public' modifier. 40
 Error
modifier RedundantModifier Redundant 'public' modifier. 41
 Error
modifier RedundantModifier Redundant 'public' modifier. 42
 Error
modifier RedundantModifier Redundant 'public' modifier. 43
 Error
modifier RedundantModifier Redundant 'public' modifier. 44

fr/paris/lutece/plugins/mylutece/modules/saml/authentication/engine/BootStrap.java

Severity Category Rule Message Line
 Error
header Header Line does not match expected header line of ' * Copyright (c) 2002-2020, City of Paris'. 2
 Error
javadoc JavadocType Missing a Javadoc comment. 55
 Error
naming StaticVariableName Name 'instance' must match pattern '^_[a-z](_?[a-zA-Z0-9])*$'. 57
 Error
coding ExplicitInitialization Variable 'instance' explicitly initialized to 'null' (default value for its type). 57
 Error
naming MemberName Name 'idpMetaDataManager' must match pattern '^_[a-z](_?[a-zA-Z0-9])*$'. 58
 Error
coding ExplicitInitialization Variable 'idpMetaDataManager' explicitly initialized to 'null' (default value for its type). 58
 Error
naming MemberName Name 'spMetaDataManager' must match pattern '^_[a-z](_?[a-zA-Z0-9])*$'. 59
 Error
coding ExplicitInitialization Variable 'spMetaDataManager' explicitly initialized to 'null' (default value for its type). 59
 Error
naming MemberName Name 'trustEngine' must match pattern '^_[a-z](_?[a-zA-Z0-9])*$'. 60
 Error
coding ExplicitInitialization Variable 'trustEngine' explicitly initialized to 'null' (default value for its type). 60
 Error
javadoc JavadocMethod Missing a Javadoc comment. 62
 Error
javadoc JavadocMethod Missing a Javadoc comment. 94
 Error
javadoc JavadocMethod Missing a Javadoc comment. 99
 Error
javadoc JavadocMethod Missing a Javadoc comment. 104
 Error
javadoc JavadocMethod Missing a Javadoc comment. 109
 Error
javadoc JavadocMethod Missing a Javadoc comment. 117
 Error
javadoc JavadocMethod Missing a Javadoc comment. 122
 Error
javadoc JavadocMethod Missing a Javadoc comment. 153

fr/paris/lutece/plugins/mylutece/modules/saml/authentication/engine/SAMLResponseManager.java

Severity Category Rule Message Line
 Error
header Header Line does not match expected header line of ' * Copyright (c) 2002-2020, City of Paris'. 2
 Error
javadoc JavadocType Missing a Javadoc comment. 76
 Error
naming MemberName Name 'response' must match pattern '^_[a-z](_?[a-zA-Z0-9])*$'. 78
 Error
coding ExplicitInitialization Variable 'response' explicitly initialized to 'null' (default value for its type). 78
 Error
coding HiddenField 'response' hides a field. 85
 Error
javadoc JavadocMethod Expected @param tag for 'response'. 85
 Error
javadoc JavadocMethod Expected @throws tag for 'SAMLParsingException'. 85
 Error
coding HiddenField 'response' hides a field. 97
 Error
javadoc JavadocMethod Expected @param tag for 'response'. 97
 Error
javadoc JavadocMethod Expected @throws tag for 'SAMLParsingException'. 97
 Error
javadoc JavadocMethod Expected @throws tag for 'SAMLParsingException'. 120
 Error
javadoc JavadocMethod Expected @throws tag for 'SAMLParsingException'. 142
 Error
javadoc JavadocMethod Expected @param tag for 'attribute'. 306
 Error
javadoc JavadocMethod Expected @param tag for 'attribute'. 330
 Error
javadoc JavadocMethod Expected @return tag. 351
 Error
javadoc JavadocMethod Expected @return tag. 363
 Error
javadoc JavadocMethod Expected @throws tag for 'SAMLParsingException'. 364
 Error
javadoc JavadocMethod Expected @return tag. 400
 Error
javadoc JavadocMethod Expected @param tag for 'requestedAttributes'. 414
 Error
javadoc JavadocMethod Expected @return tag. 452
 Error
javadoc JavadocMethod Expected @param tag for 'requestedAttributes'. 452
 Error
javadoc JavadocMethod Expected @return tag. 539

fr/paris/lutece/plugins/mylutece/modules/saml/authentication/engine/SAMLTokenExtractor.java

Severity Category Rule Message Line
 Error
header Header Line does not match expected header line of ' * Copyright (c) 2002-2020, City of Paris'. 2
 Error
javadoc JavadocType Missing a Javadoc comment. 60
 Error
design HideUtilityClassConstructor Utility classes should not have a public or default constructor. 60
 Error
javadoc JavadocMethod Expected @return tag. 68
 Error
javadoc JavadocMethod Expected @param tag for 'request'. 68
 Error
javadoc JavadocMethod Expected @throws tag for 'SAMLTokenExtractorException'. 69
 Error
naming LocalVariableName Name 'SAMLResponseB64Str' must match pattern '^[a-z][a-zA-Z0-9]*$'. 74
 Error
naming LocalVariableName Name 'SAMLResponseStr' must match pattern '^[a-z][a-zA-Z0-9]*$'. 77
 Error
naming LocalVariableName Name 'ResponseRoot' must match pattern '^[a-z][a-zA-Z0-9]*$'. 100

fr/paris/lutece/plugins/mylutece/modules/saml/authentication/engine/SAMLTokenHandler.java

Severity Category Rule Message Line
 Error
header Header Line does not match expected header line of ' * Copyright (c) 2002-2020, City of Paris'. 2
 Error
javadoc JavadocType Missing a Javadoc comment. 53
 Error
naming MemberName Name 'responseManager' must match pattern '^_[a-z](_?[a-zA-Z0-9])*$'. 55
 Error
coding ExplicitInitialization Variable 'responseManager' explicitly initialized to 'null' (default value for its type). 55
 Error
javadoc JavadocMethod Missing a Javadoc comment. 57
 Error
javadoc JavadocMethod Missing a Javadoc comment. 62
 Error
javadoc JavadocMethod Expected @throws tag for 'SAMLParsingException'. 98
 Error
javadoc JavadocMethod Expected @throws tag for 'SAMLParsingException'. 111
 Error
javadoc JavadocMethod Expected @throws tag for 'SAMLParsingException'. 124

fr/paris/lutece/plugins/mylutece/modules/saml/authentication/exceptions/CertificateValidationException.java

Severity Category Rule Message Line
 Error
header Header Line does not match expected header line of ' * Copyright (c) 2002-2020, City of Paris'. 2
 Error
javadoc JavadocType Missing a Javadoc comment. 36
 Error
javadoc JavadocMethod Missing a Javadoc comment. 43
 Error
javadoc JavadocMethod Missing a Javadoc comment. 50
 Error
javadoc JavadocMethod Missing a Javadoc comment. 57
 Error
javadoc JavadocMethod Missing a Javadoc comment. 64

fr/paris/lutece/plugins/mylutece/modules/saml/authentication/exceptions/InvalidAttributeException.java

Severity Category Rule Message Line
 Error
header Header Line does not match expected header line of ' * Copyright (c) 2002-2020, City of Paris'. 2
 Error
javadoc JavadocType Missing a Javadoc comment. 36
 Error
javadoc JavadocMethod Missing a Javadoc comment. 43
 Error
javadoc JavadocMethod Missing a Javadoc comment. 50
 Error
javadoc JavadocMethod Missing a Javadoc comment. 57
 Error
javadoc JavadocMethod Missing a Javadoc comment. 64

fr/paris/lutece/plugins/mylutece/modules/saml/authentication/exceptions/SAMLCheckerException.java

Severity Category Rule Message Line
 Error
header Header Line does not match expected header line of ' * Copyright (c) 2002-2020, City of Paris'. 2
 Error
javadoc JavadocType Missing a Javadoc comment. 36
 Error
javadoc JavadocMethod Missing a Javadoc comment. 43
 Error
javadoc JavadocMethod Missing a Javadoc comment. 50
 Error
javadoc JavadocMethod Missing a Javadoc comment. 57
 Error
javadoc JavadocMethod Missing a Javadoc comment. 64

fr/paris/lutece/plugins/mylutece/modules/saml/authentication/exceptions/SAMLParsingException.java

Severity Category Rule Message Line
 Error
header Header Line does not match expected header line of ' * Copyright (c) 2002-2020, City of Paris'. 2
 Error
javadoc JavadocType Missing a Javadoc comment. 36
 Error
javadoc JavadocMethod Missing a Javadoc comment. 40
 Error
javadoc JavadocMethod Missing a Javadoc comment. 47
 Error
javadoc JavadocMethod Missing a Javadoc comment. 54
 Error
javadoc JavadocMethod Missing a Javadoc comment. 61

fr/paris/lutece/plugins/mylutece/modules/saml/authentication/exceptions/SAMLReponseCheckerException.java

Severity Category Rule Message Line
 Error
header Header Line does not match expected header line of ' * Copyright (c) 2002-2020, City of Paris'. 2
 Error
javadoc JavadocType Missing a Javadoc comment. 36
 Error
javadoc JavadocMethod Missing a Javadoc comment. 43
 Error
javadoc JavadocMethod Missing a Javadoc comment. 50
 Error
javadoc JavadocMethod Missing a Javadoc comment. 57
 Error
javadoc JavadocMethod Missing a Javadoc comment. 64

fr/paris/lutece/plugins/mylutece/modules/saml/authentication/exceptions/SAMLTokenExtractorException.java

Severity Category Rule Message Line
 Error
header Header Line does not match expected header line of ' * Copyright (c) 2002-2020, City of Paris'. 2
 Error
javadoc JavadocType Missing a Javadoc comment. 36
 Error
javadoc JavadocMethod Missing a Javadoc comment. 40
 Error
javadoc JavadocMethod Missing a Javadoc comment. 47
 Error
javadoc JavadocMethod Missing a Javadoc comment. 54
 Error
javadoc JavadocMethod Missing a Javadoc comment. 61

fr/paris/lutece/plugins/mylutece/modules/saml/authentication/exceptions/SignatureValidationException.java

Severity Category Rule Message Line
 Error
header Header Line does not match expected header line of ' * Copyright (c) 2002-2020, City of Paris'. 2
 Error
javadoc JavadocType Missing a Javadoc comment. 36
 Error
javadoc JavadocMethod Missing a Javadoc comment. 43
 Error
javadoc JavadocMethod Missing a Javadoc comment. 50
 Error
javadoc JavadocMethod Missing a Javadoc comment. 57
 Error
javadoc JavadocMethod Missing a Javadoc comment. 64

fr/paris/lutece/plugins/mylutece/modules/saml/authentication/metadata/IDPMetadataManager.java

Severity Category Rule Message Line
 Error
header Header Line does not match expected header line of ' * Copyright (c) 2002-2020, City of Paris'. 2
 Error
javadoc JavadocType Missing a Javadoc comment. 61
 Error
javadoc JavadocMethod Missing a Javadoc comment. 63
 Error
javadoc JavadocMethod Missing a Javadoc comment. 68
 Error
coding ParameterAssignment Assignment of parameter 'inFilePath' is not allowed. 79
 Error
javadoc JavadocMethod Expected @throws tag for 'CertificateValidationException'. 139

fr/paris/lutece/plugins/mylutece/modules/saml/authentication/metadata/MetadataManager.java

Severity Category Rule Message Line
 Error
header Header Line does not match expected header line of ' * Copyright (c) 2002-2020, City of Paris'. 2
 Error
javadoc JavadocType Missing a Javadoc comment. 60
 Error
naming MemberName Name 'metaData' must match pattern '^_[a-z](_?[a-zA-Z0-9])*$'. 63
 Error
coding ExplicitInitialization Variable 'metaData' explicitly initialized to 'null' (default value for its type). 63
 Error
design VisibilityModifier Variable 'metaData' must be private and have accessor methods. 63
 Error
javadoc JavadocMethod Missing a Javadoc comment. 65
 Error
javadoc JavadocMethod Missing a Javadoc comment. 69
 Error
javadoc JavadocMethod Missing a Javadoc comment. 128
 Error
javadoc JavadocMethod Missing a Javadoc comment. 130
 Error
javadoc JavadocMethod Missing a Javadoc comment. 132

fr/paris/lutece/plugins/mylutece/modules/saml/authentication/metadata/SPMetadataManager.java

Severity Category Rule Message Line
 Error
header Header Line does not match expected header line of ' * Copyright (c) 2002-2020, City of Paris'. 2
 Error
javadoc JavadocType Missing a Javadoc comment. 54
 Error
coding ParameterAssignment Assignment of parameter 'inFilePath' is not allowed. 64
 Error
javadoc JavadocMethod Expected @throws tag for 'SAMLParsingException'. 75
 Error
javadoc JavadocMethod Expected @return tag. 113
 Error
javadoc JavadocMethod Expected @throws tag for 'SAMLParsingException'. 114
 Error
javadoc JavadocMethod Missing a Javadoc comment. 119
 Error
javadoc JavadocMethod Missing a Javadoc comment. 124
 Error
javadoc JavadocMethod Missing a Javadoc comment. 129

fr/paris/lutece/plugins/mylutece/modules/saml/authentication/util/X509CertificateHelper.java

Severity Category Rule Message Line
 Error
header Header Line does not match expected header line of ' * Copyright (c) 2002-2020, City of Paris'. 2
 Error
javadoc JavadocType Missing a Javadoc comment. 48
 Error
design HideUtilityClassConstructor Utility classes should not have a public or default constructor. 48
 Error
javadoc JavadocMethod Missing a Javadoc comment. 50

fr/paris/lutece/plugins/mylutece/modules/saml/service/SAMLPlugin.java

Severity Category Rule Message Line
 Error
header Header Line does not match expected header line of ' * Copyright (c) 2002-2020, City of Paris'. 2

fr/paris/lutece/plugins/mylutece/modules/saml/service/SAMLService.java

Severity Category Rule Message Line
 Error
header Header Line does not match expected header line of ' * Copyright (c) 2002-2020, City of Paris'. 2