Fork me on GitHub

Résultats PMD

Le document suivant contient les résultats de PMD 5.3.5.

Fichiers

fr/paris/lutece/plugins/mylutece/modules/wssodatabase/authentication/IdxWSSODatabaseAuthentication.java

Violation Ligne
Avoid unnecessary constructors - the compiler will generate these for you 6971
Document empty constructor 6971
It is a good practice to call super() in a constructor 6971
Document empty method 128129
Deeply nested if..then statements are hard to read 207210

fr/paris/lutece/plugins/mylutece/modules/wssodatabase/authentication/business/IdxWSSODatabaseDAO.java

Violation Ligne
Use explicit scoping instead of the default package private level 6770

fr/paris/lutece/plugins/mylutece/modules/wssodatabase/authentication/business/WssoUser.java

Violation Ligne
Singleton is not thread safe 6165

fr/paris/lutece/plugins/mylutece/modules/wssodatabase/authentication/business/WssoUserDAO.java

Violation Ligne
Use explicit scoping instead of the default package private level 7376

fr/paris/lutece/plugins/mylutece/modules/wssodatabase/authentication/business/WssoUserRoleDAO.java

Violation Ligne
Use explicit scoping instead of the default package private level 6972

fr/paris/lutece/plugins/mylutece/modules/wssodatabase/authentication/business/WssoUserRoleRemovalListener.java

Violation Ligne
Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 67
Avoid unnecessary if..then..else statements when returning booleans 6770

fr/paris/lutece/plugins/mylutece/modules/wssodatabase/authentication/security/WSSOSessionTrackingFilter.java

Violation Ligne
Document empty method 6768
Deeply nested if..then statements are hard to read 100110

fr/paris/lutece/plugins/mylutece/modules/wssodatabase/authentication/service/WssoDatabaseService.java

Violation Ligne
The class 'WssoDatabaseService' has a Standard Cyclomatic Complexity of 6 (Highest = 10). 62227
The class 'WssoDatabaseService' has a Cyclomatic Complexity of 6 (Highest = 10). 62227
The class 'WssoDatabaseService' has a Modified Cyclomatic Complexity of 6 (Highest = 10). 62227
The field name indicates a constant but its modifiers do not 70
The method 'init' has a Standard Cyclomatic Complexity of 10. 79143
The method 'init' has a Cyclomatic Complexity of 10. 79143
The method 'init' has a Modified Cyclomatic Complexity of 10. 79143
Deeply nested if..then statements are hard to read 106128

fr/paris/lutece/plugins/mylutece/modules/wssodatabase/authentication/util/LdapBrowser.java

Violation Ligne
The class 'LdapBrowser' has a Standard Cyclomatic Complexity of 2 (Highest = 10). 59479
The class 'LdapBrowser' has a Modified Cyclomatic Complexity of 2 (Highest = 10). 59479
The class 'LdapBrowser' has a Cyclomatic Complexity of 3 (Highest = 11). 59479
Avoid excessively long variable names like PROPERTY_USER_DN_SEARCH_FILTER_BY_CRITERIA_GIVENNAME 69
Document empty constructor 113115
Avoid unnecessary constructors - the compiler will generate these for you 113115
Avoid really long methods. 124225
The method 'getUserList' has a Cyclomatic Complexity of 10. 124225
Avoid variables with short names like sr 127
The method 'getUserPublicData' has a Cyclomatic Complexity of 11. 232334
Avoid really long methods. 232334
The method 'getUserPublicData' has a Modified Cyclomatic Complexity of 10. 232334
The method 'getUserPublicData' has a Standard Cyclomatic Complexity of 10. 232334
Avoid variables with short names like sr 235
Avoid using Literals in Conditional Statements 301
Avoid variables with short names like in 341
Avoid prefixing parameters by in, out or inOut. Uses Javadoc to document this behavior. 341
Avoid variables with short names like sb 353
StringBuffer constructor is initialized with size 16, but has at least 26 characters appended. 353
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 354
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 355
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 356
Position literals first in String comparisons for EqualsIgnoreCase 433
Consider using varargs for methods or constructors which take an array the last parameter. 463
Prefer StringBuffer over += for concatenating strings 471
Prefer StringBuffer over += for concatenating strings 475

fr/paris/lutece/plugins/mylutece/modules/wssodatabase/authentication/util/LdapUtil.java

Violation Ligne
Rather than using a lot of String arguments, consider using a container object for those values. 6869
Consider replacing this Hashtable with the newer java.util.Map 71
Rather than using a lot of String arguments, consider using a container object for those values. 106
Consider replacing this Hashtable with the newer java.util.Map 111
Avoid variables with short names like sc 134

fr/paris/lutece/plugins/mylutece/modules/wssodatabase/authentication/web/WssodatabaseJspBean.java

Violation Ligne
Avoid unnecessary constructors - the compiler will generate these for you 117119
Document empty constructor 117119
It is a good practice to call super() in a constructor 117119
Position literals first in String comparisons 163
Position literals first in String comparisons 163
Position literals first in String comparisons 163
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 170
Avoid declaring a variable if it is unreferenced before a possible exit point. 196
Avoid declaring a variable if it is unreferenced before a possible exit point. 197
Avoid declaring a variable if it is unreferenced before a possible exit point. 198
Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 215

fr/paris/lutece/plugins/mylutece/modules/wssodatabase/service/AutoExportWssoUsersFile.java

Violation Ligne
All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 4466
Document empty constructor 5153
Avoid unnecessary constructors - the compiler will generate these for you 5153
Use block level rather than method level synchronization 6065

fr/paris/lutece/plugins/mylutece/modules/wssodatabase/service/WssoUsersFileGeneratorService.java

Violation Ligne
All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 61216
Avoid excessively long variable names like PROPERTY_XMLFILEFORMAT_ATTR_APPLICATION_WSSO_APP_ID 74
Document empty constructor 8890
Avoid unnecessary constructors - the compiler will generate these for you 8890
When instantiating a SimpleDateFormat object, specify a Locale 116
Avoid catching NullPointerException; consider removing the cause of the NPE. 191
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 191

fr/paris/lutece/plugins/mylutece/modules/wssodatabase/service/daemon/ExportWssoUsersDaemon.java

Violation Ligne
Avoid unnecessary constructors - the compiler will generate these for you 5355
It is a good practice to call super() in a constructor 5355
Document empty constructor 5355