The following document contains the results of PMD 6.13.0.
| Rule | Violation | Line |
|---|---|---|
| AvoidThrowingRawExceptionTypes | Avoid throwing raw exception types. | 122 |
| Rule | Violation | Line |
|---|---|---|
| AvoidThrowingRawExceptionTypes | Avoid throwing raw exception types. | 112 |
| Rule | Violation | Line |
|---|---|---|
| MethodNamingConventions | The instance method name 'process_CAMPAIGN_CLONED' doesn't match '[a-z][a-zA-Z0-9]*' | 74–91 |
| MethodNamingConventions | The instance method name 'process_CAMPAIGN_CODE_MODIFICATION_AUTHORISATION' doesn't match '[a-z][a-zA-Z0-9]*' | 98–111 |
| MethodNamingConventions | The instance method name 'process_CAMPAIGN_CODE_MODIFIED' doesn't match '[a-z][a-zA-Z0-9]*' | 113–119 |
| Rule | Violation | Line |
|---|---|---|
| FieldNamingConventions | The field name 'dataFromBudget' doesn't match '_[a-z][a-zA-Z0-9]*' | 49 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Public method and constructor comments are required | 66–74 |
| NonThreadSafeSingleton | Singleton is not thread safe | 68–71 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 89 |
| AddEmptyString | Do not add empty strings | 114 |
| AddEmptyString | Do not add empty strings | 116 |
| Rule | Violation | Line |
|---|---|---|
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 73 |
| AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 101 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 119 |
| Rule | Violation | Line |
|---|---|---|
| SignatureDeclareThrowsException | A method/constructor should not explicitly throw java.lang.Exception | 54 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'exportToParticipatoryBudgetAction': the method is declared in an interface type | 54 |
| Rule | Violation | Line |
|---|---|---|
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 73 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 109 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 59–129 |
| ImmutableField | Private field '_commentService' could be made final; it is only initialized in the declaration or constructor. | 65 |
| ImmutableField | Private field '_solrProposalIndexer' could be made final; it is only initialized in the declaration or constructor. | 66 |
| ImmutableField | Private field '_commentDAO' could be made final; it is only initialized in the declaration or constructor. | 67 |
| UseUnderscoresInNumericLiterals | Number 10000 should separate every third digit with an underscore | 76 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 48–121 |
| SwitchStmtsShouldHaveDefault | Switch statements should have a default label | 54–64 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Public method and constructor comments are required | 62–69 |
| NonThreadSafeSingleton | Singleton is not thread safe | 64–67 |
| CommentRequired | Public method and constructor comments are required | 76–80 |
| CommentRequired | Public method and constructor comments are required | 87–91 |
| CommentRequired | Public method and constructor comments are required | 93–97 |
| CommentRequired | Public method and constructor comments are required | 99–103 |
| CommentRequired | Public method and constructor comments are required | 105–109 |
| CommentRequired | Public method and constructor comments are required | 111–115 |
| CommentRequired | Public method and constructor comments are required | 117–121 |
| CommentRequired | Public method and constructor comments are required | 123–127 |
| CommentRequired | Public method and constructor comments are required | 129–133 |
| CommentRequired | Public method and constructor comments are required | 135–139 |
| CommentRequired | Public method and constructor comments are required | 141–145 |
| CommentRequired | Public method and constructor comments are required | 152–156 |
| CommentRequired | Public method and constructor comments are required | 158–162 |
| CommentRequired | Public method and constructor comments are required | 164–168 |
| CommentRequired | Public method and constructor comments are required | 170–174 |
| CommentRequired | Public method and constructor comments are required | 176–180 |
| CommentRequired | Public method and constructor comments are required | 182–186 |
| CommentRequired | Public method and constructor comments are required | 188–198 |
| CommentRequired | Public method and constructor comments are required | 200–210 |
| CommentRequired | Public method and constructor comments are required | 217–221 |
| CommentRequired | Public method and constructor comments are required | 223–227 |
| CommentRequired | Public method and constructor comments are required | 229–233 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Public method and constructor comments are required | 3 | 66–74 |
| NonThreadSafeSingleton | Singleton is not thread safe | 3 | 68–71 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 89 |
| AddEmptyString | Do not add empty strings | 3 | 114 |
| AddEmptyString | Do not add empty strings | 3 | 116 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 73 |
| AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 3 | 101 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 119 |
| AvoidThrowingRawExceptionTypes | Avoid throwing raw exception types. | 1 | 122 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| SignatureDeclareThrowsException | A method/constructor should not explicitly throw java.lang.Exception | 3 | 54 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'exportToParticipatoryBudgetAction': the method is declared in an interface type | 3 | 54 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 73 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 109 |
| AvoidThrowingRawExceptionTypes | Avoid throwing raw exception types. | 1 | 112 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 59–129 |
| ImmutableField | Private field '_commentService' could be made final; it is only initialized in the declaration or constructor. | 3 | 65 |
| ImmutableField | Private field '_solrProposalIndexer' could be made final; it is only initialized in the declaration or constructor. | 3 | 66 |
| ImmutableField | Private field '_commentDAO' could be made final; it is only initialized in the declaration or constructor. | 3 | 67 |
| UseUnderscoresInNumericLiterals | Number 10000 should separate every third digit with an underscore | 3 | 76 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 48–121 |
| SwitchStmtsShouldHaveDefault | Switch statements should have a default label | 3 | 54–64 |
| MethodNamingConventions | The instance method name 'process_CAMPAIGN_CLONED' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 74–91 |
| MethodNamingConventions | The instance method name 'process_CAMPAIGN_CODE_MODIFICATION_AUTHORISATION' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 98–111 |
| MethodNamingConventions | The instance method name 'process_CAMPAIGN_CODE_MODIFIED' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 113–119 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Public method and constructor comments are required | 3 | 62–69 |
| NonThreadSafeSingleton | Singleton is not thread safe | 3 | 64–67 |
| CommentRequired | Public method and constructor comments are required | 3 | 76–80 |
| CommentRequired | Public method and constructor comments are required | 3 | 87–91 |
| CommentRequired | Public method and constructor comments are required | 3 | 93–97 |
| CommentRequired | Public method and constructor comments are required | 3 | 99–103 |
| CommentRequired | Public method and constructor comments are required | 3 | 105–109 |
| CommentRequired | Public method and constructor comments are required | 3 | 111–115 |
| CommentRequired | Public method and constructor comments are required | 3 | 117–121 |
| CommentRequired | Public method and constructor comments are required | 3 | 123–127 |
| CommentRequired | Public method and constructor comments are required | 3 | 129–133 |
| CommentRequired | Public method and constructor comments are required | 3 | 135–139 |
| CommentRequired | Public method and constructor comments are required | 3 | 141–145 |
| CommentRequired | Public method and constructor comments are required | 3 | 152–156 |
| CommentRequired | Public method and constructor comments are required | 3 | 158–162 |
| CommentRequired | Public method and constructor comments are required | 3 | 164–168 |
| CommentRequired | Public method and constructor comments are required | 3 | 170–174 |
| CommentRequired | Public method and constructor comments are required | 3 | 176–180 |
| CommentRequired | Public method and constructor comments are required | 3 | 182–186 |
| CommentRequired | Public method and constructor comments are required | 3 | 188–198 |
| CommentRequired | Public method and constructor comments are required | 3 | 200–210 |
| CommentRequired | Public method and constructor comments are required | 3 | 217–221 |
| CommentRequired | Public method and constructor comments are required | 3 | 223–227 |
| CommentRequired | Public method and constructor comments are required | 3 | 229–233 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| FieldNamingConventions | The field name 'dataFromBudget' doesn't match '_[a-z][a-zA-Z0-9]*' | 1 | 49 |
