PMD Results
The following document contains the results of PMD 5.3.5.
Files
fr/paris/lutece/plugins/quiz/modules/games/business/QuizParticipant.java
| Violation |
Line |
| Avoid unnecessary constructors - the compiler will generate these for you |
54–56 |
| Document empty constructor |
54–56 |
| A getX() method which returns a boolean should be named isX() |
153–156 |
fr/paris/lutece/plugins/quiz/modules/games/business/QuizParticipantDAO.java
| Violation |
Line |
| Avoid excessively long variable names like SQL_QUERY_SELECT_PARTICIPANTS_BY_IDENTIFIANT_AND_QUIZ_ID |
51 |
| Use explicit scoping instead of the default package private level |
60–77 |
fr/paris/lutece/plugins/quiz/modules/games/business/portlet/QuizPortlet.java
| Violation |
Line |
| It is a good practice to call super() in a constructor |
67–70 |
fr/paris/lutece/plugins/quiz/modules/games/business/portlet/QuizPortletDAO.java
| Violation |
Line |
| Avoid variables with short names like p |
61 |
| Avoid variables with short names like p |
91 |
fr/paris/lutece/plugins/quiz/modules/games/business/portlet/QuizPortletHome.java
| Violation |
Line |
| Avoid using redundant field initializer for '_singleton' |
52 |
| Possible unsafe assignment to a non-final static field in a constructor. |
52 |
| It is a good practice to call super() in a constructor |
57–63 |
| Singleton is not thread safe |
85–88 |
fr/paris/lutece/plugins/quiz/modules/games/web/RandApp.java
| Violation |
Line |
| Avoid unused private fields such as 'TEMPLATE_QUESTIONS_LIST'. |
68 |
| Avoid unused private fields such as 'PROPERTY_QUIZ_PAGE_PATH'. |
74 |
| Avoid unused private fields such as 'PROPERTY_QUIZ_PAGE_TITLE'. |
75 |
| Avoid unused private fields such as 'PARAMETER_RESULTS'. |
78 |
| Avoid unused private fields such as 'PARAMETER_ACTION'. |
79 |
| Private field '_randService' could be made final; it is only initialized in the declaration or constructor. |
88 |
| Avoid declaring a variable if it is unreferenced before a possible exit point. |
126 |
| Avoid declaring a variable if it is unreferenced before a possible exit point. |
140 |
| New exception is thrown in catch block, original stack trace may be lost |
200 |
| If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation |
213 |
fr/paris/lutece/plugins/quiz/modules/games/web/RandJspBean.java
| Violation |
Line |
| Avoid declaring a variable if it is unreferenced before a possible exit point. |
217 |
| Avoid declaring a variable if it is unreferenced before a possible exit point. |
218 |
| Avoid declaring a variable if it is unreferenced before a possible exit point. |
248 |
| Use opposite operator instead of the logic complement operator. |
258 |
| Avoid declaring a variable if it is unreferenced before a possible exit point. |
365 |
| Avoid declaring a variable if it is unreferenced before a possible exit point. |
367 |
| Avoid declaring a variable if it is unreferenced before a possible exit point. |
425 |
| Avoid declaring a variable if it is unreferenced before a possible exit point. |
426 |
| Avoid declaring a variable if it is unreferenced before a possible exit point. |
428 |
fr/paris/lutece/plugins/quiz/modules/games/web/portlet/QuizPortletJspBean.java
| Violation |
Line |
| If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation |
90 |
| If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation |
113 |
