Fork me on GitHub

PMD Results

The following document contains the results of PMD 6.13.0.

Violations By Priority

Priority 1

fr/paris/lutece/plugins/stock/modules/solr/indexer/SolrStockIndexer.java

Rule Violation Line
FieldNamingConventions The field name 'productService' doesn't match '_[a-z][a-zA-Z0-9]*' 106
LocalVariableNamingConventions The local variable name '_productDAO' doesn't match '[a-z][a-zA-Z0-9]*' 349

fr/paris/lutece/plugins/stock/modules/solr/service/daemon/StockSolrInjectProductsTaskDaemon.java

Rule Violation Line
LocalVariableNamingConventions The local variable name '_productService' doesn't match '[a-z][a-zA-Z0-9]*' 70

Priority 3

fr/paris/lutece/plugins/stock/modules/solr/indexer/SolrStockIndexer.java

Rule Violation Line
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 34380
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 99
CommentRequired Public method and constructor comments are required 124127
MissingOverride The method 'isEnable()' is missing an @Override annotation. 124127
MissingOverride The method 'indexDocuments()' is missing an @Override annotation. 133159
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 135
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 151
ExcessiveMethodLength Avoid really long methods. 164264
CyclomaticComplexity The method 'getItem(Product)' has a cyclomatic complexity of 11. 164264
NPathComplexity The method 'getItem(Product)' has an NPath complexity of 384 164264
UnnecessaryWrapperObjectCreation Unnecessary wrapper object creation 169
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 181
AddEmptyString Do not add empty strings 205
CollapsibleIfStatements These nested if statements could be combined 228232
MissingOverride The method 'getName()' is missing an @Override annotation. 271274
MissingOverride The method 'getVersion()' is missing an @Override annotation. 280283
MissingOverride The method 'getDescription()' is missing an @Override annotation. 288291
MissingOverride The method 'getAdditionalFields()' is missing an @Override annotation. 296338
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 298
UnnecessaryLocalBeforeReturn Consider simply returning the value vs storing it in local variable 'lstFields' 299
MissingOverride The method 'getDocuments(String)' is missing an @Override annotation. 344359
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 354
MissingOverride The method 'getResourcesName()' is missing an @Override annotation. 364367
MissingOverride The method 'getResourceUid(String, String)' is missing an @Override annotation. 372378
ShortVariable Avoid variables with short names like sb 374

fr/paris/lutece/plugins/stock/modules/solr/service/StockSolrPlugin.java

Rule Violation Line
CommentRequired Header comments are required 3942

fr/paris/lutece/plugins/stock/modules/solr/service/StockSolrProductListener.java

Rule Violation Line
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 1269
CommentRequired Header comments are required 38269
DefaultPackage Use explicit scoping instead of the default package private level 4345
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the _productService field if you want a default access modifier 45
CommentRequired Public method and constructor comments are required 4854
CommentRequired Public method and constructor comments are required 5763
CommentRequired Public method and constructor comments are required 6672

fr/paris/lutece/plugins/stock/modules/solr/service/StockSolrService.java

Rule Violation Line
CommentRequired Header comments are required 4387
UseUtilityClass All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 4487

fr/paris/lutece/plugins/stock/modules/solr/service/daemon/StockSolrInjectProductsTaskDaemon.java

Rule Violation Line
CommentRequired Header comments are required 5097

Files

fr/paris/lutece/plugins/stock/modules/solr/indexer/SolrStockIndexer.java

Rule Violation Priority Line
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 3 34380
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 99
FieldNamingConventions The field name 'productService' doesn't match '_[a-z][a-zA-Z0-9]*' 1 106
CommentRequired Public method and constructor comments are required 3 124127
MissingOverride The method 'isEnable()' is missing an @Override annotation. 3 124127
MissingOverride The method 'indexDocuments()' is missing an @Override annotation. 3 133159
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 135
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 151
ExcessiveMethodLength Avoid really long methods. 3 164264
CyclomaticComplexity The method 'getItem(Product)' has a cyclomatic complexity of 11. 3 164264
NPathComplexity The method 'getItem(Product)' has an NPath complexity of 384 3 164264
UnnecessaryWrapperObjectCreation Unnecessary wrapper object creation 3 169
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 181
AddEmptyString Do not add empty strings 3 205
CollapsibleIfStatements These nested if statements could be combined 3 228232
MissingOverride The method 'getName()' is missing an @Override annotation. 3 271274
MissingOverride The method 'getVersion()' is missing an @Override annotation. 3 280283
MissingOverride The method 'getDescription()' is missing an @Override annotation. 3 288291
MissingOverride The method 'getAdditionalFields()' is missing an @Override annotation. 3 296338
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 298
UnnecessaryLocalBeforeReturn Consider simply returning the value vs storing it in local variable 'lstFields' 3 299
MissingOverride The method 'getDocuments(String)' is missing an @Override annotation. 3 344359
LocalVariableNamingConventions The local variable name '_productDAO' doesn't match '[a-z][a-zA-Z0-9]*' 1 349
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 354
MissingOverride The method 'getResourcesName()' is missing an @Override annotation. 3 364367
MissingOverride The method 'getResourceUid(String, String)' is missing an @Override annotation. 3 372378
ShortVariable Avoid variables with short names like sb 3 374

fr/paris/lutece/plugins/stock/modules/solr/service/StockSolrPlugin.java

Rule Violation Priority Line
CommentRequired Header comments are required 3 3942

fr/paris/lutece/plugins/stock/modules/solr/service/StockSolrProductListener.java

Rule Violation Priority Line
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 3 1269
CommentRequired Header comments are required 3 38269
DefaultPackage Use explicit scoping instead of the default package private level 3 4345
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the _productService field if you want a default access modifier 3 45
CommentRequired Public method and constructor comments are required 3 4854
CommentRequired Public method and constructor comments are required 3 5763
CommentRequired Public method and constructor comments are required 3 6672

fr/paris/lutece/plugins/stock/modules/solr/service/StockSolrService.java

Rule Violation Priority Line
CommentRequired Header comments are required 3 4387
UseUtilityClass All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 3 4487

fr/paris/lutece/plugins/stock/modules/solr/service/daemon/StockSolrInjectProductsTaskDaemon.java

Rule Violation Priority Line
CommentRequired Header comments are required 3 5097
LocalVariableNamingConventions The local variable name '_productService' doesn't match '[a-z][a-zA-Z0-9]*' 1 70