Fork me on GitHub

PMD Results

The following document contains the results of PMD 5.5.1.

Files

fr/paris/lutece/plugins/ticketing/modules/ticketingfacilfamilles/service/entrytype/EntryTypeFamilyPic.java

Violation Line
Possible God class (WMC=51, ATFD=91, TCC=0.015151515151515152) 34471
A high number of imports can indicate a high degree of coupling within an object. 34471
The class 'EntryTypeFamilyPic' has a Standard Cyclomatic Complexity of 4 (Highest = 13). 74471
The class 'EntryTypeFamilyPic' has a Cyclomatic Complexity of 4 (Highest = 18). 74471
The class 'EntryTypeFamilyPic' has a Modified Cyclomatic Complexity of 4 (Highest = 13). 74471
The method getRequestData() has an NPath complexity of 8640 166289
The method 'getRequestData' has a Cyclomatic Complexity of 14. 166289
The method 'getRequestData' has a Modified Cyclomatic Complexity of 13. 166289
Avoid really long methods. 166289
The method 'getRequestData' has a Standard Cyclomatic Complexity of 13. 166289
Avoid declaring a variable if it is unreferenced before a possible exit point. 168
Assigning an Object to null is a code smell. Consider refactoring. 170
Avoid declaring a variable if it is unreferenced before a possible exit point. 170
Avoid declaring a variable if it is unreferenced before a possible exit point. 171
Avoid declaring a variable if it is unreferenced before a possible exit point. 172
Avoid declaring a variable if it is unreferenced before a possible exit point. 173
Avoid declaring a variable if it is unreferenced before a possible exit point. 175
Avoid declaring a variable if it is unreferenced before a possible exit point. 178
Avoid declaring a variable if it is unreferenced before a possible exit point. 179
Avoid declaring a variable if it is unreferenced before a possible exit point. 180
Avoid declaring a variable if it is unreferenced before a possible exit point. 181
Avoid declaring a variable if it is unreferenced before a possible exit point. 183
Avoid declaring a variable if it is unreferenced before a possible exit point. 184
The method 'getResponseData' has a Modified Cyclomatic Complexity of 13. 321410
The method 'getResponseData' has a Cyclomatic Complexity of 18. 321410
The method 'getResponseData' has a Standard Cyclomatic Complexity of 13. 321410
The method getResponseData() has an NPath complexity of 4490 321410
Assigning an Object to null is a code smell. Consider refactoring. 323
These nested if statements could be combined 364376
Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 379

fr/paris/lutece/plugins/workflow/modules/ticketingfacilfamilles/business/assignment/TaskAutomaticAssignmentDAO.java

Violation Line
The class 'TaskAutomaticAssignmentDAO' has a Cyclomatic Complexity of 3 (Highest = 10). 56334
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 180
The method 'insert' has a Cyclomatic Complexity of 10. 242268
These nested if statements could be combined 246266
Assigning an Object to null is a code smell. Consider refactoring. 260
Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 285

fr/paris/lutece/plugins/workflow/modules/ticketingfacilfamilles/service/FamilyPicResourceIdService.java

Violation Line
It is a good practice to call super() in a constructor 6164
Avoid variables with short names like rt 71
Avoid variables with short names like p 77

fr/paris/lutece/plugins/workflow/modules/ticketingfacilfamilles/service/WorkflowTicketingFacilFamillesPlugin.java

Violation Line
Document empty method 5657

fr/paris/lutece/plugins/workflow/modules/ticketingfacilfamilles/service/assignment/AutomaticAssignmentService.java

Violation Line
Avoid unnecessary constructors - the compiler will generate these for you 6063
Use block level rather than method level synchronization 8797

fr/paris/lutece/plugins/workflow/modules/ticketingfacilfamilles/service/task/TaskAutomaticAssignment.java

Violation Line
The class 'TaskAutomaticAssignment' has a Cyclomatic Complexity of 5 (Highest = 10). 65191
The method 'processTicketingTask' has a Cyclomatic Complexity of 10. 87132
Deeply nested if..then statements are hard to read 100127
Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 108
The method 'getTicketAssignCriteria' has a Cyclomatic Complexity of 10. 141171
These nested if statements could be combined 153165
Deeply nested if..then statements are hard to read 153165
Overriding method merely calls super 177180

fr/paris/lutece/plugins/workflow/modules/ticketingfacilfamilles/web/task/AutomaticAssignmentTaskComponent.java

Violation Line
Possible God class (WMC=47, ATFD=42, TCC=0.13186813186813187) 34502
The class 'AutomaticAssignmentTaskComponent' has a Cyclomatic Complexity of 4 (Highest = 11). 72502
Avoid excessively long variable names like MESSAGE_TASK_AUTOMATIC_ASSIGNMENT_CONFIRMATION_REMOVE 104
Avoid excessively long variable names like MESSAGE_TASK_AUTOMATIC_ASSIGNMENT_SUCCESSFUL_REMOVED 105
Private field '_strRoleKey' could be made final; it is only initialized in the declaration or constructor. 111
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 156
The method 'getDisplayNewUserConfigForm' has a Cyclomatic Complexity of 11. 200249
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 202
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 263
Avoid unused method parameters such as 'locale'. 385
Avoid using implementation types like 'HashMap'; use the interface instead 429
Avoid using implementation types like 'HashMap'; use the interface instead 429
Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 434