The following document contains the results of PMD 6.13.0.
| Rule | Violation | Line |
|---|---|---|
| ClassNamingConventions | The utility class name 'AppointmentWorkflowConstants' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' | 39–77 |
| Rule | Violation | Line |
|---|---|---|
| AvoidFileStream | Avoid instantiating FileInputStream, FileOutputStream, FileReader, or FileWriter | 145 |
| Rule | Violation | Line |
|---|---|---|
| AbstractClassWithoutAnyMethod | No abstract method which means that the keyword is most likely used to prevent instantiation. Use a private or protected constructor instead. | 3–6 |
| Rule | Violation | Line |
|---|---|---|
| AvoidReassigningParameters | Avoid reassigning parameters such as 'strDescription' | 248 |
| Rule | Violation | Line |
|---|---|---|
| ImmutableField | Private field '_strSubject' could be made final; it is only initialized in the declaration or constructor. | 41 |
| ImmutableField | Private field '_strContent' could be made final; it is only initialized in the declaration or constructor. | 42 |
| Rule | Violation | Line |
|---|---|---|
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 82–97 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Public method and constructor comments are required | 55–58 |
| CommentRequired | Public method and constructor comments are required | 60–63 |
| Rule | Violation | Line |
|---|---|---|
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 55–64 |
| Rule | Violation | Line |
|---|---|---|
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 59–81 |
| Rule | Violation | Line |
|---|---|---|
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 61–82 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 38–119 |
| CommentRequired | Public method and constructor comments are required | 49–52 |
| CommentRequired | Public method and constructor comments are required | 54–57 |
| CommentRequired | Public method and constructor comments are required | 59–62 |
| CommentRequired | Public method and constructor comments are required | 64–67 |
| CommentRequired | Public method and constructor comments are required | 69–72 |
| CommentRequired | Public method and constructor comments are required | 74–77 |
| CommentRequired | Public method and constructor comments are required | 79–82 |
| CommentRequired | Public method and constructor comments are required | 84–87 |
| CommentRequired | Public method and constructor comments are required | 89–92 |
| CommentRequired | Public method and constructor comments are required | 94–97 |
| CommentRequired | Public method and constructor comments are required | 99–102 |
| CommentRequired | Public method and constructor comments are required | 104–107 |
| CommentRequired | Public method and constructor comments are required | 109–112 |
| CommentRequired | Public method and constructor comments are required | 114–117 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 40–134 |
| Rule | Violation | Line |
|---|---|---|
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 59–71 |
| Rule | Violation | Line |
|---|---|---|
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 79–91 |
| Rule | Violation | Line |
|---|---|---|
| ImmutableField | Private field '_appointment' could be made final; it is only initialized in the declaration or constructor. | 53 |
| ImmutableField | Private field '_notifyAppointmentDTO' could be made final; it is only initialized in the declaration or constructor. | 58 |
| Rule | Violation | Line |
|---|---|---|
| FieldDeclarationsShouldBeAtStartOfClass | Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 49 |
| FieldDeclarationsShouldBeAtStartOfClass | Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 50 |
| FieldDeclarationsShouldBeAtStartOfClass | Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 51 |
| FieldDeclarationsShouldBeAtStartOfClass | Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 52 |
| FieldDeclarationsShouldBeAtStartOfClass | Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 53 |
| FieldDeclarationsShouldBeAtStartOfClass | Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 54 |
| FieldDeclarationsShouldBeAtStartOfClass | Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 55 |
| FieldDeclarationsShouldBeAtStartOfClass | Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 56 |
| FieldDeclarationsShouldBeAtStartOfClass | Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 57 |
| FieldDeclarationsShouldBeAtStartOfClass | Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 58 |
| FieldDeclarationsShouldBeAtStartOfClass | Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 59 |
| FieldDeclarationsShouldBeAtStartOfClass | Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 60 |
| FieldDeclarationsShouldBeAtStartOfClass | Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 61 |
| FieldDeclarationsShouldBeAtStartOfClass | Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 62 |
| FieldDeclarationsShouldBeAtStartOfClass | Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 65 |
| FieldDeclarationsShouldBeAtStartOfClass | Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 66 |
| FieldDeclarationsShouldBeAtStartOfClass | Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 67 |
| FieldDeclarationsShouldBeAtStartOfClass | Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 68 |
| FieldDeclarationsShouldBeAtStartOfClass | Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 69 |
| FieldDeclarationsShouldBeAtStartOfClass | Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 70 |
| FieldDeclarationsShouldBeAtStartOfClass | Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 71 |
| FieldDeclarationsShouldBeAtStartOfClass | Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 72 |
| FieldDeclarationsShouldBeAtStartOfClass | Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 73 |
| FieldDeclarationsShouldBeAtStartOfClass | Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 74 |
| FieldDeclarationsShouldBeAtStartOfClass | Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 75 |
| FieldDeclarationsShouldBeAtStartOfClass | Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 76 |
| Rule | Violation | Line |
|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 34–307 |
| CyclomaticComplexity | The method 'sendEmail(AppointmentDTO, ResourceHistory, HttpServletRequest, Locale, T, String)' has a cyclomatic complexity of 11. | 113–155 |
| UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 229 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 283 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 299 |
| Rule | Violation | Line |
|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 34–309 |
| CyclomaticComplexity | The method 'sendAppointment(String, String, String, String, String, String, String, AppointmentDTO, boolean)' has a cyclomatic complexity of 11. | 135–219 |
| UseObjectForClearerAPI | Rather than using a lot of String arguments, consider using a container object for those values. | 135–136 |
| NPathComplexity | The method 'sendAppointment(String, String, String, String, String, String, String, AppointmentDTO, boolean)' has an NPath complexity of 240 | 135–219 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 173 |
| ShortVariable | Avoid variables with short names like st | 184 |
| ShortVariable | Avoid variables with short names like st | 192 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 218 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 251 |
| Rule | Violation | Line |
|---|---|---|
| AvoidDeeplyNestedIfStmts | Deeply nested if..then statements are hard to read | 93–100 |
| AvoidDeeplyNestedIfStmts | Deeply nested if..then statements are hard to read | 101–104 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 56–144 |
| ShortVariable | Avoid variables with short names like m | 140 |
| Rule | Violation | Line |
|---|---|---|
| NPathComplexity | The method 'processTask(int, HttpServletRequest, Locale)' has an NPath complexity of 768 | 84–146 |
| CyclomaticComplexity | The method 'processTask(int, HttpServletRequest, Locale)' has a cyclomatic complexity of 13. | 84–146 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 86 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 88 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 29–92 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 48 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 7–17 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 11–44 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 3–6 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 5–29 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 5–14 |
| CommentRequired | Public method and constructor comments are required | 8 |
| CommentRequired | Public method and constructor comments are required | 10 |
| CommentRequired | Public method and constructor comments are required | 12 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 7–31 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 7–31 |
| Rule | Violation | Line |
|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 34–355 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 174 |
| CyclomaticComplexity | The method 'doSaveConfig(HttpServletRequest, Locale, ITask, ITaskConfigService, boolean)' has a cyclomatic complexity of 22. | 218–354 |
| NPathComplexity | The method 'doSaveConfig(HttpServletRequest, Locale, ITask, ITaskConfigService, boolean)' has an NPath complexity of 64512 | 218–354 |
| ExcessiveMethodLength | Avoid really long methods. | 218–354 |
| NcssCount | The method 'doSaveConfig(HttpServletRequest, Locale, ITask, ITaskConfigService, boolean)' has a NCSS line count of 72. | 218–354 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 224 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 225 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 226 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 227 |
| Rule | Violation | Line |
|---|---|---|
| UnusedPrivateField | Avoid unused private fields such as '_taskStateService'. | 100 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 117 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 171 |
| AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 190 |
| Rule | Violation | Line |
|---|---|---|
| CyclomaticComplexity | The method 'doExecuteWorkflowAction(HttpServletRequest, HttpServletResponse)' has a cyclomatic complexity of 16. | 95–158 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 107 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 110 |
| AvoidDeeplyNestedIfStmts | Deeply nested if..then statements are hard to read | 127–132 |
| Rule | Violation | Line |
|---|---|---|
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 89 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 128 |
| Rule | Violation | Line |
|---|---|---|
| UnusedPrivateField | Avoid unused private fields such as '_actionService'. | 64 |
| Rule | Violation | Line |
|---|---|---|
| UnusedPrivateField | Avoid unused private fields such as '_actionService'. | 63 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 53–141 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 79 |
| Rule | Violation | Line |
|---|---|---|
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 89 |
| Rule | Violation | Line |
|---|---|---|
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 133 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 159 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 161 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 162 |
| Rule | Violation | Line |
|---|---|---|
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 103 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 120–151 |
| AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 194 |
| ShortVariable | Avoid variables with short names like i | 224 |
| Rule | Violation | Line |
|---|---|---|
| BooleanGetMethodName | A getX() method which returns a boolean should be named isX() | 196–199 |
| BooleanGetMethodName | A getX() method which returns a boolean should be named isX() | 217–220 |
| BooleanGetMethodName | A getX() method which returns a boolean should be named isX() | 259–262 |
| Rule | Violation | Line |
|---|---|---|
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.plugins.appointment.business.user.User' | 49 |
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.plugins.appointment.service.UserService' | 51 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ImmutableField | Private field '_strSubject' could be made final; it is only initialized in the declaration or constructor. | 3 | 41 |
| ImmutableField | Private field '_strContent' could be made final; it is only initialized in the declaration or constructor. | 3 | 42 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 3 | 82–97 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Public method and constructor comments are required | 3 | 55–58 |
| CommentRequired | Public method and constructor comments are required | 3 | 60–63 |
| BooleanGetMethodName | A getX() method which returns a boolean should be named isX() | 4 | 196–199 |
| BooleanGetMethodName | A getX() method which returns a boolean should be named isX() | 4 | 217–220 |
| BooleanGetMethodName | A getX() method which returns a boolean should be named isX() | 4 | 259–262 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 3 | 55–64 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 3 | 59–81 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 3 | 61–82 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 38–119 |
| CommentRequired | Public method and constructor comments are required | 3 | 49–52 |
| CommentRequired | Public method and constructor comments are required | 3 | 54–57 |
| CommentRequired | Public method and constructor comments are required | 3 | 59–62 |
| CommentRequired | Public method and constructor comments are required | 3 | 64–67 |
| CommentRequired | Public method and constructor comments are required | 3 | 69–72 |
| CommentRequired | Public method and constructor comments are required | 3 | 74–77 |
| CommentRequired | Public method and constructor comments are required | 3 | 79–82 |
| CommentRequired | Public method and constructor comments are required | 3 | 84–87 |
| CommentRequired | Public method and constructor comments are required | 3 | 89–92 |
| CommentRequired | Public method and constructor comments are required | 3 | 94–97 |
| CommentRequired | Public method and constructor comments are required | 3 | 99–102 |
| CommentRequired | Public method and constructor comments are required | 3 | 104–107 |
| CommentRequired | Public method and constructor comments are required | 3 | 109–112 |
| CommentRequired | Public method and constructor comments are required | 3 | 114–117 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 40–134 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 3 | 59–71 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 3 | 79–91 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ImmutableField | Private field '_appointment' could be made final; it is only initialized in the declaration or constructor. | 3 | 53 |
| ImmutableField | Private field '_notifyAppointmentDTO' could be made final; it is only initialized in the declaration or constructor. | 3 | 58 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ClassNamingConventions | The utility class name 'AppointmentWorkflowConstants' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' | 1 | 39–77 |
| FieldDeclarationsShouldBeAtStartOfClass | Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 3 | 49 |
| FieldDeclarationsShouldBeAtStartOfClass | Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 3 | 50 |
| FieldDeclarationsShouldBeAtStartOfClass | Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 3 | 51 |
| FieldDeclarationsShouldBeAtStartOfClass | Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 3 | 52 |
| FieldDeclarationsShouldBeAtStartOfClass | Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 3 | 53 |
| FieldDeclarationsShouldBeAtStartOfClass | Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 3 | 54 |
| FieldDeclarationsShouldBeAtStartOfClass | Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 3 | 55 |
| FieldDeclarationsShouldBeAtStartOfClass | Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 3 | 56 |
| FieldDeclarationsShouldBeAtStartOfClass | Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 3 | 57 |
| FieldDeclarationsShouldBeAtStartOfClass | Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 3 | 58 |
| FieldDeclarationsShouldBeAtStartOfClass | Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 3 | 59 |
| FieldDeclarationsShouldBeAtStartOfClass | Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 3 | 60 |
| FieldDeclarationsShouldBeAtStartOfClass | Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 3 | 61 |
| FieldDeclarationsShouldBeAtStartOfClass | Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 3 | 62 |
| FieldDeclarationsShouldBeAtStartOfClass | Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 3 | 65 |
| FieldDeclarationsShouldBeAtStartOfClass | Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 3 | 66 |
| FieldDeclarationsShouldBeAtStartOfClass | Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 3 | 67 |
| FieldDeclarationsShouldBeAtStartOfClass | Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 3 | 68 |
| FieldDeclarationsShouldBeAtStartOfClass | Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 3 | 69 |
| FieldDeclarationsShouldBeAtStartOfClass | Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 3 | 70 |
| FieldDeclarationsShouldBeAtStartOfClass | Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 3 | 71 |
| FieldDeclarationsShouldBeAtStartOfClass | Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 3 | 72 |
| FieldDeclarationsShouldBeAtStartOfClass | Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 3 | 73 |
| FieldDeclarationsShouldBeAtStartOfClass | Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 3 | 74 |
| FieldDeclarationsShouldBeAtStartOfClass | Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 3 | 75 |
| FieldDeclarationsShouldBeAtStartOfClass | Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 3 | 76 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 3 | 34–307 |
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.plugins.appointment.business.user.User' | 4 | 49 |
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.plugins.appointment.service.UserService' | 4 | 51 |
| CyclomaticComplexity | The method 'sendEmail(AppointmentDTO, ResourceHistory, HttpServletRequest, Locale, T, String)' has a cyclomatic complexity of 11. | 3 | 113–155 |
| UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 3 | 229 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 283 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 299 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 3 | 34–309 |
| CyclomaticComplexity | The method 'sendAppointment(String, String, String, String, String, String, String, AppointmentDTO, boolean)' has a cyclomatic complexity of 11. | 3 | 135–219 |
| UseObjectForClearerAPI | Rather than using a lot of String arguments, consider using a container object for those values. | 3 | 135–136 |
| NPathComplexity | The method 'sendAppointment(String, String, String, String, String, String, String, AppointmentDTO, boolean)' has an NPath complexity of 240 | 3 | 135–219 |
| AvoidFileStream | Avoid instantiating FileInputStream, FileOutputStream, FileReader, or FileWriter | 1 | 145 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 173 |
| ShortVariable | Avoid variables with short names like st | 3 | 184 |
| ShortVariable | Avoid variables with short names like st | 3 | 192 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 218 |
| AvoidReassigningParameters | Avoid reassigning parameters such as 'strDescription' | 2 | 248 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 251 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| AvoidDeeplyNestedIfStmts | Deeply nested if..then statements are hard to read | 3 | 93–100 |
| AvoidDeeplyNestedIfStmts | Deeply nested if..then statements are hard to read | 3 | 101–104 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 56–144 |
| ShortVariable | Avoid variables with short names like m | 3 | 140 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| NPathComplexity | The method 'processTask(int, HttpServletRequest, Locale)' has an NPath complexity of 768 | 3 | 84–146 |
| CyclomaticComplexity | The method 'processTask(int, HttpServletRequest, Locale)' has a cyclomatic complexity of 13. | 3 | 84–146 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 86 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 88 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 29–92 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 48 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 7–17 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 11–44 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| AbstractClassWithoutAnyMethod | No abstract method which means that the keyword is most likely used to prevent instantiation. Use a private or protected constructor instead. | 1 | 3–6 |
| CommentRequired | Header comments are required | 3 | 3–6 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 5–29 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 5–14 |
| CommentRequired | Public method and constructor comments are required | 3 | 8 |
| CommentRequired | Public method and constructor comments are required | 3 | 10 |
| CommentRequired | Public method and constructor comments are required | 3 | 12 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 7–31 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 7–31 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 3 | 34–355 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 174 |
| CyclomaticComplexity | The method 'doSaveConfig(HttpServletRequest, Locale, ITask, ITaskConfigService, boolean)' has a cyclomatic complexity of 22. | 3 | 218–354 |
| NPathComplexity | The method 'doSaveConfig(HttpServletRequest, Locale, ITask, ITaskConfigService, boolean)' has an NPath complexity of 64512 | 3 | 218–354 |
| ExcessiveMethodLength | Avoid really long methods. | 3 | 218–354 |
| NcssCount | The method 'doSaveConfig(HttpServletRequest, Locale, ITask, ITaskConfigService, boolean)' has a NCSS line count of 72. | 3 | 218–354 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 224 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 225 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 226 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 227 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnusedPrivateField | Avoid unused private fields such as '_taskStateService'. | 3 | 100 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 117 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 171 |
| AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 3 | 190 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CyclomaticComplexity | The method 'doExecuteWorkflowAction(HttpServletRequest, HttpServletResponse)' has a cyclomatic complexity of 16. | 3 | 95–158 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 107 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 110 |
| AvoidDeeplyNestedIfStmts | Deeply nested if..then statements are hard to read | 3 | 127–132 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 89 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 128 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnusedPrivateField | Avoid unused private fields such as '_actionService'. | 3 | 64 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnusedPrivateField | Avoid unused private fields such as '_actionService'. | 3 | 63 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 53–141 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 79 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 89 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 133 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 159 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 161 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 162 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 103 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 120–151 |
| AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 3 | 194 |
| ShortVariable | Avoid variables with short names like i | 3 | 224 |
