The following document contains the results of PMD 6.13.0.
Rule | Violation | Line |
---|---|---|
FieldNamingConventions | The field name 'success' doesn't match '_[a-z][a-zA-Z0-9]*' | 51 |
Rule | Violation | Line |
---|---|---|
FieldNamingConventions | The field name 'rowcount' doesn't match '_[a-z][a-zA-Z0-9]*' | 51 |
Rule | Violation | Line |
---|---|---|
FieldNamingConventions | The field name 'status' doesn't match '_[a-z][a-zA-Z0-9]*' | 51 |
FieldNamingConventions | The field name 'appointments' doesn't match '_[a-z][a-zA-Z0-9]*' | 57 |
Rule | Violation | Line |
---|---|---|
ClassWithOnlyPrivateConstructorsShouldBeFinal | A class which only has private constructors should be final | 84–867 |
FieldNamingConventions | The field name '_task_ants_appointment_dao' doesn't match '_[a-z][a-zA-Z0-9]*' | 90 |
Rule | Violation | Line |
---|---|---|
ClassWithOnlyPrivateConstructorsShouldBeFinal | A class which only has private constructors should be final | 50–100 |
FieldNamingConventions | The field name '_task_ants_appointment_history_dao' doesn't match '_[a-z][a-zA-Z0-9]*' | 59 |
Rule | Violation | Line |
---|---|---|
ClassNamingConventions | The utility class name 'TaskAntsAppointmentRest' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' | 48–122 |
ClassWithOnlyPrivateConstructorsShouldBeFinal | A class which only has private constructors should be final | 48–122 |
Rule | Violation | Line |
---|---|---|
ClassWithOnlyPrivateConstructorsShouldBeFinal | A class which only has private constructors should be final | 43–73 |
ClassNamingConventions | The utility class name 'TaskAntsAppointmentRestConstants' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' | 43–73 |
Rule | Violation | Line |
---|---|---|
EmptyMethodInAbstractClassShouldBeAbstract | An empty method in an abstract class should be abstract instead | 290–293 |
EmptyMethodInAbstractClassShouldBeAbstract | An empty method in an abstract class should be abstract instead | 299–302 |
Rule | Violation | Line |
---|---|---|
CommentRequired | Public method and constructor comments are required | 57–60 |
CommentRequired | Public method and constructor comments are required | 62–65 |
CommentRequired | Public method and constructor comments are required | 67–70 |
CommentRequired | Public method and constructor comments are required | 72–75 |
Rule | Violation | Line |
---|---|---|
CommentRequired | Header comments are required | 38–84 |
Rule | Violation | Line |
---|---|---|
NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 68 |
Rule | Violation | Line |
---|---|---|
DataClass | The class 'AntsStatusResponsePOJO' is suspected to be a Data Class (WOC=0.000%, NOPA=0, NOAM=4, WMC=4) | 45–78 |
MethodReturnsInternalArray | Returning 'appointments' may expose an internal array. | 66 |
ArrayIsStoredDirectly | The user-supplied array 'appointments' is stored directly. | 74 |
Rule | Violation | Line |
---|---|---|
CommentRequired | Header comments are required | 40–47 |
CommentRequired | Public method and constructor comments are required | 42 |
UnnecessaryModifier | Unnecessary modifier 'public' on method 'createAntsAppointment': the method is declared in an interface type | 42 |
UnnecessaryModifier | Unnecessary modifier 'public' on method 'deleteAntsAppointment': the method is declared in an interface type | 44 |
CommentRequired | Public method and constructor comments are required | 44 |
CommentRequired | Public method and constructor comments are required | 46 |
UnnecessaryModifier | Unnecessary modifier 'public' on method 'getAntsApplicationFieldId': the method is declared in an interface type | 46 |
Rule | Violation | Line |
---|---|---|
AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 117 |
Rule | Violation | Line |
---|---|---|
ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 34–867 |
PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 163 |
PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 165 |
AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 220 |
PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 246 |
PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 248 |
AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 301 |
UseObjectForClearerAPI | Rather than using a lot of String arguments, consider using a container object for those values. | 346–347 |
UseObjectForClearerAPI | Rather than using a lot of String arguments, consider using a container object for those values. | 396–397 |
UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 442 |
AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 518 |
AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 607 |
AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 661 |
Rule | Violation | Line |
---|---|---|
AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 113 |
Rule | Violation | Line |
---|---|---|
CommentRequired | Header comments are required | 39–86 |
Rule | Violation | Line |
---|---|---|
UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 71 |
UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 94 |
UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 117 |
Rule | Violation | Line |
---|---|---|
UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 114 |
PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 143 |
ConfusingTernary | Avoid if (x != y) ..; else ..; | 205–225 |
Rule | Violation | Line |
---|---|---|
UseVarargs | Consider using varargs for methods or constructors which take an array the last parameter. | 74 |
Rule | Violation | Line |
---|---|---|
UnusedImports | Avoid unused imports such as 'java.util.ArrayList' | 36 |
UnusedImports | Avoid unused imports such as 'java.util.List' | 37 |
UnusedImports | Avoid unused imports such as 'fr.paris.lutece.plugins.appointment.service.AppointmentResponseService' | 45 |
UnusedImports | Avoid unused imports such as 'fr.paris.lutece.plugins.genericattributes.business.Response' | 46 |
Rule | Violation | Line |
---|---|---|
UnusedImports | Avoid unused imports such as 'fr.paris.lutece.plugins.appointment.web.AppointmentApp' | 64 |
Rule | Violation | Priority | Line |
---|---|---|---|
CommentRequired | Public method and constructor comments are required | 3 | 57–60 |
CommentRequired | Public method and constructor comments are required | 3 | 62–65 |
CommentRequired | Public method and constructor comments are required | 3 | 67–70 |
CommentRequired | Public method and constructor comments are required | 3 | 72–75 |
Rule | Violation | Priority | Line |
---|---|---|---|
CommentRequired | Header comments are required | 3 | 38–84 |
Rule | Violation | Priority | Line |
---|---|---|---|
NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 68 |
Rule | Violation | Priority | Line |
---|---|---|---|
FieldNamingConventions | The field name 'success' doesn't match '_[a-z][a-zA-Z0-9]*' | 1 | 51 |
Rule | Violation | Priority | Line |
---|---|---|---|
FieldNamingConventions | The field name 'rowcount' doesn't match '_[a-z][a-zA-Z0-9]*' | 1 | 51 |
Rule | Violation | Priority | Line |
---|---|---|---|
DataClass | The class 'AntsStatusResponsePOJO' is suspected to be a Data Class (WOC=0.000%, NOPA=0, NOAM=4, WMC=4) | 3 | 45–78 |
FieldNamingConventions | The field name 'status' doesn't match '_[a-z][a-zA-Z0-9]*' | 1 | 51 |
FieldNamingConventions | The field name 'appointments' doesn't match '_[a-z][a-zA-Z0-9]*' | 1 | 57 |
MethodReturnsInternalArray | Returning 'appointments' may expose an internal array. | 3 | 66 |
ArrayIsStoredDirectly | The user-supplied array 'appointments' is stored directly. | 3 | 74 |
UseVarargs | Consider using varargs for methods or constructors which take an array the last parameter. | 4 | 74 |
Rule | Violation | Priority | Line |
---|---|---|---|
CommentRequired | Header comments are required | 3 | 40–47 |
CommentRequired | Public method and constructor comments are required | 3 | 42 |
UnnecessaryModifier | Unnecessary modifier 'public' on method 'createAntsAppointment': the method is declared in an interface type | 3 | 42 |
UnnecessaryModifier | Unnecessary modifier 'public' on method 'deleteAntsAppointment': the method is declared in an interface type | 3 | 44 |
CommentRequired | Public method and constructor comments are required | 3 | 44 |
CommentRequired | Public method and constructor comments are required | 3 | 46 |
UnnecessaryModifier | Unnecessary modifier 'public' on method 'getAntsApplicationFieldId': the method is declared in an interface type | 3 | 46 |
Rule | Violation | Priority | Line |
---|---|---|---|
UnusedImports | Avoid unused imports such as 'java.util.ArrayList' | 4 | 36 |
UnusedImports | Avoid unused imports such as 'java.util.List' | 4 | 37 |
UnusedImports | Avoid unused imports such as 'fr.paris.lutece.plugins.appointment.service.AppointmentResponseService' | 4 | 45 |
UnusedImports | Avoid unused imports such as 'fr.paris.lutece.plugins.genericattributes.business.Response' | 4 | 46 |
AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 117 |
Rule | Violation | Priority | Line |
---|---|---|---|
ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 3 | 34–867 |
UnusedImports | Avoid unused imports such as 'fr.paris.lutece.plugins.appointment.web.AppointmentApp' | 4 | 64 |
ClassWithOnlyPrivateConstructorsShouldBeFinal | A class which only has private constructors should be final | 1 | 84–867 |
FieldNamingConventions | The field name '_task_ants_appointment_dao' doesn't match '_[a-z][a-zA-Z0-9]*' | 1 | 90 |
PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 163 |
PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 165 |
AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 220 |
PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 246 |
PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 248 |
AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 301 |
UseObjectForClearerAPI | Rather than using a lot of String arguments, consider using a container object for those values. | 3 | 346–347 |
UseObjectForClearerAPI | Rather than using a lot of String arguments, consider using a container object for those values. | 3 | 396–397 |
UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 442 |
AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 518 |
AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 607 |
AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 661 |
Rule | Violation | Priority | Line |
---|---|---|---|
AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 113 |
Rule | Violation | Priority | Line |
---|---|---|---|
CommentRequired | Header comments are required | 3 | 39–86 |
Rule | Violation | Priority | Line |
---|---|---|---|
ClassWithOnlyPrivateConstructorsShouldBeFinal | A class which only has private constructors should be final | 1 | 50–100 |
FieldNamingConventions | The field name '_task_ants_appointment_history_dao' doesn't match '_[a-z][a-zA-Z0-9]*' | 1 | 59 |
Rule | Violation | Priority | Line |
---|---|---|---|
ClassNamingConventions | The utility class name 'TaskAntsAppointmentRest' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' | 1 | 48–122 |
ClassWithOnlyPrivateConstructorsShouldBeFinal | A class which only has private constructors should be final | 1 | 48–122 |
UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 71 |
UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 94 |
UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 117 |
Rule | Violation | Priority | Line |
---|---|---|---|
ClassWithOnlyPrivateConstructorsShouldBeFinal | A class which only has private constructors should be final | 1 | 43–73 |
ClassNamingConventions | The utility class name 'TaskAntsAppointmentRestConstants' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' | 1 | 43–73 |
Rule | Violation | Priority | Line |
---|---|---|---|
UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 114 |
PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 143 |
ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 205–225 |
EmptyMethodInAbstractClassShouldBeAbstract | An empty method in an abstract class should be abstract instead | 1 | 290–293 |
EmptyMethodInAbstractClassShouldBeAbstract | An empty method in an abstract class should be abstract instead | 1 | 299–302 |