The following document contains the results of PMD 5.3.5.
| Violation | Line |
|---|---|
| This final field could be made static | 47 |
| It is a good practice to call super() in a constructor | 53–56 |
| Violation | Line |
|---|---|
| This final field could be made static | 47 |
| It is a good practice to call super() in a constructor | 53–58 |
| Violation | Line |
|---|---|
| Use block level rather than method level synchronization | 84–108 |
| Violation | Line |
|---|---|
| Use block level rather than method level synchronization | 83–94 |
| Violation | Line |
|---|---|
| Use block level rather than method level synchronization | 70–103 |
| Violation | Line |
|---|---|
| Use block level rather than method level synchronization | 66–82 |
| Violation | Line |
|---|---|
| Avoid declaring a variable if it is unreferenced before a possible exit point. | 65 |
| Violation | Line |
|---|---|
| Use block level rather than method level synchronization | 85–102 |
| Use block level rather than method level synchronization | 146–167 |
| If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 297 |
| Violation | Line |
|---|---|
| Private field '_fileHistoryService' could be made final; it is only initialized in the declaration or constructor. | 57 |
| Private field '_physicalFileHistoryService' could be made final; it is only initialized in the declaration or constructor. | 58 |
| Document empty constructor | 63–65 |
| Assigning an Object to null is a code smell. Consider refactoring. | 96 |
| Violation | Line |
|---|---|
| A getX() method which returns a boolean should be named isX() | 91–94 |
| A getX() method which returns a boolean should be named isX() | 123–127 |
| Violation | Line |
|---|---|
| A high number of imports can indicate a high degree of coupling within an object. | 34–300 |
| The class 'TaskFillingDirectory' has a Cyclomatic Complexity of 4 (Highest = 16). | 80–300 |
| The class 'TaskFillingDirectory' has a Standard Cyclomatic Complexity of 4 (Highest = 12). | 80–300 |
| The class 'TaskFillingDirectory' has a Modified Cyclomatic Complexity of 4 (Highest = 12). | 80–300 |
| The method 'processTask' has a Modified Cyclomatic Complexity of 12. | 117–239 |
| The method 'processTask' has a Cyclomatic Complexity of 16. | 117–239 |
| Avoid really long methods. | 117–239 |
| The method 'processTask' has a Standard Cyclomatic Complexity of 12. | 117–239 |
| Avoid using Literals in Conditional Statements | 188 |
| Avoid throwing raw exception types. | 235 |
| Violation | Line |
|---|---|
| The class 'TaskHelpFilling' has a Cyclomatic Complexity of 5 (Highest = 12). | 40–244 |
| The class 'TaskHelpFilling' has a Standard Cyclomatic Complexity of 4 (Highest = 10). | 40–244 |
| The class 'TaskHelpFilling' has a Modified Cyclomatic Complexity of 4 (Highest = 10). | 40–244 |
| The method 'processTask' has a Cyclomatic Complexity of 12. | 69–129 |
| The method 'processTask' has a Modified Cyclomatic Complexity of 10. | 69–129 |
| The method 'processTask' has a Standard Cyclomatic Complexity of 10. | 69–129 |
| The method processTask() has an NPath complexity of 510 | 69–129 |
| Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 121 |
| Violation | Line |
|---|---|
| Avoid declaring a variable if it is unreferenced before a possible exit point. | 131 |
| Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() | 140 |
| Violation | Line |
|---|---|
| Assigning an Object to null is a code smell. Consider refactoring. | 91 |
| Avoid variables with short names like os | 102 |
| Violation | Line |
|---|---|
| A high number of imports can indicate a high degree of coupling within an object. | 34–702 |
| Possible God class (WMC=78, ATFD=172, TCC=0.2) | 34–702 |
| The class 'FillingDirectoryTaskComponent' has a Cyclomatic Complexity of 14 (Highest = 24). | 95–702 |
| The class 'FillingDirectoryTaskComponent' has a Standard Cyclomatic Complexity of 10 (Highest = 14). | 95–702 |
| The class 'FillingDirectoryTaskComponent' has a Modified Cyclomatic Complexity of 10 (Highest = 14). | 95–702 |
| Avoid excessively long variable names like MESSAGE_NO_CONFIGURATION_FOR_TASK_EVALUATION_EXPERT | 131 |
| The method 'doSaveConfig' has a Cyclomatic Complexity of 24. | 160–270 |
| Avoid really long methods. | 160–270 |
| The method 'doSaveConfig' has a Modified Cyclomatic Complexity of 14. | 160–270 |
| The method 'doSaveConfig' has a Standard Cyclomatic Complexity of 14. | 160–270 |
| Avoid declaring a variable if it is unreferenced before a possible exit point. | 169 |
| Deeply nested if..then statements are hard to read | 217–220 |
| Deeply nested if..then statements are hard to read | 223–229 |
| The method 'doValidateTask' has a Cyclomatic Complexity of 13. | 276–383 |
| The method 'doValidateTask' has a Standard Cyclomatic Complexity of 11. | 276–383 |
| The method 'doValidateTask' has a Modified Cyclomatic Complexity of 11. | 276–383 |
| Avoid really long methods. | 276–383 |
| Avoid declaring a variable if it is unreferenced before a possible exit point. | 281 |
| Avoid declaring a variable if it is unreferenced before a possible exit point. | 283 |
| Avoid declaring a variable if it is unreferenced before a possible exit point. | 284 |
| Avoid declaring a variable if it is unreferenced before a possible exit point. | 285 |
| The method 'getDisplayConfigForm' has a Modified Cyclomatic Complexity of 14. | 389–501 |
| The method getDisplayConfigForm() has an NPath complexity of 640 | 389–501 |
| The method 'getDisplayConfigForm' has a Standard Cyclomatic Complexity of 14. | 389–501 |
| Avoid really long methods. | 389–501 |
| The method 'getDisplayConfigForm' has a Cyclomatic Complexity of 16. | 389–501 |
| If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 395 |
| No need to call String.valueOf to append to a string. | 427 |
| No need to call String.valueOf to append to a string. | 438 |
| If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 510 |
| If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 597 |
| Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() | 607 |
| Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() | 654 |
| If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 663 |
| Violation | Line |
|---|---|
| A high number of imports can indicate a high degree of coupling within an object. | 34–214 |
| The class 'HelpFillingJspBean' has a Cyclomatic Complexity of 12 (Highest = 11). | 72–214 |
| The class 'HelpFillingJspBean' has a Modified Cyclomatic Complexity of 11 (Highest = 10). | 72–214 |
| The class 'HelpFillingJspBean' has a Standard Cyclomatic Complexity of 11 (Highest = 10). | 72–214 |
| Private field '_recordService' could be made final; it is only initialized in the declaration or constructor. | 100 |
| Private field '_listEntriesService' could be made final; it is only initialized in the declaration or constructor. | 101 |
| The method 'getModifyDirectoryRecordPopup' has a Modified Cyclomatic Complexity of 10. | 110–212 |
| Avoid really long methods. | 110–212 |
| The method 'getModifyDirectoryRecordPopup' has a Standard Cyclomatic Complexity of 10. | 110–212 |
| The method 'getModifyDirectoryRecordPopup' has a Cyclomatic Complexity of 11. | 110–212 |
| The method getModifyDirectoryRecordPopup() has an NPath complexity of 432 | 110–212 |
| Avoid declaring a variable if it is unreferenced before a possible exit point. | 115 |
| If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 176 |
| If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 186 |
| Violation | Line |
|---|---|
| Possible God class (WMC=72, ATFD=105, TCC=0.04395604395604396) | 34–629 |
| A high number of imports can indicate a high degree of coupling within an object. | 34–629 |
| The class 'HelpFillingTaskComponent' has a Standard Cyclomatic Complexity of 5 (Highest = 14). | 88–629 |
| The class 'HelpFillingTaskComponent' has a Modified Cyclomatic Complexity of 5 (Highest = 14). | 88–629 |
| The class 'HelpFillingTaskComponent' has a Cyclomatic Complexity of 5 (Highest = 21). | 88–629 |
| Avoid unused private fields such as '_taskComponentManager'. | 123 |
| If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 259 |
| Avoid variables with short names like e | 291 |
| This for loop could be simplified to a while loop | 292–299 |
| Avoid variables with short names like v | 294 |
| Avoid variables with short names like e | 310 |
| This for loop could be simplified to a while loop | 311–318 |
| Avoid variables with short names like v | 313 |
| The method doActionList() has an NPath complexity of 225 | 328–349 |
| Avoid variables with short names like n1 | 332 |
| Avoid variables with short names like n2 | 333 |
| The method 'getDisplayConfigForm' has a Standard Cyclomatic Complexity of 14. | 352–463 |
| The method 'getDisplayConfigForm' has a Cyclomatic Complexity of 21. | 352–463 |
| Avoid really long methods. | 352–463 |
| The method getDisplayConfigForm() has an NPath complexity of 7200 | 352–463 |
| The method 'getDisplayConfigForm' has a Modified Cyclomatic Complexity of 14. | 352–463 |
| If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 357 |
| Avoid variables with short names like e | 475 |
| This for loop could be simplified to a while loop | 477–484 |
| Avoid variables with short names like v | 479 |
| If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 577 |
| If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 608 |
