Fork me on GitHub

Résultats PMD

Le document suivant contient les résultats de PMD 6.13.0.

Violations By Priority

Priority 1

fr/paris/lutece/plugins/workflow/modules/forms/business/EditFormResponseConfigValueHome.java

Rule Violation Ligne
ClassWithOnlyPrivateConstructorsShouldBeFinal A class which only has private constructors should be final 42–116

fr/paris/lutece/plugins/workflow/modules/forms/business/FormResponseValueStateControllerConfigHome.java

Rule Violation Ligne
ClassWithOnlyPrivateConstructorsShouldBeFinal A class which only has private constructors should be final 40–93

fr/paris/lutece/plugins/workflow/modules/forms/service/task/AbstractEditFormsTask.java

Rule Violation Ligne
FieldNamingConventions The final field name '_formsTaskService' doesn't match '[a-z][a-zA-Z0-9]*' 59
FieldNamingConventions The final field name '_editFormResponseTaskService' doesn't match '[a-z][a-zA-Z0-9]*' 60
FieldNamingConventions The final field name '_editFormResponseTaskHistoryService' doesn't match '[a-z][a-zA-Z0-9]*' 61

fr/paris/lutece/plugins/workflow/modules/forms/service/task/DuplicateFormResponseTask.java

Rule Violation Ligne
FieldNamingConventions The final field name '_formsTaskService' doesn't match '[a-z][a-zA-Z0-9]*' 75

fr/paris/lutece/plugins/workflow/modules/forms/service/task/EditFormResponseAutoUpdateTask.java

Rule Violation Ligne
FieldNamingConventions The final field name '_formsTaskService' doesn't match '[a-z][a-zA-Z0-9]*' 67

fr/paris/lutece/plugins/workflow/modules/forms/service/task/EditFormResponseTaskHistoryService.java

Rule Violation Ligne
FieldNamingConventions The final field name '_editFormResponseTaskHistoryDAO' doesn't match '[a-z][a-zA-Z0-9]*' 49

fr/paris/lutece/plugins/workflow/modules/forms/service/task/ModifyFormResponseUpdateDateTask.java

Rule Violation Ligne
FieldNamingConventions The final field name '_formsTaskService' doesn't match '[a-z][a-zA-Z0-9]*' 52

fr/paris/lutece/plugins/workflow/modules/forms/service/task/ModifyFormResponseUpdateStatusTask.java

Rule Violation Ligne
FieldNamingConventions The final field name '_formsTaskService' doesn't match '[a-z][a-zA-Z0-9]*' 53

fr/paris/lutece/plugins/workflow/modules/forms/utils/EditableResponse.java

Rule Violation Ligne
FieldNamingConventions The final field name '_question' doesn't match '[a-z][a-zA-Z0-9]*' 42
FieldNamingConventions The final field name '_responseSaved' doesn't match '[a-z][a-zA-Z0-9]*' 43
FieldNamingConventions The final field name '_responseFromForm' doesn't match '[a-z][a-zA-Z0-9]*' 44

fr/paris/lutece/plugins/workflow/modules/forms/web/task/AbstractFormResponseTaskComponent.java

Rule Violation Ligne
AbstractClassWithoutAnyMethod No abstract method which means that the keyword is most likely used to prevent instantiation. Use a private or protected constructor instead. 38–43

fr/paris/lutece/plugins/workflow/modules/forms/web/task/EditFormResponseAutoUpdateTaskComponent.java

Rule Violation Ligne
FieldNamingConventions The final field name '_formsTaskService' doesn't match '[a-z][a-zA-Z0-9]*' 101
FieldNamingConventions The final field name '_editFormResponseTaskService' doesn't match '[a-z][a-zA-Z0-9]*' 102

fr/paris/lutece/plugins/workflow/modules/forms/web/task/EditFormResponseTaskComponent.java

Rule Violation Ligne
FieldNamingConventions The final field name '_formsTaskService' doesn't match '[a-z][a-zA-Z0-9]*' 115
FieldNamingConventions The final field name '_editFormResponseTaskService' doesn't match '[a-z][a-zA-Z0-9]*' 116
FieldNamingConventions The final field name '_editFormResponseTaskHistoryService' doesn't match '[a-z][a-zA-Z0-9]*' 117

Priority 3

fr/paris/lutece/plugins/workflow/modules/forms/business/AbstractCompleteFormResponse.java

Rule Violation Ligne
CommentRequired Header comments are required 38–146
AbstractClassWithoutAbstractMethod This abstract class does not have any abstract methods 38–146

fr/paris/lutece/plugins/workflow/modules/forms/business/AbstractCompleteFormResponseTaskConfig.java

Rule Violation Ligne
CommentRequired Header comments are required 41–89

fr/paris/lutece/plugins/workflow/modules/forms/business/AbstractCompleteFormResponseValue.java

Rule Violation Ligne
AbstractClassWithoutAbstractMethod This abstract class does not have any abstract methods 38–112
CommentRequired Header comments are required 38–112

fr/paris/lutece/plugins/workflow/modules/forms/business/AbstractFormResponseTaskHistory.java

Rule Violation Ligne
AbstractClassWithoutAbstractMethod This abstract class does not have any abstract methods 38–113
CommentRequired Header comments are required 38–113

fr/paris/lutece/plugins/workflow/modules/forms/business/CompleteFormResponse.java

Rule Violation Ligne
CommentRequired Header comments are required 38–62

fr/paris/lutece/plugins/workflow/modules/forms/business/CompleteFormResponseDAO.java

Rule Violation Ligne
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 66–87
ConfusingTernary Avoid if (x != y) ..; else ..; 76–83
ConfusingTernary Avoid if (x != y) ..; else ..; 101–108
AssignmentInOperand Avoid assignments in operands 204

fr/paris/lutece/plugins/workflow/modules/forms/business/CompleteFormResponseTaskConfigDAO.java

Rule Violation Ligne
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 58–70

fr/paris/lutece/plugins/workflow/modules/forms/business/CompleteFormResponseTaskHistory.java

Rule Violation Ligne
CommentRequired Header comments are required 36–38

fr/paris/lutece/plugins/workflow/modules/forms/business/CompleteFormResponseTaskHistoryDAO.java

Rule Violation Ligne
CommentRequired Header comments are required 44–122
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 56–69

fr/paris/lutece/plugins/workflow/modules/forms/business/CompleteFormResponseValue.java

Rule Violation Ligne
CommentRequired Header comments are required 36–38

fr/paris/lutece/plugins/workflow/modules/forms/business/CompleteFormResponseValueDAO.java

Rule Violation Ligne
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 57–69

fr/paris/lutece/plugins/workflow/modules/forms/business/DuplicateFormResponseTaskConfig.java

Rule Violation Ligne
CommentRequired Header comments are required 38–40

fr/paris/lutece/plugins/workflow/modules/forms/business/DuplicateFormResponseTaskConfigDAO.java

Rule Violation Ligne
CommentRequired Header comments are required 40–123

fr/paris/lutece/plugins/workflow/modules/forms/business/EditFormResponseConfig.java

Rule Violation Ligne
CommentRequired Header comments are required 41–102
RedundantFieldInitializer Avoid using redundant field initializer for '_bMultiform' 44
CommentRequired Public method and constructor comments are required 81–84

fr/paris/lutece/plugins/workflow/modules/forms/business/EditFormResponseConfigDao.java

Rule Violation Ligne
CommentRequired Header comments are required 41–123

fr/paris/lutece/plugins/workflow/modules/forms/business/EditFormResponseConfigValue.java

Rule Violation Ligne
CommentRequired Header comments are required 40–161

fr/paris/lutece/plugins/workflow/modules/forms/business/EditFormResponseConfigValueDao.java

Rule Violation Ligne
ConfusingTernary Avoid if (x != y) ..; else ..; 69–76
ConfusingTernary Avoid if (x != y) ..; else ..; 77–84
ConfusingTernary Avoid if (x != y) ..; else ..; 85–92
ConfusingTernary Avoid if (x != y) ..; else ..; 93–100
ConfusingTernary Avoid if (x != y) ..; else ..; 120–127
ConfusingTernary Avoid if (x != y) ..; else ..; 128–135
ConfusingTernary Avoid if (x != y) ..; else ..; 136–143
ConfusingTernary Avoid if (x != y) ..; else ..; 144–151

fr/paris/lutece/plugins/workflow/modules/forms/business/EditFormResponseConfigValueHome.java

Rule Violation Ligne
CommentRequired Header comments are required 42–116

fr/paris/lutece/plugins/workflow/modules/forms/business/EditFormResponseTaskHistory.java

Rule Violation Ligne
CommentRequired Header comments are required 36–57

fr/paris/lutece/plugins/workflow/modules/forms/business/EditFormResponseTaskHistoryDAO.java

Rule Violation Ligne
CommentRequired Header comments are required 44–124
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 56–70

fr/paris/lutece/plugins/workflow/modules/forms/business/FormResponseValueStateControllerConfig.java

Rule Violation Ligne
CommentRequired Header comments are required 40–186
DataClass The class 'FormResponseValueStateControllerConfig' is suspected to be a Data Class (WOC=0.000%, NOPA=0, NOAM=16, WMC=16) 40–186
ShortVariable Avoid variables with short names like id 63

fr/paris/lutece/plugins/workflow/modules/forms/business/FormResponseValueStateControllerConfigDao.java

Rule Violation Ligne
CommentRequired Header comments are required 44–173
ConfusingTernary Avoid if (x != y) ..; else ..; 59–66
ConfusingTernary Avoid if (x != y) ..; else ..; 67–74
ConfusingTernary Avoid if (x != y) ..; else ..; 75–82
ConfusingTernary Avoid if (x != y) ..; else ..; 98–105
ConfusingTernary Avoid if (x != y) ..; else ..; 106–113
ConfusingTernary Avoid if (x != y) ..; else ..; 114–121

fr/paris/lutece/plugins/workflow/modules/forms/business/FormResponseValueStateControllerConfigHome.java

Rule Violation Ligne
CommentRequired Header comments are required 40–93

fr/paris/lutece/plugins/workflow/modules/forms/business/ICompleteFormResponseTaskHistoryDAO.java

Rule Violation Ligne
CommentRequired Header comments are required 38–69

fr/paris/lutece/plugins/workflow/modules/forms/business/IEditFormResponseTaskHistoryDAO.java

Rule Violation Ligne
CommentRequired Header comments are required 38–70

fr/paris/lutece/plugins/workflow/modules/forms/business/IFormResponseValueStateControllerConfigDao.java

Rule Violation Ligne
CommentRequired Header comments are required 38–80

fr/paris/lutece/plugins/workflow/modules/forms/business/IModifyFormResponseUpdateStatusTaskConfigDAO.java

Rule Violation Ligne
CommentRequired Header comments are required 38–72

fr/paris/lutece/plugins/workflow/modules/forms/business/IResubmitFormResponseTaskHistoryDAO.java

Rule Violation Ligne
CommentRequired Header comments are required 38–69

fr/paris/lutece/plugins/workflow/modules/forms/business/ModifyFormResponseUpdateStatusTaskConfig.java

Rule Violation Ligne
CommentRequired Header comments are required 38–51
RedundantFieldInitializer Avoid using redundant field initializer for '_bPublished' 40
CommentRequired Public method and constructor comments are required 42–45
CommentRequired Public method and constructor comments are required 47–50

fr/paris/lutece/plugins/workflow/modules/forms/business/ModifyFormResponseUpdateStatusTaskConfigDAO.java

Rule Violation Ligne
CommentRequired Header comments are required 42–108

fr/paris/lutece/plugins/workflow/modules/forms/business/ResubmitFormResponse.java

Rule Violation Ligne
CommentRequired Header comments are required 38–63

fr/paris/lutece/plugins/workflow/modules/forms/business/ResubmitFormResponseDAO.java

Rule Violation Ligne
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 66–87
ConfusingTernary Avoid if (x != y) ..; else ..; 76–83
ConfusingTernary Avoid if (x != y) ..; else ..; 101–108
AssignmentInOperand Avoid assignments in operands 206

fr/paris/lutece/plugins/workflow/modules/forms/business/ResubmitFormResponseTaskConfigDAO.java

Rule Violation Ligne
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 59–71

fr/paris/lutece/plugins/workflow/modules/forms/business/ResubmitFormResponseTaskHistory.java

Rule Violation Ligne
CommentRequired Header comments are required 36–57

fr/paris/lutece/plugins/workflow/modules/forms/business/ResubmitFormResponseTaskHistoryDAO.java

Rule Violation Ligne
CommentRequired Header comments are required 44–121
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 53–67

fr/paris/lutece/plugins/workflow/modules/forms/business/ResubmitFormResponseValue.java

Rule Violation Ligne
CommentRequired Header comments are required 36–38

fr/paris/lutece/plugins/workflow/modules/forms/business/ResubmitFormResponseValueDAO.java

Rule Violation Ligne
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 57–69

fr/paris/lutece/plugins/workflow/modules/forms/service/AbstractFormResponseService.java

Rule Violation Ligne
CommentRequired Header comments are required 59–152
CommentRequired Protected method constructor comments are required 76–97
CommentRequired Protected method constructor comments are required 99–112
CommentRequired Protected method constructor comments are required 114
CommentRequired Protected method constructor comments are required 116–139
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 131–135

fr/paris/lutece/plugins/workflow/modules/forms/service/AbstractFormResponseStateController.java

Rule Violation Ligne
CommentRequired Header comments are required 66–276
CommentRequired Protected method constructor comments are required 108–139
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 112
CommentRequired Protected method constructor comments are required 190
CommentRequired Protected method constructor comments are required 192–202
CommentRequired Protected method constructor comments are required 204–221
CommentRequired Protected method constructor comments are required 223–234
CommentRequired Protected method constructor comments are required 236
CommentRequired Protected method constructor comments are required 238–275

fr/paris/lutece/plugins/workflow/modules/forms/service/CompleteFormResponseService.java

Rule Violation Ligne
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 34–336
CommentRequired Header comments are required 78–336
CyclomaticComplexity The method 'findListQuestionUsedCorrectForm(FormResponse)' has a cyclomatic complexity of 10. 107–156
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 117

fr/paris/lutece/plugins/workflow/modules/forms/service/FormResponseValueExistsStateController.java

Rule Violation Ligne
CommentRequired Header comments are required 51–108

fr/paris/lutece/plugins/workflow/modules/forms/service/FormResponseValueStateController.java

Rule Violation Ligne
CommentRequired Header comments are required 58–134
CommentRequired Protected method constructor comments are required 117–133
MissingOverride The method 'getResponseReferenceList(int)' is missing an @Override annotation. 117–133

fr/paris/lutece/plugins/workflow/modules/forms/service/ICompleteFormResponseService.java

Rule Violation Ligne
CommentRequired Header comments are required 49–173

fr/paris/lutece/plugins/workflow/modules/forms/service/ResubmitFormResponseService.java

Rule Violation Ligne
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 34–341

fr/paris/lutece/plugins/workflow/modules/forms/service/provider/AbstractCompleteFormResponseTaskInfoProvider.java

Rule Violation Ligne
CommentRequired Header comments are required 57–175
CommentRequired Public method and constructor comments are required 81
CommentRequired Protected method constructor comments are required 128
CommentRequired Protected method constructor comments are required 130
CommentRequired Protected method constructor comments are required 132
CommentRequired Protected method constructor comments are required 134
CommentRequired Protected method constructor comments are required 136
ConfusingTernary Avoid if (x != y) ..; else ..; 149–161

fr/paris/lutece/plugins/workflow/modules/forms/service/provider/CompleteFormResponseMarkerProvider.java

Rule Violation Ligne
ShortVariable Avoid variables with short names like ID 62
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 69

fr/paris/lutece/plugins/workflow/modules/forms/service/provider/CompleteFormResponseTaskInfoProvider.java

Rule Violation Ligne
CommentRequired Header comments are required 50–108

fr/paris/lutece/plugins/workflow/modules/forms/service/provider/ResubmitFormResponseMarkerProvider.java

Rule Violation Ligne
ShortVariable Avoid variables with short names like ID 62
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 69

fr/paris/lutece/plugins/workflow/modules/forms/service/provider/ResubmitFormResponseTaskInfoProvider.java

Rule Violation Ligne
CommentRequired Header comments are required 50–108

fr/paris/lutece/plugins/workflow/modules/forms/service/signrequest/CompleteFormResponseRequestAuthenticatorService.java

Rule Violation Ligne
CommentRequired Header comments are required 39–60

fr/paris/lutece/plugins/workflow/modules/forms/service/signrequest/ResubmitFormResponseRequestAuthenticatorService.java

Rule Violation Ligne
CommentRequired Header comments are required 39–60

fr/paris/lutece/plugins/workflow/modules/forms/service/task/AbstractEditFormsTask.java

Rule Violation Ligne
UnusedFormalParameter Avoid unused method parameters such as 'locale'. 106

fr/paris/lutece/plugins/workflow/modules/forms/service/task/CompleteFormResponseTask.java

Rule Violation Ligne
CommentRequired Header comments are required 56–172
CyclomaticComplexity The method 'processTask(int, HttpServletRequest, Locale)' has a cyclomatic complexity of 11. 72–127
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 95–107

fr/paris/lutece/plugins/workflow/modules/forms/service/task/CompleteFormResponseTaskHistoryService.java

Rule Violation Ligne
CommentRequired Header comments are required 47–76

fr/paris/lutece/plugins/workflow/modules/forms/service/task/DuplicateFormResponseTask.java

Rule Violation Ligne
CommentRequired Header comments are required 62–231
UnusedPrivateField Avoid unused private fields such as '_config'. 66
CommentRequired Public method and constructor comments are required 78–81
CallSuperInConstructor It is a good practice to call super() in a constructor 78–81

fr/paris/lutece/plugins/workflow/modules/forms/service/task/EditFormResponseAutoUpdateTask.java

Rule Violation Ligne
CallSuperInConstructor It is a good practice to call super() in a constructor 86–89
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 104

fr/paris/lutece/plugins/workflow/modules/forms/service/task/EditFormResponseConfigService.java

Rule Violation Ligne
CommentRequired Header comments are required 42–91

fr/paris/lutece/plugins/workflow/modules/forms/service/task/EditFormResponseTaskHistoryService.java

Rule Violation Ligne
CommentRequired Header comments are required 47–87

fr/paris/lutece/plugins/workflow/modules/forms/service/task/EditFormResponseTaskService.java

Rule Violation Ligne
MissingOverride The method 'saveResponses(FormResponse, List)' is missing an @Override annotation. 152–160
CommentRequired Public method and constructor comments are required 152–160

fr/paris/lutece/plugins/workflow/modules/forms/service/task/FormsTaskService.java

Rule Violation Ligne
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 34–467
TooManyMethods This class has too many methods, consider refactoring it. 87–467
ConfusingTernary Avoid if (x != y) ..; else ..; 371–385
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 383
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 389

fr/paris/lutece/plugins/workflow/modules/forms/service/task/ICompleteFormResponseTaskHistoryService.java

Rule Violation Ligne
CommentRequired Header comments are required 42–69

fr/paris/lutece/plugins/workflow/modules/forms/service/task/IEditFormResponseTaskHistoryService.java

Rule Violation Ligne
CommentRequired Header comments are required 42–69

fr/paris/lutece/plugins/workflow/modules/forms/service/task/IEditFormResponseTaskService.java

Rule Violation Ligne
CommentRequired Public method and constructor comments are required 75

fr/paris/lutece/plugins/workflow/modules/forms/service/task/IFormsTaskService.java

Rule Violation Ligne
TooManyMethods This class has too many methods, consider refactoring it. 56–220
CommentRequired Public method and constructor comments are required 100–101

fr/paris/lutece/plugins/workflow/modules/forms/service/task/IResubmitFormResponseTaskHistoryService.java

Rule Violation Ligne
CommentRequired Header comments are required 42–69

fr/paris/lutece/plugins/workflow/modules/forms/service/task/LinkedValuesFormResponseTaskService.java

Rule Violation Ligne
UnusedPrivateField Avoid unused private fields such as '_taskLinkedValuesFormResponseConfigService'. 65

fr/paris/lutece/plugins/workflow/modules/forms/service/task/ModifyFormResponseUpdateDateTask.java

Rule Violation Ligne
CommentRequired Public method and constructor comments are required 55–58
CallSuperInConstructor It is a good practice to call super() in a constructor 55–58

fr/paris/lutece/plugins/workflow/modules/forms/service/task/ModifyFormResponseUpdateStatusTask.java

Rule Violation Ligne
CommentRequired Header comments are required 51–95
CallSuperInConstructor It is a good practice to call super() in a constructor 63–66
CommentRequired Public method and constructor comments are required 63–66

fr/paris/lutece/plugins/workflow/modules/forms/service/task/ResubmitFormResponseTask.java

Rule Violation Ligne
CommentRequired Header comments are required 56–171
CyclomaticComplexity The method 'processTask(int, HttpServletRequest, Locale)' has a cyclomatic complexity of 11. 72–126
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 95–106

fr/paris/lutece/plugins/workflow/modules/forms/service/task/ResubmitFormResponseTaskHistoryService.java

Rule Violation Ligne
CommentRequired Header comments are required 47–76

fr/paris/lutece/plugins/workflow/modules/forms/utils/EditableResponse.java

Rule Violation Ligne
CommentRequired Header comments are required 39–90

fr/paris/lutece/plugins/workflow/modules/forms/utils/WorkflowFormsTaskException.java

Rule Violation Ligne
CommentRequired Public method and constructor comments are required 45–48

fr/paris/lutece/plugins/workflow/modules/forms/web/AbstractFormResponseApp.java

Rule Violation Ligne
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 96
ConfusingTernary Avoid if (x != y) ..; else ..; 112–129
CommentRequired Protected method constructor comments are required 139–155
CommentRequired Protected method constructor comments are required 157–173
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 159
CommentRequired Protected method constructor comments are required 188
CommentRequired Protected method constructor comments are required 190
CommentRequired Protected method constructor comments are required 203

fr/paris/lutece/plugins/workflow/modules/forms/web/CompleteFormResponseApp.java

Rule Violation Ligne
CommentRequired Header comments are required 62–178
ImmutableField Private field '_completeFormResponseService' could be made final; it is only initialized in the declaration or constructor. 77

fr/paris/lutece/plugins/workflow/modules/forms/web/ResubmitFormResponseApp.java

Rule Violation Ligne
CommentRequired Header comments are required 67–235
ImmutableField Private field '_resubmitFormResponseService' could be made final; it is only initialized in the declaration or constructor. 88
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 93
ConfusingTernary Avoid if (x != y) ..; else ..; 109–126

fr/paris/lutece/plugins/workflow/modules/forms/web/task/AbstractFormResponseTaskComponent.java

Rule Violation Ligne
CommentRequired Header comments are required 38–43

fr/paris/lutece/plugins/workflow/modules/forms/web/task/CompleteFormResponseTaskComponent.java

Rule Violation Ligne
CommentRequired Header comments are required 62–152
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 92
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 114
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 128

fr/paris/lutece/plugins/workflow/modules/forms/web/task/DuplicateFormResponseTaskComponent.java

Rule Violation Ligne
CommentRequired Header comments are required 43–56

fr/paris/lutece/plugins/workflow/modules/forms/web/task/EditFormResponseAutoUpdateTaskComponent.java

Rule Violation Ligne
UnusedFormalParameter Avoid unused constructor parameters such as 'editFormResponseTaskHistoryService'. 116
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 146
CommentRequired Protected method constructor comments are required 178–181

fr/paris/lutece/plugins/workflow/modules/forms/web/task/EditFormResponseFOTaskComponent.java

Rule Violation Ligne
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 81

fr/paris/lutece/plugins/workflow/modules/forms/web/task/EditFormResponseTaskComponent.java

Rule Violation Ligne
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 34–416
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 177–190
CommentRequired Protected method constructor comments are required 264–274
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 270
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 282
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 304
CommentRequired Protected method constructor comments are required 325–328

fr/paris/lutece/plugins/workflow/modules/forms/web/task/LinkedValuesFormResponseTaskComponent.java

Rule Violation Ligne
DefaultPackage Use explicit scoping instead of the default package private level 90–92
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the _configService field if you want a default access modifier 92
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 97
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 161

fr/paris/lutece/plugins/workflow/modules/forms/web/task/ModifyFormResponseUpdateStatusTaskComponent.java

Rule Violation Ligne
CommentRequired Header comments are required 51–84
SingularField Perhaps '_config' could be replaced by a local variable. 59
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 70

fr/paris/lutece/plugins/workflow/modules/forms/web/task/ResubmitFormResponseTaskComponent.java

Rule Violation Ligne
CommentRequired Header comments are required 62–152
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 92
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 114
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 128

Priority 4

fr/paris/lutece/plugins/workflow/modules/forms/service/CompleteFormResponseService.java

Rule Violation Ligne
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.genericattributes.business.EntryHome' 58

fr/paris/lutece/plugins/workflow/modules/forms/service/task/IFormsTaskService.java

Rule Violation Ligne
UnusedImports Avoid unused imports such as 'java.util.Collection' 36

Fichiers

fr/paris/lutece/plugins/workflow/modules/forms/business/AbstractCompleteFormResponse.java

Rule Violation Priority Ligne
CommentRequired Header comments are required 3 38–146
AbstractClassWithoutAbstractMethod This abstract class does not have any abstract methods 3 38–146

fr/paris/lutece/plugins/workflow/modules/forms/business/AbstractCompleteFormResponseTaskConfig.java

Rule Violation Priority Ligne
CommentRequired Header comments are required 3 41–89

fr/paris/lutece/plugins/workflow/modules/forms/business/AbstractCompleteFormResponseValue.java

Rule Violation Priority Ligne
AbstractClassWithoutAbstractMethod This abstract class does not have any abstract methods 3 38–112
CommentRequired Header comments are required 3 38–112

fr/paris/lutece/plugins/workflow/modules/forms/business/AbstractFormResponseTaskHistory.java

Rule Violation Priority Ligne
AbstractClassWithoutAbstractMethod This abstract class does not have any abstract methods 3 38–113
CommentRequired Header comments are required 3 38–113

fr/paris/lutece/plugins/workflow/modules/forms/business/CompleteFormResponse.java

Rule Violation Priority Ligne
CommentRequired Header comments are required 3 38–62

fr/paris/lutece/plugins/workflow/modules/forms/business/CompleteFormResponseDAO.java

Rule Violation Priority Ligne
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 3 66–87
ConfusingTernary Avoid if (x != y) ..; else ..; 3 76–83
ConfusingTernary Avoid if (x != y) ..; else ..; 3 101–108
AssignmentInOperand Avoid assignments in operands 3 204

fr/paris/lutece/plugins/workflow/modules/forms/business/CompleteFormResponseTaskConfigDAO.java

Rule Violation Priority Ligne
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 3 58–70

fr/paris/lutece/plugins/workflow/modules/forms/business/CompleteFormResponseTaskHistory.java

Rule Violation Priority Ligne
CommentRequired Header comments are required 3 36–38

fr/paris/lutece/plugins/workflow/modules/forms/business/CompleteFormResponseTaskHistoryDAO.java

Rule Violation Priority Ligne
CommentRequired Header comments are required 3 44–122
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 3 56–69

fr/paris/lutece/plugins/workflow/modules/forms/business/CompleteFormResponseValue.java

Rule Violation Priority Ligne
CommentRequired Header comments are required 3 36–38

fr/paris/lutece/plugins/workflow/modules/forms/business/CompleteFormResponseValueDAO.java

Rule Violation Priority Ligne
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 3 57–69

fr/paris/lutece/plugins/workflow/modules/forms/business/DuplicateFormResponseTaskConfig.java

Rule Violation Priority Ligne
CommentRequired Header comments are required 3 38–40

fr/paris/lutece/plugins/workflow/modules/forms/business/DuplicateFormResponseTaskConfigDAO.java

Rule Violation Priority Ligne
CommentRequired Header comments are required 3 40–123

fr/paris/lutece/plugins/workflow/modules/forms/business/EditFormResponseConfig.java

Rule Violation Priority Ligne
CommentRequired Header comments are required 3 41–102
RedundantFieldInitializer Avoid using redundant field initializer for '_bMultiform' 3 44
CommentRequired Public method and constructor comments are required 3 81–84

fr/paris/lutece/plugins/workflow/modules/forms/business/EditFormResponseConfigDao.java

Rule Violation Priority Ligne
CommentRequired Header comments are required 3 41–123

fr/paris/lutece/plugins/workflow/modules/forms/business/EditFormResponseConfigValue.java

Rule Violation Priority Ligne
CommentRequired Header comments are required 3 40–161

fr/paris/lutece/plugins/workflow/modules/forms/business/EditFormResponseConfigValueDao.java

Rule Violation Priority Ligne
ConfusingTernary Avoid if (x != y) ..; else ..; 3 69–76
ConfusingTernary Avoid if (x != y) ..; else ..; 3 77–84
ConfusingTernary Avoid if (x != y) ..; else ..; 3 85–92
ConfusingTernary Avoid if (x != y) ..; else ..; 3 93–100
ConfusingTernary Avoid if (x != y) ..; else ..; 3 120–127
ConfusingTernary Avoid if (x != y) ..; else ..; 3 128–135
ConfusingTernary Avoid if (x != y) ..; else ..; 3 136–143
ConfusingTernary Avoid if (x != y) ..; else ..; 3 144–151

fr/paris/lutece/plugins/workflow/modules/forms/business/EditFormResponseConfigValueHome.java

Rule Violation Priority Ligne
ClassWithOnlyPrivateConstructorsShouldBeFinal A class which only has private constructors should be final 1 42–116
CommentRequired Header comments are required 3 42–116

fr/paris/lutece/plugins/workflow/modules/forms/business/EditFormResponseTaskHistory.java

Rule Violation Priority Ligne
CommentRequired Header comments are required 3 36–57

fr/paris/lutece/plugins/workflow/modules/forms/business/EditFormResponseTaskHistoryDAO.java

Rule Violation Priority Ligne
CommentRequired Header comments are required 3 44–124
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 3 56–70

fr/paris/lutece/plugins/workflow/modules/forms/business/FormResponseValueStateControllerConfig.java

Rule Violation Priority Ligne
CommentRequired Header comments are required 3 40–186
DataClass The class 'FormResponseValueStateControllerConfig' is suspected to be a Data Class (WOC=0.000%, NOPA=0, NOAM=16, WMC=16) 3 40–186
ShortVariable Avoid variables with short names like id 3 63

fr/paris/lutece/plugins/workflow/modules/forms/business/FormResponseValueStateControllerConfigDao.java

Rule Violation Priority Ligne
CommentRequired Header comments are required 3 44–173
ConfusingTernary Avoid if (x != y) ..; else ..; 3 59–66
ConfusingTernary Avoid if (x != y) ..; else ..; 3 67–74
ConfusingTernary Avoid if (x != y) ..; else ..; 3 75–82
ConfusingTernary Avoid if (x != y) ..; else ..; 3 98–105
ConfusingTernary Avoid if (x != y) ..; else ..; 3 106–113
ConfusingTernary Avoid if (x != y) ..; else ..; 3 114–121

fr/paris/lutece/plugins/workflow/modules/forms/business/FormResponseValueStateControllerConfigHome.java

Rule Violation Priority Ligne
ClassWithOnlyPrivateConstructorsShouldBeFinal A class which only has private constructors should be final 1 40–93
CommentRequired Header comments are required 3 40–93

fr/paris/lutece/plugins/workflow/modules/forms/business/ICompleteFormResponseTaskHistoryDAO.java

Rule Violation Priority Ligne
CommentRequired Header comments are required 3 38–69

fr/paris/lutece/plugins/workflow/modules/forms/business/IEditFormResponseTaskHistoryDAO.java

Rule Violation Priority Ligne
CommentRequired Header comments are required 3 38–70

fr/paris/lutece/plugins/workflow/modules/forms/business/IFormResponseValueStateControllerConfigDao.java

Rule Violation Priority Ligne
CommentRequired Header comments are required 3 38–80

fr/paris/lutece/plugins/workflow/modules/forms/business/IModifyFormResponseUpdateStatusTaskConfigDAO.java

Rule Violation Priority Ligne
CommentRequired Header comments are required 3 38–72

fr/paris/lutece/plugins/workflow/modules/forms/business/IResubmitFormResponseTaskHistoryDAO.java

Rule Violation Priority Ligne
CommentRequired Header comments are required 3 38–69

fr/paris/lutece/plugins/workflow/modules/forms/business/ModifyFormResponseUpdateStatusTaskConfig.java

Rule Violation Priority Ligne
CommentRequired Header comments are required 3 38–51
RedundantFieldInitializer Avoid using redundant field initializer for '_bPublished' 3 40
CommentRequired Public method and constructor comments are required 3 42–45
CommentRequired Public method and constructor comments are required 3 47–50

fr/paris/lutece/plugins/workflow/modules/forms/business/ModifyFormResponseUpdateStatusTaskConfigDAO.java

Rule Violation Priority Ligne
CommentRequired Header comments are required 3 42–108

fr/paris/lutece/plugins/workflow/modules/forms/business/ResubmitFormResponse.java

Rule Violation Priority Ligne
CommentRequired Header comments are required 3 38–63

fr/paris/lutece/plugins/workflow/modules/forms/business/ResubmitFormResponseDAO.java

Rule Violation Priority Ligne
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 3 66–87
ConfusingTernary Avoid if (x != y) ..; else ..; 3 76–83
ConfusingTernary Avoid if (x != y) ..; else ..; 3 101–108
AssignmentInOperand Avoid assignments in operands 3 206

fr/paris/lutece/plugins/workflow/modules/forms/business/ResubmitFormResponseTaskConfigDAO.java

Rule Violation Priority Ligne
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 3 59–71

fr/paris/lutece/plugins/workflow/modules/forms/business/ResubmitFormResponseTaskHistory.java

Rule Violation Priority Ligne
CommentRequired Header comments are required 3 36–57

fr/paris/lutece/plugins/workflow/modules/forms/business/ResubmitFormResponseTaskHistoryDAO.java

Rule Violation Priority Ligne
CommentRequired Header comments are required 3 44–121
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 3 53–67

fr/paris/lutece/plugins/workflow/modules/forms/business/ResubmitFormResponseValue.java

Rule Violation Priority Ligne
CommentRequired Header comments are required 3 36–38

fr/paris/lutece/plugins/workflow/modules/forms/business/ResubmitFormResponseValueDAO.java

Rule Violation Priority Ligne
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 3 57–69

fr/paris/lutece/plugins/workflow/modules/forms/service/AbstractFormResponseService.java

Rule Violation Priority Ligne
CommentRequired Header comments are required 3 59–152
CommentRequired Protected method constructor comments are required 3 76–97
CommentRequired Protected method constructor comments are required 3 99–112
CommentRequired Protected method constructor comments are required 3 114
CommentRequired Protected method constructor comments are required 3 116–139
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 3 131–135

fr/paris/lutece/plugins/workflow/modules/forms/service/AbstractFormResponseStateController.java

Rule Violation Priority Ligne
CommentRequired Header comments are required 3 66–276
CommentRequired Protected method constructor comments are required 3 108–139
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 112
CommentRequired Protected method constructor comments are required 3 190
CommentRequired Protected method constructor comments are required 3 192–202
CommentRequired Protected method constructor comments are required 3 204–221
CommentRequired Protected method constructor comments are required 3 223–234
CommentRequired Protected method constructor comments are required 3 236
CommentRequired Protected method constructor comments are required 3 238–275

fr/paris/lutece/plugins/workflow/modules/forms/service/CompleteFormResponseService.java

Rule Violation Priority Ligne
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 3 34–336
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.genericattributes.business.EntryHome' 4 58
CommentRequired Header comments are required 3 78–336
CyclomaticComplexity The method 'findListQuestionUsedCorrectForm(FormResponse)' has a cyclomatic complexity of 10. 3 107–156
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 117

fr/paris/lutece/plugins/workflow/modules/forms/service/FormResponseValueExistsStateController.java

Rule Violation Priority Ligne
CommentRequired Header comments are required 3 51–108

fr/paris/lutece/plugins/workflow/modules/forms/service/FormResponseValueStateController.java

Rule Violation Priority Ligne
CommentRequired Header comments are required 3 58–134
CommentRequired Protected method constructor comments are required 3 117–133
MissingOverride The method 'getResponseReferenceList(int)' is missing an @Override annotation. 3 117–133

fr/paris/lutece/plugins/workflow/modules/forms/service/ICompleteFormResponseService.java

Rule Violation Priority Ligne
CommentRequired Header comments are required 3 49–173

fr/paris/lutece/plugins/workflow/modules/forms/service/ResubmitFormResponseService.java

Rule Violation Priority Ligne
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 3 34–341

fr/paris/lutece/plugins/workflow/modules/forms/service/provider/AbstractCompleteFormResponseTaskInfoProvider.java

Rule Violation Priority Ligne
CommentRequired Header comments are required 3 57–175
CommentRequired Public method and constructor comments are required 3 81
CommentRequired Protected method constructor comments are required 3 128
CommentRequired Protected method constructor comments are required 3 130
CommentRequired Protected method constructor comments are required 3 132
CommentRequired Protected method constructor comments are required 3 134
CommentRequired Protected method constructor comments are required 3 136
ConfusingTernary Avoid if (x != y) ..; else ..; 3 149–161

fr/paris/lutece/plugins/workflow/modules/forms/service/provider/CompleteFormResponseMarkerProvider.java

Rule Violation Priority Ligne
ShortVariable Avoid variables with short names like ID 3 62
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 3 69

fr/paris/lutece/plugins/workflow/modules/forms/service/provider/CompleteFormResponseTaskInfoProvider.java

Rule Violation Priority Ligne
CommentRequired Header comments are required 3 50–108

fr/paris/lutece/plugins/workflow/modules/forms/service/provider/ResubmitFormResponseMarkerProvider.java

Rule Violation Priority Ligne
ShortVariable Avoid variables with short names like ID 3 62
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 3 69

fr/paris/lutece/plugins/workflow/modules/forms/service/provider/ResubmitFormResponseTaskInfoProvider.java

Rule Violation Priority Ligne
CommentRequired Header comments are required 3 50–108

fr/paris/lutece/plugins/workflow/modules/forms/service/signrequest/CompleteFormResponseRequestAuthenticatorService.java

Rule Violation Priority Ligne
CommentRequired Header comments are required 3 39–60

fr/paris/lutece/plugins/workflow/modules/forms/service/signrequest/ResubmitFormResponseRequestAuthenticatorService.java

Rule Violation Priority Ligne
CommentRequired Header comments are required 3 39–60

fr/paris/lutece/plugins/workflow/modules/forms/service/task/AbstractEditFormsTask.java

Rule Violation Priority Ligne
FieldNamingConventions The final field name '_formsTaskService' doesn't match '[a-z][a-zA-Z0-9]*' 1 59
FieldNamingConventions The final field name '_editFormResponseTaskService' doesn't match '[a-z][a-zA-Z0-9]*' 1 60
FieldNamingConventions The final field name '_editFormResponseTaskHistoryService' doesn't match '[a-z][a-zA-Z0-9]*' 1 61
UnusedFormalParameter Avoid unused method parameters such as 'locale'. 3 106

fr/paris/lutece/plugins/workflow/modules/forms/service/task/CompleteFormResponseTask.java

Rule Violation Priority Ligne
CommentRequired Header comments are required 3 56–172
CyclomaticComplexity The method 'processTask(int, HttpServletRequest, Locale)' has a cyclomatic complexity of 11. 3 72–127
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 3 95–107

fr/paris/lutece/plugins/workflow/modules/forms/service/task/CompleteFormResponseTaskHistoryService.java

Rule Violation Priority Ligne
CommentRequired Header comments are required 3 47–76

fr/paris/lutece/plugins/workflow/modules/forms/service/task/DuplicateFormResponseTask.java

Rule Violation Priority Ligne
CommentRequired Header comments are required 3 62–231
UnusedPrivateField Avoid unused private fields such as '_config'. 3 66
FieldNamingConventions The final field name '_formsTaskService' doesn't match '[a-z][a-zA-Z0-9]*' 1 75
CommentRequired Public method and constructor comments are required 3 78–81
CallSuperInConstructor It is a good practice to call super() in a constructor 3 78–81

fr/paris/lutece/plugins/workflow/modules/forms/service/task/EditFormResponseAutoUpdateTask.java

Rule Violation Priority Ligne
FieldNamingConventions The final field name '_formsTaskService' doesn't match '[a-z][a-zA-Z0-9]*' 1 67
CallSuperInConstructor It is a good practice to call super() in a constructor 3 86–89
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 104

fr/paris/lutece/plugins/workflow/modules/forms/service/task/EditFormResponseConfigService.java

Rule Violation Priority Ligne
CommentRequired Header comments are required 3 42–91

fr/paris/lutece/plugins/workflow/modules/forms/service/task/EditFormResponseTaskHistoryService.java

Rule Violation Priority Ligne
CommentRequired Header comments are required 3 47–87
FieldNamingConventions The final field name '_editFormResponseTaskHistoryDAO' doesn't match '[a-z][a-zA-Z0-9]*' 1 49

fr/paris/lutece/plugins/workflow/modules/forms/service/task/EditFormResponseTaskService.java

Rule Violation Priority Ligne
MissingOverride The method 'saveResponses(FormResponse, List)' is missing an @Override annotation. 3 152–160
CommentRequired Public method and constructor comments are required 3 152–160

fr/paris/lutece/plugins/workflow/modules/forms/service/task/FormsTaskService.java

Rule Violation Priority Ligne
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 3 34–467
TooManyMethods This class has too many methods, consider refactoring it. 3 87–467
ConfusingTernary Avoid if (x != y) ..; else ..; 3 371–385
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 3 383
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 3 389

fr/paris/lutece/plugins/workflow/modules/forms/service/task/ICompleteFormResponseTaskHistoryService.java

Rule Violation Priority Ligne
CommentRequired Header comments are required 3 42–69

fr/paris/lutece/plugins/workflow/modules/forms/service/task/IEditFormResponseTaskHistoryService.java

Rule Violation Priority Ligne
CommentRequired Header comments are required 3 42–69

fr/paris/lutece/plugins/workflow/modules/forms/service/task/IEditFormResponseTaskService.java

Rule Violation Priority Ligne
CommentRequired Public method and constructor comments are required 3 75

fr/paris/lutece/plugins/workflow/modules/forms/service/task/IFormsTaskService.java

Rule Violation Priority Ligne
UnusedImports Avoid unused imports such as 'java.util.Collection' 4 36
TooManyMethods This class has too many methods, consider refactoring it. 3 56–220
CommentRequired Public method and constructor comments are required 3 100–101

fr/paris/lutece/plugins/workflow/modules/forms/service/task/IResubmitFormResponseTaskHistoryService.java

Rule Violation Priority Ligne
CommentRequired Header comments are required 3 42–69

fr/paris/lutece/plugins/workflow/modules/forms/service/task/LinkedValuesFormResponseTaskService.java

Rule Violation Priority Ligne
UnusedPrivateField Avoid unused private fields such as '_taskLinkedValuesFormResponseConfigService'. 3 65

fr/paris/lutece/plugins/workflow/modules/forms/service/task/ModifyFormResponseUpdateDateTask.java

Rule Violation Priority Ligne
FieldNamingConventions The final field name '_formsTaskService' doesn't match '[a-z][a-zA-Z0-9]*' 1 52
CommentRequired Public method and constructor comments are required 3 55–58
CallSuperInConstructor It is a good practice to call super() in a constructor 3 55–58

fr/paris/lutece/plugins/workflow/modules/forms/service/task/ModifyFormResponseUpdateStatusTask.java

Rule Violation Priority Ligne
CommentRequired Header comments are required 3 51–95
FieldNamingConventions The final field name '_formsTaskService' doesn't match '[a-z][a-zA-Z0-9]*' 1 53
CallSuperInConstructor It is a good practice to call super() in a constructor 3 63–66
CommentRequired Public method and constructor comments are required 3 63–66

fr/paris/lutece/plugins/workflow/modules/forms/service/task/ResubmitFormResponseTask.java

Rule Violation Priority Ligne
CommentRequired Header comments are required 3 56–171
CyclomaticComplexity The method 'processTask(int, HttpServletRequest, Locale)' has a cyclomatic complexity of 11. 3 72–126
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 3 95–106

fr/paris/lutece/plugins/workflow/modules/forms/service/task/ResubmitFormResponseTaskHistoryService.java

Rule Violation Priority Ligne
CommentRequired Header comments are required 3 47–76

fr/paris/lutece/plugins/workflow/modules/forms/utils/EditableResponse.java

Rule Violation Priority Ligne
CommentRequired Header comments are required 3 39–90
FieldNamingConventions The final field name '_question' doesn't match '[a-z][a-zA-Z0-9]*' 1 42
FieldNamingConventions The final field name '_responseSaved' doesn't match '[a-z][a-zA-Z0-9]*' 1 43
FieldNamingConventions The final field name '_responseFromForm' doesn't match '[a-z][a-zA-Z0-9]*' 1 44

fr/paris/lutece/plugins/workflow/modules/forms/utils/WorkflowFormsTaskException.java

Rule Violation Priority Ligne
CommentRequired Public method and constructor comments are required 3 45–48

fr/paris/lutece/plugins/workflow/modules/forms/web/AbstractFormResponseApp.java

Rule Violation Priority Ligne
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 96
ConfusingTernary Avoid if (x != y) ..; else ..; 3 112–129
CommentRequired Protected method constructor comments are required 3 139–155
CommentRequired Protected method constructor comments are required 3 157–173
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 159
CommentRequired Protected method constructor comments are required 3 188
CommentRequired Protected method constructor comments are required 3 190
CommentRequired Protected method constructor comments are required 3 203

fr/paris/lutece/plugins/workflow/modules/forms/web/CompleteFormResponseApp.java

Rule Violation Priority Ligne
CommentRequired Header comments are required 3 62–178
ImmutableField Private field '_completeFormResponseService' could be made final; it is only initialized in the declaration or constructor. 3 77

fr/paris/lutece/plugins/workflow/modules/forms/web/ResubmitFormResponseApp.java

Rule Violation Priority Ligne
CommentRequired Header comments are required 3 67–235
ImmutableField Private field '_resubmitFormResponseService' could be made final; it is only initialized in the declaration or constructor. 3 88
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 93
ConfusingTernary Avoid if (x != y) ..; else ..; 3 109–126

fr/paris/lutece/plugins/workflow/modules/forms/web/task/AbstractFormResponseTaskComponent.java

Rule Violation Priority Ligne
AbstractClassWithoutAnyMethod No abstract method which means that the keyword is most likely used to prevent instantiation. Use a private or protected constructor instead. 1 38–43
CommentRequired Header comments are required 3 38–43

fr/paris/lutece/plugins/workflow/modules/forms/web/task/CompleteFormResponseTaskComponent.java

Rule Violation Priority Ligne
CommentRequired Header comments are required 3 62–152
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 92
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 114
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 128

fr/paris/lutece/plugins/workflow/modules/forms/web/task/DuplicateFormResponseTaskComponent.java

Rule Violation Priority Ligne
CommentRequired Header comments are required 3 43–56

fr/paris/lutece/plugins/workflow/modules/forms/web/task/EditFormResponseAutoUpdateTaskComponent.java

Rule Violation Priority Ligne
FieldNamingConventions The final field name '_formsTaskService' doesn't match '[a-z][a-zA-Z0-9]*' 1 101
FieldNamingConventions The final field name '_editFormResponseTaskService' doesn't match '[a-z][a-zA-Z0-9]*' 1 102
UnusedFormalParameter Avoid unused constructor parameters such as 'editFormResponseTaskHistoryService'. 3 116
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 146
CommentRequired Protected method constructor comments are required 3 178–181

fr/paris/lutece/plugins/workflow/modules/forms/web/task/EditFormResponseFOTaskComponent.java

Rule Violation Priority Ligne
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 81

fr/paris/lutece/plugins/workflow/modules/forms/web/task/EditFormResponseTaskComponent.java

Rule Violation Priority Ligne
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 3 34–416
FieldNamingConventions The final field name '_formsTaskService' doesn't match '[a-z][a-zA-Z0-9]*' 1 115
FieldNamingConventions The final field name '_editFormResponseTaskService' doesn't match '[a-z][a-zA-Z0-9]*' 1 116
FieldNamingConventions The final field name '_editFormResponseTaskHistoryService' doesn't match '[a-z][a-zA-Z0-9]*' 1 117
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 3 177–190
CommentRequired Protected method constructor comments are required 3 264–274
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 270
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 282
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 304
CommentRequired Protected method constructor comments are required 3 325–328

fr/paris/lutece/plugins/workflow/modules/forms/web/task/LinkedValuesFormResponseTaskComponent.java

Rule Violation Priority Ligne
DefaultPackage Use explicit scoping instead of the default package private level 3 90–92
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the _configService field if you want a default access modifier 3 92
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 97
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 161

fr/paris/lutece/plugins/workflow/modules/forms/web/task/ModifyFormResponseUpdateStatusTaskComponent.java

Rule Violation Priority Ligne
CommentRequired Header comments are required 3 51–84
SingularField Perhaps '_config' could be replaced by a local variable. 3 59
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 70

fr/paris/lutece/plugins/workflow/modules/forms/web/task/ResubmitFormResponseTaskComponent.java

Rule Violation Priority Ligne
CommentRequired Header comments are required 3 62–152
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 92
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 114
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 128