Fork me on GitHub

PMD Results

The following document contains the results of PMD 6.13.0.

Violations By Priority

Priority 1

fr/paris/lutece/plugins/workflow/modules/formspdf/service/AbstractFileGenerator.java

Rule Violation Line
FieldNamingConventions The final field name '_formResponse' doesn't match '[a-z][a-zA-Z0-9]*' 62
FieldNamingConventions The final field name '_fileName' doesn't match '[a-z][a-zA-Z0-9]*' 63
FieldNamingConventions The final field name '_fileDescription' doesn't match '[a-z][a-zA-Z0-9]*' 64
FieldNamingConventions The final field name '_formsPDFTaskTemplate' doesn't match '[a-z][a-zA-Z0-9]*' 65

fr/paris/lutece/plugins/workflow/modules/formspdf/service/HtmlToPDFGenerator.java

Rule Violation Line
AvoidThrowingRawExceptionTypes Avoid throwing raw exception types. 174
AvoidThrowingRawExceptionTypes Avoid throwing raw exception types. 180

fr/paris/lutece/plugins/workflow/modules/formspdf/service/task/FormsPDFTask.java

Rule Violation Line
FieldNamingConventions The constant name '_formsPDFTaskConfigService' doesn't match '[A-Z][A-Z_0-9]*' 82
FieldNamingConventions The constant name '_resourceHistoryService' doesn't match '[A-Z][A-Z_0-9]*' 87
AvoidThrowingRawExceptionTypes Avoid throwing raw exception types. 144

Priority 2

fr/paris/lutece/plugins/workflow/modules/formspdf/web/task/FormsPDFTaskTemplateJspBean.java

Rule Violation Line
AvoidReassigningParameters Avoid reassigning parameters such as 'strtemplate' 220
AvoidReassigningParameters Avoid reassigning parameters such as 'strtemplate' 231

Priority 3

fr/paris/lutece/plugins/workflow/modules/formspdf/business/FormsPDFTaskConfigDAO.java

Rule Violation Line
AvoidDuplicateLiterals The String literal "resource" appears 4 times in this file; the first occurrence is on line 73 73

fr/paris/lutece/plugins/workflow/modules/formspdf/business/FormsPDFTaskTemplate.java

Rule Violation Line
CommentRequired Header comments are required 3696
CommentRequired Public method and constructor comments are required 5052
CommentRequired Public method and constructor comments are required 5456
CommentRequired Public method and constructor comments are required 5860
CommentRequired Public method and constructor comments are required 6264
CommentRequired Public method and constructor comments are required 6668
CommentRequired Public method and constructor comments are required 7072
CommentRequired Public method and constructor comments are required 7476
CommentRequired Public method and constructor comments are required 7880
CommentRequired Public method and constructor comments are required 8284
CommentRequired Public method and constructor comments are required 8688
CommentRequired Public method and constructor comments are required 8991
CommentRequired Public method and constructor comments are required 9294

fr/paris/lutece/plugins/workflow/modules/formspdf/business/FormsPDFTaskTemplateDAO.java

Rule Violation Line
CommentRequired Header comments are required 44207

fr/paris/lutece/plugins/workflow/modules/formspdf/business/FormsPDFTaskTemplateDTO.java

Rule Violation Line
CommentRequired Header comments are required 3652
UnnecessaryConstructor Avoid unnecessary constructors - the compiler will generate these for you 4042
CommentRequired Public method and constructor comments are required 4042
CommentRequired Public method and constructor comments are required 4446
CommentRequired Public method and constructor comments are required 4850

fr/paris/lutece/plugins/workflow/modules/formspdf/business/FormsPDFTaskTemplateHome.java

Rule Violation Line
CommentRequired Header comments are required 4086
CommentRequired Public method and constructor comments are required 4953
CommentRequired Public method and constructor comments are required 5559
CommentRequired Public method and constructor comments are required 6164
CommentRequired Public method and constructor comments are required 6669
CommentRequired Public method and constructor comments are required 7174
CommentRequired Public method and constructor comments are required 7679
CommentRequired Public method and constructor comments are required 8184

fr/paris/lutece/plugins/workflow/modules/formspdf/business/IFormsPDFTaskTemplateDAO.java

Rule Violation Line
CommentRequired Header comments are required 3854
CommentRequired Public method and constructor comments are required 40
CommentRequired Public method and constructor comments are required 42
CommentRequired Public method and constructor comments are required 44
CommentRequired Public method and constructor comments are required 46
CommentRequired Public method and constructor comments are required 48
CommentRequired Public method and constructor comments are required 50
CommentRequired Public method and constructor comments are required 52

fr/paris/lutece/plugins/workflow/modules/formspdf/service/AbstractFileGenerator.java

Rule Violation Line
CommentRequired Header comments are required 54117
RedundantFieldInitializer Avoid using redundant field initializer for '_configList' 67

fr/paris/lutece/plugins/workflow/modules/formspdf/service/FormsPDFPlugin.java

Rule Violation Line
CallSuperInConstructor It is a good practice to call super() in a constructor 5558

fr/paris/lutece/plugins/workflow/modules/formspdf/service/HtmlToPDFGenerator.java

Rule Violation Line
FieldDeclarationsShouldBeAtStartOfClass Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 77
FieldDeclarationsShouldBeAtStartOfClass Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 78
FieldDeclarationsShouldBeAtStartOfClass Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 79
IdenticalCatchBranches 'catch' branch identical to 'PdfConverterServiceException' branch 176181

fr/paris/lutece/plugins/workflow/modules/formspdf/service/task/FormsPDFTask.java

Rule Violation Line
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 119
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 138

fr/paris/lutece/plugins/workflow/modules/formspdf/web/task/FormsPDFTaskComponent.java

Rule Violation Line
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 102
ConfusingTernary Avoid if (x != y) ..; else ..; 112
ConfusingTernary Avoid if (x != y) ..; else ..; 128135

fr/paris/lutece/plugins/workflow/modules/formspdf/web/task/FormsPDFTaskTemplateJspBean.java

Rule Violation Line
CommentRequired Header comments are required 54237
CommentRequired Public method and constructor comments are required 98111
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 113
CommentRequired Public method and constructor comments are required 114155
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 157
CommentRequired Public method and constructor comments are required 158174
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 176
CommentRequired Public method and constructor comments are required 177186

Priority 4

fr/paris/lutece/plugins/workflow/modules/formspdf/service/task/FormsPDFTask.java

Rule Violation Line
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.workflowcore.service.provider.InfoMarker' 60
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.forms.business.FormQuestionResponse' 61

fr/paris/lutece/plugins/workflow/modules/formspdf/web/task/FormsPDFTaskTemplateJspBean.java

Rule Violation Line
UnusedImports Avoid unused imports such as 'java.util.Locale' 36

Files

fr/paris/lutece/plugins/workflow/modules/formspdf/business/FormsPDFTaskConfigDAO.java

Rule Violation Priority Line
AvoidDuplicateLiterals The String literal "resource" appears 4 times in this file; the first occurrence is on line 73 3 73

fr/paris/lutece/plugins/workflow/modules/formspdf/business/FormsPDFTaskTemplate.java

Rule Violation Priority Line
CommentRequired Header comments are required 3 3696
CommentRequired Public method and constructor comments are required 3 5052
CommentRequired Public method and constructor comments are required 3 5456
CommentRequired Public method and constructor comments are required 3 5860
CommentRequired Public method and constructor comments are required 3 6264
CommentRequired Public method and constructor comments are required 3 6668
CommentRequired Public method and constructor comments are required 3 7072
CommentRequired Public method and constructor comments are required 3 7476
CommentRequired Public method and constructor comments are required 3 7880
CommentRequired Public method and constructor comments are required 3 8284
CommentRequired Public method and constructor comments are required 3 8688
CommentRequired Public method and constructor comments are required 3 8991
CommentRequired Public method and constructor comments are required 3 9294

fr/paris/lutece/plugins/workflow/modules/formspdf/business/FormsPDFTaskTemplateDAO.java

Rule Violation Priority Line
CommentRequired Header comments are required 3 44207

fr/paris/lutece/plugins/workflow/modules/formspdf/business/FormsPDFTaskTemplateDTO.java

Rule Violation Priority Line
CommentRequired Header comments are required 3 3652
UnnecessaryConstructor Avoid unnecessary constructors - the compiler will generate these for you 3 4042
CommentRequired Public method and constructor comments are required 3 4042
CommentRequired Public method and constructor comments are required 3 4446
CommentRequired Public method and constructor comments are required 3 4850

fr/paris/lutece/plugins/workflow/modules/formspdf/business/FormsPDFTaskTemplateHome.java

Rule Violation Priority Line
CommentRequired Header comments are required 3 4086
CommentRequired Public method and constructor comments are required 3 4953
CommentRequired Public method and constructor comments are required 3 5559
CommentRequired Public method and constructor comments are required 3 6164
CommentRequired Public method and constructor comments are required 3 6669
CommentRequired Public method and constructor comments are required 3 7174
CommentRequired Public method and constructor comments are required 3 7679
CommentRequired Public method and constructor comments are required 3 8184

fr/paris/lutece/plugins/workflow/modules/formspdf/business/IFormsPDFTaskTemplateDAO.java

Rule Violation Priority Line
CommentRequired Header comments are required 3 3854
CommentRequired Public method and constructor comments are required 3 40
CommentRequired Public method and constructor comments are required 3 42
CommentRequired Public method and constructor comments are required 3 44
CommentRequired Public method and constructor comments are required 3 46
CommentRequired Public method and constructor comments are required 3 48
CommentRequired Public method and constructor comments are required 3 50
CommentRequired Public method and constructor comments are required 3 52

fr/paris/lutece/plugins/workflow/modules/formspdf/service/AbstractFileGenerator.java

Rule Violation Priority Line
CommentRequired Header comments are required 3 54117
FieldNamingConventions The final field name '_formResponse' doesn't match '[a-z][a-zA-Z0-9]*' 1 62
FieldNamingConventions The final field name '_fileName' doesn't match '[a-z][a-zA-Z0-9]*' 1 63
FieldNamingConventions The final field name '_fileDescription' doesn't match '[a-z][a-zA-Z0-9]*' 1 64
FieldNamingConventions The final field name '_formsPDFTaskTemplate' doesn't match '[a-z][a-zA-Z0-9]*' 1 65
RedundantFieldInitializer Avoid using redundant field initializer for '_configList' 3 67

fr/paris/lutece/plugins/workflow/modules/formspdf/service/FormsPDFPlugin.java

Rule Violation Priority Line
CallSuperInConstructor It is a good practice to call super() in a constructor 3 5558

fr/paris/lutece/plugins/workflow/modules/formspdf/service/HtmlToPDFGenerator.java

Rule Violation Priority Line
FieldDeclarationsShouldBeAtStartOfClass Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 3 77
FieldDeclarationsShouldBeAtStartOfClass Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 3 78
FieldDeclarationsShouldBeAtStartOfClass Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 3 79
AvoidThrowingRawExceptionTypes Avoid throwing raw exception types. 1 174
IdenticalCatchBranches 'catch' branch identical to 'PdfConverterServiceException' branch 3 176181
AvoidThrowingRawExceptionTypes Avoid throwing raw exception types. 1 180

fr/paris/lutece/plugins/workflow/modules/formspdf/service/task/FormsPDFTask.java

Rule Violation Priority Line
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.workflowcore.service.provider.InfoMarker' 4 60
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.forms.business.FormQuestionResponse' 4 61
FieldNamingConventions The constant name '_formsPDFTaskConfigService' doesn't match '[A-Z][A-Z_0-9]*' 1 82
FieldNamingConventions The constant name '_resourceHistoryService' doesn't match '[A-Z][A-Z_0-9]*' 1 87
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 119
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 138
AvoidThrowingRawExceptionTypes Avoid throwing raw exception types. 1 144

fr/paris/lutece/plugins/workflow/modules/formspdf/web/task/FormsPDFTaskComponent.java

Rule Violation Priority Line
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 102
ConfusingTernary Avoid if (x != y) ..; else ..; 3 112
ConfusingTernary Avoid if (x != y) ..; else ..; 3 128135

fr/paris/lutece/plugins/workflow/modules/formspdf/web/task/FormsPDFTaskTemplateJspBean.java

Rule Violation Priority Line
UnusedImports Avoid unused imports such as 'java.util.Locale' 4 36
CommentRequired Header comments are required 3 54237
CommentRequired Public method and constructor comments are required 3 98111
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 3 113
CommentRequired Public method and constructor comments are required 3 114155
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 3 157
CommentRequired Public method and constructor comments are required 3 158174
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 3 176
CommentRequired Public method and constructor comments are required 3 177186
AvoidReassigningParameters Avoid reassigning parameters such as 'strtemplate' 2 220
AvoidReassigningParameters Avoid reassigning parameters such as 'strtemplate' 2 231