Fork me on GitHub

PMD Results

The following document contains the results of PMD 5.3.5.

Files

fr/paris/lutece/plugins/workflow/modules/notifycrm/business/TaskNotifyCRMConfig.java

Violation Line
A getX() method which returns a boolean should be named isX() 132135

fr/paris/lutece/plugins/workflow/modules/notifycrm/business/TaskNotifyCRMConfigDAO.java

Violation Line
Use block level rather than method level synchronization 6079

fr/paris/lutece/plugins/workflow/modules/notifycrm/service/NotifyCRMPlugin.java

Violation Line
All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 4759

fr/paris/lutece/plugins/workflow/modules/notifycrm/service/NotifyCRMService.java

Violation Line
Possible God class (WMC=77, ATFD=140, TCC=0.0) 34633
A high number of imports can indicate a high degree of coupling within an object. 34633
The class 'NotifyCRMService' has a Cyclomatic Complexity of 4 (Highest = 19). 84633
The class 'NotifyCRMService' has a Standard Cyclomatic Complexity of 3 (Highest = 10). 84633
The class 'NotifyCRMService' has a Modified Cyclomatic Complexity of 3 (Highest = 10). 84633
Private field '_listAcceptedEntryTypesIdDemand' could be made final; it is only initialized in the declaration or constructor. 88
Private field '_listRefusedEntryTypes' could be made final; it is only initialized in the declaration or constructor. 89
Private field '_listAcceptedEntryTypesUserGuid' could be made final; it is only initialized in the declaration or constructor. 90
Private field '_listAcceptedEntryTypesCrmWebAppCode' could be made final; it is only initialized in the declaration or constructor. 91
The method 'fillModel' has a Modified Cyclomatic Complexity of 10. 404494
The method fillModel() has an NPath complexity of 294 404494
The method 'fillModel' has a Cyclomatic Complexity of 19. 404494
The method 'fillModel' has a Standard Cyclomatic Complexity of 10. 404494
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 410
Unnecessary use of fully qualified name 'fr.paris.lutece.plugins.directory.business.EntryTypeGeolocation' due to existing import 'fr.paris.lutece.plugins.directory.business.EntryTypeGeolocation' 428
Unnecessary use of fully qualified name 'fr.paris.lutece.plugins.directory.business.EntryTypeGeolocation' due to existing import 'fr.paris.lutece.plugins.directory.business.EntryTypeGeolocation' 436
The method fillModelWithUserAttributes() has an NPath complexity of 627 568586
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 597
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 598
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 599
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 600
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 601

fr/paris/lutece/plugins/workflow/modules/notifycrm/service/notification/NotifyService.java

Violation Line
Deeply nested if..then statements are hard to read 9396

fr/paris/lutece/plugins/workflow/modules/notifycrm/service/taskinfo/NotifyCRMTaskInfoProvider.java

Violation Line
Avoid variables with short names like t 117

fr/paris/lutece/plugins/workflow/modules/notifycrm/util/constants/NotifyCRMConstants.java

Violation Line
Avoid excessively long variable names like PROPERTY_ACCEPTED_DIRECTORY_ENTRY_TYPE_CRM_WEB_APP_CODE 59

fr/paris/lutece/plugins/workflow/modules/notifycrm/util/validation/NotifyCRMConfigValidator.java

Violation Line
Document empty method 5758

fr/paris/lutece/plugins/workflow/modules/notifycrm/web/NotifyCRMTaskComponent.java

Violation Line
A high number of imports can indicate a high degree of coupling within an object. 34194
Avoid unused imports such as 'fr.paris.lutece.util.ReferenceList' 67
Avoid unused imports such as 'fr.paris.lutece.util.ReferenceList' 67
Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 126
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 152