Fork me on GitHub

Résultats PMD

Le document suivant contient les résultats de PMD 6.13.0.

Violations By Priority

Priority 1

fr/paris/lutece/plugins/workflow/modules/alertgru/business/UpdateTaskStateResourceQueueDAO.java

Rule Violation Ligne
FormalParameterNamingConventions The method parameter name 'IdResourceHistory' doesn't match '[a-z][a-zA-Z0-9]*' 137

fr/paris/lutece/plugins/workflow/modules/alertgru/business/UpdateTaskStateResourceQueueHome.java

Rule Violation Ligne
ClassWithOnlyPrivateConstructorsShouldBeFinal A class which only has private constructors should be final 47203

fr/paris/lutece/plugins/workflow/modules/alertgru/service/NotificationToHistory.java

Rule Violation Ligne
ClassNamingConventions The utility class name 'NotificationToHistory' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' 58238

fr/paris/lutece/plugins/workflow/modules/alertgru/service/ServiceConfigTaskForm.java

Rule Violation Ligne
ClassNamingConventions The utility class name 'ServiceConfigTaskForm' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' 57218

fr/paris/lutece/plugins/workflow/modules/alertgru/utils/constants/Constants.java

Rule Violation Ligne
ClassNamingConventions The utility class name 'Constants' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' 41306

fr/paris/lutece/plugins/workflow/modules/alertgru/web/AbstractAlertConfigValidator.java

Rule Violation Ligne
FieldNamingConventions The final field name '_request' doesn't match '[a-z][a-zA-Z0-9]*' 53

fr/paris/lutece/plugins/workflow/modules/alertgru/web/AlertGruTaskConfigController.java

Rule Violation Ligne
FieldNamingConventions The constant name '_taskAlertGruConfigService' doesn't match '[A-Z][A-Z_0-9]*' 90
FieldNamingConventions The constant name '_alertGruService' doesn't match '[A-Z][A-Z_0-9]*' 91
FieldNamingConventions The final field name '_task' doesn't match '[a-z][a-zA-Z0-9]*' 93
FieldNamingConventions The final field name '_request' doesn't match '[a-z][a-zA-Z0-9]*' 273
FieldNamingConventions The final field name '_listAlertConfig' doesn't match '[a-z][a-zA-Z0-9]*' 274
FieldNamingConventions The final field name '_model' doesn't match '[a-z][a-zA-Z0-9]*' 275
FieldNamingConventions The final field name '_request' doesn't match '[a-z][a-zA-Z0-9]*' 477
FieldNamingConventions The final field name '_listAlertConfig' doesn't match '[a-z][a-zA-Z0-9]*' 478
FieldNamingConventions The final field name '_providerManager' doesn't match '[a-z][a-zA-Z0-9]*' 479
FieldNamingConventions The final field name '_strAction' doesn't match '[a-z][a-zA-Z0-9]*' 480

fr/paris/lutece/plugins/workflow/modules/alertgru/web/alertconfig/impl/AgentAlertConfig.java

Rule Violation Ligne
FieldNamingConventions The final field name '_request' doesn't match '[a-z][a-zA-Z0-9]*' 56
FieldNamingConventions The final field name '_config' doesn't match '[a-z][a-zA-Z0-9]*' 57
FieldNamingConventions The final field name '_strMessage' doesn't match '[a-z][a-zA-Z0-9]*' 58
FieldNamingConventions The final field name '_strStatutText' doesn't match '[a-z][a-zA-Z0-9]*' 59

fr/paris/lutece/plugins/workflow/modules/alertgru/web/alertconfig/impl/BroadcastAlertConfig.java

Rule Violation Ligne
FieldNamingConventions The final field name '_request' doesn't match '[a-z][a-zA-Z0-9]*' 68
FieldNamingConventions The final field name '_config' doesn't match '[a-z][a-zA-Z0-9]*' 69
FieldNamingConventions The final field name '_strMailingType' doesn't match '[a-z][a-zA-Z0-9]*' 70
FieldNamingConventions The final field name '_strSenderName' doesn't match '[a-z][a-zA-Z0-9]*' 73
FieldNamingConventions The final field name '_strSubject' doesn't match '[a-z][a-zA-Z0-9]*' 74
FieldNamingConventions The final field name '_strMessage' doesn't match '[a-z][a-zA-Z0-9]*' 75
FieldNamingConventions The final field name '_strRecipientsCc' doesn't match '[a-z][a-zA-Z0-9]*' 76
FieldNamingConventions The final field name '_strRecipientsCci' doesn't match '[a-z][a-zA-Z0-9]*' 77

fr/paris/lutece/plugins/workflow/modules/alertgru/web/alertconfig/impl/EmailAlertConfig.java

Rule Violation Ligne
FieldNamingConventions The final field name '_request' doesn't match '[a-z][a-zA-Z0-9]*' 59
FieldNamingConventions The final field name '_config' doesn't match '[a-z][a-zA-Z0-9]*' 60
FieldNamingConventions The final field name '_strSubject' doesn't match '[a-z][a-zA-Z0-9]*' 61
FieldNamingConventions The final field name '_strMessage' doesn't match '[a-z][a-zA-Z0-9]*' 62
FieldNamingConventions The final field name '_strSenderName' doesn't match '[a-z][a-zA-Z0-9]*' 63
FieldNamingConventions The final field name '_strRecipientsCc' doesn't match '[a-z][a-zA-Z0-9]*' 64
FieldNamingConventions The final field name '_strRecipientsCci' doesn't match '[a-z][a-zA-Z0-9]*' 65

fr/paris/lutece/plugins/workflow/modules/alertgru/web/alertconfig/impl/GuichetAlertConfig.java

Rule Violation Ligne
FieldNamingConventions The final field name '_request' doesn't match '[a-z][a-zA-Z0-9]*' 65
FieldNamingConventions The final field name '_config' doesn't match '[a-z][a-zA-Z0-9]*' 66
FieldNamingConventions The final field name '_strMessage' doesn't match '[a-z][a-zA-Z0-9]*' 67
FieldNamingConventions The final field name '_strStatusText' doesn't match '[a-z][a-zA-Z0-9]*' 68
FieldNamingConventions The final field name '_strSenderName' doesn't match '[a-z][a-zA-Z0-9]*' 69
FieldNamingConventions The final field name '_strSubject' doesn't match '[a-z][a-zA-Z0-9]*' 70
FieldNamingConventions The final field name '_nDemandMaxStep' doesn't match '[a-z][a-zA-Z0-9]*' 71
FieldNamingConventions The final field name '_nDemandUserCurrentStep' doesn't match '[a-z][a-zA-Z0-9]*' 72

fr/paris/lutece/plugins/workflow/modules/alertgru/web/alertconfig/impl/SMSAlertConfig.java

Rule Violation Ligne
FieldNamingConventions The final field name '_request' doesn't match '[a-z][a-zA-Z0-9]*' 55
FieldNamingConventions The final field name '_config' doesn't match '[a-z][a-zA-Z0-9]*' 56
FieldNamingConventions The final field name '_strMessage' doesn't match '[a-z][a-zA-Z0-9]*' 57

Priority 2

fr/paris/lutece/plugins/workflow/modules/alertgru/service/TaskAlertService.java

Rule Violation Ligne
AvoidReassigningParameters Avoid reassigning parameters such as 'strMessage' 634

Priority 3

fr/paris/lutece/plugins/workflow/modules/alertgru/business/AlertGruTaskConfig.java

Rule Violation Ligne
ExcessivePublicCount This class has a bunch of public methods and attributes 34930
CommentRequired Header comments are required 41930
TooManyFields Too many fields 41930
CallSuperInConstructor It is a good practice to call super() in a constructor 164167
CommentRequired Public method and constructor comments are required 164167
CommentRequired Public method and constructor comments are required 881884
CommentRequired Public method and constructor comments are required 886889
CommentRequired Public method and constructor comments are required 891894
CommentRequired Public method and constructor comments are required 896899
CommentRequired Public method and constructor comments are required 901904
CommentRequired Public method and constructor comments are required 906909
CommentRequired Public method and constructor comments are required 911914
CommentRequired Public method and constructor comments are required 916919
CommentRequired Public method and constructor comments are required 921924
CommentRequired Public method and constructor comments are required 926929

fr/paris/lutece/plugins/workflow/modules/alertgru/business/AlertGruTaskConfigDAO.java

Rule Violation Ligne
CommentRequired Header comments are required 45267
ShortVariable Avoid variables with short names like i 193

fr/paris/lutece/plugins/workflow/modules/alertgru/business/IUpdateTaskStateResourceQueueDAO.java

Rule Violation Ligne
TooManyMethods This class has too many methods, consider refactoring it. 46206

fr/paris/lutece/plugins/workflow/modules/alertgru/business/UpdateTaskStateResourceQueueDAO.java

Rule Violation Ligne
TooManyMethods This class has too many methods, consider refactoring it. 51385
AppendCharacterWithChar Avoid appending characters as strings in StringBuffer.append. 228

fr/paris/lutece/plugins/workflow/modules/alertgru/business/UpdateTaskStateResourceQueueHome.java

Rule Violation Ligne
TooManyMethods This class has too many methods, consider refactoring it. 48203
CommentRequired Public method and constructor comments are required 5861
CommentRequired Public method and constructor comments are required 6367
CommentRequired Public method and constructor comments are required 103106

fr/paris/lutece/plugins/workflow/modules/alertgru/business/history/AlertGruHistoryDAO.java

Rule Violation Ligne
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 70114

fr/paris/lutece/plugins/workflow/modules/alertgru/service/AlertGruHistoryService.java

Rule Violation Ligne
CommentRequired Header comments are required 4492

fr/paris/lutece/plugins/workflow/modules/alertgru/service/AlertGruService.java

Rule Violation Ligne
ConfusingTernary Avoid if (x != y) ..; else ..; 130137

fr/paris/lutece/plugins/workflow/modules/alertgru/service/AlertGruTask.java

Rule Violation Ligne
CommentRequired Header comments are required 53145

fr/paris/lutece/plugins/workflow/modules/alertgru/service/AlertGruTaskConfigService.java

Rule Violation Ligne
CommentRequired Header comments are required 4197
UnnecessaryLocalBeforeReturn Consider simply returning the value vs storing it in local variable 'config' 71

fr/paris/lutece/plugins/workflow/modules/alertgru/service/AlertRessourceListener.java

Rule Violation Ligne
CommentRequired Header comments are required 4390
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 70
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 84

fr/paris/lutece/plugins/workflow/modules/alertgru/service/NotificationToHistory.java

Rule Violation Ligne
AppendCharacterWithChar Avoid appending characters as strings in StringBuffer.append. 160
AppendCharacterWithChar Avoid appending characters as strings in StringBuffer.append. 177

fr/paris/lutece/plugins/workflow/modules/alertgru/service/ServiceConfigTaskForm.java

Rule Violation Ligne
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 130
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 135
MissingBreakInSwitch A switch statement does not contain a break 185214

fr/paris/lutece/plugins/workflow/modules/alertgru/service/TaskAlertService.java

Rule Violation Ligne
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 34850
CommentRequired Enum comments are required 105850
UnnecessaryModifier Unnecessary modifier 'private' on constructor 'TaskAlertService()': enum constructors are implicitly private 134138
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 155
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 184
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 275
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 318
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 399
ConfusingTernary Avoid if (x != y) ..; else ..; 495512
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 652
CyclomaticComplexity The method 'buildNotificationContent(ITask, IProvider, Notification, ResourceHistory, AlertGruHistory, AlertGruTaskConfig)' has a cyclomatic complexity of 10. 667716
SimpleDateFormatNeedsLocale When instantiating a SimpleDateFormat object, specify a Locale 839

fr/paris/lutece/plugins/workflow/modules/alertgru/service/cache/AlertGruCacheService.java

Rule Violation Ligne
CallSuperInConstructor It is a good practice to call super() in a constructor 5861
NonThreadSafeSingleton Singleton is not thread safe 7073
InsufficientStringBufferDeclaration StringBuffer constructor is initialized with size 16, but has at least 25 characters appended. 138

fr/paris/lutece/plugins/workflow/modules/alertgru/utils/constants/Constants.java

Rule Violation Ligne
AvoidDuplicateLiterals The String literal "message" appears 4 times in this file; the first occurrence is on line 63 63
ShortVariable Avoid variables with short names like ID 129

fr/paris/lutece/plugins/workflow/modules/alertgru/web/AbstractAlertConfigValidator.java

Rule Violation Ligne
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 159

fr/paris/lutece/plugins/workflow/modules/alertgru/web/AlertGruTaskComponent.java

Rule Violation Ligne
CommentRequired Header comments are required 54100
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 86

fr/paris/lutece/plugins/workflow/modules/alertgru/web/AlertGruTaskConfigController.java

Rule Violation Ligne
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 341001
CommentRequired Header comments are required 751001
AccessorClassGeneration Avoid instantiation through private constructors from outside of the constructors class. 176
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 180
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 184
AccessorClassGeneration Avoid instantiation through private constructors from outside of the constructors class. 201
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 205
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 210
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 215
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 220
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 225
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 230
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 235
ConfusingTernary Avoid if (x != y) ..; else ..; 251258
TooManyMethods This class has too many methods, consider refactoring it. 272459
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 288
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 300
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 333
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 335
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 372
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 388
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 403
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 403
ConfusingTernary Avoid if (x != y) ..; else ..; 412414
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 414
ConfusingTernary Avoid if (x != y) ..; else ..; 419428
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 421
GodClass Possible God Class (WMC=61, ATFD=65, TCC=13.508%) 470999
TooManyMethods This class has too many methods, consider refactoring it. 471999
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 495
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 498
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 847
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 861
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 888
ConfusingTernary Avoid if (x != y) ..; else ..; 898905
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 900
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 904
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 915
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 923
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 926
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 927
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 930
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 938
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 951
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 963
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 984
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 986
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 986
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 992
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 992
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 996
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 996

fr/paris/lutece/plugins/workflow/modules/alertgru/web/IAlertConfig.java

Rule Violation Ligne
CommentRequired Header comments are required 3676

fr/paris/lutece/plugins/workflow/modules/alertgru/web/alertconfig/impl/AgentAlertConfig.java

Rule Violation Ligne
AccessorClassGeneration Avoid instantiation through private constructors from outside of the constructors class. 110
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 162
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 167
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 181

fr/paris/lutece/plugins/workflow/modules/alertgru/web/alertconfig/impl/BillingAccountBasedSMSAlertConfig.java

Rule Violation Ligne
DefaultPackage Use explicit scoping instead of the default package private level 47
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the _strBillingAccount field if you want a default access modifier 47
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the _strBillingGroup field if you want a default access modifier 50
DefaultPackage Use explicit scoping instead of the default package private level 50

fr/paris/lutece/plugins/workflow/modules/alertgru/web/alertconfig/impl/BroadcastAlertConfig.java

Rule Violation Ligne
AccessorClassGeneration Avoid instantiation through private constructors from outside of the constructors class. 143
CyclomaticComplexity The method 'validateFieldsWithoutMarker()' has a cyclomatic complexity of 11. 203239
NPathComplexity The method 'validateFieldsWithoutMarker()' has an NPath complexity of 288 203239
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 207
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 208
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 208
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 213
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 213
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 218
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 218
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 223
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 228
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 233
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 247
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 247

fr/paris/lutece/plugins/workflow/modules/alertgru/web/alertconfig/impl/EmailAlertConfig.java

Rule Violation Ligne
AccessorClassGeneration Avoid instantiation through private constructors from outside of the constructors class. 147
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 180
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 185
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 190
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 204
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 204

fr/paris/lutece/plugins/workflow/modules/alertgru/web/alertconfig/impl/GuichetAlertConfig.java

Rule Violation Ligne
AccessorClassGeneration Avoid instantiation through private constructors from outside of the constructors class. 127
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 189
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 194
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 199
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 204
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 218
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 218

fr/paris/lutece/plugins/workflow/modules/alertgru/web/alertconfig/impl/SMSAlertConfig.java

Rule Violation Ligne
AccessorClassGeneration Avoid instantiation through private constructors from outside of the constructors class. 107
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 156
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 170

Priority 4

fr/paris/lutece/plugins/workflow/modules/alertgru/business/UpdateTaskStateResourceQueue.java

Rule Violation Ligne
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 209212

fr/paris/lutece/plugins/workflow/modules/alertgru/web/AlertGruTaskConfigController.java

Rule Violation Ligne
ShortClassName Avoid short class names like View 271459

Fichiers

fr/paris/lutece/plugins/workflow/modules/alertgru/business/AlertGruTaskConfig.java

Rule Violation Priority Ligne
ExcessivePublicCount This class has a bunch of public methods and attributes 3 34930
CommentRequired Header comments are required 3 41930
TooManyFields Too many fields 3 41930
CallSuperInConstructor It is a good practice to call super() in a constructor 3 164167
CommentRequired Public method and constructor comments are required 3 164167
CommentRequired Public method and constructor comments are required 3 881884
CommentRequired Public method and constructor comments are required 3 886889
CommentRequired Public method and constructor comments are required 3 891894
CommentRequired Public method and constructor comments are required 3 896899
CommentRequired Public method and constructor comments are required 3 901904
CommentRequired Public method and constructor comments are required 3 906909
CommentRequired Public method and constructor comments are required 3 911914
CommentRequired Public method and constructor comments are required 3 916919
CommentRequired Public method and constructor comments are required 3 921924
CommentRequired Public method and constructor comments are required 3 926929

fr/paris/lutece/plugins/workflow/modules/alertgru/business/AlertGruTaskConfigDAO.java

Rule Violation Priority Ligne
CommentRequired Header comments are required 3 45267
ShortVariable Avoid variables with short names like i 3 193

fr/paris/lutece/plugins/workflow/modules/alertgru/business/IUpdateTaskStateResourceQueueDAO.java

Rule Violation Priority Ligne
TooManyMethods This class has too many methods, consider refactoring it. 3 46206

fr/paris/lutece/plugins/workflow/modules/alertgru/business/UpdateTaskStateResourceQueue.java

Rule Violation Priority Ligne
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 4 209212

fr/paris/lutece/plugins/workflow/modules/alertgru/business/UpdateTaskStateResourceQueueDAO.java

Rule Violation Priority Ligne
TooManyMethods This class has too many methods, consider refactoring it. 3 51385
FormalParameterNamingConventions The method parameter name 'IdResourceHistory' doesn't match '[a-z][a-zA-Z0-9]*' 1 137
AppendCharacterWithChar Avoid appending characters as strings in StringBuffer.append. 3 228

fr/paris/lutece/plugins/workflow/modules/alertgru/business/UpdateTaskStateResourceQueueHome.java

Rule Violation Priority Ligne
ClassWithOnlyPrivateConstructorsShouldBeFinal A class which only has private constructors should be final 1 47203
TooManyMethods This class has too many methods, consider refactoring it. 3 48203
CommentRequired Public method and constructor comments are required 3 5861
CommentRequired Public method and constructor comments are required 3 6367
CommentRequired Public method and constructor comments are required 3 103106

fr/paris/lutece/plugins/workflow/modules/alertgru/business/history/AlertGruHistoryDAO.java

Rule Violation Priority Ligne
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 3 70114

fr/paris/lutece/plugins/workflow/modules/alertgru/service/AlertGruHistoryService.java

Rule Violation Priority Ligne
CommentRequired Header comments are required 3 4492

fr/paris/lutece/plugins/workflow/modules/alertgru/service/AlertGruService.java

Rule Violation Priority Ligne
ConfusingTernary Avoid if (x != y) ..; else ..; 3 130137

fr/paris/lutece/plugins/workflow/modules/alertgru/service/AlertGruTask.java

Rule Violation Priority Ligne
CommentRequired Header comments are required 3 53145

fr/paris/lutece/plugins/workflow/modules/alertgru/service/AlertGruTaskConfigService.java

Rule Violation Priority Ligne
CommentRequired Header comments are required 3 4197
UnnecessaryLocalBeforeReturn Consider simply returning the value vs storing it in local variable 'config' 3 71

fr/paris/lutece/plugins/workflow/modules/alertgru/service/AlertRessourceListener.java

Rule Violation Priority Ligne
CommentRequired Header comments are required 3 4390
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 70
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 84

fr/paris/lutece/plugins/workflow/modules/alertgru/service/NotificationToHistory.java

Rule Violation Priority Ligne
ClassNamingConventions The utility class name 'NotificationToHistory' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' 1 58238
AppendCharacterWithChar Avoid appending characters as strings in StringBuffer.append. 3 160
AppendCharacterWithChar Avoid appending characters as strings in StringBuffer.append. 3 177

fr/paris/lutece/plugins/workflow/modules/alertgru/service/ServiceConfigTaskForm.java

Rule Violation Priority Ligne
ClassNamingConventions The utility class name 'ServiceConfigTaskForm' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' 1 57218
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 3 130
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 3 135
MissingBreakInSwitch A switch statement does not contain a break 3 185214

fr/paris/lutece/plugins/workflow/modules/alertgru/service/TaskAlertService.java

Rule Violation Priority Ligne
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 3 34850
CommentRequired Enum comments are required 3 105850
UnnecessaryModifier Unnecessary modifier 'private' on constructor 'TaskAlertService()': enum constructors are implicitly private 3 134138
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 155
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 184
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 275
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 318
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 399
ConfusingTernary Avoid if (x != y) ..; else ..; 3 495512
AvoidReassigningParameters Avoid reassigning parameters such as 'strMessage' 2 634
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 652
CyclomaticComplexity The method 'buildNotificationContent(ITask, IProvider, Notification, ResourceHistory, AlertGruHistory, AlertGruTaskConfig)' has a cyclomatic complexity of 10. 3 667716
SimpleDateFormatNeedsLocale When instantiating a SimpleDateFormat object, specify a Locale 3 839

fr/paris/lutece/plugins/workflow/modules/alertgru/service/cache/AlertGruCacheService.java

Rule Violation Priority Ligne
CallSuperInConstructor It is a good practice to call super() in a constructor 3 5861
NonThreadSafeSingleton Singleton is not thread safe 3 7073
InsufficientStringBufferDeclaration StringBuffer constructor is initialized with size 16, but has at least 25 characters appended. 3 138

fr/paris/lutece/plugins/workflow/modules/alertgru/utils/constants/Constants.java

Rule Violation Priority Ligne
ClassNamingConventions The utility class name 'Constants' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' 1 41306
AvoidDuplicateLiterals The String literal "message" appears 4 times in this file; the first occurrence is on line 63 3 63
ShortVariable Avoid variables with short names like ID 3 129

fr/paris/lutece/plugins/workflow/modules/alertgru/web/AbstractAlertConfigValidator.java

Rule Violation Priority Ligne
FieldNamingConventions The final field name '_request' doesn't match '[a-z][a-zA-Z0-9]*' 1 53
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 159

fr/paris/lutece/plugins/workflow/modules/alertgru/web/AlertGruTaskComponent.java

Rule Violation Priority Ligne
CommentRequired Header comments are required 3 54100
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 86

fr/paris/lutece/plugins/workflow/modules/alertgru/web/AlertGruTaskConfigController.java

Rule Violation Priority Ligne
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 3 341001
CommentRequired Header comments are required 3 751001
FieldNamingConventions The constant name '_taskAlertGruConfigService' doesn't match '[A-Z][A-Z_0-9]*' 1 90
FieldNamingConventions The constant name '_alertGruService' doesn't match '[A-Z][A-Z_0-9]*' 1 91
FieldNamingConventions The final field name '_task' doesn't match '[a-z][a-zA-Z0-9]*' 1 93
AccessorClassGeneration Avoid instantiation through private constructors from outside of the constructors class. 3 176
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 3 180
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 3 184
AccessorClassGeneration Avoid instantiation through private constructors from outside of the constructors class. 3 201
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 3 205
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 3 210
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 3 215
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 3 220
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 3 225
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 3 230
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 3 235
ConfusingTernary Avoid if (x != y) ..; else ..; 3 251258
ShortClassName Avoid short class names like View 4 271459
TooManyMethods This class has too many methods, consider refactoring it. 3 272459
FieldNamingConventions The final field name '_request' doesn't match '[a-z][a-zA-Z0-9]*' 1 273
FieldNamingConventions The final field name '_listAlertConfig' doesn't match '[a-z][a-zA-Z0-9]*' 1 274
FieldNamingConventions The final field name '_model' doesn't match '[a-z][a-zA-Z0-9]*' 1 275
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 3 288
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 3 300
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 3 333
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 3 335
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 3 372
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 3 388
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 3 403
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 3 403
ConfusingTernary Avoid if (x != y) ..; else ..; 3 412414
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 3 414
ConfusingTernary Avoid if (x != y) ..; else ..; 3 419428
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 3 421
GodClass Possible God Class (WMC=61, ATFD=65, TCC=13.508%) 3 470999
TooManyMethods This class has too many methods, consider refactoring it. 3 471999
FieldNamingConventions The final field name '_request' doesn't match '[a-z][a-zA-Z0-9]*' 1 477
FieldNamingConventions The final field name '_listAlertConfig' doesn't match '[a-z][a-zA-Z0-9]*' 1 478
FieldNamingConventions The final field name '_providerManager' doesn't match '[a-z][a-zA-Z0-9]*' 1 479
FieldNamingConventions The final field name '_strAction' doesn't match '[a-z][a-zA-Z0-9]*' 1 480
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 3 495
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 3 498
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 3 847
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 861
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 3 888
ConfusingTernary Avoid if (x != y) ..; else ..; 3 898905
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 3 900
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 3 904
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 3 915
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 3 923
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 3 926
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 3 927
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 3 930
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 3 938
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 3 951
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 3 963
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 3 984
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 3 986
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 3 986
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 3 992
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 3 992
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 3 996
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 3 996

fr/paris/lutece/plugins/workflow/modules/alertgru/web/IAlertConfig.java

Rule Violation Priority Ligne
CommentRequired Header comments are required 3 3676

fr/paris/lutece/plugins/workflow/modules/alertgru/web/alertconfig/impl/AgentAlertConfig.java

Rule Violation Priority Ligne
FieldNamingConventions The final field name '_request' doesn't match '[a-z][a-zA-Z0-9]*' 1 56
FieldNamingConventions The final field name '_config' doesn't match '[a-z][a-zA-Z0-9]*' 1 57
FieldNamingConventions The final field name '_strMessage' doesn't match '[a-z][a-zA-Z0-9]*' 1 58
FieldNamingConventions The final field name '_strStatutText' doesn't match '[a-z][a-zA-Z0-9]*' 1 59
AccessorClassGeneration Avoid instantiation through private constructors from outside of the constructors class. 3 110
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 3 162
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 3 167
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 3 181

fr/paris/lutece/plugins/workflow/modules/alertgru/web/alertconfig/impl/BillingAccountBasedSMSAlertConfig.java

Rule Violation Priority Ligne
DefaultPackage Use explicit scoping instead of the default package private level 3 47
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the _strBillingAccount field if you want a default access modifier 3 47
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the _strBillingGroup field if you want a default access modifier 3 50
DefaultPackage Use explicit scoping instead of the default package private level 3 50

fr/paris/lutece/plugins/workflow/modules/alertgru/web/alertconfig/impl/BroadcastAlertConfig.java

Rule Violation Priority Ligne
FieldNamingConventions The final field name '_request' doesn't match '[a-z][a-zA-Z0-9]*' 1 68
FieldNamingConventions The final field name '_config' doesn't match '[a-z][a-zA-Z0-9]*' 1 69
FieldNamingConventions The final field name '_strMailingType' doesn't match '[a-z][a-zA-Z0-9]*' 1 70
FieldNamingConventions The final field name '_strSenderName' doesn't match '[a-z][a-zA-Z0-9]*' 1 73
FieldNamingConventions The final field name '_strSubject' doesn't match '[a-z][a-zA-Z0-9]*' 1 74
FieldNamingConventions The final field name '_strMessage' doesn't match '[a-z][a-zA-Z0-9]*' 1 75
FieldNamingConventions The final field name '_strRecipientsCc' doesn't match '[a-z][a-zA-Z0-9]*' 1 76
FieldNamingConventions The final field name '_strRecipientsCci' doesn't match '[a-z][a-zA-Z0-9]*' 1 77
AccessorClassGeneration Avoid instantiation through private constructors from outside of the constructors class. 3 143
CyclomaticComplexity The method 'validateFieldsWithoutMarker()' has a cyclomatic complexity of 11. 3 203239
NPathComplexity The method 'validateFieldsWithoutMarker()' has an NPath complexity of 288 3 203239
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 3 207
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 3 208
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 3 208
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 3 213
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 3 213
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 3 218
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 3 218
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 3 223
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 3 228
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 3 233
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 3 247
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 3 247

fr/paris/lutece/plugins/workflow/modules/alertgru/web/alertconfig/impl/EmailAlertConfig.java

Rule Violation Priority Ligne
FieldNamingConventions The final field name '_request' doesn't match '[a-z][a-zA-Z0-9]*' 1 59
FieldNamingConventions The final field name '_config' doesn't match '[a-z][a-zA-Z0-9]*' 1 60
FieldNamingConventions The final field name '_strSubject' doesn't match '[a-z][a-zA-Z0-9]*' 1 61
FieldNamingConventions The final field name '_strMessage' doesn't match '[a-z][a-zA-Z0-9]*' 1 62
FieldNamingConventions The final field name '_strSenderName' doesn't match '[a-z][a-zA-Z0-9]*' 1 63
FieldNamingConventions The final field name '_strRecipientsCc' doesn't match '[a-z][a-zA-Z0-9]*' 1 64
FieldNamingConventions The final field name '_strRecipientsCci' doesn't match '[a-z][a-zA-Z0-9]*' 1 65
AccessorClassGeneration Avoid instantiation through private constructors from outside of the constructors class. 3 147
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 3 180
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 3 185
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 3 190
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 3 204
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 3 204

fr/paris/lutece/plugins/workflow/modules/alertgru/web/alertconfig/impl/GuichetAlertConfig.java

Rule Violation Priority Ligne
FieldNamingConventions The final field name '_request' doesn't match '[a-z][a-zA-Z0-9]*' 1 65
FieldNamingConventions The final field name '_config' doesn't match '[a-z][a-zA-Z0-9]*' 1 66
FieldNamingConventions The final field name '_strMessage' doesn't match '[a-z][a-zA-Z0-9]*' 1 67
FieldNamingConventions The final field name '_strStatusText' doesn't match '[a-z][a-zA-Z0-9]*' 1 68
FieldNamingConventions The final field name '_strSenderName' doesn't match '[a-z][a-zA-Z0-9]*' 1 69
FieldNamingConventions The final field name '_strSubject' doesn't match '[a-z][a-zA-Z0-9]*' 1 70
FieldNamingConventions The final field name '_nDemandMaxStep' doesn't match '[a-z][a-zA-Z0-9]*' 1 71
FieldNamingConventions The final field name '_nDemandUserCurrentStep' doesn't match '[a-z][a-zA-Z0-9]*' 1 72
AccessorClassGeneration Avoid instantiation through private constructors from outside of the constructors class. 3 127
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 3 189
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 3 194
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 3 199
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 3 204
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 3 218
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 3 218

fr/paris/lutece/plugins/workflow/modules/alertgru/web/alertconfig/impl/SMSAlertConfig.java

Rule Violation Priority Ligne
FieldNamingConventions The final field name '_request' doesn't match '[a-z][a-zA-Z0-9]*' 1 55
FieldNamingConventions The final field name '_config' doesn't match '[a-z][a-zA-Z0-9]*' 1 56
FieldNamingConventions The final field name '_strMessage' doesn't match '[a-z][a-zA-Z0-9]*' 1 57
AccessorClassGeneration Avoid instantiation through private constructors from outside of the constructors class. 3 107
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 3 156
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 3 170