The following document contains the results of PMD 6.13.0.
| Rule | Violation | Line |
|---|---|---|
| FormalParameterNamingConventions | The method parameter name 'IdResourceHistory' doesn't match '[a-z][a-zA-Z0-9]*' | 137 |
| Rule | Violation | Line |
|---|---|---|
| ClassWithOnlyPrivateConstructorsShouldBeFinal | A class which only has private constructors should be final | 47–203 |
| Rule | Violation | Line |
|---|---|---|
| ClassNamingConventions | The utility class name 'NotificationToHistory' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' | 58–238 |
| Rule | Violation | Line |
|---|---|---|
| ClassNamingConventions | The utility class name 'ServiceConfigTaskForm' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' | 57–218 |
| Rule | Violation | Line |
|---|---|---|
| ClassNamingConventions | The utility class name 'Constants' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' | 41–306 |
| Rule | Violation | Line |
|---|---|---|
| FieldNamingConventions | The final field name '_request' doesn't match '[a-z][a-zA-Z0-9]*' | 53 |
| Rule | Violation | Line |
|---|---|---|
| FieldNamingConventions | The constant name '_taskAlertGruConfigService' doesn't match '[A-Z][A-Z_0-9]*' | 90 |
| FieldNamingConventions | The constant name '_alertGruService' doesn't match '[A-Z][A-Z_0-9]*' | 91 |
| FieldNamingConventions | The final field name '_task' doesn't match '[a-z][a-zA-Z0-9]*' | 93 |
| FieldNamingConventions | The final field name '_request' doesn't match '[a-z][a-zA-Z0-9]*' | 273 |
| FieldNamingConventions | The final field name '_listAlertConfig' doesn't match '[a-z][a-zA-Z0-9]*' | 274 |
| FieldNamingConventions | The final field name '_model' doesn't match '[a-z][a-zA-Z0-9]*' | 275 |
| FieldNamingConventions | The final field name '_request' doesn't match '[a-z][a-zA-Z0-9]*' | 477 |
| FieldNamingConventions | The final field name '_listAlertConfig' doesn't match '[a-z][a-zA-Z0-9]*' | 478 |
| FieldNamingConventions | The final field name '_providerManager' doesn't match '[a-z][a-zA-Z0-9]*' | 479 |
| FieldNamingConventions | The final field name '_strAction' doesn't match '[a-z][a-zA-Z0-9]*' | 480 |
| Rule | Violation | Line |
|---|---|---|
| FieldNamingConventions | The final field name '_request' doesn't match '[a-z][a-zA-Z0-9]*' | 56 |
| FieldNamingConventions | The final field name '_config' doesn't match '[a-z][a-zA-Z0-9]*' | 57 |
| FieldNamingConventions | The final field name '_strMessage' doesn't match '[a-z][a-zA-Z0-9]*' | 58 |
| FieldNamingConventions | The final field name '_strStatutText' doesn't match '[a-z][a-zA-Z0-9]*' | 59 |
| Rule | Violation | Line |
|---|---|---|
| FieldNamingConventions | The final field name '_request' doesn't match '[a-z][a-zA-Z0-9]*' | 68 |
| FieldNamingConventions | The final field name '_config' doesn't match '[a-z][a-zA-Z0-9]*' | 69 |
| FieldNamingConventions | The final field name '_strMailingType' doesn't match '[a-z][a-zA-Z0-9]*' | 70 |
| FieldNamingConventions | The final field name '_strSenderName' doesn't match '[a-z][a-zA-Z0-9]*' | 73 |
| FieldNamingConventions | The final field name '_strSubject' doesn't match '[a-z][a-zA-Z0-9]*' | 74 |
| FieldNamingConventions | The final field name '_strMessage' doesn't match '[a-z][a-zA-Z0-9]*' | 75 |
| FieldNamingConventions | The final field name '_strRecipientsCc' doesn't match '[a-z][a-zA-Z0-9]*' | 76 |
| FieldNamingConventions | The final field name '_strRecipientsCci' doesn't match '[a-z][a-zA-Z0-9]*' | 77 |
| Rule | Violation | Line |
|---|---|---|
| FieldNamingConventions | The final field name '_request' doesn't match '[a-z][a-zA-Z0-9]*' | 59 |
| FieldNamingConventions | The final field name '_config' doesn't match '[a-z][a-zA-Z0-9]*' | 60 |
| FieldNamingConventions | The final field name '_strSubject' doesn't match '[a-z][a-zA-Z0-9]*' | 61 |
| FieldNamingConventions | The final field name '_strMessage' doesn't match '[a-z][a-zA-Z0-9]*' | 62 |
| FieldNamingConventions | The final field name '_strSenderName' doesn't match '[a-z][a-zA-Z0-9]*' | 63 |
| FieldNamingConventions | The final field name '_strRecipientsCc' doesn't match '[a-z][a-zA-Z0-9]*' | 64 |
| FieldNamingConventions | The final field name '_strRecipientsCci' doesn't match '[a-z][a-zA-Z0-9]*' | 65 |
| Rule | Violation | Line |
|---|---|---|
| FieldNamingConventions | The final field name '_request' doesn't match '[a-z][a-zA-Z0-9]*' | 65 |
| FieldNamingConventions | The final field name '_config' doesn't match '[a-z][a-zA-Z0-9]*' | 66 |
| FieldNamingConventions | The final field name '_strMessage' doesn't match '[a-z][a-zA-Z0-9]*' | 67 |
| FieldNamingConventions | The final field name '_strStatusText' doesn't match '[a-z][a-zA-Z0-9]*' | 68 |
| FieldNamingConventions | The final field name '_strSenderName' doesn't match '[a-z][a-zA-Z0-9]*' | 69 |
| FieldNamingConventions | The final field name '_strSubject' doesn't match '[a-z][a-zA-Z0-9]*' | 70 |
| FieldNamingConventions | The final field name '_nDemandMaxStep' doesn't match '[a-z][a-zA-Z0-9]*' | 71 |
| FieldNamingConventions | The final field name '_nDemandUserCurrentStep' doesn't match '[a-z][a-zA-Z0-9]*' | 72 |
| Rule | Violation | Line |
|---|---|---|
| FieldNamingConventions | The final field name '_request' doesn't match '[a-z][a-zA-Z0-9]*' | 55 |
| FieldNamingConventions | The final field name '_config' doesn't match '[a-z][a-zA-Z0-9]*' | 56 |
| FieldNamingConventions | The final field name '_strMessage' doesn't match '[a-z][a-zA-Z0-9]*' | 57 |
| Rule | Violation | Line |
|---|---|---|
| AvoidReassigningParameters | Avoid reassigning parameters such as 'strMessage' | 634 |
| Rule | Violation | Line |
|---|---|---|
| ExcessivePublicCount | This class has a bunch of public methods and attributes | 34–930 |
| CommentRequired | Header comments are required | 41–930 |
| TooManyFields | Too many fields | 41–930 |
| CallSuperInConstructor | It is a good practice to call super() in a constructor | 164–167 |
| CommentRequired | Public method and constructor comments are required | 164–167 |
| CommentRequired | Public method and constructor comments are required | 881–884 |
| CommentRequired | Public method and constructor comments are required | 886–889 |
| CommentRequired | Public method and constructor comments are required | 891–894 |
| CommentRequired | Public method and constructor comments are required | 896–899 |
| CommentRequired | Public method and constructor comments are required | 901–904 |
| CommentRequired | Public method and constructor comments are required | 906–909 |
| CommentRequired | Public method and constructor comments are required | 911–914 |
| CommentRequired | Public method and constructor comments are required | 916–919 |
| CommentRequired | Public method and constructor comments are required | 921–924 |
| CommentRequired | Public method and constructor comments are required | 926–929 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 45–267 |
| ShortVariable | Avoid variables with short names like i | 193 |
| Rule | Violation | Line |
|---|---|---|
| TooManyMethods | This class has too many methods, consider refactoring it. | 46–206 |
| Rule | Violation | Line |
|---|---|---|
| TooManyMethods | This class has too many methods, consider refactoring it. | 51–385 |
| AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 228 |
| Rule | Violation | Line |
|---|---|---|
| TooManyMethods | This class has too many methods, consider refactoring it. | 48–203 |
| CommentRequired | Public method and constructor comments are required | 58–61 |
| CommentRequired | Public method and constructor comments are required | 63–67 |
| CommentRequired | Public method and constructor comments are required | 103–106 |
| Rule | Violation | Line |
|---|---|---|
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 70–114 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 44–92 |
| Rule | Violation | Line |
|---|---|---|
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 130–137 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 53–145 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 41–97 |
| UnnecessaryLocalBeforeReturn | Consider simply returning the value vs storing it in local variable 'config' | 71 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 43–90 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 70 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 84 |
| Rule | Violation | Line |
|---|---|---|
| AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 160 |
| AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 177 |
| Rule | Violation | Line |
|---|---|---|
| AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 130 |
| AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 135 |
| MissingBreakInSwitch | A switch statement does not contain a break | 185–214 |
| Rule | Violation | Line |
|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 34–850 |
| CommentRequired | Enum comments are required | 105–850 |
| UnnecessaryModifier | Unnecessary modifier 'private' on constructor 'TaskAlertService()': enum constructors are implicitly private | 134–138 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 155 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 184 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 275 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 318 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 399 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 495–512 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 652 |
| CyclomaticComplexity | The method 'buildNotificationContent(ITask, IProvider, Notification, ResourceHistory, AlertGruHistory, AlertGruTaskConfig)' has a cyclomatic complexity of 10. | 667–716 |
| SimpleDateFormatNeedsLocale | When instantiating a SimpleDateFormat object, specify a Locale | 839 |
| Rule | Violation | Line |
|---|---|---|
| CallSuperInConstructor | It is a good practice to call super() in a constructor | 58–61 |
| NonThreadSafeSingleton | Singleton is not thread safe | 70–73 |
| InsufficientStringBufferDeclaration | StringBuffer constructor is initialized with size 16, but has at least 25 characters appended. | 138 |
| Rule | Violation | Line |
|---|---|---|
| AvoidDuplicateLiterals | The String literal "message" appears 4 times in this file; the first occurrence is on line 63 | 63 |
| ShortVariable | Avoid variables with short names like ID | 129 |
| Rule | Violation | Line |
|---|---|---|
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 159 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 54–100 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 86 |
| Rule | Violation | Line |
|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 34–1001 |
| CommentRequired | Header comments are required | 75–1001 |
| AccessorClassGeneration | Avoid instantiation through private constructors from outside of the constructors class. | 176 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 180 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 184 |
| AccessorClassGeneration | Avoid instantiation through private constructors from outside of the constructors class. | 201 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 205 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 210 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 215 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 220 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 225 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 230 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 235 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 251–258 |
| TooManyMethods | This class has too many methods, consider refactoring it. | 272–459 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 288 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 300 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 333 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 335 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 372 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 388 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 403 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 403 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 412–414 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 414 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 419–428 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 421 |
| GodClass | Possible God Class (WMC=61, ATFD=65, TCC=13.508%) | 470–999 |
| TooManyMethods | This class has too many methods, consider refactoring it. | 471–999 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 495 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 498 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 847 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 861 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 888 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 898–905 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 900 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 904 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 915 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 923 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 926 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 927 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 930 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 938 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 951 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 963 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 984 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 986 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 986 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 992 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 992 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 996 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 996 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 36–76 |
| Rule | Violation | Line |
|---|---|---|
| AccessorClassGeneration | Avoid instantiation through private constructors from outside of the constructors class. | 110 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 162 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 167 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 181 |
| Rule | Violation | Line |
|---|---|---|
| DefaultPackage | Use explicit scoping instead of the default package private level | 47 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the _strBillingAccount field if you want a default access modifier | 47 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the _strBillingGroup field if you want a default access modifier | 50 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 50 |
| Rule | Violation | Line |
|---|---|---|
| AccessorClassGeneration | Avoid instantiation through private constructors from outside of the constructors class. | 143 |
| CyclomaticComplexity | The method 'validateFieldsWithoutMarker()' has a cyclomatic complexity of 11. | 203–239 |
| NPathComplexity | The method 'validateFieldsWithoutMarker()' has an NPath complexity of 288 | 203–239 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 207 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 208 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 208 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 213 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 213 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 218 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 218 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 223 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 228 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 233 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 247 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 247 |
| Rule | Violation | Line |
|---|---|---|
| AccessorClassGeneration | Avoid instantiation through private constructors from outside of the constructors class. | 147 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 180 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 185 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 190 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 204 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 204 |
| Rule | Violation | Line |
|---|---|---|
| AccessorClassGeneration | Avoid instantiation through private constructors from outside of the constructors class. | 127 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 189 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 194 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 199 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 204 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 218 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 218 |
| Rule | Violation | Line |
|---|---|---|
| AccessorClassGeneration | Avoid instantiation through private constructors from outside of the constructors class. | 107 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 156 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 170 |
| Rule | Violation | Line |
|---|---|---|
| BooleanGetMethodName | A getX() method which returns a boolean should be named isX() | 209–212 |
| Rule | Violation | Line |
|---|---|---|
| ShortClassName | Avoid short class names like View | 271–459 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ExcessivePublicCount | This class has a bunch of public methods and attributes | 3 | 34–930 |
| CommentRequired | Header comments are required | 3 | 41–930 |
| TooManyFields | Too many fields | 3 | 41–930 |
| CallSuperInConstructor | It is a good practice to call super() in a constructor | 3 | 164–167 |
| CommentRequired | Public method and constructor comments are required | 3 | 164–167 |
| CommentRequired | Public method and constructor comments are required | 3 | 881–884 |
| CommentRequired | Public method and constructor comments are required | 3 | 886–889 |
| CommentRequired | Public method and constructor comments are required | 3 | 891–894 |
| CommentRequired | Public method and constructor comments are required | 3 | 896–899 |
| CommentRequired | Public method and constructor comments are required | 3 | 901–904 |
| CommentRequired | Public method and constructor comments are required | 3 | 906–909 |
| CommentRequired | Public method and constructor comments are required | 3 | 911–914 |
| CommentRequired | Public method and constructor comments are required | 3 | 916–919 |
| CommentRequired | Public method and constructor comments are required | 3 | 921–924 |
| CommentRequired | Public method and constructor comments are required | 3 | 926–929 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 45–267 |
| ShortVariable | Avoid variables with short names like i | 3 | 193 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| TooManyMethods | This class has too many methods, consider refactoring it. | 3 | 46–206 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| BooleanGetMethodName | A getX() method which returns a boolean should be named isX() | 4 | 209–212 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| TooManyMethods | This class has too many methods, consider refactoring it. | 3 | 51–385 |
| FormalParameterNamingConventions | The method parameter name 'IdResourceHistory' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 137 |
| AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 3 | 228 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ClassWithOnlyPrivateConstructorsShouldBeFinal | A class which only has private constructors should be final | 1 | 47–203 |
| TooManyMethods | This class has too many methods, consider refactoring it. | 3 | 48–203 |
| CommentRequired | Public method and constructor comments are required | 3 | 58–61 |
| CommentRequired | Public method and constructor comments are required | 3 | 63–67 |
| CommentRequired | Public method and constructor comments are required | 3 | 103–106 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 3 | 70–114 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 44–92 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 130–137 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 53–145 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 41–97 |
| UnnecessaryLocalBeforeReturn | Consider simply returning the value vs storing it in local variable 'config' | 3 | 71 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 43–90 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 70 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 84 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ClassNamingConventions | The utility class name 'NotificationToHistory' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' | 1 | 58–238 |
| AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 3 | 160 |
| AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 3 | 177 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ClassNamingConventions | The utility class name 'ServiceConfigTaskForm' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' | 1 | 57–218 |
| AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 3 | 130 |
| AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 3 | 135 |
| MissingBreakInSwitch | A switch statement does not contain a break | 3 | 185–214 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 3 | 34–850 |
| CommentRequired | Enum comments are required | 3 | 105–850 |
| UnnecessaryModifier | Unnecessary modifier 'private' on constructor 'TaskAlertService()': enum constructors are implicitly private | 3 | 134–138 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 155 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 184 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 275 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 318 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 399 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 495–512 |
| AvoidReassigningParameters | Avoid reassigning parameters such as 'strMessage' | 2 | 634 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 652 |
| CyclomaticComplexity | The method 'buildNotificationContent(ITask, IProvider, Notification, ResourceHistory, AlertGruHistory, AlertGruTaskConfig)' has a cyclomatic complexity of 10. | 3 | 667–716 |
| SimpleDateFormatNeedsLocale | When instantiating a SimpleDateFormat object, specify a Locale | 3 | 839 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CallSuperInConstructor | It is a good practice to call super() in a constructor | 3 | 58–61 |
| NonThreadSafeSingleton | Singleton is not thread safe | 3 | 70–73 |
| InsufficientStringBufferDeclaration | StringBuffer constructor is initialized with size 16, but has at least 25 characters appended. | 3 | 138 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ClassNamingConventions | The utility class name 'Constants' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' | 1 | 41–306 |
| AvoidDuplicateLiterals | The String literal "message" appears 4 times in this file; the first occurrence is on line 63 | 3 | 63 |
| ShortVariable | Avoid variables with short names like ID | 3 | 129 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| FieldNamingConventions | The final field name '_request' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 53 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 159 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 54–100 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 86 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 3 | 34–1001 |
| CommentRequired | Header comments are required | 3 | 75–1001 |
| FieldNamingConventions | The constant name '_taskAlertGruConfigService' doesn't match '[A-Z][A-Z_0-9]*' | 1 | 90 |
| FieldNamingConventions | The constant name '_alertGruService' doesn't match '[A-Z][A-Z_0-9]*' | 1 | 91 |
| FieldNamingConventions | The final field name '_task' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 93 |
| AccessorClassGeneration | Avoid instantiation through private constructors from outside of the constructors class. | 3 | 176 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 3 | 180 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 3 | 184 |
| AccessorClassGeneration | Avoid instantiation through private constructors from outside of the constructors class. | 3 | 201 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 3 | 205 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 3 | 210 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 3 | 215 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 3 | 220 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 3 | 225 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 3 | 230 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 3 | 235 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 251–258 |
| ShortClassName | Avoid short class names like View | 4 | 271–459 |
| TooManyMethods | This class has too many methods, consider refactoring it. | 3 | 272–459 |
| FieldNamingConventions | The final field name '_request' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 273 |
| FieldNamingConventions | The final field name '_listAlertConfig' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 274 |
| FieldNamingConventions | The final field name '_model' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 275 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 3 | 288 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 3 | 300 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 3 | 333 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 3 | 335 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 3 | 372 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 3 | 388 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 3 | 403 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 3 | 403 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 412–414 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 3 | 414 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 419–428 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 3 | 421 |
| GodClass | Possible God Class (WMC=61, ATFD=65, TCC=13.508%) | 3 | 470–999 |
| TooManyMethods | This class has too many methods, consider refactoring it. | 3 | 471–999 |
| FieldNamingConventions | The final field name '_request' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 477 |
| FieldNamingConventions | The final field name '_listAlertConfig' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 478 |
| FieldNamingConventions | The final field name '_providerManager' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 479 |
| FieldNamingConventions | The final field name '_strAction' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 480 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 3 | 495 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 3 | 498 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 3 | 847 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 861 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 3 | 888 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 898–905 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 3 | 900 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 3 | 904 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 3 | 915 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 3 | 923 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 3 | 926 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 3 | 927 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 3 | 930 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 3 | 938 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 3 | 951 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 3 | 963 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 3 | 984 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 3 | 986 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 3 | 986 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 3 | 992 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 3 | 992 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 3 | 996 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 3 | 996 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 36–76 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| FieldNamingConventions | The final field name '_request' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 56 |
| FieldNamingConventions | The final field name '_config' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 57 |
| FieldNamingConventions | The final field name '_strMessage' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 58 |
| FieldNamingConventions | The final field name '_strStatutText' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 59 |
| AccessorClassGeneration | Avoid instantiation through private constructors from outside of the constructors class. | 3 | 110 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 3 | 162 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 3 | 167 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 3 | 181 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| DefaultPackage | Use explicit scoping instead of the default package private level | 3 | 47 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the _strBillingAccount field if you want a default access modifier | 3 | 47 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the _strBillingGroup field if you want a default access modifier | 3 | 50 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 3 | 50 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| FieldNamingConventions | The final field name '_request' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 68 |
| FieldNamingConventions | The final field name '_config' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 69 |
| FieldNamingConventions | The final field name '_strMailingType' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 70 |
| FieldNamingConventions | The final field name '_strSenderName' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 73 |
| FieldNamingConventions | The final field name '_strSubject' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 74 |
| FieldNamingConventions | The final field name '_strMessage' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 75 |
| FieldNamingConventions | The final field name '_strRecipientsCc' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 76 |
| FieldNamingConventions | The final field name '_strRecipientsCci' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 77 |
| AccessorClassGeneration | Avoid instantiation through private constructors from outside of the constructors class. | 3 | 143 |
| CyclomaticComplexity | The method 'validateFieldsWithoutMarker()' has a cyclomatic complexity of 11. | 3 | 203–239 |
| NPathComplexity | The method 'validateFieldsWithoutMarker()' has an NPath complexity of 288 | 3 | 203–239 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 3 | 207 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 3 | 208 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 3 | 208 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 3 | 213 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 3 | 213 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 3 | 218 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 3 | 218 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 3 | 223 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 3 | 228 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 3 | 233 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 3 | 247 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 3 | 247 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| FieldNamingConventions | The final field name '_request' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 59 |
| FieldNamingConventions | The final field name '_config' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 60 |
| FieldNamingConventions | The final field name '_strSubject' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 61 |
| FieldNamingConventions | The final field name '_strMessage' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 62 |
| FieldNamingConventions | The final field name '_strSenderName' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 63 |
| FieldNamingConventions | The final field name '_strRecipientsCc' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 64 |
| FieldNamingConventions | The final field name '_strRecipientsCci' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 65 |
| AccessorClassGeneration | Avoid instantiation through private constructors from outside of the constructors class. | 3 | 147 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 3 | 180 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 3 | 185 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 3 | 190 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 3 | 204 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 3 | 204 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| FieldNamingConventions | The final field name '_request' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 65 |
| FieldNamingConventions | The final field name '_config' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 66 |
| FieldNamingConventions | The final field name '_strMessage' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 67 |
| FieldNamingConventions | The final field name '_strStatusText' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 68 |
| FieldNamingConventions | The final field name '_strSenderName' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 69 |
| FieldNamingConventions | The final field name '_strSubject' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 70 |
| FieldNamingConventions | The final field name '_nDemandMaxStep' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 71 |
| FieldNamingConventions | The final field name '_nDemandUserCurrentStep' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 72 |
| AccessorClassGeneration | Avoid instantiation through private constructors from outside of the constructors class. | 3 | 127 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 3 | 189 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 3 | 194 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 3 | 199 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 3 | 204 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 3 | 218 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 3 | 218 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| FieldNamingConventions | The final field name '_request' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 55 |
| FieldNamingConventions | The final field name '_config' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 56 |
| FieldNamingConventions | The final field name '_strMessage' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 57 |
| AccessorClassGeneration | Avoid instantiation through private constructors from outside of the constructors class. | 3 | 107 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 3 | 156 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 3 | 170 |
