The following document contains the results of PMD 6.13.0.
| Rule | Violation | Line |
|---|---|---|
| FormalParameterNamingConventions | The method parameter name '_bContentcleaned' doesn't match '[a-z][a-zA-Z0-9]*' | 268 |
| Rule | Violation | Line |
|---|---|---|
| ClassNamingConventions | The utility class name 'NotificationToHistory' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' | 59–239 |
| Rule | Violation | Line |
|---|---|---|
| ClassNamingConventions | The utility class name 'ServiceConfigTaskForm' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' | 57–218 |
| Rule | Violation | Line |
|---|---|---|
| ClassNamingConventions | The utility class name 'Constants' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' | 39–299 |
| Rule | Violation | Line |
|---|---|---|
| FieldNamingConventions | The final field name '_request' doesn't match '[a-z][a-zA-Z0-9]*' | 56 |
| Rule | Violation | Line |
|---|---|---|
| FieldNamingConventions | The constant name '_taskNotifyGruConfigService' doesn't match '[A-Z][A-Z_0-9]*' | 107 |
| FieldNamingConventions | The constant name '_notifyGRUService' doesn't match '[A-Z][A-Z_0-9]*' | 108 |
| FieldNamingConventions | The final field name '_task' doesn't match '[a-z][a-zA-Z0-9]*' | 110 |
| FieldNamingConventions | The final field name '_request' doesn't match '[a-z][a-zA-Z0-9]*' | 262 |
| FieldNamingConventions | The final field name '_listNotificationConfig' doesn't match '[a-z][a-zA-Z0-9]*' | 263 |
| FieldNamingConventions | The final field name '_model' doesn't match '[a-z][a-zA-Z0-9]*' | 264 |
| FieldNamingConventions | The final field name '_request' doesn't match '[a-z][a-zA-Z0-9]*' | 446 |
| FieldNamingConventions | The final field name '_listNotificationConfig' doesn't match '[a-z][a-zA-Z0-9]*' | 447 |
| FieldNamingConventions | The final field name '_providerManager' doesn't match '[a-z][a-zA-Z0-9]*' | 448 |
| FieldNamingConventions | The final field name '_strAction' doesn't match '[a-z][a-zA-Z0-9]*' | 449 |
| Rule | Violation | Line |
|---|---|---|
| FieldNamingConventions | The final field name '_request' doesn't match '[a-z][a-zA-Z0-9]*' | 58 |
| FieldNamingConventions | The final field name '_config' doesn't match '[a-z][a-zA-Z0-9]*' | 59 |
| FieldNamingConventions | The final field name '_strMessage' doesn't match '[a-z][a-zA-Z0-9]*' | 60 |
| FieldNamingConventions | The final field name '_strStatutText' doesn't match '[a-z][a-zA-Z0-9]*' | 61 |
| Rule | Violation | Line |
|---|---|---|
| FieldNamingConventions | The final field name '_request' doesn't match '[a-z][a-zA-Z0-9]*' | 71 |
| FieldNamingConventions | The final field name '_config' doesn't match '[a-z][a-zA-Z0-9]*' | 72 |
| FieldNamingConventions | The final field name '_strMailingType' doesn't match '[a-z][a-zA-Z0-9]*' | 73 |
| FieldNamingConventions | The final field name '_strSenderName' doesn't match '[a-z][a-zA-Z0-9]*' | 76 |
| FieldNamingConventions | The final field name '_strSubject' doesn't match '[a-z][a-zA-Z0-9]*' | 77 |
| FieldNamingConventions | The final field name '_strMessage' doesn't match '[a-z][a-zA-Z0-9]*' | 78 |
| FieldNamingConventions | The final field name '_strRecipientsCc' doesn't match '[a-z][a-zA-Z0-9]*' | 79 |
| FieldNamingConventions | The final field name '_strRecipientsCci' doesn't match '[a-z][a-zA-Z0-9]*' | 80 |
| Rule | Violation | Line |
|---|---|---|
| FieldNamingConventions | The final field name '_request' doesn't match '[a-z][a-zA-Z0-9]*' | 61 |
| FieldNamingConventions | The final field name '_config' doesn't match '[a-z][a-zA-Z0-9]*' | 62 |
| FieldNamingConventions | The final field name '_strSubject' doesn't match '[a-z][a-zA-Z0-9]*' | 63 |
| FieldNamingConventions | The final field name '_strMessage' doesn't match '[a-z][a-zA-Z0-9]*' | 64 |
| FieldNamingConventions | The final field name '_strSenderName' doesn't match '[a-z][a-zA-Z0-9]*' | 65 |
| FieldNamingConventions | The final field name '_strRecipientsCc' doesn't match '[a-z][a-zA-Z0-9]*' | 66 |
| FieldNamingConventions | The final field name '_strRecipientsCci' doesn't match '[a-z][a-zA-Z0-9]*' | 67 |
| Rule | Violation | Line |
|---|---|---|
| FieldNamingConventions | The final field name '_request' doesn't match '[a-z][a-zA-Z0-9]*' | 67 |
| FieldNamingConventions | The final field name '_config' doesn't match '[a-z][a-zA-Z0-9]*' | 68 |
| FieldNamingConventions | The final field name '_strMessage' doesn't match '[a-z][a-zA-Z0-9]*' | 69 |
| FieldNamingConventions | The final field name '_strStatusText' doesn't match '[a-z][a-zA-Z0-9]*' | 70 |
| FieldNamingConventions | The final field name '_strSenderName' doesn't match '[a-z][a-zA-Z0-9]*' | 71 |
| FieldNamingConventions | The final field name '_strSubject' doesn't match '[a-z][a-zA-Z0-9]*' | 72 |
| FieldNamingConventions | The final field name '_nDemandMaxStep' doesn't match '[a-z][a-zA-Z0-9]*' | 73 |
| FieldNamingConventions | The final field name '_nDemandUserCurrentStep' doesn't match '[a-z][a-zA-Z0-9]*' | 74 |
| Rule | Violation | Line |
|---|---|---|
| FieldNamingConventions | The final field name '_request' doesn't match '[a-z][a-zA-Z0-9]*' | 57 |
| FieldNamingConventions | The final field name '_config' doesn't match '[a-z][a-zA-Z0-9]*' | 58 |
| FieldNamingConventions | The final field name '_strMessage' doesn't match '[a-z][a-zA-Z0-9]*' | 59 |
| Rule | Violation | Line |
|---|---|---|
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 80–128 |
| Rule | Violation | Line |
|---|---|---|
| ExcessivePublicCount | This class has a bunch of public methods and attributes | 34–895 |
| TooManyFields | Too many fields | 49–895 |
| CallSuperInConstructor | It is a good practice to call super() in a constructor | 161–164 |
| CommentRequired | Public method and constructor comments are required | 161–164 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 530–537 |
| Rule | Violation | Line |
|---|---|---|
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 89–100 |
| Rule | Violation | Line |
|---|---|---|
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 134–141 |
| Rule | Violation | Line |
|---|---|---|
| AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 130 |
| AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 135 |
| MissingBreakInSwitch | A switch statement does not contain a break | 185–214 |
| Rule | Violation | Line |
|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 34–567 |
| TooManyMethods | This class has too many methods, consider refactoring it. | 92–567 |
| NPathComplexity | The method 'processTask(int, HttpServletRequest, Locale)' has an NPath complexity of 5184 | 120–261 |
| CyclomaticComplexity | The method 'processTask(int, HttpServletRequest, Locale)' has a cyclomatic complexity of 19. | 120–261 |
| NcssCount | The method 'processTask(int, HttpServletRequest, Locale)' has a NCSS line count of 79. | 120–261 |
| ExcessiveMethodLength | Avoid really long methods. | 120–261 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 126 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 217–243 |
| AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 236 |
| AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 237 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 352–369 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 522 |
| Rule | Violation | Line |
|---|---|---|
| UnnecessaryLocalBeforeReturn | Consider simply returning the value vs storing it in local variable 'config' | 100 |
| Rule | Violation | Line |
|---|---|---|
| CallSuperInConstructor | It is a good practice to call super() in a constructor | 58–61 |
| NonThreadSafeSingleton | Singleton is not thread safe | 70–73 |
| InsufficientStringBufferDeclaration | StringBuffer constructor is initialized with size 16, but has at least 26 characters appended. | 138 |
| Rule | Violation | Line |
|---|---|---|
| ImmutableField | Private field '_notifyGruHistoryService' could be made final; it is only initialized in the declaration or constructor. | 60 |
| MissingOverride | The method 'run()' is missing an @Override annotation. | 65–112 |
| InsufficientStringBufferDeclaration | StringBuffer constructor is initialized with size 16, but has at least 39 characters appended. | 70 |
| ConsecutiveLiteralAppends | StringBuffer (or StringBuilder).append is called 2 consecutive times with literals. Use a single append with a single combined String. | 85 |
| AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 85 |
| InefficientStringBuffering | Avoid concatenating nonliterals in a StringBuffer/StringBuilder constructor or append(). | 87 |
| AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 88 |
| ConsecutiveLiteralAppends | StringBuffer (or StringBuilder).append is called 4 consecutive times with literals. Use a single append with a single combined String. | 91 |
| AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 93 |
| AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 95 |
| ConsecutiveLiteralAppends | StringBuffer (or StringBuilder).append is called 3 consecutive times with literals. Use a single append with a single combined String. | 101 |
| AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 102 |
| Rule | Violation | Line |
|---|---|---|
| ShortVariable | Avoid variables with short names like ID | 63 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 124 |
| Rule | Violation | Line |
|---|---|---|
| AvoidDuplicateLiterals | The String literal "message" appears 4 times in this file; the first occurrence is on line 61 | 61 |
| ShortVariable | Avoid variables with short names like ID | 127 |
| Rule | Violation | Line |
|---|---|---|
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 161 |
| Rule | Violation | Line |
|---|---|---|
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 123 |
| Rule | Violation | Line |
|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 34–908 |
| AccessorClassGeneration | Avoid instantiation through private constructors from outside of the constructors class. | 177 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 181 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 185 |
| AccessorClassGeneration | Avoid instantiation through private constructors from outside of the constructors class. | 202 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 206 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 211 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 216 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 221 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 226 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 231 |
| TooManyMethods | This class has too many methods, consider refactoring it. | 261–433 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 277 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 317 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 354 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 370 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 388 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 393–402 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 395 |
| GodClass | Possible God Class (WMC=51, ATFD=37, TCC=7.672%) | 439–907 |
| TooManyMethods | This class has too many methods, consider refactoring it. | 440–907 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 464 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 467 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 780 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 794 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 819 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 829–836 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 831 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 835 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 846 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 859 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 871 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 892 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 894 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 894 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 900 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 900 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 904 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 904 |
| Rule | Violation | Line |
|---|---|---|
| AccessorClassGeneration | Avoid instantiation through private constructors from outside of the constructors class. | 112 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 164 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 169 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 183 |
| Rule | Violation | Line |
|---|---|---|
| DefaultPackage | Use explicit scoping instead of the default package private level | 47 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the _strBillingAccount field if you want a default access modifier | 47 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 50 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the _strBillingGroup field if you want a default access modifier | 50 |
| Rule | Violation | Line |
|---|---|---|
| AccessorClassGeneration | Avoid instantiation through private constructors from outside of the constructors class. | 146 |
| NPathComplexity | The method 'validateFieldsWithoutMarker()' has an NPath complexity of 288 | 206–242 |
| CyclomaticComplexity | The method 'validateFieldsWithoutMarker()' has a cyclomatic complexity of 11. | 206–242 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 210 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 211 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 211 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 216 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 216 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 221 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 221 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 226 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 231 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 236 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 250 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 250 |
| Rule | Violation | Line |
|---|---|---|
| AccessorClassGeneration | Avoid instantiation through private constructors from outside of the constructors class. | 122 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 181 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 186 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 191 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 205 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 205 |
| Rule | Violation | Line |
|---|---|---|
| AccessorClassGeneration | Avoid instantiation through private constructors from outside of the constructors class. | 129 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 191 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 196 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 201 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 206 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 220 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 220 |
| Rule | Violation | Line |
|---|---|---|
| AccessorClassGeneration | Avoid instantiation through private constructors from outside of the constructors class. | 109 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 158 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 172 |
| Rule | Violation | Line |
|---|---|---|
| UnusedImports | Avoid unused imports such as 'java.util.Date' | 37 |
| Rule | Violation | Line |
|---|---|---|
| UnusedImports | Avoid unused imports such as 'javax.inject.Inject' | 40 |
| UnusedImports | Avoid unused imports such as 'javax.inject.Named' | 41 |
| Rule | Violation | Line |
|---|---|---|
| ShortClassName | Avoid short class names like View | 260–433 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnusedImports | Avoid unused imports such as 'java.util.Date' | 4 | 37 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| FormalParameterNamingConventions | The method parameter name '_bContentcleaned' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 268 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 3 | 80–128 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ExcessivePublicCount | This class has a bunch of public methods and attributes | 3 | 34–895 |
| TooManyFields | Too many fields | 3 | 49–895 |
| CallSuperInConstructor | It is a good practice to call super() in a constructor | 3 | 161–164 |
| CommentRequired | Public method and constructor comments are required | 3 | 161–164 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 530–537 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 3 | 89–100 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ClassNamingConventions | The utility class name 'NotificationToHistory' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' | 1 | 59–239 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 134–141 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ClassNamingConventions | The utility class name 'ServiceConfigTaskForm' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' | 1 | 57–218 |
| AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 3 | 130 |
| AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 3 | 135 |
| MissingBreakInSwitch | A switch statement does not contain a break | 3 | 185–214 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 3 | 34–567 |
| TooManyMethods | This class has too many methods, consider refactoring it. | 3 | 92–567 |
| NPathComplexity | The method 'processTask(int, HttpServletRequest, Locale)' has an NPath complexity of 5184 | 3 | 120–261 |
| CyclomaticComplexity | The method 'processTask(int, HttpServletRequest, Locale)' has a cyclomatic complexity of 19. | 3 | 120–261 |
| NcssCount | The method 'processTask(int, HttpServletRequest, Locale)' has a NCSS line count of 79. | 3 | 120–261 |
| ExcessiveMethodLength | Avoid really long methods. | 3 | 120–261 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 126 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 217–243 |
| AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 3 | 236 |
| AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 3 | 237 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 352–369 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 522 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnnecessaryLocalBeforeReturn | Consider simply returning the value vs storing it in local variable 'config' | 3 | 100 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CallSuperInConstructor | It is a good practice to call super() in a constructor | 3 | 58–61 |
| NonThreadSafeSingleton | Singleton is not thread safe | 3 | 70–73 |
| InsufficientStringBufferDeclaration | StringBuffer constructor is initialized with size 16, but has at least 26 characters appended. | 3 | 138 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnusedImports | Avoid unused imports such as 'javax.inject.Inject' | 4 | 40 |
| UnusedImports | Avoid unused imports such as 'javax.inject.Named' | 4 | 41 |
| ImmutableField | Private field '_notifyGruHistoryService' could be made final; it is only initialized in the declaration or constructor. | 3 | 60 |
| MissingOverride | The method 'run()' is missing an @Override annotation. | 3 | 65–112 |
| InsufficientStringBufferDeclaration | StringBuffer constructor is initialized with size 16, but has at least 39 characters appended. | 3 | 70 |
| ConsecutiveLiteralAppends | StringBuffer (or StringBuilder).append is called 2 consecutive times with literals. Use a single append with a single combined String. | 3 | 85 |
| AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 3 | 85 |
| InefficientStringBuffering | Avoid concatenating nonliterals in a StringBuffer/StringBuilder constructor or append(). | 3 | 87 |
| AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 3 | 88 |
| ConsecutiveLiteralAppends | StringBuffer (or StringBuilder).append is called 4 consecutive times with literals. Use a single append with a single combined String. | 3 | 91 |
| AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 3 | 93 |
| AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 3 | 95 |
| ConsecutiveLiteralAppends | StringBuffer (or StringBuilder).append is called 3 consecutive times with literals. Use a single append with a single combined String. | 3 | 101 |
| AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 3 | 102 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ShortVariable | Avoid variables with short names like ID | 3 | 63 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 124 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ClassNamingConventions | The utility class name 'Constants' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' | 1 | 39–299 |
| AvoidDuplicateLiterals | The String literal "message" appears 4 times in this file; the first occurrence is on line 61 | 3 | 61 |
| ShortVariable | Avoid variables with short names like ID | 3 | 127 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| FieldNamingConventions | The final field name '_request' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 56 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 161 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 123 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 3 | 34–908 |
| FieldNamingConventions | The constant name '_taskNotifyGruConfigService' doesn't match '[A-Z][A-Z_0-9]*' | 1 | 107 |
| FieldNamingConventions | The constant name '_notifyGRUService' doesn't match '[A-Z][A-Z_0-9]*' | 1 | 108 |
| FieldNamingConventions | The final field name '_task' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 110 |
| AccessorClassGeneration | Avoid instantiation through private constructors from outside of the constructors class. | 3 | 177 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 3 | 181 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 3 | 185 |
| AccessorClassGeneration | Avoid instantiation through private constructors from outside of the constructors class. | 3 | 202 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 3 | 206 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 3 | 211 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 3 | 216 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 3 | 221 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 3 | 226 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 3 | 231 |
| ShortClassName | Avoid short class names like View | 4 | 260–433 |
| TooManyMethods | This class has too many methods, consider refactoring it. | 3 | 261–433 |
| FieldNamingConventions | The final field name '_request' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 262 |
| FieldNamingConventions | The final field name '_listNotificationConfig' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 263 |
| FieldNamingConventions | The final field name '_model' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 264 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 3 | 277 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 3 | 317 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 3 | 354 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 3 | 370 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 3 | 388 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 393–402 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 3 | 395 |
| GodClass | Possible God Class (WMC=51, ATFD=37, TCC=7.672%) | 3 | 439–907 |
| TooManyMethods | This class has too many methods, consider refactoring it. | 3 | 440–907 |
| FieldNamingConventions | The final field name '_request' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 446 |
| FieldNamingConventions | The final field name '_listNotificationConfig' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 447 |
| FieldNamingConventions | The final field name '_providerManager' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 448 |
| FieldNamingConventions | The final field name '_strAction' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 449 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 3 | 464 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 3 | 467 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 3 | 780 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 794 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 3 | 819 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 829–836 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 3 | 831 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 3 | 835 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 3 | 846 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 3 | 859 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 3 | 871 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 3 | 892 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 3 | 894 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 3 | 894 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 3 | 900 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 3 | 900 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 3 | 904 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 3 | 904 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| FieldNamingConventions | The final field name '_request' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 58 |
| FieldNamingConventions | The final field name '_config' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 59 |
| FieldNamingConventions | The final field name '_strMessage' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 60 |
| FieldNamingConventions | The final field name '_strStatutText' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 61 |
| AccessorClassGeneration | Avoid instantiation through private constructors from outside of the constructors class. | 3 | 112 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 3 | 164 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 3 | 169 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 3 | 183 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| DefaultPackage | Use explicit scoping instead of the default package private level | 3 | 47 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the _strBillingAccount field if you want a default access modifier | 3 | 47 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 3 | 50 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the _strBillingGroup field if you want a default access modifier | 3 | 50 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| FieldNamingConventions | The final field name '_request' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 71 |
| FieldNamingConventions | The final field name '_config' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 72 |
| FieldNamingConventions | The final field name '_strMailingType' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 73 |
| FieldNamingConventions | The final field name '_strSenderName' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 76 |
| FieldNamingConventions | The final field name '_strSubject' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 77 |
| FieldNamingConventions | The final field name '_strMessage' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 78 |
| FieldNamingConventions | The final field name '_strRecipientsCc' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 79 |
| FieldNamingConventions | The final field name '_strRecipientsCci' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 80 |
| AccessorClassGeneration | Avoid instantiation through private constructors from outside of the constructors class. | 3 | 146 |
| NPathComplexity | The method 'validateFieldsWithoutMarker()' has an NPath complexity of 288 | 3 | 206–242 |
| CyclomaticComplexity | The method 'validateFieldsWithoutMarker()' has a cyclomatic complexity of 11. | 3 | 206–242 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 3 | 210 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 3 | 211 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 3 | 211 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 3 | 216 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 3 | 216 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 3 | 221 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 3 | 221 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 3 | 226 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 3 | 231 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 3 | 236 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 3 | 250 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 3 | 250 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| FieldNamingConventions | The final field name '_request' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 61 |
| FieldNamingConventions | The final field name '_config' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 62 |
| FieldNamingConventions | The final field name '_strSubject' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 63 |
| FieldNamingConventions | The final field name '_strMessage' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 64 |
| FieldNamingConventions | The final field name '_strSenderName' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 65 |
| FieldNamingConventions | The final field name '_strRecipientsCc' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 66 |
| FieldNamingConventions | The final field name '_strRecipientsCci' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 67 |
| AccessorClassGeneration | Avoid instantiation through private constructors from outside of the constructors class. | 3 | 122 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 3 | 181 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 3 | 186 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 3 | 191 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 3 | 205 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 3 | 205 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| FieldNamingConventions | The final field name '_request' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 67 |
| FieldNamingConventions | The final field name '_config' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 68 |
| FieldNamingConventions | The final field name '_strMessage' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 69 |
| FieldNamingConventions | The final field name '_strStatusText' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 70 |
| FieldNamingConventions | The final field name '_strSenderName' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 71 |
| FieldNamingConventions | The final field name '_strSubject' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 72 |
| FieldNamingConventions | The final field name '_nDemandMaxStep' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 73 |
| FieldNamingConventions | The final field name '_nDemandUserCurrentStep' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 74 |
| AccessorClassGeneration | Avoid instantiation through private constructors from outside of the constructors class. | 3 | 129 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 3 | 191 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 3 | 196 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 3 | 201 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 3 | 206 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 3 | 220 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 3 | 220 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| FieldNamingConventions | The final field name '_request' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 57 |
| FieldNamingConventions | The final field name '_config' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 58 |
| FieldNamingConventions | The final field name '_strMessage' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 59 |
| AccessorClassGeneration | Avoid instantiation through private constructors from outside of the constructors class. | 3 | 109 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 3 | 158 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 3 | 172 |
