Fork me on GitHub

Résultats PMD

Le document suivant contient les résultats de PMD 6.13.0.

Violations By Priority

Priority 1

fr/paris/lutece/plugins/workflow/modules/ticketing/business/config/MessageDirection.java

Rule Violation Ligne
FieldNamingConventions The static field name 'mapMessageDirection' doesn't match '_[a-z][a-zA-Z0-9]*' 54

fr/paris/lutece/plugins/workflow/modules/ticketing/business/config/TaskModifyTicketCategoryConfig.java

Rule Violation Ligne
FormalParameterNamingConventions The method parameter name '_nSelectedEntry' doesn't match '[a-z][a-zA-Z0-9]*' 69

fr/paris/lutece/plugins/workflow/modules/ticketing/business/config/TaskReplyConfig.java

Rule Violation Ligne
FormalParameterNamingConventions The method parameter name '_bCloseTicket' doesn't match '[a-z][a-zA-Z0-9]*' 84

fr/paris/lutece/plugins/workflow/modules/ticketing/business/email/provider/TicketEmailExternalUserConstants.java

Rule Violation Ligne
ClassNamingConventions The utility class name 'TicketEmailExternalUserConstants' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' 3985

fr/paris/lutece/plugins/workflow/modules/ticketing/business/externaluser/search/ExternalUserEmailValidationServlet.java

Rule Violation Ligne
FieldNamingConventions The final field name '_externalUserDAO' doesn't match '[a-z][a-zA-Z0-9]*' 87

fr/paris/lutece/plugins/workflow/modules/ticketing/business/externaluser/search/ExternalUserSearchServlet.java

Rule Violation Ligne
FieldNamingConventions The final field name '_externalUserDAO' doesn't match '[a-z][a-zA-Z0-9]*' 107
FieldNamingConventions The constant name '_attributeService' doesn't match '[A-Z][A-Z_0-9]*' 110

fr/paris/lutece/plugins/workflow/modules/ticketing/service/daemon/NotifyDaemon.java

Rule Violation Ligne
FieldNamingConventions The constant name '_resourceHistoryService' doesn't match '[A-Z][A-Z_0-9]*' 62
FieldNamingConventions The field name 'nIdWorkflow' doesn't match '_[a-z][a-zA-Z0-9]*' 64
FieldNamingConventions The field name 'isMinuteMode' doesn't match '_[a-z][a-zA-Z0-9]*' 67
FieldNamingConventions The field name 'nIdStateWaiting' doesn't match '_[a-z][a-zA-Z0-9]*' 71
FieldNamingConventions The field name 'nIdActionRelance' doesn't match '_[a-z][a-zA-Z0-9]*' 76
FieldNamingConventions The field name 'nIdActionSolliciterFromTerrainNiv2' doesn't match '_[a-z][a-zA-Z0-9]*' 82
FieldNamingConventions The field name 'nIdActionSolliciterFromTerrainNiv3' doesn't match '_[a-z][a-zA-Z0-9]*' 85
FieldNamingConventions The field name 'nIdActionSolliciterFromContribNiv2' doesn't match '_[a-z][a-zA-Z0-9]*' 88
FieldNamingConventions The field name 'nIdActionSolliciterFromContribNiv3' doesn't match '_[a-z][a-zA-Z0-9]*' 91
FieldNamingConventions The field name 'nIdActionRetourFromTerrainNiv2' doesn't match '_[a-z][a-zA-Z0-9]*' 98
FieldNamingConventions The field name 'nIdActionRetourFromTerrainNiv3' doesn't match '_[a-z][a-zA-Z0-9]*' 101
FieldNamingConventions The field name 'nIdActionRetourFromContribNiv2' doesn't match '_[a-z][a-zA-Z0-9]*' 104
FieldNamingConventions The field name 'nIdActionRetourFromContribNiv3' doesn't match '_[a-z][a-zA-Z0-9]*' 107
FieldNamingConventions The field name 'nbRelanceMax' doesn't match '_[a-z][a-zA-Z0-9]*' 111
FieldNamingConventions The field name 'nFrequence' doesn't match '_[a-z][a-zA-Z0-9]*' 113

fr/paris/lutece/plugins/workflow/modules/ticketing/service/daemon/NotifyLevel3Daemon.java

Rule Violation Ligne
FieldNamingConventions The constant name '_resourceHistoryService' doesn't match '[A-Z][A-Z_0-9]*' 64
FieldNamingConventions The field name 'nIdWorkflow' doesn't match '_[a-z][a-zA-Z0-9]*' 66
FieldNamingConventions The field name 'isMinuteMode' doesn't match '_[a-z][a-zA-Z0-9]*' 68
FieldNamingConventions The field name 'nIdStateLevel3' doesn't match '_[a-z][a-zA-Z0-9]*' 73
FieldNamingConventions The field name 'nIdActionRelance' doesn't match '_[a-z][a-zA-Z0-9]*' 78
FieldNamingConventions The field name 'nIdActionEscaladerNiveau3' doesn't match '_[a-z][a-zA-Z0-9]*' 84
FieldNamingConventions The field name 'nIdActionReturnATraiter' doesn't match '_[a-z][a-zA-Z0-9]*' 90
FieldNamingConventions The field name 'nbRelanceMax' doesn't match '_[a-z][a-zA-Z0-9]*' 94
FieldNamingConventions The field name 'nFrequence' doesn't match '_[a-z][a-zA-Z0-9]*' 96

fr/paris/lutece/plugins/workflow/modules/ticketing/service/daemon/NotifyUsagerDaemon.java

Rule Violation Ligne
FieldNamingConventions The constant name '_resourceHistoryService' doesn't match '[A-Z][A-Z_0-9]*' 62
FieldNamingConventions The field name 'nIdWorkflow' doesn't match '_[a-z][a-zA-Z0-9]*' 64
FieldNamingConventions The field name 'isMinuteMode' doesn't match '_[a-z][a-zA-Z0-9]*' 66
FieldNamingConventions The field name 'nIdStateWaitingUsager' doesn't match '_[a-z][a-zA-Z0-9]*' 71
FieldNamingConventions The field name 'nIdActionRelance' doesn't match '_[a-z][a-zA-Z0-9]*' 77
FieldNamingConventions The field name 'nIdActionDemandeComplementUsager' doesn't match '_[a-z][a-zA-Z0-9]*' 83
FieldNamingConventions The field name 'nIdActionRetourFromDemandeComplementUsager' doesn't match '_[a-z][a-zA-Z0-9]*' 90
FieldNamingConventions The field name 'nbRelanceMax' doesn't match '_[a-z][a-zA-Z0-9]*' 94
FieldNamingConventions The field name 'nFrequence' doesn't match '_[a-z][a-zA-Z0-9]*' 96

fr/paris/lutece/plugins/workflow/modules/ticketing/service/daemon/TicketAnonymisationDaemon.java

Rule Violation Ligne
FieldNamingConventions The static field name 'dao' doesn't match '_[a-z][a-zA-Z0-9]*' 88
FieldNamingConventions The static field name 'daoTaskInfo' doesn't match '_[a-z][a-zA-Z0-9]*' 89
FieldNamingConventions The static field name 'daoResourceHist' doesn't match '_[a-z][a-zA-Z0-9]*' 90
FieldNamingConventions The static field name 'daoEditableTicketHist' doesn't match '_[a-z][a-zA-Z0-9]*' 91
FieldNamingConventions The static field name 'daoAnonymisation' doesn't match '_[a-z][a-zA-Z0-9]*' 92
FieldNamingConventions The final field name '_stockageS3DaemonMinio' doesn't match '[a-z][a-zA-Z0-9]*' 94
FieldNamingConventions The final field name '_stockageS3DaemonNetapp' doesn't match '[a-z][a-zA-Z0-9]*' 95
FieldNamingConventions The static field name 'plugin' doesn't match '_[a-z][a-zA-Z0-9]*' 97

fr/paris/lutece/plugins/workflow/modules/ticketing/service/task/TaskReassignTicketToUnitForAUserNotAvailable.java

Rule Violation Ligne
FieldNamingConventions The field name 'dao' doesn't match '_[a-z][a-zA-Z0-9]*' 81

fr/paris/lutece/plugins/workflow/modules/ticketing/utils/TaskEditTicketConstants.java

Rule Violation Ligne
ClassNamingConventions The utility class name 'TaskEditTicketConstants' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' 4160

fr/paris/lutece/plugins/workflow/modules/ticketing/utils/UtilConstants.java

Rule Violation Ligne
ClassWithOnlyPrivateConstructorsShouldBeFinal A class which only has private constructors should be final 3644
ClassNamingConventions The utility class name 'UtilConstants' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' 3644

fr/paris/lutece/plugins/workflow/modules/ticketing/utils/WorkflowTicketingUtils.java

Rule Violation Ligne
FieldNamingConventions The constant name '_resourceHistoryService' doesn't match '[A-Z][A-Z_0-9]*' 64

fr/paris/lutece/plugins/workflow/modules/ticketing/web/ModifyTicketCategoryJspBean.java

Rule Violation Ligne
FieldNamingConventions The final field name '_ticketFormService' doesn't match '[a-z][a-zA-Z0-9]*' 71
FieldNamingConventions The final field name '_taskModifyTicketCategoryConfigService' doesn't match '[a-z][a-zA-Z0-9]*' 72

fr/paris/lutece/plugins/workflow/modules/ticketing/web/task/TicketEmailExternalUserTaskComponent.java

Rule Violation Ligne
FieldNamingConventions The constant name '_attributeService' doesn't match '[A-Z][A-Z_0-9]*' 132
FieldNamingConventions The field name '_ExternalUserDAO' doesn't match '_[a-z][a-zA-Z0-9]*' 160

fr/paris/lutece/plugins/workflow/modules/ticketing/web/task/TicketingCommentTaskComponent.java

Rule Violation Ligne
FieldNamingConventions The field name 'taskComponent' doesn't match '_[a-z][a-zA-Z0-9]*' 69

Priority 2

fr/paris/lutece/plugins/workflow/modules/ticketing/service/daemon/TicketAnonymisationDaemon.java

Rule Violation Ligne
AvoidReassigningParameters Avoid reassigning parameters such as 'messageToSanitize' 811
AvoidReassigningParameters Avoid reassigning parameters such as 'messageToSanitize' 811
AvoidReassigningParameters Avoid reassigning parameters such as 'messageToSanitize' 811
AvoidReassigningParameters Avoid reassigning parameters such as 'messageToSanitize' 811
AvoidReassigningParameters Avoid reassigning parameters such as 'messageToSanitize' 811
AvoidReassigningParameters Avoid reassigning parameters such as 'messageToSanitize' 811
AvoidReassigningParameters Avoid reassigning parameters such as 'messageToSanitize' 811
AvoidReassigningParameters Avoid reassigning parameters such as 'messageToSanitize' 811
AvoidReassigningParameters Avoid reassigning parameters such as 'str' 832
AvoidReassigningParameters Avoid reassigning parameters such as 'str' 832
AvoidReassigningParameters Avoid reassigning parameters such as 'str' 832
AvoidReassigningParameters Avoid reassigning parameters such as 'str' 832
AvoidReassigningParameters Avoid reassigning parameters such as 'str' 832
AvoidReassigningParameters Avoid reassigning parameters such as 'str' 832
AvoidReassigningParameters Avoid reassigning parameters such as 'str' 832
AvoidReassigningParameters Avoid reassigning parameters such as 'str' 832
AvoidReassigningParameters Avoid reassigning parameters such as 'str' 832
AvoidReassigningParameters Avoid reassigning parameters such as 'str' 832
AvoidReassigningParameters Avoid reassigning parameters such as 'str' 832
AvoidReassigningParameters Avoid reassigning parameters such as 'str' 832
AvoidReassigningParameters Avoid reassigning parameters such as 'str' 832
AvoidReassigningParameters Avoid reassigning parameters such as 'str' 832
AvoidReassigningParameters Avoid reassigning parameters such as 'str' 832
AvoidReassigningParameters Avoid reassigning parameters such as 'str' 832
AvoidReassigningParameters Avoid reassigning parameters such as 'str' 832

fr/paris/lutece/plugins/workflow/modules/ticketing/service/daemon/TicketPjMigrationDaemon.java

Rule Violation Ligne
AvoidReassigningParameters Avoid reassigning parameters such as 'idCoreUploadFinal' 263
AvoidReassigningParameters Avoid reassigning parameters such as 'idFileList' 354

fr/paris/lutece/plugins/workflow/modules/ticketing/service/task/TaskAutomaticCentralizeAttachments.java

Rule Violation Ligne
AvoidReassigningParameters Avoid reassigning parameters such as 'idFileList' 310

Priority 3

fr/paris/lutece/plugins/workflow/modules/ticketing/business/anonymisation/AnonymisationDAO.java

Rule Violation Ligne
CommentRequired Header comments are required 44188
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 60
InefficientStringBuffering Avoid concatenating nonliterals in a StringBuffer/StringBuilder constructor or append(). 91

fr/paris/lutece/plugins/workflow/modules/ticketing/business/anonymisation/IAnonymisationDAO.java

Rule Violation Ligne
CommentRequired Header comments are required 41113

fr/paris/lutece/plugins/workflow/modules/ticketing/business/config/MessageDirection.java

Rule Violation Ligne
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 54
UseLocaleWithCaseConversions When doing a String.toLowerCase()/toUpperCase() call, use a Locale 85

fr/paris/lutece/plugins/workflow/modules/ticketing/business/config/TaskAssignTicketToUnitConfigDAO.java

Rule Violation Ligne
CommentRequired Header comments are required 41131
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 5568

fr/paris/lutece/plugins/workflow/modules/ticketing/business/config/TaskEditTicketConfig.java

Rule Violation Ligne
UnusedPrivateField Avoid unused private fields such as '_nIdStateAfterEdition'. 53

fr/paris/lutece/plugins/workflow/modules/ticketing/business/config/TaskEditTicketConfigDAO.java

Rule Violation Ligne
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 6072

fr/paris/lutece/plugins/workflow/modules/ticketing/business/config/TaskMarkAsUnreadConfig.java

Rule Violation Ligne
CommentRequired Header comments are required 4167

fr/paris/lutece/plugins/workflow/modules/ticketing/business/config/TaskMarkAsUnreadConfigDAO.java

Rule Violation Ligne
CommentRequired Header comments are required 45153
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 5970

fr/paris/lutece/plugins/workflow/modules/ticketing/business/config/TaskModifyTicketCategoryConfigDAO.java

Rule Violation Ligne
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 5581
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 121128

fr/paris/lutece/plugins/workflow/modules/ticketing/business/config/TaskNotifyWaitingTicketConfig.java

Rule Violation Ligne
CommentRequired Header comments are required 41124
CommentRequired Public method and constructor comments are required 115118
CommentRequired Public method and constructor comments are required 120123

fr/paris/lutece/plugins/workflow/modules/ticketing/business/config/TaskNotifyWaitingTicketConfigDAO.java

Rule Violation Ligne
CommentRequired Header comments are required 43183

fr/paris/lutece/plugins/workflow/modules/ticketing/business/email/cc/TicketEmailExternalUserCcDAO.java

Rule Violation Ligne
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 8398

fr/paris/lutece/plugins/workflow/modules/ticketing/business/email/config/MessageDirectionExternalUser.java

Rule Violation Ligne
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 55
UseLocaleWithCaseConversions When doing a String.toLowerCase()/toUpperCase() call, use a Locale 86

fr/paris/lutece/plugins/workflow/modules/ticketing/business/email/config/TaskTicketEmailExternalUserConfig.java

Rule Violation Ligne
CommentRequired Public method and constructor comments are required 117120
CommentRequired Public method and constructor comments are required 122125

fr/paris/lutece/plugins/workflow/modules/ticketing/business/email/config/TaskTicketEmailExternalUserConfigDAO.java

Rule Violation Ligne
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 5694

fr/paris/lutece/plugins/workflow/modules/ticketing/business/email/history/TicketEmailExternalUserHistoryDAO.java

Rule Violation Ligne
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 6274

fr/paris/lutece/plugins/workflow/modules/ticketing/business/email/message/ITicketEmailExternalUserMessageDAO.java

Rule Violation Ligne
UnnecessaryModifier Unnecessary modifier 'public' on method 'closeMessagesByIdTicket': the method is declared in an interface type 85
CommentRequired Public method and constructor comments are required 140
ShortVariable Avoid variables with short names like id 140
CommentRequired Public method and constructor comments are required 142
CommentRequired Public method and constructor comments are required 144

fr/paris/lutece/plugins/workflow/modules/ticketing/business/email/message/TicketEmailExternalUserMessage.java

Rule Violation Ligne
CommentRequired Public method and constructor comments are required 184187
CommentRequired Public method and constructor comments are required 189192

fr/paris/lutece/plugins/workflow/modules/ticketing/business/email/message/TicketEmailExternalUserMessageDAO.java

Rule Violation Ligne
TooManyMethods This class has too many methods, consider refactoring it. 52415
AvoidDuplicateLiterals The String literal "workflow.transactionManager" appears 4 times in this file; the first occurrence is on line 122 122
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 123140
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 158171
ShortVariable Avoid variables with short names like id 366
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 384

fr/paris/lutece/plugins/workflow/modules/ticketing/business/email/provider/TicketEmailExternalUserProvider.java

Rule Violation Ligne
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 34432
TooManyMethods This class has too many methods, consider refactoring it. 73432
ImmutableField Private field '_ticketEmailExternalUserHistoryDAO' could be made final; it is only initialized in the declaration or constructor. 100
ImmutableField Private field '_ticketEmailExternalUserDemandDAO' could be made final; it is only initialized in the declaration or constructor. 104
ImmutableField Private field '_ticket' could be made final; it is only initialized in the declaration or constructor. 107
SimpleDateFormatNeedsLocale When instantiating a SimpleDateFormat object, specify a Locale 110
DefaultPackage Use explicit scoping instead of the default package private level 110
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the _dateFormater field if you want a default access modifier 110
ConfusingTernary Avoid if (x != y) ..; else ..; 296307
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 421428

fr/paris/lutece/plugins/workflow/modules/ticketing/business/email/recipient/TicketEmailExternalUserRecipientDAO.java

Rule Violation Ligne
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 8199

fr/paris/lutece/plugins/workflow/modules/ticketing/business/externaluser/ExternalUserComparator.java

Rule Violation Ligne
ShortVariable Avoid variables with short names like o2 55
ShortVariable Avoid variables with short names like o1 55
ShortVariable Avoid variables with short names like c 93
CyclomaticComplexity The method 'compareAlphaNumeric(String, String, int)' has a cyclomatic complexity of 15. 142226
NPathComplexity The method 'compareAlphaNumeric(String, String, int)' has an NPath complexity of 256 142226

fr/paris/lutece/plugins/workflow/modules/ticketing/business/externaluser/ExternalUserDAO.java

Rule Violation Ligne
CyclomaticComplexity The method 'findExternalUser(String, String, String, String, String)' has a cyclomatic complexity of 14. 126208
NPathComplexity The method 'findExternalUser(String, String, String, String, String)' has an NPath complexity of 4656 126208
UseObjectForClearerAPI Rather than using a lot of String arguments, consider using a container object for those values. 126

fr/paris/lutece/plugins/workflow/modules/ticketing/business/externaluser/IExternalUserDAO.java

Rule Violation Ligne
UseObjectForClearerAPI Rather than using a lot of String arguments, consider using a container object for those values. 78

fr/paris/lutece/plugins/workflow/modules/ticketing/business/externaluser/search/ExternalUserEmailValidationServlet.java

Rule Violation Ligne
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 112
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 131
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 150

fr/paris/lutece/plugins/workflow/modules/ticketing/business/externaluser/search/ExternalUserSearchServlet.java

Rule Violation Ligne
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 144

fr/paris/lutece/plugins/workflow/modules/ticketing/business/information/TaskInformationDAO.java

Rule Violation Ligne
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 5969

fr/paris/lutece/plugins/workflow/modules/ticketing/business/resourcehistory/ResourceHistoryDAO.java

Rule Violation Ligne
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 62102

fr/paris/lutece/plugins/workflow/modules/ticketing/business/resourcehistory/ResourceHistoryService.java

Rule Violation Ligne
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 114

fr/paris/lutece/plugins/workflow/modules/ticketing/business/ticket/EditableTicketDAO.java

Rule Violation Ligne
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 6780

fr/paris/lutece/plugins/workflow/modules/ticketing/business/ticket/EditableTicketFieldDAO.java

Rule Violation Ligne
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 5970

fr/paris/lutece/plugins/workflow/modules/ticketing/service/WorkflowTicketingPlugin.java

Rule Violation Ligne
UncommentedEmptyMethodBody Document empty method body 6162

fr/paris/lutece/plugins/workflow/modules/ticketing/service/assignment/AutomaticAssignmentAgentParisFamilleService.java

Rule Violation Ligne
UnnecessaryConstructor Avoid unnecessary constructors - the compiler will generate these for you 7073
ConfusingTernary Avoid if (x != y) ..; else ..; 143151

fr/paris/lutece/plugins/workflow/modules/ticketing/service/daemon/NotifyDaemon.java

Rule Violation Ligne
CommentRequired Header comments are required 57473
ImmutableField Private field 'nIdWorkflow' could be made final; it is only initialized in the declaration or constructor. 64
LinguisticNaming Linguistics Antipattern - The field 'isMinuteMode' indicates linguistically it is a boolean, but it is 'int' 67
ImmutableField Private field 'isMinuteMode' could be made final; it is only initialized in the declaration or constructor. 67
ImmutableField Private field 'nIdStateWaiting' could be made final; it is only initialized in the declaration or constructor. 71
ImmutableField Private field 'nIdActionRelance' could be made final; it is only initialized in the declaration or constructor. 76
ImmutableField Private field 'nIdActionSolliciterFromTerrainNiv2' could be made final; it is only initialized in the declaration or constructor. 82
ImmutableField Private field 'nIdActionSolliciterFromTerrainNiv3' could be made final; it is only initialized in the declaration or constructor. 85
ImmutableField Private field 'nIdActionSolliciterFromContribNiv2' could be made final; it is only initialized in the declaration or constructor. 88
ImmutableField Private field 'nIdActionSolliciterFromContribNiv3' could be made final; it is only initialized in the declaration or constructor. 91
ImmutableField Private field 'nIdActionRetourFromTerrainNiv2' could be made final; it is only initialized in the declaration or constructor. 98
ImmutableField Private field 'nIdActionRetourFromTerrainNiv3' could be made final; it is only initialized in the declaration or constructor. 101
ImmutableField Private field 'nIdActionRetourFromContribNiv2' could be made final; it is only initialized in the declaration or constructor. 104
ImmutableField Private field 'nIdActionRetourFromContribNiv3' could be made final; it is only initialized in the declaration or constructor. 107
ImmutableField Private field 'nbRelanceMax' could be made final; it is only initialized in the declaration or constructor. 111
ImmutableField Private field 'nFrequence' could be made final; it is only initialized in the declaration or constructor. 113
ExcessiveMethodLength Avoid really long methods. 121230
CyclomaticComplexity The method 'processNotification()' has a cyclomatic complexity of 18. 121230
InsufficientStringBufferDeclaration StringBuffer constructor is initialized with size 16, but has at least 144 characters appended. 123
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 132
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 134
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 135
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 199
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 222223
ConsecutiveLiteralAppends StringBuffer (or StringBuilder).append is called 2 consecutive times with literals. Use a single append with a single combined String. 223
ConsecutiveLiteralAppends StringBuffer (or StringBuilder).append is called 2 consecutive times with literals. Use a single append with a single combined String. 224
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 224
CyclomaticComplexity The method 'isConfParamOK(StringBuilder)' has a cyclomatic complexity of 15. 239272
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 263
UnusedPrivateMethod Avoid unused private methods such as 'processRelanceNoDate(Ticket,Date)'. 282
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 424
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 458467

fr/paris/lutece/plugins/workflow/modules/ticketing/service/daemon/NotifyLevel3Daemon.java

Rule Violation Ligne
CommentRequired Header comments are required 59399
ImmutableField Private field 'nIdWorkflow' could be made final; it is only initialized in the declaration or constructor. 66
LinguisticNaming Linguistics Antipattern - The field 'isMinuteMode' indicates linguistically it is a boolean, but it is 'int' 68
ImmutableField Private field 'isMinuteMode' could be made final; it is only initialized in the declaration or constructor. 68
ImmutableField Private field 'nIdStateLevel3' could be made final; it is only initialized in the declaration or constructor. 73
ImmutableField Private field 'nIdActionRelance' could be made final; it is only initialized in the declaration or constructor. 78
ImmutableField Private field 'nIdActionEscaladerNiveau3' could be made final; it is only initialized in the declaration or constructor. 84
ImmutableField Private field 'nIdActionReturnATraiter' could be made final; it is only initialized in the declaration or constructor. 90
ImmutableField Private field 'nbRelanceMax' could be made final; it is only initialized in the declaration or constructor. 94
ImmutableField Private field 'nFrequence' could be made final; it is only initialized in the declaration or constructor. 96
ExcessiveMethodLength Avoid really long methods. 104210
CyclomaticComplexity The method 'processNotification()' has a cyclomatic complexity of 15. 104210
InsufficientStringBufferDeclaration StringBuffer constructor is initialized with size 16, but has at least 127 characters appended. 106
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 115
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 117
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 118
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 179
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 202203
ConsecutiveLiteralAppends StringBuffer (or StringBuilder).append is called 2 consecutive times with literals. Use a single append with a single combined String. 203
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 204
ConsecutiveLiteralAppends StringBuffer (or StringBuilder).append is called 2 consecutive times with literals. Use a single append with a single combined String. 204
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 241
UnusedPrivateMethod Avoid unused private methods such as 'processRelanceNoDate(Ticket,Date)'. 260
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 310
AssignmentInOperand Avoid assignments in operands 385

fr/paris/lutece/plugins/workflow/modules/ticketing/service/daemon/NotifyUsagerDaemon.java

Rule Violation Ligne
CommentRequired Header comments are required 57387
ImmutableField Private field 'nIdWorkflow' could be made final; it is only initialized in the declaration or constructor. 64
LinguisticNaming Linguistics Antipattern - The field 'isMinuteMode' indicates linguistically it is a boolean, but it is 'int' 66
ImmutableField Private field 'isMinuteMode' could be made final; it is only initialized in the declaration or constructor. 66
ImmutableField Private field 'nIdStateWaitingUsager' could be made final; it is only initialized in the declaration or constructor. 71
ImmutableField Private field 'nIdActionRelance' could be made final; it is only initialized in the declaration or constructor. 77
ImmutableField Private field 'nIdActionDemandeComplementUsager' could be made final; it is only initialized in the declaration or constructor. 83
ImmutableField Private field 'nIdActionRetourFromDemandeComplementUsager' could be made final; it is only initialized in the declaration or constructor. 90
ImmutableField Private field 'nbRelanceMax' could be made final; it is only initialized in the declaration or constructor. 94
ImmutableField Private field 'nFrequence' could be made final; it is only initialized in the declaration or constructor. 96
ExcessiveMethodLength Avoid really long methods. 104210
CyclomaticComplexity The method 'processNotification()' has a cyclomatic complexity of 15. 104210
InsufficientStringBufferDeclaration StringBuffer constructor is initialized with size 16, but has at least 158 characters appended. 106
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 115
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 117
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 118
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 179
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 202203
ConsecutiveLiteralAppends StringBuffer (or StringBuilder).append is called 2 consecutive times with literals. Use a single append with a single combined String. 203
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 204
ConsecutiveLiteralAppends StringBuffer (or StringBuilder).append is called 2 consecutive times with literals. Use a single append with a single combined String. 204
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 242
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 339
AssignmentInOperand Avoid assignments in operands 373

fr/paris/lutece/plugins/workflow/modules/ticketing/service/daemon/TicketAnonymisationDaemon.java

Rule Violation Ligne
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 34855
GodClass Possible God Class (WMC=92, ATFD=78, TCC=9.677%) 81855
CyclomaticComplexity The class 'TicketAnonymisationDaemon' has a total cyclomatic complexity of 92 (highest 8). 81855
TooManyMethods This class has too many methods, consider refactoring it. 82855
CommentRequired Public method and constructor comments are required 105108
UnnecessaryConstructor Avoid unnecessary constructors - the compiler will generate these for you 105108
ShortVariable Avoid variables with short names like sb 116
ShortVariable Avoid variables with short names like sb 130
ShortVariable Avoid variables with short names like sb 153
ConfusingTernary Avoid if (x != y) ..; else ..; 158160
ConfusingTernary Avoid if (x != y) ..; else ..; 173219
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 206
ShortVariable Avoid variables with short names like sb 237
SimpleDateFormatNeedsLocale When instantiating a SimpleDateFormat object, specify a Locale 240
ShortVariable Avoid variables with short names like pj 294
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 295
ShortVariable Avoid variables with short names like sb 315
ConfusingTernary Avoid if (x != y) ..; else ..; 419435
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 440
ShortVariable Avoid variables with short names like pj 443
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 530
ConfusingTernary Avoid if (x != y) ..; else ..; 539546
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 656
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 658677
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 712
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 714720
InefficientEmptyStringCheck String.trim().length() == 0 / String.trim().isEmpty() is an inefficient way to validate a blank String. 738
InefficientEmptyStringCheck String.trim().length() == 0 / String.trim().isEmpty() is an inefficient way to validate a blank String. 757
InefficientEmptyStringCheck String.trim().length() == 0 / String.trim().isEmpty() is an inefficient way to validate a blank String. 778
AvoidDuplicateLiterals The String literal "(?i)" appears 6 times in this file; the first occurrence is on line 813 813

fr/paris/lutece/plugins/workflow/modules/ticketing/service/daemon/TicketPjMigrationDaemon.java

Rule Violation Ligne
GodClass Possible God Class (WMC=50, ATFD=41, TCC=2.500%) 66468
TooManyMethods This class has too many methods, consider refactoring it. 67468
UnnecessaryConstructor Avoid unnecessary constructors - the compiler will generate these for you 7982
ShortVariable Avoid variables with short names like sb 90
ShortVariable Avoid variables with short names like sb 105
ConfusingTernary Avoid if (x != y) ..; else ..; 109164
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 150
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 279
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 279
ShortVariable Avoid variables with short names like pj 376
ShortVariable Avoid variables with short names like pj 411

fr/paris/lutece/plugins/workflow/modules/ticketing/service/task/AbstractTicketingTask.java

Rule Violation Ligne
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 83

fr/paris/lutece/plugins/workflow/modules/ticketing/service/task/TaskAssignTicketToMe.java

Rule Violation Ligne
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 106110

fr/paris/lutece/plugins/workflow/modules/ticketing/service/task/TaskAssignTicketToRQ.java

Rule Violation Ligne
CommentRequired Header comments are required 5199

fr/paris/lutece/plugins/workflow/modules/ticketing/service/task/TaskAssignTicketToUser.java

Rule Violation Ligne
ConfusingTernary Avoid if (x != y) ..; else ..; 96122

fr/paris/lutece/plugins/workflow/modules/ticketing/service/task/TaskAssignUnitLinkedToCategory.java

Rule Violation Ligne
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 8589

fr/paris/lutece/plugins/workflow/modules/ticketing/service/task/TaskAssignUpTicket.java

Rule Violation Ligne
CyclomaticComplexity The method 'processTicketingTask(int, HttpServletRequest, Locale)' has a cyclomatic complexity of 10. 81148
ConfusingTernary Avoid if (x != y) ..; else ..; 84

fr/paris/lutece/plugins/workflow/modules/ticketing/service/task/TaskAutomaticAgentAssignmentParisFamille.java

Rule Violation Ligne
UseLocaleWithCaseConversions When doing a String.toLowerCase()/toUpperCase() call, use a Locale 84

fr/paris/lutece/plugins/workflow/modules/ticketing/service/task/TaskAutomaticCentralizeAttachments.java

Rule Violation Ligne
TooManyMethods This class has too many methods, consider refactoring it. 68436
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 114
ShortVariable Avoid variables with short names like pj 332
ShortVariable Avoid variables with short names like pj 372

fr/paris/lutece/plugins/workflow/modules/ticketing/service/task/TaskAutomaticIdAdminBOInit.java

Rule Violation Ligne
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 69

fr/paris/lutece/plugins/workflow/modules/ticketing/service/task/TaskEditTicket.java

Rule Violation Ligne
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 34414
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 127
UnusedFormalParameter Avoid unused method parameters such as 'locale'. 163
NPathComplexity The method 'processAgentTask(int, HttpServletRequest, Locale, TaskEditTicketConfig)' has an NPath complexity of 288 163244
CyclomaticComplexity The method 'processAgentTask(int, HttpServletRequest, Locale, TaskEditTicketConfig)' has a cyclomatic complexity of 11. 163244
UnusedFormalParameter Avoid unused method parameters such as 'locale'. 259
UnusedFormalParameter Avoid unused method parameters such as 'config'. 259
CyclomaticComplexity The method 'processUserTask(int, HttpServletRequest, Locale, TaskEditTicketConfig)' has a cyclomatic complexity of 13. 259342
NPathComplexity The method 'processUserTask(int, HttpServletRequest, Locale, TaskEditTicketConfig)' has an NPath complexity of 240 259342
ShortVariable Avoid variables with short names like pj 298
ShortVariable Avoid variables with short names like pj 344
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 371

fr/paris/lutece/plugins/workflow/modules/ticketing/service/task/TaskModifyTicket.java

Rule Violation Ligne
ExcessiveMethodLength Avoid really long methods. 105323
NPathComplexity The method 'processTicketingTask(int, HttpServletRequest, Locale)' has an NPath complexity of 1047176 105323
NcssCount The method 'processTicketingTask(int, HttpServletRequest, Locale)' has a NCSS line count of 108. 105323
CyclomaticComplexity The method 'processTicketingTask(int, HttpServletRequest, Locale)' has a cyclomatic complexity of 33. 105323
ShortVariable Avoid variables with short names like pj 137
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 145
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 169
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 178
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 187
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 196
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 205
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 214
ConfusingTernary Avoid if (x != y) ..; else ..; 223290
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 230
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 237
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 244
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 251
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 262265
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 264
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 269272
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 271
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 276279
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 278
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 283286
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 285
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 300
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 309
ShortVariable Avoid variables with short names like pj 355

fr/paris/lutece/plugins/workflow/modules/ticketing/service/task/TaskModifyTicketCategory.java

Rule Violation Ligne
ExcessiveMethodLength Avoid really long methods. 93239
CyclomaticComplexity The method 'processTicketingTask(int, HttpServletRequest, Locale)' has a cyclomatic complexity of 27. 93239
NcssCount The method 'processTicketingTask(int, HttpServletRequest, Locale)' has a NCSS line count of 72. 93239
NPathComplexity The method 'processTicketingTask(int, HttpServletRequest, Locale)' has an NPath complexity of 52178 93239
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 121
ConfusingTernary Avoid if (x != y) ..; else ..; 155163
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 155163
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 157
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 162
ConfusingTernary Avoid if (x != y) ..; else ..; 178186
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 180
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 183186
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 185
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 195
EmptyIfStmt Avoid empty if statements 220222

fr/paris/lutece/plugins/workflow/modules/ticketing/service/task/TaskNotifyWaitingTicket.java

Rule Violation Ligne
CommentRequired Header comments are required 68328
ImmutableField Private field '_externalUserDAO' could be made final; it is only initialized in the declaration or constructor. 111
CyclomaticComplexity The method 'processAgentTask(int, Ticket, HttpServletRequest, TaskNotifyWaitingTicketConfig)' has a cyclomatic complexity of 10. 159232

fr/paris/lutece/plugins/workflow/modules/ticketing/service/task/TaskQualifyTicket.java

Rule Violation Ligne
ShortVariable Avoid variables with short names like sb 59

fr/paris/lutece/plugins/workflow/modules/ticketing/service/task/TaskReassignTicketToUnitForAUserNotAvailable.java

Rule Violation Ligne
ImmutableField Private field '_ticketReassignUnitResourceService' could be made final; it is only initialized in the declaration or constructor. 79
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the dao field if you want a default access modifier 81
DefaultPackage Use explicit scoping instead of the default package private level 81
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 125128
CompareObjectsWithEquals Use equals() to compare object references. 144

fr/paris/lutece/plugins/workflow/modules/ticketing/service/task/TaskRemoveSignalementTicket.java

Rule Violation Ligne
ShortVariable Avoid variables with short names like sb 59

fr/paris/lutece/plugins/workflow/modules/ticketing/service/task/TaskRemoveVspTicket.java

Rule Violation Ligne
ShortVariable Avoid variables with short names like sb 59

fr/paris/lutece/plugins/workflow/modules/ticketing/service/task/TaskReply.java

Rule Violation Ligne
UseLocaleWithCaseConversions When doing a String.toLowerCase()/toUpperCase() call, use a Locale 129
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 179
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 192

fr/paris/lutece/plugins/workflow/modules/ticketing/service/task/TaskReplyAssignUpTicket.java

Rule Violation Ligne
CyclomaticComplexity The method 'processTicketingTask(int, HttpServletRequest, Locale)' has a cyclomatic complexity of 14. 83162
NPathComplexity The method 'processTicketingTask(int, HttpServletRequest, Locale)' has an NPath complexity of 530 83162
ConfusingTernary Avoid if (x != y) ..; else ..; 109153
ConfusingTernary Avoid if (x != y) ..; else ..; 122137
ConfusingTernary Avoid if (x != y) ..; else ..; 145
ConfusingTernary Avoid if (x != y) ..; else ..; 146147
ConfusingTernary Avoid if (x != y) ..; else ..; 148
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 194
ConfusingTernary Avoid if (x != y) ..; else ..; 230

fr/paris/lutece/plugins/workflow/modules/ticketing/service/task/TaskSelectChannel.java

Rule Violation Ligne
ConfusingTernary Avoid if (x != y) ..; else ..; 8391

fr/paris/lutece/plugins/workflow/modules/ticketing/service/task/TaskSignalementTicket.java

Rule Violation Ligne
ShortVariable Avoid variables with short names like sb 59

fr/paris/lutece/plugins/workflow/modules/ticketing/service/task/TaskSphinx.java

Rule Violation Ligne
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 68

fr/paris/lutece/plugins/workflow/modules/ticketing/service/task/TaskTicketEmailExternalUser.java

Rule Violation Ligne
ImmutableField Private field '_externalUserDAO' could be made final; it is only initialized in the declaration or constructor. 108
UnusedFormalParameter Avoid unused method parameters such as 'locale'. 159
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 188208
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 215222
UnusedFormalParameter Avoid unused method parameters such as 'locale'. 240
UnusedFormalParameter Avoid unused method parameters such as 'config'. 241
UnusedFormalParameter Avoid unused method parameters such as 'locale'. 281
UnusedFormalParameter Avoid unused method parameters such as 'config'. 282

fr/paris/lutece/plugins/workflow/modules/ticketing/service/task/TaskVspTicket.java

Rule Violation Ligne
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 83

fr/paris/lutece/plugins/workflow/modules/ticketing/service/ticket/EditableTicketService.java

Rule Violation Ligne
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 260264

fr/paris/lutece/plugins/workflow/modules/ticketing/utils/UtilConstants.java

Rule Violation Ligne
CommentRequired Header comments are required 3644
FieldDeclarationsShouldBeAtStartOfClass Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 43

fr/paris/lutece/plugins/workflow/modules/ticketing/utils/WorkflowTicketingUtils.java

Rule Violation Ligne
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 113
ConfusingTernary Avoid if (x != y) ..; else ..; 138150
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 171
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 171
UnnecessaryLocalBeforeReturn Consider simply returning the value vs storing it in local variable 'formatedErrors' 179

fr/paris/lutece/plugins/workflow/modules/ticketing/web/EditTicketXPage.java

Rule Violation Ligne
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 34375
ImmutableField Private field '_editableTicketService' could be made final; it is only initialized in the declaration or constructor. 121
ImmutableField Private field '_ticketFormService' could be made final; it is only initialized in the declaration or constructor. 122
ConfusingTernary Avoid if (x != y) ..; else ..; 185220
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 201
ConfusingTernary Avoid if (x != y) ..; else ..; 213220
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 249

fr/paris/lutece/plugins/workflow/modules/ticketing/web/ModifyTicketCategoryJspBean.java

Rule Violation Ligne
CommentRequired Header comments are required 57105

fr/paris/lutece/plugins/workflow/modules/ticketing/web/TicketExternalUserResponseJspBean.java

Rule Violation Ligne
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 34384
ImmutableField Private field '_ticketEmailExternalUserHistoryDAO' could be made final; it is only initialized in the declaration or constructor. 135
ImmutableField Private field '_ticketEmailExternalUserMessageDAO' could be made final; it is only initialized in the declaration or constructor. 136
ImmutableField Private field '_taskTicketExternalUserConfigService' could be made final; it is only initialized in the declaration or constructor. 137
ImmutableField Private field '_resourceHistoryService' could be made final; it is only initialized in the declaration or constructor. 138
CommentRequired Public method and constructor comments are required 152155
ExcessiveMethodLength Avoid really long methods. 165302
NPathComplexity The method 'getExternalUserResponseView(HttpServletRequest)' has an NPath complexity of 2616 165302
NcssCount The method 'getExternalUserResponseView(HttpServletRequest)' has a NCSS line count of 71. 165302
CyclomaticComplexity The method 'getExternalUserResponseView(HttpServletRequest)' has a cyclomatic complexity of 16. 165302
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 180
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 181
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 182
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 182
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 183
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 212
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 255
AvoidCatchingNPE Avoid catching NullPointerException; consider removing the cause of the NPE. 255
CommentRequired Protected method constructor comments are required 304312
ConfusingTernary Avoid if (x != y) ..; else ..; 322330
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 332
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 344

fr/paris/lutece/plugins/workflow/modules/ticketing/web/task/AssignTicketToUnitTaskComponent.java

Rule Violation Ligne
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 89
ConfusingTernary Avoid if (x != y) ..; else ..; 94105
ConfusingTernary Avoid if (x != y) ..; else ..; 157

fr/paris/lutece/plugins/workflow/modules/ticketing/web/task/AssignTicketToUserTaskComponent.java

Rule Violation Ligne
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 9295

fr/paris/lutece/plugins/workflow/modules/ticketing/web/task/AssignUpTicketTaskComponent.java

Rule Violation Ligne
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 87
ConfusingTernary Avoid if (x != y) ..; else ..; 91102
ConfusingTernary Avoid if (x != y) ..; else ..; 164

fr/paris/lutece/plugins/workflow/modules/ticketing/web/task/EditTicketTaskComponent.java

Rule Violation Ligne
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 106
ConfusingTernary Avoid if (x != y) ..; else ..; 113120
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 172
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 237

fr/paris/lutece/plugins/workflow/modules/ticketing/web/task/MarkAsUnreadTaskComponent.java

Rule Violation Ligne
CommentRequired Header comments are required 54126
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 75

fr/paris/lutece/plugins/workflow/modules/ticketing/web/task/ModifyTicketCategoryTaskComponent.java

Rule Violation Ligne
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 34326
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 113
CyclomaticComplexity The method 'doValidateTask(int, String, HttpServletRequest, Locale, ITask)' has a cyclomatic complexity of 20. 189278
NPathComplexity The method 'doValidateTask(int, String, HttpServletRequest, Locale, ITask)' has an NPath complexity of 1300 189278
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 220224
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 229246
InefficientEmptyStringCheck String.trim().length() == 0 / String.trim().isEmpty() is an inefficient way to validate a blank String. 231
InefficientEmptyStringCheck String.trim().length() == 0 / String.trim().isEmpty() is an inefficient way to validate a blank String. 286
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 308
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 313

fr/paris/lutece/plugins/workflow/modules/ticketing/web/task/ModifyTicketNomenclatureTaskComponent.java

Rule Violation Ligne
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 79

fr/paris/lutece/plugins/workflow/modules/ticketing/web/task/ModifyTicketTaskComponent.java

Rule Violation Ligne
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 34215
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 180

fr/paris/lutece/plugins/workflow/modules/ticketing/web/task/NotifyWaitingTicketTaskComponent.java

Rule Violation Ligne
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 34392
CommentRequired Header comments are required 72392
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 133
ConfusingTernary Avoid if (x != y) ..; else ..; 146169
CyclomaticComplexity The method 'getDisplayTaskInformation(int, HttpServletRequest, Locale, ITask)' has a cyclomatic complexity of 13. 255357
ExcessiveMethodLength Avoid really long methods. 255357
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 265
ShortVariable Avoid variables with short names like sb 270
ConfusingTernary Avoid if (x != y) ..; else ..; 273339
ConfusingTernary Avoid if (x != y) ..; else ..; 285297
ConfusingTernary Avoid if (x != y) ..; else ..; 299318
InefficientEmptyStringCheck String.trim().length() == 0 / String.trim().isEmpty() is an inefficient way to validate a blank String. 342
AppendCharacterWithChar Avoid appending characters as strings in StringBuffer.append. 345

fr/paris/lutece/plugins/workflow/modules/ticketing/web/task/ReplyTaskComponent.java

Rule Violation Ligne
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 93
ConfusingTernary Avoid if (x != y) ..; else ..; 97106

fr/paris/lutece/plugins/workflow/modules/ticketing/web/task/TicketEmailExternalUserTaskComponent.java

Rule Violation Ligne
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 34515
UnusedPrivateField Avoid unused private fields such as '_taskTicketConfigService'. 136
UnusedPrivateField Avoid unused private fields such as '_actionService'. 156
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 185
ConfusingTernary Avoid if (x != y) ..; else ..; 187
ConfusingTernary Avoid if (x != y) ..; else ..; 217
CyclomaticComplexity The method 'getDisplayTaskForm(int, String, HttpServletRequest, Locale, ITask)' has a cyclomatic complexity of 15. 230301
ConfusingTernary Avoid if (x != y) ..; else ..; 263
ConfusingTernary Avoid if (x != y) ..; else ..; 265
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 277
ConfusingTernary Avoid if (x != y) ..; else ..; 296
CyclomaticComplexity The method 'doValidateTask(int, String, HttpServletRequest, Locale, ITask)' has a cyclomatic complexity of 15. 332404
NPathComplexity The method 'doValidateTask(int, String, HttpServletRequest, Locale, ITask)' has an NPath complexity of 315 332404
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 340341
UnusedLocalVariable Avoid unused local variables such as 'strEmailSubject'. 340
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 364
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 378
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 412
ConfusingTernary Avoid if (x != y) ..; else ..; 422445

fr/paris/lutece/plugins/workflow/modules/ticketing/web/task/TicketingCommentTaskComponent.java

Rule Violation Ligne
CommentRequired Header comments are required 63149
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the taskComponent field if you want a default access modifier 69
DefaultPackage Use explicit scoping instead of the default package private level 69
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 134

fr/paris/lutece/plugins/workflow/modules/ticketing/web/task/TicketingTaskComponent.java

Rule Violation Ligne
CommentRequired Public method and constructor comments are required 102105
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 151
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 164
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 164

Priority 4

fr/paris/lutece/plugins/workflow/modules/ticketing/business/email/message/TicketEmailExternalUserMessage.java

Rule Violation Ligne
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 170173

fr/paris/lutece/plugins/workflow/modules/ticketing/business/resourcehistory/ResourceHistoryService.java

Rule Violation Ligne
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'fr.paris.lutece.plugins.workflow.modules.ticketing.business.resourcehistory.ResourceHistory' due to existing same package import 'fr.paris.lutece.plugins.workflow.modules.ticketing.business.resourcehistory.*' 121
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'fr.paris.lutece.plugins.workflow.modules.ticketing.business.resourcehistory.ResourceHistory' due to existing same package import 'fr.paris.lutece.plugins.workflow.modules.ticketing.business.resourcehistory.*' 151

fr/paris/lutece/plugins/workflow/modules/ticketing/service/daemon/TicketAnonymisationDaemon.java

Rule Violation Ligne
UseVarargs Consider using varargs for methods or constructors which take an array the last parameter. 709

fr/paris/lutece/plugins/workflow/modules/ticketing/service/task/TaskVspTicket.java

Rule Violation Ligne
UseVarargs Consider using varargs for methods or constructors which take an array the last parameter. 121

Fichiers

fr/paris/lutece/plugins/workflow/modules/ticketing/business/anonymisation/AnonymisationDAO.java

Rule Violation Priority Ligne
CommentRequired Header comments are required 3 44188
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 60
InefficientStringBuffering Avoid concatenating nonliterals in a StringBuffer/StringBuilder constructor or append(). 3 91

fr/paris/lutece/plugins/workflow/modules/ticketing/business/anonymisation/IAnonymisationDAO.java

Rule Violation Priority Ligne
CommentRequired Header comments are required 3 41113

fr/paris/lutece/plugins/workflow/modules/ticketing/business/config/MessageDirection.java

Rule Violation Priority Ligne
FieldNamingConventions The static field name 'mapMessageDirection' doesn't match '_[a-z][a-zA-Z0-9]*' 1 54
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 54
UseLocaleWithCaseConversions When doing a String.toLowerCase()/toUpperCase() call, use a Locale 3 85

fr/paris/lutece/plugins/workflow/modules/ticketing/business/config/TaskAssignTicketToUnitConfigDAO.java

Rule Violation Priority Ligne
CommentRequired Header comments are required 3 41131
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 3 5568

fr/paris/lutece/plugins/workflow/modules/ticketing/business/config/TaskEditTicketConfig.java

Rule Violation Priority Ligne
UnusedPrivateField Avoid unused private fields such as '_nIdStateAfterEdition'. 3 53

fr/paris/lutece/plugins/workflow/modules/ticketing/business/config/TaskEditTicketConfigDAO.java

Rule Violation Priority Ligne
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 3 6072

fr/paris/lutece/plugins/workflow/modules/ticketing/business/config/TaskMarkAsUnreadConfig.java

Rule Violation Priority Ligne
CommentRequired Header comments are required 3 4167

fr/paris/lutece/plugins/workflow/modules/ticketing/business/config/TaskMarkAsUnreadConfigDAO.java

Rule Violation Priority Ligne
CommentRequired Header comments are required 3 45153
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 3 5970

fr/paris/lutece/plugins/workflow/modules/ticketing/business/config/TaskModifyTicketCategoryConfig.java

Rule Violation Priority Ligne
FormalParameterNamingConventions The method parameter name '_nSelectedEntry' doesn't match '[a-z][a-zA-Z0-9]*' 1 69

fr/paris/lutece/plugins/workflow/modules/ticketing/business/config/TaskModifyTicketCategoryConfigDAO.java

Rule Violation Priority Ligne
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 3 5581
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 3 121128

fr/paris/lutece/plugins/workflow/modules/ticketing/business/config/TaskNotifyWaitingTicketConfig.java

Rule Violation Priority Ligne
CommentRequired Header comments are required 3 41124
CommentRequired Public method and constructor comments are required 3 115118
CommentRequired Public method and constructor comments are required 3 120123

fr/paris/lutece/plugins/workflow/modules/ticketing/business/config/TaskNotifyWaitingTicketConfigDAO.java

Rule Violation Priority Ligne
CommentRequired Header comments are required 3 43183

fr/paris/lutece/plugins/workflow/modules/ticketing/business/config/TaskReplyConfig.java

Rule Violation Priority Ligne
FormalParameterNamingConventions The method parameter name '_bCloseTicket' doesn't match '[a-z][a-zA-Z0-9]*' 1 84

fr/paris/lutece/plugins/workflow/modules/ticketing/business/email/cc/TicketEmailExternalUserCcDAO.java

Rule Violation Priority Ligne
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 3 8398

fr/paris/lutece/plugins/workflow/modules/ticketing/business/email/config/MessageDirectionExternalUser.java

Rule Violation Priority Ligne
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 55
UseLocaleWithCaseConversions When doing a String.toLowerCase()/toUpperCase() call, use a Locale 3 86

fr/paris/lutece/plugins/workflow/modules/ticketing/business/email/config/TaskTicketEmailExternalUserConfig.java

Rule Violation Priority Ligne
CommentRequired Public method and constructor comments are required 3 117120
CommentRequired Public method and constructor comments are required 3 122125

fr/paris/lutece/plugins/workflow/modules/ticketing/business/email/config/TaskTicketEmailExternalUserConfigDAO.java

Rule Violation Priority Ligne
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 3 5694

fr/paris/lutece/plugins/workflow/modules/ticketing/business/email/history/TicketEmailExternalUserHistoryDAO.java

Rule Violation Priority Ligne
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 3 6274

fr/paris/lutece/plugins/workflow/modules/ticketing/business/email/message/ITicketEmailExternalUserMessageDAO.java

Rule Violation Priority Ligne
UnnecessaryModifier Unnecessary modifier 'public' on method 'closeMessagesByIdTicket': the method is declared in an interface type 3 85
CommentRequired Public method and constructor comments are required 3 140
ShortVariable Avoid variables with short names like id 3 140
CommentRequired Public method and constructor comments are required 3 142
CommentRequired Public method and constructor comments are required 3 144

fr/paris/lutece/plugins/workflow/modules/ticketing/business/email/message/TicketEmailExternalUserMessage.java

Rule Violation Priority Ligne
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 4 170173
CommentRequired Public method and constructor comments are required 3 184187
CommentRequired Public method and constructor comments are required 3 189192

fr/paris/lutece/plugins/workflow/modules/ticketing/business/email/message/TicketEmailExternalUserMessageDAO.java

Rule Violation Priority Ligne
TooManyMethods This class has too many methods, consider refactoring it. 3 52415
AvoidDuplicateLiterals The String literal "workflow.transactionManager" appears 4 times in this file; the first occurrence is on line 122 3 122
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 3 123140
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 3 158171
ShortVariable Avoid variables with short names like id 3 366
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 384

fr/paris/lutece/plugins/workflow/modules/ticketing/business/email/provider/TicketEmailExternalUserConstants.java

Rule Violation Priority Ligne
ClassNamingConventions The utility class name 'TicketEmailExternalUserConstants' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' 1 3985

fr/paris/lutece/plugins/workflow/modules/ticketing/business/email/provider/TicketEmailExternalUserProvider.java

Rule Violation Priority Ligne
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 3 34432
TooManyMethods This class has too many methods, consider refactoring it. 3 73432
ImmutableField Private field '_ticketEmailExternalUserHistoryDAO' could be made final; it is only initialized in the declaration or constructor. 3 100
ImmutableField Private field '_ticketEmailExternalUserDemandDAO' could be made final; it is only initialized in the declaration or constructor. 3 104
ImmutableField Private field '_ticket' could be made final; it is only initialized in the declaration or constructor. 3 107
SimpleDateFormatNeedsLocale When instantiating a SimpleDateFormat object, specify a Locale 3 110
DefaultPackage Use explicit scoping instead of the default package private level 3 110
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the _dateFormater field if you want a default access modifier 3 110
ConfusingTernary Avoid if (x != y) ..; else ..; 3 296307
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 3 421428

fr/paris/lutece/plugins/workflow/modules/ticketing/business/email/recipient/TicketEmailExternalUserRecipientDAO.java

Rule Violation Priority Ligne
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 3 8199

fr/paris/lutece/plugins/workflow/modules/ticketing/business/externaluser/ExternalUserComparator.java

Rule Violation Priority Ligne
ShortVariable Avoid variables with short names like o2 3 55
ShortVariable Avoid variables with short names like o1 3 55
ShortVariable Avoid variables with short names like c 3 93
CyclomaticComplexity The method 'compareAlphaNumeric(String, String, int)' has a cyclomatic complexity of 15. 3 142226
NPathComplexity The method 'compareAlphaNumeric(String, String, int)' has an NPath complexity of 256 3 142226

fr/paris/lutece/plugins/workflow/modules/ticketing/business/externaluser/ExternalUserDAO.java

Rule Violation Priority Ligne
CyclomaticComplexity The method 'findExternalUser(String, String, String, String, String)' has a cyclomatic complexity of 14. 3 126208
NPathComplexity The method 'findExternalUser(String, String, String, String, String)' has an NPath complexity of 4656 3 126208
UseObjectForClearerAPI Rather than using a lot of String arguments, consider using a container object for those values. 3 126

fr/paris/lutece/plugins/workflow/modules/ticketing/business/externaluser/IExternalUserDAO.java

Rule Violation Priority Ligne
UseObjectForClearerAPI Rather than using a lot of String arguments, consider using a container object for those values. 3 78

fr/paris/lutece/plugins/workflow/modules/ticketing/business/externaluser/search/ExternalUserEmailValidationServlet.java

Rule Violation Priority Ligne
FieldNamingConventions The final field name '_externalUserDAO' doesn't match '[a-z][a-zA-Z0-9]*' 1 87
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 112
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 3 131
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 3 150

fr/paris/lutece/plugins/workflow/modules/ticketing/business/externaluser/search/ExternalUserSearchServlet.java

Rule Violation Priority Ligne
FieldNamingConventions The final field name '_externalUserDAO' doesn't match '[a-z][a-zA-Z0-9]*' 1 107
FieldNamingConventions The constant name '_attributeService' doesn't match '[A-Z][A-Z_0-9]*' 1 110
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 144

fr/paris/lutece/plugins/workflow/modules/ticketing/business/information/TaskInformationDAO.java

Rule Violation Priority Ligne
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 3 5969

fr/paris/lutece/plugins/workflow/modules/ticketing/business/resourcehistory/ResourceHistoryDAO.java

Rule Violation Priority Ligne
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 3 62102

fr/paris/lutece/plugins/workflow/modules/ticketing/business/resourcehistory/ResourceHistoryService.java

Rule Violation Priority Ligne
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 114
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'fr.paris.lutece.plugins.workflow.modules.ticketing.business.resourcehistory.ResourceHistory' due to existing same package import 'fr.paris.lutece.plugins.workflow.modules.ticketing.business.resourcehistory.*' 4 121
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'fr.paris.lutece.plugins.workflow.modules.ticketing.business.resourcehistory.ResourceHistory' due to existing same package import 'fr.paris.lutece.plugins.workflow.modules.ticketing.business.resourcehistory.*' 4 151

fr/paris/lutece/plugins/workflow/modules/ticketing/business/ticket/EditableTicketDAO.java

Rule Violation Priority Ligne
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 3 6780

fr/paris/lutece/plugins/workflow/modules/ticketing/business/ticket/EditableTicketFieldDAO.java

Rule Violation Priority Ligne
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 3 5970

fr/paris/lutece/plugins/workflow/modules/ticketing/service/WorkflowTicketingPlugin.java

Rule Violation Priority Ligne
UncommentedEmptyMethodBody Document empty method body 3 6162

fr/paris/lutece/plugins/workflow/modules/ticketing/service/assignment/AutomaticAssignmentAgentParisFamilleService.java

Rule Violation Priority Ligne
UnnecessaryConstructor Avoid unnecessary constructors - the compiler will generate these for you 3 7073
ConfusingTernary Avoid if (x != y) ..; else ..; 3 143151

fr/paris/lutece/plugins/workflow/modules/ticketing/service/daemon/NotifyDaemon.java

Rule Violation Priority Ligne
CommentRequired Header comments are required 3 57473
FieldNamingConventions The constant name '_resourceHistoryService' doesn't match '[A-Z][A-Z_0-9]*' 1 62
ImmutableField Private field 'nIdWorkflow' could be made final; it is only initialized in the declaration or constructor. 3 64
FieldNamingConventions The field name 'nIdWorkflow' doesn't match '_[a-z][a-zA-Z0-9]*' 1 64
FieldNamingConventions The field name 'isMinuteMode' doesn't match '_[a-z][a-zA-Z0-9]*' 1 67
LinguisticNaming Linguistics Antipattern - The field 'isMinuteMode' indicates linguistically it is a boolean, but it is 'int' 3 67
ImmutableField Private field 'isMinuteMode' could be made final; it is only initialized in the declaration or constructor. 3 67
ImmutableField Private field 'nIdStateWaiting' could be made final; it is only initialized in the declaration or constructor. 3 71
FieldNamingConventions The field name 'nIdStateWaiting' doesn't match '_[a-z][a-zA-Z0-9]*' 1 71
FieldNamingConventions The field name 'nIdActionRelance' doesn't match '_[a-z][a-zA-Z0-9]*' 1 76
ImmutableField Private field 'nIdActionRelance' could be made final; it is only initialized in the declaration or constructor. 3 76
ImmutableField Private field 'nIdActionSolliciterFromTerrainNiv2' could be made final; it is only initialized in the declaration or constructor. 3 82
FieldNamingConventions The field name 'nIdActionSolliciterFromTerrainNiv2' doesn't match '_[a-z][a-zA-Z0-9]*' 1 82
ImmutableField Private field 'nIdActionSolliciterFromTerrainNiv3' could be made final; it is only initialized in the declaration or constructor. 3 85
FieldNamingConventions The field name 'nIdActionSolliciterFromTerrainNiv3' doesn't match '_[a-z][a-zA-Z0-9]*' 1 85
FieldNamingConventions The field name 'nIdActionSolliciterFromContribNiv2' doesn't match '_[a-z][a-zA-Z0-9]*' 1 88
ImmutableField Private field 'nIdActionSolliciterFromContribNiv2' could be made final; it is only initialized in the declaration or constructor. 3 88
FieldNamingConventions The field name 'nIdActionSolliciterFromContribNiv3' doesn't match '_[a-z][a-zA-Z0-9]*' 1 91
ImmutableField Private field 'nIdActionSolliciterFromContribNiv3' could be made final; it is only initialized in the declaration or constructor. 3 91
FieldNamingConventions The field name 'nIdActionRetourFromTerrainNiv2' doesn't match '_[a-z][a-zA-Z0-9]*' 1 98
ImmutableField Private field 'nIdActionRetourFromTerrainNiv2' could be made final; it is only initialized in the declaration or constructor. 3 98
FieldNamingConventions The field name 'nIdActionRetourFromTerrainNiv3' doesn't match '_[a-z][a-zA-Z0-9]*' 1 101
ImmutableField Private field 'nIdActionRetourFromTerrainNiv3' could be made final; it is only initialized in the declaration or constructor. 3 101
FieldNamingConventions The field name 'nIdActionRetourFromContribNiv2' doesn't match '_[a-z][a-zA-Z0-9]*' 1 104
ImmutableField Private field 'nIdActionRetourFromContribNiv2' could be made final; it is only initialized in the declaration or constructor. 3 104
ImmutableField Private field 'nIdActionRetourFromContribNiv3' could be made final; it is only initialized in the declaration or constructor. 3 107
FieldNamingConventions The field name 'nIdActionRetourFromContribNiv3' doesn't match '_[a-z][a-zA-Z0-9]*' 1 107
FieldNamingConventions The field name 'nbRelanceMax' doesn't match '_[a-z][a-zA-Z0-9]*' 1 111
ImmutableField Private field 'nbRelanceMax' could be made final; it is only initialized in the declaration or constructor. 3 111
FieldNamingConventions The field name 'nFrequence' doesn't match '_[a-z][a-zA-Z0-9]*' 1 113
ImmutableField Private field 'nFrequence' could be made final; it is only initialized in the declaration or constructor. 3 113
ExcessiveMethodLength Avoid really long methods. 3 121230
CyclomaticComplexity The method 'processNotification()' has a cyclomatic complexity of 18. 3 121230
InsufficientStringBufferDeclaration StringBuffer constructor is initialized with size 16, but has at least 144 characters appended. 3 123
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 132
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 134
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 135
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 199
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 222223
ConsecutiveLiteralAppends StringBuffer (or StringBuilder).append is called 2 consecutive times with literals. Use a single append with a single combined String. 3 223
ConsecutiveLiteralAppends StringBuffer (or StringBuilder).append is called 2 consecutive times with literals. Use a single append with a single combined String. 3 224
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 224
CyclomaticComplexity The method 'isConfParamOK(StringBuilder)' has a cyclomatic complexity of 15. 3 239272
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 3 263
UnusedPrivateMethod Avoid unused private methods such as 'processRelanceNoDate(Ticket,Date)'. 3 282
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 3 424
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 3 458467

fr/paris/lutece/plugins/workflow/modules/ticketing/service/daemon/NotifyLevel3Daemon.java

Rule Violation Priority Ligne
CommentRequired Header comments are required 3 59399
FieldNamingConventions The constant name '_resourceHistoryService' doesn't match '[A-Z][A-Z_0-9]*' 1 64
FieldNamingConventions The field name 'nIdWorkflow' doesn't match '_[a-z][a-zA-Z0-9]*' 1 66
ImmutableField Private field 'nIdWorkflow' could be made final; it is only initialized in the declaration or constructor. 3 66
LinguisticNaming Linguistics Antipattern - The field 'isMinuteMode' indicates linguistically it is a boolean, but it is 'int' 3 68
FieldNamingConventions The field name 'isMinuteMode' doesn't match '_[a-z][a-zA-Z0-9]*' 1 68
ImmutableField Private field 'isMinuteMode' could be made final; it is only initialized in the declaration or constructor. 3 68
FieldNamingConventions The field name 'nIdStateLevel3' doesn't match '_[a-z][a-zA-Z0-9]*' 1 73
ImmutableField Private field 'nIdStateLevel3' could be made final; it is only initialized in the declaration or constructor. 3 73
ImmutableField Private field 'nIdActionRelance' could be made final; it is only initialized in the declaration or constructor. 3 78
FieldNamingConventions The field name 'nIdActionRelance' doesn't match '_[a-z][a-zA-Z0-9]*' 1 78
ImmutableField Private field 'nIdActionEscaladerNiveau3' could be made final; it is only initialized in the declaration or constructor. 3 84
FieldNamingConventions The field name 'nIdActionEscaladerNiveau3' doesn't match '_[a-z][a-zA-Z0-9]*' 1 84
FieldNamingConventions The field name 'nIdActionReturnATraiter' doesn't match '_[a-z][a-zA-Z0-9]*' 1 90
ImmutableField Private field 'nIdActionReturnATraiter' could be made final; it is only initialized in the declaration or constructor. 3 90
ImmutableField Private field 'nbRelanceMax' could be made final; it is only initialized in the declaration or constructor. 3 94
FieldNamingConventions The field name 'nbRelanceMax' doesn't match '_[a-z][a-zA-Z0-9]*' 1 94
ImmutableField Private field 'nFrequence' could be made final; it is only initialized in the declaration or constructor. 3 96
FieldNamingConventions The field name 'nFrequence' doesn't match '_[a-z][a-zA-Z0-9]*' 1 96
ExcessiveMethodLength Avoid really long methods. 3 104210
CyclomaticComplexity The method 'processNotification()' has a cyclomatic complexity of 15. 3 104210
InsufficientStringBufferDeclaration StringBuffer constructor is initialized with size 16, but has at least 127 characters appended. 3 106
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 115
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 117
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 118
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 179
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 202203
ConsecutiveLiteralAppends StringBuffer (or StringBuilder).append is called 2 consecutive times with literals. Use a single append with a single combined String. 3 203
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 204
ConsecutiveLiteralAppends StringBuffer (or StringBuilder).append is called 2 consecutive times with literals. Use a single append with a single combined String. 3 204
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 3 241
UnusedPrivateMethod Avoid unused private methods such as 'processRelanceNoDate(Ticket,Date)'. 3 260
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 3 310
AssignmentInOperand Avoid assignments in operands 3 385

fr/paris/lutece/plugins/workflow/modules/ticketing/service/daemon/NotifyUsagerDaemon.java

Rule Violation Priority Ligne
CommentRequired Header comments are required 3 57387
FieldNamingConventions The constant name '_resourceHistoryService' doesn't match '[A-Z][A-Z_0-9]*' 1 62
FieldNamingConventions The field name 'nIdWorkflow' doesn't match '_[a-z][a-zA-Z0-9]*' 1 64
ImmutableField Private field 'nIdWorkflow' could be made final; it is only initialized in the declaration or constructor. 3 64
LinguisticNaming Linguistics Antipattern - The field 'isMinuteMode' indicates linguistically it is a boolean, but it is 'int' 3 66
ImmutableField Private field 'isMinuteMode' could be made final; it is only initialized in the declaration or constructor. 3 66
FieldNamingConventions The field name 'isMinuteMode' doesn't match '_[a-z][a-zA-Z0-9]*' 1 66
ImmutableField Private field 'nIdStateWaitingUsager' could be made final; it is only initialized in the declaration or constructor. 3 71
FieldNamingConventions The field name 'nIdStateWaitingUsager' doesn't match '_[a-z][a-zA-Z0-9]*' 1 71
ImmutableField Private field 'nIdActionRelance' could be made final; it is only initialized in the declaration or constructor. 3 77
FieldNamingConventions The field name 'nIdActionRelance' doesn't match '_[a-z][a-zA-Z0-9]*' 1 77
FieldNamingConventions The field name 'nIdActionDemandeComplementUsager' doesn't match '_[a-z][a-zA-Z0-9]*' 1 83
ImmutableField Private field 'nIdActionDemandeComplementUsager' could be made final; it is only initialized in the declaration or constructor. 3 83
FieldNamingConventions The field name 'nIdActionRetourFromDemandeComplementUsager' doesn't match '_[a-z][a-zA-Z0-9]*' 1 90
ImmutableField Private field 'nIdActionRetourFromDemandeComplementUsager' could be made final; it is only initialized in the declaration or constructor. 3 90
ImmutableField Private field 'nbRelanceMax' could be made final; it is only initialized in the declaration or constructor. 3 94
FieldNamingConventions The field name 'nbRelanceMax' doesn't match '_[a-z][a-zA-Z0-9]*' 1 94
FieldNamingConventions The field name 'nFrequence' doesn't match '_[a-z][a-zA-Z0-9]*' 1 96
ImmutableField Private field 'nFrequence' could be made final; it is only initialized in the declaration or constructor. 3 96
ExcessiveMethodLength Avoid really long methods. 3 104210
CyclomaticComplexity The method 'processNotification()' has a cyclomatic complexity of 15. 3 104210
InsufficientStringBufferDeclaration StringBuffer constructor is initialized with size 16, but has at least 158 characters appended. 3 106
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 115
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 117
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 118
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 179
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 202203
ConsecutiveLiteralAppends StringBuffer (or StringBuilder).append is called 2 consecutive times with literals. Use a single append with a single combined String. 3 203
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 204
ConsecutiveLiteralAppends StringBuffer (or StringBuilder).append is called 2 consecutive times with literals. Use a single append with a single combined String. 3 204
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 3 242
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 3 339
AssignmentInOperand Avoid assignments in operands 3 373

fr/paris/lutece/plugins/workflow/modules/ticketing/service/daemon/TicketAnonymisationDaemon.java

Rule Violation Priority Ligne
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 3 34855
GodClass Possible God Class (WMC=92, ATFD=78, TCC=9.677%) 3 81855
CyclomaticComplexity The class 'TicketAnonymisationDaemon' has a total cyclomatic complexity of 92 (highest 8). 3 81855
TooManyMethods This class has too many methods, consider refactoring it. 3 82855
FieldNamingConventions The static field name 'dao' doesn't match '_[a-z][a-zA-Z0-9]*' 1 88
FieldNamingConventions The static field name 'daoTaskInfo' doesn't match '_[a-z][a-zA-Z0-9]*' 1 89
FieldNamingConventions The static field name 'daoResourceHist' doesn't match '_[a-z][a-zA-Z0-9]*' 1 90
FieldNamingConventions The static field name 'daoEditableTicketHist' doesn't match '_[a-z][a-zA-Z0-9]*' 1 91
FieldNamingConventions The static field name 'daoAnonymisation' doesn't match '_[a-z][a-zA-Z0-9]*' 1 92
FieldNamingConventions The final field name '_stockageS3DaemonMinio' doesn't match '[a-z][a-zA-Z0-9]*' 1 94
FieldNamingConventions The final field name '_stockageS3DaemonNetapp' doesn't match '[a-z][a-zA-Z0-9]*' 1 95
FieldNamingConventions The static field name 'plugin' doesn't match '_[a-z][a-zA-Z0-9]*' 1 97
CommentRequired Public method and constructor comments are required 3 105108
UnnecessaryConstructor Avoid unnecessary constructors - the compiler will generate these for you 3 105108
ShortVariable Avoid variables with short names like sb 3 116
ShortVariable Avoid variables with short names like sb 3 130
ShortVariable Avoid variables with short names like sb 3 153
ConfusingTernary Avoid if (x != y) ..; else ..; 3 158160
ConfusingTernary Avoid if (x != y) ..; else ..; 3 173219
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 206
ShortVariable Avoid variables with short names like sb 3 237
SimpleDateFormatNeedsLocale When instantiating a SimpleDateFormat object, specify a Locale 3 240
ShortVariable Avoid variables with short names like pj 3 294
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 3 295
ShortVariable Avoid variables with short names like sb 3 315
ConfusingTernary Avoid if (x != y) ..; else ..; 3 419435
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 440
ShortVariable Avoid variables with short names like pj 3 443
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 530
ConfusingTernary Avoid if (x != y) ..; else ..; 3 539546
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 3 656
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 3 658677
UseVarargs Consider using varargs for methods or constructors which take an array the last parameter. 4 709
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 3 712
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 3 714720
InefficientEmptyStringCheck String.trim().length() == 0 / String.trim().isEmpty() is an inefficient way to validate a blank String. 3 738
InefficientEmptyStringCheck String.trim().length() == 0 / String.trim().isEmpty() is an inefficient way to validate a blank String. 3 757
InefficientEmptyStringCheck String.trim().length() == 0 / String.trim().isEmpty() is an inefficient way to validate a blank String. 3 778
AvoidReassigningParameters Avoid reassigning parameters such as 'messageToSanitize' 2 811
AvoidReassigningParameters Avoid reassigning parameters such as 'messageToSanitize' 2 811
AvoidReassigningParameters Avoid reassigning parameters such as 'messageToSanitize' 2 811
AvoidReassigningParameters Avoid reassigning parameters such as 'messageToSanitize' 2 811
AvoidReassigningParameters Avoid reassigning parameters such as 'messageToSanitize' 2 811
AvoidReassigningParameters Avoid reassigning parameters such as 'messageToSanitize' 2 811
AvoidReassigningParameters Avoid reassigning parameters such as 'messageToSanitize' 2 811
AvoidReassigningParameters Avoid reassigning parameters such as 'messageToSanitize' 2 811
AvoidDuplicateLiterals The String literal "(?i)" appears 6 times in this file; the first occurrence is on line 813 3 813
AvoidReassigningParameters Avoid reassigning parameters such as 'str' 2 832
AvoidReassigningParameters Avoid reassigning parameters such as 'str' 2 832
AvoidReassigningParameters Avoid reassigning parameters such as 'str' 2 832
AvoidReassigningParameters Avoid reassigning parameters such as 'str' 2 832
AvoidReassigningParameters Avoid reassigning parameters such as 'str' 2 832
AvoidReassigningParameters Avoid reassigning parameters such as 'str' 2 832
AvoidReassigningParameters Avoid reassigning parameters such as 'str' 2 832
AvoidReassigningParameters Avoid reassigning parameters such as 'str' 2 832
AvoidReassigningParameters Avoid reassigning parameters such as 'str' 2 832
AvoidReassigningParameters Avoid reassigning parameters such as 'str' 2 832
AvoidReassigningParameters Avoid reassigning parameters such as 'str' 2 832
AvoidReassigningParameters Avoid reassigning parameters such as 'str' 2 832
AvoidReassigningParameters Avoid reassigning parameters such as 'str' 2 832
AvoidReassigningParameters Avoid reassigning parameters such as 'str' 2 832
AvoidReassigningParameters Avoid reassigning parameters such as 'str' 2 832
AvoidReassigningParameters Avoid reassigning parameters such as 'str' 2 832
AvoidReassigningParameters Avoid reassigning parameters such as 'str' 2 832

fr/paris/lutece/plugins/workflow/modules/ticketing/service/daemon/TicketPjMigrationDaemon.java

Rule Violation Priority Ligne
GodClass Possible God Class (WMC=50, ATFD=41, TCC=2.500%) 3 66468
TooManyMethods This class has too many methods, consider refactoring it. 3 67468
UnnecessaryConstructor Avoid unnecessary constructors - the compiler will generate these for you 3 7982
ShortVariable Avoid variables with short names like sb 3 90
ShortVariable Avoid variables with short names like sb 3 105
ConfusingTernary Avoid if (x != y) ..; else ..; 3 109164
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 150
AvoidReassigningParameters Avoid reassigning parameters such as 'idCoreUploadFinal' 2 263
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 279
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 279
AvoidReassigningParameters Avoid reassigning parameters such as 'idFileList' 2 354
ShortVariable Avoid variables with short names like pj 3 376
ShortVariable Avoid variables with short names like pj 3 411

fr/paris/lutece/plugins/workflow/modules/ticketing/service/task/AbstractTicketingTask.java

Rule Violation Priority Ligne
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 83

fr/paris/lutece/plugins/workflow/modules/ticketing/service/task/TaskAssignTicketToMe.java

Rule Violation Priority Ligne
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 3 106110

fr/paris/lutece/plugins/workflow/modules/ticketing/service/task/TaskAssignTicketToRQ.java

Rule Violation Priority Ligne
CommentRequired Header comments are required 3 5199

fr/paris/lutece/plugins/workflow/modules/ticketing/service/task/TaskAssignTicketToUser.java

Rule Violation Priority Ligne
ConfusingTernary Avoid if (x != y) ..; else ..; 3 96122

fr/paris/lutece/plugins/workflow/modules/ticketing/service/task/TaskAssignUnitLinkedToCategory.java

Rule Violation Priority Ligne
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 3 8589

fr/paris/lutece/plugins/workflow/modules/ticketing/service/task/TaskAssignUpTicket.java

Rule Violation Priority Ligne
CyclomaticComplexity The method 'processTicketingTask(int, HttpServletRequest, Locale)' has a cyclomatic complexity of 10. 3 81148
ConfusingTernary Avoid if (x != y) ..; else ..; 3 84

fr/paris/lutece/plugins/workflow/modules/ticketing/service/task/TaskAutomaticAgentAssignmentParisFamille.java

Rule Violation Priority Ligne
UseLocaleWithCaseConversions When doing a String.toLowerCase()/toUpperCase() call, use a Locale 3 84

fr/paris/lutece/plugins/workflow/modules/ticketing/service/task/TaskAutomaticCentralizeAttachments.java

Rule Violation Priority Ligne
TooManyMethods This class has too many methods, consider refactoring it. 3 68436
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 114
AvoidReassigningParameters Avoid reassigning parameters such as 'idFileList' 2 310
ShortVariable Avoid variables with short names like pj 3 332
ShortVariable Avoid variables with short names like pj 3 372

fr/paris/lutece/plugins/workflow/modules/ticketing/service/task/TaskAutomaticIdAdminBOInit.java

Rule Violation Priority Ligne
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 3 69

fr/paris/lutece/plugins/workflow/modules/ticketing/service/task/TaskEditTicket.java

Rule Violation Priority Ligne
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 3 34414
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 127
UnusedFormalParameter Avoid unused method parameters such as 'locale'. 3 163
NPathComplexity The method 'processAgentTask(int, HttpServletRequest, Locale, TaskEditTicketConfig)' has an NPath complexity of 288 3 163244
CyclomaticComplexity The method 'processAgentTask(int, HttpServletRequest, Locale, TaskEditTicketConfig)' has a cyclomatic complexity of 11. 3 163244
UnusedFormalParameter Avoid unused method parameters such as 'locale'. 3 259
UnusedFormalParameter Avoid unused method parameters such as 'config'. 3 259
CyclomaticComplexity The method 'processUserTask(int, HttpServletRequest, Locale, TaskEditTicketConfig)' has a cyclomatic complexity of 13. 3 259342
NPathComplexity The method 'processUserTask(int, HttpServletRequest, Locale, TaskEditTicketConfig)' has an NPath complexity of 240 3 259342
ShortVariable Avoid variables with short names like pj 3 298
ShortVariable Avoid variables with short names like pj 3 344
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 371

fr/paris/lutece/plugins/workflow/modules/ticketing/service/task/TaskModifyTicket.java

Rule Violation Priority Ligne
ExcessiveMethodLength Avoid really long methods. 3 105323
NPathComplexity The method 'processTicketingTask(int, HttpServletRequest, Locale)' has an NPath complexity of 1047176 3 105323
NcssCount The method 'processTicketingTask(int, HttpServletRequest, Locale)' has a NCSS line count of 108. 3 105323
CyclomaticComplexity The method 'processTicketingTask(int, HttpServletRequest, Locale)' has a cyclomatic complexity of 33. 3 105323
ShortVariable Avoid variables with short names like pj 3 137
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 3 145
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 3 169
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 3 178
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 3 187
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 3 196
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 3 205
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 3 214
ConfusingTernary Avoid if (x != y) ..; else ..; 3 223290
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 3 230
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 3 237
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 3 244
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 3 251
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 3 262265
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 3 264
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 3 269272
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 3 271
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 3 276279
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 3 278
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 3 283286
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 3 285
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 3 300
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 3 309
ShortVariable Avoid variables with short names like pj 3 355

fr/paris/lutece/plugins/workflow/modules/ticketing/service/task/TaskModifyTicketCategory.java

Rule Violation Priority Ligne
ExcessiveMethodLength Avoid really long methods. 3 93239
CyclomaticComplexity The method 'processTicketingTask(int, HttpServletRequest, Locale)' has a cyclomatic complexity of 27. 3 93239
NcssCount The method 'processTicketingTask(int, HttpServletRequest, Locale)' has a NCSS line count of 72. 3 93239
NPathComplexity The method 'processTicketingTask(int, HttpServletRequest, Locale)' has an NPath complexity of 52178 3 93239
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 3 121
ConfusingTernary Avoid if (x != y) ..; else ..; 3 155163
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 3 155163
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 3 157
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 3 162
ConfusingTernary Avoid if (x != y) ..; else ..; 3 178186
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 3 180
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 3 183186
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 3 185
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 3 195
EmptyIfStmt Avoid empty if statements 3 220222

fr/paris/lutece/plugins/workflow/modules/ticketing/service/task/TaskNotifyWaitingTicket.java

Rule Violation Priority Ligne
CommentRequired Header comments are required 3 68328
ImmutableField Private field '_externalUserDAO' could be made final; it is only initialized in the declaration or constructor. 3 111
CyclomaticComplexity The method 'processAgentTask(int, Ticket, HttpServletRequest, TaskNotifyWaitingTicketConfig)' has a cyclomatic complexity of 10. 3 159232

fr/paris/lutece/plugins/workflow/modules/ticketing/service/task/TaskQualifyTicket.java

Rule Violation Priority Ligne
ShortVariable Avoid variables with short names like sb 3 59

fr/paris/lutece/plugins/workflow/modules/ticketing/service/task/TaskReassignTicketToUnitForAUserNotAvailable.java

Rule Violation Priority Ligne
ImmutableField Private field '_ticketReassignUnitResourceService' could be made final; it is only initialized in the declaration or constructor. 3 79
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the dao field if you want a default access modifier 3 81
DefaultPackage Use explicit scoping instead of the default package private level 3 81
FieldNamingConventions The field name 'dao' doesn't match '_[a-z][a-zA-Z0-9]*' 1 81
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 3 125128
CompareObjectsWithEquals Use equals() to compare object references. 3 144

fr/paris/lutece/plugins/workflow/modules/ticketing/service/task/TaskRemoveSignalementTicket.java

Rule Violation Priority Ligne
ShortVariable Avoid variables with short names like sb 3 59

fr/paris/lutece/plugins/workflow/modules/ticketing/service/task/TaskRemoveVspTicket.java

Rule Violation Priority Ligne
ShortVariable Avoid variables with short names like sb 3 59

fr/paris/lutece/plugins/workflow/modules/ticketing/service/task/TaskReply.java

Rule Violation Priority Ligne
UseLocaleWithCaseConversions When doing a String.toLowerCase()/toUpperCase() call, use a Locale 3 129
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 179
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 192

fr/paris/lutece/plugins/workflow/modules/ticketing/service/task/TaskReplyAssignUpTicket.java

Rule Violation Priority Ligne
CyclomaticComplexity The method 'processTicketingTask(int, HttpServletRequest, Locale)' has a cyclomatic complexity of 14. 3 83162
NPathComplexity The method 'processTicketingTask(int, HttpServletRequest, Locale)' has an NPath complexity of 530 3 83162
ConfusingTernary Avoid if (x != y) ..; else ..; 3 109153
ConfusingTernary Avoid if (x != y) ..; else ..; 3 122137
ConfusingTernary Avoid if (x != y) ..; else ..; 3 145
ConfusingTernary Avoid if (x != y) ..; else ..; 3 146147
ConfusingTernary Avoid if (x != y) ..; else ..; 3 148
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 194
ConfusingTernary Avoid if (x != y) ..; else ..; 3 230

fr/paris/lutece/plugins/workflow/modules/ticketing/service/task/TaskSelectChannel.java

Rule Violation Priority Ligne
ConfusingTernary Avoid if (x != y) ..; else ..; 3 8391

fr/paris/lutece/plugins/workflow/modules/ticketing/service/task/TaskSignalementTicket.java

Rule Violation Priority Ligne
ShortVariable Avoid variables with short names like sb 3 59

fr/paris/lutece/plugins/workflow/modules/ticketing/service/task/TaskSphinx.java

Rule Violation Priority Ligne
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 68

fr/paris/lutece/plugins/workflow/modules/ticketing/service/task/TaskTicketEmailExternalUser.java

Rule Violation Priority Ligne
ImmutableField Private field '_externalUserDAO' could be made final; it is only initialized in the declaration or constructor. 3 108
UnusedFormalParameter Avoid unused method parameters such as 'locale'. 3 159
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 3 188208
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 3 215222
UnusedFormalParameter Avoid unused method parameters such as 'locale'. 3 240
UnusedFormalParameter Avoid unused method parameters such as 'config'. 3 241
UnusedFormalParameter Avoid unused method parameters such as 'locale'. 3 281
UnusedFormalParameter Avoid unused method parameters such as 'config'. 3 282

fr/paris/lutece/plugins/workflow/modules/ticketing/service/task/TaskVspTicket.java

Rule Violation Priority Ligne
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 3 83
UseVarargs Consider using varargs for methods or constructors which take an array the last parameter. 4 121

fr/paris/lutece/plugins/workflow/modules/ticketing/service/ticket/EditableTicketService.java

Rule Violation Priority Ligne
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 3 260264

fr/paris/lutece/plugins/workflow/modules/ticketing/utils/TaskEditTicketConstants.java

Rule Violation Priority Ligne
ClassNamingConventions The utility class name 'TaskEditTicketConstants' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' 1 4160

fr/paris/lutece/plugins/workflow/modules/ticketing/utils/UtilConstants.java

Rule Violation Priority Ligne
CommentRequired Header comments are required 3 3644
ClassWithOnlyPrivateConstructorsShouldBeFinal A class which only has private constructors should be final 1 3644
ClassNamingConventions The utility class name 'UtilConstants' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' 1 3644
FieldDeclarationsShouldBeAtStartOfClass Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 3 43

fr/paris/lutece/plugins/workflow/modules/ticketing/utils/WorkflowTicketingUtils.java

Rule Violation Priority Ligne
FieldNamingConventions The constant name '_resourceHistoryService' doesn't match '[A-Z][A-Z_0-9]*' 1 64
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 113
ConfusingTernary Avoid if (x != y) ..; else ..; 3 138150
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 171
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 171
UnnecessaryLocalBeforeReturn Consider simply returning the value vs storing it in local variable 'formatedErrors' 3 179

fr/paris/lutece/plugins/workflow/modules/ticketing/web/EditTicketXPage.java

Rule Violation Priority Ligne
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 3 34375
ImmutableField Private field '_editableTicketService' could be made final; it is only initialized in the declaration or constructor. 3 121
ImmutableField Private field '_ticketFormService' could be made final; it is only initialized in the declaration or constructor. 3 122
ConfusingTernary Avoid if (x != y) ..; else ..; 3 185220
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 201
ConfusingTernary Avoid if (x != y) ..; else ..; 3 213220
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 249

fr/paris/lutece/plugins/workflow/modules/ticketing/web/ModifyTicketCategoryJspBean.java

Rule Violation Priority Ligne
CommentRequired Header comments are required 3 57105
FieldNamingConventions The final field name '_ticketFormService' doesn't match '[a-z][a-zA-Z0-9]*' 1 71
FieldNamingConventions The final field name '_taskModifyTicketCategoryConfigService' doesn't match '[a-z][a-zA-Z0-9]*' 1 72

fr/paris/lutece/plugins/workflow/modules/ticketing/web/TicketExternalUserResponseJspBean.java

Rule Violation Priority Ligne
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 3 34384
ImmutableField Private field '_ticketEmailExternalUserHistoryDAO' could be made final; it is only initialized in the declaration or constructor. 3 135
ImmutableField Private field '_ticketEmailExternalUserMessageDAO' could be made final; it is only initialized in the declaration or constructor. 3 136
ImmutableField Private field '_taskTicketExternalUserConfigService' could be made final; it is only initialized in the declaration or constructor. 3 137
ImmutableField Private field '_resourceHistoryService' could be made final; it is only initialized in the declaration or constructor. 3 138
CommentRequired Public method and constructor comments are required 3 152155
ExcessiveMethodLength Avoid really long methods. 3 165302
NPathComplexity The method 'getExternalUserResponseView(HttpServletRequest)' has an NPath complexity of 2616 3 165302
NcssCount The method 'getExternalUserResponseView(HttpServletRequest)' has a NCSS line count of 71. 3 165302
CyclomaticComplexity The method 'getExternalUserResponseView(HttpServletRequest)' has a cyclomatic complexity of 16. 3 165302
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 180
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 181
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 182
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 182
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 183
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 3 212
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 255
AvoidCatchingNPE Avoid catching NullPointerException; consider removing the cause of the NPE. 3 255
CommentRequired Protected method constructor comments are required 3 304312
ConfusingTernary Avoid if (x != y) ..; else ..; 3 322330
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 332
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 344

fr/paris/lutece/plugins/workflow/modules/ticketing/web/task/AssignTicketToUnitTaskComponent.java

Rule Violation Priority Ligne
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 89
ConfusingTernary Avoid if (x != y) ..; else ..; 3 94105
ConfusingTernary Avoid if (x != y) ..; else ..; 3 157

fr/paris/lutece/plugins/workflow/modules/ticketing/web/task/AssignTicketToUserTaskComponent.java

Rule Violation Priority Ligne
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 3 9295

fr/paris/lutece/plugins/workflow/modules/ticketing/web/task/AssignUpTicketTaskComponent.java

Rule Violation Priority Ligne
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 87
ConfusingTernary Avoid if (x != y) ..; else ..; 3 91102
ConfusingTernary Avoid if (x != y) ..; else ..; 3 164

fr/paris/lutece/plugins/workflow/modules/ticketing/web/task/EditTicketTaskComponent.java

Rule Violation Priority Ligne
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 106
ConfusingTernary Avoid if (x != y) ..; else ..; 3 113120
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 172
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 237

fr/paris/lutece/plugins/workflow/modules/ticketing/web/task/MarkAsUnreadTaskComponent.java

Rule Violation Priority Ligne
CommentRequired Header comments are required 3 54126
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 75

fr/paris/lutece/plugins/workflow/modules/ticketing/web/task/ModifyTicketCategoryTaskComponent.java

Rule Violation Priority Ligne
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 3 34326
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 113
CyclomaticComplexity The method 'doValidateTask(int, String, HttpServletRequest, Locale, ITask)' has a cyclomatic complexity of 20. 3 189278
NPathComplexity The method 'doValidateTask(int, String, HttpServletRequest, Locale, ITask)' has an NPath complexity of 1300 3 189278
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 3 220224
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 3 229246
InefficientEmptyStringCheck String.trim().length() == 0 / String.trim().isEmpty() is an inefficient way to validate a blank String. 3 231
InefficientEmptyStringCheck String.trim().length() == 0 / String.trim().isEmpty() is an inefficient way to validate a blank String. 3 286
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 3 308
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 3 313

fr/paris/lutece/plugins/workflow/modules/ticketing/web/task/ModifyTicketNomenclatureTaskComponent.java

Rule Violation Priority Ligne
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 79

fr/paris/lutece/plugins/workflow/modules/ticketing/web/task/ModifyTicketTaskComponent.java

Rule Violation Priority Ligne
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 3 34215
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 3 180

fr/paris/lutece/plugins/workflow/modules/ticketing/web/task/NotifyWaitingTicketTaskComponent.java

Rule Violation Priority Ligne
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 3 34392
CommentRequired Header comments are required 3 72392
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 133
ConfusingTernary Avoid if (x != y) ..; else ..; 3 146169
CyclomaticComplexity The method 'getDisplayTaskInformation(int, HttpServletRequest, Locale, ITask)' has a cyclomatic complexity of 13. 3 255357
ExcessiveMethodLength Avoid really long methods. 3 255357
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 265
ShortVariable Avoid variables with short names like sb 3 270
ConfusingTernary Avoid if (x != y) ..; else ..; 3 273339
ConfusingTernary Avoid if (x != y) ..; else ..; 3 285297
ConfusingTernary Avoid if (x != y) ..; else ..; 3 299318
InefficientEmptyStringCheck String.trim().length() == 0 / String.trim().isEmpty() is an inefficient way to validate a blank String. 3 342
AppendCharacterWithChar Avoid appending characters as strings in StringBuffer.append. 3 345

fr/paris/lutece/plugins/workflow/modules/ticketing/web/task/ReplyTaskComponent.java

Rule Violation Priority Ligne
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 93
ConfusingTernary Avoid if (x != y) ..; else ..; 3 97106

fr/paris/lutece/plugins/workflow/modules/ticketing/web/task/TicketEmailExternalUserTaskComponent.java

Rule Violation Priority Ligne
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 3 34515
FieldNamingConventions The constant name '_attributeService' doesn't match '[A-Z][A-Z_0-9]*' 1 132
UnusedPrivateField Avoid unused private fields such as '_taskTicketConfigService'. 3 136
UnusedPrivateField Avoid unused private fields such as '_actionService'. 3 156
FieldNamingConventions The field name '_ExternalUserDAO' doesn't match '_[a-z][a-zA-Z0-9]*' 1 160
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 185
ConfusingTernary Avoid if (x != y) ..; else ..; 3 187
ConfusingTernary Avoid if (x != y) ..; else ..; 3 217
CyclomaticComplexity The method 'getDisplayTaskForm(int, String, HttpServletRequest, Locale, ITask)' has a cyclomatic complexity of 15. 3 230301
ConfusingTernary Avoid if (x != y) ..; else ..; 3 263
ConfusingTernary Avoid if (x != y) ..; else ..; 3 265
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 277
ConfusingTernary Avoid if (x != y) ..; else ..; 3 296
CyclomaticComplexity The method 'doValidateTask(int, String, HttpServletRequest, Locale, ITask)' has a cyclomatic complexity of 15. 3 332404
NPathComplexity The method 'doValidateTask(int, String, HttpServletRequest, Locale, ITask)' has an NPath complexity of 315 3 332404
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 340341
UnusedLocalVariable Avoid unused local variables such as 'strEmailSubject'. 3 340
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 3 364
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 3 378
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 412
ConfusingTernary Avoid if (x != y) ..; else ..; 3 422445

fr/paris/lutece/plugins/workflow/modules/ticketing/web/task/TicketingCommentTaskComponent.java

Rule Violation Priority Ligne
CommentRequired Header comments are required 3 63149
FieldNamingConventions The field name 'taskComponent' doesn't match '_[a-z][a-zA-Z0-9]*' 1 69
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the taskComponent field if you want a default access modifier 3 69
DefaultPackage Use explicit scoping instead of the default package private level 3 69
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 134

fr/paris/lutece/plugins/workflow/modules/ticketing/web/task/TicketingTaskComponent.java

Rule Violation Priority Ligne
CommentRequired Public method and constructor comments are required 3 102105
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 151
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 164
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 164