Fork me on GitHub

PMD Results

The following document contains the results of PMD 6.13.0.

Violations By Priority

Priority 1

fr/paris/lutece/plugins/workflow/modules/ticketing/business/config/MessageDirection.java

Rule Violation Line
FieldNamingConventions The static field name 'mapMessageDirection' doesn't match '_[a-z][a-zA-Z0-9]*' 54

fr/paris/lutece/plugins/workflow/modules/ticketing/business/config/TaskModifyTicketCategoryConfig.java

Rule Violation Line
FormalParameterNamingConventions The method parameter name '_nSelectedEntry' doesn't match '[a-z][a-zA-Z0-9]*' 69

fr/paris/lutece/plugins/workflow/modules/ticketing/business/config/TaskReplyConfig.java

Rule Violation Line
FormalParameterNamingConventions The method parameter name '_bCloseTicket' doesn't match '[a-z][a-zA-Z0-9]*' 84

fr/paris/lutece/plugins/workflow/modules/ticketing/business/email/provider/TicketEmailExternalUserConstants.java

Rule Violation Line
ClassNamingConventions The utility class name 'TicketEmailExternalUserConstants' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' 39–86

fr/paris/lutece/plugins/workflow/modules/ticketing/business/externaluser/search/ExternalUserEmailValidationServlet.java

Rule Violation Line
FieldNamingConventions The final field name '_externalUserDAO' doesn't match '[a-z][a-zA-Z0-9]*' 87

fr/paris/lutece/plugins/workflow/modules/ticketing/business/externaluser/search/ExternalUserSearchServlet.java

Rule Violation Line
FieldNamingConventions The final field name '_externalUserDAO' doesn't match '[a-z][a-zA-Z0-9]*' 107
FieldNamingConventions The constant name '_attributeService' doesn't match '[A-Z][A-Z_0-9]*' 110

fr/paris/lutece/plugins/workflow/modules/ticketing/business/information/ChooseNextStateTaskInformationHome.java

Rule Violation Line
ClassWithOnlyPrivateConstructorsShouldBeFinal A class which only has private constructors should be final 38–88

fr/paris/lutece/plugins/workflow/modules/ticketing/service/daemon/NotifyDaemon.java

Rule Violation Line
FieldNamingConventions The constant name '_resourceHistoryService' doesn't match '[A-Z][A-Z_0-9]*' 62
FieldNamingConventions The field name 'nIdWorkflow' doesn't match '_[a-z][a-zA-Z0-9]*' 64
FieldNamingConventions The field name 'isMinuteMode' doesn't match '_[a-z][a-zA-Z0-9]*' 67
FieldNamingConventions The field name 'nIdStateWaiting' doesn't match '_[a-z][a-zA-Z0-9]*' 71
FieldNamingConventions The field name 'nIdActionRelance' doesn't match '_[a-z][a-zA-Z0-9]*' 76
FieldNamingConventions The field name 'nIdActionSolliciterFromTerrainNiv2' doesn't match '_[a-z][a-zA-Z0-9]*' 82
FieldNamingConventions The field name 'nIdActionSolliciterFromTerrainNiv3' doesn't match '_[a-z][a-zA-Z0-9]*' 85
FieldNamingConventions The field name 'nIdActionSolliciterFromContribNiv2' doesn't match '_[a-z][a-zA-Z0-9]*' 88
FieldNamingConventions The field name 'nIdActionSolliciterFromContribNiv3' doesn't match '_[a-z][a-zA-Z0-9]*' 91
FieldNamingConventions The field name 'nIdActionRetourFromTerrainNiv2' doesn't match '_[a-z][a-zA-Z0-9]*' 98
FieldNamingConventions The field name 'nIdActionRetourFromTerrainNiv3' doesn't match '_[a-z][a-zA-Z0-9]*' 101
FieldNamingConventions The field name 'nIdActionRetourFromContribNiv2' doesn't match '_[a-z][a-zA-Z0-9]*' 104
FieldNamingConventions The field name 'nIdActionRetourFromContribNiv3' doesn't match '_[a-z][a-zA-Z0-9]*' 107
FieldNamingConventions The field name 'nbRelanceMax' doesn't match '_[a-z][a-zA-Z0-9]*' 111
FieldNamingConventions The field name 'nFrequence' doesn't match '_[a-z][a-zA-Z0-9]*' 113

fr/paris/lutece/plugins/workflow/modules/ticketing/service/daemon/NotifyLevel3Daemon.java

Rule Violation Line
FieldNamingConventions The constant name '_resourceHistoryService' doesn't match '[A-Z][A-Z_0-9]*' 64
FieldNamingConventions The field name 'nIdWorkflow' doesn't match '_[a-z][a-zA-Z0-9]*' 66
FieldNamingConventions The field name 'isMinuteMode' doesn't match '_[a-z][a-zA-Z0-9]*' 68
FieldNamingConventions The field name 'nIdStateLevel3' doesn't match '_[a-z][a-zA-Z0-9]*' 73
FieldNamingConventions The field name 'nIdActionRelance' doesn't match '_[a-z][a-zA-Z0-9]*' 78
FieldNamingConventions The field name 'nIdActionEscaladerNiveau3' doesn't match '_[a-z][a-zA-Z0-9]*' 84
FieldNamingConventions The field name 'nIdActionReturnATraiter' doesn't match '_[a-z][a-zA-Z0-9]*' 90
FieldNamingConventions The field name 'nbRelanceMax' doesn't match '_[a-z][a-zA-Z0-9]*' 94
FieldNamingConventions The field name 'nFrequence' doesn't match '_[a-z][a-zA-Z0-9]*' 96

fr/paris/lutece/plugins/workflow/modules/ticketing/service/daemon/NotifyUsagerDaemon.java

Rule Violation Line
FieldNamingConventions The constant name '_resourceHistoryService' doesn't match '[A-Z][A-Z_0-9]*' 62
FieldNamingConventions The field name 'nIdWorkflow' doesn't match '_[a-z][a-zA-Z0-9]*' 64
FieldNamingConventions The field name 'isMinuteMode' doesn't match '_[a-z][a-zA-Z0-9]*' 66
FieldNamingConventions The field name 'nIdStateWaitingUsager' doesn't match '_[a-z][a-zA-Z0-9]*' 71
FieldNamingConventions The field name 'nIdActionRelance' doesn't match '_[a-z][a-zA-Z0-9]*' 77
FieldNamingConventions The field name 'nIdActionDemandeComplementUsager' doesn't match '_[a-z][a-zA-Z0-9]*' 83
FieldNamingConventions The field name 'nIdActionRetourFromDemandeComplementUsager' doesn't match '_[a-z][a-zA-Z0-9]*' 90
FieldNamingConventions The field name 'nbRelanceMax' doesn't match '_[a-z][a-zA-Z0-9]*' 94
FieldNamingConventions The field name 'nFrequence' doesn't match '_[a-z][a-zA-Z0-9]*' 96

fr/paris/lutece/plugins/workflow/modules/ticketing/service/daemon/TicketCreationBrouillonDaemon.java

Rule Violation Line
FieldNamingConventions The final field name '_stockageS3DaemonMinio' doesn't match '[a-z][a-zA-Z0-9]*' 121
FieldNamingConventions The final field name '_stockageS3ScannerDaemonNetapp' doesn't match '[a-z][a-zA-Z0-9]*' 122

fr/paris/lutece/plugins/workflow/modules/ticketing/service/daemon/TicketPurgeAnonymisationDaemon.java

Rule Violation Line
FieldNamingConventions The static field name 'daoResourceHist' doesn't match '_[a-z][a-zA-Z0-9]*' 70
FieldNamingConventions The field name 'purgeAnonymisationService' doesn't match '_[a-z][a-zA-Z0-9]*' 72
FieldNamingConventions The static field name 'plugin' doesn't match '_[a-z][a-zA-Z0-9]*' 74

fr/paris/lutece/plugins/workflow/modules/ticketing/service/purgeanonymisation/PurgeAnonymisationService.java

Rule Violation Line
FieldNamingConventions The field name 'daoEmailExternalUsermessage' doesn't match '_[a-z][a-zA-Z0-9]*' 70
FieldNamingConventions The field name 'daoTaskInfo' doesn't match '_[a-z][a-zA-Z0-9]*' 72
FieldNamingConventions The field name 'daoEditableTicketHist' doesn't match '_[a-z][a-zA-Z0-9]*' 74
FieldNamingConventions The field name 'daoEditableTicketFieldDAO' doesn't match '_[a-z][a-zA-Z0-9]*' 76
FieldNamingConventions The field name 'daoAnonymisation' doesn't match '_[a-z][a-zA-Z0-9]*' 78
FieldNamingConventions The field name 'daoEmailExternalUserRecipientDAO' doesn't match '_[a-z][a-zA-Z0-9]*' 80
FieldNamingConventions The field name 'daoEmailExternalUserCcHist' doesn't match '_[a-z][a-zA-Z0-9]*' 82
FieldNamingConventions The field name 'daoEmailExternalUserHist' doesn't match '_[a-z][a-zA-Z0-9]*' 84
FieldNamingConventions The final field name '_stockageS3DaemonMinio' doesn't match '[a-z][a-zA-Z0-9]*' 86
FieldNamingConventions The final field name '_stockageS3DaemonNetapp' doesn't match '[a-z][a-zA-Z0-9]*' 87
FieldNamingConventions The static field name 'plugin' doesn't match '_[a-z][a-zA-Z0-9]*' 89

fr/paris/lutece/plugins/workflow/modules/ticketing/service/task/TaskReassignTicketToUnitForAUserNotAvailable.java

Rule Violation Line
FieldNamingConventions The field name 'dao' doesn't match '_[a-z][a-zA-Z0-9]*' 81

fr/paris/lutece/plugins/workflow/modules/ticketing/utils/TaskEditTicketConstants.java

Rule Violation Line
ClassNamingConventions The utility class name 'TaskEditTicketConstants' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' 41–60

fr/paris/lutece/plugins/workflow/modules/ticketing/utils/UtilConstants.java

Rule Violation Line
ClassWithOnlyPrivateConstructorsShouldBeFinal A class which only has private constructors should be final 36–44
ClassNamingConventions The utility class name 'UtilConstants' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' 36–44

fr/paris/lutece/plugins/workflow/modules/ticketing/utils/WorkflowTicketingUtils.java

Rule Violation Line
FieldNamingConventions The constant name '_resourceHistoryService' doesn't match '[A-Z][A-Z_0-9]*' 64

fr/paris/lutece/plugins/workflow/modules/ticketing/web/ModifyTicketCategoryJspBean.java

Rule Violation Line
FieldNamingConventions The final field name '_ticketFormService' doesn't match '[a-z][a-zA-Z0-9]*' 71
FieldNamingConventions The final field name '_taskModifyTicketCategoryConfigService' doesn't match '[a-z][a-zA-Z0-9]*' 72

fr/paris/lutece/plugins/workflow/modules/ticketing/web/task/TicketEmailExternalUserTaskComponent.java

Rule Violation Line
FieldNamingConventions The constant name '_attributeService' doesn't match '[A-Z][A-Z_0-9]*' 132
FieldNamingConventions The field name '_ExternalUserDAO' doesn't match '_[a-z][a-zA-Z0-9]*' 160

fr/paris/lutece/plugins/workflow/modules/ticketing/web/task/TicketingCommentTaskComponent.java

Rule Violation Line
FieldNamingConventions The field name 'taskComponent' doesn't match '_[a-z][a-zA-Z0-9]*' 69

Priority 2

fr/paris/lutece/plugins/workflow/modules/ticketing/service/daemon/TicketPjMigrationDaemon.java

Rule Violation Line
AvoidReassigningParameters Avoid reassigning parameters such as 'idCoreUploadFinal' 263
AvoidReassigningParameters Avoid reassigning parameters such as 'idFileList' 354

fr/paris/lutece/plugins/workflow/modules/ticketing/service/task/TaskAutomaticCentralizeAgent.java

Rule Violation Line
AvoidReassigningParameters Avoid reassigning parameters such as 'idFileList' 283

fr/paris/lutece/plugins/workflow/modules/ticketing/service/task/TaskAutomaticCentralizeAttachments.java

Rule Violation Line
AvoidReassigningParameters Avoid reassigning parameters such as 'idFileList' 310

fr/paris/lutece/plugins/workflow/modules/ticketing/service/task/TaskAutomaticCentralizeUsager.java

Rule Violation Line
AvoidReassigningParameters Avoid reassigning parameters such as 'idFileList' 148

Priority 3

fr/paris/lutece/plugins/workflow/modules/ticketing/business/anonymisation/AnonymisationDAO.java

Rule Violation Line
CommentRequired Header comments are required 46–221
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 73

fr/paris/lutece/plugins/workflow/modules/ticketing/business/anonymisation/IAnonymisationDAO.java

Rule Violation Line
CommentRequired Header comments are required 41–149

fr/paris/lutece/plugins/workflow/modules/ticketing/business/config/MessageDirection.java

Rule Violation Line
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 54
UseLocaleWithCaseConversions When doing a String.toLowerCase()/toUpperCase() call, use a Locale 85

fr/paris/lutece/plugins/workflow/modules/ticketing/business/config/TaskAssignTicketToUnitConfigDAO.java

Rule Violation Line
CommentRequired Header comments are required 41–131
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 55–68

fr/paris/lutece/plugins/workflow/modules/ticketing/business/config/TaskChooseNextStateConfig.java

Rule Violation Line
CommentRequired Header comments are required 41–104

fr/paris/lutece/plugins/workflow/modules/ticketing/business/config/TaskChooseNextStateConfigDAO.java

Rule Violation Line
CommentRequired Header comments are required 39–114

fr/paris/lutece/plugins/workflow/modules/ticketing/business/config/TaskEditTicketConfig.java

Rule Violation Line
UnusedPrivateField Avoid unused private fields such as '_nIdStateAfterEdition'. 53

fr/paris/lutece/plugins/workflow/modules/ticketing/business/config/TaskEditTicketConfigDAO.java

Rule Violation Line
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 60–72

fr/paris/lutece/plugins/workflow/modules/ticketing/business/config/TaskMarkAsUnreadConfig.java

Rule Violation Line
CommentRequired Header comments are required 41–67

fr/paris/lutece/plugins/workflow/modules/ticketing/business/config/TaskMarkAsUnreadConfigDAO.java

Rule Violation Line
CommentRequired Header comments are required 45–153
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 59–70

fr/paris/lutece/plugins/workflow/modules/ticketing/business/config/TaskModifyTicketCategoryConfigDAO.java

Rule Violation Line
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 55–81
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 121–128

fr/paris/lutece/plugins/workflow/modules/ticketing/business/config/TaskNotifyWaitingTicketConfig.java

Rule Violation Line
CommentRequired Header comments are required 41–124
CommentRequired Public method and constructor comments are required 115–118
CommentRequired Public method and constructor comments are required 120–123

fr/paris/lutece/plugins/workflow/modules/ticketing/business/config/TaskNotifyWaitingTicketConfigDAO.java

Rule Violation Line
CommentRequired Header comments are required 43–183

fr/paris/lutece/plugins/workflow/modules/ticketing/business/email/cc/TicketEmailExternalUserCcDAO.java

Rule Violation Line
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 88–103

fr/paris/lutece/plugins/workflow/modules/ticketing/business/email/config/MessageDirectionExternalUser.java

Rule Violation Line
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 55
UseLocaleWithCaseConversions When doing a String.toLowerCase()/toUpperCase() call, use a Locale 86

fr/paris/lutece/plugins/workflow/modules/ticketing/business/email/config/TaskTicketEmailExternalUserConfig.java

Rule Violation Line
CommentRequired Public method and constructor comments are required 117–120
CommentRequired Public method and constructor comments are required 122–125

fr/paris/lutece/plugins/workflow/modules/ticketing/business/email/config/TaskTicketEmailExternalUserConfigDAO.java

Rule Violation Line
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 56–94

fr/paris/lutece/plugins/workflow/modules/ticketing/business/email/history/TicketEmailExternalUserHistoryDAO.java

Rule Violation Line
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 67–79

fr/paris/lutece/plugins/workflow/modules/ticketing/business/email/message/ITicketEmailExternalUserMessageDAO.java

Rule Violation Line
TooManyMethods This class has too many methods, consider refactoring it. 45–147
UnnecessaryModifier Unnecessary modifier 'public' on method 'closeMessagesByIdTicket': the method is declared in an interface type 85
ShortVariable Avoid variables with short names like id 140
CommentRequired Public method and constructor comments are required 140
CommentRequired Public method and constructor comments are required 142
CommentRequired Public method and constructor comments are required 144
CommentRequired Public method and constructor comments are required 146

fr/paris/lutece/plugins/workflow/modules/ticketing/business/email/message/TicketEmailExternalUserMessage.java

Rule Violation Line
CommentRequired Public method and constructor comments are required 184–187
CommentRequired Public method and constructor comments are required 189–192

fr/paris/lutece/plugins/workflow/modules/ticketing/business/email/message/TicketEmailExternalUserMessageDAO.java

Rule Violation Line
TooManyMethods This class has too many methods, consider refactoring it. 52–431
AvoidDuplicateLiterals The String literal "workflow.transactionManager" appears 4 times in this file; the first occurrence is on line 123 123
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 124–141
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 159–172
ShortVariable Avoid variables with short names like id 367
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 385

fr/paris/lutece/plugins/workflow/modules/ticketing/business/email/provider/TicketEmailExternalUserProvider.java

Rule Violation Line
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 34–433
TooManyMethods This class has too many methods, consider refactoring it. 73–433
ImmutableField Private field '_ticketEmailExternalUserHistoryDAO' could be made final; it is only initialized in the declaration or constructor. 100
ImmutableField Private field '_ticketEmailExternalUserDemandDAO' could be made final; it is only initialized in the declaration or constructor. 104
ImmutableField Private field '_ticket' could be made final; it is only initialized in the declaration or constructor. 107
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the _dateFormater field if you want a default access modifier 110
DefaultPackage Use explicit scoping instead of the default package private level 110
SimpleDateFormatNeedsLocale When instantiating a SimpleDateFormat object, specify a Locale 110
ConfusingTernary Avoid if (x != y) ..; else ..; 296–307
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 422–429

fr/paris/lutece/plugins/workflow/modules/ticketing/business/email/recipient/TicketEmailExternalUserRecipientDAO.java

Rule Violation Line
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 85–103

fr/paris/lutece/plugins/workflow/modules/ticketing/business/externaluser/ExternalUserComparator.java

Rule Violation Line
ShortVariable Avoid variables with short names like o2 55
ShortVariable Avoid variables with short names like o1 55
ShortVariable Avoid variables with short names like c 93
CyclomaticComplexity The method 'compareAlphaNumeric(String, String, int)' has a cyclomatic complexity of 15. 142–226
NPathComplexity The method 'compareAlphaNumeric(String, String, int)' has an NPath complexity of 256 142–226

fr/paris/lutece/plugins/workflow/modules/ticketing/business/externaluser/ExternalUserDAO.java

Rule Violation Line
CyclomaticComplexity The method 'findExternalUser(String, String, String, String, String)' has a cyclomatic complexity of 14. 126–208
UseObjectForClearerAPI Rather than using a lot of String arguments, consider using a container object for those values. 126
NPathComplexity The method 'findExternalUser(String, String, String, String, String)' has an NPath complexity of 4656 126–208

fr/paris/lutece/plugins/workflow/modules/ticketing/business/externaluser/IExternalUserDAO.java

Rule Violation Line
UseObjectForClearerAPI Rather than using a lot of String arguments, consider using a container object for those values. 78

fr/paris/lutece/plugins/workflow/modules/ticketing/business/externaluser/search/ExternalUserEmailValidationServlet.java

Rule Violation Line
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 112
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 131
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 150

fr/paris/lutece/plugins/workflow/modules/ticketing/business/externaluser/search/ExternalUserSearchServlet.java

Rule Violation Line
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 144

fr/paris/lutece/plugins/workflow/modules/ticketing/business/information/ChooseNextStateTaskInformationHome.java

Rule Violation Line
CommentRequired Header comments are required 38–88

fr/paris/lutece/plugins/workflow/modules/ticketing/business/information/TaskInformationDAO.java

Rule Violation Line
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 64–74

fr/paris/lutece/plugins/workflow/modules/ticketing/business/resourcehistory/ResourceHistoryDAO.java

Rule Violation Line
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 62–102

fr/paris/lutece/plugins/workflow/modules/ticketing/business/resourcehistory/ResourceHistoryService.java

Rule Violation Line
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 114

fr/paris/lutece/plugins/workflow/modules/ticketing/business/ticket/EditableTicketDAO.java

Rule Violation Line
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 71–84

fr/paris/lutece/plugins/workflow/modules/ticketing/business/ticket/EditableTicketFieldDAO.java

Rule Violation Line
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 64–75

fr/paris/lutece/plugins/workflow/modules/ticketing/service/WorkflowTicketingPlugin.java

Rule Violation Line
UncommentedEmptyMethodBody Document empty method body 61–62

fr/paris/lutece/plugins/workflow/modules/ticketing/service/assignment/AutomaticAssignmentAgentParisFamilleService.java

Rule Violation Line
UnnecessaryConstructor Avoid unnecessary constructors - the compiler will generate these for you 70–73
ConfusingTernary Avoid if (x != y) ..; else ..; 143–151

fr/paris/lutece/plugins/workflow/modules/ticketing/service/daemon/NotifyDaemon.java

Rule Violation Line
CommentRequired Header comments are required 57–473
ImmutableField Private field 'nIdWorkflow' could be made final; it is only initialized in the declaration or constructor. 64
ImmutableField Private field 'isMinuteMode' could be made final; it is only initialized in the declaration or constructor. 67
LinguisticNaming Linguistics Antipattern - The field 'isMinuteMode' indicates linguistically it is a boolean, but it is 'int' 67
ImmutableField Private field 'nIdStateWaiting' could be made final; it is only initialized in the declaration or constructor. 71
ImmutableField Private field 'nIdActionRelance' could be made final; it is only initialized in the declaration or constructor. 76
ImmutableField Private field 'nIdActionSolliciterFromTerrainNiv2' could be made final; it is only initialized in the declaration or constructor. 82
ImmutableField Private field 'nIdActionSolliciterFromTerrainNiv3' could be made final; it is only initialized in the declaration or constructor. 85
ImmutableField Private field 'nIdActionSolliciterFromContribNiv2' could be made final; it is only initialized in the declaration or constructor. 88
ImmutableField Private field 'nIdActionSolliciterFromContribNiv3' could be made final; it is only initialized in the declaration or constructor. 91
ImmutableField Private field 'nIdActionRetourFromTerrainNiv2' could be made final; it is only initialized in the declaration or constructor. 98
ImmutableField Private field 'nIdActionRetourFromTerrainNiv3' could be made final; it is only initialized in the declaration or constructor. 101
ImmutableField Private field 'nIdActionRetourFromContribNiv2' could be made final; it is only initialized in the declaration or constructor. 104
ImmutableField Private field 'nIdActionRetourFromContribNiv3' could be made final; it is only initialized in the declaration or constructor. 107
ImmutableField Private field 'nbRelanceMax' could be made final; it is only initialized in the declaration or constructor. 111
ImmutableField Private field 'nFrequence' could be made final; it is only initialized in the declaration or constructor. 113
CyclomaticComplexity The method 'processNotification()' has a cyclomatic complexity of 18. 121–230
ExcessiveMethodLength Avoid really long methods. 121–230
InsufficientStringBufferDeclaration StringBuffer constructor is initialized with size 16, but has at least 144 characters appended. 123
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 132
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 134
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 135
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 199
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 222–223
ConsecutiveLiteralAppends StringBuffer (or StringBuilder).append is called 2 consecutive times with literals. Use a single append with a single combined String. 223
ConsecutiveLiteralAppends StringBuffer (or StringBuilder).append is called 2 consecutive times with literals. Use a single append with a single combined String. 224
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 224
CyclomaticComplexity The method 'isConfParamOK(StringBuilder)' has a cyclomatic complexity of 15. 239–272
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 263
UnusedPrivateMethod Avoid unused private methods such as 'processRelanceNoDate(Ticket,Date)'. 282
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 424
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 458–467

fr/paris/lutece/plugins/workflow/modules/ticketing/service/daemon/NotifyLevel3Daemon.java

Rule Violation Line
CommentRequired Header comments are required 59–399
ImmutableField Private field 'nIdWorkflow' could be made final; it is only initialized in the declaration or constructor. 66
LinguisticNaming Linguistics Antipattern - The field 'isMinuteMode' indicates linguistically it is a boolean, but it is 'int' 68
ImmutableField Private field 'isMinuteMode' could be made final; it is only initialized in the declaration or constructor. 68
ImmutableField Private field 'nIdStateLevel3' could be made final; it is only initialized in the declaration or constructor. 73
ImmutableField Private field 'nIdActionRelance' could be made final; it is only initialized in the declaration or constructor. 78
ImmutableField Private field 'nIdActionEscaladerNiveau3' could be made final; it is only initialized in the declaration or constructor. 84
ImmutableField Private field 'nIdActionReturnATraiter' could be made final; it is only initialized in the declaration or constructor. 90
ImmutableField Private field 'nbRelanceMax' could be made final; it is only initialized in the declaration or constructor. 94
ImmutableField Private field 'nFrequence' could be made final; it is only initialized in the declaration or constructor. 96
ExcessiveMethodLength Avoid really long methods. 104–210
CyclomaticComplexity The method 'processNotification()' has a cyclomatic complexity of 15. 104–210
InsufficientStringBufferDeclaration StringBuffer constructor is initialized with size 16, but has at least 127 characters appended. 106
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 115
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 117
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 118
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 179
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 202–203
ConsecutiveLiteralAppends StringBuffer (or StringBuilder).append is called 2 consecutive times with literals. Use a single append with a single combined String. 203
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 204
ConsecutiveLiteralAppends StringBuffer (or StringBuilder).append is called 2 consecutive times with literals. Use a single append with a single combined String. 204
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 241
UnusedPrivateMethod Avoid unused private methods such as 'processRelanceNoDate(Ticket,Date)'. 260
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 310
AssignmentInOperand Avoid assignments in operands 385

fr/paris/lutece/plugins/workflow/modules/ticketing/service/daemon/NotifyUsagerDaemon.java

Rule Violation Line
CommentRequired Header comments are required 57–387
ImmutableField Private field 'nIdWorkflow' could be made final; it is only initialized in the declaration or constructor. 64
ImmutableField Private field 'isMinuteMode' could be made final; it is only initialized in the declaration or constructor. 66
LinguisticNaming Linguistics Antipattern - The field 'isMinuteMode' indicates linguistically it is a boolean, but it is 'int' 66
ImmutableField Private field 'nIdStateWaitingUsager' could be made final; it is only initialized in the declaration or constructor. 71
ImmutableField Private field 'nIdActionRelance' could be made final; it is only initialized in the declaration or constructor. 77
ImmutableField Private field 'nIdActionDemandeComplementUsager' could be made final; it is only initialized in the declaration or constructor. 83
ImmutableField Private field 'nIdActionRetourFromDemandeComplementUsager' could be made final; it is only initialized in the declaration or constructor. 90
ImmutableField Private field 'nbRelanceMax' could be made final; it is only initialized in the declaration or constructor. 94
ImmutableField Private field 'nFrequence' could be made final; it is only initialized in the declaration or constructor. 96
ExcessiveMethodLength Avoid really long methods. 104–210
CyclomaticComplexity The method 'processNotification()' has a cyclomatic complexity of 15. 104–210
InsufficientStringBufferDeclaration StringBuffer constructor is initialized with size 16, but has at least 158 characters appended. 106
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 115
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 117
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 118
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 179
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 202–203
ConsecutiveLiteralAppends StringBuffer (or StringBuilder).append is called 2 consecutive times with literals. Use a single append with a single combined String. 203
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 204
ConsecutiveLiteralAppends StringBuffer (or StringBuilder).append is called 2 consecutive times with literals. Use a single append with a single combined String. 204
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 242
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 339
AssignmentInOperand Avoid assignments in operands 373

fr/paris/lutece/plugins/workflow/modules/ticketing/service/daemon/TicketCreationBrouillonDaemon.java

Rule Violation Line
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 34–722
GodClass Possible God Class (WMC=59, ATFD=113, TCC=16.374%) 101–722
TooManyMethods This class has too many methods, consider refactoring it. 102–722
ImmutableField Private field '_nIdStateDeleted' could be made final; it is only initialized in the declaration or constructor. 127
ImmutableField Private field '_strchannelScanName' could be made final; it is only initialized in the declaration or constructor. 129
ImmutableField Private field '_strAdminUserId' could be made final; it is only initialized in the declaration or constructor. 130
ImmutableField Private field '_strEmailSender' could be made final; it is only initialized in the declaration or constructor. 131
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the _ticketInitService field if you want a default access modifier 137
DefaultPackage Use explicit scoping instead of the default package private level 137
UnnecessaryConstructor Avoid unnecessary constructors - the compiler will generate these for you 146–149
ShortVariable Avoid variables with short names like sb 157
UnusedFormalParameter Avoid unused method parameters such as 'sb'. 169
ShortVariable Avoid variables with short names like sb 169
ConfusingTernary Avoid if (x != y) ..; else ..; 215–222
ConfusingTernary Avoid if (x != y) ..; else ..; 252–279
ShortVariable Avoid variables with short names like pj 267
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 280
ShortVariable Avoid variables with short names like sb 302
ShortVariable Avoid variables with short names like n 318
ShortVariable Avoid variables with short names like sb 332
ShortVariable Avoid variables with short names like n 332
ConfusingTernary Avoid if (x != y) ..; else ..; 346–376
ConfusingTernary Avoid if (x != y) ..; else ..; 351–372
PositionLiteralsFirstInComparisons Position literals first in String comparisons 353
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 361
UseUnderscoresInNumericLiterals Number 10000000 should separate every third digit with an underscore 361
ConfusingTernary Avoid if (x != y) ..; else ..; 409–453
ConfusingTernary Avoid if (x != y) ..; else ..; 421–447
ShortVariable Avoid variables with short names like pj 436
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 455
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 489
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 516
ShortVariable Avoid variables with short names like pj 550
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 551
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 618
ShortVariable Avoid variables with short names like pj 644

fr/paris/lutece/plugins/workflow/modules/ticketing/service/daemon/TicketPjMigrationDaemon.java

Rule Violation Line
GodClass Possible God Class (WMC=50, ATFD=41, TCC=2.500%) 66–468
TooManyMethods This class has too many methods, consider refactoring it. 67–468
UnnecessaryConstructor Avoid unnecessary constructors - the compiler will generate these for you 79–82
ShortVariable Avoid variables with short names like sb 90
ShortVariable Avoid variables with short names like sb 105
ConfusingTernary Avoid if (x != y) ..; else ..; 109–164
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 150
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 279
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 279
ShortVariable Avoid variables with short names like pj 376
ShortVariable Avoid variables with short names like pj 411

fr/paris/lutece/plugins/workflow/modules/ticketing/service/daemon/TicketPurgeAnonymisationDaemon.java

Rule Violation Line
ImmutableField Private field 'purgeAnonymisationService' could be made final; it is only initialized in the declaration or constructor. 72
CommentRequired Public method and constructor comments are required 79–82
UnnecessaryConstructor Avoid unnecessary constructors - the compiler will generate these for you 79–82
ShortVariable Avoid variables with short names like sb 90
ShortVariable Avoid variables with short names like sb 104
ShortVariable Avoid variables with short names like sb 127
ConfusingTernary Avoid if (x != y) ..; else ..; 132–134
ConfusingTernary Avoid if (x != y) ..; else ..; 147–187
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 174
ShortVariable Avoid variables with short names like sb 205
SimpleDateFormatNeedsLocale When instantiating a SimpleDateFormat object, specify a Locale 208
ShortVariable Avoid variables with short names like sb 246

fr/paris/lutece/plugins/workflow/modules/ticketing/service/purgeanonymisation/IPurgeAnonymisationService.java

Rule Violation Line
CommentRequired Public method and constructor comments are required 88

fr/paris/lutece/plugins/workflow/modules/ticketing/service/purgeanonymisation/PurgeAnonymisationService.java

Rule Violation Line
TooManyMethods This class has too many methods, consider refactoring it. 65–227
UnusedFormalParameter Avoid unused method parameters such as 'plugin2'. 108
UnusedFormalParameter Avoid unused method parameters such as 'plugin2'. 114
UnusedFormalParameter Avoid unused method parameters such as 'plugin2'. 122
UnusedFormalParameter Avoid unused method parameters such as 'plugin2'. 128
UnusedFormalParameter Avoid unused method parameters such as 'plugin2'. 134
UnusedFormalParameter Avoid unused method parameters such as 'plugin2'. 142
ShortVariable Avoid variables with short names like pj 182
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 191

fr/paris/lutece/plugins/workflow/modules/ticketing/service/task/AbstractTicketingTask.java

Rule Violation Line
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 83

fr/paris/lutece/plugins/workflow/modules/ticketing/service/task/TaskAssignTicketToMe.java

Rule Violation Line
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 108–111

fr/paris/lutece/plugins/workflow/modules/ticketing/service/task/TaskAssignTicketToRQ.java

Rule Violation Line
CommentRequired Header comments are required 51–100

fr/paris/lutece/plugins/workflow/modules/ticketing/service/task/TaskAssignTicketToUser.java

Rule Violation Line
ConfusingTernary Avoid if (x != y) ..; else ..; 102–127

fr/paris/lutece/plugins/workflow/modules/ticketing/service/task/TaskAssignUnitLinkedToCategory.java

Rule Violation Line
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 85–89

fr/paris/lutece/plugins/workflow/modules/ticketing/service/task/TaskAssignUpTicket.java

Rule Violation Line
CyclomaticComplexity The method 'processTicketingTask(int, HttpServletRequest, Locale)' has a cyclomatic complexity of 10. 81–147
ConfusingTernary Avoid if (x != y) ..; else ..; 84
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 125

fr/paris/lutece/plugins/workflow/modules/ticketing/service/task/TaskAutomaticAgentAssignmentParisFamille.java

Rule Violation Line
UseLocaleWithCaseConversions When doing a String.toLowerCase()/toUpperCase() call, use a Locale 84
CollapsibleIfStatements These nested if statements could be combined 110–113

fr/paris/lutece/plugins/workflow/modules/ticketing/service/task/TaskAutomaticCentralizeAgent.java

Rule Violation Line
TooManyMethods This class has too many methods, consider refactoring it. 68–409
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 111
ShortVariable Avoid variables with short names like pj 305
ShortVariable Avoid variables with short names like pj 345

fr/paris/lutece/plugins/workflow/modules/ticketing/service/task/TaskAutomaticCentralizeAttachments.java

Rule Violation Line
TooManyMethods This class has too many methods, consider refactoring it. 68–436
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 114
ShortVariable Avoid variables with short names like pj 332
ShortVariable Avoid variables with short names like pj 372

fr/paris/lutece/plugins/workflow/modules/ticketing/service/task/TaskAutomaticCentralizeInit.java

Rule Violation Line
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 76
ShortVariable Avoid variables with short names like pj 148

fr/paris/lutece/plugins/workflow/modules/ticketing/service/task/TaskAutomaticCentralizeUsager.java

Rule Violation Line
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 78
ShortVariable Avoid variables with short names like pj 170

fr/paris/lutece/plugins/workflow/modules/ticketing/service/task/TaskAutomaticIdAdminBOInit.java

Rule Violation Line
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 69

fr/paris/lutece/plugins/workflow/modules/ticketing/service/task/TaskChooseNextState.java

Rule Violation Line
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 34–296
CommentRequired Header comments are required 72–295
ImmutableField Private field '_strchannelScanName' could be made final; it is only initialized in the declaration or constructor. 79
ImmutableField Private field '_nActionInitWorkflowId' could be made final; it is only initialized in the declaration or constructor. 82
ImmutableField Private field '_resourceWorkflowService' could be made final; it is only initialized in the declaration or constructor. 84
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 135
ConfusingTernary Avoid if (x != y) ..; else ..; 160–166
CommentRequired Public method and constructor comments are required 191–241
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 226
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 269
CommentRequired Public method and constructor comments are required 276–293

fr/paris/lutece/plugins/workflow/modules/ticketing/service/task/TaskEditTicket.java

Rule Violation Line
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 34–446
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 129
NPathComplexity The method 'processAgentTask(int, HttpServletRequest, Locale, TaskEditTicketConfig)' has an NPath complexity of 288 165–246
UnusedFormalParameter Avoid unused method parameters such as 'locale'. 165
CyclomaticComplexity The method 'processAgentTask(int, HttpServletRequest, Locale, TaskEditTicketConfig)' has a cyclomatic complexity of 11. 165–246
UnusedFormalParameter Avoid unused method parameters such as 'locale'. 261
UnusedFormalParameter Avoid unused method parameters such as 'config'. 261
CyclomaticComplexity The method 'processUserTask(int, HttpServletRequest, Locale, TaskEditTicketConfig)' has a cyclomatic complexity of 13. 261–347
NPathComplexity The method 'processUserTask(int, HttpServletRequest, Locale, TaskEditTicketConfig)' has an NPath complexity of 240 261–347
ShortVariable Avoid variables with short names like pj 303
AvoidReassigningLoopVariables Avoid reassigning the loop control variable 'response' 308
CyclomaticComplexity The method 'unescapeEmojiCharacters(String)' has a cyclomatic complexity of 14. 349–374
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 351
ShortVariable Avoid variables with short names like sb 356
ShortVariable Avoid variables with short names like pj 376
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 403

fr/paris/lutece/plugins/workflow/modules/ticketing/service/task/TaskModifyDraft.java

Rule Violation Line
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 34–407
UnusedPrivateField Avoid unused private fields such as 'ERROR_RESOURCE_NOT_FOUND'. 104
NPathComplexity The method 'processTicketingTask(int, HttpServletRequest, Locale)' has an NPath complexity of 235768328 116–369
ExcessiveMethodLength Avoid really long methods. 116–369
CyclomaticComplexity The method 'processTicketingTask(int, HttpServletRequest, Locale)' has a cyclomatic complexity of 48. 116–369
NcssCount The method 'processTicketingTask(int, HttpServletRequest, Locale)' has a NCSS line count of 126. 116–369
ShortVariable Avoid variables with short names like pj 147
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 155
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 185
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 194
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 203
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 212
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 221
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 230
ConfusingTernary Avoid if (x != y) ..; else ..; 242–320
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 250
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 258
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 266
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 274
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 281
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 292–295
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 294
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 299–302
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 301
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 306–309
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 308
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 313–316
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 315
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 329
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 340
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 349
ShortVariable Avoid variables with short names like pj 401

fr/paris/lutece/plugins/workflow/modules/ticketing/service/task/TaskModifyDraftCategory.java

Rule Violation Line
NcssCount The method 'processTicketingTask(int, HttpServletRequest, Locale)' has a NCSS line count of 72. 93–239
ExcessiveMethodLength Avoid really long methods. 93–239
NPathComplexity The method 'processTicketingTask(int, HttpServletRequest, Locale)' has an NPath complexity of 52178 93–239
CyclomaticComplexity The method 'processTicketingTask(int, HttpServletRequest, Locale)' has a cyclomatic complexity of 27. 93–239
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 121
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 155–163
ConfusingTernary Avoid if (x != y) ..; else ..; 155–163
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 157
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 162
ConfusingTernary Avoid if (x != y) ..; else ..; 178–186
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 180
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 183–186
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 185
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 195
AvoidReassigningLoopVariables Avoid reassigning the loop control variable 'response' 218
EmptyIfStmt Avoid empty if statements 220–222

fr/paris/lutece/plugins/workflow/modules/ticketing/service/task/TaskModifyTicket.java

Rule Violation Line
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 34–386
NPathComplexity The method 'processTicketingTask(int, HttpServletRequest, Locale)' has an NPath complexity of 26749448 109–347
NcssCount The method 'processTicketingTask(int, HttpServletRequest, Locale)' has a NCSS line count of 117. 109–347
ExcessiveMethodLength Avoid really long methods. 109–347
CyclomaticComplexity The method 'processTicketingTask(int, HttpServletRequest, Locale)' has a cyclomatic complexity of 44. 109–347
ShortVariable Avoid variables with short names like pj 141
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 149
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 178
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 187
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 196
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 205
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 214
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 223
ConfusingTernary Avoid if (x != y) ..; else ..; 232–304
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 240
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 249
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 257
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 265
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 276–279
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 278
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 283–286
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 285
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 290–293
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 292
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 297–300
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 299
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 313
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 324
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 333
ShortVariable Avoid variables with short names like pj 379

fr/paris/lutece/plugins/workflow/modules/ticketing/service/task/TaskModifyTicketCategory.java

Rule Violation Line
CyclomaticComplexity The method 'processTicketingTask(int, HttpServletRequest, Locale)' has a cyclomatic complexity of 27. 93–239
NcssCount The method 'processTicketingTask(int, HttpServletRequest, Locale)' has a NCSS line count of 72. 93–239
NPathComplexity The method 'processTicketingTask(int, HttpServletRequest, Locale)' has an NPath complexity of 52178 93–239
ExcessiveMethodLength Avoid really long methods. 93–239
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 121
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 155–163
ConfusingTernary Avoid if (x != y) ..; else ..; 155–163
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 157
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 162
ConfusingTernary Avoid if (x != y) ..; else ..; 178–186
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 180
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 183–186
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 185
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 195
AvoidReassigningLoopVariables Avoid reassigning the loop control variable 'response' 218
EmptyIfStmt Avoid empty if statements 220–222

fr/paris/lutece/plugins/workflow/modules/ticketing/service/task/TaskNotifyWaitingTicket.java

Rule Violation Line
CommentRequired Header comments are required 68–328
ImmutableField Private field '_externalUserDAO' could be made final; it is only initialized in the declaration or constructor. 111
CyclomaticComplexity The method 'processAgentTask(int, Ticket, HttpServletRequest, TaskNotifyWaitingTicketConfig)' has a cyclomatic complexity of 10. 159–232

fr/paris/lutece/plugins/workflow/modules/ticketing/service/task/TaskQualifyTicket.java

Rule Violation Line
ShortVariable Avoid variables with short names like sb 59

fr/paris/lutece/plugins/workflow/modules/ticketing/service/task/TaskReassignTicketToUnitForAUserNotAvailable.java

Rule Violation Line
ImmutableField Private field '_ticketReassignUnitResourceService' could be made final; it is only initialized in the declaration or constructor. 79
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the dao field if you want a default access modifier 81
DefaultPackage Use explicit scoping instead of the default package private level 81
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 125–128
CompareObjectsWithEquals Use equals() to compare object references. 144

fr/paris/lutece/plugins/workflow/modules/ticketing/service/task/TaskRegisterChannelCourrierPostal.java

Rule Violation Line
ImmutableField Private field '_strchannelScanName' could be made final; it is only initialized in the declaration or constructor. 64

fr/paris/lutece/plugins/workflow/modules/ticketing/service/task/TaskRemoveSignalementTicket.java

Rule Violation Line
ShortVariable Avoid variables with short names like sb 59

fr/paris/lutece/plugins/workflow/modules/ticketing/service/task/TaskRemoveVspTicket.java

Rule Violation Line
ShortVariable Avoid variables with short names like sb 59

fr/paris/lutece/plugins/workflow/modules/ticketing/service/task/TaskReply.java

Rule Violation Line
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 34–251
UseLocaleWithCaseConversions When doing a String.toLowerCase()/toUpperCase() call, use a Locale 145
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 148
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 202
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 215
AvoidReassigningLoopVariables Avoid reassigning the loop control variable 'response' 221

fr/paris/lutece/plugins/workflow/modules/ticketing/service/task/TaskReplyAssignUpTicket.java

Rule Violation Line
CyclomaticComplexity The method 'processTicketingTask(int, HttpServletRequest, Locale)' has a cyclomatic complexity of 14. 83–162
NPathComplexity The method 'processTicketingTask(int, HttpServletRequest, Locale)' has an NPath complexity of 530 83–162
ConfusingTernary Avoid if (x != y) ..; else ..; 109–153
ConfusingTernary Avoid if (x != y) ..; else ..; 122–137
ConfusingTernary Avoid if (x != y) ..; else ..; 145
ConfusingTernary Avoid if (x != y) ..; else ..; 146–147
ConfusingTernary Avoid if (x != y) ..; else ..; 148
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 194
ConfusingTernary Avoid if (x != y) ..; else ..; 230

fr/paris/lutece/plugins/workflow/modules/ticketing/service/task/TaskSelectChannel.java

Rule Violation Line
ConfusingTernary Avoid if (x != y) ..; else ..; 83–91

fr/paris/lutece/plugins/workflow/modules/ticketing/service/task/TaskSignalementTicket.java

Rule Violation Line
ShortVariable Avoid variables with short names like sb 59

fr/paris/lutece/plugins/workflow/modules/ticketing/service/task/TaskSphinx.java

Rule Violation Line
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 68

fr/paris/lutece/plugins/workflow/modules/ticketing/service/task/TaskTicketEmailExternalUser.java

Rule Violation Line
ImmutableField Private field '_externalUserDAO' could be made final; it is only initialized in the declaration or constructor. 108
UnusedFormalParameter Avoid unused method parameters such as 'locale'. 160
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 189–209
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 216–223
UnusedFormalParameter Avoid unused method parameters such as 'locale'. 241
UnusedFormalParameter Avoid unused method parameters such as 'config'. 242
UnusedFormalParameter Avoid unused method parameters such as 'locale'. 282
UnusedFormalParameter Avoid unused method parameters such as 'config'. 283

fr/paris/lutece/plugins/workflow/modules/ticketing/service/task/TaskVspTicket.java

Rule Violation Line
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 83

fr/paris/lutece/plugins/workflow/modules/ticketing/service/ticket/EditableTicketService.java

Rule Violation Line
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 260–264

fr/paris/lutece/plugins/workflow/modules/ticketing/utils/UtilConstants.java

Rule Violation Line
CommentRequired Header comments are required 36–44
FieldDeclarationsShouldBeAtStartOfClass Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 43

fr/paris/lutece/plugins/workflow/modules/ticketing/utils/WorkflowTicketingUtils.java

Rule Violation Line
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 113
ConfusingTernary Avoid if (x != y) ..; else ..; 138–150
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 171
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 171
UnnecessaryLocalBeforeReturn Consider simply returning the value vs storing it in local variable 'formatedErrors' 179

fr/paris/lutece/plugins/workflow/modules/ticketing/web/EditTicketXPage.java

Rule Violation Line
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 34–375
ImmutableField Private field '_editableTicketService' could be made final; it is only initialized in the declaration or constructor. 121
ImmutableField Private field '_ticketFormService' could be made final; it is only initialized in the declaration or constructor. 122
ConfusingTernary Avoid if (x != y) ..; else ..; 185–220
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 201
ConfusingTernary Avoid if (x != y) ..; else ..; 213–220
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 249

fr/paris/lutece/plugins/workflow/modules/ticketing/web/ModifyTicketCategoryJspBean.java

Rule Violation Line
CommentRequired Header comments are required 57–105

fr/paris/lutece/plugins/workflow/modules/ticketing/web/TicketExternalUserResponseJspBean.java

Rule Violation Line
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 34–390
ImmutableField Private field '_ticketEmailExternalUserHistoryDAO' could be made final; it is only initialized in the declaration or constructor. 135
ImmutableField Private field '_ticketEmailExternalUserMessageDAO' could be made final; it is only initialized in the declaration or constructor. 136
ImmutableField Private field '_taskTicketExternalUserConfigService' could be made final; it is only initialized in the declaration or constructor. 137
ImmutableField Private field '_resourceHistoryService' could be made final; it is only initialized in the declaration or constructor. 138
CommentRequired Public method and constructor comments are required 152–155
NcssCount The method 'getExternalUserResponseView(HttpServletRequest)' has a NCSS line count of 74. 165–308
ExcessiveMethodLength Avoid really long methods. 165–308
NPathComplexity The method 'getExternalUserResponseView(HttpServletRequest)' has an NPath complexity of 10392 165–308
CyclomaticComplexity The method 'getExternalUserResponseView(HttpServletRequest)' has a cyclomatic complexity of 19. 165–308
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 181
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 182
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 183
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 183
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 184
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 218
AvoidCatchingNPE Avoid catching NullPointerException; consider removing the cause of the NPE. 261
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 261
CommentRequired Protected method constructor comments are required 310–318
ConfusingTernary Avoid if (x != y) ..; else ..; 328–336
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 338
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 350

fr/paris/lutece/plugins/workflow/modules/ticketing/web/task/AssignTicketToUnitTaskComponent.java

Rule Violation Line
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 89
ConfusingTernary Avoid if (x != y) ..; else ..; 94–105
ConfusingTernary Avoid if (x != y) ..; else ..; 157

fr/paris/lutece/plugins/workflow/modules/ticketing/web/task/AssignTicketToUserTaskComponent.java

Rule Violation Line
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 92–95

fr/paris/lutece/plugins/workflow/modules/ticketing/web/task/AssignUpTicketTaskComponent.java

Rule Violation Line
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 87
ConfusingTernary Avoid if (x != y) ..; else ..; 91–102
ConfusingTernary Avoid if (x != y) ..; else ..; 164

fr/paris/lutece/plugins/workflow/modules/ticketing/web/task/ChooseNextStateTaskComponent.java

Rule Violation Line
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 84

fr/paris/lutece/plugins/workflow/modules/ticketing/web/task/EditTicketTaskComponent.java

Rule Violation Line
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 106
ConfusingTernary Avoid if (x != y) ..; else ..; 113–120
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 172
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 237

fr/paris/lutece/plugins/workflow/modules/ticketing/web/task/MarkAsUnreadTaskComponent.java

Rule Violation Line
CommentRequired Header comments are required 54–126
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 75

fr/paris/lutece/plugins/workflow/modules/ticketing/web/task/ModifyDraftCategoryTaskComponent.java

Rule Violation Line
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 34–326
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 113
CyclomaticComplexity The method 'doValidateTask(int, String, HttpServletRequest, Locale, ITask)' has a cyclomatic complexity of 20. 189–278
NPathComplexity The method 'doValidateTask(int, String, HttpServletRequest, Locale, ITask)' has an NPath complexity of 1300 189–278
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 220–224
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 229–246
InefficientEmptyStringCheck String.trim().length() == 0 / String.trim().isEmpty() is an inefficient way to validate a blank String. 231
InefficientEmptyStringCheck String.trim().length() == 0 / String.trim().isEmpty() is an inefficient way to validate a blank String. 286
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 308
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 313

fr/paris/lutece/plugins/workflow/modules/ticketing/web/task/ModifyDraftTaskComponent.java

Rule Violation Line
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 34–239
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 204

fr/paris/lutece/plugins/workflow/modules/ticketing/web/task/ModifyTicketCategoryTaskComponent.java

Rule Violation Line
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 34–326
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 113
NPathComplexity The method 'doValidateTask(int, String, HttpServletRequest, Locale, ITask)' has an NPath complexity of 1300 189–278
CyclomaticComplexity The method 'doValidateTask(int, String, HttpServletRequest, Locale, ITask)' has a cyclomatic complexity of 20. 189–278
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 220–224
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 229–246
InefficientEmptyStringCheck String.trim().length() == 0 / String.trim().isEmpty() is an inefficient way to validate a blank String. 231
InefficientEmptyStringCheck String.trim().length() == 0 / String.trim().isEmpty() is an inefficient way to validate a blank String. 286
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 308
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 313

fr/paris/lutece/plugins/workflow/modules/ticketing/web/task/ModifyTicketNomenclatureTaskComponent.java

Rule Violation Line
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 79

fr/paris/lutece/plugins/workflow/modules/ticketing/web/task/ModifyTicketTaskComponent.java

Rule Violation Line
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 34–225
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 190

fr/paris/lutece/plugins/workflow/modules/ticketing/web/task/NotifyWaitingTicketTaskComponent.java

Rule Violation Line
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 34–392
CommentRequired Header comments are required 72–392
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 133
ConfusingTernary Avoid if (x != y) ..; else ..; 146–169
ExcessiveMethodLength Avoid really long methods. 255–357
CyclomaticComplexity The method 'getDisplayTaskInformation(int, HttpServletRequest, Locale, ITask)' has a cyclomatic complexity of 13. 255–357
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 265
ShortVariable Avoid variables with short names like sb 270
ConfusingTernary Avoid if (x != y) ..; else ..; 273–339
ConfusingTernary Avoid if (x != y) ..; else ..; 285–297
ConfusingTernary Avoid if (x != y) ..; else ..; 299–318
InefficientEmptyStringCheck String.trim().length() == 0 / String.trim().isEmpty() is an inefficient way to validate a blank String. 342
AppendCharacterWithChar Avoid appending characters as strings in StringBuffer.append. 345

fr/paris/lutece/plugins/workflow/modules/ticketing/web/task/ReplyTaskComponent.java

Rule Violation Line
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 93
ConfusingTernary Avoid if (x != y) ..; else ..; 97–106

fr/paris/lutece/plugins/workflow/modules/ticketing/web/task/TicketEmailExternalUserTaskComponent.java

Rule Violation Line
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 34–515
UnusedPrivateField Avoid unused private fields such as '_taskTicketConfigService'. 136
UnusedPrivateField Avoid unused private fields such as '_actionService'. 156
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 185
ConfusingTernary Avoid if (x != y) ..; else ..; 187
ConfusingTernary Avoid if (x != y) ..; else ..; 217
CyclomaticComplexity The method 'getDisplayTaskForm(int, String, HttpServletRequest, Locale, ITask)' has a cyclomatic complexity of 15. 230–301
ConfusingTernary Avoid if (x != y) ..; else ..; 263
ConfusingTernary Avoid if (x != y) ..; else ..; 265
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 277
ConfusingTernary Avoid if (x != y) ..; else ..; 296
CyclomaticComplexity The method 'doValidateTask(int, String, HttpServletRequest, Locale, ITask)' has a cyclomatic complexity of 15. 332–404
NPathComplexity The method 'doValidateTask(int, String, HttpServletRequest, Locale, ITask)' has an NPath complexity of 315 332–404
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 340–341
UnusedLocalVariable Avoid unused local variables such as 'strEmailSubject'. 340
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 364
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 378
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 412
ConfusingTernary Avoid if (x != y) ..; else ..; 422–445

fr/paris/lutece/plugins/workflow/modules/ticketing/web/task/TicketingCommentTaskComponent.java

Rule Violation Line
CommentRequired Header comments are required 63–149
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the taskComponent field if you want a default access modifier 69
DefaultPackage Use explicit scoping instead of the default package private level 69
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 134

fr/paris/lutece/plugins/workflow/modules/ticketing/web/task/TicketingTaskComponent.java

Rule Violation Line
CommentRequired Public method and constructor comments are required 102–105
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 151
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 164
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 164

fr/paris/lutece/plugins/workflow/modules/ticketing/web/task/UploadTicketingTaskComponent.java

Rule Violation Line
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 84
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 110
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 110

Priority 4

fr/paris/lutece/plugins/workflow/modules/ticketing/business/email/message/TicketEmailExternalUserMessage.java

Rule Violation Line
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 170–173

fr/paris/lutece/plugins/workflow/modules/ticketing/business/resourcehistory/ResourceHistoryService.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'fr.paris.lutece.plugins.workflow.modules.ticketing.business.resourcehistory.ResourceHistory' due to existing same package import 'fr.paris.lutece.plugins.workflow.modules.ticketing.business.resourcehistory.*' 121
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'fr.paris.lutece.plugins.workflow.modules.ticketing.business.resourcehistory.ResourceHistory' due to existing same package import 'fr.paris.lutece.plugins.workflow.modules.ticketing.business.resourcehistory.*' 151

fr/paris/lutece/plugins/workflow/modules/ticketing/service/daemon/TicketCreationBrouillonDaemon.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.sql.Timestamp' due to existing import 'java.sql.Timestamp' 210
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.sql.Timestamp' due to existing import 'java.sql.Timestamp' 210
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.util.Date.from' due to existing import 'java.util.Date' 404
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.sql.Timestamp' due to existing import 'java.sql.Timestamp' 405
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.sql.Timestamp' due to existing import 'java.sql.Timestamp' 405
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.util.Date' due to existing import 'java.util.Date' 696

fr/paris/lutece/plugins/workflow/modules/ticketing/service/task/TaskReply.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.util.Date' due to existing import 'java.util.Date' 133

fr/paris/lutece/plugins/workflow/modules/ticketing/service/task/TaskVspTicket.java

Rule Violation Line
UseVarargs Consider using varargs for methods or constructors which take an array the last parameter. 121

Files

fr/paris/lutece/plugins/workflow/modules/ticketing/business/anonymisation/AnonymisationDAO.java

Rule Violation Priority Line
CommentRequired Header comments are required 3 46–221
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 73

fr/paris/lutece/plugins/workflow/modules/ticketing/business/anonymisation/IAnonymisationDAO.java

Rule Violation Priority Line
CommentRequired Header comments are required 3 41–149

fr/paris/lutece/plugins/workflow/modules/ticketing/business/config/MessageDirection.java

Rule Violation Priority Line
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 54
FieldNamingConventions The static field name 'mapMessageDirection' doesn't match '_[a-z][a-zA-Z0-9]*' 1 54
UseLocaleWithCaseConversions When doing a String.toLowerCase()/toUpperCase() call, use a Locale 3 85

fr/paris/lutece/plugins/workflow/modules/ticketing/business/config/TaskAssignTicketToUnitConfigDAO.java

Rule Violation Priority Line
CommentRequired Header comments are required 3 41–131
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 3 55–68

fr/paris/lutece/plugins/workflow/modules/ticketing/business/config/TaskChooseNextStateConfig.java

Rule Violation Priority Line
CommentRequired Header comments are required 3 41–104

fr/paris/lutece/plugins/workflow/modules/ticketing/business/config/TaskChooseNextStateConfigDAO.java

Rule Violation Priority Line
CommentRequired Header comments are required 3 39–114

fr/paris/lutece/plugins/workflow/modules/ticketing/business/config/TaskEditTicketConfig.java

Rule Violation Priority Line
UnusedPrivateField Avoid unused private fields such as '_nIdStateAfterEdition'. 3 53

fr/paris/lutece/plugins/workflow/modules/ticketing/business/config/TaskEditTicketConfigDAO.java

Rule Violation Priority Line
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 3 60–72

fr/paris/lutece/plugins/workflow/modules/ticketing/business/config/TaskMarkAsUnreadConfig.java

Rule Violation Priority Line
CommentRequired Header comments are required 3 41–67

fr/paris/lutece/plugins/workflow/modules/ticketing/business/config/TaskMarkAsUnreadConfigDAO.java

Rule Violation Priority Line
CommentRequired Header comments are required 3 45–153
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 3 59–70

fr/paris/lutece/plugins/workflow/modules/ticketing/business/config/TaskModifyTicketCategoryConfig.java

Rule Violation Priority Line
FormalParameterNamingConventions The method parameter name '_nSelectedEntry' doesn't match '[a-z][a-zA-Z0-9]*' 1 69

fr/paris/lutece/plugins/workflow/modules/ticketing/business/config/TaskModifyTicketCategoryConfigDAO.java

Rule Violation Priority Line
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 3 55–81
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 3 121–128

fr/paris/lutece/plugins/workflow/modules/ticketing/business/config/TaskNotifyWaitingTicketConfig.java

Rule Violation Priority Line
CommentRequired Header comments are required 3 41–124
CommentRequired Public method and constructor comments are required 3 115–118
CommentRequired Public method and constructor comments are required 3 120–123

fr/paris/lutece/plugins/workflow/modules/ticketing/business/config/TaskNotifyWaitingTicketConfigDAO.java

Rule Violation Priority Line
CommentRequired Header comments are required 3 43–183

fr/paris/lutece/plugins/workflow/modules/ticketing/business/config/TaskReplyConfig.java

Rule Violation Priority Line
FormalParameterNamingConventions The method parameter name '_bCloseTicket' doesn't match '[a-z][a-zA-Z0-9]*' 1 84

fr/paris/lutece/plugins/workflow/modules/ticketing/business/email/cc/TicketEmailExternalUserCcDAO.java

Rule Violation Priority Line
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 3 88–103

fr/paris/lutece/plugins/workflow/modules/ticketing/business/email/config/MessageDirectionExternalUser.java

Rule Violation Priority Line
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 55
UseLocaleWithCaseConversions When doing a String.toLowerCase()/toUpperCase() call, use a Locale 3 86

fr/paris/lutece/plugins/workflow/modules/ticketing/business/email/config/TaskTicketEmailExternalUserConfig.java

Rule Violation Priority Line
CommentRequired Public method and constructor comments are required 3 117–120
CommentRequired Public method and constructor comments are required 3 122–125

fr/paris/lutece/plugins/workflow/modules/ticketing/business/email/config/TaskTicketEmailExternalUserConfigDAO.java

Rule Violation Priority Line
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 3 56–94

fr/paris/lutece/plugins/workflow/modules/ticketing/business/email/history/TicketEmailExternalUserHistoryDAO.java

Rule Violation Priority Line
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 3 67–79

fr/paris/lutece/plugins/workflow/modules/ticketing/business/email/message/ITicketEmailExternalUserMessageDAO.java

Rule Violation Priority Line
TooManyMethods This class has too many methods, consider refactoring it. 3 45–147
UnnecessaryModifier Unnecessary modifier 'public' on method 'closeMessagesByIdTicket': the method is declared in an interface type 3 85
ShortVariable Avoid variables with short names like id 3 140
CommentRequired Public method and constructor comments are required 3 140
CommentRequired Public method and constructor comments are required 3 142
CommentRequired Public method and constructor comments are required 3 144
CommentRequired Public method and constructor comments are required 3 146

fr/paris/lutece/plugins/workflow/modules/ticketing/business/email/message/TicketEmailExternalUserMessage.java

Rule Violation Priority Line
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 4 170–173
CommentRequired Public method and constructor comments are required 3 184–187
CommentRequired Public method and constructor comments are required 3 189–192

fr/paris/lutece/plugins/workflow/modules/ticketing/business/email/message/TicketEmailExternalUserMessageDAO.java

Rule Violation Priority Line
TooManyMethods This class has too many methods, consider refactoring it. 3 52–431
AvoidDuplicateLiterals The String literal "workflow.transactionManager" appears 4 times in this file; the first occurrence is on line 123 3 123
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 3 124–141
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 3 159–172
ShortVariable Avoid variables with short names like id 3 367
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 385

fr/paris/lutece/plugins/workflow/modules/ticketing/business/email/provider/TicketEmailExternalUserConstants.java

Rule Violation Priority Line
ClassNamingConventions The utility class name 'TicketEmailExternalUserConstants' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' 1 39–86

fr/paris/lutece/plugins/workflow/modules/ticketing/business/email/provider/TicketEmailExternalUserProvider.java

Rule Violation Priority Line
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 3 34–433
TooManyMethods This class has too many methods, consider refactoring it. 3 73–433
ImmutableField Private field '_ticketEmailExternalUserHistoryDAO' could be made final; it is only initialized in the declaration or constructor. 3 100
ImmutableField Private field '_ticketEmailExternalUserDemandDAO' could be made final; it is only initialized in the declaration or constructor. 3 104
ImmutableField Private field '_ticket' could be made final; it is only initialized in the declaration or constructor. 3 107
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the _dateFormater field if you want a default access modifier 3 110
DefaultPackage Use explicit scoping instead of the default package private level 3 110
SimpleDateFormatNeedsLocale When instantiating a SimpleDateFormat object, specify a Locale 3 110
ConfusingTernary Avoid if (x != y) ..; else ..; 3 296–307
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 3 422–429

fr/paris/lutece/plugins/workflow/modules/ticketing/business/email/recipient/TicketEmailExternalUserRecipientDAO.java

Rule Violation Priority Line
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 3 85–103

fr/paris/lutece/plugins/workflow/modules/ticketing/business/externaluser/ExternalUserComparator.java

Rule Violation Priority Line
ShortVariable Avoid variables with short names like o2 3 55
ShortVariable Avoid variables with short names like o1 3 55
ShortVariable Avoid variables with short names like c 3 93
CyclomaticComplexity The method 'compareAlphaNumeric(String, String, int)' has a cyclomatic complexity of 15. 3 142–226
NPathComplexity The method 'compareAlphaNumeric(String, String, int)' has an NPath complexity of 256 3 142–226

fr/paris/lutece/plugins/workflow/modules/ticketing/business/externaluser/ExternalUserDAO.java

Rule Violation Priority Line
CyclomaticComplexity The method 'findExternalUser(String, String, String, String, String)' has a cyclomatic complexity of 14. 3 126–208
UseObjectForClearerAPI Rather than using a lot of String arguments, consider using a container object for those values. 3 126
NPathComplexity The method 'findExternalUser(String, String, String, String, String)' has an NPath complexity of 4656 3 126–208

fr/paris/lutece/plugins/workflow/modules/ticketing/business/externaluser/IExternalUserDAO.java

Rule Violation Priority Line
UseObjectForClearerAPI Rather than using a lot of String arguments, consider using a container object for those values. 3 78

fr/paris/lutece/plugins/workflow/modules/ticketing/business/externaluser/search/ExternalUserEmailValidationServlet.java

Rule Violation Priority Line
FieldNamingConventions The final field name '_externalUserDAO' doesn't match '[a-z][a-zA-Z0-9]*' 1 87
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 112
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 3 131
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 3 150

fr/paris/lutece/plugins/workflow/modules/ticketing/business/externaluser/search/ExternalUserSearchServlet.java

Rule Violation Priority Line
FieldNamingConventions The final field name '_externalUserDAO' doesn't match '[a-z][a-zA-Z0-9]*' 1 107
FieldNamingConventions The constant name '_attributeService' doesn't match '[A-Z][A-Z_0-9]*' 1 110
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 144

fr/paris/lutece/plugins/workflow/modules/ticketing/business/information/ChooseNextStateTaskInformationHome.java

Rule Violation Priority Line
ClassWithOnlyPrivateConstructorsShouldBeFinal A class which only has private constructors should be final 1 38–88
CommentRequired Header comments are required 3 38–88

fr/paris/lutece/plugins/workflow/modules/ticketing/business/information/TaskInformationDAO.java

Rule Violation Priority Line
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 3 64–74

fr/paris/lutece/plugins/workflow/modules/ticketing/business/resourcehistory/ResourceHistoryDAO.java

Rule Violation Priority Line
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 3 62–102

fr/paris/lutece/plugins/workflow/modules/ticketing/business/resourcehistory/ResourceHistoryService.java

Rule Violation Priority Line
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 114
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'fr.paris.lutece.plugins.workflow.modules.ticketing.business.resourcehistory.ResourceHistory' due to existing same package import 'fr.paris.lutece.plugins.workflow.modules.ticketing.business.resourcehistory.*' 4 121
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'fr.paris.lutece.plugins.workflow.modules.ticketing.business.resourcehistory.ResourceHistory' due to existing same package import 'fr.paris.lutece.plugins.workflow.modules.ticketing.business.resourcehistory.*' 4 151

fr/paris/lutece/plugins/workflow/modules/ticketing/business/ticket/EditableTicketDAO.java

Rule Violation Priority Line
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 3 71–84

fr/paris/lutece/plugins/workflow/modules/ticketing/business/ticket/EditableTicketFieldDAO.java

Rule Violation Priority Line
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 3 64–75

fr/paris/lutece/plugins/workflow/modules/ticketing/service/WorkflowTicketingPlugin.java

Rule Violation Priority Line
UncommentedEmptyMethodBody Document empty method body 3 61–62

fr/paris/lutece/plugins/workflow/modules/ticketing/service/assignment/AutomaticAssignmentAgentParisFamilleService.java

Rule Violation Priority Line
UnnecessaryConstructor Avoid unnecessary constructors - the compiler will generate these for you 3 70–73
ConfusingTernary Avoid if (x != y) ..; else ..; 3 143–151

fr/paris/lutece/plugins/workflow/modules/ticketing/service/daemon/NotifyDaemon.java

Rule Violation Priority Line
CommentRequired Header comments are required 3 57–473
FieldNamingConventions The constant name '_resourceHistoryService' doesn't match '[A-Z][A-Z_0-9]*' 1 62
ImmutableField Private field 'nIdWorkflow' could be made final; it is only initialized in the declaration or constructor. 3 64
FieldNamingConventions The field name 'nIdWorkflow' doesn't match '_[a-z][a-zA-Z0-9]*' 1 64
ImmutableField Private field 'isMinuteMode' could be made final; it is only initialized in the declaration or constructor. 3 67
LinguisticNaming Linguistics Antipattern - The field 'isMinuteMode' indicates linguistically it is a boolean, but it is 'int' 3 67
FieldNamingConventions The field name 'isMinuteMode' doesn't match '_[a-z][a-zA-Z0-9]*' 1 67
ImmutableField Private field 'nIdStateWaiting' could be made final; it is only initialized in the declaration or constructor. 3 71
FieldNamingConventions The field name 'nIdStateWaiting' doesn't match '_[a-z][a-zA-Z0-9]*' 1 71
FieldNamingConventions The field name 'nIdActionRelance' doesn't match '_[a-z][a-zA-Z0-9]*' 1 76
ImmutableField Private field 'nIdActionRelance' could be made final; it is only initialized in the declaration or constructor. 3 76
FieldNamingConventions The field name 'nIdActionSolliciterFromTerrainNiv2' doesn't match '_[a-z][a-zA-Z0-9]*' 1 82
ImmutableField Private field 'nIdActionSolliciterFromTerrainNiv2' could be made final; it is only initialized in the declaration or constructor. 3 82
ImmutableField Private field 'nIdActionSolliciterFromTerrainNiv3' could be made final; it is only initialized in the declaration or constructor. 3 85
FieldNamingConventions The field name 'nIdActionSolliciterFromTerrainNiv3' doesn't match '_[a-z][a-zA-Z0-9]*' 1 85
ImmutableField Private field 'nIdActionSolliciterFromContribNiv2' could be made final; it is only initialized in the declaration or constructor. 3 88
FieldNamingConventions The field name 'nIdActionSolliciterFromContribNiv2' doesn't match '_[a-z][a-zA-Z0-9]*' 1 88
FieldNamingConventions The field name 'nIdActionSolliciterFromContribNiv3' doesn't match '_[a-z][a-zA-Z0-9]*' 1 91
ImmutableField Private field 'nIdActionSolliciterFromContribNiv3' could be made final; it is only initialized in the declaration or constructor. 3 91
ImmutableField Private field 'nIdActionRetourFromTerrainNiv2' could be made final; it is only initialized in the declaration or constructor. 3 98
FieldNamingConventions The field name 'nIdActionRetourFromTerrainNiv2' doesn't match '_[a-z][a-zA-Z0-9]*' 1 98
ImmutableField Private field 'nIdActionRetourFromTerrainNiv3' could be made final; it is only initialized in the declaration or constructor. 3 101
FieldNamingConventions The field name 'nIdActionRetourFromTerrainNiv3' doesn't match '_[a-z][a-zA-Z0-9]*' 1 101
FieldNamingConventions The field name 'nIdActionRetourFromContribNiv2' doesn't match '_[a-z][a-zA-Z0-9]*' 1 104
ImmutableField Private field 'nIdActionRetourFromContribNiv2' could be made final; it is only initialized in the declaration or constructor. 3 104
ImmutableField Private field 'nIdActionRetourFromContribNiv3' could be made final; it is only initialized in the declaration or constructor. 3 107
FieldNamingConventions The field name 'nIdActionRetourFromContribNiv3' doesn't match '_[a-z][a-zA-Z0-9]*' 1 107
ImmutableField Private field 'nbRelanceMax' could be made final; it is only initialized in the declaration or constructor. 3 111
FieldNamingConventions The field name 'nbRelanceMax' doesn't match '_[a-z][a-zA-Z0-9]*' 1 111
FieldNamingConventions The field name 'nFrequence' doesn't match '_[a-z][a-zA-Z0-9]*' 1 113
ImmutableField Private field 'nFrequence' could be made final; it is only initialized in the declaration or constructor. 3 113
CyclomaticComplexity The method 'processNotification()' has a cyclomatic complexity of 18. 3 121–230
ExcessiveMethodLength Avoid really long methods. 3 121–230
InsufficientStringBufferDeclaration StringBuffer constructor is initialized with size 16, but has at least 144 characters appended. 3 123
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 132
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 134
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 135
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 199
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 222–223
ConsecutiveLiteralAppends StringBuffer (or StringBuilder).append is called 2 consecutive times with literals. Use a single append with a single combined String. 3 223
ConsecutiveLiteralAppends StringBuffer (or StringBuilder).append is called 2 consecutive times with literals. Use a single append with a single combined String. 3 224
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 224
CyclomaticComplexity The method 'isConfParamOK(StringBuilder)' has a cyclomatic complexity of 15. 3 239–272
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 3 263
UnusedPrivateMethod Avoid unused private methods such as 'processRelanceNoDate(Ticket,Date)'. 3 282
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 3 424
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 3 458–467

fr/paris/lutece/plugins/workflow/modules/ticketing/service/daemon/NotifyLevel3Daemon.java

Rule Violation Priority Line
CommentRequired Header comments are required 3 59–399
FieldNamingConventions The constant name '_resourceHistoryService' doesn't match '[A-Z][A-Z_0-9]*' 1 64
ImmutableField Private field 'nIdWorkflow' could be made final; it is only initialized in the declaration or constructor. 3 66
FieldNamingConventions The field name 'nIdWorkflow' doesn't match '_[a-z][a-zA-Z0-9]*' 1 66
LinguisticNaming Linguistics Antipattern - The field 'isMinuteMode' indicates linguistically it is a boolean, but it is 'int' 3 68
FieldNamingConventions The field name 'isMinuteMode' doesn't match '_[a-z][a-zA-Z0-9]*' 1 68
ImmutableField Private field 'isMinuteMode' could be made final; it is only initialized in the declaration or constructor. 3 68
ImmutableField Private field 'nIdStateLevel3' could be made final; it is only initialized in the declaration or constructor. 3 73
FieldNamingConventions The field name 'nIdStateLevel3' doesn't match '_[a-z][a-zA-Z0-9]*' 1 73
FieldNamingConventions The field name 'nIdActionRelance' doesn't match '_[a-z][a-zA-Z0-9]*' 1 78
ImmutableField Private field 'nIdActionRelance' could be made final; it is only initialized in the declaration or constructor. 3 78
FieldNamingConventions The field name 'nIdActionEscaladerNiveau3' doesn't match '_[a-z][a-zA-Z0-9]*' 1 84
ImmutableField Private field 'nIdActionEscaladerNiveau3' could be made final; it is only initialized in the declaration or constructor. 3 84
ImmutableField Private field 'nIdActionReturnATraiter' could be made final; it is only initialized in the declaration or constructor. 3 90
FieldNamingConventions The field name 'nIdActionReturnATraiter' doesn't match '_[a-z][a-zA-Z0-9]*' 1 90
ImmutableField Private field 'nbRelanceMax' could be made final; it is only initialized in the declaration or constructor. 3 94
FieldNamingConventions The field name 'nbRelanceMax' doesn't match '_[a-z][a-zA-Z0-9]*' 1 94
FieldNamingConventions The field name 'nFrequence' doesn't match '_[a-z][a-zA-Z0-9]*' 1 96
ImmutableField Private field 'nFrequence' could be made final; it is only initialized in the declaration or constructor. 3 96
ExcessiveMethodLength Avoid really long methods. 3 104–210
CyclomaticComplexity The method 'processNotification()' has a cyclomatic complexity of 15. 3 104–210
InsufficientStringBufferDeclaration StringBuffer constructor is initialized with size 16, but has at least 127 characters appended. 3 106
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 115
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 117
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 118
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 179
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 202–203
ConsecutiveLiteralAppends StringBuffer (or StringBuilder).append is called 2 consecutive times with literals. Use a single append with a single combined String. 3 203
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 204
ConsecutiveLiteralAppends StringBuffer (or StringBuilder).append is called 2 consecutive times with literals. Use a single append with a single combined String. 3 204
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 3 241
UnusedPrivateMethod Avoid unused private methods such as 'processRelanceNoDate(Ticket,Date)'. 3 260
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 3 310
AssignmentInOperand Avoid assignments in operands 3 385

fr/paris/lutece/plugins/workflow/modules/ticketing/service/daemon/NotifyUsagerDaemon.java

Rule Violation Priority Line
CommentRequired Header comments are required 3 57–387
FieldNamingConventions The constant name '_resourceHistoryService' doesn't match '[A-Z][A-Z_0-9]*' 1 62
FieldNamingConventions The field name 'nIdWorkflow' doesn't match '_[a-z][a-zA-Z0-9]*' 1 64
ImmutableField Private field 'nIdWorkflow' could be made final; it is only initialized in the declaration or constructor. 3 64
ImmutableField Private field 'isMinuteMode' could be made final; it is only initialized in the declaration or constructor. 3 66
LinguisticNaming Linguistics Antipattern - The field 'isMinuteMode' indicates linguistically it is a boolean, but it is 'int' 3 66
FieldNamingConventions The field name 'isMinuteMode' doesn't match '_[a-z][a-zA-Z0-9]*' 1 66
FieldNamingConventions The field name 'nIdStateWaitingUsager' doesn't match '_[a-z][a-zA-Z0-9]*' 1 71
ImmutableField Private field 'nIdStateWaitingUsager' could be made final; it is only initialized in the declaration or constructor. 3 71
FieldNamingConventions The field name 'nIdActionRelance' doesn't match '_[a-z][a-zA-Z0-9]*' 1 77
ImmutableField Private field 'nIdActionRelance' could be made final; it is only initialized in the declaration or constructor. 3 77
ImmutableField Private field 'nIdActionDemandeComplementUsager' could be made final; it is only initialized in the declaration or constructor. 3 83
FieldNamingConventions The field name 'nIdActionDemandeComplementUsager' doesn't match '_[a-z][a-zA-Z0-9]*' 1 83
FieldNamingConventions The field name 'nIdActionRetourFromDemandeComplementUsager' doesn't match '_[a-z][a-zA-Z0-9]*' 1 90
ImmutableField Private field 'nIdActionRetourFromDemandeComplementUsager' could be made final; it is only initialized in the declaration or constructor. 3 90
FieldNamingConventions The field name 'nbRelanceMax' doesn't match '_[a-z][a-zA-Z0-9]*' 1 94
ImmutableField Private field 'nbRelanceMax' could be made final; it is only initialized in the declaration or constructor. 3 94
FieldNamingConventions The field name 'nFrequence' doesn't match '_[a-z][a-zA-Z0-9]*' 1 96
ImmutableField Private field 'nFrequence' could be made final; it is only initialized in the declaration or constructor. 3 96
ExcessiveMethodLength Avoid really long methods. 3 104–210
CyclomaticComplexity The method 'processNotification()' has a cyclomatic complexity of 15. 3 104–210
InsufficientStringBufferDeclaration StringBuffer constructor is initialized with size 16, but has at least 158 characters appended. 3 106
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 115
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 117
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 118
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 179
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 202–203
ConsecutiveLiteralAppends StringBuffer (or StringBuilder).append is called 2 consecutive times with literals. Use a single append with a single combined String. 3 203
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 204
ConsecutiveLiteralAppends StringBuffer (or StringBuilder).append is called 2 consecutive times with literals. Use a single append with a single combined String. 3 204
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 3 242
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 3 339
AssignmentInOperand Avoid assignments in operands 3 373

fr/paris/lutece/plugins/workflow/modules/ticketing/service/daemon/TicketCreationBrouillonDaemon.java

Rule Violation Priority Line
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 3 34–722
GodClass Possible God Class (WMC=59, ATFD=113, TCC=16.374%) 3 101–722
TooManyMethods This class has too many methods, consider refactoring it. 3 102–722
FieldNamingConventions The final field name '_stockageS3DaemonMinio' doesn't match '[a-z][a-zA-Z0-9]*' 1 121
FieldNamingConventions The final field name '_stockageS3ScannerDaemonNetapp' doesn't match '[a-z][a-zA-Z0-9]*' 1 122
ImmutableField Private field '_nIdStateDeleted' could be made final; it is only initialized in the declaration or constructor. 3 127
ImmutableField Private field '_strchannelScanName' could be made final; it is only initialized in the declaration or constructor. 3 129
ImmutableField Private field '_strAdminUserId' could be made final; it is only initialized in the declaration or constructor. 3 130
ImmutableField Private field '_strEmailSender' could be made final; it is only initialized in the declaration or constructor. 3 131
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the _ticketInitService field if you want a default access modifier 3 137
DefaultPackage Use explicit scoping instead of the default package private level 3 137
UnnecessaryConstructor Avoid unnecessary constructors - the compiler will generate these for you 3 146–149
ShortVariable Avoid variables with short names like sb 3 157
UnusedFormalParameter Avoid unused method parameters such as 'sb'. 3 169
ShortVariable Avoid variables with short names like sb 3 169
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.sql.Timestamp' due to existing import 'java.sql.Timestamp' 4 210
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.sql.Timestamp' due to existing import 'java.sql.Timestamp' 4 210
ConfusingTernary Avoid if (x != y) ..; else ..; 3 215–222
ConfusingTernary Avoid if (x != y) ..; else ..; 3 252–279
ShortVariable Avoid variables with short names like pj 3 267
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 280
ShortVariable Avoid variables with short names like sb 3 302
ShortVariable Avoid variables with short names like n 3 318
ShortVariable Avoid variables with short names like sb 3 332
ShortVariable Avoid variables with short names like n 3 332
ConfusingTernary Avoid if (x != y) ..; else ..; 3 346–376
ConfusingTernary Avoid if (x != y) ..; else ..; 3 351–372
PositionLiteralsFirstInComparisons Position literals first in String comparisons 3 353
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 3 361
UseUnderscoresInNumericLiterals Number 10000000 should separate every third digit with an underscore 3 361
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.util.Date.from' due to existing import 'java.util.Date' 4 404
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.sql.Timestamp' due to existing import 'java.sql.Timestamp' 4 405
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.sql.Timestamp' due to existing import 'java.sql.Timestamp' 4 405
ConfusingTernary Avoid if (x != y) ..; else ..; 3 409–453
ConfusingTernary Avoid if (x != y) ..; else ..; 3 421–447
ShortVariable Avoid variables with short names like pj 3 436
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 455
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 3 489
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 516
ShortVariable Avoid variables with short names like pj 3 550
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 3 551
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 618
ShortVariable Avoid variables with short names like pj 3 644
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.util.Date' due to existing import 'java.util.Date' 4 696

fr/paris/lutece/plugins/workflow/modules/ticketing/service/daemon/TicketPjMigrationDaemon.java

Rule Violation Priority Line
GodClass Possible God Class (WMC=50, ATFD=41, TCC=2.500%) 3 66–468
TooManyMethods This class has too many methods, consider refactoring it. 3 67–468
UnnecessaryConstructor Avoid unnecessary constructors - the compiler will generate these for you 3 79–82
ShortVariable Avoid variables with short names like sb 3 90
ShortVariable Avoid variables with short names like sb 3 105
ConfusingTernary Avoid if (x != y) ..; else ..; 3 109–164
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 150
AvoidReassigningParameters Avoid reassigning parameters such as 'idCoreUploadFinal' 2 263
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 279
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 279
AvoidReassigningParameters Avoid reassigning parameters such as 'idFileList' 2 354
ShortVariable Avoid variables with short names like pj 3 376
ShortVariable Avoid variables with short names like pj 3 411

fr/paris/lutece/plugins/workflow/modules/ticketing/service/daemon/TicketPurgeAnonymisationDaemon.java

Rule Violation Priority Line
FieldNamingConventions The static field name 'daoResourceHist' doesn't match '_[a-z][a-zA-Z0-9]*' 1 70
ImmutableField Private field 'purgeAnonymisationService' could be made final; it is only initialized in the declaration or constructor. 3 72
FieldNamingConventions The field name 'purgeAnonymisationService' doesn't match '_[a-z][a-zA-Z0-9]*' 1 72
FieldNamingConventions The static field name 'plugin' doesn't match '_[a-z][a-zA-Z0-9]*' 1 74
CommentRequired Public method and constructor comments are required 3 79–82
UnnecessaryConstructor Avoid unnecessary constructors - the compiler will generate these for you 3 79–82
ShortVariable Avoid variables with short names like sb 3 90
ShortVariable Avoid variables with short names like sb 3 104
ShortVariable Avoid variables with short names like sb 3 127
ConfusingTernary Avoid if (x != y) ..; else ..; 3 132–134
ConfusingTernary Avoid if (x != y) ..; else ..; 3 147–187
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 174
ShortVariable Avoid variables with short names like sb 3 205
SimpleDateFormatNeedsLocale When instantiating a SimpleDateFormat object, specify a Locale 3 208
ShortVariable Avoid variables with short names like sb 3 246

fr/paris/lutece/plugins/workflow/modules/ticketing/service/purgeanonymisation/IPurgeAnonymisationService.java

Rule Violation Priority Line
CommentRequired Public method and constructor comments are required 3 88

fr/paris/lutece/plugins/workflow/modules/ticketing/service/purgeanonymisation/PurgeAnonymisationService.java

Rule Violation Priority Line
TooManyMethods This class has too many methods, consider refactoring it. 3 65–227
FieldNamingConventions The field name 'daoEmailExternalUsermessage' doesn't match '_[a-z][a-zA-Z0-9]*' 1 70
FieldNamingConventions The field name 'daoTaskInfo' doesn't match '_[a-z][a-zA-Z0-9]*' 1 72
FieldNamingConventions The field name 'daoEditableTicketHist' doesn't match '_[a-z][a-zA-Z0-9]*' 1 74
FieldNamingConventions The field name 'daoEditableTicketFieldDAO' doesn't match '_[a-z][a-zA-Z0-9]*' 1 76
FieldNamingConventions The field name 'daoAnonymisation' doesn't match '_[a-z][a-zA-Z0-9]*' 1 78
FieldNamingConventions The field name 'daoEmailExternalUserRecipientDAO' doesn't match '_[a-z][a-zA-Z0-9]*' 1 80
FieldNamingConventions The field name 'daoEmailExternalUserCcHist' doesn't match '_[a-z][a-zA-Z0-9]*' 1 82
FieldNamingConventions The field name 'daoEmailExternalUserHist' doesn't match '_[a-z][a-zA-Z0-9]*' 1 84
FieldNamingConventions The final field name '_stockageS3DaemonMinio' doesn't match '[a-z][a-zA-Z0-9]*' 1 86
FieldNamingConventions The final field name '_stockageS3DaemonNetapp' doesn't match '[a-z][a-zA-Z0-9]*' 1 87
FieldNamingConventions The static field name 'plugin' doesn't match '_[a-z][a-zA-Z0-9]*' 1 89
UnusedFormalParameter Avoid unused method parameters such as 'plugin2'. 3 108
UnusedFormalParameter Avoid unused method parameters such as 'plugin2'. 3 114
UnusedFormalParameter Avoid unused method parameters such as 'plugin2'. 3 122
UnusedFormalParameter Avoid unused method parameters such as 'plugin2'. 3 128
UnusedFormalParameter Avoid unused method parameters such as 'plugin2'. 3 134
UnusedFormalParameter Avoid unused method parameters such as 'plugin2'. 3 142
ShortVariable Avoid variables with short names like pj 3 182
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 3 191

fr/paris/lutece/plugins/workflow/modules/ticketing/service/task/AbstractTicketingTask.java

Rule Violation Priority Line
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 83

fr/paris/lutece/plugins/workflow/modules/ticketing/service/task/TaskAssignTicketToMe.java

Rule Violation Priority Line
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 3 108–111

fr/paris/lutece/plugins/workflow/modules/ticketing/service/task/TaskAssignTicketToRQ.java

Rule Violation Priority Line
CommentRequired Header comments are required 3 51–100

fr/paris/lutece/plugins/workflow/modules/ticketing/service/task/TaskAssignTicketToUser.java

Rule Violation Priority Line
ConfusingTernary Avoid if (x != y) ..; else ..; 3 102–127

fr/paris/lutece/plugins/workflow/modules/ticketing/service/task/TaskAssignUnitLinkedToCategory.java

Rule Violation Priority Line
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 3 85–89

fr/paris/lutece/plugins/workflow/modules/ticketing/service/task/TaskAssignUpTicket.java

Rule Violation Priority Line
CyclomaticComplexity The method 'processTicketingTask(int, HttpServletRequest, Locale)' has a cyclomatic complexity of 10. 3 81–147
ConfusingTernary Avoid if (x != y) ..; else ..; 3 84
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 125

fr/paris/lutece/plugins/workflow/modules/ticketing/service/task/TaskAutomaticAgentAssignmentParisFamille.java

Rule Violation Priority Line
UseLocaleWithCaseConversions When doing a String.toLowerCase()/toUpperCase() call, use a Locale 3 84
CollapsibleIfStatements These nested if statements could be combined 3 110–113

fr/paris/lutece/plugins/workflow/modules/ticketing/service/task/TaskAutomaticCentralizeAgent.java

Rule Violation Priority Line
TooManyMethods This class has too many methods, consider refactoring it. 3 68–409
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 111
AvoidReassigningParameters Avoid reassigning parameters such as 'idFileList' 2 283
ShortVariable Avoid variables with short names like pj 3 305
ShortVariable Avoid variables with short names like pj 3 345

fr/paris/lutece/plugins/workflow/modules/ticketing/service/task/TaskAutomaticCentralizeAttachments.java

Rule Violation Priority Line
TooManyMethods This class has too many methods, consider refactoring it. 3 68–436
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 114
AvoidReassigningParameters Avoid reassigning parameters such as 'idFileList' 2 310
ShortVariable Avoid variables with short names like pj 3 332
ShortVariable Avoid variables with short names like pj 3 372

fr/paris/lutece/plugins/workflow/modules/ticketing/service/task/TaskAutomaticCentralizeInit.java

Rule Violation Priority Line
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 76
ShortVariable Avoid variables with short names like pj 3 148

fr/paris/lutece/plugins/workflow/modules/ticketing/service/task/TaskAutomaticCentralizeUsager.java

Rule Violation Priority Line
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 78
AvoidReassigningParameters Avoid reassigning parameters such as 'idFileList' 2 148
ShortVariable Avoid variables with short names like pj 3 170

fr/paris/lutece/plugins/workflow/modules/ticketing/service/task/TaskAutomaticIdAdminBOInit.java

Rule Violation Priority Line
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 3 69

fr/paris/lutece/plugins/workflow/modules/ticketing/service/task/TaskChooseNextState.java

Rule Violation Priority Line
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 3 34–296
CommentRequired Header comments are required 3 72–295
ImmutableField Private field '_strchannelScanName' could be made final; it is only initialized in the declaration or constructor. 3 79
ImmutableField Private field '_nActionInitWorkflowId' could be made final; it is only initialized in the declaration or constructor. 3 82
ImmutableField Private field '_resourceWorkflowService' could be made final; it is only initialized in the declaration or constructor. 3 84
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 135
ConfusingTernary Avoid if (x != y) ..; else ..; 3 160–166
CommentRequired Public method and constructor comments are required 3 191–241
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 226
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 269
CommentRequired Public method and constructor comments are required 3 276–293

fr/paris/lutece/plugins/workflow/modules/ticketing/service/task/TaskEditTicket.java

Rule Violation Priority Line
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 3 34–446
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 129
NPathComplexity The method 'processAgentTask(int, HttpServletRequest, Locale, TaskEditTicketConfig)' has an NPath complexity of 288 3 165–246
UnusedFormalParameter Avoid unused method parameters such as 'locale'. 3 165
CyclomaticComplexity The method 'processAgentTask(int, HttpServletRequest, Locale, TaskEditTicketConfig)' has a cyclomatic complexity of 11. 3 165–246
UnusedFormalParameter Avoid unused method parameters such as 'locale'. 3 261
UnusedFormalParameter Avoid unused method parameters such as 'config'. 3 261
CyclomaticComplexity The method 'processUserTask(int, HttpServletRequest, Locale, TaskEditTicketConfig)' has a cyclomatic complexity of 13. 3 261–347
NPathComplexity The method 'processUserTask(int, HttpServletRequest, Locale, TaskEditTicketConfig)' has an NPath complexity of 240 3 261–347
ShortVariable Avoid variables with short names like pj 3 303
AvoidReassigningLoopVariables Avoid reassigning the loop control variable 'response' 3 308
CyclomaticComplexity The method 'unescapeEmojiCharacters(String)' has a cyclomatic complexity of 14. 3 349–374
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 3 351
ShortVariable Avoid variables with short names like sb 3 356
ShortVariable Avoid variables with short names like pj 3 376
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 403

fr/paris/lutece/plugins/workflow/modules/ticketing/service/task/TaskModifyDraft.java

Rule Violation Priority Line
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 3 34–407
UnusedPrivateField Avoid unused private fields such as 'ERROR_RESOURCE_NOT_FOUND'. 3 104
NPathComplexity The method 'processTicketingTask(int, HttpServletRequest, Locale)' has an NPath complexity of 235768328 3 116–369
ExcessiveMethodLength Avoid really long methods. 3 116–369
CyclomaticComplexity The method 'processTicketingTask(int, HttpServletRequest, Locale)' has a cyclomatic complexity of 48. 3 116–369
NcssCount The method 'processTicketingTask(int, HttpServletRequest, Locale)' has a NCSS line count of 126. 3 116–369
ShortVariable Avoid variables with short names like pj 3 147
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 3 155
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 3 185
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 3 194
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 3 203
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 3 212
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 3 221
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 3 230
ConfusingTernary Avoid if (x != y) ..; else ..; 3 242–320
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 3 250
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 3 258
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 3 266
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 3 274
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 3 281
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 3 292–295
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 3 294
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 3 299–302
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 3 301
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 3 306–309
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 3 308
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 3 313–316
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 3 315
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 3 329
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 3 340
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 3 349
ShortVariable Avoid variables with short names like pj 3 401

fr/paris/lutece/plugins/workflow/modules/ticketing/service/task/TaskModifyDraftCategory.java

Rule Violation Priority Line
NcssCount The method 'processTicketingTask(int, HttpServletRequest, Locale)' has a NCSS line count of 72. 3 93–239
ExcessiveMethodLength Avoid really long methods. 3 93–239
NPathComplexity The method 'processTicketingTask(int, HttpServletRequest, Locale)' has an NPath complexity of 52178 3 93–239
CyclomaticComplexity The method 'processTicketingTask(int, HttpServletRequest, Locale)' has a cyclomatic complexity of 27. 3 93–239
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 3 121
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 3 155–163
ConfusingTernary Avoid if (x != y) ..; else ..; 3 155–163
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 3 157
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 3 162
ConfusingTernary Avoid if (x != y) ..; else ..; 3 178–186
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 3 180
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 3 183–186
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 3 185
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 3 195
AvoidReassigningLoopVariables Avoid reassigning the loop control variable 'response' 3 218
EmptyIfStmt Avoid empty if statements 3 220–222

fr/paris/lutece/plugins/workflow/modules/ticketing/service/task/TaskModifyTicket.java

Rule Violation Priority Line
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 3 34–386
NPathComplexity The method 'processTicketingTask(int, HttpServletRequest, Locale)' has an NPath complexity of 26749448 3 109–347
NcssCount The method 'processTicketingTask(int, HttpServletRequest, Locale)' has a NCSS line count of 117. 3 109–347
ExcessiveMethodLength Avoid really long methods. 3 109–347
CyclomaticComplexity The method 'processTicketingTask(int, HttpServletRequest, Locale)' has a cyclomatic complexity of 44. 3 109–347
ShortVariable Avoid variables with short names like pj 3 141
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 3 149
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 3 178
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 3 187
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 3 196
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 3 205
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 3 214
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 3 223
ConfusingTernary Avoid if (x != y) ..; else ..; 3 232–304
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 3 240
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 3 249
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 3 257
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 3 265
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 3 276–279
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 3 278
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 3 283–286
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 3 285
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 3 290–293
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 3 292
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 3 297–300
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 3 299
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 3 313
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 3 324
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 3 333
ShortVariable Avoid variables with short names like pj 3 379

fr/paris/lutece/plugins/workflow/modules/ticketing/service/task/TaskModifyTicketCategory.java

Rule Violation Priority Line
CyclomaticComplexity The method 'processTicketingTask(int, HttpServletRequest, Locale)' has a cyclomatic complexity of 27. 3 93–239
NcssCount The method 'processTicketingTask(int, HttpServletRequest, Locale)' has a NCSS line count of 72. 3 93–239
NPathComplexity The method 'processTicketingTask(int, HttpServletRequest, Locale)' has an NPath complexity of 52178 3 93–239
ExcessiveMethodLength Avoid really long methods. 3 93–239
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 3 121
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 3 155–163
ConfusingTernary Avoid if (x != y) ..; else ..; 3 155–163
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 3 157
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 3 162
ConfusingTernary Avoid if (x != y) ..; else ..; 3 178–186
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 3 180
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 3 183–186
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 3 185
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 3 195
AvoidReassigningLoopVariables Avoid reassigning the loop control variable 'response' 3 218
EmptyIfStmt Avoid empty if statements 3 220–222

fr/paris/lutece/plugins/workflow/modules/ticketing/service/task/TaskNotifyWaitingTicket.java

Rule Violation Priority Line
CommentRequired Header comments are required 3 68–328
ImmutableField Private field '_externalUserDAO' could be made final; it is only initialized in the declaration or constructor. 3 111
CyclomaticComplexity The method 'processAgentTask(int, Ticket, HttpServletRequest, TaskNotifyWaitingTicketConfig)' has a cyclomatic complexity of 10. 3 159–232

fr/paris/lutece/plugins/workflow/modules/ticketing/service/task/TaskQualifyTicket.java

Rule Violation Priority Line
ShortVariable Avoid variables with short names like sb 3 59

fr/paris/lutece/plugins/workflow/modules/ticketing/service/task/TaskReassignTicketToUnitForAUserNotAvailable.java

Rule Violation Priority Line
ImmutableField Private field '_ticketReassignUnitResourceService' could be made final; it is only initialized in the declaration or constructor. 3 79
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the dao field if you want a default access modifier 3 81
DefaultPackage Use explicit scoping instead of the default package private level 3 81
FieldNamingConventions The field name 'dao' doesn't match '_[a-z][a-zA-Z0-9]*' 1 81
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 3 125–128
CompareObjectsWithEquals Use equals() to compare object references. 3 144

fr/paris/lutece/plugins/workflow/modules/ticketing/service/task/TaskRegisterChannelCourrierPostal.java

Rule Violation Priority Line
ImmutableField Private field '_strchannelScanName' could be made final; it is only initialized in the declaration or constructor. 3 64

fr/paris/lutece/plugins/workflow/modules/ticketing/service/task/TaskRemoveSignalementTicket.java

Rule Violation Priority Line
ShortVariable Avoid variables with short names like sb 3 59

fr/paris/lutece/plugins/workflow/modules/ticketing/service/task/TaskRemoveVspTicket.java

Rule Violation Priority Line
ShortVariable Avoid variables with short names like sb 3 59

fr/paris/lutece/plugins/workflow/modules/ticketing/service/task/TaskReply.java

Rule Violation Priority Line
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 3 34–251
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.util.Date' due to existing import 'java.util.Date' 4 133
UseLocaleWithCaseConversions When doing a String.toLowerCase()/toUpperCase() call, use a Locale 3 145
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 148
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 202
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 215
AvoidReassigningLoopVariables Avoid reassigning the loop control variable 'response' 3 221

fr/paris/lutece/plugins/workflow/modules/ticketing/service/task/TaskReplyAssignUpTicket.java

Rule Violation Priority Line
CyclomaticComplexity The method 'processTicketingTask(int, HttpServletRequest, Locale)' has a cyclomatic complexity of 14. 3 83–162
NPathComplexity The method 'processTicketingTask(int, HttpServletRequest, Locale)' has an NPath complexity of 530 3 83–162
ConfusingTernary Avoid if (x != y) ..; else ..; 3 109–153
ConfusingTernary Avoid if (x != y) ..; else ..; 3 122–137
ConfusingTernary Avoid if (x != y) ..; else ..; 3 145
ConfusingTernary Avoid if (x != y) ..; else ..; 3 146–147
ConfusingTernary Avoid if (x != y) ..; else ..; 3 148
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 194
ConfusingTernary Avoid if (x != y) ..; else ..; 3 230

fr/paris/lutece/plugins/workflow/modules/ticketing/service/task/TaskSelectChannel.java

Rule Violation Priority Line
ConfusingTernary Avoid if (x != y) ..; else ..; 3 83–91

fr/paris/lutece/plugins/workflow/modules/ticketing/service/task/TaskSignalementTicket.java

Rule Violation Priority Line
ShortVariable Avoid variables with short names like sb 3 59

fr/paris/lutece/plugins/workflow/modules/ticketing/service/task/TaskSphinx.java

Rule Violation Priority Line
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 68

fr/paris/lutece/plugins/workflow/modules/ticketing/service/task/TaskTicketEmailExternalUser.java

Rule Violation Priority Line
ImmutableField Private field '_externalUserDAO' could be made final; it is only initialized in the declaration or constructor. 3 108
UnusedFormalParameter Avoid unused method parameters such as 'locale'. 3 160
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 3 189–209
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 3 216–223
UnusedFormalParameter Avoid unused method parameters such as 'locale'. 3 241
UnusedFormalParameter Avoid unused method parameters such as 'config'. 3 242
UnusedFormalParameter Avoid unused method parameters such as 'locale'. 3 282
UnusedFormalParameter Avoid unused method parameters such as 'config'. 3 283

fr/paris/lutece/plugins/workflow/modules/ticketing/service/task/TaskVspTicket.java

Rule Violation Priority Line
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 3 83
UseVarargs Consider using varargs for methods or constructors which take an array the last parameter. 4 121

fr/paris/lutece/plugins/workflow/modules/ticketing/service/ticket/EditableTicketService.java

Rule Violation Priority Line
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 3 260–264

fr/paris/lutece/plugins/workflow/modules/ticketing/utils/TaskEditTicketConstants.java

Rule Violation Priority Line
ClassNamingConventions The utility class name 'TaskEditTicketConstants' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' 1 41–60

fr/paris/lutece/plugins/workflow/modules/ticketing/utils/UtilConstants.java

Rule Violation Priority Line
CommentRequired Header comments are required 3 36–44
ClassWithOnlyPrivateConstructorsShouldBeFinal A class which only has private constructors should be final 1 36–44
ClassNamingConventions The utility class name 'UtilConstants' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' 1 36–44
FieldDeclarationsShouldBeAtStartOfClass Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 3 43

fr/paris/lutece/plugins/workflow/modules/ticketing/utils/WorkflowTicketingUtils.java

Rule Violation Priority Line
FieldNamingConventions The constant name '_resourceHistoryService' doesn't match '[A-Z][A-Z_0-9]*' 1 64
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 113
ConfusingTernary Avoid if (x != y) ..; else ..; 3 138–150
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 171
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 171
UnnecessaryLocalBeforeReturn Consider simply returning the value vs storing it in local variable 'formatedErrors' 3 179

fr/paris/lutece/plugins/workflow/modules/ticketing/web/EditTicketXPage.java

Rule Violation Priority Line
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 3 34–375
ImmutableField Private field '_editableTicketService' could be made final; it is only initialized in the declaration or constructor. 3 121
ImmutableField Private field '_ticketFormService' could be made final; it is only initialized in the declaration or constructor. 3 122
ConfusingTernary Avoid if (x != y) ..; else ..; 3 185–220
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 201
ConfusingTernary Avoid if (x != y) ..; else ..; 3 213–220
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 249

fr/paris/lutece/plugins/workflow/modules/ticketing/web/ModifyTicketCategoryJspBean.java

Rule Violation Priority Line
CommentRequired Header comments are required 3 57–105
FieldNamingConventions The final field name '_ticketFormService' doesn't match '[a-z][a-zA-Z0-9]*' 1 71
FieldNamingConventions The final field name '_taskModifyTicketCategoryConfigService' doesn't match '[a-z][a-zA-Z0-9]*' 1 72

fr/paris/lutece/plugins/workflow/modules/ticketing/web/TicketExternalUserResponseJspBean.java

Rule Violation Priority Line
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 3 34–390
ImmutableField Private field '_ticketEmailExternalUserHistoryDAO' could be made final; it is only initialized in the declaration or constructor. 3 135
ImmutableField Private field '_ticketEmailExternalUserMessageDAO' could be made final; it is only initialized in the declaration or constructor. 3 136
ImmutableField Private field '_taskTicketExternalUserConfigService' could be made final; it is only initialized in the declaration or constructor. 3 137
ImmutableField Private field '_resourceHistoryService' could be made final; it is only initialized in the declaration or constructor. 3 138
CommentRequired Public method and constructor comments are required 3 152–155
NcssCount The method 'getExternalUserResponseView(HttpServletRequest)' has a NCSS line count of 74. 3 165–308
ExcessiveMethodLength Avoid really long methods. 3 165–308
NPathComplexity The method 'getExternalUserResponseView(HttpServletRequest)' has an NPath complexity of 10392 3 165–308
CyclomaticComplexity The method 'getExternalUserResponseView(HttpServletRequest)' has a cyclomatic complexity of 19. 3 165–308
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 181
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 182
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 183
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 183
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 184
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 3 218
AvoidCatchingNPE Avoid catching NullPointerException; consider removing the cause of the NPE. 3 261
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 261
CommentRequired Protected method constructor comments are required 3 310–318
ConfusingTernary Avoid if (x != y) ..; else ..; 3 328–336
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 338
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 350

fr/paris/lutece/plugins/workflow/modules/ticketing/web/task/AssignTicketToUnitTaskComponent.java

Rule Violation Priority Line
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 89
ConfusingTernary Avoid if (x != y) ..; else ..; 3 94–105
ConfusingTernary Avoid if (x != y) ..; else ..; 3 157

fr/paris/lutece/plugins/workflow/modules/ticketing/web/task/AssignTicketToUserTaskComponent.java

Rule Violation Priority Line
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 3 92–95

fr/paris/lutece/plugins/workflow/modules/ticketing/web/task/AssignUpTicketTaskComponent.java

Rule Violation Priority Line
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 87
ConfusingTernary Avoid if (x != y) ..; else ..; 3 91–102
ConfusingTernary Avoid if (x != y) ..; else ..; 3 164

fr/paris/lutece/plugins/workflow/modules/ticketing/web/task/ChooseNextStateTaskComponent.java

Rule Violation Priority Line
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 84

fr/paris/lutece/plugins/workflow/modules/ticketing/web/task/EditTicketTaskComponent.java

Rule Violation Priority Line
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 106
ConfusingTernary Avoid if (x != y) ..; else ..; 3 113–120
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 172
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 237

fr/paris/lutece/plugins/workflow/modules/ticketing/web/task/MarkAsUnreadTaskComponent.java

Rule Violation Priority Line
CommentRequired Header comments are required 3 54–126
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 75

fr/paris/lutece/plugins/workflow/modules/ticketing/web/task/ModifyDraftCategoryTaskComponent.java

Rule Violation Priority Line
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 3 34–326
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 113
CyclomaticComplexity The method 'doValidateTask(int, String, HttpServletRequest, Locale, ITask)' has a cyclomatic complexity of 20. 3 189–278
NPathComplexity The method 'doValidateTask(int, String, HttpServletRequest, Locale, ITask)' has an NPath complexity of 1300 3 189–278
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 3 220–224
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 3 229–246
InefficientEmptyStringCheck String.trim().length() == 0 / String.trim().isEmpty() is an inefficient way to validate a blank String. 3 231
InefficientEmptyStringCheck String.trim().length() == 0 / String.trim().isEmpty() is an inefficient way to validate a blank String. 3 286
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 3 308
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 3 313

fr/paris/lutece/plugins/workflow/modules/ticketing/web/task/ModifyDraftTaskComponent.java

Rule Violation Priority Line
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 3 34–239
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 3 204

fr/paris/lutece/plugins/workflow/modules/ticketing/web/task/ModifyTicketCategoryTaskComponent.java

Rule Violation Priority Line
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 3 34–326
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 113
NPathComplexity The method 'doValidateTask(int, String, HttpServletRequest, Locale, ITask)' has an NPath complexity of 1300 3 189–278
CyclomaticComplexity The method 'doValidateTask(int, String, HttpServletRequest, Locale, ITask)' has a cyclomatic complexity of 20. 3 189–278
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 3 220–224
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 3 229–246
InefficientEmptyStringCheck String.trim().length() == 0 / String.trim().isEmpty() is an inefficient way to validate a blank String. 3 231
InefficientEmptyStringCheck String.trim().length() == 0 / String.trim().isEmpty() is an inefficient way to validate a blank String. 3 286
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 3 308
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 3 313

fr/paris/lutece/plugins/workflow/modules/ticketing/web/task/ModifyTicketNomenclatureTaskComponent.java

Rule Violation Priority Line
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 79

fr/paris/lutece/plugins/workflow/modules/ticketing/web/task/ModifyTicketTaskComponent.java

Rule Violation Priority Line
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 3 34–225
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 3 190

fr/paris/lutece/plugins/workflow/modules/ticketing/web/task/NotifyWaitingTicketTaskComponent.java

Rule Violation Priority Line
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 3 34–392
CommentRequired Header comments are required 3 72–392
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 133
ConfusingTernary Avoid if (x != y) ..; else ..; 3 146–169
ExcessiveMethodLength Avoid really long methods. 3 255–357
CyclomaticComplexity The method 'getDisplayTaskInformation(int, HttpServletRequest, Locale, ITask)' has a cyclomatic complexity of 13. 3 255–357
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 265
ShortVariable Avoid variables with short names like sb 3 270
ConfusingTernary Avoid if (x != y) ..; else ..; 3 273–339
ConfusingTernary Avoid if (x != y) ..; else ..; 3 285–297
ConfusingTernary Avoid if (x != y) ..; else ..; 3 299–318
InefficientEmptyStringCheck String.trim().length() == 0 / String.trim().isEmpty() is an inefficient way to validate a blank String. 3 342
AppendCharacterWithChar Avoid appending characters as strings in StringBuffer.append. 3 345

fr/paris/lutece/plugins/workflow/modules/ticketing/web/task/ReplyTaskComponent.java

Rule Violation Priority Line
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 93
ConfusingTernary Avoid if (x != y) ..; else ..; 3 97–106

fr/paris/lutece/plugins/workflow/modules/ticketing/web/task/TicketEmailExternalUserTaskComponent.java

Rule Violation Priority Line
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 3 34–515
FieldNamingConventions The constant name '_attributeService' doesn't match '[A-Z][A-Z_0-9]*' 1 132
UnusedPrivateField Avoid unused private fields such as '_taskTicketConfigService'. 3 136
UnusedPrivateField Avoid unused private fields such as '_actionService'. 3 156
FieldNamingConventions The field name '_ExternalUserDAO' doesn't match '_[a-z][a-zA-Z0-9]*' 1 160
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 185
ConfusingTernary Avoid if (x != y) ..; else ..; 3 187
ConfusingTernary Avoid if (x != y) ..; else ..; 3 217
CyclomaticComplexity The method 'getDisplayTaskForm(int, String, HttpServletRequest, Locale, ITask)' has a cyclomatic complexity of 15. 3 230–301
ConfusingTernary Avoid if (x != y) ..; else ..; 3 263
ConfusingTernary Avoid if (x != y) ..; else ..; 3 265
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 277
ConfusingTernary Avoid if (x != y) ..; else ..; 3 296
CyclomaticComplexity The method 'doValidateTask(int, String, HttpServletRequest, Locale, ITask)' has a cyclomatic complexity of 15. 3 332–404
NPathComplexity The method 'doValidateTask(int, String, HttpServletRequest, Locale, ITask)' has an NPath complexity of 315 3 332–404
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 340–341
UnusedLocalVariable Avoid unused local variables such as 'strEmailSubject'. 3 340
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 3 364
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 3 378
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 412
ConfusingTernary Avoid if (x != y) ..; else ..; 3 422–445

fr/paris/lutece/plugins/workflow/modules/ticketing/web/task/TicketingCommentTaskComponent.java

Rule Violation Priority Line
CommentRequired Header comments are required 3 63–149
FieldNamingConventions The field name 'taskComponent' doesn't match '_[a-z][a-zA-Z0-9]*' 1 69
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the taskComponent field if you want a default access modifier 3 69
DefaultPackage Use explicit scoping instead of the default package private level 3 69
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 134

fr/paris/lutece/plugins/workflow/modules/ticketing/web/task/TicketingTaskComponent.java

Rule Violation Priority Line
CommentRequired Public method and constructor comments are required 3 102–105
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 151
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 164
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 164

fr/paris/lutece/plugins/workflow/modules/ticketing/web/task/UploadTicketingTaskComponent.java

Rule Violation Priority Line
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 84
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 110
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 110