The following document contains the results of PMD 6.13.0.
| Rule | Violation | Line |
|---|---|---|
| FieldNamingConventions | The static field name 'mapMessageDirection' doesn't match '_[a-z][a-zA-Z0-9]*' | 54 |
| Rule | Violation | Line |
|---|---|---|
| FormalParameterNamingConventions | The method parameter name '_nSelectedEntry' doesn't match '[a-z][a-zA-Z0-9]*' | 69 |
| Rule | Violation | Line |
|---|---|---|
| FormalParameterNamingConventions | The method parameter name '_bCloseTicket' doesn't match '[a-z][a-zA-Z0-9]*' | 84 |
| Rule | Violation | Line |
|---|---|---|
| ClassNamingConventions | The utility class name 'TicketEmailExternalUserConstants' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' | 39–85 |
| Rule | Violation | Line |
|---|---|---|
| FieldNamingConventions | The final field name '_externalUserDAO' doesn't match '[a-z][a-zA-Z0-9]*' | 87 |
| Rule | Violation | Line |
|---|---|---|
| FieldNamingConventions | The final field name '_externalUserDAO' doesn't match '[a-z][a-zA-Z0-9]*' | 107 |
| FieldNamingConventions | The constant name '_attributeService' doesn't match '[A-Z][A-Z_0-9]*' | 110 |
| Rule | Violation | Line |
|---|---|---|
| FieldNamingConventions | The constant name '_resourceHistoryService' doesn't match '[A-Z][A-Z_0-9]*' | 62 |
| FieldNamingConventions | The field name 'nIdWorkflow' doesn't match '_[a-z][a-zA-Z0-9]*' | 64 |
| FieldNamingConventions | The field name 'isMinuteMode' doesn't match '_[a-z][a-zA-Z0-9]*' | 67 |
| FieldNamingConventions | The field name 'nIdStateWaiting' doesn't match '_[a-z][a-zA-Z0-9]*' | 71 |
| FieldNamingConventions | The field name 'nIdActionRelance' doesn't match '_[a-z][a-zA-Z0-9]*' | 76 |
| FieldNamingConventions | The field name 'nIdActionSolliciterFromTerrainNiv2' doesn't match '_[a-z][a-zA-Z0-9]*' | 82 |
| FieldNamingConventions | The field name 'nIdActionSolliciterFromTerrainNiv3' doesn't match '_[a-z][a-zA-Z0-9]*' | 85 |
| FieldNamingConventions | The field name 'nIdActionSolliciterFromContribNiv2' doesn't match '_[a-z][a-zA-Z0-9]*' | 88 |
| FieldNamingConventions | The field name 'nIdActionSolliciterFromContribNiv3' doesn't match '_[a-z][a-zA-Z0-9]*' | 91 |
| FieldNamingConventions | The field name 'nIdActionRetourFromTerrainNiv2' doesn't match '_[a-z][a-zA-Z0-9]*' | 98 |
| FieldNamingConventions | The field name 'nIdActionRetourFromTerrainNiv3' doesn't match '_[a-z][a-zA-Z0-9]*' | 101 |
| FieldNamingConventions | The field name 'nIdActionRetourFromContribNiv2' doesn't match '_[a-z][a-zA-Z0-9]*' | 104 |
| FieldNamingConventions | The field name 'nIdActionRetourFromContribNiv3' doesn't match '_[a-z][a-zA-Z0-9]*' | 107 |
| FieldNamingConventions | The field name 'nbRelanceMax' doesn't match '_[a-z][a-zA-Z0-9]*' | 111 |
| FieldNamingConventions | The field name 'nFrequence' doesn't match '_[a-z][a-zA-Z0-9]*' | 113 |
| Rule | Violation | Line |
|---|---|---|
| FieldNamingConventions | The constant name '_resourceHistoryService' doesn't match '[A-Z][A-Z_0-9]*' | 64 |
| FieldNamingConventions | The field name 'nIdWorkflow' doesn't match '_[a-z][a-zA-Z0-9]*' | 66 |
| FieldNamingConventions | The field name 'isMinuteMode' doesn't match '_[a-z][a-zA-Z0-9]*' | 68 |
| FieldNamingConventions | The field name 'nIdStateLevel3' doesn't match '_[a-z][a-zA-Z0-9]*' | 73 |
| FieldNamingConventions | The field name 'nIdActionRelance' doesn't match '_[a-z][a-zA-Z0-9]*' | 78 |
| FieldNamingConventions | The field name 'nIdActionEscaladerNiveau3' doesn't match '_[a-z][a-zA-Z0-9]*' | 84 |
| FieldNamingConventions | The field name 'nIdActionReturnATraiter' doesn't match '_[a-z][a-zA-Z0-9]*' | 90 |
| FieldNamingConventions | The field name 'nbRelanceMax' doesn't match '_[a-z][a-zA-Z0-9]*' | 94 |
| FieldNamingConventions | The field name 'nFrequence' doesn't match '_[a-z][a-zA-Z0-9]*' | 96 |
| Rule | Violation | Line |
|---|---|---|
| FieldNamingConventions | The constant name '_resourceHistoryService' doesn't match '[A-Z][A-Z_0-9]*' | 62 |
| FieldNamingConventions | The field name 'nIdWorkflow' doesn't match '_[a-z][a-zA-Z0-9]*' | 64 |
| FieldNamingConventions | The field name 'isMinuteMode' doesn't match '_[a-z][a-zA-Z0-9]*' | 66 |
| FieldNamingConventions | The field name 'nIdStateWaitingUsager' doesn't match '_[a-z][a-zA-Z0-9]*' | 71 |
| FieldNamingConventions | The field name 'nIdActionRelance' doesn't match '_[a-z][a-zA-Z0-9]*' | 77 |
| FieldNamingConventions | The field name 'nIdActionDemandeComplementUsager' doesn't match '_[a-z][a-zA-Z0-9]*' | 83 |
| FieldNamingConventions | The field name 'nIdActionRetourFromDemandeComplementUsager' doesn't match '_[a-z][a-zA-Z0-9]*' | 90 |
| FieldNamingConventions | The field name 'nbRelanceMax' doesn't match '_[a-z][a-zA-Z0-9]*' | 94 |
| FieldNamingConventions | The field name 'nFrequence' doesn't match '_[a-z][a-zA-Z0-9]*' | 96 |
| Rule | Violation | Line |
|---|---|---|
| FieldNamingConventions | The static field name 'dao' doesn't match '_[a-z][a-zA-Z0-9]*' | 82 |
| FieldNamingConventions | The static field name 'daoTaskInfo' doesn't match '_[a-z][a-zA-Z0-9]*' | 83 |
| FieldNamingConventions | The static field name 'daoResourceHist' doesn't match '_[a-z][a-zA-Z0-9]*' | 84 |
| FieldNamingConventions | The static field name 'daoEditableTicketHist' doesn't match '_[a-z][a-zA-Z0-9]*' | 85 |
| FieldNamingConventions | The static field name 'daoAnonymisation' doesn't match '_[a-z][a-zA-Z0-9]*' | 86 |
| FieldNamingConventions | The static field name 'plugin' doesn't match '_[a-z][a-zA-Z0-9]*' | 88 |
| Rule | Violation | Line |
|---|---|---|
| FieldNamingConventions | The field name 'dao' doesn't match '_[a-z][a-zA-Z0-9]*' | 81 |
| Rule | Violation | Line |
|---|---|---|
| ClassNamingConventions | The utility class name 'TaskEditTicketConstants' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' | 41–60 |
| Rule | Violation | Line |
|---|---|---|
| ClassWithOnlyPrivateConstructorsShouldBeFinal | A class which only has private constructors should be final | 36–44 |
| ClassNamingConventions | The utility class name 'UtilConstants' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' | 36–44 |
| Rule | Violation | Line |
|---|---|---|
| FieldNamingConventions | The constant name '_resourceHistoryService' doesn't match '[A-Z][A-Z_0-9]*' | 64 |
| Rule | Violation | Line |
|---|---|---|
| FieldNamingConventions | The final field name '_ticketFormService' doesn't match '[a-z][a-zA-Z0-9]*' | 71 |
| FieldNamingConventions | The final field name '_taskModifyTicketCategoryConfigService' doesn't match '[a-z][a-zA-Z0-9]*' | 72 |
| Rule | Violation | Line |
|---|---|---|
| FieldNamingConventions | The constant name '_attributeService' doesn't match '[A-Z][A-Z_0-9]*' | 132 |
| FieldNamingConventions | The field name '_ExternalUserDAO' doesn't match '_[a-z][a-zA-Z0-9]*' | 160 |
| Rule | Violation | Line |
|---|---|---|
| FieldNamingConventions | The field name 'taskComponent' doesn't match '_[a-z][a-zA-Z0-9]*' | 69 |
| Rule | Violation | Line |
|---|---|---|
| AvoidReassigningParameters | Avoid reassigning parameters such as 'messageToSanitize' | 760 |
| AvoidReassigningParameters | Avoid reassigning parameters such as 'messageToSanitize' | 760 |
| AvoidReassigningParameters | Avoid reassigning parameters such as 'messageToSanitize' | 760 |
| AvoidReassigningParameters | Avoid reassigning parameters such as 'messageToSanitize' | 760 |
| AvoidReassigningParameters | Avoid reassigning parameters such as 'messageToSanitize' | 760 |
| AvoidReassigningParameters | Avoid reassigning parameters such as 'messageToSanitize' | 760 |
| AvoidReassigningParameters | Avoid reassigning parameters such as 'messageToSanitize' | 760 |
| AvoidReassigningParameters | Avoid reassigning parameters such as 'messageToSanitize' | 760 |
| AvoidReassigningParameters | Avoid reassigning parameters such as 'str' | 781 |
| AvoidReassigningParameters | Avoid reassigning parameters such as 'str' | 781 |
| AvoidReassigningParameters | Avoid reassigning parameters such as 'str' | 781 |
| AvoidReassigningParameters | Avoid reassigning parameters such as 'str' | 781 |
| AvoidReassigningParameters | Avoid reassigning parameters such as 'str' | 781 |
| AvoidReassigningParameters | Avoid reassigning parameters such as 'str' | 781 |
| AvoidReassigningParameters | Avoid reassigning parameters such as 'str' | 781 |
| AvoidReassigningParameters | Avoid reassigning parameters such as 'str' | 781 |
| AvoidReassigningParameters | Avoid reassigning parameters such as 'str' | 781 |
| AvoidReassigningParameters | Avoid reassigning parameters such as 'str' | 781 |
| AvoidReassigningParameters | Avoid reassigning parameters such as 'str' | 781 |
| AvoidReassigningParameters | Avoid reassigning parameters such as 'str' | 781 |
| AvoidReassigningParameters | Avoid reassigning parameters such as 'str' | 781 |
| AvoidReassigningParameters | Avoid reassigning parameters such as 'str' | 781 |
| AvoidReassigningParameters | Avoid reassigning parameters such as 'str' | 781 |
| AvoidReassigningParameters | Avoid reassigning parameters such as 'str' | 781 |
| AvoidReassigningParameters | Avoid reassigning parameters such as 'str' | 781 |
| Rule | Violation | Line |
|---|---|---|
| AvoidReassigningParameters | Avoid reassigning parameters such as 'idCoreUploadFinal' | 259 |
| AvoidReassigningParameters | Avoid reassigning parameters such as 'idFileList' | 350 |
| Rule | Violation | Line |
|---|---|---|
| AvoidReassigningParameters | Avoid reassigning parameters such as 'idFileList' | 306 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 44–188 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 60 |
| InefficientStringBuffering | Avoid concatenating nonliterals in a StringBuffer/StringBuilder constructor or append(). | 91 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 41–113 |
| Rule | Violation | Line |
|---|---|---|
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 54 |
| UseLocaleWithCaseConversions | When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 85 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 41–131 |
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 55–68 |
| Rule | Violation | Line |
|---|---|---|
| UnusedPrivateField | Avoid unused private fields such as '_nIdStateAfterEdition'. | 53 |
| Rule | Violation | Line |
|---|---|---|
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 60–72 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 41–67 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 45–153 |
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 59–70 |
| Rule | Violation | Line |
|---|---|---|
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 55–81 |
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 121–128 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 41–124 |
| CommentRequired | Public method and constructor comments are required | 115–118 |
| CommentRequired | Public method and constructor comments are required | 120–123 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 43–183 |
| Rule | Violation | Line |
|---|---|---|
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 83–98 |
| Rule | Violation | Line |
|---|---|---|
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 55 |
| UseLocaleWithCaseConversions | When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 86 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Public method and constructor comments are required | 117–120 |
| CommentRequired | Public method and constructor comments are required | 122–125 |
| Rule | Violation | Line |
|---|---|---|
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 56–94 |
| Rule | Violation | Line |
|---|---|---|
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 62–74 |
| Rule | Violation | Line |
|---|---|---|
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'closeMessagesByIdTicket': the method is declared in an interface type | 85 |
| CommentRequired | Public method and constructor comments are required | 140 |
| ShortVariable | Avoid variables with short names like id | 140 |
| CommentRequired | Public method and constructor comments are required | 142 |
| CommentRequired | Public method and constructor comments are required | 144 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Public method and constructor comments are required | 184–187 |
| CommentRequired | Public method and constructor comments are required | 189–192 |
| Rule | Violation | Line |
|---|---|---|
| TooManyMethods | This class has too many methods, consider refactoring it. | 52–415 |
| AvoidDuplicateLiterals | The String literal "workflow.transactionManager" appears 4 times in this file; the first occurrence is on line 122 | 122 |
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 123–140 |
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 158–171 |
| ShortVariable | Avoid variables with short names like id | 366 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 384 |
| Rule | Violation | Line |
|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 34–432 |
| TooManyMethods | This class has too many methods, consider refactoring it. | 73–432 |
| ImmutableField | Private field '_ticketEmailExternalUserHistoryDAO' could be made final; it is only initialized in the declaration or constructor. | 100 |
| ImmutableField | Private field '_ticketEmailExternalUserDemandDAO' could be made final; it is only initialized in the declaration or constructor. | 104 |
| ImmutableField | Private field '_ticket' could be made final; it is only initialized in the declaration or constructor. | 107 |
| SimpleDateFormatNeedsLocale | When instantiating a SimpleDateFormat object, specify a Locale | 110 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 110 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the _dateFormater field if you want a default access modifier | 110 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 296–307 |
| ForLoopCanBeForeach | This for loop can be replaced by a foreach loop | 421–428 |
| Rule | Violation | Line |
|---|---|---|
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 81–99 |
| Rule | Violation | Line |
|---|---|---|
| ShortVariable | Avoid variables with short names like o1 | 55 |
| ShortVariable | Avoid variables with short names like o2 | 55 |
| ShortVariable | Avoid variables with short names like c | 93 |
| NPathComplexity | The method 'compareAlphaNumeric(String, String, int)' has an NPath complexity of 256 | 142–226 |
| CyclomaticComplexity | The method 'compareAlphaNumeric(String, String, int)' has a cyclomatic complexity of 15. | 142–226 |
| Rule | Violation | Line |
|---|---|---|
| NPathComplexity | The method 'findExternalUser(String, String, String, String, String)' has an NPath complexity of 4656 | 126–208 |
| CyclomaticComplexity | The method 'findExternalUser(String, String, String, String, String)' has a cyclomatic complexity of 14. | 126–208 |
| UseObjectForClearerAPI | Rather than using a lot of String arguments, consider using a container object for those values. | 126 |
| Rule | Violation | Line |
|---|---|---|
| UseObjectForClearerAPI | Rather than using a lot of String arguments, consider using a container object for those values. | 78 |
| Rule | Violation | Line |
|---|---|---|
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 112 |
| AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 131 |
| AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 150 |
| Rule | Violation | Line |
|---|---|---|
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 144 |
| Rule | Violation | Line |
|---|---|---|
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 59–69 |
| Rule | Violation | Line |
|---|---|---|
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 62–102 |
| Rule | Violation | Line |
|---|---|---|
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 114 |
| Rule | Violation | Line |
|---|---|---|
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 67–80 |
| Rule | Violation | Line |
|---|---|---|
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 59–70 |
| Rule | Violation | Line |
|---|---|---|
| UncommentedEmptyMethodBody | Document empty method body | 61–62 |
| Rule | Violation | Line |
|---|---|---|
| UnnecessaryConstructor | Avoid unnecessary constructors - the compiler will generate these for you | 70–73 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 143–151 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 57–473 |
| ImmutableField | Private field 'nIdWorkflow' could be made final; it is only initialized in the declaration or constructor. | 64 |
| ImmutableField | Private field 'isMinuteMode' could be made final; it is only initialized in the declaration or constructor. | 67 |
| LinguisticNaming | Linguistics Antipattern - The field 'isMinuteMode' indicates linguistically it is a boolean, but it is 'int' | 67 |
| ImmutableField | Private field 'nIdStateWaiting' could be made final; it is only initialized in the declaration or constructor. | 71 |
| ImmutableField | Private field 'nIdActionRelance' could be made final; it is only initialized in the declaration or constructor. | 76 |
| ImmutableField | Private field 'nIdActionSolliciterFromTerrainNiv2' could be made final; it is only initialized in the declaration or constructor. | 82 |
| ImmutableField | Private field 'nIdActionSolliciterFromTerrainNiv3' could be made final; it is only initialized in the declaration or constructor. | 85 |
| ImmutableField | Private field 'nIdActionSolliciterFromContribNiv2' could be made final; it is only initialized in the declaration or constructor. | 88 |
| ImmutableField | Private field 'nIdActionSolliciterFromContribNiv3' could be made final; it is only initialized in the declaration or constructor. | 91 |
| ImmutableField | Private field 'nIdActionRetourFromTerrainNiv2' could be made final; it is only initialized in the declaration or constructor. | 98 |
| ImmutableField | Private field 'nIdActionRetourFromTerrainNiv3' could be made final; it is only initialized in the declaration or constructor. | 101 |
| ImmutableField | Private field 'nIdActionRetourFromContribNiv2' could be made final; it is only initialized in the declaration or constructor. | 104 |
| ImmutableField | Private field 'nIdActionRetourFromContribNiv3' could be made final; it is only initialized in the declaration or constructor. | 107 |
| ImmutableField | Private field 'nbRelanceMax' could be made final; it is only initialized in the declaration or constructor. | 111 |
| ImmutableField | Private field 'nFrequence' could be made final; it is only initialized in the declaration or constructor. | 113 |
| CyclomaticComplexity | The method 'processNotification()' has a cyclomatic complexity of 18. | 121–230 |
| ExcessiveMethodLength | Avoid really long methods. | 121–230 |
| InsufficientStringBufferDeclaration | StringBuffer constructor is initialized with size 16, but has at least 144 characters appended. | 123 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 132 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 134 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 135 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 199 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 222–223 |
| ConsecutiveLiteralAppends | StringBuffer (or StringBuilder).append is called 2 consecutive times with literals. Use a single append with a single combined String. | 223 |
| ConsecutiveLiteralAppends | StringBuffer (or StringBuilder).append is called 2 consecutive times with literals. Use a single append with a single combined String. | 224 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 224 |
| CyclomaticComplexity | The method 'isConfParamOK(StringBuilder)' has a cyclomatic complexity of 15. | 239–272 |
| AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 263 |
| UnusedPrivateMethod | Avoid unused private methods such as 'processRelanceNoDate(Ticket,Date)'. | 282 |
| AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 424 |
| ForLoopCanBeForeach | This for loop can be replaced by a foreach loop | 458–467 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 59–399 |
| ImmutableField | Private field 'nIdWorkflow' could be made final; it is only initialized in the declaration or constructor. | 66 |
| ImmutableField | Private field 'isMinuteMode' could be made final; it is only initialized in the declaration or constructor. | 68 |
| LinguisticNaming | Linguistics Antipattern - The field 'isMinuteMode' indicates linguistically it is a boolean, but it is 'int' | 68 |
| ImmutableField | Private field 'nIdStateLevel3' could be made final; it is only initialized in the declaration or constructor. | 73 |
| ImmutableField | Private field 'nIdActionRelance' could be made final; it is only initialized in the declaration or constructor. | 78 |
| ImmutableField | Private field 'nIdActionEscaladerNiveau3' could be made final; it is only initialized in the declaration or constructor. | 84 |
| ImmutableField | Private field 'nIdActionReturnATraiter' could be made final; it is only initialized in the declaration or constructor. | 90 |
| ImmutableField | Private field 'nbRelanceMax' could be made final; it is only initialized in the declaration or constructor. | 94 |
| ImmutableField | Private field 'nFrequence' could be made final; it is only initialized in the declaration or constructor. | 96 |
| ExcessiveMethodLength | Avoid really long methods. | 104–210 |
| CyclomaticComplexity | The method 'processNotification()' has a cyclomatic complexity of 15. | 104–210 |
| InsufficientStringBufferDeclaration | StringBuffer constructor is initialized with size 16, but has at least 127 characters appended. | 106 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 115 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 117 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 118 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 179 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 202–203 |
| ConsecutiveLiteralAppends | StringBuffer (or StringBuilder).append is called 2 consecutive times with literals. Use a single append with a single combined String. | 203 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 204 |
| ConsecutiveLiteralAppends | StringBuffer (or StringBuilder).append is called 2 consecutive times with literals. Use a single append with a single combined String. | 204 |
| AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 241 |
| UnusedPrivateMethod | Avoid unused private methods such as 'processRelanceNoDate(Ticket,Date)'. | 260 |
| AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 310 |
| AssignmentInOperand | Avoid assignments in operands | 385 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 57–387 |
| ImmutableField | Private field 'nIdWorkflow' could be made final; it is only initialized in the declaration or constructor. | 64 |
| LinguisticNaming | Linguistics Antipattern - The field 'isMinuteMode' indicates linguistically it is a boolean, but it is 'int' | 66 |
| ImmutableField | Private field 'isMinuteMode' could be made final; it is only initialized in the declaration or constructor. | 66 |
| ImmutableField | Private field 'nIdStateWaitingUsager' could be made final; it is only initialized in the declaration or constructor. | 71 |
| ImmutableField | Private field 'nIdActionRelance' could be made final; it is only initialized in the declaration or constructor. | 77 |
| ImmutableField | Private field 'nIdActionDemandeComplementUsager' could be made final; it is only initialized in the declaration or constructor. | 83 |
| ImmutableField | Private field 'nIdActionRetourFromDemandeComplementUsager' could be made final; it is only initialized in the declaration or constructor. | 90 |
| ImmutableField | Private field 'nbRelanceMax' could be made final; it is only initialized in the declaration or constructor. | 94 |
| ImmutableField | Private field 'nFrequence' could be made final; it is only initialized in the declaration or constructor. | 96 |
| CyclomaticComplexity | The method 'processNotification()' has a cyclomatic complexity of 15. | 104–210 |
| ExcessiveMethodLength | Avoid really long methods. | 104–210 |
| InsufficientStringBufferDeclaration | StringBuffer constructor is initialized with size 16, but has at least 158 characters appended. | 106 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 115 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 117 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 118 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 179 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 202–203 |
| ConsecutiveLiteralAppends | StringBuffer (or StringBuilder).append is called 2 consecutive times with literals. Use a single append with a single combined String. | 203 |
| ConsecutiveLiteralAppends | StringBuffer (or StringBuilder).append is called 2 consecutive times with literals. Use a single append with a single combined String. | 204 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 204 |
| AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 242 |
| AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 339 |
| AssignmentInOperand | Avoid assignments in operands | 373 |
| Rule | Violation | Line |
|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 34–804 |
| CyclomaticComplexity | The class 'TicketAnonymisationDaemon' has a total cyclomatic complexity of 84 (highest 7). | 75–804 |
| GodClass | Possible God Class (WMC=84, ATFD=67, TCC=10.345%) | 75–804 |
| TooManyMethods | This class has too many methods, consider refactoring it. | 76–804 |
| CommentRequired | Public method and constructor comments are required | 96–99 |
| UnnecessaryConstructor | Avoid unnecessary constructors - the compiler will generate these for you | 96–99 |
| ShortVariable | Avoid variables with short names like sb | 107 |
| ShortVariable | Avoid variables with short names like sb | 121 |
| ShortVariable | Avoid variables with short names like sb | 144 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 149–151 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 159–203 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 191 |
| ShortVariable | Avoid variables with short names like sb | 221 |
| SimpleDateFormatNeedsLocale | When instantiating a SimpleDateFormat object, specify a Locale | 224 |
| ShortVariable | Avoid variables with short names like sb | 283 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 386–397 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 479 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 488–495 |
| AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 605 |
| ForLoopCanBeForeach | This for loop can be replaced by a foreach loop | 607–626 |
| AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 661 |
| ForLoopCanBeForeach | This for loop can be replaced by a foreach loop | 663–669 |
| InefficientEmptyStringCheck | String.trim().length() == 0 / String.trim().isEmpty() is an inefficient way to validate a blank String. | 687 |
| InefficientEmptyStringCheck | String.trim().length() == 0 / String.trim().isEmpty() is an inefficient way to validate a blank String. | 706 |
| InefficientEmptyStringCheck | String.trim().length() == 0 / String.trim().isEmpty() is an inefficient way to validate a blank String. | 727 |
| AvoidDuplicateLiterals | The String literal "(?i)" appears 6 times in this file; the first occurrence is on line 762 | 762 |
| Rule | Violation | Line |
|---|---|---|
| GodClass | Possible God Class (WMC=53, ATFD=43, TCC=1.961%) | 66–503 |
| TooManyMethods | This class has too many methods, consider refactoring it. | 67–503 |
| UnnecessaryConstructor | Avoid unnecessary constructors - the compiler will generate these for you | 79–82 |
| ShortVariable | Avoid variables with short names like sb | 90 |
| ShortVariable | Avoid variables with short names like sb | 105 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 109–164 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 150 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 275 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 275 |
| ShortVariable | Avoid variables with short names like pj | 411 |
| ShortVariable | Avoid variables with short names like pj | 446 |
| Rule | Violation | Line |
|---|---|---|
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 83 |
| Rule | Violation | Line |
|---|---|---|
| AvoidDeeplyNestedIfStmts | Deeply nested if..then statements are hard to read | 106–110 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 51–99 |
| Rule | Violation | Line |
|---|---|---|
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 96–122 |
| Rule | Violation | Line |
|---|---|---|
| AvoidDeeplyNestedIfStmts | Deeply nested if..then statements are hard to read | 85–89 |
| Rule | Violation | Line |
|---|---|---|
| CyclomaticComplexity | The method 'processTicketingTask(int, HttpServletRequest, Locale)' has a cyclomatic complexity of 10. | 81–148 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 84 |
| Rule | Violation | Line |
|---|---|---|
| UseLocaleWithCaseConversions | When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 84 |
| Rule | Violation | Line |
|---|---|---|
| TooManyMethods | This class has too many methods, consider refactoring it. | 68–468 |
| UnusedPrivateField | Avoid unused private fields such as 'STATUS_TRANSFERT_OK'. | 71 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 115 |
| ShortVariable | Avoid variables with short names like pj | 367 |
| ShortVariable | Avoid variables with short names like pj | 404 |
| Rule | Violation | Line |
|---|---|---|
| UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 69 |
| Rule | Violation | Line |
|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 34–396 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 121 |
| NPathComplexity | The method 'processAgentTask(int, HttpServletRequest, Locale, TaskEditTicketConfig)' has an NPath complexity of 288 | 157–238 |
| CyclomaticComplexity | The method 'processAgentTask(int, HttpServletRequest, Locale, TaskEditTicketConfig)' has a cyclomatic complexity of 11. | 157–238 |
| UnusedFormalParameter | Avoid unused method parameters such as 'locale'. | 157 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 168 |
| UnusedFormalParameter | Avoid unused method parameters such as 'config'. | 253 |
| UnusedFormalParameter | Avoid unused method parameters such as 'locale'. | 253 |
| CyclomaticComplexity | The method 'processUserTask(int, HttpServletRequest, Locale, TaskEditTicketConfig)' has a cyclomatic complexity of 11. | 253–331 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 353 |
| Rule | Violation | Line |
|---|---|---|
| ExcessiveMethodLength | Avoid really long methods. | 98–312 |
| NPathComplexity | The method 'processTicketingTask(int, HttpServletRequest, Locale)' has an NPath complexity of 523588 | 98–312 |
| NcssCount | The method 'processTicketingTask(int, HttpServletRequest, Locale)' has a NCSS line count of 108. | 98–312 |
| CyclomaticComplexity | The method 'processTicketingTask(int, HttpServletRequest, Locale)' has a cyclomatic complexity of 33. | 98–312 |
| UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 128 |
| UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 152 |
| UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 161 |
| UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 170 |
| UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 179 |
| UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 188 |
| UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 198 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 208–279 |
| UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 215 |
| UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 222 |
| UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 230 |
| UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 237 |
| AvoidDeeplyNestedIfStmts | Deeply nested if..then statements are hard to read | 250–253 |
| UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 252 |
| AvoidDeeplyNestedIfStmts | Deeply nested if..then statements are hard to read | 257–261 |
| UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 259 |
| AvoidDeeplyNestedIfStmts | Deeply nested if..then statements are hard to read | 265–268 |
| UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 267 |
| AvoidDeeplyNestedIfStmts | Deeply nested if..then statements are hard to read | 272–275 |
| UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 274 |
| UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 289 |
| UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 298 |
| Rule | Violation | Line |
|---|---|---|
| NcssCount | The method 'processTicketingTask(int, HttpServletRequest, Locale)' has a NCSS line count of 72. | 93–239 |
| ExcessiveMethodLength | Avoid really long methods. | 93–239 |
| CyclomaticComplexity | The method 'processTicketingTask(int, HttpServletRequest, Locale)' has a cyclomatic complexity of 27. | 93–239 |
| NPathComplexity | The method 'processTicketingTask(int, HttpServletRequest, Locale)' has an NPath complexity of 52178 | 93–239 |
| UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 121 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 155–163 |
| AvoidDeeplyNestedIfStmts | Deeply nested if..then statements are hard to read | 155–163 |
| UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 157 |
| UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 162 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 178–186 |
| UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 180 |
| AvoidDeeplyNestedIfStmts | Deeply nested if..then statements are hard to read | 183–186 |
| UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 185 |
| UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 195 |
| EmptyIfStmt | Avoid empty if statements | 220–222 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 68–328 |
| ImmutableField | Private field '_externalUserDAO' could be made final; it is only initialized in the declaration or constructor. | 111 |
| CyclomaticComplexity | The method 'processAgentTask(int, Ticket, HttpServletRequest, TaskNotifyWaitingTicketConfig)' has a cyclomatic complexity of 10. | 159–232 |
| Rule | Violation | Line |
|---|---|---|
| ShortVariable | Avoid variables with short names like sb | 59 |
| Rule | Violation | Line |
|---|---|---|
| ImmutableField | Private field '_ticketReassignUnitResourceService' could be made final; it is only initialized in the declaration or constructor. | 79 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the dao field if you want a default access modifier | 81 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 81 |
| AvoidDeeplyNestedIfStmts | Deeply nested if..then statements are hard to read | 125–128 |
| CompareObjectsWithEquals | Use equals() to compare object references. | 144 |
| Rule | Violation | Line |
|---|---|---|
| ShortVariable | Avoid variables with short names like sb | 59 |
| Rule | Violation | Line |
|---|---|---|
| ShortVariable | Avoid variables with short names like sb | 59 |
| Rule | Violation | Line |
|---|---|---|
| UseLocaleWithCaseConversions | When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 129 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 179 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 192 |
| Rule | Violation | Line |
|---|---|---|
| CyclomaticComplexity | The method 'processTicketingTask(int, HttpServletRequest, Locale)' has a cyclomatic complexity of 14. | 83–162 |
| NPathComplexity | The method 'processTicketingTask(int, HttpServletRequest, Locale)' has an NPath complexity of 530 | 83–162 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 109–153 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 122–137 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 145 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 146–147 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 148 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 194 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 230 |
| Rule | Violation | Line |
|---|---|---|
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 83–91 |
| Rule | Violation | Line |
|---|---|---|
| ShortVariable | Avoid variables with short names like sb | 59 |
| Rule | Violation | Line |
|---|---|---|
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 68 |
| Rule | Violation | Line |
|---|---|---|
| ImmutableField | Private field '_externalUserDAO' could be made final; it is only initialized in the declaration or constructor. | 108 |
| UnusedFormalParameter | Avoid unused method parameters such as 'locale'. | 159 |
| ForLoopCanBeForeach | This for loop can be replaced by a foreach loop | 188–208 |
| ForLoopCanBeForeach | This for loop can be replaced by a foreach loop | 215–222 |
| UnusedFormalParameter | Avoid unused method parameters such as 'locale'. | 240 |
| UnusedFormalParameter | Avoid unused method parameters such as 'config'. | 241 |
| UnusedFormalParameter | Avoid unused method parameters such as 'locale'. | 281 |
| UnusedFormalParameter | Avoid unused method parameters such as 'config'. | 282 |
| Rule | Violation | Line |
|---|---|---|
| UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 83 |
| Rule | Violation | Line |
|---|---|---|
| AvoidDeeplyNestedIfStmts | Deeply nested if..then statements are hard to read | 260–264 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 36–44 |
| FieldDeclarationsShouldBeAtStartOfClass | Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 43 |
| Rule | Violation | Line |
|---|---|---|
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 113 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 138–150 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 171 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 171 |
| UnnecessaryLocalBeforeReturn | Consider simply returning the value vs storing it in local variable 'formatedErrors' | 179 |
| Rule | Violation | Line |
|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 34–375 |
| ImmutableField | Private field '_editableTicketService' could be made final; it is only initialized in the declaration or constructor. | 121 |
| ImmutableField | Private field '_ticketFormService' could be made final; it is only initialized in the declaration or constructor. | 122 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 185–220 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 201 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 213–220 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 249 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 57–105 |
| Rule | Violation | Line |
|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 34–384 |
| ImmutableField | Private field '_ticketEmailExternalUserHistoryDAO' could be made final; it is only initialized in the declaration or constructor. | 135 |
| ImmutableField | Private field '_ticketEmailExternalUserMessageDAO' could be made final; it is only initialized in the declaration or constructor. | 136 |
| ImmutableField | Private field '_taskTicketExternalUserConfigService' could be made final; it is only initialized in the declaration or constructor. | 137 |
| ImmutableField | Private field '_resourceHistoryService' could be made final; it is only initialized in the declaration or constructor. | 138 |
| CommentRequired | Public method and constructor comments are required | 152–155 |
| NPathComplexity | The method 'getExternalUserResponseView(HttpServletRequest)' has an NPath complexity of 2616 | 165–302 |
| NcssCount | The method 'getExternalUserResponseView(HttpServletRequest)' has a NCSS line count of 71. | 165–302 |
| ExcessiveMethodLength | Avoid really long methods. | 165–302 |
| CyclomaticComplexity | The method 'getExternalUserResponseView(HttpServletRequest)' has a cyclomatic complexity of 16. | 165–302 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 180 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 181 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 182 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 182 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 183 |
| AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 212 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 255 |
| AvoidCatchingNPE | Avoid catching NullPointerException; consider removing the cause of the NPE. | 255 |
| CommentRequired | Protected method constructor comments are required | 304–312 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 322–330 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 332 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 344 |
| Rule | Violation | Line |
|---|---|---|
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 89 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 94–105 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 157 |
| Rule | Violation | Line |
|---|---|---|
| AvoidDeeplyNestedIfStmts | Deeply nested if..then statements are hard to read | 92–95 |
| Rule | Violation | Line |
|---|---|---|
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 87 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 91–102 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 164 |
| Rule | Violation | Line |
|---|---|---|
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 106 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 113–120 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 172 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 237 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 54–126 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 75 |
| Rule | Violation | Line |
|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 34–326 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 113 |
| CyclomaticComplexity | The method 'doValidateTask(int, String, HttpServletRequest, Locale, ITask)' has a cyclomatic complexity of 20. | 189–278 |
| NPathComplexity | The method 'doValidateTask(int, String, HttpServletRequest, Locale, ITask)' has an NPath complexity of 1300 | 189–278 |
| AvoidDeeplyNestedIfStmts | Deeply nested if..then statements are hard to read | 220–224 |
| AvoidDeeplyNestedIfStmts | Deeply nested if..then statements are hard to read | 229–246 |
| InefficientEmptyStringCheck | String.trim().length() == 0 / String.trim().isEmpty() is an inefficient way to validate a blank String. | 231 |
| InefficientEmptyStringCheck | String.trim().length() == 0 / String.trim().isEmpty() is an inefficient way to validate a blank String. | 286 |
| AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 308 |
| AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 313 |
| Rule | Violation | Line |
|---|---|---|
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 79 |
| Rule | Violation | Line |
|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 34–215 |
| AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 180 |
| Rule | Violation | Line |
|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 34–392 |
| CommentRequired | Header comments are required | 72–392 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 133 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 146–169 |
| CyclomaticComplexity | The method 'getDisplayTaskInformation(int, HttpServletRequest, Locale, ITask)' has a cyclomatic complexity of 13. | 255–357 |
| ExcessiveMethodLength | Avoid really long methods. | 255–357 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 265 |
| ShortVariable | Avoid variables with short names like sb | 270 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 273–339 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 285–297 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 299–318 |
| InefficientEmptyStringCheck | String.trim().length() == 0 / String.trim().isEmpty() is an inefficient way to validate a blank String. | 342 |
| AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 345 |
| Rule | Violation | Line |
|---|---|---|
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 93 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 97–106 |
| Rule | Violation | Line |
|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 34–515 |
| UnusedPrivateField | Avoid unused private fields such as '_taskTicketConfigService'. | 136 |
| UnusedPrivateField | Avoid unused private fields such as '_actionService'. | 156 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 185 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 187 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 217 |
| CyclomaticComplexity | The method 'getDisplayTaskForm(int, String, HttpServletRequest, Locale, ITask)' has a cyclomatic complexity of 15. | 230–301 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 263 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 265 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 277 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 296 |
| CyclomaticComplexity | The method 'doValidateTask(int, String, HttpServletRequest, Locale, ITask)' has a cyclomatic complexity of 15. | 332–404 |
| NPathComplexity | The method 'doValidateTask(int, String, HttpServletRequest, Locale, ITask)' has an NPath complexity of 315 | 332–404 |
| UnusedLocalVariable | Avoid unused local variables such as 'strEmailSubject'. | 340 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 340–341 |
| AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 364 |
| AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 378 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 412 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 422–445 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 63–149 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 69 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the taskComponent field if you want a default access modifier | 69 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 134 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Public method and constructor comments are required | 102–105 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 151 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 164 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 164 |
| Rule | Violation | Line |
|---|---|---|
| BooleanGetMethodName | A getX() method which returns a boolean should be named isX() | 170–173 |
| Rule | Violation | Line |
|---|---|---|
| UnnecessaryFullyQualifiedName | Unnecessary use of fully qualified name 'fr.paris.lutece.plugins.workflow.modules.ticketing.business.resourcehistory.ResourceHistory' due to existing same package import 'fr.paris.lutece.plugins.workflow.modules.ticketing.business.resourcehistory.*' | 121 |
| UnnecessaryFullyQualifiedName | Unnecessary use of fully qualified name 'fr.paris.lutece.plugins.workflow.modules.ticketing.business.resourcehistory.ResourceHistory' due to existing same package import 'fr.paris.lutece.plugins.workflow.modules.ticketing.business.resourcehistory.*' | 151 |
| Rule | Violation | Line |
|---|---|---|
| UseVarargs | Consider using varargs for methods or constructors which take an array the last parameter. | 658 |
| Rule | Violation | Line |
|---|---|---|
| UseVarargs | Consider using varargs for methods or constructors which take an array the last parameter. | 121 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 44–188 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 60 |
| InefficientStringBuffering | Avoid concatenating nonliterals in a StringBuffer/StringBuilder constructor or append(). | 3 | 91 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 41–113 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 54 |
| FieldNamingConventions | The static field name 'mapMessageDirection' doesn't match '_[a-z][a-zA-Z0-9]*' | 1 | 54 |
| UseLocaleWithCaseConversions | When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 3 | 85 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 41–131 |
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 3 | 55–68 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnusedPrivateField | Avoid unused private fields such as '_nIdStateAfterEdition'. | 3 | 53 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 3 | 60–72 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 41–67 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 45–153 |
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 3 | 59–70 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| FormalParameterNamingConventions | The method parameter name '_nSelectedEntry' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 69 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 3 | 55–81 |
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 3 | 121–128 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 41–124 |
| CommentRequired | Public method and constructor comments are required | 3 | 115–118 |
| CommentRequired | Public method and constructor comments are required | 3 | 120–123 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 43–183 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| FormalParameterNamingConventions | The method parameter name '_bCloseTicket' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 84 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 3 | 83–98 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 55 |
| UseLocaleWithCaseConversions | When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 3 | 86 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Public method and constructor comments are required | 3 | 117–120 |
| CommentRequired | Public method and constructor comments are required | 3 | 122–125 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 3 | 56–94 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 3 | 62–74 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'closeMessagesByIdTicket': the method is declared in an interface type | 3 | 85 |
| CommentRequired | Public method and constructor comments are required | 3 | 140 |
| ShortVariable | Avoid variables with short names like id | 3 | 140 |
| CommentRequired | Public method and constructor comments are required | 3 | 142 |
| CommentRequired | Public method and constructor comments are required | 3 | 144 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| BooleanGetMethodName | A getX() method which returns a boolean should be named isX() | 4 | 170–173 |
| CommentRequired | Public method and constructor comments are required | 3 | 184–187 |
| CommentRequired | Public method and constructor comments are required | 3 | 189–192 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| TooManyMethods | This class has too many methods, consider refactoring it. | 3 | 52–415 |
| AvoidDuplicateLiterals | The String literal "workflow.transactionManager" appears 4 times in this file; the first occurrence is on line 122 | 3 | 122 |
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 3 | 123–140 |
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 3 | 158–171 |
| ShortVariable | Avoid variables with short names like id | 3 | 366 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 384 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ClassNamingConventions | The utility class name 'TicketEmailExternalUserConstants' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' | 1 | 39–85 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 3 | 34–432 |
| TooManyMethods | This class has too many methods, consider refactoring it. | 3 | 73–432 |
| ImmutableField | Private field '_ticketEmailExternalUserHistoryDAO' could be made final; it is only initialized in the declaration or constructor. | 3 | 100 |
| ImmutableField | Private field '_ticketEmailExternalUserDemandDAO' could be made final; it is only initialized in the declaration or constructor. | 3 | 104 |
| ImmutableField | Private field '_ticket' could be made final; it is only initialized in the declaration or constructor. | 3 | 107 |
| SimpleDateFormatNeedsLocale | When instantiating a SimpleDateFormat object, specify a Locale | 3 | 110 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 3 | 110 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the _dateFormater field if you want a default access modifier | 3 | 110 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 296–307 |
| ForLoopCanBeForeach | This for loop can be replaced by a foreach loop | 3 | 421–428 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 3 | 81–99 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ShortVariable | Avoid variables with short names like o1 | 3 | 55 |
| ShortVariable | Avoid variables with short names like o2 | 3 | 55 |
| ShortVariable | Avoid variables with short names like c | 3 | 93 |
| NPathComplexity | The method 'compareAlphaNumeric(String, String, int)' has an NPath complexity of 256 | 3 | 142–226 |
| CyclomaticComplexity | The method 'compareAlphaNumeric(String, String, int)' has a cyclomatic complexity of 15. | 3 | 142–226 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| NPathComplexity | The method 'findExternalUser(String, String, String, String, String)' has an NPath complexity of 4656 | 3 | 126–208 |
| CyclomaticComplexity | The method 'findExternalUser(String, String, String, String, String)' has a cyclomatic complexity of 14. | 3 | 126–208 |
| UseObjectForClearerAPI | Rather than using a lot of String arguments, consider using a container object for those values. | 3 | 126 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UseObjectForClearerAPI | Rather than using a lot of String arguments, consider using a container object for those values. | 3 | 78 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| FieldNamingConventions | The final field name '_externalUserDAO' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 87 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 112 |
| AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 3 | 131 |
| AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 3 | 150 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| FieldNamingConventions | The final field name '_externalUserDAO' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 107 |
| FieldNamingConventions | The constant name '_attributeService' doesn't match '[A-Z][A-Z_0-9]*' | 1 | 110 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 144 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 3 | 59–69 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 3 | 62–102 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 114 |
| UnnecessaryFullyQualifiedName | Unnecessary use of fully qualified name 'fr.paris.lutece.plugins.workflow.modules.ticketing.business.resourcehistory.ResourceHistory' due to existing same package import 'fr.paris.lutece.plugins.workflow.modules.ticketing.business.resourcehistory.*' | 4 | 121 |
| UnnecessaryFullyQualifiedName | Unnecessary use of fully qualified name 'fr.paris.lutece.plugins.workflow.modules.ticketing.business.resourcehistory.ResourceHistory' due to existing same package import 'fr.paris.lutece.plugins.workflow.modules.ticketing.business.resourcehistory.*' | 4 | 151 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 3 | 67–80 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 3 | 59–70 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UncommentedEmptyMethodBody | Document empty method body | 3 | 61–62 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnnecessaryConstructor | Avoid unnecessary constructors - the compiler will generate these for you | 3 | 70–73 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 143–151 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 57–473 |
| FieldNamingConventions | The constant name '_resourceHistoryService' doesn't match '[A-Z][A-Z_0-9]*' | 1 | 62 |
| FieldNamingConventions | The field name 'nIdWorkflow' doesn't match '_[a-z][a-zA-Z0-9]*' | 1 | 64 |
| ImmutableField | Private field 'nIdWorkflow' could be made final; it is only initialized in the declaration or constructor. | 3 | 64 |
| FieldNamingConventions | The field name 'isMinuteMode' doesn't match '_[a-z][a-zA-Z0-9]*' | 1 | 67 |
| ImmutableField | Private field 'isMinuteMode' could be made final; it is only initialized in the declaration or constructor. | 3 | 67 |
| LinguisticNaming | Linguistics Antipattern - The field 'isMinuteMode' indicates linguistically it is a boolean, but it is 'int' | 3 | 67 |
| FieldNamingConventions | The field name 'nIdStateWaiting' doesn't match '_[a-z][a-zA-Z0-9]*' | 1 | 71 |
| ImmutableField | Private field 'nIdStateWaiting' could be made final; it is only initialized in the declaration or constructor. | 3 | 71 |
| ImmutableField | Private field 'nIdActionRelance' could be made final; it is only initialized in the declaration or constructor. | 3 | 76 |
| FieldNamingConventions | The field name 'nIdActionRelance' doesn't match '_[a-z][a-zA-Z0-9]*' | 1 | 76 |
| ImmutableField | Private field 'nIdActionSolliciterFromTerrainNiv2' could be made final; it is only initialized in the declaration or constructor. | 3 | 82 |
| FieldNamingConventions | The field name 'nIdActionSolliciterFromTerrainNiv2' doesn't match '_[a-z][a-zA-Z0-9]*' | 1 | 82 |
| ImmutableField | Private field 'nIdActionSolliciterFromTerrainNiv3' could be made final; it is only initialized in the declaration or constructor. | 3 | 85 |
| FieldNamingConventions | The field name 'nIdActionSolliciterFromTerrainNiv3' doesn't match '_[a-z][a-zA-Z0-9]*' | 1 | 85 |
| ImmutableField | Private field 'nIdActionSolliciterFromContribNiv2' could be made final; it is only initialized in the declaration or constructor. | 3 | 88 |
| FieldNamingConventions | The field name 'nIdActionSolliciterFromContribNiv2' doesn't match '_[a-z][a-zA-Z0-9]*' | 1 | 88 |
| FieldNamingConventions | The field name 'nIdActionSolliciterFromContribNiv3' doesn't match '_[a-z][a-zA-Z0-9]*' | 1 | 91 |
| ImmutableField | Private field 'nIdActionSolliciterFromContribNiv3' could be made final; it is only initialized in the declaration or constructor. | 3 | 91 |
| ImmutableField | Private field 'nIdActionRetourFromTerrainNiv2' could be made final; it is only initialized in the declaration or constructor. | 3 | 98 |
| FieldNamingConventions | The field name 'nIdActionRetourFromTerrainNiv2' doesn't match '_[a-z][a-zA-Z0-9]*' | 1 | 98 |
| FieldNamingConventions | The field name 'nIdActionRetourFromTerrainNiv3' doesn't match '_[a-z][a-zA-Z0-9]*' | 1 | 101 |
| ImmutableField | Private field 'nIdActionRetourFromTerrainNiv3' could be made final; it is only initialized in the declaration or constructor. | 3 | 101 |
| ImmutableField | Private field 'nIdActionRetourFromContribNiv2' could be made final; it is only initialized in the declaration or constructor. | 3 | 104 |
| FieldNamingConventions | The field name 'nIdActionRetourFromContribNiv2' doesn't match '_[a-z][a-zA-Z0-9]*' | 1 | 104 |
| ImmutableField | Private field 'nIdActionRetourFromContribNiv3' could be made final; it is only initialized in the declaration or constructor. | 3 | 107 |
| FieldNamingConventions | The field name 'nIdActionRetourFromContribNiv3' doesn't match '_[a-z][a-zA-Z0-9]*' | 1 | 107 |
| ImmutableField | Private field 'nbRelanceMax' could be made final; it is only initialized in the declaration or constructor. | 3 | 111 |
| FieldNamingConventions | The field name 'nbRelanceMax' doesn't match '_[a-z][a-zA-Z0-9]*' | 1 | 111 |
| ImmutableField | Private field 'nFrequence' could be made final; it is only initialized in the declaration or constructor. | 3 | 113 |
| FieldNamingConventions | The field name 'nFrequence' doesn't match '_[a-z][a-zA-Z0-9]*' | 1 | 113 |
| CyclomaticComplexity | The method 'processNotification()' has a cyclomatic complexity of 18. | 3 | 121–230 |
| ExcessiveMethodLength | Avoid really long methods. | 3 | 121–230 |
| InsufficientStringBufferDeclaration | StringBuffer constructor is initialized with size 16, but has at least 144 characters appended. | 3 | 123 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 132 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 134 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 135 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 199 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 3 | 222–223 |
| ConsecutiveLiteralAppends | StringBuffer (or StringBuilder).append is called 2 consecutive times with literals. Use a single append with a single combined String. | 3 | 223 |
| ConsecutiveLiteralAppends | StringBuffer (or StringBuilder).append is called 2 consecutive times with literals. Use a single append with a single combined String. | 3 | 224 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 3 | 224 |
| CyclomaticComplexity | The method 'isConfParamOK(StringBuilder)' has a cyclomatic complexity of 15. | 3 | 239–272 |
| AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 3 | 263 |
| UnusedPrivateMethod | Avoid unused private methods such as 'processRelanceNoDate(Ticket,Date)'. | 3 | 282 |
| AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 3 | 424 |
| ForLoopCanBeForeach | This for loop can be replaced by a foreach loop | 3 | 458–467 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 59–399 |
| FieldNamingConventions | The constant name '_resourceHistoryService' doesn't match '[A-Z][A-Z_0-9]*' | 1 | 64 |
| FieldNamingConventions | The field name 'nIdWorkflow' doesn't match '_[a-z][a-zA-Z0-9]*' | 1 | 66 |
| ImmutableField | Private field 'nIdWorkflow' could be made final; it is only initialized in the declaration or constructor. | 3 | 66 |
| FieldNamingConventions | The field name 'isMinuteMode' doesn't match '_[a-z][a-zA-Z0-9]*' | 1 | 68 |
| ImmutableField | Private field 'isMinuteMode' could be made final; it is only initialized in the declaration or constructor. | 3 | 68 |
| LinguisticNaming | Linguistics Antipattern - The field 'isMinuteMode' indicates linguistically it is a boolean, but it is 'int' | 3 | 68 |
| ImmutableField | Private field 'nIdStateLevel3' could be made final; it is only initialized in the declaration or constructor. | 3 | 73 |
| FieldNamingConventions | The field name 'nIdStateLevel3' doesn't match '_[a-z][a-zA-Z0-9]*' | 1 | 73 |
| ImmutableField | Private field 'nIdActionRelance' could be made final; it is only initialized in the declaration or constructor. | 3 | 78 |
| FieldNamingConventions | The field name 'nIdActionRelance' doesn't match '_[a-z][a-zA-Z0-9]*' | 1 | 78 |
| FieldNamingConventions | The field name 'nIdActionEscaladerNiveau3' doesn't match '_[a-z][a-zA-Z0-9]*' | 1 | 84 |
| ImmutableField | Private field 'nIdActionEscaladerNiveau3' could be made final; it is only initialized in the declaration or constructor. | 3 | 84 |
| ImmutableField | Private field 'nIdActionReturnATraiter' could be made final; it is only initialized in the declaration or constructor. | 3 | 90 |
| FieldNamingConventions | The field name 'nIdActionReturnATraiter' doesn't match '_[a-z][a-zA-Z0-9]*' | 1 | 90 |
| FieldNamingConventions | The field name 'nbRelanceMax' doesn't match '_[a-z][a-zA-Z0-9]*' | 1 | 94 |
| ImmutableField | Private field 'nbRelanceMax' could be made final; it is only initialized in the declaration or constructor. | 3 | 94 |
| FieldNamingConventions | The field name 'nFrequence' doesn't match '_[a-z][a-zA-Z0-9]*' | 1 | 96 |
| ImmutableField | Private field 'nFrequence' could be made final; it is only initialized in the declaration or constructor. | 3 | 96 |
| ExcessiveMethodLength | Avoid really long methods. | 3 | 104–210 |
| CyclomaticComplexity | The method 'processNotification()' has a cyclomatic complexity of 15. | 3 | 104–210 |
| InsufficientStringBufferDeclaration | StringBuffer constructor is initialized with size 16, but has at least 127 characters appended. | 3 | 106 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 115 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 117 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 118 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 179 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 3 | 202–203 |
| ConsecutiveLiteralAppends | StringBuffer (or StringBuilder).append is called 2 consecutive times with literals. Use a single append with a single combined String. | 3 | 203 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 3 | 204 |
| ConsecutiveLiteralAppends | StringBuffer (or StringBuilder).append is called 2 consecutive times with literals. Use a single append with a single combined String. | 3 | 204 |
| AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 3 | 241 |
| UnusedPrivateMethod | Avoid unused private methods such as 'processRelanceNoDate(Ticket,Date)'. | 3 | 260 |
| AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 3 | 310 |
| AssignmentInOperand | Avoid assignments in operands | 3 | 385 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 57–387 |
| FieldNamingConventions | The constant name '_resourceHistoryService' doesn't match '[A-Z][A-Z_0-9]*' | 1 | 62 |
| FieldNamingConventions | The field name 'nIdWorkflow' doesn't match '_[a-z][a-zA-Z0-9]*' | 1 | 64 |
| ImmutableField | Private field 'nIdWorkflow' could be made final; it is only initialized in the declaration or constructor. | 3 | 64 |
| FieldNamingConventions | The field name 'isMinuteMode' doesn't match '_[a-z][a-zA-Z0-9]*' | 1 | 66 |
| LinguisticNaming | Linguistics Antipattern - The field 'isMinuteMode' indicates linguistically it is a boolean, but it is 'int' | 3 | 66 |
| ImmutableField | Private field 'isMinuteMode' could be made final; it is only initialized in the declaration or constructor. | 3 | 66 |
| FieldNamingConventions | The field name 'nIdStateWaitingUsager' doesn't match '_[a-z][a-zA-Z0-9]*' | 1 | 71 |
| ImmutableField | Private field 'nIdStateWaitingUsager' could be made final; it is only initialized in the declaration or constructor. | 3 | 71 |
| ImmutableField | Private field 'nIdActionRelance' could be made final; it is only initialized in the declaration or constructor. | 3 | 77 |
| FieldNamingConventions | The field name 'nIdActionRelance' doesn't match '_[a-z][a-zA-Z0-9]*' | 1 | 77 |
| FieldNamingConventions | The field name 'nIdActionDemandeComplementUsager' doesn't match '_[a-z][a-zA-Z0-9]*' | 1 | 83 |
| ImmutableField | Private field 'nIdActionDemandeComplementUsager' could be made final; it is only initialized in the declaration or constructor. | 3 | 83 |
| ImmutableField | Private field 'nIdActionRetourFromDemandeComplementUsager' could be made final; it is only initialized in the declaration or constructor. | 3 | 90 |
| FieldNamingConventions | The field name 'nIdActionRetourFromDemandeComplementUsager' doesn't match '_[a-z][a-zA-Z0-9]*' | 1 | 90 |
| ImmutableField | Private field 'nbRelanceMax' could be made final; it is only initialized in the declaration or constructor. | 3 | 94 |
| FieldNamingConventions | The field name 'nbRelanceMax' doesn't match '_[a-z][a-zA-Z0-9]*' | 1 | 94 |
| ImmutableField | Private field 'nFrequence' could be made final; it is only initialized in the declaration or constructor. | 3 | 96 |
| FieldNamingConventions | The field name 'nFrequence' doesn't match '_[a-z][a-zA-Z0-9]*' | 1 | 96 |
| CyclomaticComplexity | The method 'processNotification()' has a cyclomatic complexity of 15. | 3 | 104–210 |
| ExcessiveMethodLength | Avoid really long methods. | 3 | 104–210 |
| InsufficientStringBufferDeclaration | StringBuffer constructor is initialized with size 16, but has at least 158 characters appended. | 3 | 106 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 115 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 117 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 118 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 179 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 3 | 202–203 |
| ConsecutiveLiteralAppends | StringBuffer (or StringBuilder).append is called 2 consecutive times with literals. Use a single append with a single combined String. | 3 | 203 |
| ConsecutiveLiteralAppends | StringBuffer (or StringBuilder).append is called 2 consecutive times with literals. Use a single append with a single combined String. | 3 | 204 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 3 | 204 |
| AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 3 | 242 |
| AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 3 | 339 |
| AssignmentInOperand | Avoid assignments in operands | 3 | 373 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 3 | 34–804 |
| CyclomaticComplexity | The class 'TicketAnonymisationDaemon' has a total cyclomatic complexity of 84 (highest 7). | 3 | 75–804 |
| GodClass | Possible God Class (WMC=84, ATFD=67, TCC=10.345%) | 3 | 75–804 |
| TooManyMethods | This class has too many methods, consider refactoring it. | 3 | 76–804 |
| FieldNamingConventions | The static field name 'dao' doesn't match '_[a-z][a-zA-Z0-9]*' | 1 | 82 |
| FieldNamingConventions | The static field name 'daoTaskInfo' doesn't match '_[a-z][a-zA-Z0-9]*' | 1 | 83 |
| FieldNamingConventions | The static field name 'daoResourceHist' doesn't match '_[a-z][a-zA-Z0-9]*' | 1 | 84 |
| FieldNamingConventions | The static field name 'daoEditableTicketHist' doesn't match '_[a-z][a-zA-Z0-9]*' | 1 | 85 |
| FieldNamingConventions | The static field name 'daoAnonymisation' doesn't match '_[a-z][a-zA-Z0-9]*' | 1 | 86 |
| FieldNamingConventions | The static field name 'plugin' doesn't match '_[a-z][a-zA-Z0-9]*' | 1 | 88 |
| CommentRequired | Public method and constructor comments are required | 3 | 96–99 |
| UnnecessaryConstructor | Avoid unnecessary constructors - the compiler will generate these for you | 3 | 96–99 |
| ShortVariable | Avoid variables with short names like sb | 3 | 107 |
| ShortVariable | Avoid variables with short names like sb | 3 | 121 |
| ShortVariable | Avoid variables with short names like sb | 3 | 144 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 149–151 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 159–203 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 191 |
| ShortVariable | Avoid variables with short names like sb | 3 | 221 |
| SimpleDateFormatNeedsLocale | When instantiating a SimpleDateFormat object, specify a Locale | 3 | 224 |
| ShortVariable | Avoid variables with short names like sb | 3 | 283 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 386–397 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 479 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 488–495 |
| AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 3 | 605 |
| ForLoopCanBeForeach | This for loop can be replaced by a foreach loop | 3 | 607–626 |
| UseVarargs | Consider using varargs for methods or constructors which take an array the last parameter. | 4 | 658 |
| AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 3 | 661 |
| ForLoopCanBeForeach | This for loop can be replaced by a foreach loop | 3 | 663–669 |
| InefficientEmptyStringCheck | String.trim().length() == 0 / String.trim().isEmpty() is an inefficient way to validate a blank String. | 3 | 687 |
| InefficientEmptyStringCheck | String.trim().length() == 0 / String.trim().isEmpty() is an inefficient way to validate a blank String. | 3 | 706 |
| InefficientEmptyStringCheck | String.trim().length() == 0 / String.trim().isEmpty() is an inefficient way to validate a blank String. | 3 | 727 |
| AvoidReassigningParameters | Avoid reassigning parameters such as 'messageToSanitize' | 2 | 760 |
| AvoidReassigningParameters | Avoid reassigning parameters such as 'messageToSanitize' | 2 | 760 |
| AvoidReassigningParameters | Avoid reassigning parameters such as 'messageToSanitize' | 2 | 760 |
| AvoidReassigningParameters | Avoid reassigning parameters such as 'messageToSanitize' | 2 | 760 |
| AvoidReassigningParameters | Avoid reassigning parameters such as 'messageToSanitize' | 2 | 760 |
| AvoidReassigningParameters | Avoid reassigning parameters such as 'messageToSanitize' | 2 | 760 |
| AvoidReassigningParameters | Avoid reassigning parameters such as 'messageToSanitize' | 2 | 760 |
| AvoidReassigningParameters | Avoid reassigning parameters such as 'messageToSanitize' | 2 | 760 |
| AvoidDuplicateLiterals | The String literal "(?i)" appears 6 times in this file; the first occurrence is on line 762 | 3 | 762 |
| AvoidReassigningParameters | Avoid reassigning parameters such as 'str' | 2 | 781 |
| AvoidReassigningParameters | Avoid reassigning parameters such as 'str' | 2 | 781 |
| AvoidReassigningParameters | Avoid reassigning parameters such as 'str' | 2 | 781 |
| AvoidReassigningParameters | Avoid reassigning parameters such as 'str' | 2 | 781 |
| AvoidReassigningParameters | Avoid reassigning parameters such as 'str' | 2 | 781 |
| AvoidReassigningParameters | Avoid reassigning parameters such as 'str' | 2 | 781 |
| AvoidReassigningParameters | Avoid reassigning parameters such as 'str' | 2 | 781 |
| AvoidReassigningParameters | Avoid reassigning parameters such as 'str' | 2 | 781 |
| AvoidReassigningParameters | Avoid reassigning parameters such as 'str' | 2 | 781 |
| AvoidReassigningParameters | Avoid reassigning parameters such as 'str' | 2 | 781 |
| AvoidReassigningParameters | Avoid reassigning parameters such as 'str' | 2 | 781 |
| AvoidReassigningParameters | Avoid reassigning parameters such as 'str' | 2 | 781 |
| AvoidReassigningParameters | Avoid reassigning parameters such as 'str' | 2 | 781 |
| AvoidReassigningParameters | Avoid reassigning parameters such as 'str' | 2 | 781 |
| AvoidReassigningParameters | Avoid reassigning parameters such as 'str' | 2 | 781 |
| AvoidReassigningParameters | Avoid reassigning parameters such as 'str' | 2 | 781 |
| AvoidReassigningParameters | Avoid reassigning parameters such as 'str' | 2 | 781 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| GodClass | Possible God Class (WMC=53, ATFD=43, TCC=1.961%) | 3 | 66–503 |
| TooManyMethods | This class has too many methods, consider refactoring it. | 3 | 67–503 |
| UnnecessaryConstructor | Avoid unnecessary constructors - the compiler will generate these for you | 3 | 79–82 |
| ShortVariable | Avoid variables with short names like sb | 3 | 90 |
| ShortVariable | Avoid variables with short names like sb | 3 | 105 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 109–164 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 150 |
| AvoidReassigningParameters | Avoid reassigning parameters such as 'idCoreUploadFinal' | 2 | 259 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 275 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 275 |
| AvoidReassigningParameters | Avoid reassigning parameters such as 'idFileList' | 2 | 350 |
| ShortVariable | Avoid variables with short names like pj | 3 | 411 |
| ShortVariable | Avoid variables with short names like pj | 3 | 446 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 83 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| AvoidDeeplyNestedIfStmts | Deeply nested if..then statements are hard to read | 3 | 106–110 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 51–99 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 96–122 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| AvoidDeeplyNestedIfStmts | Deeply nested if..then statements are hard to read | 3 | 85–89 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CyclomaticComplexity | The method 'processTicketingTask(int, HttpServletRequest, Locale)' has a cyclomatic complexity of 10. | 3 | 81–148 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 84 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UseLocaleWithCaseConversions | When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 3 | 84 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| TooManyMethods | This class has too many methods, consider refactoring it. | 3 | 68–468 |
| UnusedPrivateField | Avoid unused private fields such as 'STATUS_TRANSFERT_OK'. | 3 | 71 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 115 |
| AvoidReassigningParameters | Avoid reassigning parameters such as 'idFileList' | 2 | 306 |
| ShortVariable | Avoid variables with short names like pj | 3 | 367 |
| ShortVariable | Avoid variables with short names like pj | 3 | 404 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 3 | 69 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 3 | 34–396 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 121 |
| NPathComplexity | The method 'processAgentTask(int, HttpServletRequest, Locale, TaskEditTicketConfig)' has an NPath complexity of 288 | 3 | 157–238 |
| CyclomaticComplexity | The method 'processAgentTask(int, HttpServletRequest, Locale, TaskEditTicketConfig)' has a cyclomatic complexity of 11. | 3 | 157–238 |
| UnusedFormalParameter | Avoid unused method parameters such as 'locale'. | 3 | 157 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 168 |
| UnusedFormalParameter | Avoid unused method parameters such as 'config'. | 3 | 253 |
| UnusedFormalParameter | Avoid unused method parameters such as 'locale'. | 3 | 253 |
| CyclomaticComplexity | The method 'processUserTask(int, HttpServletRequest, Locale, TaskEditTicketConfig)' has a cyclomatic complexity of 11. | 3 | 253–331 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 353 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ExcessiveMethodLength | Avoid really long methods. | 3 | 98–312 |
| NPathComplexity | The method 'processTicketingTask(int, HttpServletRequest, Locale)' has an NPath complexity of 523588 | 3 | 98–312 |
| NcssCount | The method 'processTicketingTask(int, HttpServletRequest, Locale)' has a NCSS line count of 108. | 3 | 98–312 |
| CyclomaticComplexity | The method 'processTicketingTask(int, HttpServletRequest, Locale)' has a cyclomatic complexity of 33. | 3 | 98–312 |
| UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 3 | 128 |
| UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 3 | 152 |
| UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 3 | 161 |
| UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 3 | 170 |
| UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 3 | 179 |
| UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 3 | 188 |
| UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 3 | 198 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 208–279 |
| UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 3 | 215 |
| UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 3 | 222 |
| UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 3 | 230 |
| UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 3 | 237 |
| AvoidDeeplyNestedIfStmts | Deeply nested if..then statements are hard to read | 3 | 250–253 |
| UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 3 | 252 |
| AvoidDeeplyNestedIfStmts | Deeply nested if..then statements are hard to read | 3 | 257–261 |
| UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 3 | 259 |
| AvoidDeeplyNestedIfStmts | Deeply nested if..then statements are hard to read | 3 | 265–268 |
| UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 3 | 267 |
| AvoidDeeplyNestedIfStmts | Deeply nested if..then statements are hard to read | 3 | 272–275 |
| UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 3 | 274 |
| UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 3 | 289 |
| UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 3 | 298 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| NcssCount | The method 'processTicketingTask(int, HttpServletRequest, Locale)' has a NCSS line count of 72. | 3 | 93–239 |
| ExcessiveMethodLength | Avoid really long methods. | 3 | 93–239 |
| CyclomaticComplexity | The method 'processTicketingTask(int, HttpServletRequest, Locale)' has a cyclomatic complexity of 27. | 3 | 93–239 |
| NPathComplexity | The method 'processTicketingTask(int, HttpServletRequest, Locale)' has an NPath complexity of 52178 | 3 | 93–239 |
| UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 3 | 121 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 155–163 |
| AvoidDeeplyNestedIfStmts | Deeply nested if..then statements are hard to read | 3 | 155–163 |
| UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 3 | 157 |
| UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 3 | 162 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 178–186 |
| UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 3 | 180 |
| AvoidDeeplyNestedIfStmts | Deeply nested if..then statements are hard to read | 3 | 183–186 |
| UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 3 | 185 |
| UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 3 | 195 |
| EmptyIfStmt | Avoid empty if statements | 3 | 220–222 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 68–328 |
| ImmutableField | Private field '_externalUserDAO' could be made final; it is only initialized in the declaration or constructor. | 3 | 111 |
| CyclomaticComplexity | The method 'processAgentTask(int, Ticket, HttpServletRequest, TaskNotifyWaitingTicketConfig)' has a cyclomatic complexity of 10. | 3 | 159–232 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ShortVariable | Avoid variables with short names like sb | 3 | 59 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ImmutableField | Private field '_ticketReassignUnitResourceService' could be made final; it is only initialized in the declaration or constructor. | 3 | 79 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the dao field if you want a default access modifier | 3 | 81 |
| FieldNamingConventions | The field name 'dao' doesn't match '_[a-z][a-zA-Z0-9]*' | 1 | 81 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 3 | 81 |
| AvoidDeeplyNestedIfStmts | Deeply nested if..then statements are hard to read | 3 | 125–128 |
| CompareObjectsWithEquals | Use equals() to compare object references. | 3 | 144 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ShortVariable | Avoid variables with short names like sb | 3 | 59 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ShortVariable | Avoid variables with short names like sb | 3 | 59 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UseLocaleWithCaseConversions | When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 3 | 129 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 179 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 192 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CyclomaticComplexity | The method 'processTicketingTask(int, HttpServletRequest, Locale)' has a cyclomatic complexity of 14. | 3 | 83–162 |
| NPathComplexity | The method 'processTicketingTask(int, HttpServletRequest, Locale)' has an NPath complexity of 530 | 3 | 83–162 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 109–153 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 122–137 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 145 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 146–147 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 148 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 194 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 230 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 83–91 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ShortVariable | Avoid variables with short names like sb | 3 | 59 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 68 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ImmutableField | Private field '_externalUserDAO' could be made final; it is only initialized in the declaration or constructor. | 3 | 108 |
| UnusedFormalParameter | Avoid unused method parameters such as 'locale'. | 3 | 159 |
| ForLoopCanBeForeach | This for loop can be replaced by a foreach loop | 3 | 188–208 |
| ForLoopCanBeForeach | This for loop can be replaced by a foreach loop | 3 | 215–222 |
| UnusedFormalParameter | Avoid unused method parameters such as 'locale'. | 3 | 240 |
| UnusedFormalParameter | Avoid unused method parameters such as 'config'. | 3 | 241 |
| UnusedFormalParameter | Avoid unused method parameters such as 'locale'. | 3 | 281 |
| UnusedFormalParameter | Avoid unused method parameters such as 'config'. | 3 | 282 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 3 | 83 |
| UseVarargs | Consider using varargs for methods or constructors which take an array the last parameter. | 4 | 121 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| AvoidDeeplyNestedIfStmts | Deeply nested if..then statements are hard to read | 3 | 260–264 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ClassNamingConventions | The utility class name 'TaskEditTicketConstants' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' | 1 | 41–60 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ClassWithOnlyPrivateConstructorsShouldBeFinal | A class which only has private constructors should be final | 1 | 36–44 |
| CommentRequired | Header comments are required | 3 | 36–44 |
| ClassNamingConventions | The utility class name 'UtilConstants' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' | 1 | 36–44 |
| FieldDeclarationsShouldBeAtStartOfClass | Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 3 | 43 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| FieldNamingConventions | The constant name '_resourceHistoryService' doesn't match '[A-Z][A-Z_0-9]*' | 1 | 64 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 113 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 138–150 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 171 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 171 |
| UnnecessaryLocalBeforeReturn | Consider simply returning the value vs storing it in local variable 'formatedErrors' | 3 | 179 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 3 | 34–375 |
| ImmutableField | Private field '_editableTicketService' could be made final; it is only initialized in the declaration or constructor. | 3 | 121 |
| ImmutableField | Private field '_ticketFormService' could be made final; it is only initialized in the declaration or constructor. | 3 | 122 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 185–220 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 201 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 213–220 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 249 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 57–105 |
| FieldNamingConventions | The final field name '_ticketFormService' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 71 |
| FieldNamingConventions | The final field name '_taskModifyTicketCategoryConfigService' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 72 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 3 | 34–384 |
| ImmutableField | Private field '_ticketEmailExternalUserHistoryDAO' could be made final; it is only initialized in the declaration or constructor. | 3 | 135 |
| ImmutableField | Private field '_ticketEmailExternalUserMessageDAO' could be made final; it is only initialized in the declaration or constructor. | 3 | 136 |
| ImmutableField | Private field '_taskTicketExternalUserConfigService' could be made final; it is only initialized in the declaration or constructor. | 3 | 137 |
| ImmutableField | Private field '_resourceHistoryService' could be made final; it is only initialized in the declaration or constructor. | 3 | 138 |
| CommentRequired | Public method and constructor comments are required | 3 | 152–155 |
| NPathComplexity | The method 'getExternalUserResponseView(HttpServletRequest)' has an NPath complexity of 2616 | 3 | 165–302 |
| NcssCount | The method 'getExternalUserResponseView(HttpServletRequest)' has a NCSS line count of 71. | 3 | 165–302 |
| ExcessiveMethodLength | Avoid really long methods. | 3 | 165–302 |
| CyclomaticComplexity | The method 'getExternalUserResponseView(HttpServletRequest)' has a cyclomatic complexity of 16. | 3 | 165–302 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 180 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 181 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 182 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 182 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 183 |
| AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 3 | 212 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 255 |
| AvoidCatchingNPE | Avoid catching NullPointerException; consider removing the cause of the NPE. | 3 | 255 |
| CommentRequired | Protected method constructor comments are required | 3 | 304–312 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 322–330 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 332 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 344 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 89 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 94–105 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 157 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| AvoidDeeplyNestedIfStmts | Deeply nested if..then statements are hard to read | 3 | 92–95 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 87 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 91–102 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 164 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 106 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 113–120 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 172 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 237 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 54–126 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 75 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 3 | 34–326 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 113 |
| CyclomaticComplexity | The method 'doValidateTask(int, String, HttpServletRequest, Locale, ITask)' has a cyclomatic complexity of 20. | 3 | 189–278 |
| NPathComplexity | The method 'doValidateTask(int, String, HttpServletRequest, Locale, ITask)' has an NPath complexity of 1300 | 3 | 189–278 |
| AvoidDeeplyNestedIfStmts | Deeply nested if..then statements are hard to read | 3 | 220–224 |
| AvoidDeeplyNestedIfStmts | Deeply nested if..then statements are hard to read | 3 | 229–246 |
| InefficientEmptyStringCheck | String.trim().length() == 0 / String.trim().isEmpty() is an inefficient way to validate a blank String. | 3 | 231 |
| InefficientEmptyStringCheck | String.trim().length() == 0 / String.trim().isEmpty() is an inefficient way to validate a blank String. | 3 | 286 |
| AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 3 | 308 |
| AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 3 | 313 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 79 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 3 | 34–215 |
| AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 3 | 180 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 3 | 34–392 |
| CommentRequired | Header comments are required | 3 | 72–392 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 133 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 146–169 |
| CyclomaticComplexity | The method 'getDisplayTaskInformation(int, HttpServletRequest, Locale, ITask)' has a cyclomatic complexity of 13. | 3 | 255–357 |
| ExcessiveMethodLength | Avoid really long methods. | 3 | 255–357 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 265 |
| ShortVariable | Avoid variables with short names like sb | 3 | 270 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 273–339 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 285–297 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 299–318 |
| InefficientEmptyStringCheck | String.trim().length() == 0 / String.trim().isEmpty() is an inefficient way to validate a blank String. | 3 | 342 |
| AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 3 | 345 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 93 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 97–106 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 3 | 34–515 |
| FieldNamingConventions | The constant name '_attributeService' doesn't match '[A-Z][A-Z_0-9]*' | 1 | 132 |
| UnusedPrivateField | Avoid unused private fields such as '_taskTicketConfigService'. | 3 | 136 |
| UnusedPrivateField | Avoid unused private fields such as '_actionService'. | 3 | 156 |
| FieldNamingConventions | The field name '_ExternalUserDAO' doesn't match '_[a-z][a-zA-Z0-9]*' | 1 | 160 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 185 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 187 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 217 |
| CyclomaticComplexity | The method 'getDisplayTaskForm(int, String, HttpServletRequest, Locale, ITask)' has a cyclomatic complexity of 15. | 3 | 230–301 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 263 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 265 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 277 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 296 |
| CyclomaticComplexity | The method 'doValidateTask(int, String, HttpServletRequest, Locale, ITask)' has a cyclomatic complexity of 15. | 3 | 332–404 |
| NPathComplexity | The method 'doValidateTask(int, String, HttpServletRequest, Locale, ITask)' has an NPath complexity of 315 | 3 | 332–404 |
| UnusedLocalVariable | Avoid unused local variables such as 'strEmailSubject'. | 3 | 340 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 340–341 |
| AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 3 | 364 |
| AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 3 | 378 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 412 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 422–445 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 63–149 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 3 | 69 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the taskComponent field if you want a default access modifier | 3 | 69 |
| FieldNamingConventions | The field name 'taskComponent' doesn't match '_[a-z][a-zA-Z0-9]*' | 1 | 69 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 134 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Public method and constructor comments are required | 3 | 102–105 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 151 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 164 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 164 |
