Fork me on GitHub

PMD Results

The following document contains the results of PMD 6.13.0.

Violations By Priority

Priority 1

fr/paris/lutece/plugins/workflow/modules/unittree/business/task/information/TaskInformation.java

Rule Violation Line
FieldNamingConventions The final field name '_nIdHistory' doesn't match '[a-z][a-zA-Z0-9]*' 45
FieldNamingConventions The final field name '_nIdTask' doesn't match '[a-z][a-zA-Z0-9]*' 46
FieldNamingConventions The final field name '_items' doesn't match '[a-z][a-zA-Z0-9]*' 47

fr/paris/lutece/plugins/workflow/modules/unittree/service/UnitAssignmentService.java

Rule Violation Line
FieldNamingConventions The constant name '_plugin' doesn't match '[A-Z][A-Z_0-9]*' 51

fr/paris/lutece/plugins/workflow/modules/unittree/service/task/selection/UnitSelectionService.java

Rule Violation Line
FieldNamingConventions The final field name '_listUnitSelections' doesn't match '[a-z][a-zA-Z0-9]*' 52

fr/paris/lutece/plugins/workflow/modules/unittree/service/task/selection/impl/AbstractEmptyConfigurationHandler.java

Rule Violation Line
EmptyMethodInAbstractClassShouldBeAbstract An empty method in an abstract class should be abstract instead 72–75
EmptyMethodInAbstractClassShouldBeAbstract An empty method in an abstract class should be abstract instead 81–84

fr/paris/lutece/plugins/workflow/modules/unittree/service/task/selection/impl/ParametrableUnitSelection.java

Rule Violation Line
FieldNamingConventions The final field name '_configurationHandler' doesn't match '[a-z][a-zA-Z0-9]*' 65

fr/paris/lutece/plugins/workflow/modules/unittree/service/task/selection/impl/UnitSelectionAssignor.java

Rule Violation Line
FieldNamingConventions The final field name '_configurationHandler' doesn't match '[a-z][a-zA-Z0-9]*' 70
FieldNamingConventions The final field name '_taskFormHandler' doesn't match '[a-z][a-zA-Z0-9]*' 71

fr/paris/lutece/plugins/workflow/modules/unittree/service/task/selection/impl/UnitSelectionFromAll.java

Rule Violation Line
FieldNamingConventions The final field name '_configurationHandler' doesn't match '[a-z][a-zA-Z0-9]*' 87
FieldNamingConventions The final field name '_taskFormHandler' doesn't match '[a-z][a-zA-Z0-9]*' 88

fr/paris/lutece/plugins/workflow/modules/unittree/service/task/selection/impl/UnitSelectionParent.java

Rule Violation Line
FieldNamingConventions The final field name '_configurationHandler' doesn't match '[a-z][a-zA-Z0-9]*' 68
FieldNamingConventions The final field name '_taskFormHandler' doesn't match '[a-z][a-zA-Z0-9]*' 69

fr/paris/lutece/plugins/workflow/modules/unittree/service/task/selection/impl/UnitSelectionSpecificUnit.java

Rule Violation Line
FieldNamingConventions The final field name '_unitService' doesn't match '[a-z][a-zA-Z0-9]*' 70
FieldNamingConventions The final field name '_configDAO' doesn't match '[a-z][a-zA-Z0-9]*' 71
FieldNamingConventions The final field name '_configurationHandler' doesn't match '[a-z][a-zA-Z0-9]*' 73
FieldNamingConventions The final field name '_taskFormHandler' doesn't match '[a-z][a-zA-Z0-9]*' 74

fr/paris/lutece/plugins/workflow/modules/unittree/util/ChangeUnitEvent.java

Rule Violation Line
FieldNamingConventions The final field name '_oldAssignmentList' doesn't match '[a-z][a-zA-Z0-9]*' 49

fr/paris/lutece/plugins/workflow/modules/unittree/util/WorkflowUnittreeConstants.java

Rule Violation Line
ClassNamingConventions The utility class name 'WorkflowUnittreeConstants' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' 40–51

fr/paris/lutece/plugins/workflow/modules/unittree/web/task/AbstractUnitAssignmentTaskComponent.java

Rule Violation Line
FieldNamingConventions The final field name '_strId' doesn't match '[a-z][a-zA-Z0-9]*' 262
FieldNamingConventions The final field name '_strTitle' doesn't match '[a-z][a-zA-Z0-9]*' 263
FieldNamingConventions The final field name '_strHtmlForm' doesn't match '[a-z][a-zA-Z0-9]*' 264

fr/paris/lutece/plugins/workflow/modules/unittree/web/task/AbstractUnittreeTaskComponent.java

Rule Violation Line
EmptyMethodInAbstractClassShouldBeAbstract An empty method in an abstract class should be abstract instead 85–88

Priority 3

fr/paris/lutece/plugins/workflow/modules/unittree/business/assignment/task/config/TaskUnitAssignmentNotificationConfig.java

Rule Violation Line
CommentRequired Header comments are required 38–74

fr/paris/lutece/plugins/workflow/modules/unittree/business/assignment/task/config/TaskUnitAssignmentNotificationConfigDAO.java

Rule Violation Line
CommentRequired Header comments are required 39–118

fr/paris/lutece/plugins/workflow/modules/unittree/business/assignment/task/selection/config/ParametrableUnitSelectionConfig.java

Rule Violation Line
CommentRequired Header comments are required 43–87
CommentRequired Public method and constructor comments are required 64–71

fr/paris/lutece/plugins/workflow/modules/unittree/business/assignment/task/selection/config/ParametrableUnitSelectionConfigDao.java

Rule Violation Line
CommentRequired Header comments are required 42–110

fr/paris/lutece/plugins/workflow/modules/unittree/service/prerequisite/ChildUnitAssignedResourcePrerequisite.java

Rule Violation Line
CommentRequired Header comments are required 53–126
MissingOverride The method 'getTitleI18nKey()' is missing an @Override annotation. 59–62
CommentRequired Public method and constructor comments are required 59–62
MissingOverride The method 'getPrerequisiteType()' is missing an @Override annotation. 64–67
CommentRequired Public method and constructor comments are required 64–67

fr/paris/lutece/plugins/workflow/modules/unittree/service/prerequisite/UserUnitAssignedResourcePrerequisite.java

Rule Violation Line
CommentRequired Header comments are required 51–122
MissingOverride The method 'getTitleI18nKey()' is missing an @Override annotation. 57–60
CommentRequired Public method and constructor comments are required 57–60
MissingOverride The method 'getPrerequisiteType()' is missing an @Override annotation. 62–65
CommentRequired Public method and constructor comments are required 62–65

fr/paris/lutece/plugins/workflow/modules/unittree/service/task/AbstractTaskUnitAssignment.java

Rule Violation Line
CyclomaticComplexity The method 'buildUnitAssignmentListToDeactivate(List, UnitAssignment)' has a cyclomatic complexity of 13. 278–335

fr/paris/lutece/plugins/workflow/modules/unittree/service/task/TaskUnitAssignmentNotification.java

Rule Violation Line
CommentRequired Header comments are required 61–152
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 118–124

fr/paris/lutece/plugins/workflow/modules/unittree/service/task/selection/impl/AbstractEmptyConfigurationHandler.java

Rule Violation Line
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 61

fr/paris/lutece/plugins/workflow/modules/unittree/service/task/selection/impl/ParametrableUnitSelection.java

Rule Violation Line
CommentRequired Header comments are required 58–217
ShortVariable Avoid variables with short names like ID 60
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 144
ConfusingTernary Avoid if (x != y) ..; else ..; 148–159

fr/paris/lutece/plugins/workflow/modules/unittree/service/task/selection/impl/UnitSelectionAssignor.java

Rule Violation Line
ShortVariable Avoid variables with short names like ID 64
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 178

fr/paris/lutece/plugins/workflow/modules/unittree/service/task/selection/impl/UnitSelectionFromAll.java

Rule Violation Line
ShortVariable Avoid variables with short names like ID 72
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 203

fr/paris/lutece/plugins/workflow/modules/unittree/service/task/selection/impl/UnitSelectionParent.java

Rule Violation Line
ShortVariable Avoid variables with short names like ID 62
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 181

fr/paris/lutece/plugins/workflow/modules/unittree/service/task/selection/impl/UnitSelectionSpecificUnit.java

Rule Violation Line
ShortVariable Avoid variables with short names like ID 67
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 184
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 324

fr/paris/lutece/plugins/workflow/modules/unittree/util/ChangeUnitEvent.java

Rule Violation Line
CommentRequired Public method and constructor comments are required 51–55

fr/paris/lutece/plugins/workflow/modules/unittree/util/ChangeUnitEventPublisher.java

Rule Violation Line
CommentRequired Public method and constructor comments are required 51–54
MissingOverride The method 'setApplicationEventPublisher(ApplicationEventPublisher)' is missing an @Override annotation. 51–54
CommentRequired Public method and constructor comments are required 56–59

fr/paris/lutece/plugins/workflow/modules/unittree/web/task/AbstractUnitAssignmentTaskComponent.java

Rule Violation Line
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 113

fr/paris/lutece/plugins/workflow/modules/unittree/web/task/AbstractUnittreeTaskComponent.java

Rule Violation Line
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 70

fr/paris/lutece/plugins/workflow/modules/unittree/web/task/UnitAssignmentAutomaticTaskComponent.java

Rule Violation Line
UnusedLocalVariable Avoid unused local variables such as 'config'. 69
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 69
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 72

fr/paris/lutece/plugins/workflow/modules/unittree/web/task/UnitAssignmentManualTaskComponent.java

Rule Violation Line
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 100
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 118

fr/paris/lutece/plugins/workflow/modules/unittree/web/task/UnitAssignmentNotificationTaskComponent.java

Rule Violation Line
CommentRequired Header comments are required 51–89
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 73

Priority 4

fr/paris/lutece/plugins/workflow/modules/unittree/service/task/TaskUnitAssignmentNotification.java

Rule Violation Line
UnusedImports Avoid unused imports such as 'fr.paris.lutece.portal.service.util.AppPropertiesService' 59

Files

fr/paris/lutece/plugins/workflow/modules/unittree/business/assignment/task/config/TaskUnitAssignmentNotificationConfig.java

Rule Violation Priority Line
CommentRequired Header comments are required 3 38–74

fr/paris/lutece/plugins/workflow/modules/unittree/business/assignment/task/config/TaskUnitAssignmentNotificationConfigDAO.java

Rule Violation Priority Line
CommentRequired Header comments are required 3 39–118

fr/paris/lutece/plugins/workflow/modules/unittree/business/assignment/task/selection/config/ParametrableUnitSelectionConfig.java

Rule Violation Priority Line
CommentRequired Header comments are required 3 43–87
CommentRequired Public method and constructor comments are required 3 64–71

fr/paris/lutece/plugins/workflow/modules/unittree/business/assignment/task/selection/config/ParametrableUnitSelectionConfigDao.java

Rule Violation Priority Line
CommentRequired Header comments are required 3 42–110

fr/paris/lutece/plugins/workflow/modules/unittree/business/task/information/TaskInformation.java

Rule Violation Priority Line
FieldNamingConventions The final field name '_nIdHistory' doesn't match '[a-z][a-zA-Z0-9]*' 1 45
FieldNamingConventions The final field name '_nIdTask' doesn't match '[a-z][a-zA-Z0-9]*' 1 46
FieldNamingConventions The final field name '_items' doesn't match '[a-z][a-zA-Z0-9]*' 1 47

fr/paris/lutece/plugins/workflow/modules/unittree/service/UnitAssignmentService.java

Rule Violation Priority Line
FieldNamingConventions The constant name '_plugin' doesn't match '[A-Z][A-Z_0-9]*' 1 51

fr/paris/lutece/plugins/workflow/modules/unittree/service/prerequisite/ChildUnitAssignedResourcePrerequisite.java

Rule Violation Priority Line
CommentRequired Header comments are required 3 53–126
MissingOverride The method 'getTitleI18nKey()' is missing an @Override annotation. 3 59–62
CommentRequired Public method and constructor comments are required 3 59–62
MissingOverride The method 'getPrerequisiteType()' is missing an @Override annotation. 3 64–67
CommentRequired Public method and constructor comments are required 3 64–67

fr/paris/lutece/plugins/workflow/modules/unittree/service/prerequisite/UserUnitAssignedResourcePrerequisite.java

Rule Violation Priority Line
CommentRequired Header comments are required 3 51–122
MissingOverride The method 'getTitleI18nKey()' is missing an @Override annotation. 3 57–60
CommentRequired Public method and constructor comments are required 3 57–60
MissingOverride The method 'getPrerequisiteType()' is missing an @Override annotation. 3 62–65
CommentRequired Public method and constructor comments are required 3 62–65

fr/paris/lutece/plugins/workflow/modules/unittree/service/task/AbstractTaskUnitAssignment.java

Rule Violation Priority Line
CyclomaticComplexity The method 'buildUnitAssignmentListToDeactivate(List, UnitAssignment)' has a cyclomatic complexity of 13. 3 278–335

fr/paris/lutece/plugins/workflow/modules/unittree/service/task/TaskUnitAssignmentNotification.java

Rule Violation Priority Line
UnusedImports Avoid unused imports such as 'fr.paris.lutece.portal.service.util.AppPropertiesService' 4 59
CommentRequired Header comments are required 3 61–152
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 3 118–124

fr/paris/lutece/plugins/workflow/modules/unittree/service/task/selection/UnitSelectionService.java

Rule Violation Priority Line
FieldNamingConventions The final field name '_listUnitSelections' doesn't match '[a-z][a-zA-Z0-9]*' 1 52

fr/paris/lutece/plugins/workflow/modules/unittree/service/task/selection/impl/AbstractEmptyConfigurationHandler.java

Rule Violation Priority Line
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 61
EmptyMethodInAbstractClassShouldBeAbstract An empty method in an abstract class should be abstract instead 1 72–75
EmptyMethodInAbstractClassShouldBeAbstract An empty method in an abstract class should be abstract instead 1 81–84

fr/paris/lutece/plugins/workflow/modules/unittree/service/task/selection/impl/ParametrableUnitSelection.java

Rule Violation Priority Line
CommentRequired Header comments are required 3 58–217
ShortVariable Avoid variables with short names like ID 3 60
FieldNamingConventions The final field name '_configurationHandler' doesn't match '[a-z][a-zA-Z0-9]*' 1 65
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 144
ConfusingTernary Avoid if (x != y) ..; else ..; 3 148–159

fr/paris/lutece/plugins/workflow/modules/unittree/service/task/selection/impl/UnitSelectionAssignor.java

Rule Violation Priority Line
ShortVariable Avoid variables with short names like ID 3 64
FieldNamingConventions The final field name '_configurationHandler' doesn't match '[a-z][a-zA-Z0-9]*' 1 70
FieldNamingConventions The final field name '_taskFormHandler' doesn't match '[a-z][a-zA-Z0-9]*' 1 71
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 178

fr/paris/lutece/plugins/workflow/modules/unittree/service/task/selection/impl/UnitSelectionFromAll.java

Rule Violation Priority Line
ShortVariable Avoid variables with short names like ID 3 72
FieldNamingConventions The final field name '_configurationHandler' doesn't match '[a-z][a-zA-Z0-9]*' 1 87
FieldNamingConventions The final field name '_taskFormHandler' doesn't match '[a-z][a-zA-Z0-9]*' 1 88
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 203

fr/paris/lutece/plugins/workflow/modules/unittree/service/task/selection/impl/UnitSelectionParent.java

Rule Violation Priority Line
ShortVariable Avoid variables with short names like ID 3 62
FieldNamingConventions The final field name '_configurationHandler' doesn't match '[a-z][a-zA-Z0-9]*' 1 68
FieldNamingConventions The final field name '_taskFormHandler' doesn't match '[a-z][a-zA-Z0-9]*' 1 69
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 181

fr/paris/lutece/plugins/workflow/modules/unittree/service/task/selection/impl/UnitSelectionSpecificUnit.java

Rule Violation Priority Line
ShortVariable Avoid variables with short names like ID 3 67
FieldNamingConventions The final field name '_unitService' doesn't match '[a-z][a-zA-Z0-9]*' 1 70
FieldNamingConventions The final field name '_configDAO' doesn't match '[a-z][a-zA-Z0-9]*' 1 71
FieldNamingConventions The final field name '_configurationHandler' doesn't match '[a-z][a-zA-Z0-9]*' 1 73
FieldNamingConventions The final field name '_taskFormHandler' doesn't match '[a-z][a-zA-Z0-9]*' 1 74
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 184
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 324

fr/paris/lutece/plugins/workflow/modules/unittree/util/ChangeUnitEvent.java

Rule Violation Priority Line
FieldNamingConventions The final field name '_oldAssignmentList' doesn't match '[a-z][a-zA-Z0-9]*' 1 49
CommentRequired Public method and constructor comments are required 3 51–55

fr/paris/lutece/plugins/workflow/modules/unittree/util/ChangeUnitEventPublisher.java

Rule Violation Priority Line
CommentRequired Public method and constructor comments are required 3 51–54
MissingOverride The method 'setApplicationEventPublisher(ApplicationEventPublisher)' is missing an @Override annotation. 3 51–54
CommentRequired Public method and constructor comments are required 3 56–59

fr/paris/lutece/plugins/workflow/modules/unittree/util/WorkflowUnittreeConstants.java

Rule Violation Priority Line
ClassNamingConventions The utility class name 'WorkflowUnittreeConstants' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' 1 40–51

fr/paris/lutece/plugins/workflow/modules/unittree/web/task/AbstractUnitAssignmentTaskComponent.java

Rule Violation Priority Line
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 113
FieldNamingConventions The final field name '_strId' doesn't match '[a-z][a-zA-Z0-9]*' 1 262
FieldNamingConventions The final field name '_strTitle' doesn't match '[a-z][a-zA-Z0-9]*' 1 263
FieldNamingConventions The final field name '_strHtmlForm' doesn't match '[a-z][a-zA-Z0-9]*' 1 264

fr/paris/lutece/plugins/workflow/modules/unittree/web/task/AbstractUnittreeTaskComponent.java

Rule Violation Priority Line
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 70
EmptyMethodInAbstractClassShouldBeAbstract An empty method in an abstract class should be abstract instead 1 85–88

fr/paris/lutece/plugins/workflow/modules/unittree/web/task/UnitAssignmentAutomaticTaskComponent.java

Rule Violation Priority Line
UnusedLocalVariable Avoid unused local variables such as 'config'. 3 69
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 69
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 72

fr/paris/lutece/plugins/workflow/modules/unittree/web/task/UnitAssignmentManualTaskComponent.java

Rule Violation Priority Line
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 100
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 118

fr/paris/lutece/plugins/workflow/modules/unittree/web/task/UnitAssignmentNotificationTaskComponent.java

Rule Violation Priority Line
CommentRequired Header comments are required 3 51–89
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 73