PMD Results
The following document contains the results of PMD 5.5.1.
Files
fr/paris/lutece/plugins/workflow/modules/upload/business/file/UploadFileDAO.java
| Violation |
Line |
| Use block level rather than method level synchronization |
94–108 |
fr/paris/lutece/plugins/workflow/modules/upload/business/history/UploadHistory.java
| Violation |
Line |
| Avoid variables with short names like id |
72 |
| Avoid variables with short names like sb |
106 |
fr/paris/lutece/plugins/workflow/modules/upload/business/history/UploadHistoryDAO.java
| Violation |
Line |
| Use block level rather than method level synchronization |
62–73 |
fr/paris/lutece/plugins/workflow/modules/upload/business/task/TaskUploadConfigDAO.java
| Violation |
Line |
| Use block level rather than method level synchronization |
56–70 |
fr/paris/lutece/plugins/workflow/modules/upload/services/TaskUploadAsynchronousUploadHandler.java
| Violation |
Line |
| If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation |
76 |
| Avoid declaring a variable if it is unreferenced before a possible exit point. |
110 |
| Use bitwise inversion to invert boolean values |
197 |
fr/paris/lutece/plugins/workflow/modules/upload/services/UploadResourceIdService.java
| Violation |
Line |
| It is a good practice to call super() in a constructor |
60–63 |
| Avoid variables with short names like rt |
70 |
| Avoid variables with short names like p |
76 |
fr/paris/lutece/plugins/workflow/modules/upload/services/download/UploadWorkflowFileServlet.java
| Violation |
Line |
| Avoid declaring a variable if it is unreferenced before a possible exit point. |
86 |
| Avoid variables with short names like os |
113 |
fr/paris/lutece/plugins/workflow/modules/upload/services/provider/UploadMarkerProvider.java
| Violation |
Line |
| Avoid unused imports such as 'fr.paris.lutece.portal.service.spring.SpringContextService' |
49 |
| Avoid unused imports such as 'fr.paris.lutece.portal.service.spring.SpringContextService' |
49 |
| Avoid variables with short names like ID |
60 |
fr/paris/lutece/plugins/workflow/modules/upload/web/UploadJspBean.java
| Violation |
Line |
| A high number of imports can indicate a high degree of coupling within an object. |
34–237 |
| Private field '_uploadHistoryService' could be made final; it is only initialized in the declaration or constructor. |
107 |
| Private field '_resourceHistoryService' could be made final; it is only initialized in the declaration or constructor. |
108 |
| Private field '_taskService' could be made final; it is only initialized in the declaration or constructor. |
109 |
| Private field '_taskComponentManager' could be made final; it is only initialized in the declaration or constructor. |
110 |
fr/paris/lutece/plugins/workflow/modules/upload/web/UploadTaskComponent.java
| Violation |
Line |
| Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block |
122 |
| Avoid empty catch blocks |
122–124 |
| Avoid using Literals in Conditional Statements |
134 |
| Avoid declaring a variable if it is unreferenced before a possible exit point. |
164 |
| If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation |
192 |
| If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation |
208 |
| If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation |
231 |
| If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation |
240 |
