Fork me on GitHub
Built by Maven

PMD Results

The following document contains the results of PMD 6.13.0.

Violations By Priority

Priority 3

fr/paris/lutece/plugins/accesscontrol/business/AccessControl.java

Rule Violation Line
MissingOverride The method 'getWorkgroup()' is missing an @Override annotation. 188–191

fr/paris/lutece/plugins/accesscontrol/business/AccessControlDAO.java

Rule Violation Line
AssignmentInOperand Avoid assignments in operands 275
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 275

fr/paris/lutece/plugins/accesscontrol/business/AccessControlFilter.java

Rule Violation Line
RedundantFieldInitializer Avoid using redundant field initializer for '_strName' 51
CommentRequired Public method and constructor comments are required 53–56
CommentRequired Public method and constructor comments are required 58–61
CommentRequired Public method and constructor comments are required 121–125

fr/paris/lutece/plugins/accesscontrol/business/AccessControlResource.java

Rule Violation Line
CommentRequired Header comments are required 36–92

fr/paris/lutece/plugins/accesscontrol/business/AccessControlResourceDAO.java

Rule Violation Line
ShortVariable Avoid variables with short names like id 92

fr/paris/lutece/plugins/accesscontrol/business/UserCodeControllerData.java

Rule Violation Line
CommentRequired Header comments are required 38–113

fr/paris/lutece/plugins/accesscontrol/business/UserCodeControllerDataHome.java

Rule Violation Line
CommentRequired Header comments are required 42–134

fr/paris/lutece/plugins/accesscontrol/service/AbstractPersistentAccessControllerType.java

Rule Violation Line
CommentRequired Header comments are required 51–132
CommentRequired Protected method constructor comments are required 59–77
CommentRequired Protected method constructor comments are required 101–119
ConfusingTernary Avoid if (x != y) ..; else ..; 110–118
CommentRequired Protected method constructor comments are required 121–129
CommentRequired Protected method constructor comments are required 131

fr/paris/lutece/plugins/accesscontrol/service/AbstractUserCodeAccessControllerType.java

Rule Violation Line
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 92
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 111
CommentRequired Protected method constructor comments are required 136
CommentRequired Protected method constructor comments are required 138

fr/paris/lutece/plugins/accesscontrol/service/AccessControlService.java

Rule Violation Line
CommentRequired Header comments are required 52–124

fr/paris/lutece/plugins/accesscontrol/service/AgeAccessControllerType.java

Rule Violation Line
CommentRequired Header comments are required 57–182
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 112
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 123

fr/paris/lutece/plugins/accesscontrol/service/CommentAccessControllerType.java

Rule Violation Line
CommentRequired Header comments are required 51–123
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 100
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 118

fr/paris/lutece/plugins/accesscontrol/service/IAccessControlService.java

Rule Violation Line
CommentRequired Header comments are required 45–90

fr/paris/lutece/plugins/accesscontrol/service/IAccessControllerType.java

Rule Violation Line
UncommentedEmptyMethodBody Document empty method body 78–79
UncommentedEmptyMethodBody Document empty method body 99–100

fr/paris/lutece/plugins/accesscontrol/service/IPersistentDataHandler.java

Rule Violation Line
CommentRequired Header comments are required 44–87
CommentRequired Public method and constructor comments are required 47

fr/paris/lutece/plugins/accesscontrol/service/LuteceUserCodeAccessControllerType.java

Rule Violation Line
CommentRequired Header comments are required 45–80

fr/paris/lutece/plugins/accesscontrol/service/TosAccessControllerType.java

Rule Violation Line
CommentRequired Header comments are required 51–137
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 102
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 121

fr/paris/lutece/plugins/accesscontrol/service/UserCodeAccessControllerType.java

Rule Violation Line
CommentRequired Header comments are required 42–73

fr/paris/lutece/plugins/accesscontrol/service/rbac/AccessControlRbacAction.java

Rule Violation Line
CommentRequired Header comments are required 42–171

fr/paris/lutece/plugins/accesscontrol/service/rbac/AccessControlResourceIdService.java

Rule Violation Line
DataClass The class 'AccessControlResourceIdService' is suspected to be a Data Class (WOC=0.000%, NOPA=4, NOAM=0, WMC=1) 48–123
CommentRequired Header comments are required 48–123

fr/paris/lutece/plugins/accesscontrol/util/BoolCondition.java

Rule Violation Line
CommentRequired Enum comments are required 40–56
UnnecessaryModifier Unnecessary modifier 'private' on constructor 'BoolCondition(String)': enum constructors are implicitly private 47–50
CommentRequired Public method and constructor comments are required 52–55

fr/paris/lutece/plugins/accesscontrol/web/AccessControlJspBean.java

Rule Violation Line
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 34–600
ImmutableField Private field '_accessControlService' could be made final; it is only initialized in the declaration or constructor. 143
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 158
ConfusingTernary Avoid if (x != y) ..; else ..; 175
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 283

fr/paris/lutece/plugins/accesscontrol/web/AccessControlXPage.java

Rule Violation Line
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 34–256
CommentRequired Header comments are required 74–256
ImmutableField Private field '_service' could be made final; it is only initialized in the declaration or constructor. 115
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 138
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 155
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 233
CommentRequired Public method and constructor comments are required 234–248
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 250
CommentRequired Public method and constructor comments are required 251–255

fr/paris/lutece/plugins/accesscontrol/web/UserCodeControllerJspBean.java

Rule Violation Line
ImmutableField Private field '_accessControlService' could be made final; it is only initialized in the declaration or constructor. 90
CommentRequired Public method and constructor comments are required 111–114
CommentRequired Public method and constructor comments are required 117–148

Files

fr/paris/lutece/plugins/accesscontrol/business/AccessControl.java

Rule Violation Priority Line
MissingOverride The method 'getWorkgroup()' is missing an @Override annotation. 3 188–191

fr/paris/lutece/plugins/accesscontrol/business/AccessControlDAO.java

Rule Violation Priority Line
AssignmentInOperand Avoid assignments in operands 3 275
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 3 275

fr/paris/lutece/plugins/accesscontrol/business/AccessControlFilter.java

Rule Violation Priority Line
RedundantFieldInitializer Avoid using redundant field initializer for '_strName' 3 51
CommentRequired Public method and constructor comments are required 3 53–56
CommentRequired Public method and constructor comments are required 3 58–61
CommentRequired Public method and constructor comments are required 3 121–125

fr/paris/lutece/plugins/accesscontrol/business/AccessControlResource.java

Rule Violation Priority Line
CommentRequired Header comments are required 3 36–92

fr/paris/lutece/plugins/accesscontrol/business/AccessControlResourceDAO.java

Rule Violation Priority Line
ShortVariable Avoid variables with short names like id 3 92

fr/paris/lutece/plugins/accesscontrol/business/UserCodeControllerData.java

Rule Violation Priority Line
CommentRequired Header comments are required 3 38–113

fr/paris/lutece/plugins/accesscontrol/business/UserCodeControllerDataHome.java

Rule Violation Priority Line
CommentRequired Header comments are required 3 42–134

fr/paris/lutece/plugins/accesscontrol/service/AbstractPersistentAccessControllerType.java

Rule Violation Priority Line
CommentRequired Header comments are required 3 51–132
CommentRequired Protected method constructor comments are required 3 59–77
CommentRequired Protected method constructor comments are required 3 101–119
ConfusingTernary Avoid if (x != y) ..; else ..; 3 110–118
CommentRequired Protected method constructor comments are required 3 121–129
CommentRequired Protected method constructor comments are required 3 131

fr/paris/lutece/plugins/accesscontrol/service/AbstractUserCodeAccessControllerType.java

Rule Violation Priority Line
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 92
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 111
CommentRequired Protected method constructor comments are required 3 136
CommentRequired Protected method constructor comments are required 3 138

fr/paris/lutece/plugins/accesscontrol/service/AccessControlService.java

Rule Violation Priority Line
CommentRequired Header comments are required 3 52–124

fr/paris/lutece/plugins/accesscontrol/service/AgeAccessControllerType.java

Rule Violation Priority Line
CommentRequired Header comments are required 3 57–182
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 112
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 123

fr/paris/lutece/plugins/accesscontrol/service/CommentAccessControllerType.java

Rule Violation Priority Line
CommentRequired Header comments are required 3 51–123
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 100
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 118

fr/paris/lutece/plugins/accesscontrol/service/IAccessControlService.java

Rule Violation Priority Line
CommentRequired Header comments are required 3 45–90

fr/paris/lutece/plugins/accesscontrol/service/IAccessControllerType.java

Rule Violation Priority Line
UncommentedEmptyMethodBody Document empty method body 3 78–79
UncommentedEmptyMethodBody Document empty method body 3 99–100

fr/paris/lutece/plugins/accesscontrol/service/IPersistentDataHandler.java

Rule Violation Priority Line
CommentRequired Header comments are required 3 44–87
CommentRequired Public method and constructor comments are required 3 47

fr/paris/lutece/plugins/accesscontrol/service/LuteceUserCodeAccessControllerType.java

Rule Violation Priority Line
CommentRequired Header comments are required 3 45–80

fr/paris/lutece/plugins/accesscontrol/service/TosAccessControllerType.java

Rule Violation Priority Line
CommentRequired Header comments are required 3 51–137
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 102
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 121

fr/paris/lutece/plugins/accesscontrol/service/UserCodeAccessControllerType.java

Rule Violation Priority Line
CommentRequired Header comments are required 3 42–73

fr/paris/lutece/plugins/accesscontrol/service/rbac/AccessControlRbacAction.java

Rule Violation Priority Line
CommentRequired Header comments are required 3 42–171

fr/paris/lutece/plugins/accesscontrol/service/rbac/AccessControlResourceIdService.java

Rule Violation Priority Line
DataClass The class 'AccessControlResourceIdService' is suspected to be a Data Class (WOC=0.000%, NOPA=4, NOAM=0, WMC=1) 3 48–123
CommentRequired Header comments are required 3 48–123

fr/paris/lutece/plugins/accesscontrol/util/BoolCondition.java

Rule Violation Priority Line
CommentRequired Enum comments are required 3 40–56
UnnecessaryModifier Unnecessary modifier 'private' on constructor 'BoolCondition(String)': enum constructors are implicitly private 3 47–50
CommentRequired Public method and constructor comments are required 3 52–55

fr/paris/lutece/plugins/accesscontrol/web/AccessControlJspBean.java

Rule Violation Priority Line
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 3 34–600
ImmutableField Private field '_accessControlService' could be made final; it is only initialized in the declaration or constructor. 3 143
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 158
ConfusingTernary Avoid if (x != y) ..; else ..; 3 175
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 283

fr/paris/lutece/plugins/accesscontrol/web/AccessControlXPage.java

Rule Violation Priority Line
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 3 34–256
CommentRequired Header comments are required 3 74–256
ImmutableField Private field '_service' could be made final; it is only initialized in the declaration or constructor. 3 115
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 3 138
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 155
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 3 233
CommentRequired Public method and constructor comments are required 3 234–248
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 3 250
CommentRequired Public method and constructor comments are required 3 251–255

fr/paris/lutece/plugins/accesscontrol/web/UserCodeControllerJspBean.java

Rule Violation Priority Line
ImmutableField Private field '_accessControlService' could be made final; it is only initialized in the declaration or constructor. 3 90
CommentRequired Public method and constructor comments are required 3 111–114
CommentRequired Public method and constructor comments are required 3 117–148