Fork me on GitHub

PMD Results

The following document contains the results of PMD 6.13.0.

Violations By Priority

Priority 1

fr/paris/lutece/plugins/accountgenerator/business/IdentityAccount.java

Rule Violation Line
FieldNamingConventions The field name 'guid' doesn't match '_[a-z][a-zA-Z0-9]*' 40
FieldNamingConventions The field name 'cuid' doesn't match '_[a-z][a-zA-Z0-9]*' 41
FieldNamingConventions The field name 'creationDate' doesn't match '_[a-z][a-zA-Z0-9]*' 42
FieldNamingConventions The field name 'expirationDate' doesn't match '_[a-z][a-zA-Z0-9]*' 43

fr/paris/lutece/plugins/accountgenerator/business/IdentityAccountHome.java

Rule Violation Line
FieldNamingConventions The constant name '_dao' doesn't match '[A-Z][A-Z_0-9]*' 46
FieldNamingConventions The constant name '_plugin' doesn't match '[A-Z][A-Z_0-9]*' 47

fr/paris/lutece/plugins/accountgenerator/daemon/PurgeExpiratedIdentityAccountsDaemons.java

Rule Violation Line
LocalVariableNamingConventions The local variable name 'S' doesn't match '[a-z][a-zA-Z0-9]*' 57
LocalVariableNamingConventions The local variable name 'H' doesn't match '[a-z][a-zA-Z0-9]*' 58
LocalVariableNamingConventions The local variable name 'M' doesn't match '[a-z][a-zA-Z0-9]*' 59

fr/paris/lutece/plugins/accountgenerator/dto/CitiesCodesListResponse.java

Rule Violation Line
FieldNamingConventions The field name 'result' doesn't match '_[a-z][a-zA-Z0-9]*' 40
FieldNamingConventions The field name 'status' doesn't match '_[a-z][a-zA-Z0-9]*' 41

fr/paris/lutece/plugins/accountgenerator/dto/PurgeExipratedIdentityAccountsResult.java

Rule Violation Line
FieldNamingConventions The field name 'nbDeletedAccounts' doesn't match '_[a-z][a-zA-Z0-9]*' 38
FieldNamingConventions The field name 'nbDeletedIdentities' doesn't match '_[a-z][a-zA-Z0-9]*' 39

fr/paris/lutece/plugins/accountgenerator/service/GeocodesCache.java

Rule Violation Line
ClassWithOnlyPrivateConstructorsShouldBeFinal A class which only has private constructors should be final 53–118
FieldNamingConventions The constant name 'geocodesCitiesCodesEndpoint' doesn't match '[A-Z][A-Z_0-9]*' 57
FieldNamingConventions The constant name 'citiesCodesDateFormat' doesn't match '[A-Z][A-Z_0-9]*' 58
FieldNamingConventions The constant name 'client' doesn't match '[A-Z][A-Z_0-9]*' 59
FieldNamingConventions The constant name '_mapper' doesn't match '[A-Z][A-Z_0-9]*' 60
FieldNamingConventions The static field name 'instance' doesn't match '_[a-z][a-zA-Z0-9]*' 62

fr/paris/lutece/plugins/accountgenerator/service/IdentityAccountGeneratorService.java

Rule Violation Line
ClassWithOnlyPrivateConstructorsShouldBeFinal A class which only has private constructors should be final 74–368
FieldNamingConventions The static field name 'instance' doesn't match '_[a-z][a-zA-Z0-9]*' 77
FieldNamingConventions The constant name '_identityService' doesn't match '[A-Z][A-Z_0-9]*' 89
FieldNamingConventions The constant name '_accountManagementService' doesn't match '[A-Z][A-Z_0-9]*' 90
FieldNamingConventions The constant name '_geocodesCache' doesn't match '[A-Z][A-Z_0-9]*' 91
FieldNamingConventions The constant name 'accountManagementClientId' doesn't match '[A-Z][A-Z_0-9]*' 94
FieldNamingConventions The constant name 'accountManagementSecretId' doesn't match '[A-Z][A-Z_0-9]*' 95
FieldNamingConventions The constant name 'identityStoreClientCode' doesn't match '[A-Z][A-Z_0-9]*' 96
FieldNamingConventions The constant name 'identityStoreClientName' doesn't match '[A-Z][A-Z_0-9]*' 97
FieldNamingConventions The constant name 'commonPassword' doesn't match '[A-Z][A-Z_0-9]*' 100
FieldNamingConventions The constant name 'commonMailSuffix' doesn't match '[A-Z][A-Z_0-9]*' 101
FieldNamingConventions The constant name 'mailCertifier' doesn't match '[A-Z][A-Z_0-9]*' 102
FieldNamingConventions The constant name 'loginCertifier' doesn't match '[A-Z][A-Z_0-9]*' 103
FieldNamingConventions The constant name 'firstNameCertifier' doesn't match '[A-Z][A-Z_0-9]*' 104
FieldNamingConventions The constant name 'familyNameCertifier' doesn't match '[A-Z][A-Z_0-9]*' 105
FieldNamingConventions The constant name 'birthplaceCodeCertifier' doesn't match '[A-Z][A-Z_0-9]*' 106
FieldNamingConventions The constant name 'birthCountryCodeCertifier' doesn't match '[A-Z][A-Z_0-9]*' 107
FieldNamingConventions The constant name 'birthCountryCodeValue' doesn't match '[A-Z][A-Z_0-9]*' 108
FieldNamingConventions The constant name 'genderCertifier' doesn't match '[A-Z][A-Z_0-9]*' 109
FieldNamingConventions The constant name 'birthdateCertifier' doesn't match '[A-Z][A-Z_0-9]*' 110
FieldNamingConventions The constant name 'birthdateMaxGenerationDay' doesn't match '[A-Z][A-Z_0-9]*' 111
FieldNamingConventions The constant name 'birthdateMaxGenerationMonth' doesn't match '[A-Z][A-Z_0-9]*' 112
FieldNamingConventions The constant name 'birthdateMaxGenerationYear' doesn't match '[A-Z][A-Z_0-9]*' 113
FieldNamingConventions The constant name 'genders' doesn't match '[A-Z][A-Z_0-9]*' 116
FieldNamingConventions The constant name 'alphabet' doesn't match '[A-Z][A-Z_0-9]*' 117
FieldNamingConventions The constant name 'random' doesn't match '[A-Z][A-Z_0-9]*' 119
FieldNamingConventions The constant name 'dateTimeFormatter' doesn't match '[A-Z][A-Z_0-9]*' 121

fr/paris/lutece/plugins/accountgenerator/service/IdentityAccountPurgeService.java

Rule Violation Line
ClassWithOnlyPrivateConstructorsShouldBeFinal A class which only has private constructors should be final 55–147
FieldNamingConventions The static field name 'instance' doesn't match '_[a-z][a-zA-Z0-9]*' 58
FieldNamingConventions The constant name 'accountManagementClientId' doesn't match '[A-Z][A-Z_0-9]*' 70
FieldNamingConventions The constant name 'accountManagementSecretId' doesn't match '[A-Z][A-Z_0-9]*' 71
FieldNamingConventions The constant name 'identityStoreClientCode' doesn't match '[A-Z][A-Z_0-9]*' 72
FieldNamingConventions The constant name 'identityStoreClientName' doesn't match '[A-Z][A-Z_0-9]*' 73
FieldNamingConventions The constant name '_identityService' doesn't match '[A-Z][A-Z_0-9]*' 76
FieldNamingConventions The constant name '_accountManagementService' doesn't match '[A-Z][A-Z_0-9]*' 77

fr/paris/lutece/plugins/accountgenerator/web/request/AccountGeneratorCreateRequest.java

Rule Violation Line
FieldNamingConventions The constant name 'generationLimit' doesn't match '[A-Z][A-Z_0-9]*' 51
FieldNamingConventions The static field name 'JSON_EXAMPLE' doesn't match '_[a-z][a-zA-Z0-9]*' 52
FieldNamingConventions The final field name '_accountGenerationRequest' doesn't match '[a-z][a-zA-Z0-9]*' 55

Priority 2

fr/paris/lutece/plugins/accountgenerator/service/IdentityAccountPurgeService.java

Rule Violation Line
GuardLogStatement Logger calls should be surrounded by log level guards. 109
GuardLogStatement Logger calls should be surrounded by log level guards. 132

Priority 3

fr/paris/lutece/plugins/accountgenerator/AccountGeneratorPlugin.java

Rule Violation Line
UncommentedEmptyMethodBody Document empty method body 50–51

fr/paris/lutece/plugins/accountgenerator/business/IIdentityAccountDao.java

Rule Violation Line
CommentRequired Header comments are required 40–49
CommentRequired Public method and constructor comments are required 44
CommentRequired Public method and constructor comments are required 46
CommentRequired Public method and constructor comments are required 48

fr/paris/lutece/plugins/accountgenerator/business/IdentityAccount.java

Rule Violation Line
DataClass The class 'IdentityAccount' is suspected to be a Data Class (WOC=0.000%, NOPA=0, NOAM=8, WMC=8) 38–84
CommentRequired Header comments are required 38–84

fr/paris/lutece/plugins/accountgenerator/business/IdentityAccountDao.java

Rule Violation Line
CommentRequired Header comments are required 43–97
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 52
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 68
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 82

fr/paris/lutece/plugins/accountgenerator/business/IdentityAccountHome.java

Rule Violation Line
CommentRequired Header comments are required 43–69
UseUtilityClass All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 44–69
CommentRequired Public method and constructor comments are required 49–55
CommentRequired Public method and constructor comments are required 57–63
CommentRequired Public method and constructor comments are required 65–68

fr/paris/lutece/plugins/accountgenerator/daemon/PurgeExpiratedIdentityAccountsDaemons.java

Rule Violation Line
CommentRequired Header comments are required 44–65
ShortVariable Avoid variables with short names like S 57
ShortVariable Avoid variables with short names like H 58
ShortVariable Avoid variables with short names like M 59

fr/paris/lutece/plugins/accountgenerator/dto/CitiesCodesListResponse.java

Rule Violation Line
CommentRequired Header comments are required 38–62
DataClass The class 'CitiesCodesListResponse' is suspected to be a Data Class (WOC=0.000%, NOPA=0, NOAM=4, WMC=4) 38–62

fr/paris/lutece/plugins/accountgenerator/dto/PurgeExipratedIdentityAccountsResult.java

Rule Violation Line
CommentRequired Header comments are required 36–76
RedundantFieldInitializer Avoid using redundant field initializer for 'nbDeletedAccounts' 38
RedundantFieldInitializer Avoid using redundant field initializer for 'nbDeletedIdentities' 39
CommentRequired Public method and constructor comments are required 41–44
CommentRequired Public method and constructor comments are required 46–49

fr/paris/lutece/plugins/accountgenerator/service/GeocodesCache.java

Rule Violation Line
CommentRequired Header comments are required 53–118
SimpleDateFormatNeedsLocale When instantiating a SimpleDateFormat object, specify a Locale 58
AvoidFieldNameMatchingMethodName Field instance has the same name as a method 62
CommentRequired Public method and constructor comments are required 64–71
NonThreadSafeSingleton Singleton is not thread safe 66–69
CallSuperInConstructor It is a good practice to call super() in a constructor 73–80
CommentRequired Public method and constructor comments are required 82–111
UnsynchronizedStaticFormatter Static Formatter objects should be accessed in a synchronized manner 84
ShortVariable Avoid variables with short names like o 88
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 107

fr/paris/lutece/plugins/accountgenerator/service/IdentityAccountGeneratorService.java

Rule Violation Line
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 34–368
CommentRequired Header comments are required 74–368
AvoidFieldNameMatchingMethodName Field instance has the same name as a method 77
CommentRequired Public method and constructor comments are required 79–86
NonThreadSafeSingleton Singleton is not thread safe 81–84
FieldDeclarationsShouldBeAtStartOfClass Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 89
FieldDeclarationsShouldBeAtStartOfClass Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 90
FieldDeclarationsShouldBeAtStartOfClass Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 91
FieldDeclarationsShouldBeAtStartOfClass Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 94
FieldDeclarationsShouldBeAtStartOfClass Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 95
FieldDeclarationsShouldBeAtStartOfClass Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 96
FieldDeclarationsShouldBeAtStartOfClass Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 97
FieldDeclarationsShouldBeAtStartOfClass Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 100
FieldDeclarationsShouldBeAtStartOfClass Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 101
FieldDeclarationsShouldBeAtStartOfClass Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 102
FieldDeclarationsShouldBeAtStartOfClass Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 103
FieldDeclarationsShouldBeAtStartOfClass Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 104
FieldDeclarationsShouldBeAtStartOfClass Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 105
FieldDeclarationsShouldBeAtStartOfClass Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 106
FieldDeclarationsShouldBeAtStartOfClass Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 107
FieldDeclarationsShouldBeAtStartOfClass Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 108
FieldDeclarationsShouldBeAtStartOfClass Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 109
FieldDeclarationsShouldBeAtStartOfClass Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 110
FieldDeclarationsShouldBeAtStartOfClass Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 111
FieldDeclarationsShouldBeAtStartOfClass Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 112
FieldDeclarationsShouldBeAtStartOfClass Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 113
FieldDeclarationsShouldBeAtStartOfClass Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 116
FieldDeclarationsShouldBeAtStartOfClass Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 117–118
FieldDeclarationsShouldBeAtStartOfClass Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 119
FieldDeclarationsShouldBeAtStartOfClass Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 120
FieldDeclarationsShouldBeAtStartOfClass Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 121
FieldDeclarationsShouldBeAtStartOfClass Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 124
FieldDeclarationsShouldBeAtStartOfClass Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 125
ExcessiveMethodLength Avoid really long methods. 148–264
CyclomaticComplexity The method 'createIdentityAccountBatch(AccountGenerationDto)' has a cyclomatic complexity of 14. 148–264
ConfusingTernary Avoid if (x != y) ..; else ..; 204–247
CommentRequired Public method and constructor comments are required 266–302
CommentRequired Public method and constructor comments are required 333–337
CommentRequired Public method and constructor comments are required 339–342
CommentRequired Public method and constructor comments are required 344–354
ShortVariable Avoid variables with short names like c 358
CommentRequired Public method and constructor comments are required 364–367

fr/paris/lutece/plugins/accountgenerator/service/IdentityAccountPurgeService.java

Rule Violation Line
CommentRequired Header comments are required 55–147
AvoidFieldNameMatchingMethodName Field instance has the same name as a method 58
CommentRequired Public method and constructor comments are required 60–67
NonThreadSafeSingleton Singleton is not thread safe 62–65
FieldDeclarationsShouldBeAtStartOfClass Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 70
FieldDeclarationsShouldBeAtStartOfClass Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 71
FieldDeclarationsShouldBeAtStartOfClass Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 72
FieldDeclarationsShouldBeAtStartOfClass Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 73
FieldDeclarationsShouldBeAtStartOfClass Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 76
FieldDeclarationsShouldBeAtStartOfClass Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 77
FieldDeclarationsShouldBeAtStartOfClass Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 80
FieldDeclarationsShouldBeAtStartOfClass Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 81
CommentRequired Public method and constructor comments are required 95–145
CyclomaticComplexity The method 'purge()' has a cyclomatic complexity of 10. 95–145
ConfusingTernary Avoid if (x != y) ..; else ..; 104–124
AvoidDuplicateLiterals The String literal " : " appears 4 times in this file; the first occurrence is on line 109 109

fr/paris/lutece/plugins/accountgenerator/web/request/AccountGeneratorCreateRequest.java

Rule Violation Line
CommentRequired Header comments are required 49–120
CommentRequired Public method and constructor comments are required 57–62
UncommentedEmptyMethodBody Document empty method body 65–67
UncommentedEmptyMethodBody Document empty method body 78–80
UncommentedEmptyMethodBody Document empty method body 83–85
UncommentedEmptyMethodBody Document empty method body 88–90
UncommentedEmptyMethodBody Document empty method body 93–95

fr/paris/lutece/plugins/accountgenerator/web/rs/AccountGeneratorRestService.java

Rule Violation Line
CommentRequired Header comments are required 52–69
UseObjectForClearerAPI Rather than using a lot of String arguments, consider using a container object for those values. 59–61
CommentRequired Public method and constructor comments are required 59–68

Files

fr/paris/lutece/plugins/accountgenerator/AccountGeneratorPlugin.java

Rule Violation Priority Line
UncommentedEmptyMethodBody Document empty method body 3 50–51

fr/paris/lutece/plugins/accountgenerator/business/IIdentityAccountDao.java

Rule Violation Priority Line
CommentRequired Header comments are required 3 40–49
CommentRequired Public method and constructor comments are required 3 44
CommentRequired Public method and constructor comments are required 3 46
CommentRequired Public method and constructor comments are required 3 48

fr/paris/lutece/plugins/accountgenerator/business/IdentityAccount.java

Rule Violation Priority Line
DataClass The class 'IdentityAccount' is suspected to be a Data Class (WOC=0.000%, NOPA=0, NOAM=8, WMC=8) 3 38–84
CommentRequired Header comments are required 3 38–84
FieldNamingConventions The field name 'guid' doesn't match '_[a-z][a-zA-Z0-9]*' 1 40
FieldNamingConventions The field name 'cuid' doesn't match '_[a-z][a-zA-Z0-9]*' 1 41
FieldNamingConventions The field name 'creationDate' doesn't match '_[a-z][a-zA-Z0-9]*' 1 42
FieldNamingConventions The field name 'expirationDate' doesn't match '_[a-z][a-zA-Z0-9]*' 1 43

fr/paris/lutece/plugins/accountgenerator/business/IdentityAccountDao.java

Rule Violation Priority Line
CommentRequired Header comments are required 3 43–97
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 3 52
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 3 68
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final 3 82

fr/paris/lutece/plugins/accountgenerator/business/IdentityAccountHome.java

Rule Violation Priority Line
CommentRequired Header comments are required 3 43–69
UseUtilityClass All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 3 44–69
FieldNamingConventions The constant name '_dao' doesn't match '[A-Z][A-Z_0-9]*' 1 46
FieldNamingConventions The constant name '_plugin' doesn't match '[A-Z][A-Z_0-9]*' 1 47
CommentRequired Public method and constructor comments are required 3 49–55
CommentRequired Public method and constructor comments are required 3 57–63
CommentRequired Public method and constructor comments are required 3 65–68

fr/paris/lutece/plugins/accountgenerator/daemon/PurgeExpiratedIdentityAccountsDaemons.java

Rule Violation Priority Line
CommentRequired Header comments are required 3 44–65
LocalVariableNamingConventions The local variable name 'S' doesn't match '[a-z][a-zA-Z0-9]*' 1 57
ShortVariable Avoid variables with short names like S 3 57
LocalVariableNamingConventions The local variable name 'H' doesn't match '[a-z][a-zA-Z0-9]*' 1 58
ShortVariable Avoid variables with short names like H 3 58
LocalVariableNamingConventions The local variable name 'M' doesn't match '[a-z][a-zA-Z0-9]*' 1 59
ShortVariable Avoid variables with short names like M 3 59

fr/paris/lutece/plugins/accountgenerator/dto/CitiesCodesListResponse.java

Rule Violation Priority Line
CommentRequired Header comments are required 3 38–62
DataClass The class 'CitiesCodesListResponse' is suspected to be a Data Class (WOC=0.000%, NOPA=0, NOAM=4, WMC=4) 3 38–62
FieldNamingConventions The field name 'result' doesn't match '_[a-z][a-zA-Z0-9]*' 1 40
FieldNamingConventions The field name 'status' doesn't match '_[a-z][a-zA-Z0-9]*' 1 41

fr/paris/lutece/plugins/accountgenerator/dto/PurgeExipratedIdentityAccountsResult.java

Rule Violation Priority Line
CommentRequired Header comments are required 3 36–76
RedundantFieldInitializer Avoid using redundant field initializer for 'nbDeletedAccounts' 3 38
FieldNamingConventions The field name 'nbDeletedAccounts' doesn't match '_[a-z][a-zA-Z0-9]*' 1 38
RedundantFieldInitializer Avoid using redundant field initializer for 'nbDeletedIdentities' 3 39
FieldNamingConventions The field name 'nbDeletedIdentities' doesn't match '_[a-z][a-zA-Z0-9]*' 1 39
CommentRequired Public method and constructor comments are required 3 41–44
CommentRequired Public method and constructor comments are required 3 46–49

fr/paris/lutece/plugins/accountgenerator/service/GeocodesCache.java

Rule Violation Priority Line
ClassWithOnlyPrivateConstructorsShouldBeFinal A class which only has private constructors should be final 1 53–118
CommentRequired Header comments are required 3 53–118
FieldNamingConventions The constant name 'geocodesCitiesCodesEndpoint' doesn't match '[A-Z][A-Z_0-9]*' 1 57
SimpleDateFormatNeedsLocale When instantiating a SimpleDateFormat object, specify a Locale 3 58
FieldNamingConventions The constant name 'citiesCodesDateFormat' doesn't match '[A-Z][A-Z_0-9]*' 1 58
FieldNamingConventions The constant name 'client' doesn't match '[A-Z][A-Z_0-9]*' 1 59
FieldNamingConventions The constant name '_mapper' doesn't match '[A-Z][A-Z_0-9]*' 1 60
AvoidFieldNameMatchingMethodName Field instance has the same name as a method 3 62
FieldNamingConventions The static field name 'instance' doesn't match '_[a-z][a-zA-Z0-9]*' 1 62
CommentRequired Public method and constructor comments are required 3 64–71
NonThreadSafeSingleton Singleton is not thread safe 3 66–69
CallSuperInConstructor It is a good practice to call super() in a constructor 3 73–80
CommentRequired Public method and constructor comments are required 3 82–111
UnsynchronizedStaticFormatter Static Formatter objects should be accessed in a synchronized manner 3 84
ShortVariable Avoid variables with short names like o 3 88
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 107

fr/paris/lutece/plugins/accountgenerator/service/IdentityAccountGeneratorService.java

Rule Violation Priority Line
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 3 34–368
CommentRequired Header comments are required 3 74–368
ClassWithOnlyPrivateConstructorsShouldBeFinal A class which only has private constructors should be final 1 74–368
FieldNamingConventions The static field name 'instance' doesn't match '_[a-z][a-zA-Z0-9]*' 1 77
AvoidFieldNameMatchingMethodName Field instance has the same name as a method 3 77
CommentRequired Public method and constructor comments are required 3 79–86
NonThreadSafeSingleton Singleton is not thread safe 3 81–84
FieldNamingConventions The constant name '_identityService' doesn't match '[A-Z][A-Z_0-9]*' 1 89
FieldDeclarationsShouldBeAtStartOfClass Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 3 89
FieldNamingConventions The constant name '_accountManagementService' doesn't match '[A-Z][A-Z_0-9]*' 1 90
FieldDeclarationsShouldBeAtStartOfClass Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 3 90
FieldNamingConventions The constant name '_geocodesCache' doesn't match '[A-Z][A-Z_0-9]*' 1 91
FieldDeclarationsShouldBeAtStartOfClass Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 3 91
FieldNamingConventions The constant name 'accountManagementClientId' doesn't match '[A-Z][A-Z_0-9]*' 1 94
FieldDeclarationsShouldBeAtStartOfClass Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 3 94
FieldDeclarationsShouldBeAtStartOfClass Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 3 95
FieldNamingConventions The constant name 'accountManagementSecretId' doesn't match '[A-Z][A-Z_0-9]*' 1 95
FieldDeclarationsShouldBeAtStartOfClass Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 3 96
FieldNamingConventions The constant name 'identityStoreClientCode' doesn't match '[A-Z][A-Z_0-9]*' 1 96
FieldNamingConventions The constant name 'identityStoreClientName' doesn't match '[A-Z][A-Z_0-9]*' 1 97
FieldDeclarationsShouldBeAtStartOfClass Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 3 97
FieldNamingConventions The constant name 'commonPassword' doesn't match '[A-Z][A-Z_0-9]*' 1 100
FieldDeclarationsShouldBeAtStartOfClass Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 3 100
FieldDeclarationsShouldBeAtStartOfClass Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 3 101
FieldNamingConventions The constant name 'commonMailSuffix' doesn't match '[A-Z][A-Z_0-9]*' 1 101
FieldDeclarationsShouldBeAtStartOfClass Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 3 102
FieldNamingConventions The constant name 'mailCertifier' doesn't match '[A-Z][A-Z_0-9]*' 1 102
FieldNamingConventions The constant name 'loginCertifier' doesn't match '[A-Z][A-Z_0-9]*' 1 103
FieldDeclarationsShouldBeAtStartOfClass Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 3 103
FieldNamingConventions The constant name 'firstNameCertifier' doesn't match '[A-Z][A-Z_0-9]*' 1 104
FieldDeclarationsShouldBeAtStartOfClass Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 3 104
FieldNamingConventions The constant name 'familyNameCertifier' doesn't match '[A-Z][A-Z_0-9]*' 1 105
FieldDeclarationsShouldBeAtStartOfClass Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 3 105
FieldDeclarationsShouldBeAtStartOfClass Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 3 106
FieldNamingConventions The constant name 'birthplaceCodeCertifier' doesn't match '[A-Z][A-Z_0-9]*' 1 106
FieldDeclarationsShouldBeAtStartOfClass Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 3 107
FieldNamingConventions The constant name 'birthCountryCodeCertifier' doesn't match '[A-Z][A-Z_0-9]*' 1 107
FieldDeclarationsShouldBeAtStartOfClass Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 3 108
FieldNamingConventions The constant name 'birthCountryCodeValue' doesn't match '[A-Z][A-Z_0-9]*' 1 108
FieldDeclarationsShouldBeAtStartOfClass Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 3 109
FieldNamingConventions The constant name 'genderCertifier' doesn't match '[A-Z][A-Z_0-9]*' 1 109
FieldNamingConventions The constant name 'birthdateCertifier' doesn't match '[A-Z][A-Z_0-9]*' 1 110
FieldDeclarationsShouldBeAtStartOfClass Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 3 110
FieldDeclarationsShouldBeAtStartOfClass Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 3 111
FieldNamingConventions The constant name 'birthdateMaxGenerationDay' doesn't match '[A-Z][A-Z_0-9]*' 1 111
FieldNamingConventions The constant name 'birthdateMaxGenerationMonth' doesn't match '[A-Z][A-Z_0-9]*' 1 112
FieldDeclarationsShouldBeAtStartOfClass Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 3 112
FieldNamingConventions The constant name 'birthdateMaxGenerationYear' doesn't match '[A-Z][A-Z_0-9]*' 1 113
FieldDeclarationsShouldBeAtStartOfClass Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 3 113
FieldNamingConventions The constant name 'genders' doesn't match '[A-Z][A-Z_0-9]*' 1 116
FieldDeclarationsShouldBeAtStartOfClass Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 3 116
FieldNamingConventions The constant name 'alphabet' doesn't match '[A-Z][A-Z_0-9]*' 1 117
FieldDeclarationsShouldBeAtStartOfClass Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 3 117–118
FieldDeclarationsShouldBeAtStartOfClass Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 3 119
FieldNamingConventions The constant name 'random' doesn't match '[A-Z][A-Z_0-9]*' 1 119
FieldDeclarationsShouldBeAtStartOfClass Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 3 120
FieldDeclarationsShouldBeAtStartOfClass Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 3 121
FieldNamingConventions The constant name 'dateTimeFormatter' doesn't match '[A-Z][A-Z_0-9]*' 1 121
FieldDeclarationsShouldBeAtStartOfClass Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 3 124
FieldDeclarationsShouldBeAtStartOfClass Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 3 125
ExcessiveMethodLength Avoid really long methods. 3 148–264
CyclomaticComplexity The method 'createIdentityAccountBatch(AccountGenerationDto)' has a cyclomatic complexity of 14. 3 148–264
ConfusingTernary Avoid if (x != y) ..; else ..; 3 204–247
CommentRequired Public method and constructor comments are required 3 266–302
CommentRequired Public method and constructor comments are required 3 333–337
CommentRequired Public method and constructor comments are required 3 339–342
CommentRequired Public method and constructor comments are required 3 344–354
ShortVariable Avoid variables with short names like c 3 358
CommentRequired Public method and constructor comments are required 3 364–367

fr/paris/lutece/plugins/accountgenerator/service/IdentityAccountPurgeService.java

Rule Violation Priority Line
ClassWithOnlyPrivateConstructorsShouldBeFinal A class which only has private constructors should be final 1 55–147
CommentRequired Header comments are required 3 55–147
FieldNamingConventions The static field name 'instance' doesn't match '_[a-z][a-zA-Z0-9]*' 1 58
AvoidFieldNameMatchingMethodName Field instance has the same name as a method 3 58
CommentRequired Public method and constructor comments are required 3 60–67
NonThreadSafeSingleton Singleton is not thread safe 3 62–65
FieldNamingConventions The constant name 'accountManagementClientId' doesn't match '[A-Z][A-Z_0-9]*' 1 70
FieldDeclarationsShouldBeAtStartOfClass Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 3 70
FieldDeclarationsShouldBeAtStartOfClass Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 3 71
FieldNamingConventions The constant name 'accountManagementSecretId' doesn't match '[A-Z][A-Z_0-9]*' 1 71
FieldDeclarationsShouldBeAtStartOfClass Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 3 72
FieldNamingConventions The constant name 'identityStoreClientCode' doesn't match '[A-Z][A-Z_0-9]*' 1 72
FieldNamingConventions The constant name 'identityStoreClientName' doesn't match '[A-Z][A-Z_0-9]*' 1 73
FieldDeclarationsShouldBeAtStartOfClass Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 3 73
FieldNamingConventions The constant name '_identityService' doesn't match '[A-Z][A-Z_0-9]*' 1 76
FieldDeclarationsShouldBeAtStartOfClass Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 3 76
FieldNamingConventions The constant name '_accountManagementService' doesn't match '[A-Z][A-Z_0-9]*' 1 77
FieldDeclarationsShouldBeAtStartOfClass Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 3 77
FieldDeclarationsShouldBeAtStartOfClass Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 3 80
FieldDeclarationsShouldBeAtStartOfClass Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 3 81
CommentRequired Public method and constructor comments are required 3 95–145
CyclomaticComplexity The method 'purge()' has a cyclomatic complexity of 10. 3 95–145
ConfusingTernary Avoid if (x != y) ..; else ..; 3 104–124
GuardLogStatement Logger calls should be surrounded by log level guards. 2 109
AvoidDuplicateLiterals The String literal " : " appears 4 times in this file; the first occurrence is on line 109 3 109
GuardLogStatement Logger calls should be surrounded by log level guards. 2 132

fr/paris/lutece/plugins/accountgenerator/web/request/AccountGeneratorCreateRequest.java

Rule Violation Priority Line
CommentRequired Header comments are required 3 49–120
FieldNamingConventions The constant name 'generationLimit' doesn't match '[A-Z][A-Z_0-9]*' 1 51
FieldNamingConventions The static field name 'JSON_EXAMPLE' doesn't match '_[a-z][a-zA-Z0-9]*' 1 52
FieldNamingConventions The final field name '_accountGenerationRequest' doesn't match '[a-z][a-zA-Z0-9]*' 1 55
CommentRequired Public method and constructor comments are required 3 57–62
UncommentedEmptyMethodBody Document empty method body 3 65–67
UncommentedEmptyMethodBody Document empty method body 3 78–80
UncommentedEmptyMethodBody Document empty method body 3 83–85
UncommentedEmptyMethodBody Document empty method body 3 88–90
UncommentedEmptyMethodBody Document empty method body 3 93–95

fr/paris/lutece/plugins/accountgenerator/web/rs/AccountGeneratorRestService.java

Rule Violation Priority Line
CommentRequired Header comments are required 3 52–69
UseObjectForClearerAPI Rather than using a lot of String arguments, consider using a container object for those values. 3 59–61
CommentRequired Public method and constructor comments are required 3 59–68