Fork me on GitHub

PMD Results

The following document contains the results of PMD 6.13.0.

Violations By Priority

Priority 1

fr/paris/lutece/plugins/actes/web/ActesCreateFormException.java

Rule Violation Line
FieldNamingConventions The final field name '_strErrorKey' doesn't match '[a-z][a-zA-Z0-9]*' 42
FieldNamingConventions The final field name '_args' doesn't match '[a-z][a-zA-Z0-9]*' 43

Priority 2

fr/paris/lutece/plugins/actes/web/ActesJspBean.java

Rule Violation Line
IntegerInstantiation Avoid instantiating Integer objects. Call Integer.valueOf() instead. 265
IntegerInstantiation Avoid instantiating Integer objects. Call Integer.valueOf() instead. 289
IntegerInstantiation Avoid instantiating Integer objects. Call Integer.valueOf() instead. 296

Priority 3

fr/paris/lutece/plugins/actes/business/Acte.java

Rule Violation Line
ShortVariable Avoid variables with short names like sw 68
UnnecessaryLocalBeforeReturn Consider simply returning the value vs storing it in local variable 'strDate' 99
UnnecessaryLocalBeforeReturn Consider simply returning the value vs storing it in local variable 'strDate' 112

fr/paris/lutece/plugins/actes/business/matieres/MatiereDAO.java

Rule Violation Line
MissingOverride The method 'insert(Matiere, Plugin)' is missing an @Override annotation. 61–70
MissingOverride The method 'load(String, Plugin)' is missing an @Override annotation. 78–97
MissingOverride The method 'delete(String, Plugin)' is missing an @Override annotation. 104–110
MissingOverride The method 'store(Matiere, Plugin)' is missing an @Override annotation. 117–127
MissingOverride The method 'selectMatieresList(Plugin)' is missing an @Override annotation. 134–153
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 136
MissingOverride The method 'getMatieresList(Plugin)' is missing an @Override annotation. 160–180

fr/paris/lutece/plugins/actes/business/nature/NatureDAO.java

Rule Violation Line
MissingOverride The method 'insert(Nature, Plugin)' is missing an @Override annotation. 86–98
MissingOverride The method 'load(int, Plugin)' is missing an @Override annotation. 106–126
MissingOverride The method 'delete(int, Plugin)' is missing an @Override annotation. 133–139
MissingOverride The method 'store(Nature, Plugin)' is missing an @Override annotation. 146–157
MissingOverride The method 'selectNaturesList(Plugin)' is missing an @Override annotation. 164–184
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 166
MissingOverride The method 'getNaturesList(Plugin)' is missing an @Override annotation. 191–211

fr/paris/lutece/plugins/actes/business/transaction/TransactionDAO.java

Rule Violation Line
MissingOverride The method 'insert(Transaction, Plugin)' is missing an @Override annotation. 85–102
MissingOverride The method 'load(int, Plugin)' is missing an @Override annotation. 110–135
MissingOverride The method 'delete(int, Plugin)' is missing an @Override annotation. 142–148
MissingOverride The method 'store(Transaction, Plugin)' is missing an @Override annotation. 155–171
MissingOverride The method 'selectTransactionsList(Plugin)' is missing an @Override annotation. 178–203
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 180

fr/paris/lutece/plugins/actes/service/ActesService.java

Rule Violation Line
NonThreadSafeSingleton Singleton is not thread safe 60–64

fr/paris/lutece/plugins/actes/service/ITransmissionService.java

Rule Violation Line
LinguisticNaming Linguistics Antipattern - The getter 'getInfos' should not return void linguistically 59

fr/paris/lutece/plugins/actes/service/TransmissionException.java

Rule Violation Line
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 42–64
ShortVariable Avoid variables with short names like e 59

fr/paris/lutece/plugins/actes/util/ActeNamespacePrefixMapper.java

Rule Violation Line
MissingOverride The method 'getPreferredPrefix(String, String, boolean)' is missing an @Override annotation. 76–89

fr/paris/lutece/plugins/actes/web/ActesCreateFormException.java

Rule Violation Line
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 40–83
CallSuperInConstructor It is a good practice to call super() in a constructor 49–53
CallSuperInConstructor It is a good practice to call super() in a constructor 60–64
MethodReturnsInternalArray Returning '_args' may expose an internal array. 81

fr/paris/lutece/plugins/actes/web/ActesJspBean.java

Rule Violation Line
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 34–468
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 77–468
ImmutableField Private field '_listTempFiles' could be made final; it is only initialized in the declaration or constructor. 107
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 107
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 116
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 116
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 130
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 130
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 151
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 151
PreserveStackTrace New exception is thrown in catch block, original stack trace may be lost 257
ShortVariable Avoid variables with short names like st 278
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 279
UseCollectionIsEmpty Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 286
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 293
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 362
PreserveStackTrace New exception is thrown in catch block, original stack trace may be lost 370
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 402
PreserveStackTrace New exception is thrown in catch block, original stack trace may be lost 410
ShortVariable Avoid variables with short names like e 456

Priority 4

fr/paris/lutece/plugins/actes/business/Acte.java

Rule Violation Line
ShortClassName Avoid short class names like Acte 56–114

fr/paris/lutece/plugins/actes/web/ActesCreateFormException.java

Rule Violation Line
UseVarargs Consider using varargs for methods or constructors which take an array the last parameter. 60

Files

fr/paris/lutece/plugins/actes/business/Acte.java

Rule Violation Priority Line
ShortClassName Avoid short class names like Acte 4 56–114
ShortVariable Avoid variables with short names like sw 3 68
UnnecessaryLocalBeforeReturn Consider simply returning the value vs storing it in local variable 'strDate' 3 99
UnnecessaryLocalBeforeReturn Consider simply returning the value vs storing it in local variable 'strDate' 3 112

fr/paris/lutece/plugins/actes/business/matieres/MatiereDAO.java

Rule Violation Priority Line
MissingOverride The method 'insert(Matiere, Plugin)' is missing an @Override annotation. 3 61–70
MissingOverride The method 'load(String, Plugin)' is missing an @Override annotation. 3 78–97
MissingOverride The method 'delete(String, Plugin)' is missing an @Override annotation. 3 104–110
MissingOverride The method 'store(Matiere, Plugin)' is missing an @Override annotation. 3 117–127
MissingOverride The method 'selectMatieresList(Plugin)' is missing an @Override annotation. 3 134–153
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 136
MissingOverride The method 'getMatieresList(Plugin)' is missing an @Override annotation. 3 160–180

fr/paris/lutece/plugins/actes/business/nature/NatureDAO.java

Rule Violation Priority Line
MissingOverride The method 'insert(Nature, Plugin)' is missing an @Override annotation. 3 86–98
MissingOverride The method 'load(int, Plugin)' is missing an @Override annotation. 3 106–126
MissingOverride The method 'delete(int, Plugin)' is missing an @Override annotation. 3 133–139
MissingOverride The method 'store(Nature, Plugin)' is missing an @Override annotation. 3 146–157
MissingOverride The method 'selectNaturesList(Plugin)' is missing an @Override annotation. 3 164–184
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 166
MissingOverride The method 'getNaturesList(Plugin)' is missing an @Override annotation. 3 191–211

fr/paris/lutece/plugins/actes/business/transaction/TransactionDAO.java

Rule Violation Priority Line
MissingOverride The method 'insert(Transaction, Plugin)' is missing an @Override annotation. 3 85–102
MissingOverride The method 'load(int, Plugin)' is missing an @Override annotation. 3 110–135
MissingOverride The method 'delete(int, Plugin)' is missing an @Override annotation. 3 142–148
MissingOverride The method 'store(Transaction, Plugin)' is missing an @Override annotation. 3 155–171
MissingOverride The method 'selectTransactionsList(Plugin)' is missing an @Override annotation. 3 178–203
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 180

fr/paris/lutece/plugins/actes/service/ActesService.java

Rule Violation Priority Line
NonThreadSafeSingleton Singleton is not thread safe 3 60–64

fr/paris/lutece/plugins/actes/service/ITransmissionService.java

Rule Violation Priority Line
LinguisticNaming Linguistics Antipattern - The getter 'getInfos' should not return void linguistically 3 59

fr/paris/lutece/plugins/actes/service/TransmissionException.java

Rule Violation Priority Line
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 3 42–64
ShortVariable Avoid variables with short names like e 3 59

fr/paris/lutece/plugins/actes/util/ActeNamespacePrefixMapper.java

Rule Violation Priority Line
MissingOverride The method 'getPreferredPrefix(String, String, boolean)' is missing an @Override annotation. 3 76–89

fr/paris/lutece/plugins/actes/web/ActesCreateFormException.java

Rule Violation Priority Line
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 3 40–83
FieldNamingConventions The final field name '_strErrorKey' doesn't match '[a-z][a-zA-Z0-9]*' 1 42
FieldNamingConventions The final field name '_args' doesn't match '[a-z][a-zA-Z0-9]*' 1 43
CallSuperInConstructor It is a good practice to call super() in a constructor 3 49–53
UseVarargs Consider using varargs for methods or constructors which take an array the last parameter. 4 60
CallSuperInConstructor It is a good practice to call super() in a constructor 3 60–64
MethodReturnsInternalArray Returning '_args' may expose an internal array. 3 81

fr/paris/lutece/plugins/actes/web/ActesJspBean.java

Rule Violation Priority Line
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 3 34–468
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 3 77–468
ImmutableField Private field '_listTempFiles' could be made final; it is only initialized in the declaration or constructor. 3 107
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 107
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 116
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 116
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 130
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 130
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 151
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 151
PreserveStackTrace New exception is thrown in catch block, original stack trace may be lost 3 257
IntegerInstantiation Avoid instantiating Integer objects. Call Integer.valueOf() instead. 2 265
ShortVariable Avoid variables with short names like st 3 278
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 279
UseCollectionIsEmpty Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 3 286
IntegerInstantiation Avoid instantiating Integer objects. Call Integer.valueOf() instead. 2 289
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 3 293
IntegerInstantiation Avoid instantiating Integer objects. Call Integer.valueOf() instead. 2 296
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 362
PreserveStackTrace New exception is thrown in catch block, original stack trace may be lost 3 370
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 402
PreserveStackTrace New exception is thrown in catch block, original stack trace may be lost 3 410
ShortVariable Avoid variables with short names like e 3 456