The following document contains the results of PMD 6.13.0.
| Rule | Violation | Line |
|---|---|---|
| FieldNamingConventions | The final field name '_logger' doesn't match '[a-z][a-zA-Z0-9]*' | 60 |
| Rule | Violation | Line |
|---|---|---|
| ClassNamingConventions | The utility class name 'Constants' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' | 39–63 |
| Rule | Violation | Line |
|---|---|---|
| ClassNamingConventions | The utility class name 'AddressServiceProvider' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' | 47–149 |
| Rule | Violation | Line |
|---|---|---|
| AvoidFileStream | Avoid instantiating FileInputStream, FileOutputStream, FileReader, or FileWriter | 407 |
| Rule | Violation | Line |
|---|---|---|
| LoggerIsNotStaticFinal | The Logger variable declaration does not contain the static and final modifiers | 60 |
| Rule | Violation | Line |
|---|---|---|
| MoreThanOneLogger | Class contains more than one logger. | 61–329 |
| Rule | Violation | Line |
|---|---|---|
| TooFewBranchesForASwitchStatement | A switch with less than three branches is inefficient, use a if statement instead. | 79–85 |
| Rule | Violation | Line |
|---|---|---|
| ShortVariable | Avoid variables with short names like ID | 45 |
| Rule | Violation | Line |
|---|---|---|
| ShortVariable | Avoid variables with short names like id | 103 |
| ShortVariable | Avoid variables with short names like id | 135 |
| Rule | Violation | Line |
|---|---|---|
| MissingOverride | The method 'searchAddress(HttpServletRequest, String)' is missing an @Override annotation. | 89–157 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 102 |
| ShortVariable | Avoid variables with short names like jc | 112 |
| ShortVariable | Avoid variables with short names like u | 118 |
| MissingOverride | The method 'searchAddress(HttpServletRequest, String, String)' is missing an @Override annotation. | 169–237 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 182 |
| ShortVariable | Avoid variables with short names like jc | 192 |
| ShortVariable | Avoid variables with short names like u | 198 |
| MissingOverride | The method 'getGeolocalisation(HttpServletRequest, long, String, String, boolean)' is missing an @Override annotation. | 251–320 |
| ShortVariable | Avoid variables with short names like id | 251 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 264 |
| ShortVariable | Avoid variables with short names like jc | 274 |
| ShortVariable | Avoid variables with short names like u | 280 |
| UseIndexOfChar | String.indexOf(char) is faster than String.indexOf(String). | 298 |
| UseIndexOfChar | String.indexOf(char) is faster than String.indexOf(String). | 300 |
| UseIndexOfChar | String.indexOf(char) is faster than String.indexOf(String). | 301 |
| ShortVariable | Avoid variables with short names like id | 332 |
| MissingOverride | The method 'getAdresseInfo(HttpServletRequest, long, boolean)' is missing an @Override annotation. | 332–395 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 345 |
| ShortVariable | Avoid variables with short names like jc | 355 |
| ShortVariable | Avoid variables with short names like u | 361 |
| SignatureDeclareThrowsException | A method/constructor should not explicitly throw java.lang.Exception | 405 |
| ShortVariable | Avoid variables with short names like fc | 409 |
| ShortVariable | Avoid variables with short names like bb | 411 |
| MissingOverride | The method 'getGeolocalisation(HttpServletRequest, String, String, boolean)' is missing an @Override annotation. | 531–534 |
| CommentRequired | Public method and constructor comments are required | 531–534 |
| MissingOverride | The method 'searchAddress(HttpServletRequest, String, String, String)' is missing an @Override annotation. | 540–543 |
| Rule | Violation | Line |
|---|---|---|
| ShortVariable | Avoid variables with short names like id | 102 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getGeolocalisation': the method is declared in an interface type | 117 |
| ShortVariable | Avoid variables with short names like id | 131 |
| Rule | Violation | Line |
|---|---|---|
| UnusedPrivateField | Avoid unused private fields such as 'CONSTANT_KEY_NUM_DISTRICT'. | 73 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 90 |
| UnusedLocalVariable | Avoid unused local variables such as 'list'. | 90 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 94 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 96 |
| ShortVariable | Avoid variables with short names like ha | 96 |
| ShortVariable | Avoid variables with short names like id | 202 |
| ShortVariable | Avoid variables with short names like ha | 230 |
| UselessStringValueOf | No need to call String.valueOf to append to a string. | 232 |
| AvoidDeeplyNestedIfStmts | Deeply nested if..then statements are hard to read | 283–289 |
| MissingOverride | The method 'getAdresseInfo(HttpServletRequest, long, boolean)' is missing an @Override annotation. | 309–315 |
| ShortVariable | Avoid variables with short names like id | 309 |
| UnnecessaryLocalBeforeReturn | Consider simply returning the value vs storing it in local variable 'adresseReturn' | 314 |
| Rule | Violation | Line |
|---|---|---|
| GodClass | Possible God Class (WMC=65, ATFD=69, TCC=5.138%) | 73–844 |
| UseUnderscoresInNumericLiterals | Number 27561 should separate every third digit with an underscore | 88 |
| MissingOverride | The method 'getGeolocalisation(HttpServletRequest, String, String, boolean)' is missing an @Override annotation. | 118–121 |
| MissingOverride | The method 'getGeolocalisation(HttpServletRequest, long, String, String, boolean)' is missing an @Override annotation. | 135–183 |
| ShortVariable | Avoid variables with short names like id | 135 |
| ShortVariable | Avoid variables with short names like id | 197 |
| MissingOverride | The method 'getAdresseInfo(HttpServletRequest, long, boolean)' is missing an @Override annotation. | 197–291 |
| ShortVariable | Avoid variables with short names like jc | 241 |
| ShortVariable | Avoid variables with short names like u | 247 |
| MissingOverride | The method 'searchAddress(HttpServletRequest, String)' is missing an @Override annotation. | 303–425 |
| NPathComplexity | The method 'searchAddress(HttpServletRequest, String)' has an NPath complexity of 270 | 303–425 |
| ExcessiveMethodLength | Avoid really long methods. | 303–425 |
| CyclomaticComplexity | The method 'searchAddress(HttpServletRequest, String)' has a cyclomatic complexity of 14. | 303–425 |
| ShortVariable | Avoid variables with short names like jc | 353 |
| ShortVariable | Avoid variables with short names like u | 359 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 381 |
| MissingOverride | The method 'searchAddress(HttpServletRequest, String, String)' is missing an @Override annotation. | 440–443 |
| ExcessiveMethodLength | Avoid really long methods. | 459–601 |
| NcssCount | The method 'searchAddress(HttpServletRequest, String, String, String)' has a NCSS line count of 63. | 459–601 |
| NPathComplexity | The method 'searchAddress(HttpServletRequest, String, String, String)' has an NPath complexity of 1026 | 459–601 |
| MissingOverride | The method 'searchAddress(HttpServletRequest, String, String, String)' is missing an @Override annotation. | 459–601 |
| CyclomaticComplexity | The method 'searchAddress(HttpServletRequest, String, String, String)' has a cyclomatic complexity of 17. | 459–601 |
| ShortVariable | Avoid variables with short names like jc | 509 |
| ShortVariable | Avoid variables with short names like u | 515 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 537 |
| UseIndexOfChar | String.indexOf(char) is faster than String.indexOf(String). | 569 |
| AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 570 |
| UseIndexOfChar | String.indexOf(char) is faster than String.indexOf(String). | 573 |
| CollapsibleIfStatements | These nested if statements could be combined | 590–593 |
| UseLocaleWithCaseConversions | When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 745 |
| UseLocaleWithCaseConversions | When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 761 |
| UseLocaleWithCaseConversions | When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 776 |
| ImmutableField | Private field '_idAdresse' could be made final; it is only initialized in the declaration or constructor. | 785 |
| ImmutableField | Private field '_labelAdresse' could be made final; it is only initialized in the declaration or constructor. | 786 |
| MissingOverride | The method 'hashCode()' is missing an @Override annotation. | 827–830 |
| ShortVariable | Avoid variables with short names like o | 837 |
| MissingOverride | The method 'equals(Object)' is missing an @Override annotation. | 837–842 |
| Rule | Violation | Line |
|---|---|---|
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 217 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 233 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 234 |
| Rule | Violation | Line |
|---|---|---|
| UnusedImports | Avoid unused imports such as 'javassist.bytecode.stackmap.BasicBlock' | 52 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| FieldNamingConventions | The final field name '_logger' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 60 |
| LoggerIsNotStaticFinal | The Logger variable declaration does not contain the static and final modifiers | 2 | 60 |
| TooFewBranchesForASwitchStatement | A switch with less than three branches is inefficient, use a if statement instead. | 3 | 79–85 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ClassNamingConventions | The utility class name 'Constants' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' | 1 | 39–63 |
| ShortVariable | Avoid variables with short names like ID | 3 | 45 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ClassNamingConventions | The utility class name 'AddressServiceProvider' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' | 1 | 47–149 |
| ShortVariable | Avoid variables with short names like id | 3 | 103 |
| ShortVariable | Avoid variables with short names like id | 3 | 135 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| MissingOverride | The method 'searchAddress(HttpServletRequest, String)' is missing an @Override annotation. | 3 | 89–157 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 102 |
| ShortVariable | Avoid variables with short names like jc | 3 | 112 |
| ShortVariable | Avoid variables with short names like u | 3 | 118 |
| MissingOverride | The method 'searchAddress(HttpServletRequest, String, String)' is missing an @Override annotation. | 3 | 169–237 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 182 |
| ShortVariable | Avoid variables with short names like jc | 3 | 192 |
| ShortVariable | Avoid variables with short names like u | 3 | 198 |
| MissingOverride | The method 'getGeolocalisation(HttpServletRequest, long, String, String, boolean)' is missing an @Override annotation. | 3 | 251–320 |
| ShortVariable | Avoid variables with short names like id | 3 | 251 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 264 |
| ShortVariable | Avoid variables with short names like jc | 3 | 274 |
| ShortVariable | Avoid variables with short names like u | 3 | 280 |
| UseIndexOfChar | String.indexOf(char) is faster than String.indexOf(String). | 3 | 298 |
| UseIndexOfChar | String.indexOf(char) is faster than String.indexOf(String). | 3 | 300 |
| UseIndexOfChar | String.indexOf(char) is faster than String.indexOf(String). | 3 | 301 |
| ShortVariable | Avoid variables with short names like id | 3 | 332 |
| MissingOverride | The method 'getAdresseInfo(HttpServletRequest, long, boolean)' is missing an @Override annotation. | 3 | 332–395 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 345 |
| ShortVariable | Avoid variables with short names like jc | 3 | 355 |
| ShortVariable | Avoid variables with short names like u | 3 | 361 |
| SignatureDeclareThrowsException | A method/constructor should not explicitly throw java.lang.Exception | 3 | 405 |
| AvoidFileStream | Avoid instantiating FileInputStream, FileOutputStream, FileReader, or FileWriter | 1 | 407 |
| ShortVariable | Avoid variables with short names like fc | 3 | 409 |
| ShortVariable | Avoid variables with short names like bb | 3 | 411 |
| MissingOverride | The method 'getGeolocalisation(HttpServletRequest, String, String, boolean)' is missing an @Override annotation. | 3 | 531–534 |
| CommentRequired | Public method and constructor comments are required | 3 | 531–534 |
| MissingOverride | The method 'searchAddress(HttpServletRequest, String, String, String)' is missing an @Override annotation. | 3 | 540–543 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ShortVariable | Avoid variables with short names like id | 3 | 102 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getGeolocalisation': the method is declared in an interface type | 3 | 117 |
| ShortVariable | Avoid variables with short names like id | 3 | 131 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnusedImports | Avoid unused imports such as 'javassist.bytecode.stackmap.BasicBlock' | 4 | 52 |
| MoreThanOneLogger | Class contains more than one logger. | 2 | 61–329 |
| UnusedPrivateField | Avoid unused private fields such as 'CONSTANT_KEY_NUM_DISTRICT'. | 3 | 73 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 90 |
| UnusedLocalVariable | Avoid unused local variables such as 'list'. | 3 | 90 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 94 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 96 |
| ShortVariable | Avoid variables with short names like ha | 3 | 96 |
| ShortVariable | Avoid variables with short names like id | 3 | 202 |
| ShortVariable | Avoid variables with short names like ha | 3 | 230 |
| UselessStringValueOf | No need to call String.valueOf to append to a string. | 3 | 232 |
| AvoidDeeplyNestedIfStmts | Deeply nested if..then statements are hard to read | 3 | 283–289 |
| MissingOverride | The method 'getAdresseInfo(HttpServletRequest, long, boolean)' is missing an @Override annotation. | 3 | 309–315 |
| ShortVariable | Avoid variables with short names like id | 3 | 309 |
| UnnecessaryLocalBeforeReturn | Consider simply returning the value vs storing it in local variable 'adresseReturn' | 3 | 314 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| GodClass | Possible God Class (WMC=65, ATFD=69, TCC=5.138%) | 3 | 73–844 |
| UseUnderscoresInNumericLiterals | Number 27561 should separate every third digit with an underscore | 3 | 88 |
| MissingOverride | The method 'getGeolocalisation(HttpServletRequest, String, String, boolean)' is missing an @Override annotation. | 3 | 118–121 |
| MissingOverride | The method 'getGeolocalisation(HttpServletRequest, long, String, String, boolean)' is missing an @Override annotation. | 3 | 135–183 |
| ShortVariable | Avoid variables with short names like id | 3 | 135 |
| ShortVariable | Avoid variables with short names like id | 3 | 197 |
| MissingOverride | The method 'getAdresseInfo(HttpServletRequest, long, boolean)' is missing an @Override annotation. | 3 | 197–291 |
| ShortVariable | Avoid variables with short names like jc | 3 | 241 |
| ShortVariable | Avoid variables with short names like u | 3 | 247 |
| MissingOverride | The method 'searchAddress(HttpServletRequest, String)' is missing an @Override annotation. | 3 | 303–425 |
| NPathComplexity | The method 'searchAddress(HttpServletRequest, String)' has an NPath complexity of 270 | 3 | 303–425 |
| ExcessiveMethodLength | Avoid really long methods. | 3 | 303–425 |
| CyclomaticComplexity | The method 'searchAddress(HttpServletRequest, String)' has a cyclomatic complexity of 14. | 3 | 303–425 |
| ShortVariable | Avoid variables with short names like jc | 3 | 353 |
| ShortVariable | Avoid variables with short names like u | 3 | 359 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 381 |
| MissingOverride | The method 'searchAddress(HttpServletRequest, String, String)' is missing an @Override annotation. | 3 | 440–443 |
| ExcessiveMethodLength | Avoid really long methods. | 3 | 459–601 |
| NcssCount | The method 'searchAddress(HttpServletRequest, String, String, String)' has a NCSS line count of 63. | 3 | 459–601 |
| NPathComplexity | The method 'searchAddress(HttpServletRequest, String, String, String)' has an NPath complexity of 1026 | 3 | 459–601 |
| MissingOverride | The method 'searchAddress(HttpServletRequest, String, String, String)' is missing an @Override annotation. | 3 | 459–601 |
| CyclomaticComplexity | The method 'searchAddress(HttpServletRequest, String, String, String)' has a cyclomatic complexity of 17. | 3 | 459–601 |
| ShortVariable | Avoid variables with short names like jc | 3 | 509 |
| ShortVariable | Avoid variables with short names like u | 3 | 515 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 537 |
| UseIndexOfChar | String.indexOf(char) is faster than String.indexOf(String). | 3 | 569 |
| AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 3 | 570 |
| UseIndexOfChar | String.indexOf(char) is faster than String.indexOf(String). | 3 | 573 |
| CollapsibleIfStatements | These nested if statements could be combined | 3 | 590–593 |
| UseLocaleWithCaseConversions | When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 3 | 745 |
| UseLocaleWithCaseConversions | When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 3 | 761 |
| UseLocaleWithCaseConversions | When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 3 | 776 |
| ImmutableField | Private field '_idAdresse' could be made final; it is only initialized in the declaration or constructor. | 3 | 785 |
| ImmutableField | Private field '_labelAdresse' could be made final; it is only initialized in the declaration or constructor. | 3 | 786 |
| MissingOverride | The method 'hashCode()' is missing an @Override annotation. | 3 | 827–830 |
| ShortVariable | Avoid variables with short names like o | 3 | 837 |
| MissingOverride | The method 'equals(Object)' is missing an @Override annotation. | 3 | 837–842 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 3 | 217 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 3 | 233 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 3 | 234 |
