Fork me on GitHub

Résultats PMD

Le document suivant contient les résultats de PMD 6.13.0.

Violations By Priority

Priority 1

fr/paris/lutece/plugins/adminauthenticationwsso/service/AutoExportWssoAdminUsersFile.java

Rule Violation Ligne
ClassNamingConventions The utility class name 'AutoExportWssoAdminUsersFile' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' 4366

fr/paris/lutece/plugins/adminauthenticationwsso/service/WssoAdminUserImportService.java

Rule Violation Ligne
FieldNamingConventions The constant name '_attributeService' doesn't match '[A-Z][A-Z_0-9]*' 92

fr/paris/lutece/plugins/adminauthenticationwsso/service/WssoAdminUsersFileGeneratorService.java

Rule Violation Ligne
AvoidFileStream Avoid instantiating FileInputStream, FileOutputStream, FileReader, or FileWriter 191

Priority 2

fr/paris/lutece/plugins/adminauthenticationwsso/AdminWssoAuthentication.java

Rule Violation Ligne
GuardLogStatement Logger calls should be surrounded by log level guards. 344346
GuardLogStatement Logger calls should be surrounded by log level guards. 409411
GuardLogStatement Logger calls should be surrounded by log level guards. 477
GuardLogStatement Logger calls should be surrounded by log level guards. 496497

fr/paris/lutece/plugins/adminauthenticationwsso/util/WssoLdapUtil.java

Rule Violation Ligne
GuardLogStatement Logger calls should be surrounded by log level guards. 111
GuardLogStatement Logger calls should be surrounded by log level guards. 175178

Priority 3

fr/paris/lutece/plugins/adminauthenticationwsso/AdminWssoAuthentication.java

Rule Violation Ligne
GodClass Possible God Class (WMC=55, ATFD=51, TCC=0.265%) 67598
MissingOverride The method 'compare(AdminWssoUser, AdminWssoUser)' is missing an @Override annotation. 103118
CommentRequired Public method and constructor comments are required 103118
UseLocaleWithCaseConversions When doing a String.toLowerCase()/toUpperCase() call, use a Locale 105
UseLocaleWithCaseConversions When doing a String.toLowerCase()/toUpperCase() call, use a Locale 105
UseLocaleWithCaseConversions When doing a String.toLowerCase()/toUpperCase() call, use a Locale 109
UseLocaleWithCaseConversions When doing a String.toLowerCase()/toUpperCase() call, use a Locale 109
UseLocaleWithCaseConversions When doing a String.toLowerCase()/toUpperCase() call, use a Locale 113
UseLocaleWithCaseConversions When doing a String.toLowerCase()/toUpperCase() call, use a Locale 113
UnnecessaryConstructor Avoid unnecessary constructors - the compiler will generate these for you 129132
CommentRequired Public method and constructor comments are required 137140
MissingOverride The method 'getAuthServiceName()' is missing an @Override annotation. 137140
CommentRequired Public method and constructor comments are required 145161
MissingOverride The method 'getAuthType(HttpServletRequest)' is missing an @Override annotation. 145161
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 150158
MissingOverride The method 'login(String, String, HttpServletRequest)' is missing an @Override annotation. 166171
MissingOverride The method 'logout(AdminUser)' is missing an @Override annotation. 176179
CommentRequired Public method and constructor comments are required 176179
CommentRequired Public method and constructor comments are required 184188
MissingOverride The method 'getAnonymousUser()' is missing an @Override annotation. 184188
MissingOverride The method 'isExternalAuthentication()' is missing an @Override annotation. 194197
CommentRequired Public method and constructor comments are required 202242
MissingOverride The method 'getHttpAuthenticatedUser(HttpServletRequest)' is missing an @Override annotation. 202242
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 211231
CommentRequired Public method and constructor comments are required 247250
MissingOverride The method 'getLoginPageUrl()' is missing an @Override annotation. 247250
MissingOverride The method 'getChangePasswordPageUrl()' is missing an @Override annotation. 255258
CommentRequired Public method and constructor comments are required 255258
MissingOverride The method 'getDoLoginUrl()' is missing an @Override annotation. 263267
CommentRequired Public method and constructor comments are required 263267
CommentRequired Public method and constructor comments are required 272276
MissingOverride The method 'getDoLogoutUrl()' is missing an @Override annotation. 272276
MissingOverride The method 'getNewAccountPageUrl()' is missing an @Override annotation. 281285
CommentRequired Public method and constructor comments are required 281285
CommentRequired Public method and constructor comments are required 290294
MissingOverride The method 'getViewAccountPageUrl()' is missing an @Override annotation. 290294
MissingOverride The method 'getLostPasswordPageUrl()' is missing an @Override annotation. 299303
CommentRequired Public method and constructor comments are required 299303
MissingOverride The method 'getLostLoginPageUrl()' is missing an @Override annotation. 308312
CommentRequired Public method and constructor comments are required 308312
MissingOverride The method 'getUserList(String, String, String)' is missing an @Override annotation. 317448
NcssCount The method 'getUserList(String, String, String)' has a NCSS line count of 60. 317448
CommentRequired Public method and constructor comments are required 317448
CyclomaticComplexity The method 'getUserList(String, String, String)' has a cyclomatic complexity of 10. 317448
ExcessiveMethodLength Avoid really long methods. 317448
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 319
ShortVariable Avoid variables with short names like sr 320
ConfusingTernary Avoid if (x != y) ..; else ..; 358366
AvoidDuplicateLiterals The String literal "Error while searching for users '" appears 6 times in this file; the first occurrence is on line 364 364
AvoidDuplicateLiterals The String literal "' with search filter : " appears 6 times in this file; the first occurrence is on line 365 365
ConfusingTernary Avoid if (x != y) ..; else ..; 372380
ConfusingTernary Avoid if (x != y) ..; else ..; 386394
ConfusingTernary Avoid if (x != y) ..; else ..; 400417
EmptyCatchBlock Avoid empty catch blocks 443446
CommentRequired Public method and constructor comments are required 453534
MissingOverride The method 'getUserPublicData(String)' is missing an @Override annotation. 453534
ShortVariable Avoid variables with short names like sr 456
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 501
EmptyCatchBlock Avoid empty catch blocks 529532
ShortVariable Avoid variables with short names like in 536
InsufficientStringBufferDeclaration StringBuffer constructor is initialized with size 16, but has at least 26 characters appended. 543
ShortVariable Avoid variables with short names like sb 543
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 544
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 545
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 546
PositionLiteralsFirstInCaseInsensitiveComparisons Position literals first in String comparisons for EqualsIgnoreCase 581

fr/paris/lutece/plugins/adminauthenticationwsso/AdminWssoUser.java

Rule Violation Ligne
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 4353

fr/paris/lutece/plugins/adminauthenticationwsso/service/AutoExportWssoAdminUsersFile.java

Rule Violation Ligne
UseUtilityClass All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 4466
UnnecessaryConstructor Avoid unnecessary constructors - the compiler will generate these for you 5153
UncommentedEmptyConstructor Document empty constructor 5153
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 6065

fr/paris/lutece/plugins/adminauthenticationwsso/service/WssoAdminUserImportService.java

Rule Violation Ligne
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 34453
CommentRequired Header comments are required 71453
CyclomaticComplexity The method 'readLineOfCSVFile(String, int, Locale, String)' has a cyclomatic complexity of 37. 98416
NPathComplexity The method 'readLineOfCSVFile(String, int, Locale, String)' has an NPath complexity of 1814760 98416
NcssCount The method 'readLineOfCSVFile(String, int, Locale, String)' has a NCSS line count of 163. 98416
ExcessiveMethodLength Avoid really long methods. 98416
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 100
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 106
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 185
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 216
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 266
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 266
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 267
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 268
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 269
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 305
UseCollectionIsEmpty Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 345
AvoidReassigningLoopVariables Avoid reassigning the loop control variable 'strValue' 368
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 401

fr/paris/lutece/plugins/adminauthenticationwsso/service/WssoAdminUsersFileGeneratorService.java

Rule Violation Ligne
UseUtilityClass All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 62231
UnnecessaryConstructor Avoid unnecessary constructors - the compiler will generate these for you 9294
UncommentedEmptyConstructor Document empty constructor 9294
SimpleDateFormatNeedsLocale When instantiating a SimpleDateFormat object, specify a Locale 126
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 206
IdenticalCatchBranches 'catch' branch identical to 'IOException' branch 206210
AvoidCatchingNPE Avoid catching NullPointerException; consider removing the cause of the NPE. 206

fr/paris/lutece/plugins/adminauthenticationwsso/service/daemon/ExportWssoAdminUsersDaemon.java

Rule Violation Ligne
CallSuperInConstructor It is a good practice to call super() in a constructor 5153
UncommentedEmptyConstructor Document empty constructor 5153
UnnecessaryConstructor Avoid unnecessary constructors - the compiler will generate these for you 5153
MissingOverride The method 'run()' is missing an @Override annotation. 5863

fr/paris/lutece/plugins/adminauthenticationwsso/util/WssoLdapUtil.java

Rule Violation Ligne
CommentRequired Header comments are required 54253
UseUtilityClass All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 55253
CommentRequired Public method and constructor comments are required 7587
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 82
CommentRequired Public method and constructor comments are required 89198
ExcessiveMethodLength Avoid really long methods. 89198
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 91
ShortVariable Avoid variables with short names like sr 92
AddEmptyString Do not add empty strings 96
AddEmptyString Do not add empty strings 97
ConfusingTernary Avoid if (x != y) ..; else ..; 123131
AvoidDuplicateLiterals The String literal "Error while searching for users '" appears 5 times in this file; the first occurrence is on line 129 129
AvoidDuplicateLiterals The String literal "' with search filter : " appears 5 times in this file; the first occurrence is on line 130 130
ConfusingTernary Avoid if (x != y) ..; else ..; 137145
ConfusingTernary Avoid if (x != y) ..; else ..; 151159
ConfusingTernary Avoid if (x != y) ..; else ..; 165184
ShortVariable Avoid variables with short names like in 201
CommentRequired Public method and constructor comments are required 201204
CommentRequired Public method and constructor comments are required 206209
CommentRequired Public method and constructor comments are required 211214
CommentRequired Public method and constructor comments are required 216219
CommentRequired Public method and constructor comments are required 221224
CommentRequired Public method and constructor comments are required 226229
CommentRequired Public method and constructor comments are required 231241
PositionLiteralsFirstInCaseInsensitiveComparisons Position literals first in String comparisons for EqualsIgnoreCase 235
CommentRequired Public method and constructor comments are required 243246
CommentRequired Public method and constructor comments are required 248251

fr/paris/lutece/plugins/adminauthenticationwsso/web/WSSOAuthenticationJspBean.java

Rule Violation Ligne
CommentRequired Header comments are required 4048
CommentRequired Public method and constructor comments are required 4447

Priority 4

fr/paris/lutece/plugins/adminauthenticationwsso/AdminWssoAuthentication.java

Rule Violation Ligne
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.lang.UnsupportedOperationException' due to existing implicit import 'java.lang.*' 186

Fichiers

fr/paris/lutece/plugins/adminauthenticationwsso/AdminWssoAuthentication.java

Rule Violation Priority Ligne
GodClass Possible God Class (WMC=55, ATFD=51, TCC=0.265%) 3 67598
MissingOverride The method 'compare(AdminWssoUser, AdminWssoUser)' is missing an @Override annotation. 3 103118
CommentRequired Public method and constructor comments are required 3 103118
UseLocaleWithCaseConversions When doing a String.toLowerCase()/toUpperCase() call, use a Locale 3 105
UseLocaleWithCaseConversions When doing a String.toLowerCase()/toUpperCase() call, use a Locale 3 105
UseLocaleWithCaseConversions When doing a String.toLowerCase()/toUpperCase() call, use a Locale 3 109
UseLocaleWithCaseConversions When doing a String.toLowerCase()/toUpperCase() call, use a Locale 3 109
UseLocaleWithCaseConversions When doing a String.toLowerCase()/toUpperCase() call, use a Locale 3 113
UseLocaleWithCaseConversions When doing a String.toLowerCase()/toUpperCase() call, use a Locale 3 113
UnnecessaryConstructor Avoid unnecessary constructors - the compiler will generate these for you 3 129132
CommentRequired Public method and constructor comments are required 3 137140
MissingOverride The method 'getAuthServiceName()' is missing an @Override annotation. 3 137140
CommentRequired Public method and constructor comments are required 3 145161
MissingOverride The method 'getAuthType(HttpServletRequest)' is missing an @Override annotation. 3 145161
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 3 150158
MissingOverride The method 'login(String, String, HttpServletRequest)' is missing an @Override annotation. 3 166171
MissingOverride The method 'logout(AdminUser)' is missing an @Override annotation. 3 176179
CommentRequired Public method and constructor comments are required 3 176179
CommentRequired Public method and constructor comments are required 3 184188
MissingOverride The method 'getAnonymousUser()' is missing an @Override annotation. 3 184188
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.lang.UnsupportedOperationException' due to existing implicit import 'java.lang.*' 4 186
MissingOverride The method 'isExternalAuthentication()' is missing an @Override annotation. 3 194197
CommentRequired Public method and constructor comments are required 3 202242
MissingOverride The method 'getHttpAuthenticatedUser(HttpServletRequest)' is missing an @Override annotation. 3 202242
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 3 211231
CommentRequired Public method and constructor comments are required 3 247250
MissingOverride The method 'getLoginPageUrl()' is missing an @Override annotation. 3 247250
MissingOverride The method 'getChangePasswordPageUrl()' is missing an @Override annotation. 3 255258
CommentRequired Public method and constructor comments are required 3 255258
MissingOverride The method 'getDoLoginUrl()' is missing an @Override annotation. 3 263267
CommentRequired Public method and constructor comments are required 3 263267
CommentRequired Public method and constructor comments are required 3 272276
MissingOverride The method 'getDoLogoutUrl()' is missing an @Override annotation. 3 272276
MissingOverride The method 'getNewAccountPageUrl()' is missing an @Override annotation. 3 281285
CommentRequired Public method and constructor comments are required 3 281285
CommentRequired Public method and constructor comments are required 3 290294
MissingOverride The method 'getViewAccountPageUrl()' is missing an @Override annotation. 3 290294
MissingOverride The method 'getLostPasswordPageUrl()' is missing an @Override annotation. 3 299303
CommentRequired Public method and constructor comments are required 3 299303
MissingOverride The method 'getLostLoginPageUrl()' is missing an @Override annotation. 3 308312
CommentRequired Public method and constructor comments are required 3 308312
MissingOverride The method 'getUserList(String, String, String)' is missing an @Override annotation. 3 317448
NcssCount The method 'getUserList(String, String, String)' has a NCSS line count of 60. 3 317448
CommentRequired Public method and constructor comments are required 3 317448
CyclomaticComplexity The method 'getUserList(String, String, String)' has a cyclomatic complexity of 10. 3 317448
ExcessiveMethodLength Avoid really long methods. 3 317448
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 319
ShortVariable Avoid variables with short names like sr 3 320
GuardLogStatement Logger calls should be surrounded by log level guards. 2 344346
ConfusingTernary Avoid if (x != y) ..; else ..; 3 358366
AvoidDuplicateLiterals The String literal "Error while searching for users '" appears 6 times in this file; the first occurrence is on line 364 3 364
AvoidDuplicateLiterals The String literal "' with search filter : " appears 6 times in this file; the first occurrence is on line 365 3 365
ConfusingTernary Avoid if (x != y) ..; else ..; 3 372380
ConfusingTernary Avoid if (x != y) ..; else ..; 3 386394
ConfusingTernary Avoid if (x != y) ..; else ..; 3 400417
GuardLogStatement Logger calls should be surrounded by log level guards. 2 409411
EmptyCatchBlock Avoid empty catch blocks 3 443446
CommentRequired Public method and constructor comments are required 3 453534
MissingOverride The method 'getUserPublicData(String)' is missing an @Override annotation. 3 453534
ShortVariable Avoid variables with short names like sr 3 456
GuardLogStatement Logger calls should be surrounded by log level guards. 2 477
GuardLogStatement Logger calls should be surrounded by log level guards. 2 496497
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 3 501
EmptyCatchBlock Avoid empty catch blocks 3 529532
ShortVariable Avoid variables with short names like in 3 536
InsufficientStringBufferDeclaration StringBuffer constructor is initialized with size 16, but has at least 26 characters appended. 3 543
ShortVariable Avoid variables with short names like sb 3 543
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 544
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 545
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 546
PositionLiteralsFirstInCaseInsensitiveComparisons Position literals first in String comparisons for EqualsIgnoreCase 3 581

fr/paris/lutece/plugins/adminauthenticationwsso/AdminWssoUser.java

Rule Violation Priority Ligne
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 3 4353

fr/paris/lutece/plugins/adminauthenticationwsso/service/AutoExportWssoAdminUsersFile.java

Rule Violation Priority Ligne
ClassNamingConventions The utility class name 'AutoExportWssoAdminUsersFile' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' 1 4366
UseUtilityClass All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 3 4466
UnnecessaryConstructor Avoid unnecessary constructors - the compiler will generate these for you 3 5153
UncommentedEmptyConstructor Document empty constructor 3 5153
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 3 6065

fr/paris/lutece/plugins/adminauthenticationwsso/service/WssoAdminUserImportService.java

Rule Violation Priority Ligne
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 3 34453
CommentRequired Header comments are required 3 71453
FieldNamingConventions The constant name '_attributeService' doesn't match '[A-Z][A-Z_0-9]*' 1 92
CyclomaticComplexity The method 'readLineOfCSVFile(String, int, Locale, String)' has a cyclomatic complexity of 37. 3 98416
NPathComplexity The method 'readLineOfCSVFile(String, int, Locale, String)' has an NPath complexity of 1814760 3 98416
NcssCount The method 'readLineOfCSVFile(String, int, Locale, String)' has a NCSS line count of 163. 3 98416
ExcessiveMethodLength Avoid really long methods. 3 98416
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 3 100
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 106
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 185
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 3 216
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 266
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 266
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 267
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 268
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 269
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 305
UseCollectionIsEmpty Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 3 345
AvoidReassigningLoopVariables Avoid reassigning the loop control variable 'strValue' 3 368
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 401

fr/paris/lutece/plugins/adminauthenticationwsso/service/WssoAdminUsersFileGeneratorService.java

Rule Violation Priority Ligne
UseUtilityClass All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 3 62231
UnnecessaryConstructor Avoid unnecessary constructors - the compiler will generate these for you 3 9294
UncommentedEmptyConstructor Document empty constructor 3 9294
SimpleDateFormatNeedsLocale When instantiating a SimpleDateFormat object, specify a Locale 3 126
AvoidFileStream Avoid instantiating FileInputStream, FileOutputStream, FileReader, or FileWriter 1 191
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 206
IdenticalCatchBranches 'catch' branch identical to 'IOException' branch 3 206210
AvoidCatchingNPE Avoid catching NullPointerException; consider removing the cause of the NPE. 3 206

fr/paris/lutece/plugins/adminauthenticationwsso/service/daemon/ExportWssoAdminUsersDaemon.java

Rule Violation Priority Ligne
CallSuperInConstructor It is a good practice to call super() in a constructor 3 5153
UncommentedEmptyConstructor Document empty constructor 3 5153
UnnecessaryConstructor Avoid unnecessary constructors - the compiler will generate these for you 3 5153
MissingOverride The method 'run()' is missing an @Override annotation. 3 5863

fr/paris/lutece/plugins/adminauthenticationwsso/util/WssoLdapUtil.java

Rule Violation Priority Ligne
CommentRequired Header comments are required 3 54253
UseUtilityClass All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 3 55253
CommentRequired Public method and constructor comments are required 3 7587
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 82
CommentRequired Public method and constructor comments are required 3 89198
ExcessiveMethodLength Avoid really long methods. 3 89198
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 91
ShortVariable Avoid variables with short names like sr 3 92
AddEmptyString Do not add empty strings 3 96
AddEmptyString Do not add empty strings 3 97
GuardLogStatement Logger calls should be surrounded by log level guards. 2 111
ConfusingTernary Avoid if (x != y) ..; else ..; 3 123131
AvoidDuplicateLiterals The String literal "Error while searching for users '" appears 5 times in this file; the first occurrence is on line 129 3 129
AvoidDuplicateLiterals The String literal "' with search filter : " appears 5 times in this file; the first occurrence is on line 130 3 130
ConfusingTernary Avoid if (x != y) ..; else ..; 3 137145
ConfusingTernary Avoid if (x != y) ..; else ..; 3 151159
ConfusingTernary Avoid if (x != y) ..; else ..; 3 165184
GuardLogStatement Logger calls should be surrounded by log level guards. 2 175178
ShortVariable Avoid variables with short names like in 3 201
CommentRequired Public method and constructor comments are required 3 201204
CommentRequired Public method and constructor comments are required 3 206209
CommentRequired Public method and constructor comments are required 3 211214
CommentRequired Public method and constructor comments are required 3 216219
CommentRequired Public method and constructor comments are required 3 221224
CommentRequired Public method and constructor comments are required 3 226229
CommentRequired Public method and constructor comments are required 3 231241
PositionLiteralsFirstInCaseInsensitiveComparisons Position literals first in String comparisons for EqualsIgnoreCase 3 235
CommentRequired Public method and constructor comments are required 3 243246
CommentRequired Public method and constructor comments are required 3 248251

fr/paris/lutece/plugins/adminauthenticationwsso/web/WSSOAuthenticationJspBean.java

Rule Violation Priority Ligne
CommentRequired Header comments are required 3 4048
CommentRequired Public method and constructor comments are required 3 4447