Fork me on GitHub

PMD Results

The following document contains the results of PMD 6.13.0.

Violations By Priority

Priority 1

fr/paris/lutece/plugins/adminauthenticationwsso/service/AutoExportWssoAdminUsersFile.java

Rule Violation Line
ClassNamingConventions The utility class name 'AutoExportWssoAdminUsersFile' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' 43–66

fr/paris/lutece/plugins/adminauthenticationwsso/service/WssoAdminUserImportService.java

Rule Violation Line
FieldNamingConventions The constant name '_attributeService' doesn't match '[A-Z][A-Z_0-9]*' 92

fr/paris/lutece/plugins/adminauthenticationwsso/service/WssoAdminUsersFileGeneratorService.java

Rule Violation Line
AvoidFileStream Avoid instantiating FileInputStream, FileOutputStream, FileReader, or FileWriter 191

Priority 2

fr/paris/lutece/plugins/adminauthenticationwsso/AdminWssoAuthentication.java

Rule Violation Line
GuardLogStatement Logger calls should be surrounded by log level guards. 344–346
GuardLogStatement Logger calls should be surrounded by log level guards. 409–411
GuardLogStatement Logger calls should be surrounded by log level guards. 477
GuardLogStatement Logger calls should be surrounded by log level guards. 496–497

fr/paris/lutece/plugins/adminauthenticationwsso/util/WssoLdapUtil.java

Rule Violation Line
GuardLogStatement Logger calls should be surrounded by log level guards. 111
GuardLogStatement Logger calls should be surrounded by log level guards. 175–178

Priority 3

fr/paris/lutece/plugins/adminauthenticationwsso/AdminWssoAuthentication.java

Rule Violation Line
GodClass Possible God Class (WMC=55, ATFD=51, TCC=0.265%) 67–598
MissingOverride The method 'compare(AdminWssoUser, AdminWssoUser)' is missing an @Override annotation. 103–118
CommentRequired Public method and constructor comments are required 103–118
UseLocaleWithCaseConversions When doing a String.toLowerCase()/toUpperCase() call, use a Locale 105
UseLocaleWithCaseConversions When doing a String.toLowerCase()/toUpperCase() call, use a Locale 105
UseLocaleWithCaseConversions When doing a String.toLowerCase()/toUpperCase() call, use a Locale 109
UseLocaleWithCaseConversions When doing a String.toLowerCase()/toUpperCase() call, use a Locale 109
UseLocaleWithCaseConversions When doing a String.toLowerCase()/toUpperCase() call, use a Locale 113
UseLocaleWithCaseConversions When doing a String.toLowerCase()/toUpperCase() call, use a Locale 113
UnnecessaryConstructor Avoid unnecessary constructors - the compiler will generate these for you 129–132
CommentRequired Public method and constructor comments are required 137–140
MissingOverride The method 'getAuthServiceName()' is missing an @Override annotation. 137–140
CommentRequired Public method and constructor comments are required 145–161
MissingOverride The method 'getAuthType(HttpServletRequest)' is missing an @Override annotation. 145–161
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 150–158
MissingOverride The method 'login(String, String, HttpServletRequest)' is missing an @Override annotation. 166–171
MissingOverride The method 'logout(AdminUser)' is missing an @Override annotation. 176–179
CommentRequired Public method and constructor comments are required 176–179
CommentRequired Public method and constructor comments are required 184–188
MissingOverride The method 'getAnonymousUser()' is missing an @Override annotation. 184–188
MissingOverride The method 'isExternalAuthentication()' is missing an @Override annotation. 194–197
CommentRequired Public method and constructor comments are required 202–242
MissingOverride The method 'getHttpAuthenticatedUser(HttpServletRequest)' is missing an @Override annotation. 202–242
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 211–231
CommentRequired Public method and constructor comments are required 247–250
MissingOverride The method 'getLoginPageUrl()' is missing an @Override annotation. 247–250
MissingOverride The method 'getChangePasswordPageUrl()' is missing an @Override annotation. 255–258
CommentRequired Public method and constructor comments are required 255–258
MissingOverride The method 'getDoLoginUrl()' is missing an @Override annotation. 263–267
CommentRequired Public method and constructor comments are required 263–267
CommentRequired Public method and constructor comments are required 272–276
MissingOverride The method 'getDoLogoutUrl()' is missing an @Override annotation. 272–276
MissingOverride The method 'getNewAccountPageUrl()' is missing an @Override annotation. 281–285
CommentRequired Public method and constructor comments are required 281–285
CommentRequired Public method and constructor comments are required 290–294
MissingOverride The method 'getViewAccountPageUrl()' is missing an @Override annotation. 290–294
MissingOverride The method 'getLostPasswordPageUrl()' is missing an @Override annotation. 299–303
CommentRequired Public method and constructor comments are required 299–303
MissingOverride The method 'getLostLoginPageUrl()' is missing an @Override annotation. 308–312
CommentRequired Public method and constructor comments are required 308–312
MissingOverride The method 'getUserList(String, String, String)' is missing an @Override annotation. 317–448
NcssCount The method 'getUserList(String, String, String)' has a NCSS line count of 60. 317–448
CommentRequired Public method and constructor comments are required 317–448
CyclomaticComplexity The method 'getUserList(String, String, String)' has a cyclomatic complexity of 10. 317–448
ExcessiveMethodLength Avoid really long methods. 317–448
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 319
ShortVariable Avoid variables with short names like sr 320
ConfusingTernary Avoid if (x != y) ..; else ..; 358–366
AvoidDuplicateLiterals The String literal "Error while searching for users '" appears 6 times in this file; the first occurrence is on line 364 364
AvoidDuplicateLiterals The String literal "' with search filter : " appears 6 times in this file; the first occurrence is on line 365 365
ConfusingTernary Avoid if (x != y) ..; else ..; 372–380
ConfusingTernary Avoid if (x != y) ..; else ..; 386–394
ConfusingTernary Avoid if (x != y) ..; else ..; 400–417
EmptyCatchBlock Avoid empty catch blocks 443–446
CommentRequired Public method and constructor comments are required 453–534
MissingOverride The method 'getUserPublicData(String)' is missing an @Override annotation. 453–534
ShortVariable Avoid variables with short names like sr 456
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 501
EmptyCatchBlock Avoid empty catch blocks 529–532
ShortVariable Avoid variables with short names like in 536
InsufficientStringBufferDeclaration StringBuffer constructor is initialized with size 16, but has at least 26 characters appended. 543
ShortVariable Avoid variables with short names like sb 543
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 544
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 545
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 546
PositionLiteralsFirstInCaseInsensitiveComparisons Position literals first in String comparisons for EqualsIgnoreCase 581

fr/paris/lutece/plugins/adminauthenticationwsso/AdminWssoUser.java

Rule Violation Line
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 43–53

fr/paris/lutece/plugins/adminauthenticationwsso/service/AutoExportWssoAdminUsersFile.java

Rule Violation Line
UseUtilityClass All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 44–66
UnnecessaryConstructor Avoid unnecessary constructors - the compiler will generate these for you 51–53
UncommentedEmptyConstructor Document empty constructor 51–53
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 60–65

fr/paris/lutece/plugins/adminauthenticationwsso/service/WssoAdminUserImportService.java

Rule Violation Line
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 34–453
CommentRequired Header comments are required 71–453
CyclomaticComplexity The method 'readLineOfCSVFile(String, int, Locale, String)' has a cyclomatic complexity of 37. 98–416
NPathComplexity The method 'readLineOfCSVFile(String, int, Locale, String)' has an NPath complexity of 1814760 98–416
NcssCount The method 'readLineOfCSVFile(String, int, Locale, String)' has a NCSS line count of 163. 98–416
ExcessiveMethodLength Avoid really long methods. 98–416
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 100
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 106
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 185
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 216
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 266
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 266
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 267
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 268
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 269
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 305
UseCollectionIsEmpty Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 345
AvoidReassigningLoopVariables Avoid reassigning the loop control variable 'strValue' 368
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 401

fr/paris/lutece/plugins/adminauthenticationwsso/service/WssoAdminUsersFileGeneratorService.java

Rule Violation Line
UseUtilityClass All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 62–231
UnnecessaryConstructor Avoid unnecessary constructors - the compiler will generate these for you 92–94
UncommentedEmptyConstructor Document empty constructor 92–94
SimpleDateFormatNeedsLocale When instantiating a SimpleDateFormat object, specify a Locale 126
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 206
IdenticalCatchBranches 'catch' branch identical to 'IOException' branch 206–210
AvoidCatchingNPE Avoid catching NullPointerException; consider removing the cause of the NPE. 206

fr/paris/lutece/plugins/adminauthenticationwsso/service/daemon/ExportWssoAdminUsersDaemon.java

Rule Violation Line
CallSuperInConstructor It is a good practice to call super() in a constructor 51–53
UncommentedEmptyConstructor Document empty constructor 51–53
UnnecessaryConstructor Avoid unnecessary constructors - the compiler will generate these for you 51–53
MissingOverride The method 'run()' is missing an @Override annotation. 58–63

fr/paris/lutece/plugins/adminauthenticationwsso/util/WssoLdapUtil.java

Rule Violation Line
CommentRequired Header comments are required 54–253
UseUtilityClass All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 55–253
CommentRequired Public method and constructor comments are required 75–87
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 82
CommentRequired Public method and constructor comments are required 89–198
ExcessiveMethodLength Avoid really long methods. 89–198
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 91
ShortVariable Avoid variables with short names like sr 92
AddEmptyString Do not add empty strings 96
AddEmptyString Do not add empty strings 97
ConfusingTernary Avoid if (x != y) ..; else ..; 123–131
AvoidDuplicateLiterals The String literal "Error while searching for users '" appears 5 times in this file; the first occurrence is on line 129 129
AvoidDuplicateLiterals The String literal "' with search filter : " appears 5 times in this file; the first occurrence is on line 130 130
ConfusingTernary Avoid if (x != y) ..; else ..; 137–145
ConfusingTernary Avoid if (x != y) ..; else ..; 151–159
ConfusingTernary Avoid if (x != y) ..; else ..; 165–184
ShortVariable Avoid variables with short names like in 201
CommentRequired Public method and constructor comments are required 201–204
CommentRequired Public method and constructor comments are required 206–209
CommentRequired Public method and constructor comments are required 211–214
CommentRequired Public method and constructor comments are required 216–219
CommentRequired Public method and constructor comments are required 221–224
CommentRequired Public method and constructor comments are required 226–229
CommentRequired Public method and constructor comments are required 231–241
PositionLiteralsFirstInCaseInsensitiveComparisons Position literals first in String comparisons for EqualsIgnoreCase 235
CommentRequired Public method and constructor comments are required 243–246
CommentRequired Public method and constructor comments are required 248–251

fr/paris/lutece/plugins/adminauthenticationwsso/web/WSSOAuthenticationJspBean.java

Rule Violation Line
CommentRequired Header comments are required 40–48
CommentRequired Public method and constructor comments are required 44–47

Priority 4

fr/paris/lutece/plugins/adminauthenticationwsso/AdminWssoAuthentication.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.lang.UnsupportedOperationException' due to existing implicit import 'java.lang.*' 186

Files

fr/paris/lutece/plugins/adminauthenticationwsso/AdminWssoAuthentication.java

Rule Violation Priority Line
GodClass Possible God Class (WMC=55, ATFD=51, TCC=0.265%) 3 67–598
MissingOverride The method 'compare(AdminWssoUser, AdminWssoUser)' is missing an @Override annotation. 3 103–118
CommentRequired Public method and constructor comments are required 3 103–118
UseLocaleWithCaseConversions When doing a String.toLowerCase()/toUpperCase() call, use a Locale 3 105
UseLocaleWithCaseConversions When doing a String.toLowerCase()/toUpperCase() call, use a Locale 3 105
UseLocaleWithCaseConversions When doing a String.toLowerCase()/toUpperCase() call, use a Locale 3 109
UseLocaleWithCaseConversions When doing a String.toLowerCase()/toUpperCase() call, use a Locale 3 109
UseLocaleWithCaseConversions When doing a String.toLowerCase()/toUpperCase() call, use a Locale 3 113
UseLocaleWithCaseConversions When doing a String.toLowerCase()/toUpperCase() call, use a Locale 3 113
UnnecessaryConstructor Avoid unnecessary constructors - the compiler will generate these for you 3 129–132
CommentRequired Public method and constructor comments are required 3 137–140
MissingOverride The method 'getAuthServiceName()' is missing an @Override annotation. 3 137–140
CommentRequired Public method and constructor comments are required 3 145–161
MissingOverride The method 'getAuthType(HttpServletRequest)' is missing an @Override annotation. 3 145–161
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 3 150–158
MissingOverride The method 'login(String, String, HttpServletRequest)' is missing an @Override annotation. 3 166–171
MissingOverride The method 'logout(AdminUser)' is missing an @Override annotation. 3 176–179
CommentRequired Public method and constructor comments are required 3 176–179
CommentRequired Public method and constructor comments are required 3 184–188
MissingOverride The method 'getAnonymousUser()' is missing an @Override annotation. 3 184–188
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.lang.UnsupportedOperationException' due to existing implicit import 'java.lang.*' 4 186
MissingOverride The method 'isExternalAuthentication()' is missing an @Override annotation. 3 194–197
CommentRequired Public method and constructor comments are required 3 202–242
MissingOverride The method 'getHttpAuthenticatedUser(HttpServletRequest)' is missing an @Override annotation. 3 202–242
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 3 211–231
CommentRequired Public method and constructor comments are required 3 247–250
MissingOverride The method 'getLoginPageUrl()' is missing an @Override annotation. 3 247–250
MissingOverride The method 'getChangePasswordPageUrl()' is missing an @Override annotation. 3 255–258
CommentRequired Public method and constructor comments are required 3 255–258
MissingOverride The method 'getDoLoginUrl()' is missing an @Override annotation. 3 263–267
CommentRequired Public method and constructor comments are required 3 263–267
CommentRequired Public method and constructor comments are required 3 272–276
MissingOverride The method 'getDoLogoutUrl()' is missing an @Override annotation. 3 272–276
MissingOverride The method 'getNewAccountPageUrl()' is missing an @Override annotation. 3 281–285
CommentRequired Public method and constructor comments are required 3 281–285
CommentRequired Public method and constructor comments are required 3 290–294
MissingOverride The method 'getViewAccountPageUrl()' is missing an @Override annotation. 3 290–294
MissingOverride The method 'getLostPasswordPageUrl()' is missing an @Override annotation. 3 299–303
CommentRequired Public method and constructor comments are required 3 299–303
MissingOverride The method 'getLostLoginPageUrl()' is missing an @Override annotation. 3 308–312
CommentRequired Public method and constructor comments are required 3 308–312
MissingOverride The method 'getUserList(String, String, String)' is missing an @Override annotation. 3 317–448
NcssCount The method 'getUserList(String, String, String)' has a NCSS line count of 60. 3 317–448
CommentRequired Public method and constructor comments are required 3 317–448
CyclomaticComplexity The method 'getUserList(String, String, String)' has a cyclomatic complexity of 10. 3 317–448
ExcessiveMethodLength Avoid really long methods. 3 317–448
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 319
ShortVariable Avoid variables with short names like sr 3 320
GuardLogStatement Logger calls should be surrounded by log level guards. 2 344–346
ConfusingTernary Avoid if (x != y) ..; else ..; 3 358–366
AvoidDuplicateLiterals The String literal "Error while searching for users '" appears 6 times in this file; the first occurrence is on line 364 3 364
AvoidDuplicateLiterals The String literal "' with search filter : " appears 6 times in this file; the first occurrence is on line 365 3 365
ConfusingTernary Avoid if (x != y) ..; else ..; 3 372–380
ConfusingTernary Avoid if (x != y) ..; else ..; 3 386–394
ConfusingTernary Avoid if (x != y) ..; else ..; 3 400–417
GuardLogStatement Logger calls should be surrounded by log level guards. 2 409–411
EmptyCatchBlock Avoid empty catch blocks 3 443–446
CommentRequired Public method and constructor comments are required 3 453–534
MissingOverride The method 'getUserPublicData(String)' is missing an @Override annotation. 3 453–534
ShortVariable Avoid variables with short names like sr 3 456
GuardLogStatement Logger calls should be surrounded by log level guards. 2 477
GuardLogStatement Logger calls should be surrounded by log level guards. 2 496–497
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 3 501
EmptyCatchBlock Avoid empty catch blocks 3 529–532
ShortVariable Avoid variables with short names like in 3 536
InsufficientStringBufferDeclaration StringBuffer constructor is initialized with size 16, but has at least 26 characters appended. 3 543
ShortVariable Avoid variables with short names like sb 3 543
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 544
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 545
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 546
PositionLiteralsFirstInCaseInsensitiveComparisons Position literals first in String comparisons for EqualsIgnoreCase 3 581

fr/paris/lutece/plugins/adminauthenticationwsso/AdminWssoUser.java

Rule Violation Priority Line
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 3 43–53

fr/paris/lutece/plugins/adminauthenticationwsso/service/AutoExportWssoAdminUsersFile.java

Rule Violation Priority Line
ClassNamingConventions The utility class name 'AutoExportWssoAdminUsersFile' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' 1 43–66
UseUtilityClass All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 3 44–66
UnnecessaryConstructor Avoid unnecessary constructors - the compiler will generate these for you 3 51–53
UncommentedEmptyConstructor Document empty constructor 3 51–53
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 3 60–65

fr/paris/lutece/plugins/adminauthenticationwsso/service/WssoAdminUserImportService.java

Rule Violation Priority Line
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 3 34–453
CommentRequired Header comments are required 3 71–453
FieldNamingConventions The constant name '_attributeService' doesn't match '[A-Z][A-Z_0-9]*' 1 92
CyclomaticComplexity The method 'readLineOfCSVFile(String, int, Locale, String)' has a cyclomatic complexity of 37. 3 98–416
NPathComplexity The method 'readLineOfCSVFile(String, int, Locale, String)' has an NPath complexity of 1814760 3 98–416
NcssCount The method 'readLineOfCSVFile(String, int, Locale, String)' has a NCSS line count of 163. 3 98–416
ExcessiveMethodLength Avoid really long methods. 3 98–416
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 3 100
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 106
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 185
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 3 216
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 266
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 266
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 267
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 268
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 269
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 305
UseCollectionIsEmpty Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 3 345
AvoidReassigningLoopVariables Avoid reassigning the loop control variable 'strValue' 3 368
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 401

fr/paris/lutece/plugins/adminauthenticationwsso/service/WssoAdminUsersFileGeneratorService.java

Rule Violation Priority Line
UseUtilityClass All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 3 62–231
UnnecessaryConstructor Avoid unnecessary constructors - the compiler will generate these for you 3 92–94
UncommentedEmptyConstructor Document empty constructor 3 92–94
SimpleDateFormatNeedsLocale When instantiating a SimpleDateFormat object, specify a Locale 3 126
AvoidFileStream Avoid instantiating FileInputStream, FileOutputStream, FileReader, or FileWriter 1 191
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 206
IdenticalCatchBranches 'catch' branch identical to 'IOException' branch 3 206–210
AvoidCatchingNPE Avoid catching NullPointerException; consider removing the cause of the NPE. 3 206

fr/paris/lutece/plugins/adminauthenticationwsso/service/daemon/ExportWssoAdminUsersDaemon.java

Rule Violation Priority Line
CallSuperInConstructor It is a good practice to call super() in a constructor 3 51–53
UncommentedEmptyConstructor Document empty constructor 3 51–53
UnnecessaryConstructor Avoid unnecessary constructors - the compiler will generate these for you 3 51–53
MissingOverride The method 'run()' is missing an @Override annotation. 3 58–63

fr/paris/lutece/plugins/adminauthenticationwsso/util/WssoLdapUtil.java

Rule Violation Priority Line
CommentRequired Header comments are required 3 54–253
UseUtilityClass All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 3 55–253
CommentRequired Public method and constructor comments are required 3 75–87
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 82
CommentRequired Public method and constructor comments are required 3 89–198
ExcessiveMethodLength Avoid really long methods. 3 89–198
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 91
ShortVariable Avoid variables with short names like sr 3 92
AddEmptyString Do not add empty strings 3 96
AddEmptyString Do not add empty strings 3 97
GuardLogStatement Logger calls should be surrounded by log level guards. 2 111
ConfusingTernary Avoid if (x != y) ..; else ..; 3 123–131
AvoidDuplicateLiterals The String literal "Error while searching for users '" appears 5 times in this file; the first occurrence is on line 129 3 129
AvoidDuplicateLiterals The String literal "' with search filter : " appears 5 times in this file; the first occurrence is on line 130 3 130
ConfusingTernary Avoid if (x != y) ..; else ..; 3 137–145
ConfusingTernary Avoid if (x != y) ..; else ..; 3 151–159
ConfusingTernary Avoid if (x != y) ..; else ..; 3 165–184
GuardLogStatement Logger calls should be surrounded by log level guards. 2 175–178
ShortVariable Avoid variables with short names like in 3 201
CommentRequired Public method and constructor comments are required 3 201–204
CommentRequired Public method and constructor comments are required 3 206–209
CommentRequired Public method and constructor comments are required 3 211–214
CommentRequired Public method and constructor comments are required 3 216–219
CommentRequired Public method and constructor comments are required 3 221–224
CommentRequired Public method and constructor comments are required 3 226–229
CommentRequired Public method and constructor comments are required 3 231–241
PositionLiteralsFirstInCaseInsensitiveComparisons Position literals first in String comparisons for EqualsIgnoreCase 3 235
CommentRequired Public method and constructor comments are required 3 243–246
CommentRequired Public method and constructor comments are required 3 248–251

fr/paris/lutece/plugins/adminauthenticationwsso/web/WSSOAuthenticationJspBean.java

Rule Violation Priority Line
CommentRequired Header comments are required 3 40–48
CommentRequired Public method and constructor comments are required 3 44–47