Fork me on GitHub

PMD Results

The following document contains the results of PMD 6.13.0.

Violations By Priority

Priority 1

fr/paris/lutece/plugins/appcenter/business/Application.java

Rule Violation Line
FormalParameterNamingConventions The method parameter name '_strCode' doesn't match '[a-z][a-zA-Z0-9]*' 227

fr/paris/lutece/plugins/appcenter/business/ApplicationData.java

Rule Violation Line
FormalParameterNamingConventions The method parameter name '_nIdApllicationData' doesn't match '[a-z][a-zA-Z0-9]*' 114

fr/paris/lutece/plugins/appcenter/business/Demand.java

Rule Violation Line
FormalParameterNamingConventions The method parameter name '_creationTimestamp' doesn't match '[a-z][a-zA-Z0-9]*' 273

fr/paris/lutece/plugins/appcenter/business/DemandDAO.java

Rule Violation Line
AvoidThrowingRawExceptionTypes Avoid throwing raw exception types. 342

fr/paris/lutece/plugins/appcenter/business/DocumentationCategory.java

Rule Violation Line
FieldNamingConventions The final field name '_strPrefix' doesn't match '[a-z][a-zA-Z0-9]*' 43
FieldNamingConventions The final field name '_strLabelKey' doesn't match '[a-z][a-zA-Z0-9]*' 44

fr/paris/lutece/plugins/appcenter/business/Environment.java

Rule Violation Line
FieldNamingConventions The final field name '_strPrefix' doesn't match '[a-z][a-zA-Z0-9]*' 46
FieldNamingConventions The final field name '_strLabelKey' doesn't match '[a-z][a-zA-Z0-9]*' 47

fr/paris/lutece/plugins/appcenter/business/IPermissionDAO.java

Rule Violation Line
FormalParameterNamingConventions The method parameter name '_plugin' doesn't match '[a-z][a-zA-Z0-9]*' 98

fr/paris/lutece/plugins/appcenter/service/DemandTypeService.java

Rule Violation Line
FieldNamingConventions The static field name 'KEY_SUPER_ADMIN_ROLE' doesn't match '_[a-z][a-zA-Z0-9]*' 50

fr/paris/lutece/plugins/appcenter/service/task/AppcenterTask.java

Rule Violation Line
AvoidThrowingRawExceptionTypes Avoid throwing raw exception types. 108

fr/paris/lutece/plugins/appcenter/service/task/TaskCustomDemandStatus.java

Rule Violation Line
FieldNamingConventions The final field name '_taskConfigService' doesn't match '[a-z][a-zA-Z0-9]*' 50

fr/paris/lutece/plugins/appcenter/web/AppCenterXPage.java

Rule Violation Line
EmptyMethodInAbstractClassShouldBeAbstract An empty method in an abstract class should be abstract instead 344347

fr/paris/lutece/plugins/appcenter/web/Constants.java

Rule Violation Line
ClassNamingConventions The utility class name 'Constants' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' 3975

Priority 2

fr/paris/lutece/plugins/appcenter/service/web/task/TaskCustomDemandStatusComponent.java

Rule Violation Line
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 82

Priority 3

fr/paris/lutece/plugins/appcenter/business/Action.java

Rule Violation Line
CommentRequired Header comments are required 36151
CommentRequired Public method and constructor comments are required 4451
CommentRequired Public method and constructor comments are required 5356
CommentRequired Public method and constructor comments are required 141144
CommentRequired Public method and constructor comments are required 146149

fr/paris/lutece/plugins/appcenter/business/Application.java

Rule Violation Line
ConfusingTernary Avoid if (x != y) ..; else ..; 177
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 229
ConfusingTernary Avoid if (x != y) ..; else ..; 229
UseLocaleWithCaseConversions When doing a String.toLowerCase()/toUpperCase() call, use a Locale 229
CommentRequired Public method and constructor comments are required 269281

fr/paris/lutece/plugins/appcenter/business/ApplicationDAO.java

Rule Violation Line
TooManyMethods This class has too many methods, consider refactoring it. 50508
ConfusingTernary Avoid if (x != y) ..; else ..; 106114
ConfusingTernary Avoid if (x != y) ..; else ..; 227235
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 388
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 388

fr/paris/lutece/plugins/appcenter/business/ApplicationData.java

Rule Violation Line
CommentRequired Header comments are required 39119
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 43

fr/paris/lutece/plugins/appcenter/business/ApplicationDatas.java

Rule Violation Line
CommentRequired Header comments are required 4173
CommentRequired Public method and constructor comments are required 4548
CommentRequired Public method and constructor comments are required 6065

fr/paris/lutece/plugins/appcenter/business/ApplicationDemandTypesEnable.java

Rule Violation Line
CommentRequired Public method and constructor comments are required 4851
FieldDeclarationsShouldBeAtStartOfClass Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 53
CommentRequired Public method and constructor comments are required 6568

fr/paris/lutece/plugins/appcenter/business/ApplicationUrlHome.java

Rule Violation Line
UseUtilityClass All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 47110

fr/paris/lutece/plugins/appcenter/business/AuthorizedApp.java

Rule Violation Line
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 3964

fr/paris/lutece/plugins/appcenter/business/CategoryAction.java

Rule Violation Line
CommentRequired Header comments are required 39152
CommentRequired Public method and constructor comments are required 4652
CommentRequired Public method and constructor comments are required 5466

fr/paris/lutece/plugins/appcenter/business/CategoryDemandType.java

Rule Violation Line
CommentRequired Public method and constructor comments are required 142145
CommentRequired Public method and constructor comments are required 147150

fr/paris/lutece/plugins/appcenter/business/CategoryDemandTypeDAO.java

Rule Violation Line
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 148
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 176

fr/paris/lutece/plugins/appcenter/business/Demand.java

Rule Violation Line
CommentRequired Public method and constructor comments are required 261265
CommentRequired Public method and constructor comments are required 321324

fr/paris/lutece/plugins/appcenter/business/DemandDAO.java

Rule Violation Line
TooManyMethods This class has too many methods, consider refactoring it. 54463
ConfusingTernary Avoid if (x != y) ..; else ..; 103110
ConfusingTernary Avoid if (x != y) ..; else ..; 192199
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 213
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 235
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 259
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 284
NPathComplexity The method 'selectDemandsListByFilter(DemandFilter, Plugin)' has an NPath complexity of 2304 392462
CyclomaticComplexity The method 'selectDemandsListByFilter(DemandFilter, Plugin)' has a cyclomatic complexity of 14. 392462
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 394
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 431

fr/paris/lutece/plugins/appcenter/business/DemandHome.java

Rule Violation Line
CommentRequired Public method and constructor comments are required 194197

fr/paris/lutece/plugins/appcenter/business/DemandType.java

Rule Violation Line
CommentRequired Public method and constructor comments are required 7578
CommentRequired Public method and constructor comments are required 205208
CommentRequired Public method and constructor comments are required 210213
CommentRequired Public method and constructor comments are required 215218
CommentRequired Public method and constructor comments are required 220223
CommentRequired Public method and constructor comments are required 225228
CommentRequired Public method and constructor comments are required 230233
CommentRequired Public method and constructor comments are required 235238
CommentRequired Public method and constructor comments are required 240243
CommentRequired Public method and constructor comments are required 245248

fr/paris/lutece/plugins/appcenter/business/DemandTypeDAO.java

Rule Violation Line
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 163
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 208
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 243

fr/paris/lutece/plugins/appcenter/business/DemandValidation.java

Rule Violation Line
CommentRequired Header comments are required 40151

fr/paris/lutece/plugins/appcenter/business/DemandValidationHome.java

Rule Violation Line
ImportFromSamePackage No need to import a type that lives in the same package 36
ImportFromSamePackage No need to import a type that lives in the same package 37

fr/paris/lutece/plugins/appcenter/business/DocumentationCategory.java

Rule Violation Line
CommentRequired Enum comments are required 3899
UnnecessaryModifier Unnecessary modifier 'private' on constructor 'DocumentationCategory(String, String)': enum constructors are implicitly private 5458

fr/paris/lutece/plugins/appcenter/business/DocumentationDAO.java

Rule Violation Line
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 150
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 178
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 216

fr/paris/lutece/plugins/appcenter/business/Environment.java

Rule Violation Line
CommentRequired Enum comments are required 40111
UnnecessaryModifier Unnecessary modifier 'private' on constructor 'Environment(String, String)': enum constructors are implicitly private 5761

fr/paris/lutece/plugins/appcenter/business/IApplicationDAO.java

Rule Violation Line
TooManyMethods This class has too many methods, consider refactoring it. 45183

fr/paris/lutece/plugins/appcenter/business/IDemandDAO.java

Rule Violation Line
TooManyMethods This class has too many methods, consider refactoring it. 45174

fr/paris/lutece/plugins/appcenter/business/IDemandValidationDAO.java

Rule Violation Line
ImportFromSamePackage No need to import a type that lives in the same package 36

fr/paris/lutece/plugins/appcenter/business/IUserApplicationRoleDAO.java

Rule Violation Line
TooManyMethods This class has too many methods, consider refactoring it. 44179

fr/paris/lutece/plugins/appcenter/business/RoleDAO.java

Rule Violation Line
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 174
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 200
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 238
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 238

fr/paris/lutece/plugins/appcenter/business/UserApplicationRoleDAO.java

Rule Violation Line
TooManyMethods This class has too many methods, consider refactoring it. 48403
NPathComplexity The method 'selectUserApplicationRolesListByFilter(UserApplicationRoleFilter, Plugin)' has an NPath complexity of 1728 213282
CyclomaticComplexity The method 'selectUserApplicationRolesListByFilter(UserApplicationRoleFilter, Plugin)' has a cyclomatic complexity of 14. 213282

fr/paris/lutece/plugins/appcenter/business/UserDAO.java

Rule Violation Line
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 136
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 161

fr/paris/lutece/plugins/appcenter/business/UserInfos.java

Rule Violation Line
CommentRequired Header comments are required 3843

fr/paris/lutece/plugins/appcenter/business/organization/Organization.java

Rule Violation Line
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 4283

fr/paris/lutece/plugins/appcenter/business/organization/OrganizationManager.java

Rule Violation Line
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 42142

fr/paris/lutece/plugins/appcenter/business/prerequisite/PrerequisiteValidationConfig.java

Rule Violation Line
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 3887
CommentRequired Header comments are required 3887
DefaultPackage Use explicit scoping instead of the default package private level 42
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the _nIdTask field if you want a default access modifier 42
DefaultPackage Use explicit scoping instead of the default package private level 43
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the _nStatus field if you want a default access modifier 43

fr/paris/lutece/plugins/appcenter/business/prerequisite/PrerequisiteValidationConfigDAO.java

Rule Violation Line
CommentRequired Header comments are required 43120

fr/paris/lutece/plugins/appcenter/business/resourcetype/AbstractAppCenterResourceType.java

Rule Violation Line
CommentRequired Header comments are required 4561

fr/paris/lutece/plugins/appcenter/business/resourcetype/ApplicationResourceType.java

Rule Violation Line
CommentRequired Header comments are required 4587

fr/paris/lutece/plugins/appcenter/business/resourcetype/EnvironmentResourceType.java

Rule Violation Line
CommentRequired Header comments are required 4680

fr/paris/lutece/plugins/appcenter/business/resourcetype/IAppCenterResourceType.java

Rule Violation Line
CommentRequired Header comments are required 3861
UnnecessaryModifier Unnecessary modifier 'public' on method 'getRessourceTypeKey': the method is declared in an interface type 45
UnnecessaryModifier Unnecessary modifier 'public' on method 'getRessourceTypeLabel': the method is declared in an interface type 52
UnnecessaryModifier Unnecessary modifier 'public' on method 'getResourceTypeValues': the method is declared in an interface type 59

fr/paris/lutece/plugins/appcenter/business/resourcetype/ResourceTypeValue.java

Rule Violation Line
CommentRequired Header comments are required 4188

fr/paris/lutece/plugins/appcenter/business/task/CustomDemandStatusTaskConfigDAO.java

Rule Violation Line
UnusedPrivateField Avoid unused private fields such as 'SQL_QUERY_NEW_PK'. 45

fr/paris/lutece/plugins/appcenter/business/task/NotifyTaskConfig.java

Rule Violation Line
CommentRequired Header comments are required 38148
DefaultPackage Use explicit scoping instead of the default package private level 40
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the _strNotificationType field if you want a default access modifier 40
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the _nIdMailingList field if you want a default access modifier 41
DefaultPackage Use explicit scoping instead of the default package private level 41
DefaultPackage Use explicit scoping instead of the default package private level 42
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the _strSubject field if you want a default access modifier 42
DefaultPackage Use explicit scoping instead of the default package private level 43
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the _strMessage field if you want a default access modifier 43
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the _strSenderName field if you want a default access modifier 44
DefaultPackage Use explicit scoping instead of the default package private level 44

fr/paris/lutece/plugins/appcenter/business/userinfos/GitlabUserInfo.java

Rule Violation Line
CommentRequired Header comments are required 3976
CommentRequired Public method and constructor comments are required 4448
CallSuperInConstructor It is a good practice to call super() in a constructor 4448
CommentRequired Public method and constructor comments are required 5053
CommentRequired Public method and constructor comments are required 5558
CommentRequired Public method and constructor comments are required 6063
CommentRequired Public method and constructor comments are required 6568

fr/paris/lutece/plugins/appcenter/business/userinfos/SvnUserInfo.java

Rule Violation Line
CommentRequired Header comments are required 3976
CallSuperInConstructor It is a good practice to call super() in a constructor 4448
CommentRequired Public method and constructor comments are required 4448
CommentRequired Public method and constructor comments are required 5053
CommentRequired Public method and constructor comments are required 5558
CommentRequired Public method and constructor comments are required 6063
CommentRequired Public method and constructor comments are required 6568

fr/paris/lutece/plugins/appcenter/service/ActionService.java

Rule Violation Line
CommentRequired Header comments are required 51105
UseUtilityClass All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 52105

fr/paris/lutece/plugins/appcenter/service/AppcenterAsynchronousUploadHandler.java

Rule Violation Line
CommentRequired Header comments are required 56277
ShortVariable Avoid variables with short names like s 243
ControlStatementBraces This statement should have braces 245
CommentRequired Public method and constructor comments are required 249261
CommentRequired Public method and constructor comments are required 263275

fr/paris/lutece/plugins/appcenter/service/AppcenterPlugin.java

Rule Violation Line
CommentRequired Header comments are required 4056
UncommentedEmptyMethodBody Document empty method body 4950
CommentRequired Public method and constructor comments are required 5255

fr/paris/lutece/plugins/appcenter/service/ApplicationPermissionProvider.java

Rule Violation Line
CommentRequired Header comments are required 4695
AvoidDuplicateLiterals The String literal "APP" appears 6 times in this file; the first occurrence is on line 59 59

fr/paris/lutece/plugins/appcenter/service/ApplicationService.java

Rule Violation Line
UseUtilityClass All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 68301
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the getApplicationData method if you want a default access modifier 161175
DefaultPackage Use explicit scoping instead of the default package private level 161175
ConfusingTernary Avoid if (x != y) ..; else ..; 166173
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the getDataSubset method if you want a default access modifier 218228
DefaultPackage Use explicit scoping instead of the default package private level 218228
CommentRequired Public method and constructor comments are required 254278
ConfusingTernary Avoid if (x != y) ..; else ..; 260269
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 292

fr/paris/lutece/plugins/appcenter/service/AuthorizationService.java

Rule Violation Line
UseUtilityClass All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 4685
CommentRequired Public method and constructor comments are required 4784
CyclomaticComplexity The method 'isAuthorized(String, int, String, String)' has a cyclomatic complexity of 10. 4784
ConfusingTernary Avoid if (x != y) ..; else ..; 6579
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 6972
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 7679

fr/paris/lutece/plugins/appcenter/service/DemandService.java

Rule Violation Line
UseUtilityClass All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 60224
CommentRequired Public method and constructor comments are required 6879
CommentRequired Public method and constructor comments are required 8184
CommentRequired Public method and constructor comments are required 8697
ShortVariable Avoid variables with short names like it 162
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 167171
UseCollectionIsEmpty Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 173
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 190

fr/paris/lutece/plugins/appcenter/service/DemandTypeIdService.java

Rule Violation Line
CommentRequired Header comments are required 4694
ShortVariable Avoid variables with short names like rt 59
ShortVariable Avoid variables with short names like p 65

fr/paris/lutece/plugins/appcenter/service/DemandTypeService.java

Rule Violation Line
CommentRequired Header comments are required 47124
UseUtilityClass All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 48124
CommentRequired Public method and constructor comments are required 5255
CommentRequired Public method and constructor comments are required 5760
CommentRequired Public method and constructor comments are required 6281
UnnecessaryLocalBeforeReturn Consider simply returning the value vs storing it in local variable 'className' 72

fr/paris/lutece/plugins/appcenter/service/EnvironmentService.java

Rule Violation Line
CommentRequired Header comments are required 4265
UseUtilityClass All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 4365

fr/paris/lutece/plugins/appcenter/service/IPermissionProvider.java

Rule Violation Line
CommentRequired Header comments are required 4452
UnnecessaryModifier Unnecessary modifier 'public' on method 'providePermissionList': the method is declared in an interface type 51

fr/paris/lutece/plugins/appcenter/service/PermissionService.java

Rule Violation Line
CommentRequired Header comments are required 4680
UseUtilityClass All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 4780

fr/paris/lutece/plugins/appcenter/service/ResourceTypeConfig.java

Rule Violation Line
CommentRequired Header comments are required 3993
DefaultPackage Use explicit scoping instead of the default package private level 41
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the _mapResourceType field if you want a default access modifier 41

fr/paris/lutece/plugins/appcenter/service/ResourceTypeService.java

Rule Violation Line
CommentRequired Header comments are required 4574
UseUtilityClass All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 4674

fr/paris/lutece/plugins/appcenter/service/RoleService.java

Rule Violation Line
CommentRequired Header comments are required 4656
UseUtilityClass All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 4756
CommentRequired Public method and constructor comments are required 5055
UnnecessaryLocalBeforeReturn Consider simply returning the value vs storing it in local variable 'ownerRole' 54

fr/paris/lutece/plugins/appcenter/service/UserService.java

Rule Violation Line
UseUtilityClass All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 59343
ConfusingTernary Avoid if (x != y) ..; else ..; 125140
DefaultPackage Use explicit scoping instead of the default package private level 293316
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the getUserInfo method if you want a default access modifier 293316
ConfusingTernary Avoid if (x != y) ..; else ..; 307314
DefaultPackage Use explicit scoping instead of the default package private level 331341
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the getDataSubset method if you want a default access modifier 331341

fr/paris/lutece/plugins/appcenter/service/prerequisite/PrerequisiteValidation.java

Rule Violation Line
CommentRequired Header comments are required 62153
MissingOverride The method 'getPrerequisiteType()' is missing an @Override annotation. 7376
CommentRequired Public method and constructor comments are required 7376
MissingOverride The method 'getTitleI18nKey()' is missing an @Override annotation. 7881
CommentRequired Public method and constructor comments are required 7881
MissingOverride The method 'hasConfiguration()' is missing an @Override annotation. 8386
CommentRequired Public method and constructor comments are required 8386
MissingOverride The method 'getEmptyConfiguration()' is missing an @Override annotation. 8891
CommentRequired Public method and constructor comments are required 8891
MissingOverride The method 'getConfigurationDaoBeanName()' is missing an @Override annotation. 9396
CommentRequired Public method and constructor comments are required 9396
CommentRequired Public method and constructor comments are required 98106
MissingOverride The method 'getConfigHtml(IPrerequisiteConfig, HttpServletRequest, Locale)' is missing an @Override annotation. 98106
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 100
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 100

fr/paris/lutece/plugins/appcenter/service/task/AppCenterTaskFunctional.java

Rule Violation Line
CommentRequired Header comments are required 4550
CommentRequired Public method and constructor comments are required 48

fr/paris/lutece/plugins/appcenter/service/task/AppcenterTask.java

Rule Violation Line
CyclomaticComplexity The method 'processTask(int, HttpServletRequest, Locale, Class, Class, Class, AppCenterTaskFunctional)' has a cyclomatic complexity of 11. 90167
ShortVariable Avoid variables with short names like it 150

fr/paris/lutece/plugins/appcenter/service/task/TaskCloseDemand.java

Rule Violation Line
CommentRequired Header comments are required 4575

fr/paris/lutece/plugins/appcenter/service/task/TaskCustomDemandStatus.java

Rule Violation Line
CommentRequired Header comments are required 4881

fr/paris/lutece/plugins/appcenter/service/task/TaskNotify.java

Rule Violation Line
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 34174
CommentRequired Header comments are required 70174
UnusedFormalParameter Avoid unused method parameters such as 'request'. 112
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 114
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 114
SwitchStmtsShouldHaveDefault Switch statements should have a default label 142169
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 150
UseEqualsToCompareStrings Use equals() to compare strings instead of '==' or '!=' 150

fr/paris/lutece/plugins/appcenter/service/task/TaskNotifyToValidate.java

Rule Violation Line
CommentRequired Header comments are required 65158
UnusedPrivateField Avoid unused private fields such as 'SLASH'. 85
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 129
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 129

fr/paris/lutece/plugins/appcenter/service/web/task/TaskCustomDemandStatusComponent.java

Rule Violation Line
CommentRequired Header comments are required 51122
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 63
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 63
ShortVariable Avoid variables with short names like i 92
ShortVariable Avoid variables with short names like i 100
ShortVariable Avoid variables with short names like i 109
ShortVariable Avoid variables with short names like i 118

fr/paris/lutece/plugins/appcenter/service/web/task/TaskNotifyComponent.java

Rule Violation Line
ShortVariable Avoid variables with short names like i 82
CommentRequired Public method and constructor comments are required 8790
ShortVariable Avoid variables with short names like i 87
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 95
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 95
ShortVariable Avoid variables with short names like i 107
ConfusingTernary Avoid if (x != y) ..; else ..; 132169
DefaultPackage Use explicit scoping instead of the default package private level 174190
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the populate method if you want a default access modifier 174190

fr/paris/lutece/plugins/appcenter/service/web/task/TaskNotifyToValidateComponent.java

Rule Violation Line
CommentRequired Header comments are required 55149
ShortVariable Avoid variables with short names like i 69
CommentRequired Public method and constructor comments are required 7477
ShortVariable Avoid variables with short names like i 74
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 82
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 82
ShortVariable Avoid variables with short names like i 93
ConfusingTernary Avoid if (x != y) ..; else ..; 118145

fr/paris/lutece/plugins/appcenter/util/AppCenterUtils.java

Rule Violation Line
CommentRequired Header comments are required 4175
UseUtilityClass All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 4275

fr/paris/lutece/plugins/appcenter/util/CryptoUtil.java

Rule Violation Line
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the PROPERTY_CRYPTO_KEY field if you want a default access modifier 62
DefaultPackage Use explicit scoping instead of the default package private level 62
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the DSKEY_CRYPTO_KEY field if you want a default access modifier 63
DefaultPackage Use explicit scoping instead of the default package private level 63
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 115
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 145
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 168
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 218228
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 220
AppendCharacterWithChar Avoid appending characters as strings in StringBuffer.append. 223

fr/paris/lutece/plugins/appcenter/web/AppCenterDemandXPage.java

Rule Violation Line
ConfusingTernary Avoid if (x != y) ..; else ..; 86
UnusedLocalVariable Avoid unused local variables such as 'session'. 90
CommentRequired Protected method constructor comments are required 110
CommentRequired Protected method constructor comments are required 112
CommentRequired Protected method constructor comments are required 114

fr/paris/lutece/plugins/appcenter/web/AppCenterXPage.java

Rule Violation Line
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 34348
UnusedPrivateField Avoid unused private fields such as 'ERROR_APP_NOT_FOUND'. 89
UnusedPrivateField Avoid unused private fields such as 'ERROR_INVALID_APP_ID'. 91
EmptyCatchBlock Avoid empty catch blocks 125128
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 158
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 159
UnnecessaryLocalBeforeReturn Consider simply returning the value vs storing it in local variable 'environment' 183
CommentRequired Protected method constructor comments are required 212252
UnusedLocalVariable Avoid unused local variables such as 'session'. 215
CommentRequired Protected method constructor comments are required 254279
UnusedLocalVariable Avoid unused local variables such as 'session'. 259
ConfusingTernary Avoid if (x != y) ..; else ..; 261276
LinguisticNaming Linguistics Antipattern - The getter 'getUnauthorizedAccessMessage' should not return void linguistically 316319
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 338
EmptyCatchBlock Avoid empty catch blocks 338341
CommentRequired Protected method constructor comments are required 344347

fr/paris/lutece/plugins/appcenter/web/ApplicationJspBean.java

Rule Violation Line
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 34546
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 76546
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 170
ConfusingTernary Avoid if (x != y) ..; else ..; 234
ConfusingTernary Avoid if (x != y) ..; else ..; 398399
CyclomaticComplexity The method 'doSendApplicationMail(HttpServletRequest)' has a cyclomatic complexity of 12. 444516
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 450
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 451
PositionLiteralsFirstInComparisons Position literals first in String comparisons 462
PositionLiteralsFirstInComparisons Position literals first in String comparisons 471

fr/paris/lutece/plugins/appcenter/web/ApplicationUrlXPage.java

Rule Violation Line
CommentRequired Public method and constructor comments are required 98120
ConfusingTernary Avoid if (x != y) ..; else ..; 126133
UseLocaleWithCaseConversions When doing a String.toLowerCase()/toUpperCase() call, use a Locale 129
CommentRequired Public method and constructor comments are required 139156
ConfusingTernary Avoid if (x != y) ..; else ..; 144150
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 151
CommentRequired Public method and constructor comments are required 159174
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 169

fr/paris/lutece/plugins/appcenter/web/ApplicationXPage.java

Rule Violation Line
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 34667
TooManyStaticImports Too many static imports may lead to messy code 34667
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 109667
UnusedPrivateField Avoid unused private fields such as 'ERROR_USER_ROLE_NOT_AUTHORIZED'. 157
CommentRequired Public method and constructor comments are required 185206
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 187
ConfusingTernary Avoid if (x != y) ..; else ..; 218
AvoidDuplicateLiterals The String literal "demandtype_" appears 4 times in this file; the first occurrence is on line 276 276
UseEqualsToCompareStrings Use equals() to compare strings instead of '==' or '!=' 380
ConfusingTernary Avoid if (x != y) ..; else ..; 380391
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 380
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 411
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 412
CommentRequired Public method and constructor comments are required 433476
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 457
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 458
CyclomaticComplexity The method 'doModifyApplication(HttpServletRequest)' has a cyclomatic complexity of 10. 486541
UnusedLocalVariable Avoid unused local variables such as 'application'. 598

fr/paris/lutece/plugins/appcenter/web/DemandJspBean.java

Rule Violation Line
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 34559
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 88559
ImmutableField Private field '_stateService' could be made final; it is only initialized in the declaration or constructor. 157
CyclomaticComplexity The method 'getManageDemands(HttpServletRequest)' has a cyclomatic complexity of 23. 169346
ExcessiveMethodLength Avoid really long methods. 169346
NPathComplexity The method 'getManageDemands(HttpServletRequest)' has an NPath complexity of 28672 169346
NcssCount The method 'getManageDemands(HttpServletRequest)' has a NCSS line count of 96. 169346
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 185
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 186
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 187
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 189
ShortVariable Avoid variables with short names like c 287
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 372
ConfusingTernary Avoid if (x != y) ..; else ..; 373
ConfusingTernary Avoid if (x != y) ..; else ..; 374
ConfusingTernary Avoid if (x != y) ..; else ..; 412
ConfusingTernary Avoid if (x != y) ..; else ..; 447
ConfusingTernary Avoid if (x != y) ..; else ..; 448
ConfusingTernary Avoid if (x != y) ..; else ..; 471
ConfusingTernary Avoid if (x != y) ..; else ..; 472
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 488
CommentRequired Public method and constructor comments are required 539558

fr/paris/lutece/plugins/appcenter/web/DemandTypeJspBean.java

Rule Violation Line
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 68793
TooManyMethods This class has too many methods, consider refactoring it. 69793
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 179
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 182
ConfusingTernary Avoid if (x != y) ..; else ..; 209
CommentRequired Public method and constructor comments are required 331365
ShortVariable Avoid variables with short names like it 345
CommentRequired Public method and constructor comments are required 368404
ShortVariable Avoid variables with short names like it 384
ConfusingTernary Avoid if (x != y) ..; else ..; 422
ConfusingTernary Avoid if (x != y) ..; else ..; 442449
CommentRequired Public method and constructor comments are required 543576
ShortVariable Avoid variables with short names like it 556
CommentRequired Public method and constructor comments are required 579614
ShortVariable Avoid variables with short names like it 594
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 626
ConfusingTernary Avoid if (x != y) ..; else ..; 642655
ConfusingTernary Avoid if (x != y) ..; else ..; 668

fr/paris/lutece/plugins/appcenter/web/DemandValidationXPage.java

Rule Violation Line
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 34252
CommentRequired Header comments are required 77252
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 77252
ImmutableField Private field '_taskService' could be made final; it is only initialized in the declaration or constructor. 110
ImmutableField Private field '_actionService' could be made final; it is only initialized in the declaration or constructor. 111
ImmutableField Private field '_stateService' could be made final; it is only initialized in the declaration or constructor. 112
UnusedPrivateField Avoid unused private fields such as '_stateService'. 112
CyclomaticComplexity The method 'getDemandValidation(HttpServletRequest)' has a cyclomatic complexity of 12. 124184
NPathComplexity The method 'getDemandValidation(HttpServletRequest)' has an NPath complexity of 768 124184
ConfusingTernary Avoid if (x != y) ..; else ..; 133
ConfusingTernary Avoid if (x != y) ..; else ..; 134

fr/paris/lutece/plugins/appcenter/web/ManageAppCenterJspBean.java

Rule Violation Line
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 49102
SingularField Perhaps '_nDefaultItemsPerPage' could be replaced by a local variable. 65
AddEmptyString Do not add empty strings 96

fr/paris/lutece/plugins/appcenter/web/PermissionRoleJspBean.java

Rule Violation Line
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 57233
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 113
ConfusingTernary Avoid if (x != y) ..; else ..; 141

fr/paris/lutece/plugins/appcenter/web/RoleJspBean.java

Rule Violation Line
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 53240
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 109
ConfusingTernary Avoid if (x != y) ..; else ..; 126

fr/paris/lutece/plugins/appcenter/web/UserApplicationRoleJspBean.java

Rule Violation Line
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 68479
CyclomaticComplexity The method 'getManageUserApplicationRoles(HttpServletRequest)' has a cyclomatic complexity of 11. 151230
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 159
ShortVariable Avoid variables with short names like c 181
ConfusingTernary Avoid if (x != y) ..; else ..; 276
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 466
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 466

fr/paris/lutece/plugins/appcenter/web/UserXPage.java

Rule Violation Line
CommentRequired Header comments are required 52144
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 52144
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 123
ControlStatementBraces This statement should have braces 127
ControlStatementBraces This statement should have braces 129

fr/paris/lutece/plugins/appcenter/web/organization/AbstractManageOrganizationJspBean.java

Rule Violation Line
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 4997

fr/paris/lutece/plugins/appcenter/web/organization/OrganizationJspBean.java

Rule Violation Line
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 55249
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 109
ConfusingTernary Avoid if (x != y) ..; else ..; 125

fr/paris/lutece/plugins/appcenter/web/organization/OrganizationManagerJspBean.java

Rule Violation Line
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 56274
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 112
ConfusingTernary Avoid if (x != y) ..; else ..; 142

Priority 4

fr/paris/lutece/plugins/appcenter/business/Application.java

Rule Violation Line
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.appcenter.business.resourcetype.ResourceTypeValue' 37
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.appcenter.business.resourcetype.AbstractAppCenterResourceType' 38
DuplicateImports Avoid duplicate imports such as 'javax.validation.constraints.NotNull' 51
DuplicateImports Avoid duplicate imports such as 'javax.validation.constraints.Size' 52
DuplicateImports Avoid duplicate imports such as 'org.hibernate.validator.constraints.NotEmpty' 53

fr/paris/lutece/plugins/appcenter/business/CategoryDemandType.java

Rule Violation Line
UnusedImports Avoid unused imports such as 'javax.validation.constraints' 36
UnusedImports Avoid unused imports such as 'org.hibernate.validator.constraints' 37
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 105108

fr/paris/lutece/plugins/appcenter/business/Demand.java

Rule Violation Line
UnusedImports Avoid unused imports such as 'com.fasterxml.jackson.annotation.JsonIgnoreProperties' 40

fr/paris/lutece/plugins/appcenter/business/DemandHome.java

Rule Violation Line
UnusedImports Avoid unused imports such as 'fr.paris.lutece.portal.service.util.AppLogService' 43
UnusedImports Avoid unused imports such as 'java.io.IOException' 46

fr/paris/lutece/plugins/appcenter/business/DemandTypeDAO.java

Rule Violation Line
UnusedImports Avoid unused imports such as 'java.util.function.Predicate' 43

fr/paris/lutece/plugins/appcenter/business/Documentation.java

Rule Violation Line
UnusedImports Avoid unused imports such as 'org.hibernate.validator.constraints' 37

fr/paris/lutece/plugins/appcenter/business/IDemandDAO.java

Rule Violation Line
UnusedImports Avoid unused imports such as 'java.io.IOException' 38

fr/paris/lutece/plugins/appcenter/business/PermissionRole.java

Rule Violation Line
UnusedImports Avoid unused imports such as 'javax.validation.constraints.Size' 36

fr/paris/lutece/plugins/appcenter/business/Role.java

Rule Violation Line
ShortClassName Avoid short class names like Role 43119

fr/paris/lutece/plugins/appcenter/business/User.java

Rule Violation Line
ShortClassName Avoid short class names like User 41112

fr/paris/lutece/plugins/appcenter/business/UserDAO.java

Rule Violation Line
UnusedImports Avoid unused imports such as 'java.sql.Statement' 39

fr/paris/lutece/plugins/appcenter/business/prerequisite/PrerequisiteValidationConfigDAO.java

Rule Violation Line
UnusedImports Avoid unused imports such as 'java.sql.Statement' 41

fr/paris/lutece/plugins/appcenter/business/resourcetype/AbstractAppCenterResourceType.java

Rule Violation Line
UnusedImports Avoid unused imports such as 'java.util.Collection' 42

fr/paris/lutece/plugins/appcenter/service/RoleService.java

Rule Violation Line
UnusedImports Avoid unused imports such as 'fr.paris.lutece.util.ReferenceList' 44

fr/paris/lutece/plugins/appcenter/service/prerequisite/PrerequisiteValidation.java

Rule Violation Line
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.appcenter.business.organization.OrganizationManagerHome' 43

fr/paris/lutece/plugins/appcenter/service/task/AppCenterTaskFunctional.java

Rule Violation Line
GenericsNaming Generics names should be a one letter long and upper case. 45
GenericsNaming Generics names should be a one letter long and upper case. 45

fr/paris/lutece/plugins/appcenter/service/task/TaskNotify.java

Rule Violation Line
UnusedImports Avoid unused imports such as 'fr.paris.lutece.portal.service.mail.MailItem' 56

fr/paris/lutece/plugins/appcenter/service/task/TaskNotifyToValidate.java

Rule Violation Line
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.appcenter.business.organization.OrganizationManagerHome' 45

fr/paris/lutece/plugins/appcenter/service/web/task/TaskCustomDemandStatusComponent.java

Rule Violation Line
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.workflowcore.web.task.SimpleTaskComponent' 39

fr/paris/lutece/plugins/appcenter/web/AppCenterDemandXPage.java

Rule Violation Line
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.appcenter.business.Application' 38
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.appcenter.business.ApplicationDemandTypesEnable' 39
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.appcenter.business.DemandHome' 41
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.appcenter.service.ApplicationService' 43
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.appcenter.service.DemandTypeService' 44
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.workflowcore.business.state.State' 46
UnusedImports Avoid unused imports such as 'fr.paris.lutece.portal.service.admin.AccessDeniedException' 47
UnusedImports Avoid unused imports such as 'fr.paris.lutece.portal.service.workflow.WorkflowService' 52
UnusedImports Avoid unused imports such as 'java.util.HashMap' 53
UnusedImports Avoid unused imports such as 'java.util.List' 54

fr/paris/lutece/plugins/appcenter/web/ApplicationJspBean.java

Rule Violation Line
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.appcenter.business.organization.Organization' 41
UnusedImports Avoid unused imports such as 'fr.paris.lutece.util.ReferenceItem' 56
UnusedImports Avoid unused imports such as 'java.util.HashMap' 62

fr/paris/lutece/plugins/appcenter/web/DemandJspBean.java

Rule Violation Line
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.appcenter.business.ApplicationDatas' 44
UnusedImports Avoid unused imports such as 'fr.paris.lutece.portal.service.util.AppException' 64
UnusedImports Avoid unused imports such as 'java.util.Locale' 81
UnusedImports Avoid unused imports such as 'java.util.Optional' 82

fr/paris/lutece/plugins/appcenter/web/DemandTypeJspBean.java

Rule Violation Line
UnusedImports Avoid unused imports such as 'java.util.function.Function' 60

fr/paris/lutece/plugins/appcenter/web/DemandValidationXPage.java

Rule Violation Line
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.appcenter.business.organization.OrganizationManagerHome' 49

Files

fr/paris/lutece/plugins/appcenter/business/Action.java

Rule Violation Priority Line
CommentRequired Header comments are required 3 36151
CommentRequired Public method and constructor comments are required 3 4451
CommentRequired Public method and constructor comments are required 3 5356
CommentRequired Public method and constructor comments are required 3 141144
CommentRequired Public method and constructor comments are required 3 146149

fr/paris/lutece/plugins/appcenter/business/Application.java

Rule Violation Priority Line
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.appcenter.business.resourcetype.ResourceTypeValue' 4 37
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.appcenter.business.resourcetype.AbstractAppCenterResourceType' 4 38
DuplicateImports Avoid duplicate imports such as 'javax.validation.constraints.NotNull' 4 51
DuplicateImports Avoid duplicate imports such as 'javax.validation.constraints.Size' 4 52
DuplicateImports Avoid duplicate imports such as 'org.hibernate.validator.constraints.NotEmpty' 4 53
ConfusingTernary Avoid if (x != y) ..; else ..; 3 177
FormalParameterNamingConventions The method parameter name '_strCode' doesn't match '[a-z][a-zA-Z0-9]*' 1 227
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 229
ConfusingTernary Avoid if (x != y) ..; else ..; 3 229
UseLocaleWithCaseConversions When doing a String.toLowerCase()/toUpperCase() call, use a Locale 3 229
CommentRequired Public method and constructor comments are required 3 269281

fr/paris/lutece/plugins/appcenter/business/ApplicationDAO.java

Rule Violation Priority Line
TooManyMethods This class has too many methods, consider refactoring it. 3 50508
ConfusingTernary Avoid if (x != y) ..; else ..; 3 106114
ConfusingTernary Avoid if (x != y) ..; else ..; 3 227235
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 388
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 388

fr/paris/lutece/plugins/appcenter/business/ApplicationData.java

Rule Violation Priority Line
CommentRequired Header comments are required 3 39119
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 43
FormalParameterNamingConventions The method parameter name '_nIdApllicationData' doesn't match '[a-z][a-zA-Z0-9]*' 1 114

fr/paris/lutece/plugins/appcenter/business/ApplicationDatas.java

Rule Violation Priority Line
CommentRequired Header comments are required 3 4173
CommentRequired Public method and constructor comments are required 3 4548
CommentRequired Public method and constructor comments are required 3 6065

fr/paris/lutece/plugins/appcenter/business/ApplicationDemandTypesEnable.java

Rule Violation Priority Line
CommentRequired Public method and constructor comments are required 3 4851
FieldDeclarationsShouldBeAtStartOfClass Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 3 53
CommentRequired Public method and constructor comments are required 3 6568

fr/paris/lutece/plugins/appcenter/business/ApplicationUrlHome.java

Rule Violation Priority Line
UseUtilityClass All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 3 47110

fr/paris/lutece/plugins/appcenter/business/AuthorizedApp.java

Rule Violation Priority Line
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 3 3964

fr/paris/lutece/plugins/appcenter/business/CategoryAction.java

Rule Violation Priority Line
CommentRequired Header comments are required 3 39152
CommentRequired Public method and constructor comments are required 3 4652
CommentRequired Public method and constructor comments are required 3 5466

fr/paris/lutece/plugins/appcenter/business/CategoryDemandType.java

Rule Violation Priority Line
UnusedImports Avoid unused imports such as 'javax.validation.constraints' 4 36
UnusedImports Avoid unused imports such as 'org.hibernate.validator.constraints' 4 37
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 4 105108
CommentRequired Public method and constructor comments are required 3 142145
CommentRequired Public method and constructor comments are required 3 147150

fr/paris/lutece/plugins/appcenter/business/CategoryDemandTypeDAO.java

Rule Violation Priority Line
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 148
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 176

fr/paris/lutece/plugins/appcenter/business/Demand.java

Rule Violation Priority Line
UnusedImports Avoid unused imports such as 'com.fasterxml.jackson.annotation.JsonIgnoreProperties' 4 40
CommentRequired Public method and constructor comments are required 3 261265
FormalParameterNamingConventions The method parameter name '_creationTimestamp' doesn't match '[a-z][a-zA-Z0-9]*' 1 273
CommentRequired Public method and constructor comments are required 3 321324

fr/paris/lutece/plugins/appcenter/business/DemandDAO.java

Rule Violation Priority Line
TooManyMethods This class has too many methods, consider refactoring it. 3 54463
ConfusingTernary Avoid if (x != y) ..; else ..; 3 103110
ConfusingTernary Avoid if (x != y) ..; else ..; 3 192199
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 213
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 235
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 259
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 284
AvoidThrowingRawExceptionTypes Avoid throwing raw exception types. 1 342
NPathComplexity The method 'selectDemandsListByFilter(DemandFilter, Plugin)' has an NPath complexity of 2304 3 392462
CyclomaticComplexity The method 'selectDemandsListByFilter(DemandFilter, Plugin)' has a cyclomatic complexity of 14. 3 392462
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 394
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 431

fr/paris/lutece/plugins/appcenter/business/DemandHome.java

Rule Violation Priority Line
UnusedImports Avoid unused imports such as 'fr.paris.lutece.portal.service.util.AppLogService' 4 43
UnusedImports Avoid unused imports such as 'java.io.IOException' 4 46
CommentRequired Public method and constructor comments are required 3 194197

fr/paris/lutece/plugins/appcenter/business/DemandType.java

Rule Violation Priority Line
CommentRequired Public method and constructor comments are required 3 7578
CommentRequired Public method and constructor comments are required 3 205208
CommentRequired Public method and constructor comments are required 3 210213
CommentRequired Public method and constructor comments are required 3 215218
CommentRequired Public method and constructor comments are required 3 220223
CommentRequired Public method and constructor comments are required 3 225228
CommentRequired Public method and constructor comments are required 3 230233
CommentRequired Public method and constructor comments are required 3 235238
CommentRequired Public method and constructor comments are required 3 240243
CommentRequired Public method and constructor comments are required 3 245248

fr/paris/lutece/plugins/appcenter/business/DemandTypeDAO.java

Rule Violation Priority Line
UnusedImports Avoid unused imports such as 'java.util.function.Predicate' 4 43
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 163
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 208
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 243

fr/paris/lutece/plugins/appcenter/business/DemandValidation.java

Rule Violation Priority Line
CommentRequired Header comments are required 3 40151

fr/paris/lutece/plugins/appcenter/business/DemandValidationHome.java

Rule Violation Priority Line
ImportFromSamePackage No need to import a type that lives in the same package 3 36
ImportFromSamePackage No need to import a type that lives in the same package 3 37

fr/paris/lutece/plugins/appcenter/business/Documentation.java

Rule Violation Priority Line
UnusedImports Avoid unused imports such as 'org.hibernate.validator.constraints' 4 37

fr/paris/lutece/plugins/appcenter/business/DocumentationCategory.java

Rule Violation Priority Line
CommentRequired Enum comments are required 3 3899
FieldNamingConventions The final field name '_strPrefix' doesn't match '[a-z][a-zA-Z0-9]*' 1 43
FieldNamingConventions The final field name '_strLabelKey' doesn't match '[a-z][a-zA-Z0-9]*' 1 44
UnnecessaryModifier Unnecessary modifier 'private' on constructor 'DocumentationCategory(String, String)': enum constructors are implicitly private 3 5458

fr/paris/lutece/plugins/appcenter/business/DocumentationDAO.java

Rule Violation Priority Line
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 150
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 178
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 216

fr/paris/lutece/plugins/appcenter/business/Environment.java

Rule Violation Priority Line
CommentRequired Enum comments are required 3 40111
FieldNamingConventions The final field name '_strPrefix' doesn't match '[a-z][a-zA-Z0-9]*' 1 46
FieldNamingConventions The final field name '_strLabelKey' doesn't match '[a-z][a-zA-Z0-9]*' 1 47
UnnecessaryModifier Unnecessary modifier 'private' on constructor 'Environment(String, String)': enum constructors are implicitly private 3 5761

fr/paris/lutece/plugins/appcenter/business/IApplicationDAO.java

Rule Violation Priority Line
TooManyMethods This class has too many methods, consider refactoring it. 3 45183

fr/paris/lutece/plugins/appcenter/business/IDemandDAO.java

Rule Violation Priority Line
UnusedImports Avoid unused imports such as 'java.io.IOException' 4 38
TooManyMethods This class has too many methods, consider refactoring it. 3 45174

fr/paris/lutece/plugins/appcenter/business/IDemandValidationDAO.java

Rule Violation Priority Line
ImportFromSamePackage No need to import a type that lives in the same package 3 36

fr/paris/lutece/plugins/appcenter/business/IPermissionDAO.java

Rule Violation Priority Line
FormalParameterNamingConventions The method parameter name '_plugin' doesn't match '[a-z][a-zA-Z0-9]*' 1 98

fr/paris/lutece/plugins/appcenter/business/IUserApplicationRoleDAO.java

Rule Violation Priority Line
TooManyMethods This class has too many methods, consider refactoring it. 3 44179

fr/paris/lutece/plugins/appcenter/business/PermissionRole.java

Rule Violation Priority Line
UnusedImports Avoid unused imports such as 'javax.validation.constraints.Size' 4 36

fr/paris/lutece/plugins/appcenter/business/Role.java

Rule Violation Priority Line
ShortClassName Avoid short class names like Role 4 43119

fr/paris/lutece/plugins/appcenter/business/RoleDAO.java

Rule Violation Priority Line
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 174
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 200
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 238
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 238

fr/paris/lutece/plugins/appcenter/business/User.java

Rule Violation Priority Line
ShortClassName Avoid short class names like User 4 41112

fr/paris/lutece/plugins/appcenter/business/UserApplicationRoleDAO.java

Rule Violation Priority Line
TooManyMethods This class has too many methods, consider refactoring it. 3 48403
NPathComplexity The method 'selectUserApplicationRolesListByFilter(UserApplicationRoleFilter, Plugin)' has an NPath complexity of 1728 3 213282
CyclomaticComplexity The method 'selectUserApplicationRolesListByFilter(UserApplicationRoleFilter, Plugin)' has a cyclomatic complexity of 14. 3 213282

fr/paris/lutece/plugins/appcenter/business/UserDAO.java

Rule Violation Priority Line
UnusedImports Avoid unused imports such as 'java.sql.Statement' 4 39
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 136
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 161

fr/paris/lutece/plugins/appcenter/business/UserInfos.java

Rule Violation Priority Line
CommentRequired Header comments are required 3 3843

fr/paris/lutece/plugins/appcenter/business/organization/Organization.java

Rule Violation Priority Line
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 3 4283

fr/paris/lutece/plugins/appcenter/business/organization/OrganizationManager.java

Rule Violation Priority Line
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 3 42142

fr/paris/lutece/plugins/appcenter/business/prerequisite/PrerequisiteValidationConfig.java

Rule Violation Priority Line
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 3 3887
CommentRequired Header comments are required 3 3887
DefaultPackage Use explicit scoping instead of the default package private level 3 42
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the _nIdTask field if you want a default access modifier 3 42
DefaultPackage Use explicit scoping instead of the default package private level 3 43
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the _nStatus field if you want a default access modifier 3 43

fr/paris/lutece/plugins/appcenter/business/prerequisite/PrerequisiteValidationConfigDAO.java

Rule Violation Priority Line
UnusedImports Avoid unused imports such as 'java.sql.Statement' 4 41
CommentRequired Header comments are required 3 43120

fr/paris/lutece/plugins/appcenter/business/resourcetype/AbstractAppCenterResourceType.java

Rule Violation Priority Line
UnusedImports Avoid unused imports such as 'java.util.Collection' 4 42
CommentRequired Header comments are required 3 4561

fr/paris/lutece/plugins/appcenter/business/resourcetype/ApplicationResourceType.java

Rule Violation Priority Line
CommentRequired Header comments are required 3 4587

fr/paris/lutece/plugins/appcenter/business/resourcetype/EnvironmentResourceType.java

Rule Violation Priority Line
CommentRequired Header comments are required 3 4680

fr/paris/lutece/plugins/appcenter/business/resourcetype/IAppCenterResourceType.java

Rule Violation Priority Line
CommentRequired Header comments are required 3 3861
UnnecessaryModifier Unnecessary modifier 'public' on method 'getRessourceTypeKey': the method is declared in an interface type 3 45
UnnecessaryModifier Unnecessary modifier 'public' on method 'getRessourceTypeLabel': the method is declared in an interface type 3 52
UnnecessaryModifier Unnecessary modifier 'public' on method 'getResourceTypeValues': the method is declared in an interface type 3 59

fr/paris/lutece/plugins/appcenter/business/resourcetype/ResourceTypeValue.java

Rule Violation Priority Line
CommentRequired Header comments are required 3 4188

fr/paris/lutece/plugins/appcenter/business/task/CustomDemandStatusTaskConfigDAO.java

Rule Violation Priority Line
UnusedPrivateField Avoid unused private fields such as 'SQL_QUERY_NEW_PK'. 3 45

fr/paris/lutece/plugins/appcenter/business/task/NotifyTaskConfig.java

Rule Violation Priority Line
CommentRequired Header comments are required 3 38148
DefaultPackage Use explicit scoping instead of the default package private level 3 40
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the _strNotificationType field if you want a default access modifier 3 40
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the _nIdMailingList field if you want a default access modifier 3 41
DefaultPackage Use explicit scoping instead of the default package private level 3 41
DefaultPackage Use explicit scoping instead of the default package private level 3 42
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the _strSubject field if you want a default access modifier 3 42
DefaultPackage Use explicit scoping instead of the default package private level 3 43
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the _strMessage field if you want a default access modifier 3 43
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the _strSenderName field if you want a default access modifier 3 44
DefaultPackage Use explicit scoping instead of the default package private level 3 44

fr/paris/lutece/plugins/appcenter/business/userinfos/GitlabUserInfo.java

Rule Violation Priority Line
CommentRequired Header comments are required 3 3976
CommentRequired Public method and constructor comments are required 3 4448
CallSuperInConstructor It is a good practice to call super() in a constructor 3 4448
CommentRequired Public method and constructor comments are required 3 5053
CommentRequired Public method and constructor comments are required 3 5558
CommentRequired Public method and constructor comments are required 3 6063
CommentRequired Public method and constructor comments are required 3 6568

fr/paris/lutece/plugins/appcenter/business/userinfos/SvnUserInfo.java

Rule Violation Priority Line
CommentRequired Header comments are required 3 3976
CallSuperInConstructor It is a good practice to call super() in a constructor 3 4448
CommentRequired Public method and constructor comments are required 3 4448
CommentRequired Public method and constructor comments are required 3 5053
CommentRequired Public method and constructor comments are required 3 5558
CommentRequired Public method and constructor comments are required 3 6063
CommentRequired Public method and constructor comments are required 3 6568

fr/paris/lutece/plugins/appcenter/service/ActionService.java

Rule Violation Priority Line
CommentRequired Header comments are required 3 51105
UseUtilityClass All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 3 52105

fr/paris/lutece/plugins/appcenter/service/AppcenterAsynchronousUploadHandler.java

Rule Violation Priority Line
CommentRequired Header comments are required 3 56277
ShortVariable Avoid variables with short names like s 3 243
ControlStatementBraces This statement should have braces 3 245
CommentRequired Public method and constructor comments are required 3 249261
CommentRequired Public method and constructor comments are required 3 263275

fr/paris/lutece/plugins/appcenter/service/AppcenterPlugin.java

Rule Violation Priority Line
CommentRequired Header comments are required 3 4056
UncommentedEmptyMethodBody Document empty method body 3 4950
CommentRequired Public method and constructor comments are required 3 5255

fr/paris/lutece/plugins/appcenter/service/ApplicationPermissionProvider.java

Rule Violation Priority Line
CommentRequired Header comments are required 3 4695
AvoidDuplicateLiterals The String literal "APP" appears 6 times in this file; the first occurrence is on line 59 3 59

fr/paris/lutece/plugins/appcenter/service/ApplicationService.java

Rule Violation Priority Line
UseUtilityClass All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 3 68301
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the getApplicationData method if you want a default access modifier 3 161175
DefaultPackage Use explicit scoping instead of the default package private level 3 161175
ConfusingTernary Avoid if (x != y) ..; else ..; 3 166173
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the getDataSubset method if you want a default access modifier 3 218228
DefaultPackage Use explicit scoping instead of the default package private level 3 218228
CommentRequired Public method and constructor comments are required 3 254278
ConfusingTernary Avoid if (x != y) ..; else ..; 3 260269
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 292

fr/paris/lutece/plugins/appcenter/service/AuthorizationService.java

Rule Violation Priority Line
UseUtilityClass All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 3 4685
CommentRequired Public method and constructor comments are required 3 4784
CyclomaticComplexity The method 'isAuthorized(String, int, String, String)' has a cyclomatic complexity of 10. 3 4784
ConfusingTernary Avoid if (x != y) ..; else ..; 3 6579
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 3 6972
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 3 7679

fr/paris/lutece/plugins/appcenter/service/DemandService.java

Rule Violation Priority Line
UseUtilityClass All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 3 60224
CommentRequired Public method and constructor comments are required 3 6879
CommentRequired Public method and constructor comments are required 3 8184
CommentRequired Public method and constructor comments are required 3 8697
ShortVariable Avoid variables with short names like it 3 162
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 3 167171
UseCollectionIsEmpty Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 3 173
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 190

fr/paris/lutece/plugins/appcenter/service/DemandTypeIdService.java

Rule Violation Priority Line
CommentRequired Header comments are required 3 4694
ShortVariable Avoid variables with short names like rt 3 59
ShortVariable Avoid variables with short names like p 3 65

fr/paris/lutece/plugins/appcenter/service/DemandTypeService.java

Rule Violation Priority Line
CommentRequired Header comments are required 3 47124
UseUtilityClass All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 3 48124
FieldNamingConventions The static field name 'KEY_SUPER_ADMIN_ROLE' doesn't match '_[a-z][a-zA-Z0-9]*' 1 50
CommentRequired Public method and constructor comments are required 3 5255
CommentRequired Public method and constructor comments are required 3 5760
CommentRequired Public method and constructor comments are required 3 6281
UnnecessaryLocalBeforeReturn Consider simply returning the value vs storing it in local variable 'className' 3 72

fr/paris/lutece/plugins/appcenter/service/EnvironmentService.java

Rule Violation Priority Line
CommentRequired Header comments are required 3 4265
UseUtilityClass All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 3 4365

fr/paris/lutece/plugins/appcenter/service/IPermissionProvider.java

Rule Violation Priority Line
CommentRequired Header comments are required 3 4452
UnnecessaryModifier Unnecessary modifier 'public' on method 'providePermissionList': the method is declared in an interface type 3 51

fr/paris/lutece/plugins/appcenter/service/PermissionService.java

Rule Violation Priority Line
CommentRequired Header comments are required 3 4680
UseUtilityClass All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 3 4780

fr/paris/lutece/plugins/appcenter/service/ResourceTypeConfig.java

Rule Violation Priority Line
CommentRequired Header comments are required 3 3993
DefaultPackage Use explicit scoping instead of the default package private level 3 41
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the _mapResourceType field if you want a default access modifier 3 41

fr/paris/lutece/plugins/appcenter/service/ResourceTypeService.java

Rule Violation Priority Line
CommentRequired Header comments are required 3 4574
UseUtilityClass All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 3 4674

fr/paris/lutece/plugins/appcenter/service/RoleService.java

Rule Violation Priority Line
UnusedImports Avoid unused imports such as 'fr.paris.lutece.util.ReferenceList' 4 44
CommentRequired Header comments are required 3 4656
UseUtilityClass All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 3 4756
CommentRequired Public method and constructor comments are required 3 5055
UnnecessaryLocalBeforeReturn Consider simply returning the value vs storing it in local variable 'ownerRole' 3 54

fr/paris/lutece/plugins/appcenter/service/UserService.java

Rule Violation Priority Line
UseUtilityClass All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 3 59343
ConfusingTernary Avoid if (x != y) ..; else ..; 3 125140
DefaultPackage Use explicit scoping instead of the default package private level 3 293316
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the getUserInfo method if you want a default access modifier 3 293316
ConfusingTernary Avoid if (x != y) ..; else ..; 3 307314
DefaultPackage Use explicit scoping instead of the default package private level 3 331341
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the getDataSubset method if you want a default access modifier 3 331341

fr/paris/lutece/plugins/appcenter/service/prerequisite/PrerequisiteValidation.java

Rule Violation Priority Line
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.appcenter.business.organization.OrganizationManagerHome' 4 43
CommentRequired Header comments are required 3 62153
MissingOverride The method 'getPrerequisiteType()' is missing an @Override annotation. 3 7376
CommentRequired Public method and constructor comments are required 3 7376
MissingOverride The method 'getTitleI18nKey()' is missing an @Override annotation. 3 7881
CommentRequired Public method and constructor comments are required 3 7881
MissingOverride The method 'hasConfiguration()' is missing an @Override annotation. 3 8386
CommentRequired Public method and constructor comments are required 3 8386
MissingOverride The method 'getEmptyConfiguration()' is missing an @Override annotation. 3 8891
CommentRequired Public method and constructor comments are required 3 8891
MissingOverride The method 'getConfigurationDaoBeanName()' is missing an @Override annotation. 3 9396
CommentRequired Public method and constructor comments are required 3 9396
CommentRequired Public method and constructor comments are required 3 98106
MissingOverride The method 'getConfigHtml(IPrerequisiteConfig, HttpServletRequest, Locale)' is missing an @Override annotation. 3 98106
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 100
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 100

fr/paris/lutece/plugins/appcenter/service/task/AppCenterTaskFunctional.java

Rule Violation Priority Line
CommentRequired Header comments are required 3 4550
GenericsNaming Generics names should be a one letter long and upper case. 4 45
GenericsNaming Generics names should be a one letter long and upper case. 4 45
CommentRequired Public method and constructor comments are required 3 48

fr/paris/lutece/plugins/appcenter/service/task/AppcenterTask.java

Rule Violation Priority Line
CyclomaticComplexity The method 'processTask(int, HttpServletRequest, Locale, Class, Class, Class, AppCenterTaskFunctional)' has a cyclomatic complexity of 11. 3 90167
AvoidThrowingRawExceptionTypes Avoid throwing raw exception types. 1 108
ShortVariable Avoid variables with short names like it 3 150

fr/paris/lutece/plugins/appcenter/service/task/TaskCloseDemand.java

Rule Violation Priority Line
CommentRequired Header comments are required 3 4575

fr/paris/lutece/plugins/appcenter/service/task/TaskCustomDemandStatus.java

Rule Violation Priority Line
CommentRequired Header comments are required 3 4881
FieldNamingConventions The final field name '_taskConfigService' doesn't match '[a-z][a-zA-Z0-9]*' 1 50

fr/paris/lutece/plugins/appcenter/service/task/TaskNotify.java

Rule Violation Priority Line
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 3 34174
UnusedImports Avoid unused imports such as 'fr.paris.lutece.portal.service.mail.MailItem' 4 56
CommentRequired Header comments are required 3 70174
UnusedFormalParameter Avoid unused method parameters such as 'request'. 3 112
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 114
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 114
SwitchStmtsShouldHaveDefault Switch statements should have a default label 3 142169
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 3 150
UseEqualsToCompareStrings Use equals() to compare strings instead of '==' or '!=' 3 150

fr/paris/lutece/plugins/appcenter/service/task/TaskNotifyToValidate.java

Rule Violation Priority Line
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.appcenter.business.organization.OrganizationManagerHome' 4 45
CommentRequired Header comments are required 3 65158
UnusedPrivateField Avoid unused private fields such as 'SLASH'. 3 85
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 129
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 129

fr/paris/lutece/plugins/appcenter/service/web/task/TaskCustomDemandStatusComponent.java

Rule Violation Priority Line
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.workflowcore.web.task.SimpleTaskComponent' 4 39
CommentRequired Header comments are required 3 51122
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 63
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 63
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 2 82
ShortVariable Avoid variables with short names like i 3 92
ShortVariable Avoid variables with short names like i 3 100
ShortVariable Avoid variables with short names like i 3 109
ShortVariable Avoid variables with short names like i 3 118

fr/paris/lutece/plugins/appcenter/service/web/task/TaskNotifyComponent.java

Rule Violation Priority Line
ShortVariable Avoid variables with short names like i 3 82
CommentRequired Public method and constructor comments are required 3 8790
ShortVariable Avoid variables with short names like i 3 87
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 95
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 95
ShortVariable Avoid variables with short names like i 3 107
ConfusingTernary Avoid if (x != y) ..; else ..; 3 132169
DefaultPackage Use explicit scoping instead of the default package private level 3 174190
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the populate method if you want a default access modifier 3 174190

fr/paris/lutece/plugins/appcenter/service/web/task/TaskNotifyToValidateComponent.java

Rule Violation Priority Line
CommentRequired Header comments are required 3 55149
ShortVariable Avoid variables with short names like i 3 69
CommentRequired Public method and constructor comments are required 3 7477
ShortVariable Avoid variables with short names like i 3 74
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 82
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 82
ShortVariable Avoid variables with short names like i 3 93
ConfusingTernary Avoid if (x != y) ..; else ..; 3 118145

fr/paris/lutece/plugins/appcenter/util/AppCenterUtils.java

Rule Violation Priority Line
CommentRequired Header comments are required 3 4175
UseUtilityClass All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 3 4275

fr/paris/lutece/plugins/appcenter/util/CryptoUtil.java

Rule Violation Priority Line
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the PROPERTY_CRYPTO_KEY field if you want a default access modifier 3 62
DefaultPackage Use explicit scoping instead of the default package private level 3 62
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the DSKEY_CRYPTO_KEY field if you want a default access modifier 3 63
DefaultPackage Use explicit scoping instead of the default package private level 3 63
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 115
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 145
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 168
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 3 218228
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 3 220
AppendCharacterWithChar Avoid appending characters as strings in StringBuffer.append. 3 223

fr/paris/lutece/plugins/appcenter/web/AppCenterDemandXPage.java

Rule Violation Priority Line
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.appcenter.business.Application' 4 38
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.appcenter.business.ApplicationDemandTypesEnable' 4 39
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.appcenter.business.DemandHome' 4 41
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.appcenter.service.ApplicationService' 4 43
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.appcenter.service.DemandTypeService' 4 44
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.workflowcore.business.state.State' 4 46
UnusedImports Avoid unused imports such as 'fr.paris.lutece.portal.service.admin.AccessDeniedException' 4 47
UnusedImports Avoid unused imports such as 'fr.paris.lutece.portal.service.workflow.WorkflowService' 4 52
UnusedImports Avoid unused imports such as 'java.util.HashMap' 4 53
UnusedImports Avoid unused imports such as 'java.util.List' 4 54
ConfusingTernary Avoid if (x != y) ..; else ..; 3 86
UnusedLocalVariable Avoid unused local variables such as 'session'. 3 90
CommentRequired Protected method constructor comments are required 3 110
CommentRequired Protected method constructor comments are required 3 112
CommentRequired Protected method constructor comments are required 3 114

fr/paris/lutece/plugins/appcenter/web/AppCenterXPage.java

Rule Violation Priority Line
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 3 34348
UnusedPrivateField Avoid unused private fields such as 'ERROR_APP_NOT_FOUND'. 3 89
UnusedPrivateField Avoid unused private fields such as 'ERROR_INVALID_APP_ID'. 3 91
EmptyCatchBlock Avoid empty catch blocks 3 125128
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 158
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 159
UnnecessaryLocalBeforeReturn Consider simply returning the value vs storing it in local variable 'environment' 3 183
CommentRequired Protected method constructor comments are required 3 212252
UnusedLocalVariable Avoid unused local variables such as 'session'. 3 215
CommentRequired Protected method constructor comments are required 3 254279
UnusedLocalVariable Avoid unused local variables such as 'session'. 3 259
ConfusingTernary Avoid if (x != y) ..; else ..; 3 261276
LinguisticNaming Linguistics Antipattern - The getter 'getUnauthorizedAccessMessage' should not return void linguistically 3 316319
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 338
EmptyCatchBlock Avoid empty catch blocks 3 338341
CommentRequired Protected method constructor comments are required 3 344347
EmptyMethodInAbstractClassShouldBeAbstract An empty method in an abstract class should be abstract instead 1 344347

fr/paris/lutece/plugins/appcenter/web/ApplicationJspBean.java

Rule Violation Priority Line
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 3 34546
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.appcenter.business.organization.Organization' 4 41
UnusedImports Avoid unused imports such as 'fr.paris.lutece.util.ReferenceItem' 4 56
UnusedImports Avoid unused imports such as 'java.util.HashMap' 4 62
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 3 76546
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 170
ConfusingTernary Avoid if (x != y) ..; else ..; 3 234
ConfusingTernary Avoid if (x != y) ..; else ..; 3 398399
CyclomaticComplexity The method 'doSendApplicationMail(HttpServletRequest)' has a cyclomatic complexity of 12. 3 444516
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 450
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 451
PositionLiteralsFirstInComparisons Position literals first in String comparisons 3 462
PositionLiteralsFirstInComparisons Position literals first in String comparisons 3 471

fr/paris/lutece/plugins/appcenter/web/ApplicationUrlXPage.java

Rule Violation Priority Line
CommentRequired Public method and constructor comments are required 3 98120
ConfusingTernary Avoid if (x != y) ..; else ..; 3 126133
UseLocaleWithCaseConversions When doing a String.toLowerCase()/toUpperCase() call, use a Locale 3 129
CommentRequired Public method and constructor comments are required 3 139156
ConfusingTernary Avoid if (x != y) ..; else ..; 3 144150
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 151
CommentRequired Public method and constructor comments are required 3 159174
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 169

fr/paris/lutece/plugins/appcenter/web/ApplicationXPage.java

Rule Violation Priority Line
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 3 34667
TooManyStaticImports Too many static imports may lead to messy code 3 34667
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 3 109667
UnusedPrivateField Avoid unused private fields such as 'ERROR_USER_ROLE_NOT_AUTHORIZED'. 3 157
CommentRequired Public method and constructor comments are required 3 185206
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 187
ConfusingTernary Avoid if (x != y) ..; else ..; 3 218
AvoidDuplicateLiterals The String literal "demandtype_" appears 4 times in this file; the first occurrence is on line 276 3 276
UseEqualsToCompareStrings Use equals() to compare strings instead of '==' or '!=' 3 380
ConfusingTernary Avoid if (x != y) ..; else ..; 3 380391
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 3 380
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 411
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 412
CommentRequired Public method and constructor comments are required 3 433476
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 457
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 458
CyclomaticComplexity The method 'doModifyApplication(HttpServletRequest)' has a cyclomatic complexity of 10. 3 486541
UnusedLocalVariable Avoid unused local variables such as 'application'. 3 598

fr/paris/lutece/plugins/appcenter/web/Constants.java

Rule Violation Priority Line
ClassNamingConventions The utility class name 'Constants' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' 1 3975

fr/paris/lutece/plugins/appcenter/web/DemandJspBean.java

Rule Violation Priority Line
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 3 34559
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.appcenter.business.ApplicationDatas' 4 44
UnusedImports Avoid unused imports such as 'fr.paris.lutece.portal.service.util.AppException' 4 64
UnusedImports Avoid unused imports such as 'java.util.Locale' 4 81
UnusedImports Avoid unused imports such as 'java.util.Optional' 4 82
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 3 88559
ImmutableField Private field '_stateService' could be made final; it is only initialized in the declaration or constructor. 3 157
CyclomaticComplexity The method 'getManageDemands(HttpServletRequest)' has a cyclomatic complexity of 23. 3 169346
ExcessiveMethodLength Avoid really long methods. 3 169346
NPathComplexity The method 'getManageDemands(HttpServletRequest)' has an NPath complexity of 28672 3 169346
NcssCount The method 'getManageDemands(HttpServletRequest)' has a NCSS line count of 96. 3 169346
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 185
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 186
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 187
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 189
ShortVariable Avoid variables with short names like c 3 287
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 372
ConfusingTernary Avoid if (x != y) ..; else ..; 3 373
ConfusingTernary Avoid if (x != y) ..; else ..; 3 374
ConfusingTernary Avoid if (x != y) ..; else ..; 3 412
ConfusingTernary Avoid if (x != y) ..; else ..; 3 447
ConfusingTernary Avoid if (x != y) ..; else ..; 3 448
ConfusingTernary Avoid if (x != y) ..; else ..; 3 471
ConfusingTernary Avoid if (x != y) ..; else ..; 3 472
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 488
CommentRequired Public method and constructor comments are required 3 539558

fr/paris/lutece/plugins/appcenter/web/DemandTypeJspBean.java

Rule Violation Priority Line
UnusedImports Avoid unused imports such as 'java.util.function.Function' 4 60
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 3 68793
TooManyMethods This class has too many methods, consider refactoring it. 3 69793
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 179
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 182
ConfusingTernary Avoid if (x != y) ..; else ..; 3 209
CommentRequired Public method and constructor comments are required 3 331365
ShortVariable Avoid variables with short names like it 3 345
CommentRequired Public method and constructor comments are required 3 368404
ShortVariable Avoid variables with short names like it 3 384
ConfusingTernary Avoid if (x != y) ..; else ..; 3 422
ConfusingTernary Avoid if (x != y) ..; else ..; 3 442449
CommentRequired Public method and constructor comments are required 3 543576
ShortVariable Avoid variables with short names like it 3 556
CommentRequired Public method and constructor comments are required 3 579614
ShortVariable Avoid variables with short names like it 3 594
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 626
ConfusingTernary Avoid if (x != y) ..; else ..; 3 642655
ConfusingTernary Avoid if (x != y) ..; else ..; 3 668

fr/paris/lutece/plugins/appcenter/web/DemandValidationXPage.java

Rule Violation Priority Line
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 3 34252
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.appcenter.business.organization.OrganizationManagerHome' 4 49
CommentRequired Header comments are required 3 77252
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 3 77252
ImmutableField Private field '_taskService' could be made final; it is only initialized in the declaration or constructor. 3 110
ImmutableField Private field '_actionService' could be made final; it is only initialized in the declaration or constructor. 3 111
ImmutableField Private field '_stateService' could be made final; it is only initialized in the declaration or constructor. 3 112
UnusedPrivateField Avoid unused private fields such as '_stateService'. 3 112
CyclomaticComplexity The method 'getDemandValidation(HttpServletRequest)' has a cyclomatic complexity of 12. 3 124184
NPathComplexity The method 'getDemandValidation(HttpServletRequest)' has an NPath complexity of 768 3 124184
ConfusingTernary Avoid if (x != y) ..; else ..; 3 133
ConfusingTernary Avoid if (x != y) ..; else ..; 3 134

fr/paris/lutece/plugins/appcenter/web/ManageAppCenterJspBean.java

Rule Violation Priority Line
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 3 49102
SingularField Perhaps '_nDefaultItemsPerPage' could be replaced by a local variable. 3 65
AddEmptyString Do not add empty strings 3 96

fr/paris/lutece/plugins/appcenter/web/PermissionRoleJspBean.java

Rule Violation Priority Line
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 3 57233
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 113
ConfusingTernary Avoid if (x != y) ..; else ..; 3 141

fr/paris/lutece/plugins/appcenter/web/RoleJspBean.java

Rule Violation Priority Line
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 3 53240
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 109
ConfusingTernary Avoid if (x != y) ..; else ..; 3 126

fr/paris/lutece/plugins/appcenter/web/UserApplicationRoleJspBean.java

Rule Violation Priority Line
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 3 68479
CyclomaticComplexity The method 'getManageUserApplicationRoles(HttpServletRequest)' has a cyclomatic complexity of 11. 3 151230
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 159
ShortVariable Avoid variables with short names like c 3 181
ConfusingTernary Avoid if (x != y) ..; else ..; 3 276
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 466
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 466

fr/paris/lutece/plugins/appcenter/web/UserXPage.java

Rule Violation Priority Line
CommentRequired Header comments are required 3 52144
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 3 52144
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 3 123
ControlStatementBraces This statement should have braces 3 127
ControlStatementBraces This statement should have braces 3 129

fr/paris/lutece/plugins/appcenter/web/organization/AbstractManageOrganizationJspBean.java

Rule Violation Priority Line
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 3 4997

fr/paris/lutece/plugins/appcenter/web/organization/OrganizationJspBean.java

Rule Violation Priority Line
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 3 55249
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 109
ConfusingTernary Avoid if (x != y) ..; else ..; 3 125

fr/paris/lutece/plugins/appcenter/web/organization/OrganizationManagerJspBean.java

Rule Violation Priority Line
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 3 56274
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 112
ConfusingTernary Avoid if (x != y) ..; else ..; 3 142