The following document contains the results of PMD 6.13.0.
| Rule | Violation | Line |
|---|---|---|
| FormalParameterNamingConventions | The method parameter name '_strCode' doesn't match '[a-z][a-zA-Z0-9]*' | 227 |
| Rule | Violation | Line |
|---|---|---|
| FormalParameterNamingConventions | The method parameter name '_nIdApllicationData' doesn't match '[a-z][a-zA-Z0-9]*' | 114 |
| Rule | Violation | Line |
|---|---|---|
| FormalParameterNamingConventions | The method parameter name '_creationTimestamp' doesn't match '[a-z][a-zA-Z0-9]*' | 273 |
| Rule | Violation | Line |
|---|---|---|
| AvoidThrowingRawExceptionTypes | Avoid throwing raw exception types. | 342 |
| Rule | Violation | Line |
|---|---|---|
| FieldNamingConventions | The final field name '_strPrefix' doesn't match '[a-z][a-zA-Z0-9]*' | 43 |
| FieldNamingConventions | The final field name '_strLabelKey' doesn't match '[a-z][a-zA-Z0-9]*' | 44 |
| Rule | Violation | Line |
|---|---|---|
| FieldNamingConventions | The final field name '_strPrefix' doesn't match '[a-z][a-zA-Z0-9]*' | 46 |
| FieldNamingConventions | The final field name '_strLabelKey' doesn't match '[a-z][a-zA-Z0-9]*' | 47 |
| Rule | Violation | Line |
|---|---|---|
| FormalParameterNamingConventions | The method parameter name '_plugin' doesn't match '[a-z][a-zA-Z0-9]*' | 98 |
| Rule | Violation | Line |
|---|---|---|
| FieldNamingConventions | The static field name 'KEY_SUPER_ADMIN_ROLE' doesn't match '_[a-z][a-zA-Z0-9]*' | 50 |
| Rule | Violation | Line |
|---|---|---|
| AvoidThrowingRawExceptionTypes | Avoid throwing raw exception types. | 108 |
| Rule | Violation | Line |
|---|---|---|
| FieldNamingConventions | The final field name '_taskConfigService' doesn't match '[a-z][a-zA-Z0-9]*' | 50 |
| Rule | Violation | Line |
|---|---|---|
| EmptyMethodInAbstractClassShouldBeAbstract | An empty method in an abstract class should be abstract instead | 344–347 |
| Rule | Violation | Line |
|---|---|---|
| ClassNamingConventions | The utility class name 'Constants' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' | 39–75 |
| Rule | Violation | Line |
|---|---|---|
| AvoidBranchingStatementAsLastInLoop | Avoid using a branching statement as the last in a loop. | 82 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 36–151 |
| CommentRequired | Public method and constructor comments are required | 44–51 |
| CommentRequired | Public method and constructor comments are required | 53–56 |
| CommentRequired | Public method and constructor comments are required | 141–144 |
| CommentRequired | Public method and constructor comments are required | 146–149 |
| Rule | Violation | Line |
|---|---|---|
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 177 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 229 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 229 |
| UseLocaleWithCaseConversions | When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 229 |
| CommentRequired | Public method and constructor comments are required | 269–281 |
| Rule | Violation | Line |
|---|---|---|
| TooManyMethods | This class has too many methods, consider refactoring it. | 50–508 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 106–114 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 227–235 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 388 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 388 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 39–119 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 43 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 41–73 |
| CommentRequired | Public method and constructor comments are required | 45–48 |
| CommentRequired | Public method and constructor comments are required | 60–65 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Public method and constructor comments are required | 48–51 |
| FieldDeclarationsShouldBeAtStartOfClass | Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 53 |
| CommentRequired | Public method and constructor comments are required | 65–68 |
| Rule | Violation | Line |
|---|---|---|
| UseUtilityClass | All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. | 47–110 |
| Rule | Violation | Line |
|---|---|---|
| MissingSerialVersionUID | Classes implementing Serializable should set a serialVersionUID | 39–64 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 39–152 |
| CommentRequired | Public method and constructor comments are required | 46–52 |
| CommentRequired | Public method and constructor comments are required | 54–66 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Public method and constructor comments are required | 142–145 |
| CommentRequired | Public method and constructor comments are required | 147–150 |
| Rule | Violation | Line |
|---|---|---|
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 148 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 176 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Public method and constructor comments are required | 261–265 |
| CommentRequired | Public method and constructor comments are required | 321–324 |
| Rule | Violation | Line |
|---|---|---|
| TooManyMethods | This class has too many methods, consider refactoring it. | 54–463 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 103–110 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 192–199 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 213 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 235 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 259 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 284 |
| NPathComplexity | The method 'selectDemandsListByFilter(DemandFilter, Plugin)' has an NPath complexity of 2304 | 392–462 |
| CyclomaticComplexity | The method 'selectDemandsListByFilter(DemandFilter, Plugin)' has a cyclomatic complexity of 14. | 392–462 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 394 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 431 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Public method and constructor comments are required | 194–197 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Public method and constructor comments are required | 75–78 |
| CommentRequired | Public method and constructor comments are required | 205–208 |
| CommentRequired | Public method and constructor comments are required | 210–213 |
| CommentRequired | Public method and constructor comments are required | 215–218 |
| CommentRequired | Public method and constructor comments are required | 220–223 |
| CommentRequired | Public method and constructor comments are required | 225–228 |
| CommentRequired | Public method and constructor comments are required | 230–233 |
| CommentRequired | Public method and constructor comments are required | 235–238 |
| CommentRequired | Public method and constructor comments are required | 240–243 |
| CommentRequired | Public method and constructor comments are required | 245–248 |
| Rule | Violation | Line |
|---|---|---|
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 163 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 208 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 243 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 40–151 |
| Rule | Violation | Line |
|---|---|---|
| ImportFromSamePackage | No need to import a type that lives in the same package | 36 |
| ImportFromSamePackage | No need to import a type that lives in the same package | 37 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Enum comments are required | 38–99 |
| UnnecessaryModifier | Unnecessary modifier 'private' on constructor 'DocumentationCategory(String, String)': enum constructors are implicitly private | 54–58 |
| Rule | Violation | Line |
|---|---|---|
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 150 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 178 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 216 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Enum comments are required | 40–111 |
| UnnecessaryModifier | Unnecessary modifier 'private' on constructor 'Environment(String, String)': enum constructors are implicitly private | 57–61 |
| Rule | Violation | Line |
|---|---|---|
| TooManyMethods | This class has too many methods, consider refactoring it. | 45–183 |
| Rule | Violation | Line |
|---|---|---|
| TooManyMethods | This class has too many methods, consider refactoring it. | 45–174 |
| Rule | Violation | Line |
|---|---|---|
| ImportFromSamePackage | No need to import a type that lives in the same package | 36 |
| Rule | Violation | Line |
|---|---|---|
| TooManyMethods | This class has too many methods, consider refactoring it. | 44–179 |
| Rule | Violation | Line |
|---|---|---|
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 174 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 200 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 238 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 238 |
| Rule | Violation | Line |
|---|---|---|
| TooManyMethods | This class has too many methods, consider refactoring it. | 48–403 |
| NPathComplexity | The method 'selectUserApplicationRolesListByFilter(UserApplicationRoleFilter, Plugin)' has an NPath complexity of 1728 | 213–282 |
| CyclomaticComplexity | The method 'selectUserApplicationRolesListByFilter(UserApplicationRoleFilter, Plugin)' has a cyclomatic complexity of 14. | 213–282 |
| Rule | Violation | Line |
|---|---|---|
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 136 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 161 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 38–43 |
| Rule | Violation | Line |
|---|---|---|
| MissingSerialVersionUID | Classes implementing Serializable should set a serialVersionUID | 42–83 |
| Rule | Violation | Line |
|---|---|---|
| MissingSerialVersionUID | Classes implementing Serializable should set a serialVersionUID | 42–142 |
| Rule | Violation | Line |
|---|---|---|
| MissingSerialVersionUID | Classes implementing Serializable should set a serialVersionUID | 38–87 |
| CommentRequired | Header comments are required | 38–87 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 42 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the _nIdTask field if you want a default access modifier | 42 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 43 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the _nStatus field if you want a default access modifier | 43 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 43–120 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 45–61 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 45–87 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 46–80 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 38–61 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getRessourceTypeKey': the method is declared in an interface type | 45 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getRessourceTypeLabel': the method is declared in an interface type | 52 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getResourceTypeValues': the method is declared in an interface type | 59 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 41–88 |
| Rule | Violation | Line |
|---|---|---|
| UnusedPrivateField | Avoid unused private fields such as 'SQL_QUERY_NEW_PK'. | 45 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 38–148 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 40 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the _strNotificationType field if you want a default access modifier | 40 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the _nIdMailingList field if you want a default access modifier | 41 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 41 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 42 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the _strSubject field if you want a default access modifier | 42 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 43 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the _strMessage field if you want a default access modifier | 43 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the _strSenderName field if you want a default access modifier | 44 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 44 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 39–76 |
| CommentRequired | Public method and constructor comments are required | 44–48 |
| CallSuperInConstructor | It is a good practice to call super() in a constructor | 44–48 |
| CommentRequired | Public method and constructor comments are required | 50–53 |
| CommentRequired | Public method and constructor comments are required | 55–58 |
| CommentRequired | Public method and constructor comments are required | 60–63 |
| CommentRequired | Public method and constructor comments are required | 65–68 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 39–76 |
| CallSuperInConstructor | It is a good practice to call super() in a constructor | 44–48 |
| CommentRequired | Public method and constructor comments are required | 44–48 |
| CommentRequired | Public method and constructor comments are required | 50–53 |
| CommentRequired | Public method and constructor comments are required | 55–58 |
| CommentRequired | Public method and constructor comments are required | 60–63 |
| CommentRequired | Public method and constructor comments are required | 65–68 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 51–105 |
| UseUtilityClass | All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. | 52–105 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 56–277 |
| ShortVariable | Avoid variables with short names like s | 243 |
| ControlStatementBraces | This statement should have braces | 245 |
| CommentRequired | Public method and constructor comments are required | 249–261 |
| CommentRequired | Public method and constructor comments are required | 263–275 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 40–56 |
| UncommentedEmptyMethodBody | Document empty method body | 49–50 |
| CommentRequired | Public method and constructor comments are required | 52–55 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 46–95 |
| AvoidDuplicateLiterals | The String literal "APP" appears 6 times in this file; the first occurrence is on line 59 | 59 |
| Rule | Violation | Line |
|---|---|---|
| UseUtilityClass | All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. | 68–301 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the getApplicationData method if you want a default access modifier | 161–175 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 161–175 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 166–173 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the getDataSubset method if you want a default access modifier | 218–228 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 218–228 |
| CommentRequired | Public method and constructor comments are required | 254–278 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 260–269 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 292 |
| Rule | Violation | Line |
|---|---|---|
| UseUtilityClass | All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. | 46–85 |
| CommentRequired | Public method and constructor comments are required | 47–84 |
| CyclomaticComplexity | The method 'isAuthorized(String, int, String, String)' has a cyclomatic complexity of 10. | 47–84 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 65–79 |
| AvoidDeeplyNestedIfStmts | Deeply nested if..then statements are hard to read | 69–72 |
| AvoidDeeplyNestedIfStmts | Deeply nested if..then statements are hard to read | 76–79 |
| Rule | Violation | Line |
|---|---|---|
| UseUtilityClass | All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. | 60–224 |
| CommentRequired | Public method and constructor comments are required | 68–79 |
| CommentRequired | Public method and constructor comments are required | 81–84 |
| CommentRequired | Public method and constructor comments are required | 86–97 |
| ShortVariable | Avoid variables with short names like it | 162 |
| AvoidDeeplyNestedIfStmts | Deeply nested if..then statements are hard to read | 167–171 |
| UseCollectionIsEmpty | Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() | 173 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 190 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 46–94 |
| ShortVariable | Avoid variables with short names like rt | 59 |
| ShortVariable | Avoid variables with short names like p | 65 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 47–124 |
| UseUtilityClass | All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. | 48–124 |
| CommentRequired | Public method and constructor comments are required | 52–55 |
| CommentRequired | Public method and constructor comments are required | 57–60 |
| CommentRequired | Public method and constructor comments are required | 62–81 |
| UnnecessaryLocalBeforeReturn | Consider simply returning the value vs storing it in local variable 'className' | 72 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 42–65 |
| UseUtilityClass | All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. | 43–65 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 44–52 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'providePermissionList': the method is declared in an interface type | 51 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 46–80 |
| UseUtilityClass | All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. | 47–80 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 39–93 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 41 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the _mapResourceType field if you want a default access modifier | 41 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 45–74 |
| UseUtilityClass | All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. | 46–74 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 46–56 |
| UseUtilityClass | All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. | 47–56 |
| CommentRequired | Public method and constructor comments are required | 50–55 |
| UnnecessaryLocalBeforeReturn | Consider simply returning the value vs storing it in local variable 'ownerRole' | 54 |
| Rule | Violation | Line |
|---|---|---|
| UseUtilityClass | All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. | 59–343 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 125–140 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 293–316 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the getUserInfo method if you want a default access modifier | 293–316 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 307–314 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 331–341 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the getDataSubset method if you want a default access modifier | 331–341 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 62–153 |
| MissingOverride | The method 'getPrerequisiteType()' is missing an @Override annotation. | 73–76 |
| CommentRequired | Public method and constructor comments are required | 73–76 |
| MissingOverride | The method 'getTitleI18nKey()' is missing an @Override annotation. | 78–81 |
| CommentRequired | Public method and constructor comments are required | 78–81 |
| MissingOverride | The method 'hasConfiguration()' is missing an @Override annotation. | 83–86 |
| CommentRequired | Public method and constructor comments are required | 83–86 |
| MissingOverride | The method 'getEmptyConfiguration()' is missing an @Override annotation. | 88–91 |
| CommentRequired | Public method and constructor comments are required | 88–91 |
| MissingOverride | The method 'getConfigurationDaoBeanName()' is missing an @Override annotation. | 93–96 |
| CommentRequired | Public method and constructor comments are required | 93–96 |
| CommentRequired | Public method and constructor comments are required | 98–106 |
| MissingOverride | The method 'getConfigHtml(IPrerequisiteConfig, HttpServletRequest, Locale)' is missing an @Override annotation. | 98–106 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 100 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 100 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 45–50 |
| CommentRequired | Public method and constructor comments are required | 48 |
| Rule | Violation | Line |
|---|---|---|
| CyclomaticComplexity | The method 'processTask(int, HttpServletRequest, Locale, Class, Class, Class, AppCenterTaskFunctional)' has a cyclomatic complexity of 11. | 90–167 |
| ShortVariable | Avoid variables with short names like it | 150 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 45–75 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 48–81 |
| Rule | Violation | Line |
|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 34–174 |
| CommentRequired | Header comments are required | 70–174 |
| UnusedFormalParameter | Avoid unused method parameters such as 'request'. | 112 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 114 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 114 |
| SwitchStmtsShouldHaveDefault | Switch statements should have a default label | 142–169 |
| AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 150 |
| UseEqualsToCompareStrings | Use equals() to compare strings instead of '==' or '!=' | 150 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 65–158 |
| UnusedPrivateField | Avoid unused private fields such as 'SLASH'. | 85 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 129 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 129 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 51–122 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 63 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 63 |
| ShortVariable | Avoid variables with short names like i | 92 |
| ShortVariable | Avoid variables with short names like i | 100 |
| ShortVariable | Avoid variables with short names like i | 109 |
| ShortVariable | Avoid variables with short names like i | 118 |
| Rule | Violation | Line |
|---|---|---|
| ShortVariable | Avoid variables with short names like i | 82 |
| CommentRequired | Public method and constructor comments are required | 87–90 |
| ShortVariable | Avoid variables with short names like i | 87 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 95 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 95 |
| ShortVariable | Avoid variables with short names like i | 107 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 132–169 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 174–190 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the populate method if you want a default access modifier | 174–190 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 55–149 |
| ShortVariable | Avoid variables with short names like i | 69 |
| CommentRequired | Public method and constructor comments are required | 74–77 |
| ShortVariable | Avoid variables with short names like i | 74 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 82 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 82 |
| ShortVariable | Avoid variables with short names like i | 93 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 118–145 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 41–75 |
| UseUtilityClass | All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. | 42–75 |
| Rule | Violation | Line |
|---|---|---|
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the PROPERTY_CRYPTO_KEY field if you want a default access modifier | 62 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 62 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the DSKEY_CRYPTO_KEY field if you want a default access modifier | 63 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 63 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 115 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 145 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 168 |
| ForLoopCanBeForeach | This for loop can be replaced by a foreach loop | 218–228 |
| AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 220 |
| AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 223 |
| Rule | Violation | Line |
|---|---|---|
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 86 |
| UnusedLocalVariable | Avoid unused local variables such as 'session'. | 90 |
| CommentRequired | Protected method constructor comments are required | 110 |
| CommentRequired | Protected method constructor comments are required | 112 |
| CommentRequired | Protected method constructor comments are required | 114 |
| Rule | Violation | Line |
|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 34–348 |
| UnusedPrivateField | Avoid unused private fields such as 'ERROR_APP_NOT_FOUND'. | 89 |
| UnusedPrivateField | Avoid unused private fields such as 'ERROR_INVALID_APP_ID'. | 91 |
| EmptyCatchBlock | Avoid empty catch blocks | 125–128 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 158 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 159 |
| UnnecessaryLocalBeforeReturn | Consider simply returning the value vs storing it in local variable 'environment' | 183 |
| CommentRequired | Protected method constructor comments are required | 212–252 |
| UnusedLocalVariable | Avoid unused local variables such as 'session'. | 215 |
| CommentRequired | Protected method constructor comments are required | 254–279 |
| UnusedLocalVariable | Avoid unused local variables such as 'session'. | 259 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 261–276 |
| LinguisticNaming | Linguistics Antipattern - The getter 'getUnauthorizedAccessMessage' should not return void linguistically | 316–319 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 338 |
| EmptyCatchBlock | Avoid empty catch blocks | 338–341 |
| CommentRequired | Protected method constructor comments are required | 344–347 |
| Rule | Violation | Line |
|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 34–546 |
| MissingSerialVersionUID | Classes implementing Serializable should set a serialVersionUID | 76–546 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 170 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 234 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 398–399 |
| CyclomaticComplexity | The method 'doSendApplicationMail(HttpServletRequest)' has a cyclomatic complexity of 12. | 444–516 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 450 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 451 |
| PositionLiteralsFirstInComparisons | Position literals first in String comparisons | 462 |
| PositionLiteralsFirstInComparisons | Position literals first in String comparisons | 471 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Public method and constructor comments are required | 98–120 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 126–133 |
| UseLocaleWithCaseConversions | When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 129 |
| CommentRequired | Public method and constructor comments are required | 139–156 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 144–150 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 151 |
| CommentRequired | Public method and constructor comments are required | 159–174 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 169 |
| Rule | Violation | Line |
|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 34–667 |
| TooManyStaticImports | Too many static imports may lead to messy code | 34–667 |
| MissingSerialVersionUID | Classes implementing Serializable should set a serialVersionUID | 109–667 |
| UnusedPrivateField | Avoid unused private fields such as 'ERROR_USER_ROLE_NOT_AUTHORIZED'. | 157 |
| CommentRequired | Public method and constructor comments are required | 185–206 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 187 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 218 |
| AvoidDuplicateLiterals | The String literal "demandtype_" appears 4 times in this file; the first occurrence is on line 276 | 276 |
| UseEqualsToCompareStrings | Use equals() to compare strings instead of '==' or '!=' | 380 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 380–391 |
| AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 380 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 411 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 412 |
| CommentRequired | Public method and constructor comments are required | 433–476 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 457 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 458 |
| CyclomaticComplexity | The method 'doModifyApplication(HttpServletRequest)' has a cyclomatic complexity of 10. | 486–541 |
| UnusedLocalVariable | Avoid unused local variables such as 'application'. | 598 |
| Rule | Violation | Line |
|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 34–559 |
| MissingSerialVersionUID | Classes implementing Serializable should set a serialVersionUID | 88–559 |
| ImmutableField | Private field '_stateService' could be made final; it is only initialized in the declaration or constructor. | 157 |
| CyclomaticComplexity | The method 'getManageDemands(HttpServletRequest)' has a cyclomatic complexity of 23. | 169–346 |
| ExcessiveMethodLength | Avoid really long methods. | 169–346 |
| NPathComplexity | The method 'getManageDemands(HttpServletRequest)' has an NPath complexity of 28672 | 169–346 |
| NcssCount | The method 'getManageDemands(HttpServletRequest)' has a NCSS line count of 96. | 169–346 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 185 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 186 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 187 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 189 |
| ShortVariable | Avoid variables with short names like c | 287 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 372 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 373 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 374 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 412 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 447 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 448 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 471 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 472 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 488 |
| CommentRequired | Public method and constructor comments are required | 539–558 |
| Rule | Violation | Line |
|---|---|---|
| MissingSerialVersionUID | Classes implementing Serializable should set a serialVersionUID | 68–793 |
| TooManyMethods | This class has too many methods, consider refactoring it. | 69–793 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 179 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 182 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 209 |
| CommentRequired | Public method and constructor comments are required | 331–365 |
| ShortVariable | Avoid variables with short names like it | 345 |
| CommentRequired | Public method and constructor comments are required | 368–404 |
| ShortVariable | Avoid variables with short names like it | 384 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 422 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 442–449 |
| CommentRequired | Public method and constructor comments are required | 543–576 |
| ShortVariable | Avoid variables with short names like it | 556 |
| CommentRequired | Public method and constructor comments are required | 579–614 |
| ShortVariable | Avoid variables with short names like it | 594 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 626 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 642–655 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 668 |
| Rule | Violation | Line |
|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 34–252 |
| CommentRequired | Header comments are required | 77–252 |
| MissingSerialVersionUID | Classes implementing Serializable should set a serialVersionUID | 77–252 |
| ImmutableField | Private field '_taskService' could be made final; it is only initialized in the declaration or constructor. | 110 |
| ImmutableField | Private field '_actionService' could be made final; it is only initialized in the declaration or constructor. | 111 |
| ImmutableField | Private field '_stateService' could be made final; it is only initialized in the declaration or constructor. | 112 |
| UnusedPrivateField | Avoid unused private fields such as '_stateService'. | 112 |
| CyclomaticComplexity | The method 'getDemandValidation(HttpServletRequest)' has a cyclomatic complexity of 12. | 124–184 |
| NPathComplexity | The method 'getDemandValidation(HttpServletRequest)' has an NPath complexity of 768 | 124–184 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 133 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 134 |
| Rule | Violation | Line |
|---|---|---|
| MissingSerialVersionUID | Classes implementing Serializable should set a serialVersionUID | 49–102 |
| SingularField | Perhaps '_nDefaultItemsPerPage' could be replaced by a local variable. | 65 |
| AddEmptyString | Do not add empty strings | 96 |
| Rule | Violation | Line |
|---|---|---|
| MissingSerialVersionUID | Classes implementing Serializable should set a serialVersionUID | 57–233 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 113 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 141 |
| Rule | Violation | Line |
|---|---|---|
| MissingSerialVersionUID | Classes implementing Serializable should set a serialVersionUID | 53–240 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 109 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 126 |
| Rule | Violation | Line |
|---|---|---|
| MissingSerialVersionUID | Classes implementing Serializable should set a serialVersionUID | 68–479 |
| CyclomaticComplexity | The method 'getManageUserApplicationRoles(HttpServletRequest)' has a cyclomatic complexity of 11. | 151–230 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 159 |
| ShortVariable | Avoid variables with short names like c | 181 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 276 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 466 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 466 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 52–144 |
| MissingSerialVersionUID | Classes implementing Serializable should set a serialVersionUID | 52–144 |
| UnnecessaryAnnotationValueElement | Avoid the use of value in annotations when its the only element | 123 |
| ControlStatementBraces | This statement should have braces | 127 |
| ControlStatementBraces | This statement should have braces | 129 |
| Rule | Violation | Line |
|---|---|---|
| MissingSerialVersionUID | Classes implementing Serializable should set a serialVersionUID | 49–97 |
| Rule | Violation | Line |
|---|---|---|
| MissingSerialVersionUID | Classes implementing Serializable should set a serialVersionUID | 55–249 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 109 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 125 |
| Rule | Violation | Line |
|---|---|---|
| MissingSerialVersionUID | Classes implementing Serializable should set a serialVersionUID | 56–274 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 112 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 142 |
| Rule | Violation | Line |
|---|---|---|
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.plugins.appcenter.business.resourcetype.ResourceTypeValue' | 37 |
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.plugins.appcenter.business.resourcetype.AbstractAppCenterResourceType' | 38 |
| DuplicateImports | Avoid duplicate imports such as 'javax.validation.constraints.NotNull' | 51 |
| DuplicateImports | Avoid duplicate imports such as 'javax.validation.constraints.Size' | 52 |
| DuplicateImports | Avoid duplicate imports such as 'org.hibernate.validator.constraints.NotEmpty' | 53 |
| Rule | Violation | Line |
|---|---|---|
| UnusedImports | Avoid unused imports such as 'javax.validation.constraints' | 36 |
| UnusedImports | Avoid unused imports such as 'org.hibernate.validator.constraints' | 37 |
| BooleanGetMethodName | A getX() method which returns a boolean should be named isX() | 105–108 |
| Rule | Violation | Line |
|---|---|---|
| UnusedImports | Avoid unused imports such as 'com.fasterxml.jackson.annotation.JsonIgnoreProperties' | 40 |
| Rule | Violation | Line |
|---|---|---|
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.portal.service.util.AppLogService' | 43 |
| UnusedImports | Avoid unused imports such as 'java.io.IOException' | 46 |
| Rule | Violation | Line |
|---|---|---|
| UnusedImports | Avoid unused imports such as 'java.util.function.Predicate' | 43 |
| Rule | Violation | Line |
|---|---|---|
| UnusedImports | Avoid unused imports such as 'org.hibernate.validator.constraints' | 37 |
| Rule | Violation | Line |
|---|---|---|
| UnusedImports | Avoid unused imports such as 'java.io.IOException' | 38 |
| Rule | Violation | Line |
|---|---|---|
| UnusedImports | Avoid unused imports such as 'javax.validation.constraints.Size' | 36 |
| Rule | Violation | Line |
|---|---|---|
| ShortClassName | Avoid short class names like Role | 43–119 |
| Rule | Violation | Line |
|---|---|---|
| ShortClassName | Avoid short class names like User | 41–112 |
| Rule | Violation | Line |
|---|---|---|
| UnusedImports | Avoid unused imports such as 'java.sql.Statement' | 39 |
| Rule | Violation | Line |
|---|---|---|
| UnusedImports | Avoid unused imports such as 'java.sql.Statement' | 41 |
| Rule | Violation | Line |
|---|---|---|
| UnusedImports | Avoid unused imports such as 'java.util.Collection' | 42 |
| Rule | Violation | Line |
|---|---|---|
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.util.ReferenceList' | 44 |
| Rule | Violation | Line |
|---|---|---|
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.plugins.appcenter.business.organization.OrganizationManagerHome' | 43 |
| Rule | Violation | Line |
|---|---|---|
| GenericsNaming | Generics names should be a one letter long and upper case. | 45 |
| GenericsNaming | Generics names should be a one letter long and upper case. | 45 |
| Rule | Violation | Line |
|---|---|---|
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.portal.service.mail.MailItem' | 56 |
| Rule | Violation | Line |
|---|---|---|
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.plugins.appcenter.business.organization.OrganizationManagerHome' | 45 |
| Rule | Violation | Line |
|---|---|---|
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.plugins.workflowcore.web.task.SimpleTaskComponent' | 39 |
| Rule | Violation | Line |
|---|---|---|
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.plugins.appcenter.business.Application' | 38 |
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.plugins.appcenter.business.ApplicationDemandTypesEnable' | 39 |
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.plugins.appcenter.business.DemandHome' | 41 |
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.plugins.appcenter.service.ApplicationService' | 43 |
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.plugins.appcenter.service.DemandTypeService' | 44 |
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.plugins.workflowcore.business.state.State' | 46 |
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.portal.service.admin.AccessDeniedException' | 47 |
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.portal.service.workflow.WorkflowService' | 52 |
| UnusedImports | Avoid unused imports such as 'java.util.HashMap' | 53 |
| UnusedImports | Avoid unused imports such as 'java.util.List' | 54 |
| Rule | Violation | Line |
|---|---|---|
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.plugins.appcenter.business.organization.Organization' | 41 |
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.util.ReferenceItem' | 56 |
| UnusedImports | Avoid unused imports such as 'java.util.HashMap' | 62 |
| Rule | Violation | Line |
|---|---|---|
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.plugins.appcenter.business.ApplicationDatas' | 44 |
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.portal.service.util.AppException' | 64 |
| UnusedImports | Avoid unused imports such as 'java.util.Locale' | 81 |
| UnusedImports | Avoid unused imports such as 'java.util.Optional' | 82 |
| Rule | Violation | Line |
|---|---|---|
| UnusedImports | Avoid unused imports such as 'java.util.function.Function' | 60 |
| Rule | Violation | Line |
|---|---|---|
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.plugins.appcenter.business.organization.OrganizationManagerHome' | 49 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 36–151 |
| CommentRequired | Public method and constructor comments are required | 3 | 44–51 |
| CommentRequired | Public method and constructor comments are required | 3 | 53–56 |
| CommentRequired | Public method and constructor comments are required | 3 | 141–144 |
| CommentRequired | Public method and constructor comments are required | 3 | 146–149 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.plugins.appcenter.business.resourcetype.ResourceTypeValue' | 4 | 37 |
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.plugins.appcenter.business.resourcetype.AbstractAppCenterResourceType' | 4 | 38 |
| DuplicateImports | Avoid duplicate imports such as 'javax.validation.constraints.NotNull' | 4 | 51 |
| DuplicateImports | Avoid duplicate imports such as 'javax.validation.constraints.Size' | 4 | 52 |
| DuplicateImports | Avoid duplicate imports such as 'org.hibernate.validator.constraints.NotEmpty' | 4 | 53 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 177 |
| FormalParameterNamingConventions | The method parameter name '_strCode' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 227 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 229 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 229 |
| UseLocaleWithCaseConversions | When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 3 | 229 |
| CommentRequired | Public method and constructor comments are required | 3 | 269–281 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| TooManyMethods | This class has too many methods, consider refactoring it. | 3 | 50–508 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 106–114 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 227–235 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 388 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 388 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 39–119 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 43 |
| FormalParameterNamingConventions | The method parameter name '_nIdApllicationData' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 114 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 41–73 |
| CommentRequired | Public method and constructor comments are required | 3 | 45–48 |
| CommentRequired | Public method and constructor comments are required | 3 | 60–65 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Public method and constructor comments are required | 3 | 48–51 |
| FieldDeclarationsShouldBeAtStartOfClass | Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 3 | 53 |
| CommentRequired | Public method and constructor comments are required | 3 | 65–68 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UseUtilityClass | All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. | 3 | 47–110 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| MissingSerialVersionUID | Classes implementing Serializable should set a serialVersionUID | 3 | 39–64 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 39–152 |
| CommentRequired | Public method and constructor comments are required | 3 | 46–52 |
| CommentRequired | Public method and constructor comments are required | 3 | 54–66 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnusedImports | Avoid unused imports such as 'javax.validation.constraints' | 4 | 36 |
| UnusedImports | Avoid unused imports such as 'org.hibernate.validator.constraints' | 4 | 37 |
| BooleanGetMethodName | A getX() method which returns a boolean should be named isX() | 4 | 105–108 |
| CommentRequired | Public method and constructor comments are required | 3 | 142–145 |
| CommentRequired | Public method and constructor comments are required | 3 | 147–150 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 148 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 176 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnusedImports | Avoid unused imports such as 'com.fasterxml.jackson.annotation.JsonIgnoreProperties' | 4 | 40 |
| CommentRequired | Public method and constructor comments are required | 3 | 261–265 |
| FormalParameterNamingConventions | The method parameter name '_creationTimestamp' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 273 |
| CommentRequired | Public method and constructor comments are required | 3 | 321–324 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| TooManyMethods | This class has too many methods, consider refactoring it. | 3 | 54–463 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 103–110 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 192–199 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 213 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 235 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 259 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 284 |
| AvoidThrowingRawExceptionTypes | Avoid throwing raw exception types. | 1 | 342 |
| NPathComplexity | The method 'selectDemandsListByFilter(DemandFilter, Plugin)' has an NPath complexity of 2304 | 3 | 392–462 |
| CyclomaticComplexity | The method 'selectDemandsListByFilter(DemandFilter, Plugin)' has a cyclomatic complexity of 14. | 3 | 392–462 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 394 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 3 | 431 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.portal.service.util.AppLogService' | 4 | 43 |
| UnusedImports | Avoid unused imports such as 'java.io.IOException' | 4 | 46 |
| CommentRequired | Public method and constructor comments are required | 3 | 194–197 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Public method and constructor comments are required | 3 | 75–78 |
| CommentRequired | Public method and constructor comments are required | 3 | 205–208 |
| CommentRequired | Public method and constructor comments are required | 3 | 210–213 |
| CommentRequired | Public method and constructor comments are required | 3 | 215–218 |
| CommentRequired | Public method and constructor comments are required | 3 | 220–223 |
| CommentRequired | Public method and constructor comments are required | 3 | 225–228 |
| CommentRequired | Public method and constructor comments are required | 3 | 230–233 |
| CommentRequired | Public method and constructor comments are required | 3 | 235–238 |
| CommentRequired | Public method and constructor comments are required | 3 | 240–243 |
| CommentRequired | Public method and constructor comments are required | 3 | 245–248 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnusedImports | Avoid unused imports such as 'java.util.function.Predicate' | 4 | 43 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 163 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 208 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 243 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 40–151 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ImportFromSamePackage | No need to import a type that lives in the same package | 3 | 36 |
| ImportFromSamePackage | No need to import a type that lives in the same package | 3 | 37 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnusedImports | Avoid unused imports such as 'org.hibernate.validator.constraints' | 4 | 37 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Enum comments are required | 3 | 38–99 |
| FieldNamingConventions | The final field name '_strPrefix' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 43 |
| FieldNamingConventions | The final field name '_strLabelKey' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 44 |
| UnnecessaryModifier | Unnecessary modifier 'private' on constructor 'DocumentationCategory(String, String)': enum constructors are implicitly private | 3 | 54–58 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 150 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 178 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 216 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Enum comments are required | 3 | 40–111 |
| FieldNamingConventions | The final field name '_strPrefix' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 46 |
| FieldNamingConventions | The final field name '_strLabelKey' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 47 |
| UnnecessaryModifier | Unnecessary modifier 'private' on constructor 'Environment(String, String)': enum constructors are implicitly private | 3 | 57–61 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| TooManyMethods | This class has too many methods, consider refactoring it. | 3 | 45–183 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnusedImports | Avoid unused imports such as 'java.io.IOException' | 4 | 38 |
| TooManyMethods | This class has too many methods, consider refactoring it. | 3 | 45–174 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ImportFromSamePackage | No need to import a type that lives in the same package | 3 | 36 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| FormalParameterNamingConventions | The method parameter name '_plugin' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 98 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| TooManyMethods | This class has too many methods, consider refactoring it. | 3 | 44–179 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnusedImports | Avoid unused imports such as 'javax.validation.constraints.Size' | 4 | 36 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ShortClassName | Avoid short class names like Role | 4 | 43–119 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 174 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 200 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 238 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 238 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ShortClassName | Avoid short class names like User | 4 | 41–112 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| TooManyMethods | This class has too many methods, consider refactoring it. | 3 | 48–403 |
| NPathComplexity | The method 'selectUserApplicationRolesListByFilter(UserApplicationRoleFilter, Plugin)' has an NPath complexity of 1728 | 3 | 213–282 |
| CyclomaticComplexity | The method 'selectUserApplicationRolesListByFilter(UserApplicationRoleFilter, Plugin)' has a cyclomatic complexity of 14. | 3 | 213–282 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnusedImports | Avoid unused imports such as 'java.sql.Statement' | 4 | 39 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 136 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 161 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 38–43 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| MissingSerialVersionUID | Classes implementing Serializable should set a serialVersionUID | 3 | 42–83 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| MissingSerialVersionUID | Classes implementing Serializable should set a serialVersionUID | 3 | 42–142 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| MissingSerialVersionUID | Classes implementing Serializable should set a serialVersionUID | 3 | 38–87 |
| CommentRequired | Header comments are required | 3 | 38–87 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 3 | 42 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the _nIdTask field if you want a default access modifier | 3 | 42 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 3 | 43 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the _nStatus field if you want a default access modifier | 3 | 43 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnusedImports | Avoid unused imports such as 'java.sql.Statement' | 4 | 41 |
| CommentRequired | Header comments are required | 3 | 43–120 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnusedImports | Avoid unused imports such as 'java.util.Collection' | 4 | 42 |
| CommentRequired | Header comments are required | 3 | 45–61 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 45–87 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 46–80 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 38–61 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getRessourceTypeKey': the method is declared in an interface type | 3 | 45 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getRessourceTypeLabel': the method is declared in an interface type | 3 | 52 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getResourceTypeValues': the method is declared in an interface type | 3 | 59 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 41–88 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnusedPrivateField | Avoid unused private fields such as 'SQL_QUERY_NEW_PK'. | 3 | 45 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 38–148 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 3 | 40 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the _strNotificationType field if you want a default access modifier | 3 | 40 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the _nIdMailingList field if you want a default access modifier | 3 | 41 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 3 | 41 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 3 | 42 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the _strSubject field if you want a default access modifier | 3 | 42 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 3 | 43 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the _strMessage field if you want a default access modifier | 3 | 43 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the _strSenderName field if you want a default access modifier | 3 | 44 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 3 | 44 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 39–76 |
| CommentRequired | Public method and constructor comments are required | 3 | 44–48 |
| CallSuperInConstructor | It is a good practice to call super() in a constructor | 3 | 44–48 |
| CommentRequired | Public method and constructor comments are required | 3 | 50–53 |
| CommentRequired | Public method and constructor comments are required | 3 | 55–58 |
| CommentRequired | Public method and constructor comments are required | 3 | 60–63 |
| CommentRequired | Public method and constructor comments are required | 3 | 65–68 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 39–76 |
| CallSuperInConstructor | It is a good practice to call super() in a constructor | 3 | 44–48 |
| CommentRequired | Public method and constructor comments are required | 3 | 44–48 |
| CommentRequired | Public method and constructor comments are required | 3 | 50–53 |
| CommentRequired | Public method and constructor comments are required | 3 | 55–58 |
| CommentRequired | Public method and constructor comments are required | 3 | 60–63 |
| CommentRequired | Public method and constructor comments are required | 3 | 65–68 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 51–105 |
| UseUtilityClass | All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. | 3 | 52–105 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 56–277 |
| ShortVariable | Avoid variables with short names like s | 3 | 243 |
| ControlStatementBraces | This statement should have braces | 3 | 245 |
| CommentRequired | Public method and constructor comments are required | 3 | 249–261 |
| CommentRequired | Public method and constructor comments are required | 3 | 263–275 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 40–56 |
| UncommentedEmptyMethodBody | Document empty method body | 3 | 49–50 |
| CommentRequired | Public method and constructor comments are required | 3 | 52–55 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 46–95 |
| AvoidDuplicateLiterals | The String literal "APP" appears 6 times in this file; the first occurrence is on line 59 | 3 | 59 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UseUtilityClass | All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. | 3 | 68–301 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the getApplicationData method if you want a default access modifier | 3 | 161–175 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 3 | 161–175 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 166–173 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the getDataSubset method if you want a default access modifier | 3 | 218–228 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 3 | 218–228 |
| CommentRequired | Public method and constructor comments are required | 3 | 254–278 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 260–269 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 292 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UseUtilityClass | All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. | 3 | 46–85 |
| CommentRequired | Public method and constructor comments are required | 3 | 47–84 |
| CyclomaticComplexity | The method 'isAuthorized(String, int, String, String)' has a cyclomatic complexity of 10. | 3 | 47–84 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 65–79 |
| AvoidDeeplyNestedIfStmts | Deeply nested if..then statements are hard to read | 3 | 69–72 |
| AvoidDeeplyNestedIfStmts | Deeply nested if..then statements are hard to read | 3 | 76–79 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UseUtilityClass | All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. | 3 | 60–224 |
| CommentRequired | Public method and constructor comments are required | 3 | 68–79 |
| CommentRequired | Public method and constructor comments are required | 3 | 81–84 |
| CommentRequired | Public method and constructor comments are required | 3 | 86–97 |
| ShortVariable | Avoid variables with short names like it | 3 | 162 |
| AvoidDeeplyNestedIfStmts | Deeply nested if..then statements are hard to read | 3 | 167–171 |
| UseCollectionIsEmpty | Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() | 3 | 173 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 190 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 46–94 |
| ShortVariable | Avoid variables with short names like rt | 3 | 59 |
| ShortVariable | Avoid variables with short names like p | 3 | 65 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 47–124 |
| UseUtilityClass | All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. | 3 | 48–124 |
| FieldNamingConventions | The static field name 'KEY_SUPER_ADMIN_ROLE' doesn't match '_[a-z][a-zA-Z0-9]*' | 1 | 50 |
| CommentRequired | Public method and constructor comments are required | 3 | 52–55 |
| CommentRequired | Public method and constructor comments are required | 3 | 57–60 |
| CommentRequired | Public method and constructor comments are required | 3 | 62–81 |
| UnnecessaryLocalBeforeReturn | Consider simply returning the value vs storing it in local variable 'className' | 3 | 72 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 42–65 |
| UseUtilityClass | All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. | 3 | 43–65 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 44–52 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'providePermissionList': the method is declared in an interface type | 3 | 51 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 46–80 |
| UseUtilityClass | All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. | 3 | 47–80 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 39–93 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 3 | 41 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the _mapResourceType field if you want a default access modifier | 3 | 41 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 45–74 |
| UseUtilityClass | All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. | 3 | 46–74 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.util.ReferenceList' | 4 | 44 |
| CommentRequired | Header comments are required | 3 | 46–56 |
| UseUtilityClass | All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. | 3 | 47–56 |
| CommentRequired | Public method and constructor comments are required | 3 | 50–55 |
| UnnecessaryLocalBeforeReturn | Consider simply returning the value vs storing it in local variable 'ownerRole' | 3 | 54 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UseUtilityClass | All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. | 3 | 59–343 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 125–140 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 3 | 293–316 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the getUserInfo method if you want a default access modifier | 3 | 293–316 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 307–314 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 3 | 331–341 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the getDataSubset method if you want a default access modifier | 3 | 331–341 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.plugins.appcenter.business.organization.OrganizationManagerHome' | 4 | 43 |
| CommentRequired | Header comments are required | 3 | 62–153 |
| MissingOverride | The method 'getPrerequisiteType()' is missing an @Override annotation. | 3 | 73–76 |
| CommentRequired | Public method and constructor comments are required | 3 | 73–76 |
| MissingOverride | The method 'getTitleI18nKey()' is missing an @Override annotation. | 3 | 78–81 |
| CommentRequired | Public method and constructor comments are required | 3 | 78–81 |
| MissingOverride | The method 'hasConfiguration()' is missing an @Override annotation. | 3 | 83–86 |
| CommentRequired | Public method and constructor comments are required | 3 | 83–86 |
| MissingOverride | The method 'getEmptyConfiguration()' is missing an @Override annotation. | 3 | 88–91 |
| CommentRequired | Public method and constructor comments are required | 3 | 88–91 |
| MissingOverride | The method 'getConfigurationDaoBeanName()' is missing an @Override annotation. | 3 | 93–96 |
| CommentRequired | Public method and constructor comments are required | 3 | 93–96 |
| CommentRequired | Public method and constructor comments are required | 3 | 98–106 |
| MissingOverride | The method 'getConfigHtml(IPrerequisiteConfig, HttpServletRequest, Locale)' is missing an @Override annotation. | 3 | 98–106 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 100 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 100 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 45–50 |
| GenericsNaming | Generics names should be a one letter long and upper case. | 4 | 45 |
| GenericsNaming | Generics names should be a one letter long and upper case. | 4 | 45 |
| CommentRequired | Public method and constructor comments are required | 3 | 48 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CyclomaticComplexity | The method 'processTask(int, HttpServletRequest, Locale, Class, Class, Class, AppCenterTaskFunctional)' has a cyclomatic complexity of 11. | 3 | 90–167 |
| AvoidThrowingRawExceptionTypes | Avoid throwing raw exception types. | 1 | 108 |
| ShortVariable | Avoid variables with short names like it | 3 | 150 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 45–75 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 48–81 |
| FieldNamingConventions | The final field name '_taskConfigService' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 50 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 3 | 34–174 |
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.portal.service.mail.MailItem' | 4 | 56 |
| CommentRequired | Header comments are required | 3 | 70–174 |
| UnusedFormalParameter | Avoid unused method parameters such as 'request'. | 3 | 112 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 114 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 114 |
| SwitchStmtsShouldHaveDefault | Switch statements should have a default label | 3 | 142–169 |
| AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 3 | 150 |
| UseEqualsToCompareStrings | Use equals() to compare strings instead of '==' or '!=' | 3 | 150 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.plugins.appcenter.business.organization.OrganizationManagerHome' | 4 | 45 |
| CommentRequired | Header comments are required | 3 | 65–158 |
| UnusedPrivateField | Avoid unused private fields such as 'SLASH'. | 3 | 85 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 129 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 129 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.plugins.workflowcore.web.task.SimpleTaskComponent' | 4 | 39 |
| CommentRequired | Header comments are required | 3 | 51–122 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 63 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 63 |
| AvoidBranchingStatementAsLastInLoop | Avoid using a branching statement as the last in a loop. | 2 | 82 |
| ShortVariable | Avoid variables with short names like i | 3 | 92 |
| ShortVariable | Avoid variables with short names like i | 3 | 100 |
| ShortVariable | Avoid variables with short names like i | 3 | 109 |
| ShortVariable | Avoid variables with short names like i | 3 | 118 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ShortVariable | Avoid variables with short names like i | 3 | 82 |
| CommentRequired | Public method and constructor comments are required | 3 | 87–90 |
| ShortVariable | Avoid variables with short names like i | 3 | 87 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 95 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 95 |
| ShortVariable | Avoid variables with short names like i | 3 | 107 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 132–169 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 3 | 174–190 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the populate method if you want a default access modifier | 3 | 174–190 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 55–149 |
| ShortVariable | Avoid variables with short names like i | 3 | 69 |
| CommentRequired | Public method and constructor comments are required | 3 | 74–77 |
| ShortVariable | Avoid variables with short names like i | 3 | 74 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 82 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 82 |
| ShortVariable | Avoid variables with short names like i | 3 | 93 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 118–145 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 41–75 |
| UseUtilityClass | All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. | 3 | 42–75 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the PROPERTY_CRYPTO_KEY field if you want a default access modifier | 3 | 62 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 3 | 62 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the DSKEY_CRYPTO_KEY field if you want a default access modifier | 3 | 63 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 3 | 63 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 115 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 145 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 168 |
| ForLoopCanBeForeach | This for loop can be replaced by a foreach loop | 3 | 218–228 |
| AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 3 | 220 |
| AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 3 | 223 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.plugins.appcenter.business.Application' | 4 | 38 |
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.plugins.appcenter.business.ApplicationDemandTypesEnable' | 4 | 39 |
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.plugins.appcenter.business.DemandHome' | 4 | 41 |
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.plugins.appcenter.service.ApplicationService' | 4 | 43 |
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.plugins.appcenter.service.DemandTypeService' | 4 | 44 |
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.plugins.workflowcore.business.state.State' | 4 | 46 |
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.portal.service.admin.AccessDeniedException' | 4 | 47 |
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.portal.service.workflow.WorkflowService' | 4 | 52 |
| UnusedImports | Avoid unused imports such as 'java.util.HashMap' | 4 | 53 |
| UnusedImports | Avoid unused imports such as 'java.util.List' | 4 | 54 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 86 |
| UnusedLocalVariable | Avoid unused local variables such as 'session'. | 3 | 90 |
| CommentRequired | Protected method constructor comments are required | 3 | 110 |
| CommentRequired | Protected method constructor comments are required | 3 | 112 |
| CommentRequired | Protected method constructor comments are required | 3 | 114 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 3 | 34–348 |
| UnusedPrivateField | Avoid unused private fields such as 'ERROR_APP_NOT_FOUND'. | 3 | 89 |
| UnusedPrivateField | Avoid unused private fields such as 'ERROR_INVALID_APP_ID'. | 3 | 91 |
| EmptyCatchBlock | Avoid empty catch blocks | 3 | 125–128 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 158 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 159 |
| UnnecessaryLocalBeforeReturn | Consider simply returning the value vs storing it in local variable 'environment' | 3 | 183 |
| CommentRequired | Protected method constructor comments are required | 3 | 212–252 |
| UnusedLocalVariable | Avoid unused local variables such as 'session'. | 3 | 215 |
| CommentRequired | Protected method constructor comments are required | 3 | 254–279 |
| UnusedLocalVariable | Avoid unused local variables such as 'session'. | 3 | 259 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 261–276 |
| LinguisticNaming | Linguistics Antipattern - The getter 'getUnauthorizedAccessMessage' should not return void linguistically | 3 | 316–319 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 338 |
| EmptyCatchBlock | Avoid empty catch blocks | 3 | 338–341 |
| CommentRequired | Protected method constructor comments are required | 3 | 344–347 |
| EmptyMethodInAbstractClassShouldBeAbstract | An empty method in an abstract class should be abstract instead | 1 | 344–347 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 3 | 34–546 |
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.plugins.appcenter.business.organization.Organization' | 4 | 41 |
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.util.ReferenceItem' | 4 | 56 |
| UnusedImports | Avoid unused imports such as 'java.util.HashMap' | 4 | 62 |
| MissingSerialVersionUID | Classes implementing Serializable should set a serialVersionUID | 3 | 76–546 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 170 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 234 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 398–399 |
| CyclomaticComplexity | The method 'doSendApplicationMail(HttpServletRequest)' has a cyclomatic complexity of 12. | 3 | 444–516 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 450 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 451 |
| PositionLiteralsFirstInComparisons | Position literals first in String comparisons | 3 | 462 |
| PositionLiteralsFirstInComparisons | Position literals first in String comparisons | 3 | 471 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Public method and constructor comments are required | 3 | 98–120 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 126–133 |
| UseLocaleWithCaseConversions | When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 3 | 129 |
| CommentRequired | Public method and constructor comments are required | 3 | 139–156 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 144–150 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 151 |
| CommentRequired | Public method and constructor comments are required | 3 | 159–174 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 169 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 3 | 34–667 |
| TooManyStaticImports | Too many static imports may lead to messy code | 3 | 34–667 |
| MissingSerialVersionUID | Classes implementing Serializable should set a serialVersionUID | 3 | 109–667 |
| UnusedPrivateField | Avoid unused private fields such as 'ERROR_USER_ROLE_NOT_AUTHORIZED'. | 3 | 157 |
| CommentRequired | Public method and constructor comments are required | 3 | 185–206 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 187 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 218 |
| AvoidDuplicateLiterals | The String literal "demandtype_" appears 4 times in this file; the first occurrence is on line 276 | 3 | 276 |
| UseEqualsToCompareStrings | Use equals() to compare strings instead of '==' or '!=' | 3 | 380 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 380–391 |
| AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 3 | 380 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 411 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 412 |
| CommentRequired | Public method and constructor comments are required | 3 | 433–476 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 457 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 458 |
| CyclomaticComplexity | The method 'doModifyApplication(HttpServletRequest)' has a cyclomatic complexity of 10. | 3 | 486–541 |
| UnusedLocalVariable | Avoid unused local variables such as 'application'. | 3 | 598 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ClassNamingConventions | The utility class name 'Constants' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' | 1 | 39–75 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 3 | 34–559 |
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.plugins.appcenter.business.ApplicationDatas' | 4 | 44 |
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.portal.service.util.AppException' | 4 | 64 |
| UnusedImports | Avoid unused imports such as 'java.util.Locale' | 4 | 81 |
| UnusedImports | Avoid unused imports such as 'java.util.Optional' | 4 | 82 |
| MissingSerialVersionUID | Classes implementing Serializable should set a serialVersionUID | 3 | 88–559 |
| ImmutableField | Private field '_stateService' could be made final; it is only initialized in the declaration or constructor. | 3 | 157 |
| CyclomaticComplexity | The method 'getManageDemands(HttpServletRequest)' has a cyclomatic complexity of 23. | 3 | 169–346 |
| ExcessiveMethodLength | Avoid really long methods. | 3 | 169–346 |
| NPathComplexity | The method 'getManageDemands(HttpServletRequest)' has an NPath complexity of 28672 | 3 | 169–346 |
| NcssCount | The method 'getManageDemands(HttpServletRequest)' has a NCSS line count of 96. | 3 | 169–346 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 185 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 186 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 187 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 189 |
| ShortVariable | Avoid variables with short names like c | 3 | 287 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 372 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 373 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 374 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 412 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 447 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 448 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 471 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 472 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 488 |
| CommentRequired | Public method and constructor comments are required | 3 | 539–558 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnusedImports | Avoid unused imports such as 'java.util.function.Function' | 4 | 60 |
| MissingSerialVersionUID | Classes implementing Serializable should set a serialVersionUID | 3 | 68–793 |
| TooManyMethods | This class has too many methods, consider refactoring it. | 3 | 69–793 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 179 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 182 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 209 |
| CommentRequired | Public method and constructor comments are required | 3 | 331–365 |
| ShortVariable | Avoid variables with short names like it | 3 | 345 |
| CommentRequired | Public method and constructor comments are required | 3 | 368–404 |
| ShortVariable | Avoid variables with short names like it | 3 | 384 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 422 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 442–449 |
| CommentRequired | Public method and constructor comments are required | 3 | 543–576 |
| ShortVariable | Avoid variables with short names like it | 3 | 556 |
| CommentRequired | Public method and constructor comments are required | 3 | 579–614 |
| ShortVariable | Avoid variables with short names like it | 3 | 594 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 626 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 642–655 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 668 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 3 | 34–252 |
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.plugins.appcenter.business.organization.OrganizationManagerHome' | 4 | 49 |
| CommentRequired | Header comments are required | 3 | 77–252 |
| MissingSerialVersionUID | Classes implementing Serializable should set a serialVersionUID | 3 | 77–252 |
| ImmutableField | Private field '_taskService' could be made final; it is only initialized in the declaration or constructor. | 3 | 110 |
| ImmutableField | Private field '_actionService' could be made final; it is only initialized in the declaration or constructor. | 3 | 111 |
| ImmutableField | Private field '_stateService' could be made final; it is only initialized in the declaration or constructor. | 3 | 112 |
| UnusedPrivateField | Avoid unused private fields such as '_stateService'. | 3 | 112 |
| CyclomaticComplexity | The method 'getDemandValidation(HttpServletRequest)' has a cyclomatic complexity of 12. | 3 | 124–184 |
| NPathComplexity | The method 'getDemandValidation(HttpServletRequest)' has an NPath complexity of 768 | 3 | 124–184 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 133 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 134 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| MissingSerialVersionUID | Classes implementing Serializable should set a serialVersionUID | 3 | 49–102 |
| SingularField | Perhaps '_nDefaultItemsPerPage' could be replaced by a local variable. | 3 | 65 |
| AddEmptyString | Do not add empty strings | 3 | 96 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| MissingSerialVersionUID | Classes implementing Serializable should set a serialVersionUID | 3 | 57–233 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 113 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 141 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| MissingSerialVersionUID | Classes implementing Serializable should set a serialVersionUID | 3 | 53–240 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 109 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 126 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| MissingSerialVersionUID | Classes implementing Serializable should set a serialVersionUID | 3 | 68–479 |
| CyclomaticComplexity | The method 'getManageUserApplicationRoles(HttpServletRequest)' has a cyclomatic complexity of 11. | 3 | 151–230 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 159 |
| ShortVariable | Avoid variables with short names like c | 3 | 181 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 276 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 466 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 466 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 52–144 |
| MissingSerialVersionUID | Classes implementing Serializable should set a serialVersionUID | 3 | 52–144 |
| UnnecessaryAnnotationValueElement | Avoid the use of value in annotations when its the only element | 3 | 123 |
| ControlStatementBraces | This statement should have braces | 3 | 127 |
| ControlStatementBraces | This statement should have braces | 3 | 129 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| MissingSerialVersionUID | Classes implementing Serializable should set a serialVersionUID | 3 | 49–97 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| MissingSerialVersionUID | Classes implementing Serializable should set a serialVersionUID | 3 | 55–249 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 109 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 125 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| MissingSerialVersionUID | Classes implementing Serializable should set a serialVersionUID | 3 | 56–274 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 112 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 142 |