Fork me on GitHub

Résultats PMD

Le document suivant contient les résultats de PMD 5.5.1.

Fichiers

fr/paris/lutece/plugins/appointment/business/AbstractDateConversion.java

Violation Ligne
Assigning an Object to null is a code smell. Consider refactoring. 97

fr/paris/lutece/plugins/appointment/business/UtilDAO.java

Violation Ligne
Abstract classes should be named AbstractXXX 3972
This abstract class does not have any abstract methods 3972
Document empty constructor 4547
Avoid unnecessary constructors - the compiler will generate these for you 4547

fr/paris/lutece/plugins/appointment/business/appointment/Appointment.java

Violation Ligne
A getX() method which returns a boolean should be named isX() 161164

fr/paris/lutece/plugins/appointment/business/appointment/AppointmentDAO.java

Violation Ligne
Possible God class (WMC=56, ATFD=83, TCC=0.0) 34610
Avoid unused imports such as 'java.sql.ResultSet' 36
Avoid unused imports such as 'java.sql.ResultSet' 36
Avoid unused imports such as 'java.util.Map' 42
Avoid unused imports such as 'java.util.Map' 42
Avoid unused private fields such as 'SQL_QUERY_GET_ID_FORM_BY_NUMERO'. 83
Use block level rather than method level synchronization 97102
Invoke equals() on the object you've already ensured is not null 537
Avoid appending characters as strings in StringBuffer.append. 589

fr/paris/lutece/plugins/appointment/business/appointment/AppointmentHome.java

Violation Ligne
Avoid using implementation types like 'HashMap'; use the interface instead 186
Avoid using implementation types like 'HashMap'; use the interface instead 186
Consider using varargs for methods or constructors which take an array the last parameter. 233

fr/paris/lutece/plugins/appointment/business/appointment/IAppointmentDAO.java

Violation Ligne
Avoid modifiers which are implied by the context 54
Avoid using implementation types like 'HashMap'; use the interface instead 165
Avoid using implementation types like 'HashMap'; use the interface instead 165

fr/paris/lutece/plugins/appointment/business/appointment/IAppointmentResponseDAO.java

Violation Ligne
Avoid modifiers which are implied by the context 52

fr/paris/lutece/plugins/appointment/business/calendar/CalendarTemplateDAO.java

Violation Ligne
Use block level rather than method level synchronization 5964

fr/paris/lutece/plugins/appointment/business/category/CategoryDAO.java

Violation Ligne
Use block level rather than method level synchronization 6267

fr/paris/lutece/plugins/appointment/business/category/ICategoryDAO.java

Violation Ligne
Avoid modifiers which are implied by the context 52

fr/paris/lutece/plugins/appointment/business/display/DisplayDAO.java

Violation Ligne
Use block level rather than method level synchronization 5964

fr/paris/lutece/plugins/appointment/business/display/IDisplayDAO.java

Violation Ligne
Avoid modifiers which are implied by the context 50

fr/paris/lutece/plugins/appointment/business/form/Form.java

Violation Ligne
Avoid short class names like Form 57408
Assigning an Object to null is a code smell. Consider refactoring. 279
Assigning an Object to null is a code smell. Consider refactoring. 333
A getX() method which returns a boolean should be named isX() 342345

fr/paris/lutece/plugins/appointment/business/form/FormDAO.java

Violation Ligne
Avoid excessively long variable names like SQL_QUERY_SELECT_ACTIVE_AND_DISPLAYED_ON_PORTLET_FORMS 61
Use block level rather than method level synchronization 6570

fr/paris/lutece/plugins/appointment/business/form/IFormDAO.java

Violation Ligne
Avoid modifiers which are implied by the context 52

fr/paris/lutece/plugins/appointment/business/localization/ILocalizationDAO.java

Violation Ligne
Avoid modifiers which are implied by the context 50

fr/paris/lutece/plugins/appointment/business/localization/LocalizationDAO.java

Violation Ligne
Use block level rather than method level synchronization 5257

fr/paris/lutece/plugins/appointment/business/message/FormMessage.java

Violation Ligne
Too many fields 44543

fr/paris/lutece/plugins/appointment/business/message/FormMessageDAO.java

Violation Ligne
Use block level rather than method level synchronization 5863

fr/paris/lutece/plugins/appointment/business/message/IFormMessageDAO.java

Violation Ligne
Avoid modifiers which are implied by the context 49

fr/paris/lutece/plugins/appointment/business/planning/ClosingDay.java

Violation Ligne
Assigning an Object to null is a code smell. Consider refactoring. 140

fr/paris/lutece/plugins/appointment/business/planning/ClosingDayDAO.java

Violation Ligne
Avoid excessively long variable names like SQL_QUERY_SELECT_BY_ID_FORM_AND_DATE_OF_CLOSING_DAY 61
Use block level rather than method level synchronization 6671

fr/paris/lutece/plugins/appointment/business/planning/IClosingDayDAO.java

Violation Ligne
Avoid modifiers which are implied by the context 53

fr/paris/lutece/plugins/appointment/business/planning/ITimeSlotDAO.java

Violation Ligne
Avoid modifiers which are implied by the context 52

fr/paris/lutece/plugins/appointment/business/planning/IWeekDefinitionDAO.java

Violation Ligne
Avoid modifiers which are implied by the context 53

fr/paris/lutece/plugins/appointment/business/planning/IWorkingDayDAO.java

Violation Ligne
Avoid modifiers which are implied by the context 52

fr/paris/lutece/plugins/appointment/business/planning/TimeSlot.java

Violation Ligne
A getX() method which returns a boolean should be named isX() 223226

fr/paris/lutece/plugins/appointment/business/planning/TimeSlotDAO.java

Violation Ligne
Use block level rather than method level synchronization 6166

fr/paris/lutece/plugins/appointment/business/planning/WeekDefinitionDAO.java

Violation Ligne
Use block level rather than method level synchronization 6469

fr/paris/lutece/plugins/appointment/business/planning/WorkingDayDAO.java

Violation Ligne
Use block level rather than method level synchronization 6166

fr/paris/lutece/plugins/appointment/business/portlet/AppointmentFormListPortlet.java

Violation Ligne
It is a good practice to call super() in a constructor 5457

fr/paris/lutece/plugins/appointment/business/portlet/AppointmentFormListPortletHome.java

Violation Ligne
Possible unsafe assignment to a non-final static field in a constructor. 53
Use of modifier volatile is not recommended. 53
It is a good practice to call super() in a constructor 5864
Singleton is not thread safe 8588

fr/paris/lutece/plugins/appointment/business/portlet/AppointmentFormPortlet.java

Violation Ligne
It is a good practice to call super() in a constructor 5659

fr/paris/lutece/plugins/appointment/business/portlet/AppointmentFormPortletDAO.java

Violation Ligne
Avoid variables with short names like p 71
Avoid variables with short names like p 126

fr/paris/lutece/plugins/appointment/business/portlet/AppointmentFormPortletHome.java

Violation Ligne
Possible unsafe assignment to a non-final static field in a constructor. 53
Use of modifier volatile is not recommended. 53
It is a good practice to call super() in a constructor 5864
Singleton is not thread safe 8588

fr/paris/lutece/plugins/appointment/business/portlet/AppointmentPortlet.java

Violation Ligne
It is a good practice to call super() in a constructor 5861

fr/paris/lutece/plugins/appointment/business/portlet/AppointmentPortletHome.java

Violation Ligne
Possible unsafe assignment to a non-final static field in a constructor. 53
Use of modifier volatile is not recommended. 53
It is a good practice to call super() in a constructor 5864
Singleton is not thread safe 8588

fr/paris/lutece/plugins/appointment/business/rule/FormRule.java

Violation Ligne
A getX() method which returns a boolean should be named isX() 123126
A getX() method which returns a boolean should be named isX() 144147
A getX() method which returns a boolean should be named isX() 165168

fr/paris/lutece/plugins/appointment/business/rule/FormRuleDAO.java

Violation Ligne
Use block level rather than method level synchronization 5863

fr/paris/lutece/plugins/appointment/business/rule/IFormRuleDAO.java

Violation Ligne
Avoid modifiers which are implied by the context 50

fr/paris/lutece/plugins/appointment/business/rule/IReservationRuleDAO.java

Violation Ligne
Avoid modifiers which are implied by the context 53

fr/paris/lutece/plugins/appointment/business/rule/ReservationRuleDAO.java

Violation Ligne
Use block level rather than method level synchronization 6469

fr/paris/lutece/plugins/appointment/business/slot/ISlotDAO.java

Violation Ligne
Avoid modifiers which are implied by the context 53

fr/paris/lutece/plugins/appointment/business/slot/Slot.java

Violation Ligne
Avoid short class names like Slot 51481
A getX() method which returns a boolean should be named isX() 318321
A getX() method which returns a boolean should be named isX() 339342
A getX() method which returns a boolean should be named isX() 360363

fr/paris/lutece/plugins/appointment/business/slot/SlotDAO.java

Violation Ligne
Avoid excessively long variable names like SQL_QUERY_SELECT_OPEN_SLOTS_BY_ID_FORM_AND_DATE_RANGE 65
Use block level rather than method level synchronization 7378

fr/paris/lutece/plugins/appointment/business/user/User.java

Violation Ligne
Avoid short class names like User 52248

fr/paris/lutece/plugins/appointment/business/user/UserDAO.java

Violation Ligne
Use block level rather than method level synchronization 6368
When doing a String.toLowerCase()/toUpperCase() call, use a Locale 143
When doing a String.toLowerCase()/toUpperCase() call, use a Locale 144
When doing a String.toLowerCase()/toUpperCase() call, use a Locale 145

fr/paris/lutece/plugins/appointment/log/LogUtilities.java

Violation Ligne
Avoid variables with short names like BY 46

fr/paris/lutece/plugins/appointment/service/AppointmentResourceIdService.java

Violation Ligne
It is a good practice to call super() in a constructor 112115

fr/paris/lutece/plugins/appointment/service/AppointmentService.java

Violation Ligne
The class 'AppointmentService' has a Cyclomatic Complexity of 2 (Highest = 11). 68571
The method 'saveAppointment' has a Cyclomatic Complexity of 11. 149241
The method saveAppointment() has an NPath complexity of 216 149241
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 163
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 235
Unnecessary use of fully qualified name 'org.apache.commons.lang3.StringUtils.SPACE' due to existing import 'org.apache.commons.lang3.StringUtils' 360
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 400
Avoid using implementation types like 'HashMap'; use the interface instead 508
Avoid using implementation types like 'HashMap'; use the interface instead 508
Consider using varargs for methods or constructors which take an array the last parameter. 567

fr/paris/lutece/plugins/appointment/service/AppointmentUtilities.java

Violation Ligne
Possible God class (WMC=125, ATFD=185, TCC=0.005263157894736842) 341074
A high number of imports can indicate a high degree of coupling within an object. 341074
The class 'AppointmentUtilities' has a Standard Cyclomatic Complexity of 5 (Highest = 31). 1081074
The class 'AppointmentUtilities' has a Cyclomatic Complexity of 6 (Highest = 35). 1081074
The class 'AppointmentUtilities' has a Modified Cyclomatic Complexity of 5 (Highest = 31). 1081074
Avoid variables with short names like s 230
Deeply nested if..then statements are hard to read 231242
Deeply nested if..then statements are hard to read 276279
Avoid variables with short names like a 278
Deeply nested if..then statements are hard to read 280294
Avoid variables with short names like s 322
Deeply nested if..then statements are hard to read 323375
Avoid variables with short names like s 335
Avoid variables with short names like s 338
Avoid variables with short names like s 365
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 412
Avoid catching NullPointerException; consider removing the cause of the NPE. 412
The method 'buildExcelFileWithAppointments' has a Modified Cyclomatic Complexity of 31. 561755
The method buildExcelFileWithAppointments() has an NPath complexity of 478800 561755
The method buildExcelFileWithAppointments() has an NCSS line count of 134 561755
The method 'buildExcelFileWithAppointments' has a Standard Cyclomatic Complexity of 31. 561755
The method 'buildExcelFileWithAppointments' has a Cyclomatic Complexity of 35. 561755
Avoid really long methods. 561755
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 571
Deeply nested if..then statements are hard to read 586589
Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 613
Avoid variables with short names like f 673
Avoid concatenating nonliterals in a StringBuffer/StringBuilder constructor or append(). 691
When instantiating a SimpleDateFormat object, specify a Locale 739
Avoid variables with short names like os 746
Avoid variables with short names like nI 811
Avoid empty if statements 906908
Use bitwise inversion to invert boolean values 926
Avoid unnecessary comparisons in boolean expressions 960
Avoid variables with short names like a 960
Prefer StringBuffer over += for concatenating strings 1068

fr/paris/lutece/plugins/appointment/service/ClosingDayService.java

Violation Ligne
The class 'ClosingDayService' has a Cyclomatic Complexity of 2 (Highest = 12). 64274
The class 'ClosingDayService' has a Standard Cyclomatic Complexity of 2 (Highest = 11). 64274
The class 'ClosingDayService' has a Modified Cyclomatic Complexity of 2 (Highest = 11). 64274
The method 'getImportClosingDays' has a Standard Cyclomatic Complexity of 11. 207272
The method 'getImportClosingDays' has a Modified Cyclomatic Complexity of 11. 207272
The method 'getImportClosingDays' has a Cyclomatic Complexity of 12. 207272
Avoid using Literals in Conditional Statements 230
Deeply nested if..then statements are hard to read 239253
Avoid using Literals in Conditional Statements 239

fr/paris/lutece/plugins/appointment/service/EntryService.java

Violation Ligne
Possible God class (WMC=81, ATFD=178, TCC=0.0) 34758
A high number of imports can indicate a high degree of coupling within an object. 34758
The class 'EntryService' has a Cyclomatic Complexity of 5 (Highest = 16). 76758
The class 'EntryService' has a Modified Cyclomatic Complexity of 4 (Highest = 13). 76758
The class 'EntryService' has a Standard Cyclomatic Complexity of 4 (Highest = 13). 76758
The method 'moveDownEntryOrder' has a Modified Cyclomatic Complexity of 13. 140235
The method 'moveDownEntryOrder' has a Standard Cyclomatic Complexity of 13. 140235
The method 'moveDownEntryOrder' has a Cyclomatic Complexity of 16. 140235
The method 'moveUpEntryOrder' has a Cyclomatic Complexity of 13. 245319
The method 'moveUpEntryOrder' has a Modified Cyclomatic Complexity of 10. 245319
The method 'moveUpEntryOrder' has a Standard Cyclomatic Complexity of 10. 245319
The method 'getHtmlEntry' has a Cyclomatic Complexity of 13. 510574
The method 'getHtmlEntry' has a Modified Cyclomatic Complexity of 12. 510574
The method getHtmlEntry() has an NPath complexity of 200 510574
The method 'getHtmlEntry' has a Standard Cyclomatic Complexity of 12. 510574
The method 'getResponseEntry' has a Cyclomatic Complexity of 11. 614686
The method 'getResponseEntry' has a Standard Cyclomatic Complexity of 11. 614686
The method 'getResponseEntry' has a Modified Cyclomatic Complexity of 11. 614686
Consider simply returning the value vs storing it in local variable 'listEntryFirstLevel' 755

fr/paris/lutece/plugins/appointment/service/EntryTypeService.java

Violation Ligne
Use of modifier volatile is not recommended. 51
Singleton is not thread safe 6972

fr/paris/lutece/plugins/appointment/service/FormMessageService.java

Violation Ligne
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 61
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 63
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 64
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 65
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 66
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 67
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 68
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 69
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 70
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 71
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 72
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 73
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 74
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 75
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 76
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 77
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 78
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 79

fr/paris/lutece/plugins/appointment/service/FormService.java

Violation Ligne
Possible God class (WMC=76, ATFD=132, TCC=0.0) 34775
Avoid unused imports such as 'fr.paris.lutece.plugins.appointment.business.appointment.AppointmentHome' 42
Avoid unused imports such as 'fr.paris.lutece.plugins.appointment.business.appointment.AppointmentHome' 42
The class 'FormService' has a Standard Cyclomatic Complexity of 2 (Highest = 10). 72775
The class 'FormService' has a Cyclomatic Complexity of 3 (Highest = 11). 72775
The class 'FormService' has a Modified Cyclomatic Complexity of 2 (Highest = 10). 72775
Avoid really long methods. 91196
The method 'buildAppointmentForm' has a Cyclomatic Complexity of 10. 389439
The method 'buildAppointmentForm' has a Modified Cyclomatic Complexity of 10. 389439
The method 'buildAppointmentForm' has a Standard Cyclomatic Complexity of 10. 389439
The method buildAppointmentForm() has an NPath complexity of 512 389439
The method 'fillAppointmentFormWithWeekDefinitionPart' has a Standard Cyclomatic Complexity of 10. 449491
The method 'fillAppointmentFormWithWeekDefinitionPart' has a Cyclomatic Complexity of 10. 449491
Switch statements should have a default label 457480
The method 'checkValidityDate' has a Cyclomatic Complexity of 11. 607626

fr/paris/lutece/plugins/appointment/service/FormTraderService.java

Violation Ligne
Possible God class (WMC=85, ATFD=81, TCC=0.05263157894736842) 34761
A high number of imports can indicate a high degree of coupling within an object. 34761
The class 'FormTraderService' has a Cyclomatic Complexity of 4 (Highest = 13). 85761
The class 'FormTraderService' has a Modified Cyclomatic Complexity of 4 (Highest = 12). 85761
The class 'FormTraderService' has a Standard Cyclomatic Complexity of 4 (Highest = 12). 85761
The method 'importFormFromJson' has a Cyclomatic Complexity of 10. 127186
The method 'importFormFromJson' has a Standard Cyclomatic Complexity of 10. 127186
The method 'importFormFromJson' has a Modified Cyclomatic Complexity of 10. 127186
The method importEntries() has an NPath complexity of 960 499566
The method 'importEntries' has a Standard Cyclomatic Complexity of 12. 499566
The method 'importEntries' has a Modified Cyclomatic Complexity of 12. 499566
The method 'importEntries' has a Cyclomatic Complexity of 13. 499566

fr/paris/lutece/plugins/appointment/service/ReservationRuleService.java

Violation Ligne
Avoid variables with short names like w2 181
Avoid variables with short names like w1 181
Avoid variables with short names like x 190
Consider simply returning the value vs storing it in local variable 'reservationRule' 208
Consider simply returning the value vs storing it in local variable 'reservationRule' 221
Avoid using implementation types like 'HashMap'; use the interface instead 249
Avoid using implementation types like 'HashMap'; use the interface instead 249

fr/paris/lutece/plugins/appointment/service/SlotService.java

Violation Ligne
Possible God class (WMC=86, ATFD=150, TCC=0.0) 34914
The class 'SlotService' has a Cyclomatic Complexity of 4 (Highest = 21). 64914
The class 'SlotService' has a Modified Cyclomatic Complexity of 3 (Highest = 16). 64914
The class 'SlotService' has a Standard Cyclomatic Complexity of 3 (Highest = 16). 64914
Avoid using implementation types like 'HashMap'; use the interface instead 123
Avoid using implementation types like 'HashMap'; use the interface instead 123
The method 'buildListSlot' has a Cyclomatic Complexity of 21. 192344
Avoid really long methods. 192344
Avoid using implementation types like 'HashMap'; use the interface instead 192
Avoid using implementation types like 'HashMap'; use the interface instead 192
The method 'buildListSlot' has a Standard Cyclomatic Complexity of 16. 192344
The method 'buildListSlot' has a Modified Cyclomatic Complexity of 16. 192344
Assigning an Object to null is a code smell. Consider refactoring. 247
Avoid variables with short names like t 429
Avoid variables with short names like t2 522
Avoid variables with short names like t1 522
The method 'updateSlotWithShift' has a Cyclomatic Complexity of 11. 561702
Avoid really long methods. 561702
The method 'updateSlotWithShift' has a Standard Cyclomatic Complexity of 11. 561702
The method 'updateSlotWithShift' has a Modified Cyclomatic Complexity of 11. 561702
Avoid variables with short names like s1 624
Avoid variables with short names like s2 624

fr/paris/lutece/plugins/appointment/service/TimeSlotService.java

Violation Ligne
Avoid really long methods. 246369
Avoid variables with short names like t2 294
Avoid variables with short names like t1 294
Avoid variables with short names like x 394
Avoid variables with short names like t2 402
Avoid variables with short names like t1 402
Avoid variables with short names like x 457
Avoid variables with short names like x 521
Avoid variables with short names like x 535

fr/paris/lutece/plugins/appointment/service/Utilities.java

Violation Ligne
Avoid variables with short names like x 92
Avoid variables with short names like x 106

fr/paris/lutece/plugins/appointment/service/WeekDefinitionService.java

Violation Ligne
Avoid variables with short names like w2 218
Avoid variables with short names like w1 218
Avoid variables with short names like x 227
Consider simply returning the value vs storing it in local variable 'weekDefinition' 249
Avoid variables with short names like x 267
Avoid variables with short names like w2 270
Avoid variables with short names like w1 270
Avoid using implementation types like 'HashMap'; use the interface instead 327
Avoid using implementation types like 'HashMap'; use the interface instead 327
Avoid using implementation types like 'HashSet'; use the interface instead 448
Avoid using implementation types like 'HashSet'; use the interface instead 448
Avoid using implementation types like 'HashSet'; use the interface instead 465
Avoid using implementation types like 'HashSet'; use the interface instead 465

fr/paris/lutece/plugins/appointment/service/WorkingDayService.java

Violation Ligne
Consider simply returning the value vs storing it in local variable 'workingDay' 202
Avoid using implementation types like 'HashSet'; use the interface instead 342
Avoid using implementation types like 'HashSet'; use the interface instead 342
Avoid variables with short names like x 369

fr/paris/lutece/plugins/appointment/service/entrytype/EntryTypeImage.java

Violation Ligne
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 107

fr/paris/lutece/plugins/appointment/service/lock/TimerForLockOnSlot.java

Violation Ligne
Avoid unnecessary constructors - the compiler will generate these for you 5053

fr/paris/lutece/plugins/appointment/web/AbstractAppointmentFormAndSlotJspBean.java

Violation Ligne
Use explicit scoping instead of the default package private level 50
Use explicit scoping instead of the default package private level 51
Use explicit scoping instead of the default package private level 52
Use explicit scoping instead of the default package private level 53
Use explicit scoping instead of the default package private level 54
Avoid excessively long variable names like MESSAGE_ERROR_DAY_DURATION_APPOINTMENT_NOT_MULTIPLE_FORM 54
These nested if statements could be combined 133137

fr/paris/lutece/plugins/appointment/web/AppointmentApp.java

Violation Ligne
A high number of imports can indicate a high degree of coupling within an object. 341630
Possible God class (WMC=191, ATFD=333, TCC=0.2761904761904762) 341630
Avoid unused imports such as 'org.apache.commons.lang.StringEscapeUtils' 56
Avoid unused imports such as 'org.apache.commons.lang.StringEscapeUtils' 56
The class 'AppointmentApp' has a Cyclomatic Complexity of 9 (Highest = 37). 1231630
Avoid really long classes. 1231630
The class 'AppointmentApp' has a Modified Cyclomatic Complexity of 6 (Highest = 26). 1231630
The class 'AppointmentApp' has a Standard Cyclomatic Complexity of 6 (Highest = 26). 1231630
Private field 'idEntryKiosque' could be made final; it is only initialized in the declaration or constructor. 292
Private field 'idEntryCleSecurite' could be made final; it is only initialized in the declaration or constructor. 293
Private field 'idEntryDates' could be made final; it is only initialized in the declaration or constructor. 294
Private field 'idEntryNumero' could be made final; it is only initialized in the declaration or constructor. 295
Private field 'idEntryEmail' could be made final; it is only initialized in the declaration or constructor. 296
Private field 'amplitude' could be made final; it is only initialized in the declaration or constructor. 297
Private field 'animations' could be made final; it is only initialized in the declaration or constructor. 298
Private field 'horaireMaxAM' could be made final; it is only initialized in the declaration or constructor. 299
Private field 'horaireMinPM' could be made final; it is only initialized in the declaration or constructor. 300
The method 'getViewAppointmentCalendar' has a Cyclomatic Complexity of 31. 327547
The method 'getViewAppointmentCalendar' has a Modified Cyclomatic Complexity of 21. 327547
The method 'getViewAppointmentCalendar' has a Standard Cyclomatic Complexity of 24. 327547
The method getViewAppointmentCalendar() has an NPath complexity of 4262400 327547
The method getViewAppointmentCalendar() has an NCSS line count of 133 327547
Avoid really long methods. 327547
Avoid using Literals in Conditional Statements 399
Avoid variables with short names like w 407
Avoid variables with short names like s 431
Avoid variables with short names like s 437
Deeply nested if..then statements are hard to read 439443
Avoid variables with short names like s2 441
Avoid variables with short names like s1 441
Avoid variables with short names like s 516
Avoid variables with short names like s 523
The method 'getViewAppointmentForm' has a Standard Cyclomatic Complexity of 26. 559773
Avoid really long methods. 559773
The method getViewAppointmentForm() has an NCSS line count of 132 559773
The method 'getViewAppointmentForm' has a Modified Cyclomatic Complexity of 26. 559773
The method 'getViewAppointmentForm' has a Cyclomatic Complexity of 37. 559773
The method getViewAppointmentForm() has an NPath complexity of 6881280 559773
StringBuffer constructor is initialized with size 16, but has at least 59 characters appended. 734
Avoid really long methods. 785936
The method 'doValidateForm' has a Standard Cyclomatic Complexity of 20. 785936
The method 'doValidateForm' has a Modified Cyclomatic Complexity of 20. 785936
The method 'doValidateForm' has a Cyclomatic Complexity of 26. 785936
The method doValidateForm() has an NPath complexity of 53280 785936
When instantiating a SimpleDateFormat object, specify a Locale 823
Prefer StringBuffer over += for concatenating strings 833
Prefer StringBuffer over += for concatenating strings 840
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 927
The method 'displayRecapAppointment' has a Cyclomatic Complexity of 10. 947987
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 960
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 969
Avoid variables with short names like t 982
Avoid declaring a variable if it is unreferenced before a possible exit point. 1002
These nested if statements could be combined 10091013
debug logging that involves string concatenation should be guarded with isDebugEnabled() checks 1082
Prefer StringBuffer over += for concatenating strings 1094
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 1098
The method 'getViewCancelAppointment' has a Cyclomatic Complexity of 10. 11401192
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 1155
The method 'doCancelAppointment' has a Cyclomatic Complexity of 10. 12021250
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 1223
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 1234
The method 'getAppointmentCanceled' has a Cyclomatic Complexity of 10. 12601282
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 1272
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 1336
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 1357
Avoid variables with short names like a 1365
Avoid variables with short names like a1 1367
Avoid variables with short names like a2 1367
These nested if statements could be combined 14941498
The method 'doFillAppointement' has a Cyclomatic Complexity of 10. 15251573
Prefer StringBuffer over += for concatenating strings 1557
Prefer StringBuffer over += for concatenating strings 1561
Prefer StringBuffer over += for concatenating strings 1564
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 1589

fr/paris/lutece/plugins/appointment/web/AppointmentCategoryJspBean.java

Violation Ligne
Document empty constructor 119121
Avoid unnecessary constructors - the compiler will generate these for you 119121
It is a good practice to call super() in a constructor 119121

fr/paris/lutece/plugins/appointment/web/AppointmentFormDashboardComponent.java

Violation Ligne
Avoid variables with short names like a1 84
Avoid variables with short names like a2 84
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 85

fr/paris/lutece/plugins/appointment/web/AppointmentFormEntryJspBean.java

Violation Ligne
A high number of imports can indicate a high degree of coupling within an object. 34758
The class 'AppointmentFormEntryJspBean' has a Standard Cyclomatic Complexity of 4 (Highest = 10). 84758
The class 'AppointmentFormEntryJspBean' has a Modified Cyclomatic Complexity of 4 (Highest = 10). 84758
The class 'AppointmentFormEntryJspBean' has a Cyclomatic Complexity of 5 (Highest = 13). 84758
Private field '_entryService' could be made final; it is only initialized in the declaration or constructor. 146
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 211
The method 'doCreateEntry' has a Cyclomatic Complexity of 13. 233285
The method doCreateEntry() has an NPath complexity of 234 233285
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 315
The method 'doModifyEntry' has a Cyclomatic Complexity of 11. 343397
The method 'doModifyEntry' has a Standard Cyclomatic Complexity of 10. 343397
The method 'doModifyEntry' has a Modified Cyclomatic Complexity of 10. 343397
Deeply nested if..then statements are hard to read 357360
Deeply nested if..then statements are hard to read 368377
Avoid declaring a variable if it is unreferenced before a possible exit point. 433
The method 'doChangeOrderEntry' has a Cyclomatic Complexity of 11. 586636

fr/paris/lutece/plugins/appointment/web/AppointmentFormFieldJspBean.java

Violation Ligne
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 135
Avoid declaring a variable if it is unreferenced before a possible exit point. 455
Avoid declaring a variable if it is unreferenced before a possible exit point. 456
Avoid declaring a variable if it is unreferenced before a possible exit point. 457

fr/paris/lutece/plugins/appointment/web/AppointmentFormJspBean.java

Violation Ligne
A high number of imports can indicate a high degree of coupling within an object. 34832
The class 'AppointmentFormJspBean' has a Standard Cyclomatic Complexity of 3 (Highest = 10). 105832
The class 'AppointmentFormJspBean' has a Cyclomatic Complexity of 4 (Highest = 11). 105832
The class 'AppointmentFormJspBean' has a Modified Cyclomatic Complexity of 3 (Highest = 10). 105832
Private field '_nDefaultItemsPerPage' could be made final; it is only initialized in the declaration or constructor. 115
Avoid excessively long variable names like PROPERTY_PAGE_TITLE_MODIFY_APPOINTMENTFORM_MESSAGES 139
Avoid excessively long variable names like ERROR_APPOINTMENTFORM_ENDING_VALIDITY_DATE_BEFORE_NOW 196
It is a good practice to call super() in a constructor 207210
Avoid variables with short names like a2 238
Avoid variables with short names like a1 238
The method 'doModifyAppointmentForm' has a Cyclomatic Complexity of 10. 423471
The method doModifyAppointmentForm() has an NPath complexity of 360 423471
The method 'doChangeFormActivation' has a Cyclomatic Complexity of 10. 483531
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 589
The method 'importClosingDayFile' has a Modified Cyclomatic Complexity of 10. 742811
The method 'importClosingDayFile' has a Cyclomatic Complexity of 11. 742811
The method 'importClosingDayFile' has a Standard Cyclomatic Complexity of 10. 742811
Avoid empty catch blocks 759761

fr/paris/lutece/plugins/appointment/web/AppointmentJspBean.java

Violation Ligne
A high number of imports can indicate a high degree of coupling within an object. 341598
Avoid unused imports such as 'fr.paris.lutece.plugins.appointment.business.AppointmentFillDTO' 57
Avoid unused imports such as 'fr.paris.lutece.plugins.appointment.business.AppointmentFillDTO' 57
Avoid really long classes. 1361598
The class 'AppointmentJspBean' has a Standard Cyclomatic Complexity of 6 (Highest = 15). 1361598
The class 'AppointmentJspBean' has a Cyclomatic Complexity of 7 (Highest = 20). 1361598
The class 'AppointmentJspBean' has a Modified Cyclomatic Complexity of 5 (Highest = 15). 1361598
Private field '_nDefaultItemsPerPage' could be made final; it is only initialized in the declaration or constructor. 321
Private field 'amplitude' could be made final; it is only initialized in the declaration or constructor. 323
Private field 'animations' could be made final; it is only initialized in the declaration or constructor. 324
Private field 'horaireMaxAM' could be made final; it is only initialized in the declaration or constructor. 325
Private field 'horaireMinPM' could be made final; it is only initialized in the declaration or constructor. 326
Avoid really long methods. 337443
The method 'getViewCalendarManageAppointments' has a Modified Cyclomatic Complexity of 13. 337443
The method getViewCalendarManageAppointments() has an NPath complexity of 1920 337443
The method 'getViewCalendarManageAppointments' has a Standard Cyclomatic Complexity of 13. 337443
The method 'getViewCalendarManageAppointments' has a Cyclomatic Complexity of 13. 337443
Avoid variables with short names like s 403
Avoid variables with short names like s 421
The String literal "unchecked" appears 5 times in this file; the first occurrence is on line 454 454
The method 'getManageAppointments' has a Standard Cyclomatic Complexity of 14. 456586
The method 'getManageAppointments' has a Modified Cyclomatic Complexity of 14. 456586
The method getManageAppointments() has an NPath complexity of 5760 456586
The method 'getManageAppointments' has a Cyclomatic Complexity of 17. 456586
Avoid really long methods. 456586
Avoid declaring a variable if it is unreferenced before a possible exit point. 620
Avoid variables with short names like a 634
Avoid declaring a variable if it is unreferenced before a possible exit point. 670
Avoid variables with short names like a 693
The method 'getViewAppointment' has a Cyclomatic Complexity of 10. 710781
Avoid declaring a variable if it is unreferenced before a possible exit point. 715
Avoid declaring a variable if it is unreferenced before a possible exit point. 716717
Avoid declaring a variable if it is unreferenced before a possible exit point. 719
The method getViewCreateAppointment() has an NPath complexity of 2016 8931022
Avoid really long methods. 8931022
The method 'getViewCreateAppointment' has a Standard Cyclomatic Complexity of 15. 8931022
The method 'getViewCreateAppointment' has a Modified Cyclomatic Complexity of 15. 8931022
The method 'getViewCreateAppointment' has a Cyclomatic Complexity of 20. 8931022
Avoid declaring a variable if it is unreferenced before a possible exit point. 897
StringBuffer constructor is initialized with size 16, but has at least 156 characters appended. 974
The method 'doValidateForm' has a Modified Cyclomatic Complexity of 13. 10351130
The method 'doValidateForm' has a Cyclomatic Complexity of 19. 10351130
The method 'doValidateForm' has a Standard Cyclomatic Complexity of 13. 10351130
The method doValidateForm() has an NPath complexity of 1296 10351130
When instantiating a SimpleDateFormat object, specify a Locale 1077
Prefer StringBuffer over += for concatenating strings 1087
Prefer StringBuffer over += for concatenating strings 1094
Avoid declaring a variable if it is unreferenced before a possible exit point. 1145
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 1189
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 1208
The method 'doMakeAppointment' has a Modified Cyclomatic Complexity of 10. 12351310
The method 'doMakeAppointment' has a Cyclomatic Complexity of 11. 12351310
The method 'doMakeAppointment' has a Standard Cyclomatic Complexity of 10. 12351310
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 1306
It is a good practice to call super() in a constructor 13341337
The method 'orderList' has a Standard Cyclomatic Complexity of 12. 13761425
Avoid reassigning parameters such as 'strOrderBy' 1376
The method 'orderList' has a Cyclomatic Complexity of 12. 13761425
A switch statement does not contain a break 13931418
Avoid variables with short names like a1 1396
Avoid variables with short names like a2 1396
Avoid variables with short names like a1 1399
Avoid variables with short names like a2 1399
Avoid variables with short names like a2 1402
Avoid variables with short names like a1 1402
Avoid variables with short names like a1 1405
Avoid variables with short names like a2 1405
Avoid variables with short names like a2 1408
Avoid variables with short names like a1 1408
Avoid variables with short names like a1 1411
Avoid variables with short names like a2 1411
Avoid variables with short names like a1 1414
Avoid variables with short names like a2 1414
Avoid variables with short names like a1 1417
Avoid variables with short names like a2 1417
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 1470
The method 'doProcessWorkflowAction' has a Cyclomatic Complexity of 13. 14891542
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 1530
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 1534
Avoid declaring a variable if it is unreferenced before a possible exit point. 1561

fr/paris/lutece/plugins/appointment/web/AppointmentSessionListener.java

Violation Ligne
Avoid variables with short names like se 51
Avoid variables with short names like se 60

fr/paris/lutece/plugins/appointment/web/AppointmentSlotJspBean.java

Violation Ligne
A high number of imports can indicate a high degree of coupling within an object. 34871
The class 'AppointmentSlotJspBean' has a Modified Cyclomatic Complexity of 5 (Highest = 10). 92871
The class 'AppointmentSlotJspBean' has a Cyclomatic Complexity of 6 (Highest = 14). 92871
The class 'AppointmentSlotJspBean' has a Standard Cyclomatic Complexity of 5 (Highest = 10). 92871
Avoid excessively long variable names like MESSAGE_ERROR_MODIFY_FORM_HAS_APPOINTMENTS_AFTER_DATE_OF_MODIFICATION 119
Avoid declaring a variable if it is unreferenced before a possible exit point. 269
Avoid declaring a variable if it is unreferenced before a possible exit point. 371
Avoid variables with short names like w 375
The method doModifyTimeSlot() has an NPath complexity of 396 438529
The method 'doModifyTimeSlot' has a Standard Cyclomatic Complexity of 10. 438529
The method 'doModifyTimeSlot' has a Modified Cyclomatic Complexity of 10. 438529
The method 'doModifyTimeSlot' has a Cyclomatic Complexity of 13. 438529
Avoid declaring a variable if it is unreferenced before a possible exit point. 442
Avoid declaring a variable if it is unreferenced before a possible exit point. 444
Avoid declaring a variable if it is unreferenced before a possible exit point. 455
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 474
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 499
Avoid unnecessary comparisons in boolean expressions 508
These nested if statements could be combined 562565
Avoid variables with short names like s 578
The method 'doModifySlot' has a Cyclomatic Complexity of 14. 646723
The method doModifySlot() has an NPath complexity of 1440 646723
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 719

fr/paris/lutece/plugins/appointment/web/CalendarTemplateJspBean.java

Violation Ligne
The class 'CalendarTemplateJspBean' has a Modified Cyclomatic Complexity of 4 (Highest = 10). 70379
The class 'CalendarTemplateJspBean' has a Cyclomatic Complexity of 5 (Highest = 12). 70379
The class 'CalendarTemplateJspBean' has a Standard Cyclomatic Complexity of 4 (Highest = 10). 70379
Assigning an Object to null is a code smell. Consider refactoring. 158
The method 'getCreateModifyTemplate' has a Modified Cyclomatic Complexity of 10. 190251
The method 'getCreateModifyTemplate' has a Cyclomatic Complexity of 12. 190251
The method 'getCreateModifyTemplate' has a Standard Cyclomatic Complexity of 10. 190251
Deeply nested if..then statements are hard to read 231234

fr/paris/lutece/plugins/appointment/web/dto/AppointmentDTO.java

Violation Ligne
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 133
A getX() method which returns a boolean should be named isX() 255258

fr/paris/lutece/plugins/appointment/web/dto/AppointmentFilterDTO.java

Violation Ligne
Assigning an Object to null is a code smell. Consider refactoring. 136
Assigning an Object to null is a code smell. Consider refactoring. 172

fr/paris/lutece/plugins/appointment/web/dto/AppointmentFormDTO.java

Violation Ligne
This class has a bunch of public methods and attributes 341065
Avoid really long classes. 571065
Too many fields 571065
The String literal "#i18n{portal.validation.message.notEmpty}" appears 8 times in this file; the first occurrence is on line 90 90
Assigning an Object to null is a code smell. Consider refactoring. 355
A getX() method which returns a boolean should be named isX() 485488
A getX() method which returns a boolean should be named isX() 506509
A getX() method which returns a boolean should be named isX() 527530
A getX() method which returns a boolean should be named isX() 548551
A getX() method which returns a boolean should be named isX() 569572
A getX() method which returns a boolean should be named isX() 590593
A getX() method which returns a boolean should be named isX() 611614
Assigning an Object to null is a code smell. Consider refactoring. 658
Assigning an Object to null is a code smell. Consider refactoring. 693
A getX() method which returns a boolean should be named isX() 702705
A getX() method which returns a boolean should be named isX() 723726
A getX() method which returns a boolean should be named isX() 744747
A getX() method which returns a boolean should be named isX() 807810
A getX() method which returns a boolean should be named isX() 849852
A getX() method which returns a boolean should be named isX() 933936

fr/paris/lutece/plugins/appointment/web/dto/ResponseRecapDTO.java

Violation Ligne
Private field '_response' could be made final; it is only initialized in the declaration or constructor. 64
It is a good practice to call super() in a constructor 7275
It is a good practice to call super() in a constructor 8589
Avoid variables with short names like o 176
Avoid variables with short names like o 187

fr/paris/lutece/plugins/appointment/web/portlet/AppointmentFormListPortletJspBean.java

Violation Ligne
Avoid declaring a variable if it is unreferenced before a possible exit point. 65

fr/paris/lutece/plugins/appointment/web/portlet/AppointmentFormPortletJspBean.java

Violation Ligne
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 94
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 121
Avoid declaring a variable if it is unreferenced before a possible exit point. 139

fr/paris/lutece/plugins/appointment/web/portlet/AppointmentPortletJspBean.java

Violation Ligne
Avoid declaring a variable if it is unreferenced before a possible exit point. 65

fr/paris/lutece/plugins/appointment/web/rs/FormRest.java

Violation Ligne
Avoid unnecessary constructors - the compiler will generate these for you 5861