Fork me on GitHub

PMD Results

The following document contains the results of PMD 5.5.1.

Files

fr/paris/lutece/plugins/archivagedansmarue/business/dao/IArchivageDAO.java

Violation Line
Avoid modifiers which are implied by the context 51
Avoid modifiers which are implied by the context 58
Avoid modifiers which are implied by the context 65
Avoid modifiers which are implied by the context 72
Avoid modifiers which are implied by the context 79
Avoid modifiers which are implied by the context 118

fr/paris/lutece/plugins/archivagedansmarue/business/dao/IReferentielDAO.java

Violation Line
Avoid modifiers which are implied by the context 44

fr/paris/lutece/plugins/archivagedansmarue/business/dao/ISignalementDAO.java

Violation Line
Avoid modifiers which are implied by the context 67
Avoid modifiers which are implied by the context 78
Avoid modifiers which are implied by the context 88
Avoid modifiers which are implied by the context 98
Avoid modifiers which are implied by the context 108
Avoid modifiers which are implied by the context 118
Avoid modifiers which are implied by the context 141
Avoid modifiers which are implied by the context 150
Avoid modifiers which are implied by the context 158
Avoid modifiers which are implied by the context 166
Avoid modifiers which are implied by the context 174
Avoid modifiers which are implied by the context 182

fr/paris/lutece/plugins/archivagedansmarue/business/dao/impl/ArchivageDAO.java

Violation Line
The String literal " select id_archivage, date_debut, date_fin, nb_signalement_archives_init," appears 4 times in this file; the first occurrence is on line 53 53
The String literal " nb_signalement_insere, nb_signalement_en_erreur, nb_signalement_prod_init, nb_signalement_supprime, extract(" appears 4 times in this file; the first occurrence is on line 54 54
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 283

fr/paris/lutece/plugins/archivagedansmarue/business/dao/impl/PluginArchivageDAO.java

Violation Line
This abstract class does not have any abstract methods 72288
Abstract classes should be named AbstractXXX 72288
Avoid unused private fields such as 'PARAMETER_AGENT'. 77
Avoid variables with short names like ts 125
When instantiating a SimpleDateFormat object, specify a Locale 126
Avoid appending characters as strings in StringBuffer.append. 164
Avoid appending characters as strings in StringBuffer.append. 169
Avoid declaring a variable if it is unreferenced before a possible exit point. 184
When instantiating a SimpleDateFormat object, specify a Locale 193
When instantiating a SimpleDateFormat object, specify a Locale 197
Unnecessary use of fully qualified name 'java.sql.Timestamp' due to existing import 'java.sql.Timestamp' 200
Avoid unused private methods such as 'decryptMail(String)'. 270
Avoid unused local variables such as 'domain'. 272

fr/paris/lutece/plugins/archivagedansmarue/business/dao/impl/ReferentielDAO.java

Violation Line
Ensure that resources like this ResultSet object are closed after use 60
Avoid concatenating nonliterals in a StringBuffer/StringBuilder constructor or append(). 132
Avoid appending characters as strings in StringBuffer.append. 137

fr/paris/lutece/plugins/archivagedansmarue/business/dao/impl/SignalementDAO.java

Violation Line
The String literal "select" appears 5 times in this file; the first occurrence is on line 59 59
The String literal " from " appears 4 times in this file; the first occurrence is on line 67 67
Avoid excessively long variable names like SQL_QUERY_INSERT_SIGNALEMENT_SIGNALEMENT_WITHOUT_SECTOR 99

fr/paris/lutece/plugins/archivagedansmarue/business/dao/impl/WorkflowDAO.java

Violation Line
Too many fields 59622
The field name indicates a constant but its modifiers do not 6265
Private field 'SQL_QUERY_SELECT_OLD_WORKFLOW_HISTORY' could be made final; it is only initialized in the declaration or constructor. 62
The String literal "from\r\n" appears 7 times in this file; the first occurrence is on line 64 64
The String literal "where\r\n" appears 7 times in this file; the first occurrence is on line 64 64
The field name indicates a constant but its modifiers do not 6667
Private field 'SQL_QUERY_SELECT_OLD_WORKFLOW_COMMENT_VALUE' could be made final; it is only initialized in the declaration or constructor. 66
The field name indicates a constant but its modifiers do not 6875
Private field 'SQL_QUERY_SELECT_OLD_WORKFLOW_GRU' could be made final; it is only initialized in the declaration or constructor. 68
The String literal "select \r\n" appears 5 times in this file; the first occurrence is on line 68 68
Avoid excessively long variable names like SQL_QUERY_SELECT_OLD_SIGNALEMENT_WORKFLOW_MUTLI_CONTENTS 76
The field name indicates a constant but its modifiers do not 7678
Private field 'SQL_QUERY_SELECT_OLD_SIGNALEMENT_WORKFLOW_MUTLI_CONTENTS' could be made final; it is only initialized in the declaration or constructor. 76
Private field 'SQL_QUERY_SELECT_OLD_SIGNALEMENT_WORKFLOW_USER' could be made final; it is only initialized in the declaration or constructor. 79
The field name indicates a constant but its modifiers do not 7980
Private field 'SQL_QUERY_SELECT_OLD_SIGNALEMENT_WORKFLOW_PUSH' could be made final; it is only initialized in the declaration or constructor. 81
The field name indicates a constant but its modifiers do not 8183
Private field 'SQL_QUERY_SELECT_OLD_SIGNALEMENT_WORKFLOW_SUIVI' could be made final; it is only initialized in the declaration or constructor. 84
The field name indicates a constant but its modifiers do not 8486
Private field 'SQL_QUERY_INSERT_WORKFLOW_HISTORY' could be made final; it is only initialized in the declaration or constructor. 87
The field name indicates a constant but its modifiers do not 8788
The field name indicates a constant but its modifiers do not 8990
Private field 'SQL_QUERY_INSERT_WORKFLOW_TASK_COMMENT_VALUE' could be made final; it is only initialized in the declaration or constructor. 89
The String literal "VALUES(?, ?, ?);" appears 5 times in this file; the first occurrence is on line 90 90
The field name indicates a constant but its modifiers do not 9193
Private field 'SQL_QUERY_INSERT_WORKFLOW_TASK_NOTIFY_GRU_HISTORY' could be made final; it is only initialized in the declaration or constructor. 91
Do not add empty strings 93
Private field 'SQL_QUERY_INSERT_SIGNALEMENT_WORKFLOW_NOTIFUSER_MULTI_CONTENTS_VALUE' could be made final; it is only initialized in the declaration or constructor. 94
Avoid excessively long variable names like SQL_QUERY_INSERT_SIGNALEMENT_WORKFLOW_NOTIFUSER_MULTI_CONTENTS_VALUE 94
The field name indicates a constant but its modifiers do not 9495
Avoid excessively long variable names like SQL_QUERY_INSERT_SIGNALEMENT_WORKFLOW_NOTIFUSER_WITHOUT_ID_MESSAGE 96
Private field 'SQL_QUERY_INSERT_SIGNALEMENT_WORKFLOW_NOTIFUSER_WITHOUT_ID_MESSAGE' could be made final; it is only initialized in the declaration or constructor. 96
The field name indicates a constant but its modifiers do not 9697
The field name indicates a constant but its modifiers do not 99100
Avoid excessively long variable names like SQL_QUERY_INSERT_SIGNALEMENT_WORKFLOW_NOTIFICATION_USER_VALUE 99
Private field 'SQL_QUERY_INSERT_SIGNALEMENT_WORKFLOW_NOTIFICATION_USER_VALUE' could be made final; it is only initialized in the declaration or constructor. 99
Private field 'SQL_QUERY_INSERT_SIGNALEMENT_WORKFLOW_NOTIFICATION_PUSH_VALUE' could be made final; it is only initialized in the declaration or constructor. 101
The field name indicates a constant but its modifiers do not 101102
Avoid excessively long variable names like SQL_QUERY_INSERT_SIGNALEMENT_WORKFLOW_NOTIFICATION_PUSH_VALUE 101
Private field 'SQL_QUERY_INSERT_SIGNALEMENT_WORKFLOW_NOTIFICATION_SUIVI_VALUE' could be made final; it is only initialized in the declaration or constructor. 103
The field name indicates a constant but its modifiers do not 103104
Avoid excessively long variable names like SQL_QUERY_INSERT_SIGNALEMENT_WORKFLOW_NOTIFICATION_SUIVI_VALUE 103
The String literal "WHERE id_history in (" appears 7 times in this file; the first occurrence is on line 105 105
Private field 'SQL_QUERY_DELETE_WORKFLOW_HISTORY' could be made final; it is only initialized in the declaration or constructor. 105
The field name indicates a constant but its modifiers do not 105
The field name indicates a constant but its modifiers do not 106
Private field 'SQL_QUERY_DELETE_WORKFLOW_TASK_COMMENT_VALUE' could be made final; it is only initialized in the declaration or constructor. 106
The field name indicates a constant but its modifiers do not 107
Private field 'SQL_QUERY_DELETE_WORKFLOW_TASK_NOTIFY_GRU_HISTORY' could be made final; it is only initialized in the declaration or constructor. 107
Avoid excessively long variable names like SQL_QUERY_DELETE_SIGNALEMENT_WORKFLOW_NOTIFUSER_MULTI_CONTENTS_VALUE 108
The field name indicates a constant but its modifiers do not 108
Private field 'SQL_QUERY_DELETE_SIGNALEMENT_WORKFLOW_NOTIFUSER_MULTI_CONTENTS_VALUE' could be made final; it is only initialized in the declaration or constructor. 108
Private field 'SQL_QUERY_DELETE_SIGNALEMENT_WORKFLOW_NOTIFICATION_USER_VALUE' could be made final; it is only initialized in the declaration or constructor. 109
The field name indicates a constant but its modifiers do not 109
Avoid excessively long variable names like SQL_QUERY_DELETE_SIGNALEMENT_WORKFLOW_NOTIFICATION_USER_VALUE 109
The field name indicates a constant but its modifiers do not 110
Avoid excessively long variable names like SQL_QUERY_DELETE_SIGNALEMENT_WORKFLOW_NOTIFICATION_PUSH_VALUE 110
Private field 'SQL_QUERY_DELETE_SIGNALEMENT_WORKFLOW_NOTIFICATION_PUSH_VALUE' could be made final; it is only initialized in the declaration or constructor. 110
Avoid excessively long variable names like SQL_QUERY_DELETE_SIGNALEMENT_WORKFLOW_NOTIFICATION_SUIVI_VALUE 111
The field name indicates a constant but its modifiers do not 111
Private field 'SQL_QUERY_DELETE_SIGNALEMENT_WORKFLOW_NOTIFICATION_SUIVI_VALUE' could be made final; it is only initialized in the declaration or constructor. 111

fr/paris/lutece/plugins/archivagedansmarue/business/entities/Archivage.java

Violation Line
Too many fields 41440

fr/paris/lutece/plugins/archivagedansmarue/business/entities/SignalementSelectExport.java

Violation Line
This class has a bunch of public methods and attributes 34462
Too many fields 41462

fr/paris/lutece/plugins/archivagedansmarue/business/entities/SignalementSelectPhoto.java

Violation Line
Returning '_imageContent' may expose an internal array. 72
The user-supplied array 'imageContent' is stored directly. 75
Returning '_imageThumbnail' may expose an internal array. 82
The user-supplied array 'imageThumbnail' is stored directly. 85

fr/paris/lutece/plugins/archivagedansmarue/business/entities/SignalementSelectReportData.java

Violation Line
This class has a bunch of public methods and attributes 34438
Too many fields 41438

fr/paris/lutece/plugins/archivagedansmarue/daemon/ArchivageDaemon.java

Violation Line
Private field '_archivageService' could be made final; it is only initialized in the declaration or constructor. 63
Private field '_workflowService' could be made final; it is only initialized in the declaration or constructor. 64
Private field '_signalementService' could be made final; it is only initialized in the declaration or constructor. 65
Private field '_referentielService' could be made final; it is only initialized in the declaration or constructor. 66
The Logger variable declaration does not contain the static and final modifiers 67
The method run() has an NCSS line count of 105 70254
Avoid really long methods. 70254

fr/paris/lutece/plugins/archivagedansmarue/daemon/ArchivagePhotoDaemon.java

Violation Line
Private field '_signalementService' could be made final; it is only initialized in the declaration or constructor. 50
The Logger variable declaration does not contain the static and final modifiers 51

fr/paris/lutece/plugins/archivagedansmarue/service/IArchivageService.java

Violation Line
Avoid modifiers which are implied by the context 72
Avoid modifiers which are implied by the context 79

fr/paris/lutece/plugins/archivagedansmarue/service/IReferentielService.java

Violation Line
Avoid modifiers which are implied by the context 46

fr/paris/lutece/plugins/archivagedansmarue/service/impl/ReferentielService.java

Violation Line
Private field '_strTablesReferentiel' could be made final; it is only initialized in the declaration or constructor. 49

fr/paris/lutece/plugins/archivagedansmarue/service/impl/SignalementService.java

Violation Line
Possible God class (WMC=74, ATFD=29, TCC=0.016194331983805668) 34731
Deeply nested if..then statements are hard to read 277280
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 350
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 388
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 438
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 458
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 510
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 530
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 580
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 601
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 651
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 672
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 722

fr/paris/lutece/plugins/archivagedansmarue/service/impl/WorkflowService.java

Violation Line
Possible God class (WMC=69, ATFD=46, TCC=0.028225806451612902) 34736
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 290
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 354
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 390
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 425
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 463
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 500
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 537
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 569
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 591
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 635
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 657
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 679
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 701
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 728

fr/paris/lutece/plugins/archivagedansmarue/web/AbstractJspBean.java

Violation Line
Avoid unused private fields such as '_request'. 48
Perhaps '_request' could be replaced by a local variable. 48

fr/paris/lutece/plugins/archivagedansmarue/web/StatArchivageJspBean.java

Violation Line
Private field '_archivageService' could be made final; it is only initialized in the declaration or constructor. 70
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 89
Avoid variables with short names like t 95