Fork me on GitHub

PMD Results

The following document contains the results of PMD 6.13.0.

Violations By Priority

Priority 1

fr/paris/lutece/plugins/asynchronousupload/service/AbstractAsynchronousUploadHandler.java

Rule Violation Line
EmptyMethodInAbstractClassShouldBeAbstract An empty method in an abstract class should be abstract instead 417–419

Priority 3

fr/paris/lutece/plugins/asynchronousupload/service/AbstractAsynchronousUploadHandler.java

Rule Violation Line
CyclomaticComplexity The method 'process(HttpServletRequest, HttpServletResponse, Map, List)' has a cyclomatic complexity of 11. 87–148
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 105
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 142
AvoidReassigningLoopVariables Avoid reassigning the loop control variable 'nFieldIndex' 266
UncommentedEmptyMethodBody Document empty method body 418–419
ShortVariable Avoid variables with short names like r 445
ShortVariable Avoid variables with short names like m 446
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 455
CommentRequired Protected method constructor comments are required 465–474

fr/paris/lutece/plugins/asynchronousupload/service/AsynchronousUploadHandler.java

Rule Violation Line
CommentRequired Header comments are required 54–180

fr/paris/lutece/plugins/asynchronousupload/service/AsynchronousUploadSessionListener.java

Rule Violation Line
ShortVariable Avoid variables with short names like se 50
ShortVariable Avoid variables with short names like se 59

fr/paris/lutece/plugins/asynchronousupload/service/IAsyncUploadHandler.java

Rule Violation Line
TooManyMethods This class has too many methods, consider refactoring it. 50–243
LinguisticNaming Linguistics Antipattern - The method 'canUploadFiles' indicates linguistically it returns a boolean, but it returns 'String' 85
UncommentedEmptyMethodBody Document empty method body 241–242

fr/paris/lutece/plugins/asynchronousupload/service/PartialFileItemGroup.java

Rule Violation Line
ImmutableField Private field '_items' could be made final; it is only initialized in the declaration or constructor. 61
ImmutableField Private field '_sequenceInputStream' could be made final; it is only initialized in the declaration or constructor. 62

fr/paris/lutece/plugins/asynchronousupload/service/UploadCacheService.java

Rule Violation Line
CallSuperInConstructor It is a good practice to call super() in a constructor 49–52

fr/paris/lutece/plugins/asynchronousupload/util/JSONUtils.java

Rule Violation Line
ConfusingTernary Avoid if (x != y) ..; else ..; 97–131
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 99

fr/paris/lutece/plugins/asynchronousupload/web/AsynchronousUploadApp.java

Rule Violation Line
NPathComplexity The method 'getMainUploadJs(HttpServletRequest, Boolean)' has an NPath complexity of 512 111–211
NcssCount The method 'getMainUploadJs(HttpServletRequest, Boolean)' has a NCSS line count of 61. 111–211
CyclomaticComplexity The method 'getMainUploadJs(HttpServletRequest, Boolean)' has a cyclomatic complexity of 10. 111–211
ExcessiveMethodLength Avoid really long methods. 111–211
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 115
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 126
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 181

Files

fr/paris/lutece/plugins/asynchronousupload/service/AbstractAsynchronousUploadHandler.java

Rule Violation Priority Line
CyclomaticComplexity The method 'process(HttpServletRequest, HttpServletResponse, Map, List)' has a cyclomatic complexity of 11. 3 87–148
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 3 105
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 142
AvoidReassigningLoopVariables Avoid reassigning the loop control variable 'nFieldIndex' 3 266
EmptyMethodInAbstractClassShouldBeAbstract An empty method in an abstract class should be abstract instead 1 417–419
UncommentedEmptyMethodBody Document empty method body 3 418–419
ShortVariable Avoid variables with short names like r 3 445
ShortVariable Avoid variables with short names like m 3 446
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 3 455
CommentRequired Protected method constructor comments are required 3 465–474

fr/paris/lutece/plugins/asynchronousupload/service/AsynchronousUploadHandler.java

Rule Violation Priority Line
CommentRequired Header comments are required 3 54–180

fr/paris/lutece/plugins/asynchronousupload/service/AsynchronousUploadSessionListener.java

Rule Violation Priority Line
ShortVariable Avoid variables with short names like se 3 50
ShortVariable Avoid variables with short names like se 3 59

fr/paris/lutece/plugins/asynchronousupload/service/IAsyncUploadHandler.java

Rule Violation Priority Line
TooManyMethods This class has too many methods, consider refactoring it. 3 50–243
LinguisticNaming Linguistics Antipattern - The method 'canUploadFiles' indicates linguistically it returns a boolean, but it returns 'String' 3 85
UncommentedEmptyMethodBody Document empty method body 3 241–242

fr/paris/lutece/plugins/asynchronousupload/service/PartialFileItemGroup.java

Rule Violation Priority Line
ImmutableField Private field '_items' could be made final; it is only initialized in the declaration or constructor. 3 61
ImmutableField Private field '_sequenceInputStream' could be made final; it is only initialized in the declaration or constructor. 3 62

fr/paris/lutece/plugins/asynchronousupload/service/UploadCacheService.java

Rule Violation Priority Line
CallSuperInConstructor It is a good practice to call super() in a constructor 3 49–52

fr/paris/lutece/plugins/asynchronousupload/util/JSONUtils.java

Rule Violation Priority Line
ConfusingTernary Avoid if (x != y) ..; else ..; 3 97–131
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 3 99

fr/paris/lutece/plugins/asynchronousupload/web/AsynchronousUploadApp.java

Rule Violation Priority Line
NPathComplexity The method 'getMainUploadJs(HttpServletRequest, Boolean)' has an NPath complexity of 512 3 111–211
NcssCount The method 'getMainUploadJs(HttpServletRequest, Boolean)' has a NCSS line count of 61. 3 111–211
CyclomaticComplexity The method 'getMainUploadJs(HttpServletRequest, Boolean)' has a cyclomatic complexity of 10. 3 111–211
ExcessiveMethodLength Avoid really long methods. 3 111–211
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 115
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 126
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 181