PMD Results
The following document contains the results of PMD 5.5.1.
Files
fr/paris/lutece/plugins/avatarserver/business/Avatar.java
Violation |
Line |
Returning '_byValue' may expose an internal array. |
108 |
The user-supplied array 'value' is stored directly. |
117 |
fr/paris/lutece/plugins/avatarserver/service/AvatarResourceProvider.java
Violation |
Line |
Document empty constructor |
57–59 |
fr/paris/lutece/plugins/avatarserver/service/HashService.java
Violation |
Line |
When doing a String.toLowerCase()/toUpperCase() call, use a Locale |
61 |
Avoid variables with short names like md |
62 |
Avoid variables with short names like sb |
69 |
fr/paris/lutece/plugins/avatarserver/service/HttpUtils.java
Violation |
Line |
All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. |
47–110 |
fr/paris/lutece/plugins/avatarserver/service/ImageService.java
Violation |
Line |
Avoid variables with short names like in |
96 |
fr/paris/lutece/plugins/avatarserver/web/AvatarJspBean.java
Violation |
Line |
Avoid unused imports such as 'fr.paris.lutece.portal.service.util.AppPropertiesService' |
41 |
Avoid unused imports such as 'fr.paris.lutece.portal.service.util.AppPropertiesService' |
41 |
Avoid unused imports such as 'fr.paris.lutece.portal.web.util.LocalizedPaginator' |
46 |
Avoid unused imports such as 'fr.paris.lutece.portal.web.util.LocalizedPaginator' |
46 |
Avoid unused imports such as 'fr.paris.lutece.util.html.Paginator' |
47 |
Avoid unused imports such as 'fr.paris.lutece.util.html.Paginator' |
47 |
Assigning an Object to null is a code smell. Consider refactoring. |
166 |
Assigning an Object to null is a code smell. Consider refactoring. |
256 |
fr/paris/lutece/plugins/avatarserver/web/AvatarServerApp.java
Violation |
Line |
Assigning an Object to null is a code smell. Consider refactoring. |
101 |
Avoid declaring a variable if it is unreferenced before a possible exit point. |
143 |
fr/paris/lutece/plugins/avatarserver/web/ManageAvatarserverJspBean.java
Violation |
Line |
Abstract classes should be named AbstractXXX |
50–84 |
Perhaps '_nDefaultItemsPerPage' could be replaced by a local variable. |
60 |
Do not add empty strings |
78 |
fr/paris/lutece/plugins/avatarserver/web/PostAvatarServlet.java
Violation |
Line |
The class 'PostAvatarServlet' has a Cyclomatic Complexity of 6 (Highest = 11). |
65–181 |
The class 'PostAvatarServlet' has a Standard Cyclomatic Complexity of 6 (Highest = 10). |
65–181 |
The class 'PostAvatarServlet' has a Modified Cyclomatic Complexity of 6 (Highest = 10). |
65–181 |
The method 'doPost' has a Modified Cyclomatic Complexity of 10. |
96–180 |
The method 'doPost' has a Cyclomatic Complexity of 11. |
96–180 |
The method 'doPost' has a Standard Cyclomatic Complexity of 10. |
96–180 |
fr/paris/lutece/plugins/avatarserver/web/rs/AvatarRest.java
Violation |
Line |
Use explicit scoping instead of the default package private level |
63–64 |
Use explicit scoping instead of the default package private level |
65–66 |
The Logger variable declaration does not contain the static and final modifiers |
67 |
Private field '_logger' could be made final; it is only initialized in the declaration or constructor. |
67 |
debug logging that involves string concatenation should be guarded with isDebugEnabled() checks |
83 |