The following document contains the results of PMD 6.13.0.
| Rule | Violation | Line |
|---|---|---|
| FormalParameterNamingConventions | The method parameter name '_strFirstName' doesn't match '[a-z][a-zA-Z0-9]*' | 52 |
| FormalParameterNamingConventions | The method parameter name '_strLastName' doesn't match '[a-z][a-zA-Z0-9]*' | 62 |
| Rule | Violation | Line |
|---|---|---|
| ClassNamingConventions | The utility class name 'Constants' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' | 39–70 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Public method and constructor comments are required | 47–50 |
| CommentRequired | Public method and constructor comments are required | 52–55 |
| CommentRequired | Public method and constructor comments are required | 57–60 |
| CommentRequired | Public method and constructor comments are required | 62–65 |
| Rule | Violation | Line |
|---|---|---|
| TooFewBranchesForASwitchStatement | A switch with less than three branches is inefficient, use a if statement instead. | 89–96 |
| UnusedFormalParameter | Avoid unused method parameters such as 'response'. | 108 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 115–146 |
| LinguisticNaming | Linguistics Antipattern - The method 'isUserAuthenticated' indicates linguistically it returns a boolean, but it returns 'Response' | 186–199 |
| TooFewBranchesForASwitchStatement | A switch with less than three branches is inefficient, use a if statement instead. | 189–196 |
| LinguisticNaming | Linguistics Antipattern - The method 'isUserAuthenticatedV1' indicates linguistically it returns a boolean, but it returns 'Response' | 208–219 |
| UnusedFormalParameter | Avoid unused method parameters such as 'response'. | 208 |
| TooFewBranchesForASwitchStatement | A switch with less than three branches is inefficient, use a if statement instead. | 239–246 |
| TooFewBranchesForASwitchStatement | A switch with less than three branches is inefficient, use a if statement instead. | 282–289 |
| TooFewBranchesForASwitchStatement | A switch with less than three branches is inefficient, use a if statement instead. | 329–336 |
| UnusedFormalParameter | Avoid unused method parameters such as 'response'. | 365 |
| Rule | Violation | Line |
|---|---|---|
| ShortVariable | Avoid variables with short names like ID | 56 |
| Rule | Violation | Line |
|---|---|---|
| MissingOverride | The method 'handleToken(Token, HttpServletRequest, HttpServletResponse)' is missing an @Override annotation. | 72–98 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 106–112 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the parse method if you want a default access modifier | 106–112 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 10–77 |
| RedundantFieldInitializer | Avoid using redundant field initializer for '_authenticator' | 21 |
| CommentRequired | Public method and constructor comments are required | 23–35 |
| NonThreadSafeSingleton | Singleton is not thread safe | 25–33 |
| CommentRequired | Public method and constructor comments are required | 37–40 |
| CommentRequired | Public method and constructor comments are required | 42–45 |
| CommentRequired | Public method and constructor comments are required | 47–50 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Public method and constructor comments are required | 3 | 47–50 |
| CommentRequired | Public method and constructor comments are required | 3 | 52–55 |
| FormalParameterNamingConventions | The method parameter name '_strFirstName' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 52 |
| CommentRequired | Public method and constructor comments are required | 3 | 57–60 |
| CommentRequired | Public method and constructor comments are required | 3 | 62–65 |
| FormalParameterNamingConventions | The method parameter name '_strLastName' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 62 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| TooFewBranchesForASwitchStatement | A switch with less than three branches is inefficient, use a if statement instead. | 3 | 89–96 |
| UnusedFormalParameter | Avoid unused method parameters such as 'response'. | 3 | 108 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 115–146 |
| LinguisticNaming | Linguistics Antipattern - The method 'isUserAuthenticated' indicates linguistically it returns a boolean, but it returns 'Response' | 3 | 186–199 |
| TooFewBranchesForASwitchStatement | A switch with less than three branches is inefficient, use a if statement instead. | 3 | 189–196 |
| LinguisticNaming | Linguistics Antipattern - The method 'isUserAuthenticatedV1' indicates linguistically it returns a boolean, but it returns 'Response' | 3 | 208–219 |
| UnusedFormalParameter | Avoid unused method parameters such as 'response'. | 3 | 208 |
| TooFewBranchesForASwitchStatement | A switch with less than three branches is inefficient, use a if statement instead. | 3 | 239–246 |
| TooFewBranchesForASwitchStatement | A switch with less than three branches is inefficient, use a if statement instead. | 3 | 282–289 |
| TooFewBranchesForASwitchStatement | A switch with less than three branches is inefficient, use a if statement instead. | 3 | 329–336 |
| UnusedFormalParameter | Avoid unused method parameters such as 'response'. | 3 | 365 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ClassNamingConventions | The utility class name 'Constants' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' | 1 | 39–70 |
| ShortVariable | Avoid variables with short names like ID | 3 | 56 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| MissingOverride | The method 'handleToken(Token, HttpServletRequest, HttpServletResponse)' is missing an @Override annotation. | 3 | 72–98 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 3 | 106–112 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the parse method if you want a default access modifier | 3 | 106–112 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 10–77 |
| RedundantFieldInitializer | Avoid using redundant field initializer for '_authenticator' | 3 | 21 |
| CommentRequired | Public method and constructor comments are required | 3 | 23–35 |
| NonThreadSafeSingleton | Singleton is not thread safe | 3 | 25–33 |
| CommentRequired | Public method and constructor comments are required | 3 | 37–40 |
| CommentRequired | Public method and constructor comments are required | 3 | 42–45 |
| CommentRequired | Public method and constructor comments are required | 3 | 47–50 |
