Fork me on GitHub

Résultats PMD

Le document suivant contient les résultats de PMD 6.13.0.

Violations By Priority

Priority 1

fr/paris/lutece/plugins/campagnebp/business/Campagne.java

Rule Violation Ligne
FormalParameterNamingConventions The method parameter name 'Imgs' doesn't match '[a-z][a-zA-Z0-9]*' 258

fr/paris/lutece/plugins/campagnebp/business/CampagneTheme.java

Rule Violation Ligne
FormalParameterNamingConventions The method parameter name '_fileImage' doesn't match '[a-z][a-zA-Z0-9]*' 207

fr/paris/lutece/plugins/campagnebp/business/ICampagneDAO.java

Rule Violation Ligne
FormalParameterNamingConventions The method parameter name '_plugin' doesn't match '[a-z][a-zA-Z0-9]*' 95

fr/paris/lutece/plugins/campagnebp/business/MyAccount.java

Rule Violation Ligne
FormalParameterNamingConventions The method parameter name '_strLogin' doesn't match '[a-z][a-zA-Z0-9]*' 65
FormalParameterNamingConventions The method parameter name '_strPassword' doesn't match '[a-z][a-zA-Z0-9]*' 82
FormalParameterNamingConventions The method parameter name '_strConfirmationPassword' doesn't match '[a-z][a-zA-Z0-9]*' 99

fr/paris/lutece/plugins/campagnebp/business/MyInfosForm.java

Rule Violation Ligne
FormalParameterNamingConventions The method parameter name '_bAccountVerified' doesn't match '[a-z][a-zA-Z0-9]*' 337
FormalParameterNamingConventions The method parameter name '_strNickname' doesn't match '[a-z][a-zA-Z0-9]*' 354
FormalParameterNamingConventions The method parameter name '_strPostalCode' doesn't match '[a-z][a-zA-Z0-9]*' 391
FormalParameterNamingConventions The method parameter name '_dLongitude' doesn't match '[a-z][a-zA-Z0-9]*' 410
FormalParameterNamingConventions The method parameter name '_dLatitude' doesn't match '[a-z][a-zA-Z0-9]*' 429
FormalParameterNamingConventions The method parameter name '_strGeojson' doesn't match '[a-z][a-zA-Z0-9]*' 446

fr/paris/lutece/plugins/campagnebp/service/MyInfosListenerService.java

Rule Violation Ligne
FieldNamingConventions The public constant name 'Document_PROPERTY_RESOURCE_TYPE' doesn't match '[A-Z][A-Z_0-9]*' 61

fr/paris/lutece/plugins/campagnebp/service/MyInfosService.java

Rule Violation Ligne
FieldNamingConventions The constant name 'patternPostalCode' doesn't match '[A-Z][A-Z_0-9]*' 79

fr/paris/lutece/plugins/campagnebp/utils/CampagneErrorJsonResponse.java

Rule Violation Ligne
FormalParameterNamingConventions The method parameter name '_strToken' doesn't match '[a-z][a-zA-Z0-9]*' 85

fr/paris/lutece/plugins/campagnebp/utils/CampagneResponse.java

Rule Violation Ligne
FormalParameterNamingConventions The method parameter name '_strToken' doesn't match '[a-z][a-zA-Z0-9]*' 78
FormalParameterNamingConventions The method parameter name '_bSuccess' doesn't match '[a-z][a-zA-Z0-9]*' 99

fr/paris/lutece/plugins/campagnebp/utils/Constants.java

Rule Violation Ligne
ClassNamingConventions The utility class name 'Constants' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' 40117

Priority 2

fr/paris/lutece/plugins/campagnebp/service/CampagnesService.java

Rule Violation Ligne
GuardLogStatement Logger calls should be surrounded by log level guards. 116117

fr/paris/lutece/plugins/campagnebp/service/MyInfosService.java

Rule Violation Ligne
AvoidUsingVolatile Use of modifier volatile is not recommended. 117
AvoidUsingVolatile Use of modifier volatile is not recommended. 118
BooleanInstantiation Avoid instantiating Boolean objects; reference Boolean.TRUE or Boolean.FALSE or call Boolean.valueOf() instead. 218
BooleanInstantiation Avoid instantiating Boolean objects; reference Boolean.TRUE or Boolean.FALSE or call Boolean.valueOf() instead. 223
BooleanInstantiation Avoid instantiating Boolean objects; reference Boolean.TRUE or Boolean.FALSE or call Boolean.valueOf() instead. 363

fr/paris/lutece/plugins/campagnebp/web/MyInfosXPage.java

Rule Violation Ligne
BooleanInstantiation Avoid instantiating Boolean objects; reference Boolean.TRUE or Boolean.FALSE or call Boolean.valueOf() instead. 1202

Priority 3

fr/paris/lutece/plugins/campagnebp/business/Campagne.java

Rule Violation Ligne
CommentRequired Public method and constructor comments are required 6770

fr/paris/lutece/plugins/campagnebp/business/CampagneDAO.java

Rule Violation Ligne
TooManyMethods This class has too many methods, consider refactoring it. 52342
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 190
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 274
ConfusingTernary Avoid if (x != y) ..; else ..; 294301
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 303
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 314

fr/paris/lutece/plugins/campagnebp/business/CampagneImageDAO.java

Rule Violation Ligne
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 158
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 183

fr/paris/lutece/plugins/campagnebp/business/CampagnePhaseDAO.java

Rule Violation Ligne
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 166
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 193
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 212

fr/paris/lutece/plugins/campagnebp/business/CampagneThemeDAO.java

Rule Violation Ligne
ConfusingTernary Avoid if (x != y) ..; else ..; 107114
ConfusingTernary Avoid if (x != y) ..; else ..; 190197
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 210
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 231
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 265
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 287
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 287
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 298

fr/paris/lutece/plugins/campagnebp/business/Civility.java

Rule Violation Ligne
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 61
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 62

fr/paris/lutece/plugins/campagnebp/business/MyInfosForm.java

Rule Violation Ligne
TooManyFields Too many fields 53451
CloneThrowsCloneNotSupportedException clone() method should throw CloneNotSupportedException 288298

fr/paris/lutece/plugins/campagnebp/service/AccountService.java

Rule Violation Ligne
UseUtilityClass All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 53149

fr/paris/lutece/plugins/campagnebp/service/BudgetIncludeService.java

Rule Violation Ligne
UseUtilityClass All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 4766

fr/paris/lutece/plugins/campagnebp/service/CampagneIncludeService.java

Rule Violation Ligne
UseUtilityClass All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 4766

fr/paris/lutece/plugins/campagnebp/service/CampagnesService.java

Rule Violation Ligne
RedundantFieldInitializer Avoid using redundant field initializer for '_cache' 60
NonThreadSafeSingleton Singleton is not thread safe 7679
ControlStatementBraces This statement should have braces 91
MissingOverride The method 'reset()' is missing an @Override annotation. 101121
CommentRequired Public method and constructor comments are required 101121
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 105
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 105
MissingOverride The method 'getLastCampagne()' is missing an @Override annotation. 128131
CommentRequired Public method and constructor comments are required 128131
CommentRequired Public method and constructor comments are required 151157
MissingOverride The method 'isBeforeBeginning(String, String)' is missing an @Override annotation. 151157
UnnecessaryLocalBeforeReturn Consider simply returning the value vs storing it in local variable 'result' 156
CommentRequired Public method and constructor comments are required 159165
MissingOverride The method 'isBeforeEnd(String, String)' is missing an @Override annotation. 159165
UnnecessaryLocalBeforeReturn Consider simply returning the value vs storing it in local variable 'result' 164
MissingOverride The method 'isDuring(String, String)' is missing an @Override annotation. 167176
CommentRequired Public method and constructor comments are required 167176
UnnecessaryLocalBeforeReturn Consider simply returning the value vs storing it in local variable 'result' 175
MissingOverride The method 'isAfterBeginning(String, String)' is missing an @Override annotation. 178184
CommentRequired Public method and constructor comments are required 178184
UnnecessaryLocalBeforeReturn Consider simply returning the value vs storing it in local variable 'result' 183
MissingOverride The method 'isAfterEnd(String, String)' is missing an @Override annotation. 186192
CommentRequired Public method and constructor comments are required 186192
UnnecessaryLocalBeforeReturn Consider simply returning the value vs storing it in local variable 'result' 191
MissingOverride The method 'start(String, String)' is missing an @Override annotation. 194198
CommentRequired Public method and constructor comments are required 194198
UnnecessaryLocalBeforeReturn Consider simply returning the value vs storing it in local variable 'timeStamp' 197
CommentRequired Public method and constructor comments are required 200204
MissingOverride The method 'end(String, String)' is missing an @Override annotation. 200204
UnnecessaryLocalBeforeReturn Consider simply returning the value vs storing it in local variable 'timeStamp' 203
CommentRequired Public method and constructor comments are required 206213
MissingOverride The method 'startStr(String, String, String, boolean)' is missing an @Override annotation. 206213
ShortVariable Avoid variables with short names like ts 208
SimpleDateFormatNeedsLocale When instantiating a SimpleDateFormat object, specify a Locale 211
CommentRequired Public method and constructor comments are required 215222
MissingOverride The method 'endStr(String, String, String, boolean)' is missing an @Override annotation. 215222
ShortVariable Avoid variables with short names like ts 217
SimpleDateFormatNeedsLocale When instantiating a SimpleDateFormat object, specify a Locale 220
MissingOverride The method 'isBeforeBeginning(String)' is missing an @Override annotation. 226229
CommentRequired Public method and constructor comments are required 226229
MissingOverride The method 'isBeforeEnd(String)' is missing an @Override annotation. 231234
CommentRequired Public method and constructor comments are required 231234
MissingOverride The method 'isDuring(String)' is missing an @Override annotation. 236239
CommentRequired Public method and constructor comments are required 236239
CommentRequired Public method and constructor comments are required 241244
MissingOverride The method 'isAfterBeginning(String)' is missing an @Override annotation. 241244
CommentRequired Public method and constructor comments are required 246249
MissingOverride The method 'isAfterEnd(String)' is missing an @Override annotation. 246249
MissingOverride The method 'start(String)' is missing an @Override annotation. 251254
CommentRequired Public method and constructor comments are required 251254
CommentRequired Public method and constructor comments are required 256259
MissingOverride The method 'end(String)' is missing an @Override annotation. 256259
CommentRequired Public method and constructor comments are required 261264
MissingOverride The method 'startStr(String, String, boolean)' is missing an @Override annotation. 261264
CommentRequired Public method and constructor comments are required 266269
MissingOverride The method 'endStr(String, String, boolean)' is missing an @Override annotation. 266269
ConfusingTernary Avoid if (x != y) ..; else ..; 281288
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 297

fr/paris/lutece/plugins/campagnebp/service/ICampagneService.java

Rule Violation Ligne
UnnecessaryModifier Unnecessary modifier 'public' on method 'getLastCampagne': the method is declared in an interface type 52
UnnecessaryModifier Unnecessary modifier 'public' on method 'isBeforeBeginning': the method is declared in an interface type 61
UnnecessaryModifier Unnecessary modifier 'public' on method 'isBeforeEnd': the method is declared in an interface type 70
UnnecessaryModifier Unnecessary modifier 'public' on method 'isDuring': the method is declared in an interface type 79
UnnecessaryModifier Unnecessary modifier 'public' on method 'isAfterBeginning': the method is declared in an interface type 88
UnnecessaryModifier Unnecessary modifier 'public' on method 'isAfterEnd': the method is declared in an interface type 97
UnnecessaryModifier Unnecessary modifier 'public' on method 'start': the method is declared in an interface type 106
UnnecessaryModifier Unnecessary modifier 'public' on method 'end': the method is declared in an interface type 115
UnnecessaryModifier Unnecessary modifier 'public' on method 'startStr': the method is declared in an interface type 128
UnnecessaryModifier Unnecessary modifier 'public' on method 'endStr': the method is declared in an interface type 141
UnnecessaryModifier Unnecessary modifier 'public' on method 'isBeforeBeginning': the method is declared in an interface type 149
UnnecessaryModifier Unnecessary modifier 'public' on method 'isBeforeEnd': the method is declared in an interface type 156
UnnecessaryModifier Unnecessary modifier 'public' on method 'isDuring': the method is declared in an interface type 163
UnnecessaryModifier Unnecessary modifier 'public' on method 'isAfterBeginning': the method is declared in an interface type 170
UnnecessaryModifier Unnecessary modifier 'public' on method 'isAfterEnd': the method is declared in an interface type 177
UnnecessaryModifier Unnecessary modifier 'public' on method 'start': the method is declared in an interface type 184
UnnecessaryModifier Unnecessary modifier 'public' on method 'end': the method is declared in an interface type 191
UnnecessaryModifier Unnecessary modifier 'public' on method 'startStr': the method is declared in an interface type 202
UnnecessaryModifier Unnecessary modifier 'public' on method 'endStr': the method is declared in an interface type 213
UnnecessaryModifier Unnecessary modifier 'public' on method 'reset': the method is declared in an interface type 219

fr/paris/lutece/plugins/campagnebp/service/IMyInfosListener.java

Rule Violation Ligne
LinguisticNaming Linguistics Antipattern - The method 'canChangeArrond' indicates linguistically it returns a boolean, but it returns 'int' 67

fr/paris/lutece/plugins/campagnebp/service/MyInfosListenerService.java

Rule Violation Ligne
UseUtilityClass All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 53187
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 55
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 57
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 57
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 6973
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 8393
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 88
LinguisticNaming Linguistics Antipattern - The method 'canChangeArrond' indicates linguistically it returns a boolean, but it returns 'int' 149163

fr/paris/lutece/plugins/campagnebp/service/MyInfosService.java

Rule Violation Ligne
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 34856
GodClass Possible God Class (WMC=74, ATFD=132, TCC=6.897%) 76856
TooManyMethods This class has too many methods, consider refactoring it. 77856
SimplifiedTernary Ternary operators that can be simplified with || or && 223
ConfusingTernary Avoid if (x != y) ..; else ..; 223
CyclomaticComplexity The method 'saveUserInfos(String, String, MyInfosForm)' has a cyclomatic complexity of 10. 264321
ConfusingTernary Avoid if (x != y) ..; else ..; 306318
NonThreadSafeSingleton Singleton is not thread safe 408424
UseUnderscoresInNumericLiterals Number 75001 should separate every third digit with an underscore 419
AddEmptyString Do not add empty strings 419
NonThreadSafeSingleton Singleton is not thread safe 436457
AddEmptyString Do not add empty strings 447
UseUnderscoresInNumericLiterals Number 75001 should separate every third digit with an underscore 447
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 449
LinguisticNaming Linguistics Antipattern - The setter 'setAdressValid' should not return any type except void linguistically 485516
ShortVariable Avoid variables with short names like m 493
ConfusingTernary Avoid if (x != y) ..; else ..; 615
UseLocaleWithCaseConversions When doing a String.toLowerCase()/toUpperCase() call, use a Locale 689

fr/paris/lutece/plugins/campagnebp/service/NoSuchPhaseException.java

Rule Violation Ligne
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 3998
CallSuperInConstructor It is a good practice to call super() in a constructor 4548

fr/paris/lutece/plugins/campagnebp/service/avatar/CampagneAvatarService.java

Rule Violation Ligne
UseUtilityClass All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 53119
UseCollectionIsEmpty Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 69
UseCollectionIsEmpty Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 94

fr/paris/lutece/plugins/campagnebp/uploadhandler/CampagneSessionListener.java

Rule Violation Ligne
ShortVariable Avoid variables with short names like se 50
ShortVariable Avoid variables with short names like se 59

fr/paris/lutece/plugins/campagnebp/uploadhandler/CampagneUploadHandler.java

Rule Violation Ligne
UseUnderscoresInNumericLiterals Number 2097152 should separate every third digit with an underscore 64
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 79
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 122
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 123
UseCollectionIsEmpty Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 128
UseLocaleWithCaseConversions When doing a String.toLowerCase()/toUpperCase() call, use a Locale 142
UseLocaleWithCaseConversions When doing a String.toLowerCase()/toUpperCase() call, use a Locale 142
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 227
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 237

fr/paris/lutece/plugins/campagnebp/utils/ModelUtils.java

Rule Violation Ligne
UseLocaleWithCaseConversions When doing a String.toLowerCase()/toUpperCase() call, use a Locale 82

fr/paris/lutece/plugins/campagnebp/web/CampagneImageJspBean.java

Rule Violation Ligne
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 54246
UnusedPrivateField Avoid unused private fields such as 'PROPERTY_DEFAULT_LIST_CAMPAGNEIMAGE_PER_PAGE'. 81
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 114
ConfusingTernary Avoid if (x != y) ..; else ..; 131

fr/paris/lutece/plugins/campagnebp/web/CampagneJspBean.java

Rule Violation Ligne
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 55252
UnusedPrivateField Avoid unused private fields such as 'PROPERTY_DEFAULT_LIST_CAMPAGNE_PER_PAGE'. 82
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 115
ConfusingTernary Avoid if (x != y) ..; else ..; 132

fr/paris/lutece/plugins/campagnebp/web/CampagnePhaseJspBean.java

Rule Violation Ligne
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 55253
UnusedPrivateField Avoid unused private fields such as 'PROPERTY_DEFAULT_LIST_CAMPAGNEPHASE_PER_PAGE'. 82
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 115
ConfusingTernary Avoid if (x != y) ..; else ..; 132

fr/paris/lutece/plugins/campagnebp/web/CampagneThemeJspBean.java

Rule Violation Ligne
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 54246
UnusedPrivateField Avoid unused private fields such as 'PROPERTY_DEFAULT_LIST_CAMPAGNETHEME_PER_PAGE'. 81
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 114
ConfusingTernary Avoid if (x != y) ..; else ..; 131

fr/paris/lutece/plugins/campagnebp/web/ManageCampagnebpJspBean.java

Rule Violation Ligne
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 4886
SingularField Perhaps '_nDefaultItemsPerPage' could be replaced by a local variable. 62
CommentRequired Protected method constructor comments are required 6685
AddEmptyString Do not add empty strings 80

fr/paris/lutece/plugins/campagnebp/web/MyInfosXPage.java

Rule Violation Ligne
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 341362
CyclomaticComplexity The class 'MyInfosXPage' has a total cyclomatic complexity of 97 (highest 30). 1041362
GodClass Possible God Class (WMC=97, ATFD=172, TCC=15.686%) 1041362
ExcessiveClassLength Avoid really long classes. 1041362
UnusedPrivateField Avoid unused private fields such as 'CAMPAGNE_BP_APP_NAME'. 204
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 241
NonStaticInitializer Non-static initializers are confusing 243248
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 244
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 245
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 246
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 247
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 251
NonStaticInitializer Non-static initializers are confusing 253257
ImmutableField Private field '_patternAddress' could be made final; it is only initialized in the declaration or constructor. 262
ImmutableField Private field '_captchaService' could be made final; it is only initialized in the declaration or constructor. 268
ImmutableField Private field '_identityService' could be made final; it is only initialized in the declaration or constructor. 274
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 295
ConfusingTernary Avoid if (x != y) ..; else ..; 310332
CyclomaticComplexity The method 'doCreateMyInfos(HttpServletRequest)' has a cyclomatic complexity of 16. 356447
NPathComplexity The method 'doCreateMyInfos(HttpServletRequest)' has an NPath complexity of 2916 356447
CollapsibleIfStatements These nested if statements could be combined 370374
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 444
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 445
CyclomaticComplexity The method 'getMyInfos(HttpServletRequest, boolean)' has a cyclomatic complexity of 19. 475637
NcssCount The method 'getMyInfos(HttpServletRequest, boolean)' has a NCSS line count of 90. 475637
ExcessiveMethodLength Avoid really long methods. 475637
NPathComplexity The method 'getMyInfos(HttpServletRequest, boolean)' has an NPath complexity of 9218 475637
ConfusingTernary Avoid if (x != y) ..; else ..; 487495
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 490
ConfusingTernary Avoid if (x != y) ..; else ..; 501510
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 504
EmptyIfStmt Avoid empty if statements 516518
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 568
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 568
NPathComplexity The method 'doSave(HttpServletRequest)' has an NPath complexity of 2612738 651865
CyclomaticComplexity The method 'doSave(HttpServletRequest)' has a cyclomatic complexity of 39. 651865
NcssCount The method 'doSave(HttpServletRequest)' has a NCSS line count of 97. 651865
ExcessiveMethodLength Avoid really long methods. 651865
CollapsibleIfStatements These nested if statements could be combined 683687
CollapsibleIfStatements These nested if statements could be combined 721736
ConfusingTernary Avoid if (x != y) ..; else ..; 750782
EmptyIfStmt Avoid empty if statements 751755
CollapsibleIfStatements These nested if statements could be combined 761778
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 781
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 803
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 803
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 812
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 817
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 819
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 819
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 832
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 832
LinguisticNaming Linguistics Antipattern - The method 'isUserValid' indicates linguistically it returns a boolean, but it returns 'String' 891934
ConfusingTernary Avoid if (x != y) ..; else ..; 910923
ConfusingTernary Avoid if (x != y) ..; else ..; 916923
CyclomaticComplexity The method 'doSaveForAjax(HttpServletRequest)' has a cyclomatic complexity of 20. 10521150
NPathComplexity The method 'doSaveForAjax(HttpServletRequest)' has an NPath complexity of 3026 10521150
CollapsibleIfStatements These nested if statements could be combined 10681072
CollapsibleIfStatements These nested if statements could be combined 12181221
NcssCount The method 'savePersonalData(OpenamUser, MyInfosForm)' has a NCSS line count of 65. 12461361
ExcessiveMethodLength Avoid really long methods. 12461361
NPathComplexity The method 'savePersonalData(OpenamUser, MyInfosForm)' has an NPath complexity of 88320 12461361
CyclomaticComplexity The method 'savePersonalData(OpenamUser, MyInfosForm)' has a cyclomatic complexity of 30. 12461361
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 1250
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 1250
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 1303
UseCollectionIsEmpty Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 1339
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 1355

Priority 4

fr/paris/lutece/plugins/campagnebp/business/Campagne.java

Rule Violation Ligne
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 167170

fr/paris/lutece/plugins/campagnebp/business/CampagnePhaseDAO.java

Rule Violation Ligne
UnusedImports Avoid unused imports such as 'fr.paris.lutece.portal.business.file.FileHome' 36

fr/paris/lutece/plugins/campagnebp/business/CampagneTheme.java

Rule Violation Ligne
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 162165

fr/paris/lutece/plugins/campagnebp/business/MyInfosForm.java

Rule Violation Ligne
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 268271

Fichiers

fr/paris/lutece/plugins/campagnebp/business/Campagne.java

Rule Violation Priority Ligne
CommentRequired Public method and constructor comments are required 3 6770
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 4 167170
FormalParameterNamingConventions The method parameter name 'Imgs' doesn't match '[a-z][a-zA-Z0-9]*' 1 258

fr/paris/lutece/plugins/campagnebp/business/CampagneDAO.java

Rule Violation Priority Ligne
TooManyMethods This class has too many methods, consider refactoring it. 3 52342
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 190
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 274
ConfusingTernary Avoid if (x != y) ..; else ..; 3 294301
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 303
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 314

fr/paris/lutece/plugins/campagnebp/business/CampagneImageDAO.java

Rule Violation Priority Ligne
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 158
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 183

fr/paris/lutece/plugins/campagnebp/business/CampagnePhaseDAO.java

Rule Violation Priority Ligne
UnusedImports Avoid unused imports such as 'fr.paris.lutece.portal.business.file.FileHome' 4 36
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 166
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 193
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 212

fr/paris/lutece/plugins/campagnebp/business/CampagneTheme.java

Rule Violation Priority Ligne
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 4 162165
FormalParameterNamingConventions The method parameter name '_fileImage' doesn't match '[a-z][a-zA-Z0-9]*' 1 207

fr/paris/lutece/plugins/campagnebp/business/CampagneThemeDAO.java

Rule Violation Priority Ligne
ConfusingTernary Avoid if (x != y) ..; else ..; 3 107114
ConfusingTernary Avoid if (x != y) ..; else ..; 3 190197
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 210
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 231
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 265
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 287
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 287
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 298

fr/paris/lutece/plugins/campagnebp/business/Civility.java

Rule Violation Priority Ligne
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 61
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 62

fr/paris/lutece/plugins/campagnebp/business/ICampagneDAO.java

Rule Violation Priority Ligne
FormalParameterNamingConventions The method parameter name '_plugin' doesn't match '[a-z][a-zA-Z0-9]*' 1 95

fr/paris/lutece/plugins/campagnebp/business/MyAccount.java

Rule Violation Priority Ligne
FormalParameterNamingConventions The method parameter name '_strLogin' doesn't match '[a-z][a-zA-Z0-9]*' 1 65
FormalParameterNamingConventions The method parameter name '_strPassword' doesn't match '[a-z][a-zA-Z0-9]*' 1 82
FormalParameterNamingConventions The method parameter name '_strConfirmationPassword' doesn't match '[a-z][a-zA-Z0-9]*' 1 99

fr/paris/lutece/plugins/campagnebp/business/MyInfosForm.java

Rule Violation Priority Ligne
TooManyFields Too many fields 3 53451
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 4 268271
CloneThrowsCloneNotSupportedException clone() method should throw CloneNotSupportedException 3 288298
FormalParameterNamingConventions The method parameter name '_bAccountVerified' doesn't match '[a-z][a-zA-Z0-9]*' 1 337
FormalParameterNamingConventions The method parameter name '_strNickname' doesn't match '[a-z][a-zA-Z0-9]*' 1 354
FormalParameterNamingConventions The method parameter name '_strPostalCode' doesn't match '[a-z][a-zA-Z0-9]*' 1 391
FormalParameterNamingConventions The method parameter name '_dLongitude' doesn't match '[a-z][a-zA-Z0-9]*' 1 410
FormalParameterNamingConventions The method parameter name '_dLatitude' doesn't match '[a-z][a-zA-Z0-9]*' 1 429
FormalParameterNamingConventions The method parameter name '_strGeojson' doesn't match '[a-z][a-zA-Z0-9]*' 1 446

fr/paris/lutece/plugins/campagnebp/service/AccountService.java

Rule Violation Priority Ligne
UseUtilityClass All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 3 53149

fr/paris/lutece/plugins/campagnebp/service/BudgetIncludeService.java

Rule Violation Priority Ligne
UseUtilityClass All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 3 4766

fr/paris/lutece/plugins/campagnebp/service/CampagneIncludeService.java

Rule Violation Priority Ligne
UseUtilityClass All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 3 4766

fr/paris/lutece/plugins/campagnebp/service/CampagnesService.java

Rule Violation Priority Ligne
RedundantFieldInitializer Avoid using redundant field initializer for '_cache' 3 60
NonThreadSafeSingleton Singleton is not thread safe 3 7679
ControlStatementBraces This statement should have braces 3 91
MissingOverride The method 'reset()' is missing an @Override annotation. 3 101121
CommentRequired Public method and constructor comments are required 3 101121
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 105
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 105
GuardLogStatement Logger calls should be surrounded by log level guards. 2 116117
MissingOverride The method 'getLastCampagne()' is missing an @Override annotation. 3 128131
CommentRequired Public method and constructor comments are required 3 128131
CommentRequired Public method and constructor comments are required 3 151157
MissingOverride The method 'isBeforeBeginning(String, String)' is missing an @Override annotation. 3 151157
UnnecessaryLocalBeforeReturn Consider simply returning the value vs storing it in local variable 'result' 3 156
CommentRequired Public method and constructor comments are required 3 159165
MissingOverride The method 'isBeforeEnd(String, String)' is missing an @Override annotation. 3 159165
UnnecessaryLocalBeforeReturn Consider simply returning the value vs storing it in local variable 'result' 3 164
MissingOverride The method 'isDuring(String, String)' is missing an @Override annotation. 3 167176
CommentRequired Public method and constructor comments are required 3 167176
UnnecessaryLocalBeforeReturn Consider simply returning the value vs storing it in local variable 'result' 3 175
MissingOverride The method 'isAfterBeginning(String, String)' is missing an @Override annotation. 3 178184
CommentRequired Public method and constructor comments are required 3 178184
UnnecessaryLocalBeforeReturn Consider simply returning the value vs storing it in local variable 'result' 3 183
MissingOverride The method 'isAfterEnd(String, String)' is missing an @Override annotation. 3 186192
CommentRequired Public method and constructor comments are required 3 186192
UnnecessaryLocalBeforeReturn Consider simply returning the value vs storing it in local variable 'result' 3 191
MissingOverride The method 'start(String, String)' is missing an @Override annotation. 3 194198
CommentRequired Public method and constructor comments are required 3 194198
UnnecessaryLocalBeforeReturn Consider simply returning the value vs storing it in local variable 'timeStamp' 3 197
CommentRequired Public method and constructor comments are required 3 200204
MissingOverride The method 'end(String, String)' is missing an @Override annotation. 3 200204
UnnecessaryLocalBeforeReturn Consider simply returning the value vs storing it in local variable 'timeStamp' 3 203
CommentRequired Public method and constructor comments are required 3 206213
MissingOverride The method 'startStr(String, String, String, boolean)' is missing an @Override annotation. 3 206213
ShortVariable Avoid variables with short names like ts 3 208
SimpleDateFormatNeedsLocale When instantiating a SimpleDateFormat object, specify a Locale 3 211
CommentRequired Public method and constructor comments are required 3 215222
MissingOverride The method 'endStr(String, String, String, boolean)' is missing an @Override annotation. 3 215222
ShortVariable Avoid variables with short names like ts 3 217
SimpleDateFormatNeedsLocale When instantiating a SimpleDateFormat object, specify a Locale 3 220
MissingOverride The method 'isBeforeBeginning(String)' is missing an @Override annotation. 3 226229
CommentRequired Public method and constructor comments are required 3 226229
MissingOverride The method 'isBeforeEnd(String)' is missing an @Override annotation. 3 231234
CommentRequired Public method and constructor comments are required 3 231234
MissingOverride The method 'isDuring(String)' is missing an @Override annotation. 3 236239
CommentRequired Public method and constructor comments are required 3 236239
CommentRequired Public method and constructor comments are required 3 241244
MissingOverride The method 'isAfterBeginning(String)' is missing an @Override annotation. 3 241244
CommentRequired Public method and constructor comments are required 3 246249
MissingOverride The method 'isAfterEnd(String)' is missing an @Override annotation. 3 246249
MissingOverride The method 'start(String)' is missing an @Override annotation. 3 251254
CommentRequired Public method and constructor comments are required 3 251254
CommentRequired Public method and constructor comments are required 3 256259
MissingOverride The method 'end(String)' is missing an @Override annotation. 3 256259
CommentRequired Public method and constructor comments are required 3 261264
MissingOverride The method 'startStr(String, String, boolean)' is missing an @Override annotation. 3 261264
CommentRequired Public method and constructor comments are required 3 266269
MissingOverride The method 'endStr(String, String, boolean)' is missing an @Override annotation. 3 266269
ConfusingTernary Avoid if (x != y) ..; else ..; 3 281288
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 3 297

fr/paris/lutece/plugins/campagnebp/service/ICampagneService.java

Rule Violation Priority Ligne
UnnecessaryModifier Unnecessary modifier 'public' on method 'getLastCampagne': the method is declared in an interface type 3 52
UnnecessaryModifier Unnecessary modifier 'public' on method 'isBeforeBeginning': the method is declared in an interface type 3 61
UnnecessaryModifier Unnecessary modifier 'public' on method 'isBeforeEnd': the method is declared in an interface type 3 70
UnnecessaryModifier Unnecessary modifier 'public' on method 'isDuring': the method is declared in an interface type 3 79
UnnecessaryModifier Unnecessary modifier 'public' on method 'isAfterBeginning': the method is declared in an interface type 3 88
UnnecessaryModifier Unnecessary modifier 'public' on method 'isAfterEnd': the method is declared in an interface type 3 97
UnnecessaryModifier Unnecessary modifier 'public' on method 'start': the method is declared in an interface type 3 106
UnnecessaryModifier Unnecessary modifier 'public' on method 'end': the method is declared in an interface type 3 115
UnnecessaryModifier Unnecessary modifier 'public' on method 'startStr': the method is declared in an interface type 3 128
UnnecessaryModifier Unnecessary modifier 'public' on method 'endStr': the method is declared in an interface type 3 141
UnnecessaryModifier Unnecessary modifier 'public' on method 'isBeforeBeginning': the method is declared in an interface type 3 149
UnnecessaryModifier Unnecessary modifier 'public' on method 'isBeforeEnd': the method is declared in an interface type 3 156
UnnecessaryModifier Unnecessary modifier 'public' on method 'isDuring': the method is declared in an interface type 3 163
UnnecessaryModifier Unnecessary modifier 'public' on method 'isAfterBeginning': the method is declared in an interface type 3 170
UnnecessaryModifier Unnecessary modifier 'public' on method 'isAfterEnd': the method is declared in an interface type 3 177
UnnecessaryModifier Unnecessary modifier 'public' on method 'start': the method is declared in an interface type 3 184
UnnecessaryModifier Unnecessary modifier 'public' on method 'end': the method is declared in an interface type 3 191
UnnecessaryModifier Unnecessary modifier 'public' on method 'startStr': the method is declared in an interface type 3 202
UnnecessaryModifier Unnecessary modifier 'public' on method 'endStr': the method is declared in an interface type 3 213
UnnecessaryModifier Unnecessary modifier 'public' on method 'reset': the method is declared in an interface type 3 219

fr/paris/lutece/plugins/campagnebp/service/IMyInfosListener.java

Rule Violation Priority Ligne
LinguisticNaming Linguistics Antipattern - The method 'canChangeArrond' indicates linguistically it returns a boolean, but it returns 'int' 3 67

fr/paris/lutece/plugins/campagnebp/service/MyInfosListenerService.java

Rule Violation Priority Ligne
UseUtilityClass All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 3 53187
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 55
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 57
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 57
FieldNamingConventions The public constant name 'Document_PROPERTY_RESOURCE_TYPE' doesn't match '[A-Z][A-Z_0-9]*' 1 61
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 3 6973
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 3 8393
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 88
LinguisticNaming Linguistics Antipattern - The method 'canChangeArrond' indicates linguistically it returns a boolean, but it returns 'int' 3 149163

fr/paris/lutece/plugins/campagnebp/service/MyInfosService.java

Rule Violation Priority Ligne
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 3 34856
GodClass Possible God Class (WMC=74, ATFD=132, TCC=6.897%) 3 76856
TooManyMethods This class has too many methods, consider refactoring it. 3 77856
FieldNamingConventions The constant name 'patternPostalCode' doesn't match '[A-Z][A-Z_0-9]*' 1 79
AvoidUsingVolatile Use of modifier volatile is not recommended. 2 117
AvoidUsingVolatile Use of modifier volatile is not recommended. 2 118
BooleanInstantiation Avoid instantiating Boolean objects; reference Boolean.TRUE or Boolean.FALSE or call Boolean.valueOf() instead. 2 218
SimplifiedTernary Ternary operators that can be simplified with || or && 3 223
ConfusingTernary Avoid if (x != y) ..; else ..; 3 223
BooleanInstantiation Avoid instantiating Boolean objects; reference Boolean.TRUE or Boolean.FALSE or call Boolean.valueOf() instead. 2 223
CyclomaticComplexity The method 'saveUserInfos(String, String, MyInfosForm)' has a cyclomatic complexity of 10. 3 264321
ConfusingTernary Avoid if (x != y) ..; else ..; 3 306318
BooleanInstantiation Avoid instantiating Boolean objects; reference Boolean.TRUE or Boolean.FALSE or call Boolean.valueOf() instead. 2 363
NonThreadSafeSingleton Singleton is not thread safe 3 408424
UseUnderscoresInNumericLiterals Number 75001 should separate every third digit with an underscore 3 419
AddEmptyString Do not add empty strings 3 419
NonThreadSafeSingleton Singleton is not thread safe 3 436457
AddEmptyString Do not add empty strings 3 447
UseUnderscoresInNumericLiterals Number 75001 should separate every third digit with an underscore 3 447
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 3 449
LinguisticNaming Linguistics Antipattern - The setter 'setAdressValid' should not return any type except void linguistically 3 485516
ShortVariable Avoid variables with short names like m 3 493
ConfusingTernary Avoid if (x != y) ..; else ..; 3 615
UseLocaleWithCaseConversions When doing a String.toLowerCase()/toUpperCase() call, use a Locale 3 689

fr/paris/lutece/plugins/campagnebp/service/NoSuchPhaseException.java

Rule Violation Priority Ligne
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 3 3998
CallSuperInConstructor It is a good practice to call super() in a constructor 3 4548

fr/paris/lutece/plugins/campagnebp/service/avatar/CampagneAvatarService.java

Rule Violation Priority Ligne
UseUtilityClass All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 3 53119
UseCollectionIsEmpty Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 3 69
UseCollectionIsEmpty Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 3 94

fr/paris/lutece/plugins/campagnebp/uploadhandler/CampagneSessionListener.java

Rule Violation Priority Ligne
ShortVariable Avoid variables with short names like se 3 50
ShortVariable Avoid variables with short names like se 3 59

fr/paris/lutece/plugins/campagnebp/uploadhandler/CampagneUploadHandler.java

Rule Violation Priority Ligne
UseUnderscoresInNumericLiterals Number 2097152 should separate every third digit with an underscore 3 64
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 79
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 122
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 123
UseCollectionIsEmpty Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 3 128
UseLocaleWithCaseConversions When doing a String.toLowerCase()/toUpperCase() call, use a Locale 3 142
UseLocaleWithCaseConversions When doing a String.toLowerCase()/toUpperCase() call, use a Locale 3 142
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 227
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 237

fr/paris/lutece/plugins/campagnebp/utils/CampagneErrorJsonResponse.java

Rule Violation Priority Ligne
FormalParameterNamingConventions The method parameter name '_strToken' doesn't match '[a-z][a-zA-Z0-9]*' 1 85

fr/paris/lutece/plugins/campagnebp/utils/CampagneResponse.java

Rule Violation Priority Ligne
FormalParameterNamingConventions The method parameter name '_strToken' doesn't match '[a-z][a-zA-Z0-9]*' 1 78
FormalParameterNamingConventions The method parameter name '_bSuccess' doesn't match '[a-z][a-zA-Z0-9]*' 1 99

fr/paris/lutece/plugins/campagnebp/utils/Constants.java

Rule Violation Priority Ligne
ClassNamingConventions The utility class name 'Constants' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' 1 40117

fr/paris/lutece/plugins/campagnebp/utils/ModelUtils.java

Rule Violation Priority Ligne
UseLocaleWithCaseConversions When doing a String.toLowerCase()/toUpperCase() call, use a Locale 3 82

fr/paris/lutece/plugins/campagnebp/web/CampagneImageJspBean.java

Rule Violation Priority Ligne
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 3 54246
UnusedPrivateField Avoid unused private fields such as 'PROPERTY_DEFAULT_LIST_CAMPAGNEIMAGE_PER_PAGE'. 3 81
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 114
ConfusingTernary Avoid if (x != y) ..; else ..; 3 131

fr/paris/lutece/plugins/campagnebp/web/CampagneJspBean.java

Rule Violation Priority Ligne
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 3 55252
UnusedPrivateField Avoid unused private fields such as 'PROPERTY_DEFAULT_LIST_CAMPAGNE_PER_PAGE'. 3 82
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 115
ConfusingTernary Avoid if (x != y) ..; else ..; 3 132

fr/paris/lutece/plugins/campagnebp/web/CampagnePhaseJspBean.java

Rule Violation Priority Ligne
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 3 55253
UnusedPrivateField Avoid unused private fields such as 'PROPERTY_DEFAULT_LIST_CAMPAGNEPHASE_PER_PAGE'. 3 82
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 115
ConfusingTernary Avoid if (x != y) ..; else ..; 3 132

fr/paris/lutece/plugins/campagnebp/web/CampagneThemeJspBean.java

Rule Violation Priority Ligne
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 3 54246
UnusedPrivateField Avoid unused private fields such as 'PROPERTY_DEFAULT_LIST_CAMPAGNETHEME_PER_PAGE'. 3 81
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 114
ConfusingTernary Avoid if (x != y) ..; else ..; 3 131

fr/paris/lutece/plugins/campagnebp/web/ManageCampagnebpJspBean.java

Rule Violation Priority Ligne
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 3 4886
SingularField Perhaps '_nDefaultItemsPerPage' could be replaced by a local variable. 3 62
CommentRequired Protected method constructor comments are required 3 6685
AddEmptyString Do not add empty strings 3 80

fr/paris/lutece/plugins/campagnebp/web/MyInfosXPage.java

Rule Violation Priority Ligne
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 3 341362
CyclomaticComplexity The class 'MyInfosXPage' has a total cyclomatic complexity of 97 (highest 30). 3 1041362
GodClass Possible God Class (WMC=97, ATFD=172, TCC=15.686%) 3 1041362
ExcessiveClassLength Avoid really long classes. 3 1041362
UnusedPrivateField Avoid unused private fields such as 'CAMPAGNE_BP_APP_NAME'. 3 204
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 241
NonStaticInitializer Non-static initializers are confusing 3 243248
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 3 244
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 3 245
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 3 246
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 3 247
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 251
NonStaticInitializer Non-static initializers are confusing 3 253257
ImmutableField Private field '_patternAddress' could be made final; it is only initialized in the declaration or constructor. 3 262
ImmutableField Private field '_captchaService' could be made final; it is only initialized in the declaration or constructor. 3 268
ImmutableField Private field '_identityService' could be made final; it is only initialized in the declaration or constructor. 3 274
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 3 295
ConfusingTernary Avoid if (x != y) ..; else ..; 3 310332
CyclomaticComplexity The method 'doCreateMyInfos(HttpServletRequest)' has a cyclomatic complexity of 16. 3 356447
NPathComplexity The method 'doCreateMyInfos(HttpServletRequest)' has an NPath complexity of 2916 3 356447
CollapsibleIfStatements These nested if statements could be combined 3 370374
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 444
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 445
CyclomaticComplexity The method 'getMyInfos(HttpServletRequest, boolean)' has a cyclomatic complexity of 19. 3 475637
NcssCount The method 'getMyInfos(HttpServletRequest, boolean)' has a NCSS line count of 90. 3 475637
ExcessiveMethodLength Avoid really long methods. 3 475637
NPathComplexity The method 'getMyInfos(HttpServletRequest, boolean)' has an NPath complexity of 9218 3 475637
ConfusingTernary Avoid if (x != y) ..; else ..; 3 487495
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 490
ConfusingTernary Avoid if (x != y) ..; else ..; 3 501510
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 504
EmptyIfStmt Avoid empty if statements 3 516518
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 568
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 568
NPathComplexity The method 'doSave(HttpServletRequest)' has an NPath complexity of 2612738 3 651865
CyclomaticComplexity The method 'doSave(HttpServletRequest)' has a cyclomatic complexity of 39. 3 651865
NcssCount The method 'doSave(HttpServletRequest)' has a NCSS line count of 97. 3 651865
ExcessiveMethodLength Avoid really long methods. 3 651865
CollapsibleIfStatements These nested if statements could be combined 3 683687
CollapsibleIfStatements These nested if statements could be combined 3 721736
ConfusingTernary Avoid if (x != y) ..; else ..; 3 750782
EmptyIfStmt Avoid empty if statements 3 751755
CollapsibleIfStatements These nested if statements could be combined 3 761778
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 781
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 803
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 803
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 3 812
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 3 817
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 819
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 819
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 832
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 832
LinguisticNaming Linguistics Antipattern - The method 'isUserValid' indicates linguistically it returns a boolean, but it returns 'String' 3 891934
ConfusingTernary Avoid if (x != y) ..; else ..; 3 910923
ConfusingTernary Avoid if (x != y) ..; else ..; 3 916923
CyclomaticComplexity The method 'doSaveForAjax(HttpServletRequest)' has a cyclomatic complexity of 20. 3 10521150
NPathComplexity The method 'doSaveForAjax(HttpServletRequest)' has an NPath complexity of 3026 3 10521150
CollapsibleIfStatements These nested if statements could be combined 3 10681072
BooleanInstantiation Avoid instantiating Boolean objects; reference Boolean.TRUE or Boolean.FALSE or call Boolean.valueOf() instead. 2 1202
CollapsibleIfStatements These nested if statements could be combined 3 12181221
NcssCount The method 'savePersonalData(OpenamUser, MyInfosForm)' has a NCSS line count of 65. 3 12461361
ExcessiveMethodLength Avoid really long methods. 3 12461361
NPathComplexity The method 'savePersonalData(OpenamUser, MyInfosForm)' has an NPath complexity of 88320 3 12461361
CyclomaticComplexity The method 'savePersonalData(OpenamUser, MyInfosForm)' has a cyclomatic complexity of 30. 3 12461361
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 1250
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 1250
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 3 1303
UseCollectionIsEmpty Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 3 1339
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 1355