The following document contains the results of PMD 6.13.0.
| Rule | Violation | Line |
|---|---|---|
| FormalParameterNamingConventions | The method parameter name '_plugin' doesn't match '[a-z][a-zA-Z0-9]*' | 149 |
| Rule | Violation | Line |
|---|---|---|
| ClassWithOnlyPrivateConstructorsShouldBeFinal | A class which only has private constructors should be final | 39–58 |
| Rule | Violation | Line |
|---|---|---|
| ClassWithOnlyPrivateConstructorsShouldBeFinal | A class which only has private constructors should be final | 38–47 |
| ClassNamingConventions | The utility class name 'Utils' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' | 38–47 |
| FieldNamingConventions | The public constant name 'dateFormat' doesn't match '[A-Z][A-Z_0-9]*' | 41 |
| Rule | Violation | Line |
|---|---|---|
| GuardLogStatement | Logger calls should be surrounded by log level guards. | 82–83 |
| Rule | Violation | Line |
|---|---|---|
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 255 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 39–58 |
| Rule | Violation | Line |
|---|---|---|
| NonThreadSafeSingleton | Singleton is not thread safe | 55–58 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 50–192 |
| RedundantFieldInitializer | Avoid using redundant field initializer for '_cache' | 52 |
| CommentRequired | Public method and constructor comments are required | 58–65 |
| NonThreadSafeSingleton | Singleton is not thread safe | 60–63 |
| CommentRequired | Public method and constructor comments are required | 67–87 |
| MissingOverride | The method 'reset()' is missing an @Override annotation. | 67–87 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 71 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 71 |
| AvoidDuplicateLiterals | The String literal "BEGINNING_DATETIME" appears 4 times in this file; the first occurrence is on line 76 | 76 |
| AvoidDuplicateLiterals | The String literal "END_DATETIME" appears 4 times in this file; the first occurrence is on line 77 | 77 |
| ControlStatementBraces | This statement should have braces | 97 |
| CommentRequired | Public method and constructor comments are required | 115–124 |
| MissingOverride | The method 'isDuring(String, String)' is missing an @Override annotation. | 115–124 |
| UnnecessaryLocalBeforeReturn | Consider simply returning the value vs storing it in local variable 'result' | 123 |
| CommentRequired | Public method and constructor comments are required | 126–129 |
| MissingOverride | The method 'isDuring(String)' is missing an @Override annotation. | 126–129 |
| CommentRequired | Public method and constructor comments are required | 131–137 |
| MissingOverride | The method 'isBeforeEnd(String, String)' is missing an @Override annotation. | 131–137 |
| UnnecessaryLocalBeforeReturn | Consider simply returning the value vs storing it in local variable 'result' | 136 |
| MissingOverride | The method 'isBeforeEnd(String)' is missing an @Override annotation. | 139–142 |
| CommentRequired | Public method and constructor comments are required | 139–142 |
| MissingOverride | The method 'isAfterBeginning(String, String)' is missing an @Override annotation. | 144–150 |
| CommentRequired | Public method and constructor comments are required | 144–150 |
| UnnecessaryLocalBeforeReturn | Consider simply returning the value vs storing it in local variable 'result' | 149 |
| MissingOverride | The method 'isAfterBeginning(String)' is missing an @Override annotation. | 152–155 |
| CommentRequired | Public method and constructor comments are required | 152–155 |
| CommentRequired | Public method and constructor comments are required | 157–163 |
| MissingOverride | The method 'isBeforeBeginning(String, String)' is missing an @Override annotation. | 157–163 |
| UnnecessaryLocalBeforeReturn | Consider simply returning the value vs storing it in local variable 'result' | 162 |
| CommentRequired | Public method and constructor comments are required | 165–168 |
| MissingOverride | The method 'isBeforeBeginning(String)' is missing an @Override annotation. | 165–168 |
| MissingOverride | The method 'isAfterEnd(String, String)' is missing an @Override annotation. | 170–176 |
| CommentRequired | Public method and constructor comments are required | 170–176 |
| UnnecessaryLocalBeforeReturn | Consider simply returning the value vs storing it in local variable 'result' | 175 |
| CommentRequired | Public method and constructor comments are required | 178–181 |
| MissingOverride | The method 'isAfterEnd(String)' is missing an @Override annotation. | 178–181 |
| MissingOverride | The method 'getLastCampaign()' is missing an @Override annotation. | 183–186 |
| CommentRequired | Public method and constructor comments are required | 183–186 |
| MissingOverride | The method 'getCampaignsReferenceList()' is missing an @Override annotation. | 188–191 |
| CommentRequired | Public method and constructor comments are required | 188–191 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 43–77 |
| NonThreadSafeSingleton | Singleton is not thread safe | 53–56 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 40–59 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'findPhaseByCampaignAndPhaseTypeCode': the method is declared in an interface type | 50 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getPhasesListByCampaign': the method is declared in an interface type | 57 |
| Rule | Violation | Line |
|---|---|---|
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'isDuring': the method is declared in an interface type | 57 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'isDuring': the method is declared in an interface type | 64 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getLastCampaign': the method is declared in an interface type | 69 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'isBeforeEnd': the method is declared in an interface type | 78 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'isBeforeEnd': the method is declared in an interface type | 85 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'isAfterBeginning': the method is declared in an interface type | 94 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'isAfterBeginning': the method is declared in an interface type | 101 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'isBeforeBeginning': the method is declared in an interface type | 110 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'isBeforeBeginning': the method is declared in an interface type | 117 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'isAfterEnd': the method is declared in an interface type | 126 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'isAfterEnd': the method is declared in an interface type | 133 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'reset': the method is declared in an interface type | 139 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getCampaignsReferenceList': the method is declared in an interface type | 146 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 42–51 |
| CommentRequired | Public method and constructor comments are required | 45 |
| CommentRequired | Public method and constructor comments are required | 47 |
| CommentRequired | Public method and constructor comments are required | 49 |
| Rule | Violation | Line |
|---|---|---|
| CallSuperInConstructor | It is a good practice to call super() in a constructor | 50–53 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 38–47 |
| Rule | Violation | Line |
|---|---|---|
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 119 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 136 |
| Rule | Violation | Line |
|---|---|---|
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 118 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 135 |
| Rule | Violation | Line |
|---|---|---|
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 129 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 146 |
| Rule | Violation | Line |
|---|---|---|
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 119 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 137 |
| Rule | Violation | Line |
|---|---|---|
| ShortClassName | Avoid short class names like Area | 43–210 |
| BooleanGetMethodName | A getX() method which returns a boolean should be named isX() | 195–198 |
| Rule | Violation | Line |
|---|---|---|
| BooleanGetMethodName | A getX() method which returns a boolean should be named isX() | 152–155 |
| Rule | Violation | Line |
|---|---|---|
| BooleanGetMethodName | A getX() method which returns a boolean should be named isX() | 158–161 |
| Rule | Violation | Line |
|---|---|---|
| UnusedImports | Avoid unused imports such as 'java.sql.Timestamp' | 36 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ShortClassName | Avoid short class names like Area | 4 | 43–210 |
| BooleanGetMethodName | A getX() method which returns a boolean should be named isX() | 4 | 195–198 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| BooleanGetMethodName | A getX() method which returns a boolean should be named isX() | 4 | 152–155 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| FormalParameterNamingConventions | The method parameter name '_plugin' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 149 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| BooleanGetMethodName | A getX() method which returns a boolean should be named isX() | 4 | 158–161 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 255 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 39–58 |
| ClassWithOnlyPrivateConstructorsShouldBeFinal | A class which only has private constructors should be final | 1 | 39–58 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| NonThreadSafeSingleton | Singleton is not thread safe | 3 | 55–58 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 50–192 |
| RedundantFieldInitializer | Avoid using redundant field initializer for '_cache' | 3 | 52 |
| CommentRequired | Public method and constructor comments are required | 3 | 58–65 |
| NonThreadSafeSingleton | Singleton is not thread safe | 3 | 60–63 |
| CommentRequired | Public method and constructor comments are required | 3 | 67–87 |
| MissingOverride | The method 'reset()' is missing an @Override annotation. | 3 | 67–87 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 71 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 71 |
| AvoidDuplicateLiterals | The String literal "BEGINNING_DATETIME" appears 4 times in this file; the first occurrence is on line 76 | 3 | 76 |
| AvoidDuplicateLiterals | The String literal "END_DATETIME" appears 4 times in this file; the first occurrence is on line 77 | 3 | 77 |
| GuardLogStatement | Logger calls should be surrounded by log level guards. | 2 | 82–83 |
| ControlStatementBraces | This statement should have braces | 3 | 97 |
| CommentRequired | Public method and constructor comments are required | 3 | 115–124 |
| MissingOverride | The method 'isDuring(String, String)' is missing an @Override annotation. | 3 | 115–124 |
| UnnecessaryLocalBeforeReturn | Consider simply returning the value vs storing it in local variable 'result' | 3 | 123 |
| CommentRequired | Public method and constructor comments are required | 3 | 126–129 |
| MissingOverride | The method 'isDuring(String)' is missing an @Override annotation. | 3 | 126–129 |
| CommentRequired | Public method and constructor comments are required | 3 | 131–137 |
| MissingOverride | The method 'isBeforeEnd(String, String)' is missing an @Override annotation. | 3 | 131–137 |
| UnnecessaryLocalBeforeReturn | Consider simply returning the value vs storing it in local variable 'result' | 3 | 136 |
| MissingOverride | The method 'isBeforeEnd(String)' is missing an @Override annotation. | 3 | 139–142 |
| CommentRequired | Public method and constructor comments are required | 3 | 139–142 |
| MissingOverride | The method 'isAfterBeginning(String, String)' is missing an @Override annotation. | 3 | 144–150 |
| CommentRequired | Public method and constructor comments are required | 3 | 144–150 |
| UnnecessaryLocalBeforeReturn | Consider simply returning the value vs storing it in local variable 'result' | 3 | 149 |
| MissingOverride | The method 'isAfterBeginning(String)' is missing an @Override annotation. | 3 | 152–155 |
| CommentRequired | Public method and constructor comments are required | 3 | 152–155 |
| CommentRequired | Public method and constructor comments are required | 3 | 157–163 |
| MissingOverride | The method 'isBeforeBeginning(String, String)' is missing an @Override annotation. | 3 | 157–163 |
| UnnecessaryLocalBeforeReturn | Consider simply returning the value vs storing it in local variable 'result' | 3 | 162 |
| CommentRequired | Public method and constructor comments are required | 3 | 165–168 |
| MissingOverride | The method 'isBeforeBeginning(String)' is missing an @Override annotation. | 3 | 165–168 |
| MissingOverride | The method 'isAfterEnd(String, String)' is missing an @Override annotation. | 3 | 170–176 |
| CommentRequired | Public method and constructor comments are required | 3 | 170–176 |
| UnnecessaryLocalBeforeReturn | Consider simply returning the value vs storing it in local variable 'result' | 3 | 175 |
| CommentRequired | Public method and constructor comments are required | 3 | 178–181 |
| MissingOverride | The method 'isAfterEnd(String)' is missing an @Override annotation. | 3 | 178–181 |
| MissingOverride | The method 'getLastCampaign()' is missing an @Override annotation. | 3 | 183–186 |
| CommentRequired | Public method and constructor comments are required | 3 | 183–186 |
| MissingOverride | The method 'getCampaignsReferenceList()' is missing an @Override annotation. | 3 | 188–191 |
| CommentRequired | Public method and constructor comments are required | 3 | 188–191 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 43–77 |
| NonThreadSafeSingleton | Singleton is not thread safe | 3 | 53–56 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 40–59 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'findPhaseByCampaignAndPhaseTypeCode': the method is declared in an interface type | 3 | 50 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getPhasesListByCampaign': the method is declared in an interface type | 3 | 57 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnusedImports | Avoid unused imports such as 'java.sql.Timestamp' | 4 | 36 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'isDuring': the method is declared in an interface type | 3 | 57 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'isDuring': the method is declared in an interface type | 3 | 64 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getLastCampaign': the method is declared in an interface type | 3 | 69 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'isBeforeEnd': the method is declared in an interface type | 3 | 78 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'isBeforeEnd': the method is declared in an interface type | 3 | 85 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'isAfterBeginning': the method is declared in an interface type | 3 | 94 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'isAfterBeginning': the method is declared in an interface type | 3 | 101 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'isBeforeBeginning': the method is declared in an interface type | 3 | 110 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'isBeforeBeginning': the method is declared in an interface type | 3 | 117 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'isAfterEnd': the method is declared in an interface type | 3 | 126 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'isAfterEnd': the method is declared in an interface type | 3 | 133 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'reset': the method is declared in an interface type | 3 | 139 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getCampaignsReferenceList': the method is declared in an interface type | 3 | 146 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 42–51 |
| CommentRequired | Public method and constructor comments are required | 3 | 45 |
| CommentRequired | Public method and constructor comments are required | 3 | 47 |
| CommentRequired | Public method and constructor comments are required | 3 | 49 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CallSuperInConstructor | It is a good practice to call super() in a constructor | 3 | 50–53 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 38–47 |
| ClassWithOnlyPrivateConstructorsShouldBeFinal | A class which only has private constructors should be final | 1 | 38–47 |
| ClassNamingConventions | The utility class name 'Utils' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' | 1 | 38–47 |
| FieldNamingConventions | The public constant name 'dateFormat' doesn't match '[A-Z][A-Z_0-9]*' | 1 | 41 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 119 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 136 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 118 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 135 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 129 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 146 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 119 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 137 |
