Fork me on GitHub

Résultats PMD

Le document suivant contient les résultats de PMD 6.13.0.

Violations By Priority

Priority 1

fr/paris/lutece/plugins/carto/business/Coordonnee.java

Rule Violation Ligne
FormalParameterNamingConventions The method parameter name '_strGeoJson' doesn't match '[a-z][a-zA-Z0-9]*' 160
FormalParameterNamingConventions The method parameter name '_dataLayer' doesn't match '[a-z][a-zA-Z0-9]*' 170

fr/paris/lutece/plugins/carto/business/DataLayer.java

Rule Violation Ligne
FormalParameterNamingConventions The method parameter name '_strSource' doesn't match '[a-z][a-zA-Z0-9]*' 208
FormalParameterNamingConventions The method parameter name '_strUrlFlux' doesn't match '[a-z][a-zA-Z0-9]*' 226
FormalParameterNamingConventions The method parameter name '_strTypeNameFlux' doesn't match '[a-z][a-zA-Z0-9]*' 244
FormalParameterNamingConventions The method parameter name '_strVersionFlux' doesn't match '[a-z][a-zA-Z0-9]*' 262

fr/paris/lutece/plugins/carto/business/DataLayerMapTemplate.java

Rule Violation Ligne
FieldNamingConventions The field name '_nPictoSizeZoom0_7' doesn't match '_[a-z][a-zA-Z0-9]*' 74
FieldNamingConventions The field name '_nPictoSizeZoom8_12' doesn't match '_[a-z][a-zA-Z0-9]*' 75
FieldNamingConventions The field name '_nPictoSizeZoom13_15' doesn't match '_[a-z][a-zA-Z0-9]*' 76
FieldNamingConventions The field name '_nPictoSizeZoom16_19' doesn't match '_[a-z][a-zA-Z0-9]*' 77
FormalParameterNamingConventions The method parameter name '_fkIdCoordinate' doesn't match '[a-z][a-zA-Z0-9]*' 286
FormalParameterNamingConventions The method parameter name '_nZoomPicto' doesn't match '[a-z][a-zA-Z0-9]*' 306
FormalParameterNamingConventions The method parameter name '_strIconImage' doesn't match '[a-z][a-zA-Z0-9]*' 325
FormalParameterNamingConventions The method parameter name '_nPictoSizeZoom0_7' doesn't match '[a-z][a-zA-Z0-9]*' 341
FormalParameterNamingConventions The method parameter name '_nPictoSizeZoom8_12' doesn't match '[a-z][a-zA-Z0-9]*' 357
FormalParameterNamingConventions The method parameter name '_nPictoSizeZoom13_15' doesn't match '[a-z][a-zA-Z0-9]*' 373
FormalParameterNamingConventions The method parameter name '_nPictoSizeZoom16_19' doesn't match '[a-z][a-zA-Z0-9]*' 389
FormalParameterNamingConventions The method parameter name '_bMarkerCluster' doesn't match '[a-z][a-zA-Z0-9]*' 405

fr/paris/lutece/plugins/carto/business/DataLayerMapTemplateDAO.java

Rule Violation Ligne
FormalParameterNamingConventions The method parameter name '_plugin' doesn't match '[a-z][a-zA-Z0-9]*' 335
FormalParameterNamingConventions The method parameter name '_plugin' doesn't match '[a-z][a-zA-Z0-9]*' 361
FormalParameterNamingConventions The method parameter name '_plugin' doesn't match '[a-z][a-zA-Z0-9]*' 429

fr/paris/lutece/plugins/carto/business/Feature.java

Rule Violation Ligne
FieldNamingConventions The field name 'type' doesn't match '_[a-z][a-zA-Z0-9]*' 23

fr/paris/lutece/plugins/carto/business/FeatureCollection.java

Rule Violation Ligne
FieldNamingConventions The field name 'features' doesn't match '_[a-z][a-zA-Z0-9]*' 10

fr/paris/lutece/plugins/carto/business/IBasemapDAO.java

Rule Violation Ligne
FormalParameterNamingConventions The method parameter name '_plugin' doesn't match '[a-z][a-zA-Z0-9]*' 127

fr/paris/lutece/plugins/carto/business/ICoordonneeDAO.java

Rule Violation Ligne
FormalParameterNamingConventions The method parameter name '_plugin' doesn't match '[a-z][a-zA-Z0-9]*' 126

fr/paris/lutece/plugins/carto/business/IDataLayerDAO.java

Rule Violation Ligne
FormalParameterNamingConventions The method parameter name '_plugin' doesn't match '[a-z][a-zA-Z0-9]*' 127

fr/paris/lutece/plugins/carto/business/IDataLayerMapTemplateDAO.java

Rule Violation Ligne
FormalParameterNamingConventions The method parameter name '_plugin' doesn't match '[a-z][a-zA-Z0-9]*' 127
FormalParameterNamingConventions The method parameter name '_plugin' doesn't match '[a-z][a-zA-Z0-9]*' 138
FormalParameterNamingConventions The method parameter name '_plugin' doesn't match '[a-z][a-zA-Z0-9]*' 175

fr/paris/lutece/plugins/carto/business/IDataLayerTypeDAO.java

Rule Violation Ligne
FormalParameterNamingConventions The method parameter name '_plugin' doesn't match '[a-z][a-zA-Z0-9]*' 127

fr/paris/lutece/plugins/carto/business/IGeometryTypeDAO.java

Rule Violation Ligne
FormalParameterNamingConventions The method parameter name '_plugin' doesn't match '[a-z][a-zA-Z0-9]*' 127

fr/paris/lutece/plugins/carto/business/IMapTemplateDAO.java

Rule Violation Ligne
FormalParameterNamingConventions The method parameter name '_plugin' doesn't match '[a-z][a-zA-Z0-9]*' 127
FormalParameterNamingConventions The method parameter name '_plugin' doesn't match '[a-z][a-zA-Z0-9]*' 136

fr/paris/lutece/plugins/carto/provider/InfoMarker.java

Rule Violation Ligne
FieldNamingConventions The final field name '_strMarker' doesn't match '[a-z][a-zA-Z0-9]*' 52

Priority 3

fr/paris/lutece/plugins/carto/business/BasemapDAO.java

Rule Violation Ligne
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 221–224

fr/paris/lutece/plugins/carto/business/Coordonnee.java

Rule Violation Ligne
CommentRequired Public method and constructor comments are required 62–64
UncommentedEmptyConstructor Document empty constructor 62–64
CommentRequired Public method and constructor comments are required 66–69
CommentRequired Public method and constructor comments are required 155–158
CommentRequired Public method and constructor comments are required 160–163

fr/paris/lutece/plugins/carto/business/CoordonneeDAO.java

Rule Violation Ligne
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 237–240

fr/paris/lutece/plugins/carto/business/DataLayerDAO.java

Rule Violation Ligne
TooManyMethods This class has too many methods, consider refactoring it. 50–431
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 333–336

fr/paris/lutece/plugins/carto/business/DataLayerMapTemplate.java

Rule Violation Ligne
TooManyFields Too many fields 43–409

fr/paris/lutece/plugins/carto/business/DataLayerMapTemplateDAO.java

Rule Violation Ligne
TooManyMethods This class has too many methods, consider refactoring it. 50–464
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 280–283

fr/paris/lutece/plugins/carto/business/DataLayerTypeDAO.java

Rule Violation Ligne
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 229–232

fr/paris/lutece/plugins/carto/business/Feature.java

Rule Violation Ligne
CommentRequired Header comments are required 11–93
UnusedPrivateField Avoid unused private fields such as 'type'. 23
CommentRequired Public method and constructor comments are required 35–53
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 37
CommentRequired Public method and constructor comments are required 57–71
LinguisticNaming Linguistics Antipattern - The setter 'setType' should not return any type except void linguistically 90–92

fr/paris/lutece/plugins/carto/business/FeatureCollection.java

Rule Violation Ligne
CommentRequired Header comments are required 9–40
CommentRequired Public method and constructor comments are required 29–39
UnnecessaryLocalBeforeReturn Consider simply returning the value vs storing it in local variable 'lstCoordonnees' 38

fr/paris/lutece/plugins/carto/business/GeometryTypeDAO.java

Rule Violation Ligne
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 217–220

fr/paris/lutece/plugins/carto/business/IDataLayerDAO.java

Rule Violation Ligne
TooManyMethods This class has too many methods, consider refactoring it. 46–165

fr/paris/lutece/plugins/carto/business/IDataLayerMapTemplateDAO.java

Rule Violation Ligne
TooManyMethods This class has too many methods, consider refactoring it. 46–177

fr/paris/lutece/plugins/carto/business/MapTemplateDAO.java

Rule Violation Ligne
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 250–253

fr/paris/lutece/plugins/carto/provider/IMarkerProvider.java

Rule Violation Ligne
CommentRequired Public method and constructor comments are required 95

fr/paris/lutece/plugins/carto/web/AbstractManageCartoJspBean.java

Rule Violation Ligne
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 49–116
DefaultPackage Use explicit scoping instead of the default package private level 115
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the getItemsFromIds method if you want a default access modifier 115

fr/paris/lutece/plugins/carto/web/BasemapJspBean.java

Rule Violation Ligne
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 62–300
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 122
DefaultPackage Use explicit scoping instead of the default package private level 140–147
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the getItemsFromIds method if you want a default access modifier 141–147
ConfusingTernary Avoid if (x != y) ..; else ..; 167

fr/paris/lutece/plugins/carto/web/CoordonneeJspBean.java

Rule Violation Ligne
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 61–299
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 121
DefaultPackage Use explicit scoping instead of the default package private level 139–146
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the getItemsFromIds method if you want a default access modifier 140–146
ConfusingTernary Avoid if (x != y) ..; else ..; 166

fr/paris/lutece/plugins/carto/web/DataLayerJspBean.java

Rule Violation Ligne
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 35–499
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 88–499
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 158
DefaultPackage Use explicit scoping instead of the default package private level 176–183
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the getItemsFromIds method if you want a default access modifier 177–183
ConfusingTernary Avoid if (x != y) ..; else ..; 203
ControlStatementBraces This statement should have braces 330
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 414
UnusedLocalVariable Avoid unused local variables such as 'strGeoJSON'. 414
CommentRequired Public method and constructor comments are required 454–471
CommentRequired Public method and constructor comments are required 473–498

fr/paris/lutece/plugins/carto/web/DataLayerMapTemplateJspBean.java

Rule Violation Ligne
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 35–545
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 88–545
UnusedPrivateField Avoid unused private fields such as 'ERROR_LAYER_TEMPLATE_INCLUSION_EXCLUSION'. 143
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 159
DefaultPackage Use explicit scoping instead of the default package private level 185–193
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the getItemsFromIds method if you want a default access modifier 186–193
ConfusingTernary Avoid if (x != y) ..; else ..; 213
NPathComplexity The method 'doCreateDataLayerMapTemplate(HttpServletRequest)' has an NPath complexity of 288 240–307
CyclomaticComplexity The method 'doCreateDataLayerMapTemplate(HttpServletRequest)' has a cyclomatic complexity of 13. 240–307
ConfusingTernary Avoid if (x != y) ..; else ..; 285–288
ControlStatementBraces This statement should have braces 286
ControlStatementBraces This statement should have braces 288
ControlStatementBraces This statement should have braces 382
CyclomaticComplexity The method 'doModifyDataLayerMapTemplate(HttpServletRequest)' has a cyclomatic complexity of 17. 411–494
NPathComplexity The method 'doModifyDataLayerMapTemplate(HttpServletRequest)' has an NPath complexity of 672 411–494
ConfusingTernary Avoid if (x != y) ..; else ..; 459–462
ControlStatementBraces This statement should have braces 460
ControlStatementBraces This statement should have braces 462
ConfusingTernary Avoid if (x != y) ..; else ..; 471–474
ControlStatementBraces This statement should have braces 472
ControlStatementBraces This statement should have braces 474
CommentRequired Public method and constructor comments are required 496–513

fr/paris/lutece/plugins/carto/web/DataLayerTypeJspBean.java

Rule Violation Ligne
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 62–301
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 122
DefaultPackage Use explicit scoping instead of the default package private level 140–147
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the getItemsFromIds method if you want a default access modifier 141–147
ConfusingTernary Avoid if (x != y) ..; else ..; 167

fr/paris/lutece/plugins/carto/web/GeometryTypeJspBean.java

Rule Violation Ligne
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 62–300
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 122
DefaultPackage Use explicit scoping instead of the default package private level 140–147
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the getItemsFromIds method if you want a default access modifier 141–147
ConfusingTernary Avoid if (x != y) ..; else ..; 167

fr/paris/lutece/plugins/carto/web/MapTemplateJspBean.java

Rule Violation Ligne
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 69–336
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 131
DefaultPackage Use explicit scoping instead of the default package private level 149–156
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the getItemsFromIds method if you want a default access modifier 150–156
ConfusingTernary Avoid if (x != y) ..; else ..; 176

Priority 4

fr/paris/lutece/plugins/carto/business/DataLayerMapTemplate.java

Rule Violation Ligne
UnusedImports Avoid unused imports such as 'javax.validation.constraints.NotEmpty' 37

fr/paris/lutece/plugins/carto/business/DataLayerType.java

Rule Violation Ligne
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 109–112
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 130–133
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 151–154
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 172–175

fr/paris/lutece/plugins/carto/business/MapTemplate.java

Rule Violation Ligne
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 289–292

fr/paris/lutece/plugins/carto/provider/IMarkerProvider.java

Rule Violation Ligne
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.workflowcore.business.resource.ResourceHistory' 41
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.workflowcore.service.task.ITask' 42

fr/paris/lutece/plugins/carto/web/DataLayerJspBean.java

Rule Violation Ligne
UnusedImports Avoid unused imports such as 'java.util.Collection' 55
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.carto.provider.InfoMarker' 81

fr/paris/lutece/plugins/carto/web/DataLayerMapTemplateJspBean.java

Rule Violation Ligne
UnusedImports Avoid unused imports such as 'fr.paris.lutece.portal.business.file.File' 40

Fichiers

fr/paris/lutece/plugins/carto/business/BasemapDAO.java

Rule Violation Priority Ligne
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 3 221–224

fr/paris/lutece/plugins/carto/business/Coordonnee.java

Rule Violation Priority Ligne
CommentRequired Public method and constructor comments are required 3 62–64
UncommentedEmptyConstructor Document empty constructor 3 62–64
CommentRequired Public method and constructor comments are required 3 66–69
CommentRequired Public method and constructor comments are required 3 155–158
FormalParameterNamingConventions The method parameter name '_strGeoJson' doesn't match '[a-z][a-zA-Z0-9]*' 1 160
CommentRequired Public method and constructor comments are required 3 160–163
FormalParameterNamingConventions The method parameter name '_dataLayer' doesn't match '[a-z][a-zA-Z0-9]*' 1 170

fr/paris/lutece/plugins/carto/business/CoordonneeDAO.java

Rule Violation Priority Ligne
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 3 237–240

fr/paris/lutece/plugins/carto/business/DataLayer.java

Rule Violation Priority Ligne
FormalParameterNamingConventions The method parameter name '_strSource' doesn't match '[a-z][a-zA-Z0-9]*' 1 208
FormalParameterNamingConventions The method parameter name '_strUrlFlux' doesn't match '[a-z][a-zA-Z0-9]*' 1 226
FormalParameterNamingConventions The method parameter name '_strTypeNameFlux' doesn't match '[a-z][a-zA-Z0-9]*' 1 244
FormalParameterNamingConventions The method parameter name '_strVersionFlux' doesn't match '[a-z][a-zA-Z0-9]*' 1 262

fr/paris/lutece/plugins/carto/business/DataLayerDAO.java

Rule Violation Priority Ligne
TooManyMethods This class has too many methods, consider refactoring it. 3 50–431
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 3 333–336

fr/paris/lutece/plugins/carto/business/DataLayerMapTemplate.java

Rule Violation Priority Ligne
UnusedImports Avoid unused imports such as 'javax.validation.constraints.NotEmpty' 4 37
TooManyFields Too many fields 3 43–409
FieldNamingConventions The field name '_nPictoSizeZoom0_7' doesn't match '_[a-z][a-zA-Z0-9]*' 1 74
FieldNamingConventions The field name '_nPictoSizeZoom8_12' doesn't match '_[a-z][a-zA-Z0-9]*' 1 75
FieldNamingConventions The field name '_nPictoSizeZoom13_15' doesn't match '_[a-z][a-zA-Z0-9]*' 1 76
FieldNamingConventions The field name '_nPictoSizeZoom16_19' doesn't match '_[a-z][a-zA-Z0-9]*' 1 77
FormalParameterNamingConventions The method parameter name '_fkIdCoordinate' doesn't match '[a-z][a-zA-Z0-9]*' 1 286
FormalParameterNamingConventions The method parameter name '_nZoomPicto' doesn't match '[a-z][a-zA-Z0-9]*' 1 306
FormalParameterNamingConventions The method parameter name '_strIconImage' doesn't match '[a-z][a-zA-Z0-9]*' 1 325
FormalParameterNamingConventions The method parameter name '_nPictoSizeZoom0_7' doesn't match '[a-z][a-zA-Z0-9]*' 1 341
FormalParameterNamingConventions The method parameter name '_nPictoSizeZoom8_12' doesn't match '[a-z][a-zA-Z0-9]*' 1 357
FormalParameterNamingConventions The method parameter name '_nPictoSizeZoom13_15' doesn't match '[a-z][a-zA-Z0-9]*' 1 373
FormalParameterNamingConventions The method parameter name '_nPictoSizeZoom16_19' doesn't match '[a-z][a-zA-Z0-9]*' 1 389
FormalParameterNamingConventions The method parameter name '_bMarkerCluster' doesn't match '[a-z][a-zA-Z0-9]*' 1 405

fr/paris/lutece/plugins/carto/business/DataLayerMapTemplateDAO.java

Rule Violation Priority Ligne
TooManyMethods This class has too many methods, consider refactoring it. 3 50–464
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 3 280–283
FormalParameterNamingConventions The method parameter name '_plugin' doesn't match '[a-z][a-zA-Z0-9]*' 1 335
FormalParameterNamingConventions The method parameter name '_plugin' doesn't match '[a-z][a-zA-Z0-9]*' 1 361
FormalParameterNamingConventions The method parameter name '_plugin' doesn't match '[a-z][a-zA-Z0-9]*' 1 429

fr/paris/lutece/plugins/carto/business/DataLayerType.java

Rule Violation Priority Ligne
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 4 109–112
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 4 130–133
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 4 151–154
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 4 172–175

fr/paris/lutece/plugins/carto/business/DataLayerTypeDAO.java

Rule Violation Priority Ligne
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 3 229–232

fr/paris/lutece/plugins/carto/business/Feature.java

Rule Violation Priority Ligne
CommentRequired Header comments are required 3 11–93
FieldNamingConventions The field name 'type' doesn't match '_[a-z][a-zA-Z0-9]*' 1 23
UnusedPrivateField Avoid unused private fields such as 'type'. 3 23
CommentRequired Public method and constructor comments are required 3 35–53
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 37
CommentRequired Public method and constructor comments are required 3 57–71
LinguisticNaming Linguistics Antipattern - The setter 'setType' should not return any type except void linguistically 3 90–92

fr/paris/lutece/plugins/carto/business/FeatureCollection.java

Rule Violation Priority Ligne
CommentRequired Header comments are required 3 9–40
FieldNamingConventions The field name 'features' doesn't match '_[a-z][a-zA-Z0-9]*' 1 10
CommentRequired Public method and constructor comments are required 3 29–39
UnnecessaryLocalBeforeReturn Consider simply returning the value vs storing it in local variable 'lstCoordonnees' 3 38

fr/paris/lutece/plugins/carto/business/GeometryTypeDAO.java

Rule Violation Priority Ligne
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 3 217–220

fr/paris/lutece/plugins/carto/business/IBasemapDAO.java

Rule Violation Priority Ligne
FormalParameterNamingConventions The method parameter name '_plugin' doesn't match '[a-z][a-zA-Z0-9]*' 1 127

fr/paris/lutece/plugins/carto/business/ICoordonneeDAO.java

Rule Violation Priority Ligne
FormalParameterNamingConventions The method parameter name '_plugin' doesn't match '[a-z][a-zA-Z0-9]*' 1 126

fr/paris/lutece/plugins/carto/business/IDataLayerDAO.java

Rule Violation Priority Ligne
TooManyMethods This class has too many methods, consider refactoring it. 3 46–165
FormalParameterNamingConventions The method parameter name '_plugin' doesn't match '[a-z][a-zA-Z0-9]*' 1 127

fr/paris/lutece/plugins/carto/business/IDataLayerMapTemplateDAO.java

Rule Violation Priority Ligne
TooManyMethods This class has too many methods, consider refactoring it. 3 46–177
FormalParameterNamingConventions The method parameter name '_plugin' doesn't match '[a-z][a-zA-Z0-9]*' 1 127
FormalParameterNamingConventions The method parameter name '_plugin' doesn't match '[a-z][a-zA-Z0-9]*' 1 138
FormalParameterNamingConventions The method parameter name '_plugin' doesn't match '[a-z][a-zA-Z0-9]*' 1 175

fr/paris/lutece/plugins/carto/business/IDataLayerTypeDAO.java

Rule Violation Priority Ligne
FormalParameterNamingConventions The method parameter name '_plugin' doesn't match '[a-z][a-zA-Z0-9]*' 1 127

fr/paris/lutece/plugins/carto/business/IGeometryTypeDAO.java

Rule Violation Priority Ligne
FormalParameterNamingConventions The method parameter name '_plugin' doesn't match '[a-z][a-zA-Z0-9]*' 1 127

fr/paris/lutece/plugins/carto/business/IMapTemplateDAO.java

Rule Violation Priority Ligne
FormalParameterNamingConventions The method parameter name '_plugin' doesn't match '[a-z][a-zA-Z0-9]*' 1 127
FormalParameterNamingConventions The method parameter name '_plugin' doesn't match '[a-z][a-zA-Z0-9]*' 1 136

fr/paris/lutece/plugins/carto/business/MapTemplate.java

Rule Violation Priority Ligne
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 4 289–292

fr/paris/lutece/plugins/carto/business/MapTemplateDAO.java

Rule Violation Priority Ligne
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 3 250–253

fr/paris/lutece/plugins/carto/provider/IMarkerProvider.java

Rule Violation Priority Ligne
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.workflowcore.business.resource.ResourceHistory' 4 41
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.workflowcore.service.task.ITask' 4 42
CommentRequired Public method and constructor comments are required 3 95

fr/paris/lutece/plugins/carto/provider/InfoMarker.java

Rule Violation Priority Ligne
FieldNamingConventions The final field name '_strMarker' doesn't match '[a-z][a-zA-Z0-9]*' 1 52

fr/paris/lutece/plugins/carto/web/AbstractManageCartoJspBean.java

Rule Violation Priority Ligne
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 3 49–116
DefaultPackage Use explicit scoping instead of the default package private level 3 115
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the getItemsFromIds method if you want a default access modifier 3 115

fr/paris/lutece/plugins/carto/web/BasemapJspBean.java

Rule Violation Priority Ligne
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 3 62–300
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 122
DefaultPackage Use explicit scoping instead of the default package private level 3 140–147
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the getItemsFromIds method if you want a default access modifier 3 141–147
ConfusingTernary Avoid if (x != y) ..; else ..; 3 167

fr/paris/lutece/plugins/carto/web/CoordonneeJspBean.java

Rule Violation Priority Ligne
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 3 61–299
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 121
DefaultPackage Use explicit scoping instead of the default package private level 3 139–146
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the getItemsFromIds method if you want a default access modifier 3 140–146
ConfusingTernary Avoid if (x != y) ..; else ..; 3 166

fr/paris/lutece/plugins/carto/web/DataLayerJspBean.java

Rule Violation Priority Ligne
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 3 35–499
UnusedImports Avoid unused imports such as 'java.util.Collection' 4 55
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.carto.provider.InfoMarker' 4 81
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 3 88–499
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 158
DefaultPackage Use explicit scoping instead of the default package private level 3 176–183
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the getItemsFromIds method if you want a default access modifier 3 177–183
ConfusingTernary Avoid if (x != y) ..; else ..; 3 203
ControlStatementBraces This statement should have braces 3 330
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 414
UnusedLocalVariable Avoid unused local variables such as 'strGeoJSON'. 3 414
CommentRequired Public method and constructor comments are required 3 454–471
CommentRequired Public method and constructor comments are required 3 473–498

fr/paris/lutece/plugins/carto/web/DataLayerMapTemplateJspBean.java

Rule Violation Priority Ligne
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 3 35–545
UnusedImports Avoid unused imports such as 'fr.paris.lutece.portal.business.file.File' 4 40
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 3 88–545
UnusedPrivateField Avoid unused private fields such as 'ERROR_LAYER_TEMPLATE_INCLUSION_EXCLUSION'. 3 143
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 159
DefaultPackage Use explicit scoping instead of the default package private level 3 185–193
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the getItemsFromIds method if you want a default access modifier 3 186–193
ConfusingTernary Avoid if (x != y) ..; else ..; 3 213
NPathComplexity The method 'doCreateDataLayerMapTemplate(HttpServletRequest)' has an NPath complexity of 288 3 240–307
CyclomaticComplexity The method 'doCreateDataLayerMapTemplate(HttpServletRequest)' has a cyclomatic complexity of 13. 3 240–307
ConfusingTernary Avoid if (x != y) ..; else ..; 3 285–288
ControlStatementBraces This statement should have braces 3 286
ControlStatementBraces This statement should have braces 3 288
ControlStatementBraces This statement should have braces 3 382
CyclomaticComplexity The method 'doModifyDataLayerMapTemplate(HttpServletRequest)' has a cyclomatic complexity of 17. 3 411–494
NPathComplexity The method 'doModifyDataLayerMapTemplate(HttpServletRequest)' has an NPath complexity of 672 3 411–494
ConfusingTernary Avoid if (x != y) ..; else ..; 3 459–462
ControlStatementBraces This statement should have braces 3 460
ControlStatementBraces This statement should have braces 3 462
ConfusingTernary Avoid if (x != y) ..; else ..; 3 471–474
ControlStatementBraces This statement should have braces 3 472
ControlStatementBraces This statement should have braces 3 474
CommentRequired Public method and constructor comments are required 3 496–513

fr/paris/lutece/plugins/carto/web/DataLayerTypeJspBean.java

Rule Violation Priority Ligne
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 3 62–301
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 122
DefaultPackage Use explicit scoping instead of the default package private level 3 140–147
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the getItemsFromIds method if you want a default access modifier 3 141–147
ConfusingTernary Avoid if (x != y) ..; else ..; 3 167

fr/paris/lutece/plugins/carto/web/GeometryTypeJspBean.java

Rule Violation Priority Ligne
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 3 62–300
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 122
DefaultPackage Use explicit scoping instead of the default package private level 3 140–147
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the getItemsFromIds method if you want a default access modifier 3 141–147
ConfusingTernary Avoid if (x != y) ..; else ..; 3 167

fr/paris/lutece/plugins/carto/web/MapTemplateJspBean.java

Rule Violation Priority Ligne
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 3 69–336
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 131
DefaultPackage Use explicit scoping instead of the default package private level 3 149–156
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the getItemsFromIds method if you want a default access modifier 3 150–156
ConfusingTernary Avoid if (x != y) ..; else ..; 3 176