Fork me on GitHub

Résultats PMD

Le document suivant contient les résultats de PMD 6.13.0.

Violations By Priority

Priority 2

fr/paris/lutece/plugins/childpages/business/portlet/ChildPagesPortlet.java

Rule Violation Ligne
IntegerInstantiation Avoid instantiating Integer objects. Call Integer.valueOf() instead. 131

Priority 3

fr/paris/lutece/plugins/childpages/business/portlet/ChildPagesPortlet.java

Rule Violation Ligne
CallSuperInConstructor It is a good practice to call super() in a constructor 6871
MissingOverride The method 'getXml(HttpServletRequest)' is missing an @Override annotation. 99145
CollapsibleIfStatements These nested if statements could be combined 118138
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 129
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 129134
UnnecessaryConversionTemporary Avoid unnecessary temporaries when converting primitives to Strings 131
MissingOverride The method 'getXmlDocument(HttpServletRequest)' is missing an @Override annotation. 153156
MissingOverride The method 'remove()' is missing an @Override annotation. 169172

fr/paris/lutece/plugins/childpages/business/portlet/ChildPagesPortletDAO.java

Rule Violation Ligne
MissingOverride The method 'insert(Portlet)' is missing an @Override annotation. 6573
ShortVariable Avoid variables with short names like p 68
MissingOverride The method 'delete(int)' is missing an @Override annotation. 8086
MissingOverride The method 'load(int)' is missing an @Override annotation. 94111
MissingOverride The method 'store(Portlet)' is missing an @Override annotation. 117125
ShortVariable Avoid variables with short names like p 120
MissingOverride The method 'selectChildPagesList(int)' is missing an @Override annotation. 133149
MissingOverride The method 'selectPagesList()' is missing an @Override annotation. 156171
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 180

fr/paris/lutece/plugins/childpages/business/portlet/ChildPagesPortletHome.java

Rule Violation Ligne
RedundantFieldInitializer Avoid using redundant field initializer for '_singleton' 56
AssignmentToNonFinalStatic Possible unsafe assignment to a non-final static field in a constructor. 56
CallSuperInConstructor It is a good practice to call super() in a constructor 6167
MissingOverride The method 'getPortletTypeId()' is missing an @Override annotation. 7480
UnnecessaryLocalBeforeReturn Consider simply returning the value vs storing it in local variable 'strPortletTypeId' 79
NonThreadSafeSingleton Singleton is not thread safe 8992
MissingOverride The method 'getDAO()' is missing an @Override annotation. 102105
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 150

fr/paris/lutece/plugins/childpages/business/portlet/EventListener.java

Rule Violation Ligne
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 97

fr/paris/lutece/plugins/childpages/business/portlet/IChildPagesPortletDAO.java

Rule Violation Ligne
UnnecessaryModifier Unnecessary modifiers 'public abstract' on method 'delete': the method is declared in an interface type 55
MissingOverride The method 'delete(int)' is missing an @Override annotation. 55
MissingOverride The method 'insert(Portlet)' is missing an @Override annotation. 63
UnnecessaryModifier Unnecessary modifiers 'public abstract' on method 'insert': the method is declared in an interface type 63
UnnecessaryModifier Unnecessary modifiers 'public abstract' on method 'load': the method is declared in an interface type 72
MissingOverride The method 'load(int)' is missing an @Override annotation. 72
UnnecessaryModifier Unnecessary modifiers 'public abstract' on method 'selectChildPagesList': the method is declared in an interface type 81
UnnecessaryModifier Unnecessary modifiers 'public abstract' on method 'selectPagesList': the method is declared in an interface type 89
MissingOverride The method 'store(Portlet)' is missing an @Override annotation. 96
UnnecessaryModifier Unnecessary modifiers 'public abstract' on method 'store': the method is declared in an interface type 96
UnnecessaryModifier Unnecessary modifier 'public' on method 'getChildPagesPortlets': the method is declared in an interface type 104

fr/paris/lutece/plugins/childpages/web/portlet/ChildPagesPortletJspBean.java

Rule Violation Ligne
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 56261
MissingOverride The method 'getCreate(HttpServletRequest)' is missing an @Override annotation. 93103
CommentRequired Public method and constructor comments are required 105120
MissingOverride The method 'getModify(HttpServletRequest)' is missing an @Override annotation. 105120
MissingOverride The method 'doCreate(HttpServletRequest)' is missing an @Override annotation. 128185
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 130
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 132
MissingOverride The method 'doModify(HttpServletRequest)' is missing an @Override annotation. 193248

Fichiers

fr/paris/lutece/plugins/childpages/business/portlet/ChildPagesPortlet.java

Rule Violation Priority Ligne
CallSuperInConstructor It is a good practice to call super() in a constructor 3 6871
MissingOverride The method 'getXml(HttpServletRequest)' is missing an @Override annotation. 3 99145
CollapsibleIfStatements These nested if statements could be combined 3 118138
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 3 129
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 3 129134
UnnecessaryConversionTemporary Avoid unnecessary temporaries when converting primitives to Strings 3 131
IntegerInstantiation Avoid instantiating Integer objects. Call Integer.valueOf() instead. 2 131
MissingOverride The method 'getXmlDocument(HttpServletRequest)' is missing an @Override annotation. 3 153156
MissingOverride The method 'remove()' is missing an @Override annotation. 3 169172

fr/paris/lutece/plugins/childpages/business/portlet/ChildPagesPortletDAO.java

Rule Violation Priority Ligne
MissingOverride The method 'insert(Portlet)' is missing an @Override annotation. 3 6573
ShortVariable Avoid variables with short names like p 3 68
MissingOverride The method 'delete(int)' is missing an @Override annotation. 3 8086
MissingOverride The method 'load(int)' is missing an @Override annotation. 3 94111
MissingOverride The method 'store(Portlet)' is missing an @Override annotation. 3 117125
ShortVariable Avoid variables with short names like p 3 120
MissingOverride The method 'selectChildPagesList(int)' is missing an @Override annotation. 3 133149
MissingOverride The method 'selectPagesList()' is missing an @Override annotation. 3 156171
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 180

fr/paris/lutece/plugins/childpages/business/portlet/ChildPagesPortletHome.java

Rule Violation Priority Ligne
RedundantFieldInitializer Avoid using redundant field initializer for '_singleton' 3 56
AssignmentToNonFinalStatic Possible unsafe assignment to a non-final static field in a constructor. 3 56
CallSuperInConstructor It is a good practice to call super() in a constructor 3 6167
MissingOverride The method 'getPortletTypeId()' is missing an @Override annotation. 3 7480
UnnecessaryLocalBeforeReturn Consider simply returning the value vs storing it in local variable 'strPortletTypeId' 3 79
NonThreadSafeSingleton Singleton is not thread safe 3 8992
MissingOverride The method 'getDAO()' is missing an @Override annotation. 3 102105
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 150

fr/paris/lutece/plugins/childpages/business/portlet/EventListener.java

Rule Violation Priority Ligne
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 97

fr/paris/lutece/plugins/childpages/business/portlet/IChildPagesPortletDAO.java

Rule Violation Priority Ligne
UnnecessaryModifier Unnecessary modifiers 'public abstract' on method 'delete': the method is declared in an interface type 3 55
MissingOverride The method 'delete(int)' is missing an @Override annotation. 3 55
MissingOverride The method 'insert(Portlet)' is missing an @Override annotation. 3 63
UnnecessaryModifier Unnecessary modifiers 'public abstract' on method 'insert': the method is declared in an interface type 3 63
UnnecessaryModifier Unnecessary modifiers 'public abstract' on method 'load': the method is declared in an interface type 3 72
MissingOverride The method 'load(int)' is missing an @Override annotation. 3 72
UnnecessaryModifier Unnecessary modifiers 'public abstract' on method 'selectChildPagesList': the method is declared in an interface type 3 81
UnnecessaryModifier Unnecessary modifiers 'public abstract' on method 'selectPagesList': the method is declared in an interface type 3 89
MissingOverride The method 'store(Portlet)' is missing an @Override annotation. 3 96
UnnecessaryModifier Unnecessary modifiers 'public abstract' on method 'store': the method is declared in an interface type 3 96
UnnecessaryModifier Unnecessary modifier 'public' on method 'getChildPagesPortlets': the method is declared in an interface type 3 104

fr/paris/lutece/plugins/childpages/web/portlet/ChildPagesPortletJspBean.java

Rule Violation Priority Ligne
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 3 56261
MissingOverride The method 'getCreate(HttpServletRequest)' is missing an @Override annotation. 3 93103
CommentRequired Public method and constructor comments are required 3 105120
MissingOverride The method 'getModify(HttpServletRequest)' is missing an @Override annotation. 3 105120
MissingOverride The method 'doCreate(HttpServletRequest)' is missing an @Override annotation. 3 128185
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 130
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 132
MissingOverride The method 'doModify(HttpServletRequest)' is missing an @Override annotation. 3 193248