The following document contains the results of PMD 6.13.0.
| Rule | Violation | Line |
|---|---|---|
| IntegerInstantiation | Avoid instantiating Integer objects. Call Integer.valueOf() instead. | 131 |
| Rule | Violation | Line |
|---|---|---|
| CallSuperInConstructor | It is a good practice to call super() in a constructor | 68–71 |
| MissingOverride | The method 'getXml(HttpServletRequest)' is missing an @Override annotation. | 99–145 |
| CollapsibleIfStatements | These nested if statements could be combined | 118–138 |
| AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 129 |
| AvoidDeeplyNestedIfStmts | Deeply nested if..then statements are hard to read | 129–134 |
| UnnecessaryConversionTemporary | Avoid unnecessary temporaries when converting primitives to Strings | 131 |
| MissingOverride | The method 'getXmlDocument(HttpServletRequest)' is missing an @Override annotation. | 153–156 |
| MissingOverride | The method 'remove()' is missing an @Override annotation. | 169–172 |
| Rule | Violation | Line |
|---|---|---|
| MissingOverride | The method 'insert(Portlet)' is missing an @Override annotation. | 65–73 |
| ShortVariable | Avoid variables with short names like p | 68 |
| MissingOverride | The method 'delete(int)' is missing an @Override annotation. | 80–86 |
| MissingOverride | The method 'load(int)' is missing an @Override annotation. | 94–111 |
| MissingOverride | The method 'store(Portlet)' is missing an @Override annotation. | 117–125 |
| ShortVariable | Avoid variables with short names like p | 120 |
| MissingOverride | The method 'selectChildPagesList(int)' is missing an @Override annotation. | 133–149 |
| MissingOverride | The method 'selectPagesList()' is missing an @Override annotation. | 156–171 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 180 |
| Rule | Violation | Line |
|---|---|---|
| RedundantFieldInitializer | Avoid using redundant field initializer for '_singleton' | 56 |
| AssignmentToNonFinalStatic | Possible unsafe assignment to a non-final static field in a constructor. | 56 |
| CallSuperInConstructor | It is a good practice to call super() in a constructor | 61–67 |
| MissingOverride | The method 'getPortletTypeId()' is missing an @Override annotation. | 74–80 |
| UnnecessaryLocalBeforeReturn | Consider simply returning the value vs storing it in local variable 'strPortletTypeId' | 79 |
| NonThreadSafeSingleton | Singleton is not thread safe | 89–92 |
| MissingOverride | The method 'getDAO()' is missing an @Override annotation. | 102–105 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 150 |
| Rule | Violation | Line |
|---|---|---|
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 97 |
| Rule | Violation | Line |
|---|---|---|
| UnnecessaryModifier | Unnecessary modifiers 'public abstract' on method 'delete': the method is declared in an interface type | 55 |
| MissingOverride | The method 'delete(int)' is missing an @Override annotation. | 55 |
| MissingOverride | The method 'insert(Portlet)' is missing an @Override annotation. | 63 |
| UnnecessaryModifier | Unnecessary modifiers 'public abstract' on method 'insert': the method is declared in an interface type | 63 |
| UnnecessaryModifier | Unnecessary modifiers 'public abstract' on method 'load': the method is declared in an interface type | 72 |
| MissingOverride | The method 'load(int)' is missing an @Override annotation. | 72 |
| UnnecessaryModifier | Unnecessary modifiers 'public abstract' on method 'selectChildPagesList': the method is declared in an interface type | 81 |
| UnnecessaryModifier | Unnecessary modifiers 'public abstract' on method 'selectPagesList': the method is declared in an interface type | 89 |
| MissingOverride | The method 'store(Portlet)' is missing an @Override annotation. | 96 |
| UnnecessaryModifier | Unnecessary modifiers 'public abstract' on method 'store': the method is declared in an interface type | 96 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getChildPagesPortlets': the method is declared in an interface type | 104 |
| Rule | Violation | Line |
|---|---|---|
| MissingSerialVersionUID | Classes implementing Serializable should set a serialVersionUID | 56–261 |
| MissingOverride | The method 'getCreate(HttpServletRequest)' is missing an @Override annotation. | 93–103 |
| CommentRequired | Public method and constructor comments are required | 105–120 |
| MissingOverride | The method 'getModify(HttpServletRequest)' is missing an @Override annotation. | 105–120 |
| MissingOverride | The method 'doCreate(HttpServletRequest)' is missing an @Override annotation. | 128–185 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 130 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 132 |
| MissingOverride | The method 'doModify(HttpServletRequest)' is missing an @Override annotation. | 193–248 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CallSuperInConstructor | It is a good practice to call super() in a constructor | 3 | 68–71 |
| MissingOverride | The method 'getXml(HttpServletRequest)' is missing an @Override annotation. | 3 | 99–145 |
| CollapsibleIfStatements | These nested if statements could be combined | 3 | 118–138 |
| AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 3 | 129 |
| AvoidDeeplyNestedIfStmts | Deeply nested if..then statements are hard to read | 3 | 129–134 |
| UnnecessaryConversionTemporary | Avoid unnecessary temporaries when converting primitives to Strings | 3 | 131 |
| IntegerInstantiation | Avoid instantiating Integer objects. Call Integer.valueOf() instead. | 2 | 131 |
| MissingOverride | The method 'getXmlDocument(HttpServletRequest)' is missing an @Override annotation. | 3 | 153–156 |
| MissingOverride | The method 'remove()' is missing an @Override annotation. | 3 | 169–172 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| MissingOverride | The method 'insert(Portlet)' is missing an @Override annotation. | 3 | 65–73 |
| ShortVariable | Avoid variables with short names like p | 3 | 68 |
| MissingOverride | The method 'delete(int)' is missing an @Override annotation. | 3 | 80–86 |
| MissingOverride | The method 'load(int)' is missing an @Override annotation. | 3 | 94–111 |
| MissingOverride | The method 'store(Portlet)' is missing an @Override annotation. | 3 | 117–125 |
| ShortVariable | Avoid variables with short names like p | 3 | 120 |
| MissingOverride | The method 'selectChildPagesList(int)' is missing an @Override annotation. | 3 | 133–149 |
| MissingOverride | The method 'selectPagesList()' is missing an @Override annotation. | 3 | 156–171 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 180 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| RedundantFieldInitializer | Avoid using redundant field initializer for '_singleton' | 3 | 56 |
| AssignmentToNonFinalStatic | Possible unsafe assignment to a non-final static field in a constructor. | 3 | 56 |
| CallSuperInConstructor | It is a good practice to call super() in a constructor | 3 | 61–67 |
| MissingOverride | The method 'getPortletTypeId()' is missing an @Override annotation. | 3 | 74–80 |
| UnnecessaryLocalBeforeReturn | Consider simply returning the value vs storing it in local variable 'strPortletTypeId' | 3 | 79 |
| NonThreadSafeSingleton | Singleton is not thread safe | 3 | 89–92 |
| MissingOverride | The method 'getDAO()' is missing an @Override annotation. | 3 | 102–105 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 150 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 97 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnnecessaryModifier | Unnecessary modifiers 'public abstract' on method 'delete': the method is declared in an interface type | 3 | 55 |
| MissingOverride | The method 'delete(int)' is missing an @Override annotation. | 3 | 55 |
| MissingOverride | The method 'insert(Portlet)' is missing an @Override annotation. | 3 | 63 |
| UnnecessaryModifier | Unnecessary modifiers 'public abstract' on method 'insert': the method is declared in an interface type | 3 | 63 |
| UnnecessaryModifier | Unnecessary modifiers 'public abstract' on method 'load': the method is declared in an interface type | 3 | 72 |
| MissingOverride | The method 'load(int)' is missing an @Override annotation. | 3 | 72 |
| UnnecessaryModifier | Unnecessary modifiers 'public abstract' on method 'selectChildPagesList': the method is declared in an interface type | 3 | 81 |
| UnnecessaryModifier | Unnecessary modifiers 'public abstract' on method 'selectPagesList': the method is declared in an interface type | 3 | 89 |
| MissingOverride | The method 'store(Portlet)' is missing an @Override annotation. | 3 | 96 |
| UnnecessaryModifier | Unnecessary modifiers 'public abstract' on method 'store': the method is declared in an interface type | 3 | 96 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getChildPagesPortlets': the method is declared in an interface type | 3 | 104 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| MissingSerialVersionUID | Classes implementing Serializable should set a serialVersionUID | 3 | 56–261 |
| MissingOverride | The method 'getCreate(HttpServletRequest)' is missing an @Override annotation. | 3 | 93–103 |
| CommentRequired | Public method and constructor comments are required | 3 | 105–120 |
| MissingOverride | The method 'getModify(HttpServletRequest)' is missing an @Override annotation. | 3 | 105–120 |
| MissingOverride | The method 'doCreate(HttpServletRequest)' is missing an @Override annotation. | 3 | 128–185 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 130 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 132 |
| MissingOverride | The method 'doModify(HttpServletRequest)' is missing an @Override annotation. | 3 | 193–248 |
