Fork me on GitHub

PMD Results

The following document contains the results of PMD 6.13.0.

Violations By Priority

Priority 1

fr/paris/lutece/plugins/crmclient/business/demand/DemandItem.java

Rule Violation Line
AbstractClassWithoutAnyMethod No abstract method which means that the keyword is most likely used to prevent instantiation. Use a private or protected constructor instead. 4350

fr/paris/lutece/plugins/crmclient/business/demand/DemandItemV2.java

Rule Violation Line
AbstractClassWithoutAnyMethod No abstract method which means that the keyword is most likely used to prevent instantiation. Use a private or protected constructor instead. 4350

fr/paris/lutece/plugins/crmclient/business/user/UserItem.java

Rule Violation Line
AbstractClassWithoutAnyMethod No abstract method which means that the keyword is most likely used to prevent instantiation. Use a private or protected constructor instead. 4349

Priority 3

fr/paris/lutece/plugins/crmclient/business/CRMItemFactory.java

Rule Violation Line
UnnecessaryLocalBeforeReturn Consider simply returning the value vs storing it in local variable 'crmItem' 69
IdenticalCatchBranches 'catch' branch identical to 'BeanDefinitionStoreException' branch 7578
IdenticalCatchBranches 'catch' branch identical to 'BeanDefinitionStoreException' branch 7982

fr/paris/lutece/plugins/crmclient/business/CRMItemQueueDAO.java

Rule Violation Line
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 124160
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 151
IdenticalCatchBranches 'catch' branch identical to 'IOException' branch 192195
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 224

fr/paris/lutece/plugins/crmclient/business/demand/DemandItemCreateByIdCRMUser.java

Rule Violation Line
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 55
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 56

fr/paris/lutece/plugins/crmclient/business/demand/DemandItemCreateByUserGuid.java

Rule Violation Line
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 55
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 56

fr/paris/lutece/plugins/crmclient/business/demand/DemandItemCreateByUserGuidV2.java

Rule Violation Line
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 55
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 56

fr/paris/lutece/plugins/crmclient/business/demand/DemandItemDelete.java

Rule Violation Line
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 55
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 56

fr/paris/lutece/plugins/crmclient/business/demand/DemandItemDeleteV2.java

Rule Violation Line
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 55
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 56

fr/paris/lutece/plugins/crmclient/business/demand/DemandItemUpdate.java

Rule Violation Line
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 55
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 56

fr/paris/lutece/plugins/crmclient/business/demand/DemandItemUpdateV2.java

Rule Violation Line
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 55
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 56

fr/paris/lutece/plugins/crmclient/business/demand/DemandItemUserGuid.java

Rule Violation Line
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 56
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 57
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 58
AppendCharacterWithChar Avoid appending characters as strings in StringBuffer.append. 59
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 59

fr/paris/lutece/plugins/crmclient/business/user/UserItemAttribute.java

Rule Violation Line
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 56
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 57
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 58
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 59
AppendCharacterWithChar Avoid appending characters as strings in StringBuffer.append. 59

fr/paris/lutece/plugins/crmclient/business/user/UserItemAttributesJson.java

Rule Violation Line
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 55
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 56

fr/paris/lutece/plugins/crmclient/business/user/UserItemAttributesXml.java

Rule Violation Line
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 55
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 56

fr/paris/lutece/plugins/crmclient/business/user/UserItemGuidByIdCRMUser.java

Rule Violation Line
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 56
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 57
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 58
AppendCharacterWithChar Avoid appending characters as strings in StringBuffer.append. 59
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 59

fr/paris/lutece/plugins/crmclient/service/CRMClientService.java

Rule Violation Line
TooManyMethods This class has too many methods, consider refactoring it. 53545
DefaultPackage Use explicit scoping instead of the default package private level 6162
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the _crmClientProcessor field if you want a default access modifier 62
UseObjectForClearerAPI Rather than using a lot of String arguments, consider using a container object for those values. 77
UseObjectForClearerAPI Rather than using a lot of String arguments, consider using a container object for those values. 86
UseObjectForClearerAPI Rather than using a lot of String arguments, consider using a container object for those values. 125
UseObjectForClearerAPI Rather than using a lot of String arguments, consider using a container object for those values. 134
UseObjectForClearerAPI Rather than using a lot of String arguments, consider using a container object for those values. 161
UseObjectForClearerAPI Rather than using a lot of String arguments, consider using a container object for those values. 168169
UseObjectForClearerAPI Rather than using a lot of String arguments, consider using a container object for those values. 194
UseObjectForClearerAPI Rather than using a lot of String arguments, consider using a container object for those values. 202203
UseObjectForClearerAPI Rather than using a lot of String arguments, consider using a container object for those values. 441
UseObjectForClearerAPI Rather than using a lot of String arguments, consider using a container object for those values. 463464
UseObjectForClearerAPI Rather than using a lot of String arguments, consider using a container object for those values. 506507

fr/paris/lutece/plugins/crmclient/service/authenticator/AuthenticatorService.java

Rule Violation Line
CommentRequired Header comments are required 43100

fr/paris/lutece/plugins/crmclient/service/daemon/CRMClientSenderDaemon.java

Rule Violation Line
MissingOverride The method 'run()' is missing an @Override annotation. 56107
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 56107
InsufficientStringBufferDeclaration StringBuffer constructor is initialized with size 16, but has at least 20 characters appended. 58
ConsecutiveLiteralAppends StringBuffer (or StringBuilder).append is called 2 consecutive times with literals. Use a single append with a single combined String. 86
InefficientStringBuffering Avoid concatenating nonliterals in a StringBuffer/StringBuilder constructor or append(). 87
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 9295

fr/paris/lutece/plugins/crmclient/service/processor/CRMClientWSProcessor.java

Rule Violation Line
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 142

fr/paris/lutece/plugins/crmclient/util/http/WebServiceCaller.java

Rule Violation Line
InsufficientStringBufferDeclaration StringBuffer constructor is initialized with size 16, but has at least 275 characters appended. 111
ConsecutiveLiteralAppends StringBuffer (or StringBuilder).append is called 2 consecutive times with literals. Use a single append with a single combined String. 112
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 112
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 113
AppendCharacterWithChar Avoid appending characters as strings in StringBuffer.append. 118
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 121
ConsecutiveLiteralAppends StringBuffer (or StringBuilder).append is called 2 consecutive times with literals. Use a single append with a single combined String. 121
AddEmptyString Do not add empty strings 132
ConsecutiveLiteralAppends StringBuffer (or StringBuilder).append is called 2 consecutive times with literals. Use a single append with a single combined String. 134
ConsecutiveLiteralAppends StringBuffer (or StringBuilder).append is called 2 consecutive times with literals. Use a single append with a single combined String. 144

Files

fr/paris/lutece/plugins/crmclient/business/CRMItemFactory.java

Rule Violation Priority Line
UnnecessaryLocalBeforeReturn Consider simply returning the value vs storing it in local variable 'crmItem' 3 69
IdenticalCatchBranches 'catch' branch identical to 'BeanDefinitionStoreException' branch 3 7578
IdenticalCatchBranches 'catch' branch identical to 'BeanDefinitionStoreException' branch 3 7982

fr/paris/lutece/plugins/crmclient/business/CRMItemQueueDAO.java

Rule Violation Priority Line
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 3 124160
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 151
IdenticalCatchBranches 'catch' branch identical to 'IOException' branch 3 192195
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 224

fr/paris/lutece/plugins/crmclient/business/demand/DemandItem.java

Rule Violation Priority Line
AbstractClassWithoutAnyMethod No abstract method which means that the keyword is most likely used to prevent instantiation. Use a private or protected constructor instead. 1 4350

fr/paris/lutece/plugins/crmclient/business/demand/DemandItemCreateByIdCRMUser.java

Rule Violation Priority Line
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 55
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 56

fr/paris/lutece/plugins/crmclient/business/demand/DemandItemCreateByUserGuid.java

Rule Violation Priority Line
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 55
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 56

fr/paris/lutece/plugins/crmclient/business/demand/DemandItemCreateByUserGuidV2.java

Rule Violation Priority Line
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 55
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 56

fr/paris/lutece/plugins/crmclient/business/demand/DemandItemDelete.java

Rule Violation Priority Line
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 55
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 56

fr/paris/lutece/plugins/crmclient/business/demand/DemandItemDeleteV2.java

Rule Violation Priority Line
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 55
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 56

fr/paris/lutece/plugins/crmclient/business/demand/DemandItemUpdate.java

Rule Violation Priority Line
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 55
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 56

fr/paris/lutece/plugins/crmclient/business/demand/DemandItemUpdateV2.java

Rule Violation Priority Line
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 55
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 56

fr/paris/lutece/plugins/crmclient/business/demand/DemandItemUserGuid.java

Rule Violation Priority Line
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 56
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 57
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 58
AppendCharacterWithChar Avoid appending characters as strings in StringBuffer.append. 3 59
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 59

fr/paris/lutece/plugins/crmclient/business/demand/DemandItemV2.java

Rule Violation Priority Line
AbstractClassWithoutAnyMethod No abstract method which means that the keyword is most likely used to prevent instantiation. Use a private or protected constructor instead. 1 4350

fr/paris/lutece/plugins/crmclient/business/user/UserItem.java

Rule Violation Priority Line
AbstractClassWithoutAnyMethod No abstract method which means that the keyword is most likely used to prevent instantiation. Use a private or protected constructor instead. 1 4349

fr/paris/lutece/plugins/crmclient/business/user/UserItemAttribute.java

Rule Violation Priority Line
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 56
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 57
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 58
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 59
AppendCharacterWithChar Avoid appending characters as strings in StringBuffer.append. 3 59

fr/paris/lutece/plugins/crmclient/business/user/UserItemAttributesJson.java

Rule Violation Priority Line
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 55
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 56

fr/paris/lutece/plugins/crmclient/business/user/UserItemAttributesXml.java

Rule Violation Priority Line
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 55
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 56

fr/paris/lutece/plugins/crmclient/business/user/UserItemGuidByIdCRMUser.java

Rule Violation Priority Line
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 56
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 57
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 58
AppendCharacterWithChar Avoid appending characters as strings in StringBuffer.append. 3 59
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 59

fr/paris/lutece/plugins/crmclient/service/CRMClientService.java

Rule Violation Priority Line
TooManyMethods This class has too many methods, consider refactoring it. 3 53545
DefaultPackage Use explicit scoping instead of the default package private level 3 6162
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the _crmClientProcessor field if you want a default access modifier 3 62
UseObjectForClearerAPI Rather than using a lot of String arguments, consider using a container object for those values. 3 77
UseObjectForClearerAPI Rather than using a lot of String arguments, consider using a container object for those values. 3 86
UseObjectForClearerAPI Rather than using a lot of String arguments, consider using a container object for those values. 3 125
UseObjectForClearerAPI Rather than using a lot of String arguments, consider using a container object for those values. 3 134
UseObjectForClearerAPI Rather than using a lot of String arguments, consider using a container object for those values. 3 161
UseObjectForClearerAPI Rather than using a lot of String arguments, consider using a container object for those values. 3 168169
UseObjectForClearerAPI Rather than using a lot of String arguments, consider using a container object for those values. 3 194
UseObjectForClearerAPI Rather than using a lot of String arguments, consider using a container object for those values. 3 202203
UseObjectForClearerAPI Rather than using a lot of String arguments, consider using a container object for those values. 3 441
UseObjectForClearerAPI Rather than using a lot of String arguments, consider using a container object for those values. 3 463464
UseObjectForClearerAPI Rather than using a lot of String arguments, consider using a container object for those values. 3 506507

fr/paris/lutece/plugins/crmclient/service/authenticator/AuthenticatorService.java

Rule Violation Priority Line
CommentRequired Header comments are required 3 43100

fr/paris/lutece/plugins/crmclient/service/daemon/CRMClientSenderDaemon.java

Rule Violation Priority Line
MissingOverride The method 'run()' is missing an @Override annotation. 3 56107
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 3 56107
InsufficientStringBufferDeclaration StringBuffer constructor is initialized with size 16, but has at least 20 characters appended. 3 58
ConsecutiveLiteralAppends StringBuffer (or StringBuilder).append is called 2 consecutive times with literals. Use a single append with a single combined String. 3 86
InefficientStringBuffering Avoid concatenating nonliterals in a StringBuffer/StringBuilder constructor or append(). 3 87
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 3 9295

fr/paris/lutece/plugins/crmclient/service/processor/CRMClientWSProcessor.java

Rule Violation Priority Line
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 142

fr/paris/lutece/plugins/crmclient/util/http/WebServiceCaller.java

Rule Violation Priority Line
InsufficientStringBufferDeclaration StringBuffer constructor is initialized with size 16, but has at least 275 characters appended. 3 111
ConsecutiveLiteralAppends StringBuffer (or StringBuilder).append is called 2 consecutive times with literals. Use a single append with a single combined String. 3 112
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 112
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 113
AppendCharacterWithChar Avoid appending characters as strings in StringBuffer.append. 3 118
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 121
ConsecutiveLiteralAppends StringBuffer (or StringBuilder).append is called 2 consecutive times with literals. Use a single append with a single combined String. 3 121
AddEmptyString Do not add empty strings 3 132
ConsecutiveLiteralAppends StringBuffer (or StringBuilder).append is called 2 consecutive times with literals. Use a single append with a single combined String. 3 134
ConsecutiveLiteralAppends StringBuffer (or StringBuilder).append is called 2 consecutive times with literals. Use a single append with a single combined String. 3 144