The following document contains the results of PMD 5.3.5.
| Violation | Line |
|---|---|
| Use block level rather than method level synchronization | 124–160 |
| Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 151 |
| Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 224 |
| Violation | Line |
|---|---|
| Abstract classes should be named AbstractXXX | 43–50 |
| No abstract method which means that the keyword is most likely used to prevent instantiation. Use a private or protected constructor instead. | 43–50 |
| Violation | Line |
|---|---|
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 55 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 56 |
| Violation | Line |
|---|---|
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 55 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 56 |
| Violation | Line |
|---|---|
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 55 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 56 |
| Violation | Line |
|---|---|
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 55 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 56 |
| Violation | Line |
|---|---|
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 55 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 56 |
| Violation | Line |
|---|---|
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 55 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 56 |
| Violation | Line |
|---|---|
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 55 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 56 |
| Violation | Line |
|---|---|
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 56 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 57 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 58 |
| Avoid appending characters as strings in StringBuffer.append. | 59 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 59 |
| Violation | Line |
|---|---|
| No abstract method which means that the keyword is most likely used to prevent instantiation. Use a private or protected constructor instead. | 43–50 |
| Abstract classes should be named AbstractXXX | 43–50 |
| Violation | Line |
|---|---|
| No abstract method which means that the keyword is most likely used to prevent instantiation. Use a private or protected constructor instead. | 43–49 |
| Abstract classes should be named AbstractXXX | 43–49 |
| Violation | Line |
|---|---|
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 56 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 57 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 58 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 59 |
| Avoid appending characters as strings in StringBuffer.append. | 59 |
| Violation | Line |
|---|---|
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 55 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 56 |
| Violation | Line |
|---|---|
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 55 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 56 |
| Violation | Line |
|---|---|
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 56 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 57 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 58 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 59 |
| Avoid appending characters as strings in StringBuffer.append. | 59 |
| Violation | Line |
|---|---|
| All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. | 46–58 |
| Violation | Line |
|---|---|
| Possible God class (WMC=101, ATFD=209, TCC=0.05263157894736842) | 34–545 |
| Use explicit scoping instead of the default package private level | 61–62 |
| Rather than using a lot of String arguments, consider using a container object for those values. | 77 |
| The method notify() has an NPath complexity of 1250 | 86–101 |
| Rather than using a lot of String arguments, consider using a container object for those values. | 86 |
| Rather than using a lot of String arguments, consider using a container object for those values. | 125 |
| The method sendUpdateDemand() has an NPath complexity of 200 | 134–158 |
| Rather than using a lot of String arguments, consider using a container object for those values. | 134 |
| Rather than using a lot of String arguments, consider using a container object for those values. | 161 |
| The method sendCreateDemandByUserGuid() has an NPath complexity of 6250 | 168–190 |
| Rather than using a lot of String arguments, consider using a container object for those values. | 168–169 |
| Rather than using a lot of String arguments, consider using a container object for those values. | 194 |
| Rather than using a lot of String arguments, consider using a container object for those values. | 202–203 |
| The method sendCreateDemandByIdCRMUser() has an NPath complexity of 6250 | 202–223 |
| Rather than using a lot of String arguments, consider using a container object for those values. | 441 |
| The method notifyV2() has an NPath complexity of 6250 | 441–460 |
| The method sendCreateDemandByUserGuidV2() has an NPath complexity of 31250 | 463–486 |
| Rather than using a lot of String arguments, consider using a container object for those values. | 463–464 |
| The method sendUpdateDemandV2() has an NPath complexity of 1000 | 506–533 |
| Rather than using a lot of String arguments, consider using a container object for those values. | 506–507 |
| Violation | Line |
|---|---|
| Use block level rather than method level synchronization | 56–107 |
| StringBuffer constructor is initialized with size 16, but has at least 20 characters appended. | 58 |
| StringBuffer (or StringBuilder).append is called 3 consecutive times with literal Strings. Use a single append with a single combined String. | 72 |
| Avoid concatenating nonliterals in a StringBuffer/StringBuilder constructor or append(). | 87 |
| Deeply nested if..then statements are hard to read | 92–95 |
| Violation | Line |
|---|---|
| A method/constructor shouldnt explicitly throw java.lang.Exception | 105 |
| A method/constructor shouldnt explicitly throw java.lang.Exception | 105 |
| Violation | Line |
|---|---|
| StringBuffer constructor is initialized with size 16, but has at least 275 characters appended. | 111 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 112 |
| StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. | 112 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 113 |
| Avoid appending characters as strings in StringBuffer.append. | 118 |
| StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. | 121 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 121 |
| Do not add empty strings | 132 |
| StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. | 134 |
| StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. | 144 |
