The following document contains the results of PMD 6.13.0.
| Rule | Violation | Line |
|---|---|---|
| FieldNamingConventions | The constant name '_listPrefixToRemove' doesn't match '[A-Z][A-Z_0-9]*' | 74 |
| FieldNamingConventions | The constant name '_listTypeAllowedForSearch' doesn't match '[A-Z][A-Z_0-9]*' | 75 |
| Rule | Violation | Line |
|---|---|---|
| FieldNamingConventions | The constant name '_dao' doesn't match '[A-Z][A-Z_0-9]*' | 50 |
| FieldNamingConventions | The constant name '_plugin' doesn't match '[A-Z][A-Z_0-9]*' | 51 |
| Rule | Violation | Line |
|---|---|---|
| FormalParameterNamingConventions | The method parameter name '_plugin' doesn't match '[a-z][a-zA-Z0-9]*' | 138 |
| Rule | Violation | Line |
|---|---|---|
| FieldNamingConventions | The field name 'id' doesn't match '_[a-z][a-zA-Z0-9]*' | 40 |
| FieldNamingConventions | The field name 'createdAt' doesn't match '_[a-z][a-zA-Z0-9]*' | 41 |
| FieldNamingConventions | The field name 'changeType' doesn't match '_[a-z][a-zA-Z0-9]*' | 42 |
| FieldNamingConventions | The field name 'customerId' doesn't match '_[a-z][a-zA-Z0-9]*' | 43 |
| FieldNamingConventions | The field name 'connectionId' doesn't match '_[a-z][a-zA-Z0-9]*' | 44 |
| FieldNamingConventions | The field name 'registrationToken' doesn't match '_[a-z][a-zA-Z0-9]*' | 45 |
| FieldNamingConventions | The field name 'tokenIssuer' doesn't match '_[a-z][a-zA-Z0-9]*' | 46 |
| Rule | Violation | Line |
|---|---|---|
| FieldNamingConventions | The constant name 'dao' doesn't match '[A-Z][A-Z_0-9]*' | 46 |
| FieldNamingConventions | The constant name 'plugin' doesn't match '[A-Z][A-Z_0-9]*' | 47 |
| Rule | Violation | Line |
|---|---|---|
| FieldNamingConventions | The field name 'customerId' doesn't match '_[a-z][a-zA-Z0-9]*' | 48 |
| FieldNamingConventions | The field name 'connectionId' doesn't match '_[a-z][a-zA-Z0-9]*' | 52 |
| FieldNamingConventions | The field name 'registrationToken' doesn't match '_[a-z][a-zA-Z0-9]*' | 57 |
| Rule | Violation | Line |
|---|---|---|
| ConstructorCallsOverridableMethod | Overridable method 'addMessage' called during object construction | 60 |
| Rule | Violation | Line |
|---|---|---|
| ClassNamingConventions | The utility class name 'Constants' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' | 39–80 |
| Rule | Violation | Line |
|---|---|---|
| ClassWithOnlyPrivateConstructorsShouldBeFinal | A class which only has private constructors should be final | 41–85 |
| FieldNamingConventions | The static field name 'instance' doesn't match '_[a-z][a-zA-Z0-9]*' | 44 |
| Rule | Violation | Line |
|---|---|---|
| ClassWithOnlyPrivateConstructorsShouldBeFinal | A class which only has private constructors should be final | 48–154 |
| FieldNamingConventions | The static field name 'instance' doesn't match '_[a-z][a-zA-Z0-9]*' | 51 |
| Rule | Violation | Line |
|---|---|---|
| ClassNamingConventions | The utility class name 'DeviceRegistrationValidator' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' | 48–73 |
| ClassWithOnlyPrivateConstructorsShouldBeFinal | A class which only has private constructors should be final | 48–73 |
| Rule | Violation | Line |
|---|---|---|
| AbstractClassWithoutAbstractMethod | This abstract class does not have any abstract methods | 44–266 |
| CommentRequired | Header comments are required | 44–266 |
| LooseCoupling | Avoid using implementation types like 'HashMap'; use the interface instead | 48 |
| UnusedPrivateField | Avoid unused private fields such as 'SQL_ASC'. | 62 |
| UnusedPrivateField | Avoid unused private fields such as 'SQL_DESC'. | 63 |
| Rule | Violation | Line |
|---|---|---|
| UncommentedEmptyConstructor | Document empty constructor | 64–67 |
| CommentRequired | Public method and constructor comments are required | 64–67 |
| CommentRequired | Public method and constructor comments are required | 69–74 |
| CommentRequired | Public method and constructor comments are required | 160–163 |
| CommentRequired | Public method and constructor comments are required | 165–168 |
| Rule | Violation | Line |
|---|---|---|
| TooManyMethods | This class has too many methods, consider refactoring it. | 52–317 |
| CallSuperInConstructor | It is a good practice to call super() in a constructor | 68–71 |
| UnnecessaryModifier | Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final | 79 |
| UnnecessaryModifier | Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final | 98 |
| UnnecessaryModifier | Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final | 112 |
| UnnecessaryModifier | Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final | 122 |
| UnnecessaryModifier | Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final | 148 |
| UnnecessaryModifier | Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final | 169 |
| UnnecessaryModifier | Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final | 189 |
| UnnecessaryModifier | Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final | 223 |
| UnnecessaryModifier | Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final | 255 |
| UnnecessaryModifier | Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final | 284 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Public method and constructor comments are required | 78 |
| CommentRequired | Public method and constructor comments are required | 94 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Enum comments are required | 36–40 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 38–118 |
| DataClass | The class 'DeviceRegistrationHistory' is suspected to be a Data Class (WOC=0.000%, NOPA=0, NOAM=14, WMC=14) | 38–118 |
| ShortVariable | Avoid variables with short names like id | 40 |
| ShortVariable | Avoid variables with short names like id | 53 |
| Rule | Violation | Line |
|---|---|---|
| DataClass | The class 'DeviceRegistrationHistoryDAO' is suspected to be a Data Class (WOC=0.000%, NOPA=4, NOAM=0, WMC=2) | 47–161 |
| CommentRequired | Header comments are required | 47–161 |
| CommentRequired | Public method and constructor comments are required | 57–60 |
| CallSuperInConstructor | It is a good practice to call super() in a constructor | 57–60 |
| UnnecessaryModifier | Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final | 65 |
| UnnecessaryModifier | Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final | 86 |
| UnnecessaryModifier | Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final | 130 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 43–76 |
| CommentRequired | Public method and constructor comments are required | 56–59 |
| CommentRequired | Public method and constructor comments are required | 61–64 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 41–57 |
| CommentRequired | Public method and constructor comments are required | 54 |
| CommentRequired | Public method and constructor comments are required | 56 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 44–84 |
| UnnecessaryAnnotationValueElement | Avoid the use of value in annotations when its the only element | 46 |
| UnnecessaryAnnotationValueElement | Avoid the use of value in annotations when its the only element | 50 |
| UnnecessaryAnnotationValueElement | Avoid the use of value in annotations when its the only element | 54 |
| CommentRequired | Public method and constructor comments are required | 59–61 |
| UncommentedEmptyConstructor | Document empty constructor | 59–61 |
| CommentRequired | Public method and constructor comments are required | 63–68 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 41–74 |
| UnnecessaryAnnotationValueElement | Avoid the use of value in annotations when its the only element | 43 |
| UnnecessaryAnnotationValueElement | Avoid the use of value in annotations when its the only element | 46 |
| UnnecessaryAnnotationValueElement | Avoid the use of value in annotations when its the only element | 49 |
| CommentRequired | Public method and constructor comments are required | 52–57 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 43–80 |
| UnnecessaryAnnotationValueElement | Avoid the use of value in annotations when its the only element | 45 |
| UnnecessaryAnnotationValueElement | Avoid the use of value in annotations when its the only element | 48 |
| CommentRequired | Public method and constructor comments are required | 51–54 |
| CommentRequired | Public method and constructor comments are required | 56–61 |
| CommentRequired | Public method and constructor comments are required | 68–74 |
| Rule | Violation | Line |
|---|---|---|
| MissingSerialVersionUID | Classes implementing Serializable should set a serialVersionUID | 41–67 |
| CommentRequired | Header comments are required | 41–67 |
| CommentRequired | Public method and constructor comments are required | 45–48 |
| CommentRequired | Public method and constructor comments are required | 50–54 |
| CommentRequired | Public method and constructor comments are required | 56–61 |
| Rule | Violation | Line |
|---|---|---|
| ShortVariable | Avoid variables with short names like ID | 46 |
| Rule | Violation | Line |
|---|---|---|
| UnnecessaryAnnotationValueElement | Avoid the use of value in annotations when its the only element | 74 |
| CommentRequired | Public method and constructor comments are required | 80–90 |
| UnnecessaryAnnotationValueElement | Avoid the use of value in annotations when its the only element | 96 |
| CommentRequired | Public method and constructor comments are required | 102–109 |
| UnnecessaryAnnotationValueElement | Avoid the use of value in annotations when its the only element | 115 |
| CommentRequired | Public method and constructor comments are required | 121–128 |
| Rule | Violation | Line |
|---|---|---|
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 140 |
| UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 150 |
| UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 153 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 45–72 |
| ShortVariable | Avoid variables with short names like e | 48 |
| ShortVariable | Avoid variables with short names like e | 58 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 41–85 |
| NonThreadSafeSingleton | Singleton is not thread safe | 60–63 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 48–154 |
| CommentRequired | Public method and constructor comments are required | 57–64 |
| NonThreadSafeSingleton | Singleton is not thread safe | 59–62 |
| UseObjectForClearerAPI | Rather than using a lot of String arguments, consider using a container object for those values. | 66 |
| CommentRequired | Public method and constructor comments are required | 66–79 |
| CommentRequired | Public method and constructor comments are required | 81–105 |
| UseObjectForClearerAPI | Rather than using a lot of String arguments, consider using a container object for those values. | 81 |
| CommentRequired | Public method and constructor comments are required | 107–129 |
| UseObjectForClearerAPI | Rather than using a lot of String arguments, consider using a container object for those values. | 131 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 133 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 48–73 |
| CommentRequired | Public method and constructor comments are required | 55–71 |
| Rule | Violation | Line |
|---|---|---|
| MissingSerialVersionUID | Classes implementing Serializable should set a serialVersionUID | 50–182 |
| CommentRequired | Header comments are required | 50–182 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 116 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the getItemsFromIds method if you want a default access modifier | 116 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 118–121 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the getPluginDefaultNumberOfItemPerPage method if you want a default access modifier | 118–121 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 128 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 141 |
| Rule | Violation | Line |
|---|---|---|
| MissingSerialVersionUID | Classes implementing Serializable should set a serialVersionUID | 58–147 |
| LooseCoupling | Avoid using implementation types like 'HashMap'; use the interface instead | 75 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 133–139 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the getItemsFromIds method if you want a default access modifier | 134–139 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 141–145 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the getPluginDefaultNumberOfItemPerPage method if you want a default access modifier | 142–145 |
| Rule | Violation | Line |
|---|---|---|
| MissingSerialVersionUID | Classes implementing Serializable should set a serialVersionUID | 59–332 |
| LooseCoupling | Avoid using implementation types like 'HashMap'; use the interface instead | 112 |
| UnusedPrivateField | Avoid unused private fields such as '_optionOrderBy'. | 113 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 125 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 166–172 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the getItemsFromIds method if you want a default access modifier | 167–172 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 174–178 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the getPluginDefaultNumberOfItemPerPage method if you want a default access modifier | 175–178 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 198 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| AbstractClassWithoutAbstractMethod | This abstract class does not have any abstract methods | 3 | 44–266 |
| CommentRequired | Header comments are required | 3 | 44–266 |
| LooseCoupling | Avoid using implementation types like 'HashMap'; use the interface instead | 3 | 48 |
| UnusedPrivateField | Avoid unused private fields such as 'SQL_ASC'. | 3 | 62 |
| UnusedPrivateField | Avoid unused private fields such as 'SQL_DESC'. | 3 | 63 |
| FieldNamingConventions | The constant name '_listPrefixToRemove' doesn't match '[A-Z][A-Z_0-9]*' | 1 | 74 |
| FieldNamingConventions | The constant name '_listTypeAllowedForSearch' doesn't match '[A-Z][A-Z_0-9]*' | 1 | 75 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UncommentedEmptyConstructor | Document empty constructor | 3 | 64–67 |
| CommentRequired | Public method and constructor comments are required | 3 | 64–67 |
| CommentRequired | Public method and constructor comments are required | 3 | 69–74 |
| CommentRequired | Public method and constructor comments are required | 3 | 160–163 |
| CommentRequired | Public method and constructor comments are required | 3 | 165–168 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| TooManyMethods | This class has too many methods, consider refactoring it. | 3 | 52–317 |
| CallSuperInConstructor | It is a good practice to call super() in a constructor | 3 | 68–71 |
| UnnecessaryModifier | Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final | 3 | 79 |
| UnnecessaryModifier | Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final | 3 | 98 |
| UnnecessaryModifier | Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final | 3 | 112 |
| UnnecessaryModifier | Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final | 3 | 122 |
| UnnecessaryModifier | Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final | 3 | 148 |
| UnnecessaryModifier | Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final | 3 | 169 |
| UnnecessaryModifier | Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final | 3 | 189 |
| UnnecessaryModifier | Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final | 3 | 223 |
| UnnecessaryModifier | Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final | 3 | 255 |
| UnnecessaryModifier | Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final | 3 | 284 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| FieldNamingConventions | The constant name '_dao' doesn't match '[A-Z][A-Z_0-9]*' | 1 | 50 |
| FieldNamingConventions | The constant name '_plugin' doesn't match '[A-Z][A-Z_0-9]*' | 1 | 51 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Public method and constructor comments are required | 3 | 78 |
| CommentRequired | Public method and constructor comments are required | 3 | 94 |
| FormalParameterNamingConventions | The method parameter name '_plugin' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 138 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Enum comments are required | 3 | 36–40 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 38–118 |
| DataClass | The class 'DeviceRegistrationHistory' is suspected to be a Data Class (WOC=0.000%, NOPA=0, NOAM=14, WMC=14) | 3 | 38–118 |
| ShortVariable | Avoid variables with short names like id | 3 | 40 |
| FieldNamingConventions | The field name 'id' doesn't match '_[a-z][a-zA-Z0-9]*' | 1 | 40 |
| FieldNamingConventions | The field name 'createdAt' doesn't match '_[a-z][a-zA-Z0-9]*' | 1 | 41 |
| FieldNamingConventions | The field name 'changeType' doesn't match '_[a-z][a-zA-Z0-9]*' | 1 | 42 |
| FieldNamingConventions | The field name 'customerId' doesn't match '_[a-z][a-zA-Z0-9]*' | 1 | 43 |
| FieldNamingConventions | The field name 'connectionId' doesn't match '_[a-z][a-zA-Z0-9]*' | 1 | 44 |
| FieldNamingConventions | The field name 'registrationToken' doesn't match '_[a-z][a-zA-Z0-9]*' | 1 | 45 |
| FieldNamingConventions | The field name 'tokenIssuer' doesn't match '_[a-z][a-zA-Z0-9]*' | 1 | 46 |
| ShortVariable | Avoid variables with short names like id | 3 | 53 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| DataClass | The class 'DeviceRegistrationHistoryDAO' is suspected to be a Data Class (WOC=0.000%, NOPA=4, NOAM=0, WMC=2) | 3 | 47–161 |
| CommentRequired | Header comments are required | 3 | 47–161 |
| CommentRequired | Public method and constructor comments are required | 3 | 57–60 |
| CallSuperInConstructor | It is a good practice to call super() in a constructor | 3 | 57–60 |
| UnnecessaryModifier | Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final | 3 | 65 |
| UnnecessaryModifier | Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final | 3 | 86 |
| UnnecessaryModifier | Unnecessary modifier 'final' on resource specification 'daoUtil': resource specifications are implicitly final | 3 | 130 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 43–76 |
| FieldNamingConventions | The constant name 'dao' doesn't match '[A-Z][A-Z_0-9]*' | 1 | 46 |
| FieldNamingConventions | The constant name 'plugin' doesn't match '[A-Z][A-Z_0-9]*' | 1 | 47 |
| CommentRequired | Public method and constructor comments are required | 3 | 56–59 |
| CommentRequired | Public method and constructor comments are required | 3 | 61–64 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 41–57 |
| CommentRequired | Public method and constructor comments are required | 3 | 54 |
| CommentRequired | Public method and constructor comments are required | 3 | 56 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 44–84 |
| UnnecessaryAnnotationValueElement | Avoid the use of value in annotations when its the only element | 3 | 46 |
| FieldNamingConventions | The field name 'customerId' doesn't match '_[a-z][a-zA-Z0-9]*' | 1 | 48 |
| UnnecessaryAnnotationValueElement | Avoid the use of value in annotations when its the only element | 3 | 50 |
| FieldNamingConventions | The field name 'connectionId' doesn't match '_[a-z][a-zA-Z0-9]*' | 1 | 52 |
| UnnecessaryAnnotationValueElement | Avoid the use of value in annotations when its the only element | 3 | 54 |
| FieldNamingConventions | The field name 'registrationToken' doesn't match '_[a-z][a-zA-Z0-9]*' | 1 | 57 |
| CommentRequired | Public method and constructor comments are required | 3 | 59–61 |
| UncommentedEmptyConstructor | Document empty constructor | 3 | 59–61 |
| CommentRequired | Public method and constructor comments are required | 3 | 63–68 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 41–74 |
| UnnecessaryAnnotationValueElement | Avoid the use of value in annotations when its the only element | 3 | 43 |
| UnnecessaryAnnotationValueElement | Avoid the use of value in annotations when its the only element | 3 | 46 |
| UnnecessaryAnnotationValueElement | Avoid the use of value in annotations when its the only element | 3 | 49 |
| CommentRequired | Public method and constructor comments are required | 3 | 52–57 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 43–80 |
| UnnecessaryAnnotationValueElement | Avoid the use of value in annotations when its the only element | 3 | 45 |
| UnnecessaryAnnotationValueElement | Avoid the use of value in annotations when its the only element | 3 | 48 |
| CommentRequired | Public method and constructor comments are required | 3 | 51–54 |
| CommentRequired | Public method and constructor comments are required | 3 | 56–61 |
| ConstructorCallsOverridableMethod | Overridable method 'addMessage' called during object construction | 1 | 60 |
| CommentRequired | Public method and constructor comments are required | 3 | 68–74 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| MissingSerialVersionUID | Classes implementing Serializable should set a serialVersionUID | 3 | 41–67 |
| CommentRequired | Header comments are required | 3 | 41–67 |
| CommentRequired | Public method and constructor comments are required | 3 | 45–48 |
| CommentRequired | Public method and constructor comments are required | 3 | 50–54 |
| CommentRequired | Public method and constructor comments are required | 3 | 56–61 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ClassNamingConventions | The utility class name 'Constants' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' | 1 | 39–80 |
| ShortVariable | Avoid variables with short names like ID | 3 | 46 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnnecessaryAnnotationValueElement | Avoid the use of value in annotations when its the only element | 3 | 74 |
| CommentRequired | Public method and constructor comments are required | 3 | 80–90 |
| UnnecessaryAnnotationValueElement | Avoid the use of value in annotations when its the only element | 3 | 96 |
| CommentRequired | Public method and constructor comments are required | 3 | 102–109 |
| UnnecessaryAnnotationValueElement | Avoid the use of value in annotations when its the only element | 3 | 115 |
| CommentRequired | Public method and constructor comments are required | 3 | 121–128 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 140 |
| UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 3 | 150 |
| UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 3 | 153 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 45–72 |
| ShortVariable | Avoid variables with short names like e | 3 | 48 |
| ShortVariable | Avoid variables with short names like e | 3 | 58 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 41–85 |
| ClassWithOnlyPrivateConstructorsShouldBeFinal | A class which only has private constructors should be final | 1 | 41–85 |
| FieldNamingConventions | The static field name 'instance' doesn't match '_[a-z][a-zA-Z0-9]*' | 1 | 44 |
| NonThreadSafeSingleton | Singleton is not thread safe | 3 | 60–63 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 48–154 |
| ClassWithOnlyPrivateConstructorsShouldBeFinal | A class which only has private constructors should be final | 1 | 48–154 |
| FieldNamingConventions | The static field name 'instance' doesn't match '_[a-z][a-zA-Z0-9]*' | 1 | 51 |
| CommentRequired | Public method and constructor comments are required | 3 | 57–64 |
| NonThreadSafeSingleton | Singleton is not thread safe | 3 | 59–62 |
| UseObjectForClearerAPI | Rather than using a lot of String arguments, consider using a container object for those values. | 3 | 66 |
| CommentRequired | Public method and constructor comments are required | 3 | 66–79 |
| CommentRequired | Public method and constructor comments are required | 3 | 81–105 |
| UseObjectForClearerAPI | Rather than using a lot of String arguments, consider using a container object for those values. | 3 | 81 |
| CommentRequired | Public method and constructor comments are required | 3 | 107–129 |
| UseObjectForClearerAPI | Rather than using a lot of String arguments, consider using a container object for those values. | 3 | 131 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 133 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ClassNamingConventions | The utility class name 'DeviceRegistrationValidator' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' | 1 | 48–73 |
| ClassWithOnlyPrivateConstructorsShouldBeFinal | A class which only has private constructors should be final | 1 | 48–73 |
| CommentRequired | Header comments are required | 3 | 48–73 |
| CommentRequired | Public method and constructor comments are required | 3 | 55–71 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| MissingSerialVersionUID | Classes implementing Serializable should set a serialVersionUID | 3 | 50–182 |
| CommentRequired | Header comments are required | 3 | 50–182 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 3 | 116 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the getItemsFromIds method if you want a default access modifier | 3 | 116 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 3 | 118–121 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the getPluginDefaultNumberOfItemPerPage method if you want a default access modifier | 3 | 118–121 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 128 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 141 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| MissingSerialVersionUID | Classes implementing Serializable should set a serialVersionUID | 3 | 58–147 |
| LooseCoupling | Avoid using implementation types like 'HashMap'; use the interface instead | 3 | 75 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 3 | 133–139 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the getItemsFromIds method if you want a default access modifier | 3 | 134–139 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 3 | 141–145 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the getPluginDefaultNumberOfItemPerPage method if you want a default access modifier | 3 | 142–145 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| MissingSerialVersionUID | Classes implementing Serializable should set a serialVersionUID | 3 | 59–332 |
| LooseCoupling | Avoid using implementation types like 'HashMap'; use the interface instead | 3 | 112 |
| UnusedPrivateField | Avoid unused private fields such as '_optionOrderBy'. | 3 | 113 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 125 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 3 | 166–172 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the getItemsFromIds method if you want a default access modifier | 3 | 167–172 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 3 | 174–178 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the getPluginDefaultNumberOfItemPerPage method if you want a default access modifier | 3 | 175–178 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 198 |
